Prevent empty credential to be added

Prevent empty credential to be added
(e.g. only rowneruuid is sent)

Patch #1: initial upload
Patch #2-3: fix arduino build error

Change-Id: I7802dcb76daab3269eb0a9638659087643b0c141
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13379
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 9366b7f721f6fe0c526832baf26b102984c7dcee)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13445

SVACE issue fixes

Change-Id: I4cd1fb23818a560449ae1ff3f2635c14ef093da7
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13435
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 2ee97889f591fccaec860fb7ae7d0d95148c9311)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13447

Update the return value of MOT releated API.

Change-Id: I97a6ee6f0b9eecafd2a28e717887a04decd9209d
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13449
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 1ae2de1ec129cd8ad6de9cabae7cccff755ff170)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13461

Update build script for RE android sample app.

When building of RE android sample app,
we need to execute of scons build and also need additional android studio build.
With this patch, can build android sample app by only scons build.

Change-Id: Ife7142cf89993531bc15bf4b9f655090f50a1bad
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13369
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

fix issues relates to wrong syncInfo received

Change-Id: I77f9ce5d0fa3e7c40e0fe390b42f210e5a188a50
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13451
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Multiple Ownership Transfer support.

[NOTE] This patch includes the following patches for MOT :
   https://gerrit.iotivity.org/gerrit/#/c/12063/
   https://gerrit.iotivity.org/gerrit/#/c/13375/
   https://gerrit.iotivity.org/gerrit/#/c/13341/
   https://gerrit.iotivity.org/gerrit/#/c/13343/

[Overview]
This patch is to support the multiple ownership transfer(MOT).
We assume the MOT authenticated client is the SubOwner.
SubOwner can access the ALL resources with full permsion except the DOXM, ACL and CRED.

This patch includes following changes :
1. Update the doxm resource to include MOT related properties.
   - New Properties
     . x.org.iotivity.mom : Mode of MOT
     . x.org.iotivity.subowneruuid : List of SubOwner
   - SubOwner has READ permission for DOXM.
   - The resource server will be update subowner list of doxm
     when MOT authentication successfully done.

2. Update the cred, acl resource to include MOT related property.
   - New Properties
     . x.org.iotivity.eowneruuid : entry owner uuid for each entry.
   - SubOwner should set the eowner as subowner's UUID
     when provision the ACL and CRED.
   - SubOwner can access only those resources that registered as eowner.

3. Update the PolicyEngine for SubOwner's access control as following :
   - DOXM : READ ONLY
   - CRED/ACL : SubOwner can access only those resources that registerd as eowner.
     . SubOwner can not provision ACL which is include the DOXM, CRED, ACL, PSTAT.
   - PSTAT : FULL permission
   - Application Resources : FULL permission

4. Add Preconfigured-PIN OxM

5. Update the sample codes
   - Test Preconfigured PIN based MOT
     1. Run the sampleserver_justworks
     2. Run the provisioningclient
     [On the provisioningclient]
     3. Perform the UnOwned Device discovery [Menu:11]
     4. Perform the OTM [Menu:20]
     5. Perform the Owned Device Discovery [Menu:12]
     6. Change the server's 'mode of MOT' [Menu:70]
     7. Perform the MOT enabled device discovery [Menu:13]
        - Check the discovered device list.
     8. POST the preconfigured-PIN credential [Menu:71]
         - sample's preconfigured-PIN is '12341234'
     9. Change the server's 'oxmsel' [Menu:72]
         - '3' is preconfigured-PIN OxM
     10. Run the subownerclient
     [On the subownerclient]
     11. Perform the MOT enabled device discovery [Menu:10]
         - Check the discovered device list.
     12. Perform the MOT [Menu:20]
     13. Perform the Multiple Owned device discovery [Menu:11]
         - Check the discovered device list.
     14. Perform the ACL provisioning TEST [Menu:40]

   - Test Random PIN based MOT
     1. Run the sampleserver_randompin
     2. Run the provisioningclient
     [On the provisioningclient]
     3. Perform the UnOwned Device discovery [Menu:11]
     4. Perform the OTM [Menu:20]
     5. Perform the Owned Device Discovery [Menu:12]
     6. Change the server's 'mode of MOT' [Menu:70]
     7. Run the subownerclient
     [On the subownerclient]
     8. Perform the MOT enabled device discovery [Menu:10]
         - Check the discovered device list.
     9. Perform the MOT [Menu:20]
         In case of random PIN based MOT, PIN input required.
     [On the sampleserver_randompin]
     10. Press 'G' or 'g' on the sampleserver_randompin.
         server will generate and display the random PIN.
     11. Input the server's PIN number on the subownerclient side.
     12. Perform the Multiple Owned device discovery [Menu:11]
         - Check the discovered device list.
     13. Perform the ACL provisioning TEST [Menu:40]
     14. Press 'E' or 'e' on the sampleserver_randompin to exit server.

Change-Id: I25d029839b3567455743031afafb34d2fc78278c
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13419
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix bug for invalid return variable.

Invalid return variable is fixed.
1. invalid boolean -> pointer
2. invalid pointer -> boolean

Change-Id: I16cb2338b28ba5bb725ed6eb8d640f04216f7933
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13317
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update discovery when connection was changed.

When connection state was changed try to unicast discovery.

Change-Id: I7fe8f16039e9ead5002282742d6e51d805fc9225
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13319
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Updated NS Sample App for testing Sync and sending complete NSMessage

Change-Id: I8bf14b020b1e5ec42dcf5710fe30a1b6beefbe4b
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix for Memory leak results from static analyzer for NS C++ Wrapper.

Change-Id: I97ca331ce6fcd7352350fd36426366433a5521a2
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13307
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix Build issue for soname for NS Libraries

Change-Id: I07416d904e5ac63bbb389081e99f6849acfff842
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13413
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

setting received  ttl value  by consumer.

Change-Id: I1de504edf851d39d761dfa2a189a77116fca8a85
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13387
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

fix issue related to wrong messageId

Change-Id: I6008dfe8fc3dc648841f0527e993bd698275f7e4
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13385
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Unit tests for SSL adapter update

Change-Id: Ib108dd1ce76632f1393383e6402e73c7ba2e60d7
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13349
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 2fe020f4bc86b7dcecc4a8853b7f772b591a010c)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13363

build: ignore debian generated files

Change-Id: I963a02a548344f5c6e9955a4286de595801e9f93
Origin: https://gerrit.iotivity.org/gerrit/#/c/11811/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12967
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit ee74ca52a64302ba39c2d5cce7762fbd4c35427d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11811

tizen: Use upstream packaging file as aligned

Note, for dependencies libraries.
It's easier to maintain them as patches over upstream git.

More details on downstream maintenance at:
https://wiki.iotivity.org/tizen

Change-Id: Id630e6a06bff11c750a106e8fc0cffb9a154f87b
Bug: https://review.tizen.org/gerrit/#/c/82260/
Origin: https://github.com/tizenteam/iotivity/tree/sandbox/pcoval/on/master/tizen
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11683
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11407

fix android build failure issue with WITH_CLOUD=1 and secure mode

Change-Id: I1f1cca166866fda08e2d644032eca7e721bf8db8
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12861
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit ec9364d7abdbd06a406d2028cdfa27b315aefffe)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13061

added error code (4.03 / 5.00) in ocstack result

Change-Id: I311c0b76a2faa7704be8f4a8b89088a0ae471c6a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13135
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: byonggon chun <bg.chun@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1388] fixed duplicate start server in EDR adapter.

when both mode(server and client) in App is set.
startDiscoveryServer and startListenningServer is calling.
and then both accept thread
and receive thread is running redundantly

Change-Id: I70395ace6115d52d28d2c034ea24c70aafeb671e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12799
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13065

modify about rule of coding.

this patch include,
1. modify if statement and while statement about rule of coding.
2. remove unused function.

Change-Id: I73117fcc15581dfaff435cd5922f14c91356c358
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13357
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Bug fix about result of static anlayzer.

this patch include,
bug fix about memory leak and coding idiom.

Change-Id: I6fba4a8b182ce88cda44571ebb490c7573812c01
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13267
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix crash in Android provisioning client App.

Catch exception in provision Android client for setDeviceId API.

Change-Id: I19918e47eac9f040d490e3805964c6cc7d5d3fba
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13345
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit add0610e0eafe8c51d669151fa77aeca5ee59bd6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13347

Update a logic to check an availability of cloud server resource

Rather than URI, resource type of the cloud server resource is more
confirmable to check the availability.

Change-Id: I61f3b63412b39fc56e993a3041ac007d0886368b
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13331
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Add null checking for observe request in easy setup

Checking if entityHandlerRequest is NULL is added.

Change-Id: I79bf75c9f53f28b9c0c679a5dd7371552764b5cd
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13323
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix for all discovered devices to include a secure port

This patch prevent to add the device that does not have a secure port to discovered device list

Change-Id: Ia7283b37b7820e045f4a51ad03395205b4240dd3
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13299
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 44d8220a5c20a0077cfc4c65fbd9919b37129278)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13303

IOT-1448 - Fix Windows x86 Build issue

The affected test were processing the windows
include files before the iotivity_config.h
could set the preprocessor config.

Update callback calling convention

Change-Id: I9adbfafef2c2e1b117a37ad9003ff53bb0450656
Signed-off-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13185
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Update the ACL delete mechanism as determined by OSWG.

After this patch,
If 'subject' not exist in the query string of DELETE request,
All ACE data will be removed.

Change-Id: Ife12c457b2029991168bf048bbfb90278ea4b3a2
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13265
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 8d7bb539d4325a857a8297a760348ccc0e1eb081)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13297

[IOT-1442] Apply the new ACL policy for device owner and resource owner.

According to new ACL policy,
Device owner's ACL should be provisioned while OTM.
For this reason, Ownership transfer manager should updates the owner's ACL while OTM.

- Patch #1 : Initial upload
- Patch #2 : Updated according to comments.
- Patch #3 : Rebase
- Patch #4 : Fixed a bug that occured during rebase.

Change-Id: I92a78e6145afdb3341582555739a64184bee65db
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12265
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 21c991f5a317bc1e3872bcb25a216e903352b40b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13275

Add license comment

Change-Id: I1374b2ee45e120bae756e1e2f975eba23fee24f4
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13291
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Added NULL check for GetDoxmResourceData

Change-Id: Iea981a40ebaccef368ae4cbd834c30cb124fd76c
Signed-off-by: sahil bansal <sahil.bansal@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13229
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 615726b1656173c4a6892ef28a6c3e664a0125ec)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13273

Keep ACL rowneruuid when POST payload does not have rowneruuid

Maintains the ACL rowneruuid when the payload of POST request
does not have rowneruuid

Change-Id: I52177b84ba9ced8b1078b3edea12256e23d6dfd8
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13257
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit b012422858a1834d1b3868dbf51f67bcebd613c1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13271

[IOT-1438] Solve Build issue on Tizen secured build through gbsbuild script

- add secured check logic into gbsbuild.sh file
- using this logic, check mbedtls file & apply the patch

Change-Id: I6d458ea599562216444582b78724a1b61023d6de
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13099
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 3f7b46b56356b3d8997fc56d5904a1e0e12d9c87)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13263

[IOT-1440] findResource() to return list of discovered resources.

OCPlatform::findResource() does not return all the discovered resources in single callback
even though it gets the whole discovery payload from RI C layer.

This change implements OCPlatform::findResourceList() API which does return all the parsed
resources in discovery payload in single callback.

Change-Id: Ic95541f7303a15eb676029e6f2ea4952e5e3ca3e
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13113
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fix bugs for result of static analizer.

1. Initializatioin of local variable is added.
2. Invalid memory double free is removed on error handling.

Change-Id: I2d4c8460dd1e81ef88f6119f79deeae09c7f01c8
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13201
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit bae888047c3313e742f2b56cbab3366b118762e4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13259

bug fix about memory leak.

this patch include,
bug fix for dynamic analyzer.

Change-Id: I4fc7ff7436ac6019abe3aaaf8467392068e0ad7d
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13253
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

IOT-1447 Fix scope_id usage

Never assume that a scope id and an interface index are the same.
Removed bad code from the tcp adapter; the scope id should always
be present in the addr string of a scoped IPv6 address, and is correctly
handled by CAConvertNameToAddr and CAConvertAddrToName.

Change-Id: I19f8739d7da2e7944e3904770ca0d8e914608ba2
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13181
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Update observe-request processing logic.

Change-Id: Icb5ae1a3f8c8e985570b30b0420cc6e7fe98ffdc
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13235
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Bug fix about memory leak.

this patch include,
bug fix for dynamic analyzer.

Change-Id: I9a36d496b76c9d712d80af45492f0e38a7aff4ea
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13243
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1392] Fix Android build for SECURE=0 and WITH_TCP=1

Change-Id: Ia4423b2ad9b2f0d38f95050aea5380d4bde70fae
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12761
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit ca322622fe08d67f39ae7b491038c1d6f040b8d1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12847
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

bug fix for response of topic and modify unittest.

this patch include,
1. bug fix for response of topic post case.
2. modify unittest about included interface type.

Change-Id: I5bba7ef93260c2c67f25d9d79455e383d6ea8c0c
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13219
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1444] Enabling handling observe requests for collection resource.

Change-Id: If72f5a85858240787dea2b307710f1167c14c68a
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13149
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Added SVACE Fixes for C++ wrapper Unit TCs

Change-Id: I09224a2bcd6e38c0d8cbb80caf5a0009161113d2
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13231
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove unnecessary define and files for SSL

1) Removed X.509 build option because it is enabled by default
2) Deleted DTLS and TLS adapter files because thay are included in SSL

Change-Id: I078c5b0c912801f17fa858d6fdd2abe39feed9f8
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13115
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13213

tizen: Ship only BSD licence from libcoap

libcoap-4.1.1 is also licenced LICENSE.GPL,
to avoid ambiguity, tizen use the more permissive one, BSD.

This patch can be reverted,
 if Tizen wants to ship all upstream licences

Change-Id: Idc77605c48322f36887cc502dc0be570e2562486
Origin: https://gerrit.iotivity.org/gerrit/#/c/12969/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12805
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

[IOT-1449] mbedTLS: Use wcslen instead of lstrlenW on Windows

lstrlenW is not allowed in Windows Store applications. Use wcslen
instead.

Also fix a nearby narrowing size_t to int conversion to make sure
it's safe.

Change-Id: I14d37b6a0d6c82444f4733f5d54bd8173ca62b71
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13183
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit aa49bbd28a78a486df9568b3867a373100e92e2f)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13207

Fix a faulty logic in PMSingleDeviceDiscovery

A device discovery transaction should be removed AFTER port discovery
is done or discovery time is expired.

Change-Id: I55062a3a8ef5187bf249d0afee2276e40c0f52d9
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13167
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 3c07416db2f0bd587fbe9e1619d0fe954bb6cfc1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13165

Set ACL Rowner to PT's Device ID in SRPProvisionACL

If Rowner of ACL to be provisioned in SRPProvisionACL is empty,
Set it to PT's Device ID

Patch #1: Initial upload
Patch #2: Jongsung's recommendation applied
Patch #3: Fix typo
Patch #4-5: GetDoxmDeviceID failure taken care of

Change-Id: I38886d32fd35f39370d4e5e46e39b66edfc0f003
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13037
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit e3a136f22d2c08a237b7b949d914a9f299fea3d8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13205

Cloud ACL Modifications

Modifications to Cloud ACL

Patch #1: ACE Id changed to UUID format
Patch #2: Changes modified DeleteACE & UpdateACE changes added
Patch #3: Oid check included in verifyAcl
Patch #4-5: OCCloudAclIndividualDeleteAce() added
Patch #6: Minor bug fixes
Patch #7: OCCloudAclIndividualUpdate() added

Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Change-Id: I6b3b4c68f06c43ce002df36a741ea4eb8549ba44
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12739
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 6c08489dfc353cb854f2d04c4648108c04d114b6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12785

[IOT-1446] Fix discovery failure issue

Change logic in the Policy Engine in order to resolve
discovery failure issue

Patch #1: Initial upload
Patch #2: Error message changed

Change-Id: I08ab1dec15cb0f49374d42d97b65a23fe885db39
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13173
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 5c78f31a2d4415c970f38db14e248bfef348a6b0)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13199

Updated Easysetup Security logic.

 - EnrolleeSecure resource not to re-created during previous request is processed
   for every security provisioning request to get callback from security-logic

Change-Id: I905b1cf708db68583a95bd9cad299212fa00ec84
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13077
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add logic about checking the NULL and modify warning code.

This patch include, check the NULL and modify warning code.

Change-Id: Ie28548563357e0c9565ecdcd776cce60d3d42f33
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13193
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modified CloudClient (CPP)

to use DEFAULT_PORT 5683

Change-Id: I32c5d5c7e373250ac2af3354c5a345a02d4cdbea
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12935
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13017

Unit tests for SSL adapter (ca_adapter_net_ssl.c)

Change-Id: Ia9bb81012159df0f1b5f87d80e821610aeaa44c1
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12349
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13179

[IOT-1441] Update DevOwner access policy to remove implicit access in RFPROV.

With this patch, the DevOwner now will only be able to access SVRs during
RFOTM or RESET states, unless of course there is an ACE installed allowing
explicit access to the DevOwner.

This behavior change is required by the Security Test Matrix v7, published
by the Security WG.

Patch 2: updated with JIRA ticket #

Patch 3: fixed logic bug found by Kevin

Patch 4: corrected commitmsg

Change-Id: I267c9eb78682bc810b7b2399f6606b8379d6e718
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13117
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 7958457e535a8a0d15f2a201109b137ba9bc6cf6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13137

Fixed bug for result of static analysis.

Change-Id: I6301a61d0e8fd8bfd21585a59455da50b2aabd14
Signed-off-by: Parkhi <h_w.park@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13141
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove unused old API.

 - delete registerSecurityCallbackHandler api.

Change-Id: I0d4c31af7ac9d5d25c260cf07f5ebf38381609ea
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13081
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1420] Solve that if, rt properties ommited

- add rt, if attributes to SceneListResource

Change-Id: I07017fbfb99755d182676e5a946fde505e121e66
Signed-off-by: ChaJiWon <jw_wonny.cha@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13105
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Added changes to remove build warning while building NS Jni Common files

Change-Id: I0631be24a2cdfeedaae61a02fb351f047f834ae7
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13177
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Unit Tests added for CoAP-HTTP Proxy module

Change-Id: I8554cd9010bbd27ef29f1615a53f62cda4e41d30
Signed-off-by: Rajendra <raje_ndra.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12615
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix bugs for result of dynamic analizer.

1. definitely losted memory was deallocated.
2. pthread creating type was modified for parameter deallocation.
3. invalid c-string copy was fixed.

Change-Id: Iab32535f164029ccd8a82d49968ce0a44e8b8bd1
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13169
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix auto_build.py on Python 2.7.10 for Windows

There are two fixes in this build.

* Prior to this change, Python was putting quotes around the SCons call.
  This behavior differs from Python 2.7.0.

* Prior to this change, "python auto_build.py" would try to build Android
  and fail.  Now we limit auto_build.py to only build Windows binaries on
  a Windows host.

Change-Id: I41ec4986c3dc57821cfdbe48f598e547e1934c71
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12841
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ajay Saini <ajay.saini@intel.com>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

[IOT-1333] Enable message queue(MQ) in tizen platform

Change-Id: Ic35205cbeaaa39108cce970324fa4172a980ba7f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12035
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Remove Disabled TC in CA layer.

Because this should no longer be a valid test.

Change-Id: I739aeafda6b9b86ac298247c19c7ad37dde89c3e
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13035
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

tizen: Scan for licences to be shipped in package

It's important to have this generated at buildtime,
 specially if tree is patched with missing dependencies,
 like those mentionned at:

 https://wiki.iotivity.org/build

Change-Id: Ie8d9dc0685ddc2df37545e92da4a662ee496bd07
Credit-to: Jaehong Jo <jaehong.jo@samsung.com>
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8177
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

tizen: Disable SECURED by default

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: I22e14a601d30b29005352a5154f617ed66ce1903
Origin: https://gerrit.iotivity.org/gerrit/#/c/12101/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12101
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12493
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Fix for IOT-1394.

In callbacks for GET, PUT, POST, and OBSERVE requests in
InProcClientWrapper.cpp (CPP layer of RI), the representation was parsed
only for success cases.

But when we are dealing with cloud responses,
they include a payload with error message and code even for error cases.

To catch those responses, we should ignore the status(OCStackResult)
of client response and let the error representation reach till application.

Change-Id: I103957bb79e948693807fc05e8bed461e6b2d8dd
Signed-off-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12831
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Change settings on deviceInfo and platformInfo in samples as per specs.

Bug: https://jira.iotivity.org/browse/IOT-1435
Change-Id: I9de03c0c6c09d4632503f9ad8f2943c9f1468527
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13051
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Update C API doxygen

C API description is updated for some fields such as subControllability.

Change-Id: Ie44c213657a9ffdd55ec386e8bc953bad709432d
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13075
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update and fix of  UnitTest for cpp-wrapper

1)Updated new unittest for consumer and provider
2)Fix for removing segmentation fault

Change-Id: If06e9606c405a3fa2dace726a5c9320399b06e66
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12943
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1430] bug fix for seg fault on start consumer.

With this patch, segmentation fault is resolved on the starting consumer service.

Change-Id: I929ec45d34a401ea7e6e503d6c686471656f39cf
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13005
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update Cpp Api doxygen

Change-Id: I4ed23e32956980d816c3a7e6bb0605272df2782f
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13145
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add doxygen comment for java api's of ProviderServicer and ConsumerService.

Change-Id: I149a714258db8495473064c98f270b9b01fd2497
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13011
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix bug for invalid remove a context at request.

When receive responce of getting topic information,
consumer serivce remove context manually.
But, it is the invalid way.
With this patch, consumer service does not remove manually.
Context will be removed automatically by RI layer.

Change-Id: I1278dc13bf297b95e513d364f243064b525a7083
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13063
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

change asynccall Function to synccall function.

this patch include,
1. change sync call about NSProviderSetConsumerTopic Function.
2. change sync call about NSProviderUnsetConsumerTopic Function.

second patch include,
modify invalid return value.

Change-Id: Ia73d6544489dd36f4612c97108ca488f76e038e3
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12991
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Bug fix about invalid parsing and modify sconscript.

this patch include,
1. Bug fix about invalid parsing in jni side
   and send notification was changed to once call.
2. Modify sconscript for android 6.0 devices

Change-Id: I9ae6d68ebf24d944e896db54949f86de62fc0f6e
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13067
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add device and platform information in sample codes.

Bug: https://jira.iotivity.org/browse/IOT-1384
Change-Id: I8f8e69716534dddb77d6069394267e730a02c14f
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12909
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

[IOT-1400] fix memory leak related presence in ocstack

Change-Id: Ib838532de9ab732fd1833d9423b2759c8aec0cf7
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12871
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 02fa07402283aa6922e4f3ff64c16cfedbfe47c6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13059

[IOT-1434] Fix memory leak related server request List.

when there is no response data for virtual reqeust in server.
it should be removed, since it never remove and
causes a big memory leak.

Change-Id: Ic65692ae8b2c1c27f554f466d00bd0cc1674118f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12947
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit d54b727a3f55d0238393fd14781e0723df4a9e17)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13057

Simple mapping between COAP response code and OCStackResult in comment

like below.
OC_STACK_OK = 0,                /** 203, 205*/
OC_STACK_RESOURCE_CREATED,      /** 201*/
OC_STACK_RESOURCE_DELETED,      /** 202*/

Change-Id: Ia03e07770c1855753cc7d781347bdec5376cd7ac
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12931
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1417] Fix Sign Up/In/Out Workflow

Change-Id: Icfadd8e40fcb8cbf8d962464d8bc1372b302d5c6
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13093
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 26c80763150b1689f2eaa8845569a7b1eab14c2a)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13125

Fixed [IOT-1414]

Propagate INVALID_CALLBACK  instead of INVALID_PARAM when Listener is null

Change-Id: Id41c9be5dc33e9220c4809351b8269738eb95f56
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12949
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit dc57a68c8a4eceb0efdf6786d48ce42f76305d8e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13015

[IOT-1396] Changed values of OicSecDpom_t to align with oic.sec.pomtype from Security Spec v1.1.12

The bitmask values for the pstat.om and pstat.sm properties were incorrectly
defined.  A few other files (including provisioning tool files) appeared to use
the values incorrectly, and are also fixed as part of this patch.

Patch #2: .json and .dat files changed accordingly
Patch #3: unittest svd db changed accordingly

Change-Id: Ie1d4b13a271eafea38b41313bba6e087b69a2f62
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12855
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 8c6fba5b2cf63e48466b8628fa4f542ac67bea58)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13003

[IOT-1405, IOT-1418] Bug fixes

Memory leak issue in Secure resources
scan newline '\n' at end of line

Change-Id: I8e7675fef88670ea6f4fc7c38a1b484cc6e28b50
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12951
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 0267c7ab809830f60d4110550f1f9c0bf8b0868f)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12999

[IOT-1395] Fix for rowneruuid update

[IOT-1395] Fix for rowneruuid update for CTT testing

Patch #1-2: rowneruuid update enabled
Patch #4: Logic modified

Change-Id: I2d6a53c1868e59ea112def5c45ed869b2b6d86da
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12807
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit dd82e65657fb6ef738b044a376d17f0ae86ed3ba)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12997

Add network monitor support for Windows

Also fix a memory leak in the Linux code

Change-Id: I8d243604a49cf4f2947849ac13624b2c044259d5
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12953
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Modify gradle version for building notification service.

Change-Id: I93557aac43c2d1c808495dff1120cff737ccea44
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13103
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Common adapter for DTLS/TLS

Format of a certificate changed, so previous X.509 parser
is not able to parse new certificates provided by Cloud:
1) For DTLS and TLS used mbedTLS
2) CKManager removed

Change-Id: Icacf60237a8ce15e996c4bbe4769a230b39c770e
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
X-Origin-Change-Id: I6b47f7b3439b923ec12f26b0e159e3b7a1144658
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12029
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13095
Reviewed-by: Kevin Kane <kkane@microsoft.com>

Disable security version discovery

Change-Id: I22183fc82ef953f2fe49966406488d491de18ada
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13083
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[IOT-1380] Use BCryptGenRandom on Windows

Patch mbedTLS to use BCryptGenRandom on Windows.
Add the mbedtls subtree to .gitignore.

Change-Id: I23367aac194de2531299badc466a0d39e46eda4d
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12725
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

cloud server crl

Change-Id: Ic920258819ae8ebcc14592279c07b2069a6525ff
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12635
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 5a3f96d0dcb17c0b40738392e9c04dc4b6225cc2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13033

Remove build warning realted MQ in android JNI.

There is a redefined proprocessor in JniOnMQSubscribeListener.h
since octypes.h has it. it should be removed

------------------------------warning---------------------------------------
jni/JniOnMQSubscribeListener.h:26:0: warning: "MAX_SEQUENCE_NUMBER" redefined
 #define MAX_SEQUENCE_NUMBER 0xFFFFFF
----------------------------------------------------------------------------

Change-Id: If57b79b963d700459a59d2fb8704a60ad019e838
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12857
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

tizen: Add iotivity namespace for headers

Currently symlink to parent folder,
 this way it's aligned to yocto recipe.

In longer term it would be nice to rely on scons install rules.

Change-Id: Ie8067c13302ccf92936d599bb4f6b3740d3cf009
Bug: https://jira.iotivity.org/browse/IOT-524
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12149
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 5a494b98d65b2950a9331ec77b03ce429ba64cde)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12485

Add ECDSA to cipher suite selection menu

Change-Id: I74efcab80da86123540e5355378ab3b1bb343718
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12889
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13031

RC3 svace fix (cloudClient + crlresource.c)

Change-Id: Ic6093286d89daf6de10ed617c445fbc53d8a3bd1
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12829
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13029

[IOT-1352] SampleApp(CloudClient) goes into infinite loop while testing some features

Change-Id: Ib173abc1968051e2a8ef3dc70e1bbff14bc4d732
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12569
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13027
Reviewed-by: Kevin Kane <kkane@microsoft.com>

[IOT-1347] OCCloudAclIdCreate or OCCloudAclIdGetByDevice API doesn't provide the ACL ID Directly

Print aclId, gid, gp in external callbacks (application level, provisioning/sample module)
Print acl, crl, group id list, invite response too.

Change-Id: Ifb9f4ee996030894a31b4317c98a8159e345218b
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12563
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13023

Split cloudClient to Client & Server part

1) Server part creates LED resource
2) Only Client part supports d2d requests

Change-Id: I335f7556a1ef247526886175ebcf400cd9e19b99
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12057
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11781

Update a response representation according to requested interface in easy setup

Referred jira ticket:
[IOT-1408] -
  [ES] Common properties are not exist
[IOT-1410] -
  [ES] /ProvisioningResURI does not support properly for Retrieve
       with interface query

Change-Id: Icb2c8bb5e3c9d796e7f09a7bdd23e895c1f2352d
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12987
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

add logic for invalid char

this patch include,
add logic for invalid char in notificationprovider example only.
sometimes, input variable has an incorrect value.

Change-Id: Id8fa6152a7a7f15ef5d54425daf896680d6c9447
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12979
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add curl license file

CURL license file is attached so that an example is used the licensed code.

Change-Id: I65e5e136e042329fa6350a7660a24bc5cd3b22ba
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13009
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>