Matt Mitchell [Tue, 24 Feb 2015 18:49:49 +0000 (10:49 -0800)]
Two random fixes
* Use uname -s on mac
* Don't print "Running ..." for pal tests (will still print failures). Cuts down on noise in output.
Matt Mitchell [Tue, 24 Feb 2015 17:01:13 +0000 (09:01 -0800)]
Merge pull request #325 from kyulee1/switchtest
add a switch test
Stephen Toub [Tue, 24 Feb 2015 16:45:48 +0000 (11:45 -0500)]
Merge pull request #331 from stephentoub/redirect_ole32
Redirect mscorlib's ole32.dll P/Invokes to libcoreclr
Stephen Toub [Tue, 24 Feb 2015 15:23:01 +0000 (10:23 -0500)]
Redirect ole32.dll P/Invokes to libcoreclr
When FEATURE_PAL is defined, mscorlib P/Invokes to kernel32 and user32 are being redirected to libcoreclr.so (at least for now as a bring-up mechanism). However, P/Invokes to ole32.dll aren't being redirected (CoCreateGuid, CoTaskMemAlloc, etc.) even though all of the ones that are used exist in the PAL. This causes failures any time Guid.NewGuid is called, any time the StubHelpers string marshalers are used, etc.
This commit just adds ole32.dll to the set of libraries for which mscorlib redirects its P/Invokes to libcoreclr.
Kyungwoo Lee [Mon, 23 Feb 2015 20:41:16 +0000 (12:41 -0800)]
Add a switch test to cover Jit codegen.
This is a test case to cover switch expansion in Reader.
Matt Mitchell [Tue, 24 Feb 2015 01:19:57 +0000 (17:19 -0800)]
Merge pull request #287 from mmitche/output-paths
Place binaries and intermediates in folders that include OS
Matt Mitchell [Tue, 24 Feb 2015 00:34:11 +0000 (16:34 -0800)]
Place binaries and intermediates in folders that include OS
Rework the output paths so that the OS may appear in them. This then follows the same form as corefx. This solves a number of problems:
1) When building unix mscorlib after the regular build, we would use the wrong intermediates for incremental.
2) When testing windows after building unix mscorlib we'd use the wrong outputs and fail.
This change removes our cmake directory and moves cmake generated files into intermediates (under OS/arch paths)
The reason is that the intermediates go under here when actually doing the build, and on unix based systems, we need to generate the cmake files for different builds into different directories for the purpose of preserving incremental builds.
Change clean behavior
Clean should simply delete the root binary. We also should not make assumptions about
whether necessary directories are available when we begin to build and should create them every time if
necessary.
Create directories as needed.
Rich Lander [Mon, 23 Feb 2015 23:20:50 +0000 (15:20 -0800)]
Merge pull request #320 from richlander/rich-build
Clarify Visual Studio pre-req
Stephen Toub [Mon, 23 Feb 2015 22:15:55 +0000 (17:15 -0500)]
Merge pull request #326 from stephentoub/mres_datetime
Change MRES to use DateTime.UtcNow instead of Now
Stephen Toub [Mon, 23 Feb 2015 20:44:23 +0000 (15:44 -0500)]
Change MRES to use DateTime.UtcNow instead of Now
In debug builds, ManualResetEventSlim is storing the last time that Set and Reset are called, using DateTime.Now. This in turn requires time zone information, which is currently not implemented on Unix, causing any usage of ManualResetEventSlim.Set/Reset in a debug build to throw a NotImplementedException.
This change just switches the usage to be DateTime.UtcNow instead of DateTime.Now to avoid the need for time zone information. I was tempted to remove these debug-only fields entirely, but in case someone's actually using them during debugging, doesn't seem particularly harmful to leave them.
Bengu Li [Mon, 23 Feb 2015 17:32:50 +0000 (09:32 -0800)]
Merge pull request #322 from libengu/AltJitNameChange
Change alternative JIT name to LLILC
Bengu Li [Sun, 22 Feb 2015 21:28:45 +0000 (13:28 -0800)]
Allow alternative JIT configurable.
Bengu Li [Sun, 22 Feb 2015 17:45:50 +0000 (09:45 -0800)]
Change alternative JIT name to LLILC
Richard Lander [Sun, 22 Feb 2015 02:05:26 +0000 (18:05 -0800)]
Clarify Visual Studio pre-req
Jan Kotas [Sun, 22 Feb 2015 00:51:12 +0000 (16:51 -0800)]
Merge pull request #317 from janvorli/fix-cfi-annotation
Fix cfi annotation for NDirectImportThunk and JIT_RareDisableHelper
Pat Gavlin [Sun, 22 Feb 2015 00:26:43 +0000 (16:26 -0800)]
Merge pull request #319 from pgavlin/FixClangWarnings
Fix warnings generated when building with Clang on Linux.
Pat Gavlin [Sat, 21 Feb 2015 18:23:28 +0000 (10:23 -0800)]
Fix warnings generated when building with Clang on Linux.
There were three classes of warnings that needed to be fixed:
1) Warnings for unused typedefs
2) Warnings for pointer to boolena conversions that were always true
3) Warnings for taking the absolute value of unsigned values
(1) accounted for the majority of the warnings. All of these warnings
originated from macro definitions debugreturn.h, staticcontract.h,
or pal_assert.h. In the first two cases, typedefs were used as
compile-time checks to ensure certain invariants inside of method or
function bodies. These cases were addressed by using an empty member
of the typedef under an "if (0)" guard. In the third case, typedefs
were used for compile-time assertions that may appear in any location
in a source file; these have been updated to use C++11's static_assert.
(2) and (3) were much more straightforward: the former was addressed by
explicitly comparing the source pointer against NULL and the latter by
removing the offending calls to abs().
This change also contains a small update to .gitignore to ignore the
binaries directory and CMake artifacts created by build.sh.
Rich Lander [Sat, 21 Feb 2015 15:56:47 +0000 (07:56 -0800)]
Merge pull request #316 from richlander/master
Add dotnet standards doc
Jan Vorlicek [Sat, 21 Feb 2015 01:20:44 +0000 (02:20 +0100)]
Merge pull request #312 from janvorli/pal-exception-tests
Enable several PAL exception tests
Jan Vorlicek [Sat, 21 Feb 2015 01:16:27 +0000 (02:16 +0100)]
Fix cfi annotation for NDirectImportThunk and JIT_RareDisableHelper
The title says all
Pat Gavlin [Sat, 21 Feb 2015 00:41:27 +0000 (16:41 -0800)]
Merge pull request #313 from pgavlin/LibUnwindCheck
Move the error that is emitted when libunwind is missing into CMake.
Rich Lander [Sat, 21 Feb 2015 00:34:40 +0000 (16:34 -0800)]
Add dotnet standards doc
Pat Gavlin [Fri, 20 Feb 2015 23:53:39 +0000 (15:53 -0800)]
Move the error that is emitted when libunwind is missing into CMake.
This provides a friendlier user experience when libunwind is not
installed, as configuration fails earlier than the build does.
Jan Vorlicek [Fri, 20 Feb 2015 23:28:15 +0000 (00:28 +0100)]
Remove duplicate check for number of exception arguments
I have added a check for the exception arguments in my last commit, but it turns
out there was already one, only in a wrong place. So the exceptionRecord.NumberParameters
was set incorrectly to the unclipped value.
Jan Vorlicek [Fri, 20 Feb 2015 23:05:06 +0000 (00:05 +0100)]
Merge pull request #308 from janvorli/exception-handling
Reimplement native exception handling for PAL
Jan Vorlicek [Fri, 20 Feb 2015 22:58:05 +0000 (23:58 +0100)]
Enable several PAL exception tests
This change enables several PAL exception tests to test the
new exception handling stuff.
Jan Vorlicek [Fri, 20 Feb 2015 22:30:54 +0000 (23:30 +0100)]
Merge pull request #310 from kangaroo/issue-307
Check for libunwind in configure
Jan Vorlicek [Fri, 20 Feb 2015 21:13:24 +0000 (22:13 +0100)]
Cleanup more
I am removing few other things from the seh-unwind.cpp. First, the code that verified the
stack unwindibility actually couldn't work since in most cases, it would reach a managed
frame and then get screwed. It happened to few people in the recent past and they
were mislead into thinking that it is a problem of the coreclr unwinder.
There is no reasonable way to find out whether a frame is managed or native inside PAL,
that's why I am removign that stuff.
Also, there was now unused vectored exception handling stuff that I am also removing.
Another change is in the pal.h / pal.cpp where the type of the argv parameter was
const char **argv, which prevented passing in char** (the compiler was ok with it in C,
but failed in C++). I have changed it to const char * const *argv, which allows
passing in the char** as well.
Jan Vorlicek [Fri, 20 Feb 2015 19:19:02 +0000 (20:19 +0100)]
Add comments to PAL_TRY, PAL_EXCEPT etc.
This change just adds comments to those methods.
Geoff Norton [Fri, 20 Feb 2015 17:25:16 +0000 (09:25 -0800)]
Improve error messaging to be a bit more helpful on linux
Sergiy Kuryata [Fri, 20 Feb 2015 17:04:05 +0000 (09:04 -0800)]
Merge pull request #302 from dotnet-bot/from-tfs
Merge changes from TFS
Geoff Norton [Fri, 20 Feb 2015 16:53:55 +0000 (08:53 -0800)]
Unwind also needs _DEFAULT_SOURCE, in fact most everything does. Lets move it to toplevel
Geoff Norton [Fri, 20 Feb 2015 16:32:03 +0000 (08:32 -0800)]
Check for libunwind in configure, and setup seh-unwind to have possible other future alternatives
Jan Vorlicek [Fri, 20 Feb 2015 15:16:48 +0000 (16:16 +0100)]
Add missing dummy PAL_CheckVirtualUnwind in Release
With the previous commit, I haven't noticed that the dummy PAL_CheckVirtualUnwind() is now
missing in the release build. Adding it back.
Jan Kotas [Fri, 20 Feb 2015 14:46:36 +0000 (06:46 -0800)]
Merge pull request #309 from jkotas/deadcode
Delete dead code
Jan Vorlicek [Fri, 20 Feb 2015 14:27:55 +0000 (15:27 +0100)]
Reflect PR feedback
Remove few classes / macros from pal.h that are not used anymore.
Fix some line continuation backslash identations.
Jan Kotas [Fri, 20 Feb 2015 13:51:46 +0000 (05:51 -0800)]
Delete dead code
Jan Vorlicek [Fri, 20 Feb 2015 12:36:45 +0000 (13:36 +0100)]
Reimplement native exception handling for PAL
This change removes the preexisting exception handling in PAL that was simulating Windows
SEH using a lot of low level machinery. The only remaining part is the code that raises
the exception and that extracts the exception context information.
The PAL_TRY, PAL_EXCEPT, PAL_FINALLY, ... macros are reimplemented using plain C++ exception
handling.
Wes Haggard [Fri, 20 Feb 2015 03:12:06 +0000 (19:12 -0800)]
Update README.md
Fixed broken contributing guide link.
AlexGhiondea [Fri, 20 Feb 2015 01:27:59 +0000 (17:27 -0800)]
Merge pull request #294 from AlexGhiondea/localPublish
Setup the CoreCLR repo to use the LocalPackagePublish mechanism.
John Chen [Thu, 19 Feb 2015 20:53:11 +0000 (12:53 -0800)]
OS bug 1704585: WoW64 breakpoint in crossgen!debugError when compiling ARMCHK
Remove call to DebugBreak when crossgen encounters a case not supported by MDIL. Such scenarios are expected in production.
Also fixed an uninitialized field in ZapperOptions, which caused some warnings from crossgen to be lost.
[tfs-changeset: 1418191]
Alex Ghiondea [Thu, 19 Feb 2015 00:26:30 +0000 (16:26 -0800)]
Setup the CoreCLR repo to use the LocalPackagePublish mechanism.
This will enable the 'local publish' of the CoreCLR package to a location where
it can be picked up by the CoreFx build. What this means is that you will be able
to build the CoreCLR package and use that to run the CoreFx tests on top of it.
Changes required to make this happen:
- Refactor the managed build to make sure the buildtools gets restored before
we attempt to use the targets it provides.
- Take a dependency to the Microsoft.DotNet.BuildTools to bring in the packages.targets
- Update the $(PackagesDir) to point to the <repo root>\packages to make it consistent with CoreFx
- Hook-up the LocalPackagePublish targets to the build of the CoreCLR NuGet packages
Jan Kotas [Thu, 19 Feb 2015 03:38:20 +0000 (19:38 -0800)]
Merge pull request #271 from kangaroo/more-va_list-safety
Remove PAL_printf_arg_remover
Jan Vorlicek [Thu, 19 Feb 2015 01:08:34 +0000 (02:08 +0100)]
Merge branch 'unix_issue177'
Jan Vorlicek [Wed, 18 Feb 2015 10:36:37 +0000 (11:36 +0100)]
Reflect CR feedback
Rename VirtualUnwind in PAL to PAL_VirtualUnwind
Move .cfi annotation inside macros and update PROLOG_WITH_TRANSITION_BLOCK
to use these macros. I've verified that the annotation is correct by
stepping through the asm code and verifying that the stack trace is
correct at every instruction.
Matt Ellis [Wed, 18 Feb 2015 05:34:28 +0000 (21:34 -0800)]
Merge pull request #292 from ellismg/remove-unix-specific-encoding-workaround
Remove Unix specific hack in Encoding.GetEncoding
Sergiy Kuryata [Wed, 18 Feb 2015 04:18:09 +0000 (20:18 -0800)]
Merge pull request #289 from kangaroo/master
Fix redefine of HAVE_FTRUNCATE_LARGE_LENGTH_SUPPORT
Matt Ellis [Wed, 18 Feb 2015 03:53:41 +0000 (19:53 -0800)]
Remove Unix specific hack in Encoding.GetEncoding
During Hello World bring-up for Unix, we ran into a crash which at the
time I thought was incorrectly due to some missing support in
globalization leading to a first chance exception being thrown.
Instead the problem was that due to a JIT bug, a hashtable that the
Encodings code tried to construct was getting bad data passed to the
constructor which caused an exception to try to be thrown. The change
I provided caused the hashtable codepath to not be taken and hence
masked the issue.
Now that the JIT bug is fixed, we can remove this workaround. I
verified that HelloWorld still runs on Unix with these changes.
Jan Vorlicek [Wed, 18 Feb 2015 00:54:15 +0000 (01:54 +0100)]
Merge pull request #284 from kangaroo/unix_issue177
Refactor libunwind to work on osx
Geoff Norton [Tue, 17 Feb 2015 23:51:53 +0000 (15:51 -0800)]
Fix redefint of HAVE_FTRUNCATE_LARGE_LENGTH_SUPPORT
Geoff Norton [Tue, 17 Feb 2015 21:02:44 +0000 (13:02 -0800)]
Move the UNWIND_CONTEXT_IS_UCONTEXT_T check into cmake as well
Geoff Norton [Tue, 17 Feb 2015 20:50:09 +0000 (12:50 -0800)]
Merge branch 'master' into unix_issue177
Conflicts:
src/pal/src/config.h.linux
src/pal/src/config.h.osx
src/pal/src/exception/seh-unwind.cpp
Geoff Norton [Tue, 17 Feb 2015 02:02:17 +0000 (18:02 -0800)]
Refactor linux libunwind to work on osx
libunwind on linux exposes the unw_context_t directly as a
ucontext_t, but on OSX its an opaque data structure. Additionally
UNW_REG_SP is read/write on OSX, but read-only on Linux. As such
we need to diverge the libunwind code a bit depending on what flavor
we are running on. There is one OSXTODO around the context pointers,
since we do not have unw_get_save_loc on OSX.
Sergiy Kuryata [Tue, 17 Feb 2015 17:18:15 +0000 (09:18 -0800)]
Merge pull request #283 from kangaroo/issue-281
The ftruncate tests eat up a lot of disk space, and build time -- disabl...
Geoff Norton [Tue, 17 Feb 2015 00:52:55 +0000 (16:52 -0800)]
The ftruncate tests eat up a lot of disk space, and build time -- disable them
Rich Lander [Mon, 16 Feb 2015 20:50:15 +0000 (12:50 -0800)]
Merge pull request #278 from richlander/richlander-ecma
Add type loader doc
Sergiy Kuryata [Mon, 16 Feb 2015 18:42:07 +0000 (10:42 -0800)]
Merge pull request #272 from kangaroo/pal-cleanup
PAL cleanup
Matt Mitchell [Mon, 16 Feb 2015 16:51:45 +0000 (08:51 -0800)]
Merge pull request #279 from richlander/richlander-ecma6
Update ECMA links to 6 ed
Jan Vorlicek [Mon, 16 Feb 2015 14:43:50 +0000 (15:43 +0100)]
Implement native stack unwinding for Linux
This change implements native stack unwinding using the libunwind on
Linux. I have also fixed bunch of issues / details in the related code:
1) 0x in front of %p inside format string
2) Subtraction of -1 from dl_info.dli_sname
3) Added .cfi_xxxx annotation to the CallDescrWorkerInternal and the
LEAF_ENTRY / LEAF_END macros.
4) Changed local labels in the CallDescrWorkerInternal to be prefixed by
.L to see the CallDescrWorkerInternal in the stack trace
5) Changed moveOWord to use movdqu - it was being called with one of the
parameters unaligned
Rich Lander [Mon, 16 Feb 2015 06:31:39 +0000 (22:31 -0800)]
Update ECMA links to 6 ed
dotnet-bot [Mon, 16 Feb 2015 06:14:13 +0000 (22:14 -0800)]
Add type loader doc
Rich Lander [Mon, 16 Feb 2015 05:27:56 +0000 (21:27 -0800)]
Merge pull request #277 from jonorossi/patch-1
Fixed syntax error in example code in mscorlib.md
Jonathon Rossi [Mon, 16 Feb 2015 05:17:17 +0000 (15:17 +1000)]
Fixed syntax error in example code in mscorlib.md
Jan Kotas [Sun, 15 Feb 2015 06:57:34 +0000 (22:57 -0800)]
Merge pull request #274 from richlander/master
Add authors to code guide
Rich Lander [Sun, 15 Feb 2015 05:46:48 +0000 (21:46 -0800)]
Add authors to code guide
Geoff Norton [Sat, 14 Feb 2015 21:12:03 +0000 (13:12 -0800)]
Remove PowerPC
Geoff Norton [Sat, 14 Feb 2015 21:10:15 +0000 (13:10 -0800)]
Remove solaris support
Geoff Norton [Sat, 14 Feb 2015 21:07:35 +0000 (13:07 -0800)]
Clean up pal configure stage
This commit removes a bunch of dead checks in the configure stage, as well
as fixing inconsistencies in HAVE_FTRUNCATE_LENGTH_ISSUE/HAVE_FTRUNCATE_LENGTH_BUG
off_t in file.cpp was declared after the goto, making it a protected scope, so it
needed to be moved up.
Geoff Norton [Sat, 14 Feb 2015 19:07:24 +0000 (11:07 -0800)]
Remove PAL_printf_arg_remover - what its doing is against the standards, and breaks on some platforms
Jan Kotas [Sat, 14 Feb 2015 07:35:17 +0000 (23:35 -0800)]
Merge pull request #269 from dotnet-bot/from-tfs
Merge changes from TFS
Jan Kotas [Sat, 14 Feb 2015 07:11:31 +0000 (23:11 -0800)]
Merge pull request #268 from kangaroo/master
di can be built, but still cannot be linked.
Jan Kotas [Sat, 14 Feb 2015 07:10:22 +0000 (23:10 -0800)]
Fix x86 build break
[tfs-changeset: 1415626]
Geoff Norton [Sat, 14 Feb 2015 06:01:19 +0000 (22:01 -0800)]
di can be built, but still cannot be linked.
Jan Kotas [Sat, 14 Feb 2015 03:09:36 +0000 (19:09 -0800)]
Merge pull request #266 from jkotas/simplify-ifdefs
Simplify platform ifdefs
Sergiy Kuryata [Sat, 14 Feb 2015 03:02:28 +0000 (19:02 -0800)]
Merge pull request #255 from kangaroo/pal-config-with-cmake
Refactor the PAL build configuration to detect at configure time
Jan Kotas [Sat, 14 Feb 2015 02:18:27 +0000 (18:18 -0800)]
Fixed comments, replaced references to Evanesco with ARM
Jan Kotas [Sat, 14 Feb 2015 01:02:03 +0000 (17:02 -0800)]
Merge pull request #267 from dotnet-bot/from-tfs
Merge changes from TFS
Geoff Norton [Fri, 13 Feb 2015 23:48:22 +0000 (15:48 -0800)]
Correct the return values for the ungetc check
Eugene Zemtsov [Fri, 13 Feb 2015 23:40:00 +0000 (15:40 -0800)]
Improve workaround description and limit it to just MS compiler
[tfs-changeset: 1415470]
Matt Mitchell [Fri, 13 Feb 2015 22:45:19 +0000 (14:45 -0800)]
Merge pull request #265 from mmitche/debug-dev-package
When building debug, author the development package with an appropriate name
Jan Kotas [Fri, 13 Feb 2015 22:14:10 +0000 (14:14 -0800)]
Simplify platform ifdefs
Simplify platform ifdefs like #if defined(_WIN64) || defined(_TARGET_ARM_) to #if !defined(_TARGET_X86_) based on @BruceForstall suggestion
Stephen Toub [Fri, 13 Feb 2015 21:22:47 +0000 (16:22 -0500)]
Merge pull request #261 from stephentoub/fix_semaphore
Implement CreateSemaphoreExA/W via CreateSemaphoreA/W
Geoff Norton [Fri, 13 Feb 2015 05:00:22 +0000 (21:00 -0800)]
Refactor the PAL build configuration to detect at configure time
The current PAL has binary check-ins of the config.h for Linux and MAC, long
term this is not sustainable. This is a first pass at cleaning this up.
Please note, there are some static platform independent defines as I tried to
keep consistency with the current outputs of the not-checked-in configure.in.
As we clean up the PAL the CMakeLists should be revisited and redundant pieces
removed.
Stephen Toub [Fri, 13 Feb 2015 20:36:51 +0000 (15:36 -0500)]
Implement CreateSemaphoreExA/W
Any managed code that touches the ThreadPool is currently crashing when the ThreadPool tries to initialize. This is due to it creating a semaphore via CreateSemaphoreExA/W in the pal, and those functions not being implemented.
This commit just implements those functions by delegating to their non-Ex counterparts. With this change, ThreadPool.QueueUserWorkItem, Task.Run, etc. are able to successfully schedule work and have it executed.
Matt Mitchell [Fri, 13 Feb 2015 20:26:31 +0000 (12:26 -0800)]
When building debug, author the development package with an appropriate name
AlexGhiondea [Fri, 13 Feb 2015 19:27:20 +0000 (11:27 -0800)]
Merge pull request #262 from AlexGhiondea/produceDevPackage
Update the CoreCLR nuspec to deploy the files under the aspnetcore5 folder
Alex Ghiondea [Fri, 13 Feb 2015 18:56:56 +0000 (10:56 -0800)]
Update the CoreCLR nuspec to deploy the files under the aspnetcore5 folder.
Matt Mitchell [Fri, 13 Feb 2015 18:47:53 +0000 (10:47 -0800)]
Merge pull request #245 from poizan42/fix-rm-intermediates
Fix wrong flag to rm when deleting intermediates folder.
Matt Mitchell [Fri, 13 Feb 2015 18:46:57 +0000 (10:46 -0800)]
Merge pull request #251 from shahid-pk/issue-243
Correctly locate Clang [Fixes 250]
Matt Mitchell [Fri, 13 Feb 2015 18:46:08 +0000 (10:46 -0800)]
Merge pull request #260 from henrybw/henrybw-define-complus
Add definition of "COMPLUS" to the glossary
Henry Baba-Weiss [Fri, 13 Feb 2015 17:08:05 +0000 (09:08 -0800)]
Add definition of "COMPLUS" to the glossary
In the same vein as "COR" and "URT", the terms "COM+"/"COMPLUS" appear frequently throughout the codebase, most notably in config settings (e.g. "COMPLUS_DefaultVersion"). I couldn't find any other explanation for what this means, and since I remember learning about it myself by asking older members of the team, I thought it would be helpful to have this documented for newcomers to the codebase.
Jan Vorlicek [Fri, 13 Feb 2015 15:31:38 +0000 (16:31 +0100)]
Merge pull request #259 from janvorli/linux-issue177
Modify the windows amd64 unwinder to work as jitted code unwinder on Uni...
Jan Vorlicek [Fri, 13 Feb 2015 10:33:23 +0000 (11:33 +0100)]
Modify the windows amd64 unwinder to work as jitted code unwinder on Unix
Update the windows amd64 unwinder from its source to the latest version
and add context pointers updating that was excluded before.
Change methods of the OOPStackUnwinder and OOPStackUnwinderAMD64 to be
static, since the base class has no data members and the unwinding is
always using the processor specific subclass.
Modify the code so that it is built in two flavors. The first one
is the DAC flavor which is used by the debugger. The second one will be
used for jitted code stack frames unwinding on non-Windows systems.
Jan Vorlicek [Fri, 13 Feb 2015 09:53:38 +0000 (10:53 +0100)]
Merge pull request #258 from sergiy-k/fix-sscanf-parsing
Fix sscanf implementation in PAL
Sergiy Kuryata [Fri, 13 Feb 2015 08:29:53 +0000 (00:29 -0800)]
Fix sscanf implementation in PAL
Implementation of sscanf was incorrectly handling cases where the input format was in the form of \93%2c\94, \93%2s\94, or \93%[\93 which could result in an access violation. The problem was that sscanf was calling sscanf_s with incorrect set of arguments. Implementation of sscanf_s expects to find the size of the target buffer in the list of its parameters but that parameter was not present in some cases. This change fixes this issue and re-enables previously disabled sscanf tests.
Matt Ellis [Fri, 13 Feb 2015 05:52:13 +0000 (21:52 -0800)]
Merge pull request #254 from ellismg/remove-locale-cpp
Remove locale.cpp from the PAL on OSX
Rich Lander [Fri, 13 Feb 2015 05:33:29 +0000 (21:33 -0800)]
Merge pull request #246 from akoeplinger/fix-botr
Improvements to docs
shahid-pk [Fri, 13 Feb 2015 00:00:11 +0000 (05:00 +0500)]
Correctly locate Clang [Fixes 243]
Addressing comments
Matt Ellis [Fri, 13 Feb 2015 02:23:02 +0000 (18:23 -0800)]
Remove locale.cpp from the PAL on OSX
The globalization plans no longer require these methods to be
implemented in the PAL, since we no longer call into the VM for
globalization support except on Windows.
It's possible that more stuff can be cleaned up here, and not just for
OSX, but I need to take a careful look at the use of codepages across the
runtime to understand if it's still needed.
Matt Ellis [Fri, 13 Feb 2015 02:01:18 +0000 (18:01 -0800)]
Merge pull request #252 from dotnet-bot/from-tfs
Merge changes from TFS