halcanary [Wed, 13 Aug 2014 14:14:36 +0000 (07:14 -0700)]
Fix Flate Test, also cleanup
- Remove SkData double-unref to fix assert.
- Re-enable the test with DEBUG (was disabled due to double-unref assert).
- SkRandom instead of rand() for thread-safety.
- General clean up of the test for readability.
Motivation: I am investigating turning on SkFlate::HaveFlate on Windows.
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
464333002
rmistry [Wed, 13 Aug 2014 13:11:09 +0000 (06:11 -0700)]
Add stephana@ to the list of Skia CQ commiters.
Note: This will take effect only after the Skia CQ is restarted
NOTRY=True
(SkipBuildbotRuns)
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
469753002
rmistry [Wed, 13 Aug 2014 12:36:43 +0000 (05:36 -0700)]
Whitespace change to test the CQ commit message
(SkipBuildbotRuns)
TBR=
BUG=chromium:308792
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
470603002
george [Wed, 13 Aug 2014 01:00:47 +0000 (18:00 -0700)]
Add a parameter GR_ALWAYS_ALLOCATE_ON_HEAP to allow for only ever creating temporary buffers on the heap instead of allowing stack allocation
Unfortunately this can't be a GR_GL_* config like we'd discussed because there are SkAutoSMalloc buffers that are built outside of gl/
R=bsalomon@google.com, bsalomon
BUG=skia:
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/
459263003
dandov [Wed, 13 Aug 2014 00:14:57 +0000 (17:14 -0700)]
Proposal for the mesh gradient interface. Implemented as a grid of
patches and uses 4 private arrays to store the values of the control points and
colors. When it needs a patch at a certain position of the grid it just
builds it using the corresponding values of the array and the
grid coordinates provided. Details on implementation are documented in the corresponding classes' comments.
Also added a gm for mesh gradients.
BUG=skia:
R=egdaniel@google.com, reed@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
451723003
borenet [Tue, 12 Aug 2014 20:02:26 +0000 (13:02 -0700)]
whitespace
BUG=skia:
TBR=bungeman
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
461123002
krajcevski [Tue, 12 Aug 2014 19:48:18 +0000 (12:48 -0700)]
Turn off pedantic blit rect
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
460253003
fmalita [Tue, 12 Aug 2014 19:24:17 +0000 (12:24 -0700)]
Add missing DRAW_PICTURE_MATRIX_PAINT paint offset.
Also remove explicit gPaintOffsets sizing to make the existing compile
time size check effective.
R=reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
467683003
tomhudson [Tue, 12 Aug 2014 18:05:29 +0000 (11:05 -0700)]
Update path to Android font config file
In version LMP, Android is expected to change the path to their font
configuration file (and condense several files into one), as well as
changing the format (qv http://crrev.com/
446473003/). This patch tries
the new path before falling back to the old path.
The new fonts are incompatible with assumptions made by the old
SkFontConfigInterfaceAndroid, so this patch MUST NOT land until
https://crrev.com/
462073002/ or the equivalent has turned on the
new SkFontManager.
BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
458543002
tomhudson [Tue, 12 Aug 2014 17:55:09 +0000 (10:55 -0700)]
Turn on FontMgr for Android
Minimal change for activating the SkFontMgr on Android, broken out
of http://crrev.com/
445143002/.
BUG=chromium:400801
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
462073002
robertphillips [Tue, 12 Aug 2014 17:12:40 +0000 (10:12 -0700)]
Update tools for use of picture stats in GPU optimization decision
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
466733004
halcanary [Tue, 12 Aug 2014 16:28:57 +0000 (09:28 -0700)]
Replace LLU with ULL to make VS2012 work again.
R=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
458663004
halcanary [Tue, 12 Aug 2014 16:07:08 +0000 (09:07 -0700)]
Revert of SkImage::NewFromGenerator(SkImageGenerator*), and a unit test. (https://codereview.chromium.org/
465823003/)
Reason for revert:
Mac bots are failing
Original issue's description:
> SkImage::NewFromGenerator(SkImageGenerator*), and a unit test.
>
> Committed: https://skia.googlesource.com/skia/+/
186f7b04956a1742f185a4ca69b44b52bc50e7fc
R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
453723003
tfarina [Tue, 12 Aug 2014 16:03:16 +0000 (09:03 -0700)]
Migrate SkRTConfRegistry test to DEF_TEST().
BUG=None
TEST=dm --tests=true --gms=false
R=mtklein@google.com, bsalomon@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
444303002
dandov [Tue, 12 Aug 2014 15:34:29 +0000 (08:34 -0700)]
SkCanvas::drawPatch param SkPoint[12]
drawPatch now receives as parameter const SkPoint cubics[12]
Adjusted derived classes and serialization.
Ajusted GM's and benches that take into account combinations of optional
parameters, the scale of the patch and 4 different types of patches.
Planning on adding the extra functionality of SkPatch in another CL.
BUG=skia:
R=egdaniel@google.com, reed@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
463493002
epoger [Tue, 12 Aug 2014 15:30:09 +0000 (08:30 -0700)]
rebaseline_server: periodically log tasks_queue size
Without this, it's hard to tell whether the server is stuck (or why it's taking so long).
NOTRY=true
R=stephana@google.com, rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
454953002
epoger [Tue, 12 Aug 2014 15:29:05 +0000 (08:29 -0700)]
change setA/setB labels if viewing actuals vs expectations
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
451053004
Brian Salomon [Tue, 12 Aug 2014 15:19:54 +0000 (11:19 -0400)]
Mark degeneratesegments GM as flakly on nvpr/ubuntu/debug
BUG=skia:2826
Review URL: https://codereview.chromium.org/
456653005
Brian Salomon [Tue, 12 Aug 2014 15:10:35 +0000 (11:10 -0400)]
Rebaseline current failures and those ignored for GPU rect change.
BUG=skia:
Review URL: https://codereview.chromium.org/
460343003
halcanary [Tue, 12 Aug 2014 15:04:58 +0000 (08:04 -0700)]
SkImage::NewFromGenerator(SkImageGenerator*), and a unit test.
R=reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
465823003
caryclark [Tue, 12 Aug 2014 14:46:33 +0000 (07:46 -0700)]
fix pathops skp-derived bugs; add more failing tests
TBR=
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
463883002
tomhudson [Tue, 12 Aug 2014 14:42:16 +0000 (07:42 -0700)]
Fix lower-casing error in font config parser
The Android font config parser was missing some SkAutoAsciiToLC
instantiations; this was discovered in https://crrev.com/
458543002/
but should land independently.
BUG=chromium:400801
R=bungeman@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
465973002
krajcevski [Tue, 12 Aug 2014 14:26:25 +0000 (07:26 -0700)]
Change GR_COMPRESS_ALPHA_MASK from compile-time flag to run-time. We do this by introducing an Options struct to be passed to a GrContext on creation.
R=robertphillips@google.com, bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
459033002
mtklein [Tue, 12 Aug 2014 14:01:25 +0000 (07:01 -0700)]
SkTileGrid: store insertion order, return results sorted by that.
This removes the need to assume the void* are SkPictureStateTree::Data*.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
466503002
bsalomon [Tue, 12 Aug 2014 13:58:16 +0000 (06:58 -0700)]
Make comment ASCII in GrDrawTarget.h
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRYS=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
458383004
halcanary [Tue, 12 Aug 2014 13:53:28 +0000 (06:53 -0700)]
Revert of SkImage_Codec is Lazy (https://codereview.chromium.org/
460823002/)
Reason for revert:
breaks chromium - no SkDecodingImageGenerator::Create
Original issue's description:
> SkImage_Codec is Lazy
>
> Committed: https://skia.googlesource.com/skia/+/
e36f499110da8c2e2aa05227bee6deb967309ead
R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
461043002
reed [Tue, 12 Aug 2014 13:53:09 +0000 (06:53 -0700)]
re-add samplerstress gm, but use blurmaskfilter instead (std filter)
BUG=skia:
R=robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
468483002
halcanary [Tue, 12 Aug 2014 13:37:21 +0000 (06:37 -0700)]
SkImage_Codec is Lazy
R=reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
460823002
reed [Tue, 12 Aug 2014 12:50:10 +0000 (05:50 -0700)]
remove SkStippleMaskFilter - no external clients
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/
462013002
caryclark [Tue, 12 Aug 2014 12:49:37 +0000 (05:49 -0700)]
relax quadratic binary search test
Extreme implicit quartic equations solve to roots that are different
enough that they appear to have failed. In this case, fall back on
binary searching to find an intersection.
Relax the condition when this happens; don't give up just because the
computed implicit root points aren't remotely the same.
TBR=reed
BUG=skia:2808
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
456383003
robertphillips [Tue, 12 Aug 2014 12:35:58 +0000 (05:35 -0700)]
Add layer counting to SkPictureRecord
This will be used for a SkPicture::suitableForOptimization entry point.
Committed: https://skia.googlesource.com/skia/+/
4a2b2e8ed2e35171bf98bad68a69daaced11ec7c
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
464433002
thakis [Mon, 11 Aug 2014 22:27:24 +0000 (15:27 -0700)]
Let skia build with clang's integrated assembler.
1. vuzpq is a gcc instruction. Replace it with the equivalent vuzp
(see http://llvm.org/PR20423)
2. .func / .endfunc only have an effect with -gstabs, which we don't
use. As it's unused and clang doesn't support it, remove
.func / .endfunc (also see http://llvm.org/20424)
BUG=chromium:124610
R=mtklein@google.com
Author: thakis@chromium.org
Review URL: https://codereview.chromium.org/
461693004
mtklein [Mon, 11 Aug 2014 22:20:23 +0000 (15:20 -0700)]
Revert of Add layer counting to SkPictureRecord (https://codereview.chromium.org/
464433002/)
Reason for revert:
DM's all segfaulty
http://108.170.220.120:10117/builders/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/builds/3866/steps/RunDM/logs/stdio
Original issue's description:
> Add layer counting to SkPictureRecord
>
> This will be used for a SkPicture::suitableForOptimization entry point.
>
> Committed: https://skia.googlesource.com/skia/+/
4a2b2e8ed2e35171bf98bad68a69daaced11ec7c
R=bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
452673003
robertphillips [Mon, 11 Aug 2014 21:45:38 +0000 (14:45 -0700)]
Add layer counting to SkPictureRecord
This will be used for a SkPicture::suitableForOptimization entry point.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
464433002
bsalomon [Mon, 11 Aug 2014 21:19:09 +0000 (14:19 -0700)]
Consider index8 a compressed config.
R=krajcevski@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
457333004
cdalton [Mon, 11 Aug 2014 21:05:05 +0000 (14:05 -0700)]
Wrap NV_path_rendering API with GrGLPathRendering
Adds a GrGLPathRendering class that wraps the NV_path_rendering
extension and manages its various API versions. It also provides
backup implementations when certain NVpr methods from later API
versions are not present on the current system.
BUG=skia:
R=bungeman@google.com, bsalomon@google.com, kkinnunen@nvidia.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
444223002
joshualitt [Mon, 11 Aug 2014 20:55:34 +0000 (13:55 -0700)]
2D kernel initial wiring for Guassian
BUG=skia:
R=senorblanco@chromium.org, bsalomon@chromium.org, bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
418223009
krajcevski [Mon, 11 Aug 2014 20:34:22 +0000 (13:34 -0700)]
Add BlitRect to SkTCompressedAlphaBlitter
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
456873003
halcanary [Mon, 11 Aug 2014 20:08:27 +0000 (13:08 -0700)]
clean up render_pdfs:
Remove unused headers
replace dynamic memory wstream with null wstream.
Use SkAutoTDelete when appropriate.
Replace PdfRenderer class with short function: pdf_to_stream.
Collapse render_pdf, process_input, tool_main_core functions
Split out process_input_files function.
Don't crash when no arguments given.
print out max rss on each skp.
prettier output
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
463603002
reed [Mon, 11 Aug 2014 20:03:55 +0000 (13:03 -0700)]
mark all SkImage methods const, so we can make it thread-safe
BUG=skia:
R=mtklein@google.com, halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
453613003
cdalton [Mon, 11 Aug 2014 19:43:28 +0000 (12:43 -0700)]
Fix crash in nvpr text after abandoning context
Don't implement GlyphPathRange::onAbandon/onRelease. Its path range is
also a GrGpuResource, registered with the gpu, and will automatically
handle abandoning and releasing the actual GL objects. Don't delete
the path range early, it is assumed to be a valid pointer throughout
the entire lifetime of GlyphPathRange.
BUG=skia:
R=bsalomon@google.com, kkinnunen@nvidia.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
452273003
Brian Salomon [Mon, 11 Aug 2014 19:36:43 +0000 (15:36 -0400)]
Mark convex_poly_clip as flaky on msaa16/win8 bots. Add more tests to ignored_tests.txt after GPU rect change.
BUG=skia:
Review URL: https://codereview.chromium.org/
460023002
mtklein [Mon, 11 Aug 2014 19:05:59 +0000 (12:05 -0700)]
More SkTileGrid refactoring.
I've rearranged the code a bit more and added more notes.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
463593003
halcanary [Mon, 11 Aug 2014 18:33:51 +0000 (11:33 -0700)]
Process Statistics header, add max RSS to render_pdfs
Committed: https://skia.googlesource.com/skia/+/
6274baae7fe82ce6481da367687aa6168356e1e1
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
448993003
tomhudson [Mon, 11 Aug 2014 18:28:00 +0000 (11:28 -0700)]
Parses sample code provided by Android project. Attempts to keep FontFamily data structures produced consistent with expectations of previous versions of Skia.
R=bungeman@google.com, djsollen@google.com, palmer@chromium.org, reed@google.com, hcm@google.com, tomhudson@google.com
BUG=400801
Committed: https://skia.googlesource.com/skia/+/
07544757c9fcf0f359f1686a3779eb2e75dd5b36
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
446473003
bsalomon [Mon, 11 Aug 2014 18:07:48 +0000 (11:07 -0700)]
Always use both a color and coverage attribute in GrAARectRenderer.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
435743002
bungeman [Mon, 11 Aug 2014 17:53:29 +0000 (10:53 -0700)]
Actually use test configuration in SkFontMgr on Android.
BUG=chromium:401954
R=tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
461673002
mtklein [Mon, 11 Aug 2014 17:09:34 +0000 (10:09 -0700)]
De-parameterize SkNextDatumFunction.
Just a simple refactor to make it clear we're only using this
one method and this one type.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
465523002
thakis [Mon, 11 Aug 2014 16:52:32 +0000 (09:52 -0700)]
Replace a pre-UAL instruction with its modern form.
See the notes in the Chromium bug, and http://llvm.org/20427
BUG=chromium:124610,skia:900
R=djsollen@google.com, mtklein@google.com
Author: thakis@chromium.org
Review URL: https://codereview.chromium.org/
455903002
robertphillips [Mon, 11 Aug 2014 16:50:11 +0000 (09:50 -0700)]
Cleaning up SkPicture-related classes
R=mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
459043002
reed [Mon, 11 Aug 2014 15:28:24 +0000 (08:28 -0700)]
add localMatrix to gradient Descriptor
this consolidation will also help transisition to new flattening pattern, where we want to
have a flatten/unflatten method on all of the common gradient params (i.e. Descriptor).
BUG=skia:
R=egdaniel@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
461643002
Brian Salomon [Mon, 11 Aug 2014 15:21:25 +0000 (11:21 -0400)]
Remove bleed test from ignored-tests.txt
BUG=skia:
Review URL: https://codereview.chromium.org/
463503004
mtklein [Mon, 11 Aug 2014 15:08:43 +0000 (08:08 -0700)]
Plumbing for using a BBH in SkRecordDraw.
For now this only creates a degenerate bounding box hierarchy where all ops
just have maximal bounds. I will flesh out FillBounds in future CL(s).
Not quite sure why QuadTree and TileGrid aren't drawing right---haven't even
looked at the diffs yet---so I've disabled those test modes for now. RTree
seems fine, so that'll at least get us coverage for all this new plumbing.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
454123003
Brian Salomon [Mon, 11 Aug 2014 14:22:10 +0000 (10:22 -0400)]
Rebase convex_poly_clip test on Win8 msaa16
BUG=skia:
Review URL: https://codereview.chromium.org/
458243002
bungeman [Mon, 11 Aug 2014 14:19:56 +0000 (07:19 -0700)]
Fix string assert and dead code which caused it.
Running tools with a '--' parameter caused SkString to assert here
incorrectly. SkString::remove should allow the entire contents of a
string to be removed.
The code in the flags parser which caused this call is dead and should
be removed.
R=mtklein@google.com, reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
453333002
reed [Mon, 11 Aug 2014 13:35:48 +0000 (06:35 -0700)]
Revert of Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/
457253002/)
Reason for revert:
webkit has been updated, so re-landing
Original issue's description:
> Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/
456203002/)
>
> Reason for revert:
> still need to update ProfilingCanvas in blink
>
> Original issue's description:
> > remove (now unneeded) legacy onDrawPicture variant
> >
> > TBR=fmalita@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/
2e69d292e5a389db7d9264eb66172376692de8ca
>
> TBR=
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/
47f9bdcc3d741a63935c52bfe85db44ab13f66f2
R=reed@chromium.org
TBR=reed@chromium.org
NOTREECHECKS=true
NOTRY=true
Author: reed@google.com
Review URL: https://codereview.chromium.org/
460693002
robertphillips [Mon, 11 Aug 2014 13:03:42 +0000 (06:03 -0700)]
Remove Matrix/Clip State collapse code
Given recent & upcoming changes (e.g., removal of save flags & SkRecord picture backend) this will have to be reimplemented.
R=fmalita@google.com, fmalita@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
453133003
reed [Mon, 11 Aug 2014 02:04:01 +0000 (19:04 -0700)]
Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/
456203002/)
Reason for revert:
still need to update ProfilingCanvas in blink
Original issue's description:
> remove (now unneeded) legacy onDrawPicture variant
>
> TBR=fmalita@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
2e69d292e5a389db7d9264eb66172376692de8ca
TBR=
NOTREECHECKS=true
NOTRY=true
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
457253002
reed [Sun, 10 Aug 2014 18:28:46 +0000 (11:28 -0700)]
remove (now unneeded) legacy onDrawPicture variant
TBR=fmalita@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
456203002
kevin.petit [Sat, 9 Aug 2014 18:22:54 +0000 (11:22 -0700)]
Fix S32A_D565_Opaque for RGBA on arm64
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:2813
R=halcanary@google.com, djsollen@google.com, mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
458453002
reed [Sat, 9 Aug 2014 18:08:05 +0000 (11:08 -0700)]
add drawPicture variant that takes a matrix and paint
will need some staging strategy, since chrome and blink have overrides of onDrawPicture
R=robertphillips@google.com, fmalita@google.com, bsalomon@google.com, mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
448793004
bensong [Sat, 9 Aug 2014 17:19:22 +0000 (10:19 -0700)]
manual bench rebase after 8d9153f, adjusted with
e530eb370c084336b584a6dff5a9e6974d932dfa
TBR=bungeman@google.com
Bypassing trybots:
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
451293002
bensong [Fri, 8 Aug 2014 22:59:30 +0000 (15:59 -0700)]
manual bench rebase after 8d9153f
R=bungeman@google.com
TBR=bungeman@google.com
Bypassing trybots:
NOTRY=true
BUG=skia:2819
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
454223002
Mike Klein [Fri, 8 Aug 2014 21:28:53 +0000 (17:28 -0400)]
Restore bench_util.py
BUG=skia:2819
Review URL: https://codereview.chromium.org/
450253003
reed [Fri, 8 Aug 2014 19:51:24 +0000 (12:51 -0700)]
add dummy onDrawPicture to allow migration for chrome overrides
after this lands in chrome, land these two CLs
https://codereview.chromium.org/
454993002/
https://codereview.chromium.org/
454143003
then land this skia CL
https://codereview.chromium.org/
448793004/
then remove the onDrawPicture overrides from chrome
R=fmalita@google.com, robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
457753002
humper [Fri, 8 Aug 2014 19:11:33 +0000 (12:11 -0700)]
add an animated test to verify that high-quality identity scaling doesn't change the image
BUG=skia:
R=reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
454913002
bungeman [Fri, 8 Aug 2014 19:06:51 +0000 (12:06 -0700)]
Blink layout tests all assume it can provide custom font configuration files on every platform. In moving Android to the font manager, we broke those.
They're ugly, but this patch reinstates them.
R=tomhudson@google.com, djsollen@google.com, reed@google.com
TBR=reed@google.com
BUG=chromium:401954
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
451093002
humper [Fri, 8 Aug 2014 19:06:13 +0000 (12:06 -0700)]
short circuit high quality scales that are actually the identity
transform
BUG=skia:
R=reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
456843002
mtklein [Fri, 8 Aug 2014 18:49:39 +0000 (11:49 -0700)]
Make BBH::search() const.
I'd like to have SkRecordDraw() work with a const SkBBoxHierarchy*, but
can't quite today. The only interesting change here is no longer flushing
if needed in RTree; instead we assert we've been flushed already.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
452233002
humper [Fri, 8 Aug 2014 18:45:46 +0000 (11:45 -0700)]
add a simple ascii-art debug thing for AA clips
BUG=skia:
R=reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
450423002
krajcevski [Fri, 8 Aug 2014 18:38:27 +0000 (11:38 -0700)]
Add R11 KTX GM
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
456873002
hendrikw [Fri, 8 Aug 2014 17:44:33 +0000 (10:44 -0700)]
Moved SkPictureContentInfo into its own file. It now tracks the number of skia
operations (maybe, I'm not 100% sure I'm doing this right yet) and the number
of text draws. I also moved some of the gpu logic out of SkPictureRecord and
into SkPictureContentInfo,
http://code.google.com/p/chromium/issues/detail?id=396908
http://code.google.com/p/chromium/issues/detail?id=397198
http://code.google.com/p/chromium/issues/detail?id=399728
BUG=396908
R=nduca@chromium.org, mtklein@chromium.org, robertphillips@google.com, mtklein@google.com
Author: hendrikw@chromium.org
Review URL: https://codereview.chromium.org/
435093003
mtklein [Fri, 8 Aug 2014 17:05:19 +0000 (10:05 -0700)]
SkRecord: Strip out cull-skipping and y-only drawPosTextH skipping.
These optimizations are outclassed by a general bounding-box hierarchy,
and are just going to make plugging that into SkRecordDraw more complicated.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
452983002
joshualitt [Fri, 8 Aug 2014 16:41:42 +0000 (09:41 -0700)]
Pretty print of shaders
BUG=skia:
R=bsalomon@chromium.org, senorblanco@chromium.org, bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
437593004
krajcevski [Fri, 8 Aug 2014 15:41:21 +0000 (08:41 -0700)]
Implement BlitRect for SkTCompressedAlphaBlitter
R=robertphillips@google.com, reed@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
451823002
Robert Phillips [Fri, 8 Aug 2014 15:40:08 +0000 (11:40 -0400)]
Add mandill_128.r11.ktx to resources
Review URL: https://codereview.chromium.org/
457693002
krajcevski [Fri, 8 Aug 2014 15:12:29 +0000 (08:12 -0700)]
Fix bug in blitAntiH
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
449223002
bsalomon [Fri, 8 Aug 2014 15:08:50 +0000 (08:08 -0700)]
Add an opaqueness hint to GrDrawState.
Check it when deciding whether to combine draw states.
R=egdaniel@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
446953002
bsalomon [Fri, 8 Aug 2014 14:43:29 +0000 (07:43 -0700)]
Make the rotated rects bench allow more alpha/color variations and an arbitrary xfermode::mode.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
448253002
stephana [Fri, 8 Aug 2014 14:21:00 +0000 (07:21 -0700)]
Rebaseline-server: sorting of columns in asc/desc order in frontend.
NOTRY=true
BUG=skia:1907
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/
449843002
senorblanco [Fri, 8 Aug 2014 14:14:35 +0000 (07:14 -0700)]
Remove external SkImageFilter cache, and rename UniqueIDCache -> Cache.
There Can Only Be One.... Cache for SkImageFilter.
R=bsalomon@google.com
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
452923002
rmistry [Fri, 8 Aug 2014 12:24:06 +0000 (05:24 -0700)]
Whitespace change to test the CQ
BUG=skia:
(SkipBuildbotRuns)
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
454873002
mtklein [Thu, 7 Aug 2014 22:20:02 +0000 (15:20 -0700)]
Fix iOS build by centralizing --writePath.
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
452633002
epoger [Thu, 7 Aug 2014 21:55:34 +0000 (14:55 -0700)]
don't list out all sourceSkpFile names in the rebaseline_server UI
(the list is long and crowds out the results themselves; better to use
a text filter to select the sourceSkpFiles of interest)
R=stephana@google.com
TBR=stephana
NOTREECHECKS=true
NOTRY=true
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
451853002
epoger [Thu, 7 Aug 2014 21:39:05 +0000 (14:39 -0700)]
make rebaseline_server properly handle unescaped URLs
R=rmistry@google.com
TBR=rmistry
NOTREECHECKS=true
NOTRY=true
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
445753005
bsalomon [Thu, 7 Aug 2014 21:28:50 +0000 (14:28 -0700)]
Add option to dump images from nanobench.
Add option to set the repeat count to any number, replacs the --runOnce flag.
R=mtklein@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
450743002
mtklein [Thu, 7 Aug 2014 21:27:03 +0000 (14:27 -0700)]
DM: conserve memory when using --skps
- limit to maximum 1000x1000 viewport like in bench_pictures and nanobench
- use lazy bitmap decoding when reading the pictures from disk
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
448263002
joshualitt [Thu, 7 Aug 2014 20:48:49 +0000 (13:48 -0700)]
Cleanup of context initialization
Cleanup context initialization on linux
BUG=skia:
R=bsalomon@chromium.org, bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
422323003
bungeman [Thu, 7 Aug 2014 20:27:17 +0000 (13:27 -0700)]
Revert of Process Statistics header, add max RSS to render_pdfs (https://codereview.chromium.org/
448993003/)
Reason for revert:
Reverting due to breaking iOS bots.
Original issue's description:
> Process Statistics header, add max RSS to render_pdfs
>
> Committed: https://skia.googlesource.com/skia/+/
6274baae7fe82ce6481da367687aa6168356e1e1
R=mtklein@google.com, halcanary@google.com
TBR=halcanary@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
448243003
halcanary [Thu, 7 Aug 2014 20:13:54 +0000 (13:13 -0700)]
Process Statistics header, add max RSS to render_pdfs
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
448993003
borenet [Thu, 7 Aug 2014 20:02:42 +0000 (13:02 -0700)]
Empty the Recipes bot's GM expectations
BUG=skia:761
NOTRY=true
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
455433002
krajcevski [Thu, 7 Aug 2014 19:58:38 +0000 (12:58 -0700)]
Add astcbitmap to gm slides.
Add additional ASTC formats.
Add astc image decoder files.
R=reed@google.com, robertphillips@google.com, halcanary@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
444093002
mtklein [Thu, 7 Aug 2014 19:46:29 +0000 (12:46 -0700)]
Default --skps to ./skps
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
452553002
reed [Thu, 7 Aug 2014 19:19:50 +0000 (12:19 -0700)]
change drawPicture in SkRecord to just ref the picture
also fix some int/unsigned/size_t warnings
BUG=skia:
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
449933002
epoger [Thu, 7 Aug 2014 19:13:12 +0000 (12:13 -0700)]
rebaseline_server: allow live queries to examine JSONKEY_EXPECTEDRESULTS or JSONKEY_ACTUALRESULTS
See https://goto.google.com/CorrectnessTestingBigIssues for full context
BUG=skia:1942
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
453433004
reed [Thu, 7 Aug 2014 18:48:10 +0000 (11:48 -0700)]
add isRect() check to AAClip, to detect if a soft-clip is really just an irect
taken from (https://codereview.chromium.org/
445233006/)
fix: don't assume that the first yoffset is 0, since we may have performed a translate and not
re-alloced our data.
This reverts commit
0aeea6d344f12e35e29a79f4bbc48af88f913204.
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/
443353004
krajcevski [Thu, 7 Aug 2014 18:33:59 +0000 (11:33 -0700)]
Revert of - Add astcbitmap to gm slides (https://codereview.chromium.org/
444093002/)
Reason for revert:
Breaking DM
Original issue's description:
> - Add astcbitmap to gm slides
> - Add additional ASTC formats
> - Add astc image decoder files
>
> Committed: https://skia.googlesource.com/skia/+/
2fc05823fed4b9649338f3029cd1ba05ef49a02f
R=reed@google.com, robertphillips@google.com, halcanary@google.com
TBR=halcanary@google.com, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
447343002
djsollen [Thu, 7 Aug 2014 18:30:30 +0000 (11:30 -0700)]
Disable suspect NEON function for 64-bit Android
R=halcanary@google.com, mtklein@google.com, kevin.petit@arm.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
451633006
borenet [Thu, 7 Aug 2014 18:28:20 +0000 (11:28 -0700)]
Duplicate NoGPU expectations for new recipes bot
BUG=skia:761
R=epoger@google.com
TBR=epoger
NOTRY=true
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
447323003
reed [Thu, 7 Aug 2014 18:19:11 +0000 (11:19 -0700)]
Revert of add isRect() check to AAClip, to detect if a soft-clip is really just an irect (https://codereview.chromium.org/
445233006/)
Reason for revert:
new code asserts on some pictures
Original issue's description:
> add isRect() check to AAClip, to detect if a soft-clip is really just an irect
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
592cb8d552556b1e922887d506d00b64bc5d0547
R=bsalomon@google.com, humper@google.com
TBR=bsalomon@google.com, humper@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/
452533002