platform/upstream/dotnet/runtime.git
17 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 219120...
dotnet bot [Wed, 31 May 2023 07:24:26 +0000 (00:24 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2191208 (#86925)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2190984

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2190984

17 months agoDo less work building Delegate.GetMethodInfo lookup (#86930)
Michal Strehovský [Wed, 31 May 2023 05:40:57 +0000 (14:40 +0900)]
Do less work building Delegate.GetMethodInfo lookup (#86930)

This code is very problematic for startup. We're spending 6.6% of startup samples of the Stage2 app in `ComputeLdftnReverseLookup_InvokeMap`. This code supports `Delegate.GetMethodInfo` and builds a reverse lookup table to lookup code metadata from code address. The data structure we have in the image is optimized for lookups in the other direction. 2.2% of the total time is spent trying to decode the entrypoint as an unboxing stub (the requires looking up unwinding info for the method). Shortcut this and do it only for valuetypes.

Medium term we'd want to do something about this. In the end this is the same problem as https://github.com/dotnet/runtime/pull/79921#discussion_r1056547078. Except this time we need to be able to lookup this information both ways (from metadata to function pointer and from function pointer to metadata). One thing I'm thinking about is whether we could store the hashcode of the owning type in the unwinding information of the method to give us something to go off.

17 months ago[main] Update dependencies from dotnet/arcade (#86494)
dotnet-maestro[bot] [Wed, 31 May 2023 05:16:44 +0000 (07:16 +0200)]
[main] Update dependencies from dotnet/arcade (#86494)

* Update dependencies from https://github.com/dotnet/arcade build 20230519.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.1

* Update dependencies from https://github.com/dotnet/arcade build 20230519.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.2

* Update dependencies from https://github.com/dotnet/arcade build 20230524.6

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23274.6

* Update dependencies from https://github.com/dotnet/arcade build 20230525.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23275.2

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

* Update dependencies from https://github.com/dotnet/arcade build 20230526.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23276.2

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

* Update dependencies from https://github.com/dotnet/arcade build 20230527.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23277.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

* Update dependencies from https://github.com/dotnet/arcade build 20230529.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

* Update dependencies from https://github.com/dotnet/arcade build 20230529.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.4

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

* Update dependencies from https://github.com/dotnet/arcade build 20230530.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23280.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

* Remove duplicate package references

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
17 months agoRemove comment in ZipFile.Create.cs (#86927)
Marc Brooks [Wed, 31 May 2023 04:32:32 +0000 (23:32 -0500)]
Remove comment in ZipFile.Create.cs (#86927)

* Remove comment in ZipFile.Create.cs

In #85491 the stream-based version of the `DoCreateFromDirectory` override copy-pasted comments from the string-based version
```csharp
// Rely on Path.GetFullPath for validation of sourceDirectoryName and destinationArchive
```
The last clause of that comment is not relevant in the stream-based version (the argument is `Stream destination`) so deleted that clause.

It's possible that the other comment is also misleading as we test the `compressionLevel ` argument just above (unlike in the `String destinationArchive` version
```csharp
            // Checking of compressionLevel is passed down to DeflateStream and the IDeflater implementation
            // as it is a pluggable component that completely encapsulates the meaning of compressionLevel.
```

* Remove compressionLevel validation comment

Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
---------

Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
17 months ago[wasm] Exploit unallocated zero page to remove null checks in jiterpreter (#86403)
Katelyn Gadd [Wed, 31 May 2023 02:50:34 +0000 (19:50 -0700)]
[wasm] Exploit unallocated zero page to remove null checks in jiterpreter (#86403)

* Fuse null and length checks for getelema1 and getchr
* Sense whether zero page optimizations are safe based on the location of the emscripten stack and contents of memory near zero
* Improve jiterpreter stats formatting

17 months agoEnsure Memory<T>/ReadOnlyMemory<T> are marked as unsupported types. (#86900)
Eirik Tsarpalis [Tue, 30 May 2023 22:12:23 +0000 (23:12 +0100)]
Ensure Memory<T>/ReadOnlyMemory<T> are marked as unsupported types. (#86900)

* Ensure Memory<T>/ReadOnlyMemory<T> are marked as unsupported types.

* Update src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs

17 months agoFix ClrEtwAllMeta.lst for the ContentionLockCreated event (#86907)
Koundinya Veluri [Tue, 30 May 2023 21:19:28 +0000 (14:19 -0700)]
Fix ClrEtwAllMeta.lst for the ContentionLockCreated event (#86907)

17 months agoFix deserialization of nullable structs with constructors. (#86896)
Eirik Tsarpalis [Tue, 30 May 2023 18:25:02 +0000 (19:25 +0100)]
Fix deserialization of nullable structs with constructors. (#86896)

17 months agoFix assert failure in grow_heap_segment for SVR GC. (#86889)
Peter Sollich [Tue, 30 May 2023 17:55:52 +0000 (19:55 +0200)]
Fix assert failure in grow_heap_segment for SVR GC. (#86889)

For my previous change, I overlooked the fact that we may call grow_heap_segment from within should_proceed_for_no_gc(), so it's too late to turn off gradual_decommit_in_progress_p after this method returns.

17 months agoImplement stream-based ZipFile ExtractToDirectory and CreateFromDirectory method...
Carlos Sánchez López [Tue, 30 May 2023 16:48:39 +0000 (09:48 -0700)]
Implement stream-based ZipFile ExtractToDirectory and CreateFromDirectory method overloads (#85491)

* ref: Add stream-based ZipFile.CreateFromDirectory and ZipFile.ExtractToDirectory methods.

* src: Add stream-based ZipFile.CreateFromDirectory ZipFile.ExtractToDirectory methods.

* tests: Move wrongly placed tests to the correct class.

* tests: Add stream-based tests for ZipFile.CreateFromDirectory and ZipFile.ExtractToDirectory.

* src: Documentation and resource strings.

* tests: More tests for unseekable/unreadable/unwritable streams.

* Address suggestions and include more exception validation tests.

* Fix braces after resolving conflict.

* Use AssertExtensions.SequenceEqual for clearer error message.

* Reset the resx file again.

* Order results of dir enumeration tests

17 months agoChange the LockCreated event to ContentionLockCreated (#86817)
Koundinya Veluri [Tue, 30 May 2023 15:46:52 +0000 (08:46 -0700)]
Change the LockCreated event to ContentionLockCreated (#86817)

- The event was added in .NET 8, I have updated the event name based on the suggestion in https://github.com/microsoft/perfview/pull/1731#issuecomment-1293961643.
- The name now matches the convention used for most other events, and shows up as Contention/LockCreated as expected in PerfView

17 months agoAdd PipeOptions.FirstPipeInstance enum value (#83936)
Tarun047 [Tue, 30 May 2023 14:49:19 +0000 (20:19 +0530)]
Add PipeOptions.FirstPipeInstance enum value (#83936)

Co-authored-by: Gudipati.Tarun <Gudipati.Tarun@wisetechglobal.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
17 months agoFix formatting issues in DependencyGraphViewer (#86890)
Vitek Karas [Tue, 30 May 2023 10:09:42 +0000 (03:09 -0700)]
Fix formatting issues in DependencyGraphViewer (#86890)

Whitespace only change, to fix tabs/spaces and trailing spaces.
Without this the tool doesn't build.

17 months ago[RISC-V] Fix receiving of 2nd register in struct (#86144)
t-mustafin [Tue, 30 May 2023 07:47:14 +0000 (10:47 +0300)]
[RISC-V] Fix receiving of 2nd register in struct (#86144)

* [RISC-V] Fix receiving of 2nd register in struct

* jit-format patch apply

17 months ago[RISC-V][JIT] Fix branch (#86482)
Dong-Heon Jung [Tue, 30 May 2023 07:45:53 +0000 (16:45 +0900)]
[RISC-V][JIT] Fix branch (#86482)

* [RISC-V][JIT] Fix branch

* [RISC-V][JIT] Updated emitJumpDistBind

* jit-format

* Update JALR offset value

* Updated by reviews

* Updated by reviews and fix

* [RISC-V][JIT] Fixed the dest reg of jalr

- Pass `./JIT/jit64/opt/cse/HugeField2/HugeField2.sh` test

17 months ago[wasm][globalization] `HybridGlobalization` fix bug in change case (#86799)
Ilona Tomkowicz [Tue, 30 May 2023 06:54:51 +0000 (08:54 +0200)]
[wasm][globalization] `HybridGlobalization` fix bug in change case (#86799)

* Fix + test.

* Fix surrogates problem, document final sigma.

* Update change-case.ts

* Fix NLS

17 months ago[NativeAOT] Fix MD array GC series (#86877)
Vladimir Sadov [Tue, 30 May 2023 06:03:26 +0000 (23:03 -0700)]
[NativeAOT] Fix MD array GC series (#86877)

* Fix MD array GC series

* add a test

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
17 months agoDo not compute debug names of reflection objects (#86880)
Michal Strehovský [Tue, 30 May 2023 05:45:14 +0000 (14:45 +0900)]
Do not compute debug names of reflection objects (#86880)

We're spending 5% of Stage2 app startup computing debug names.

This code originates from .NET Native where we had a "release mode with developer experience mode enabled" mode that tried to make troubleshooting trimming issues easier. One of the things it did was providing names of things in the debugger. Since we lack compiler support for this, developer experience mode is always enabled right now.

Since in .NET 5+ people are not supposed to troubleshoot trimming issues in the debugger, this mode doesn't make much sense (we also don't have a managed debugger to surface the `DebuggerDisplay` anyway)

17 months agoRead public GC options if available (#86068)
Andrii Kurdiumov [Tue, 30 May 2023 03:44:37 +0000 (09:44 +0600)]
Read public GC options if available (#86068)

17 months agoAnnotate test with IsPreciseGcSupported (#86869)
Jan Kotas [Tue, 30 May 2023 03:07:56 +0000 (20:07 -0700)]
Annotate test with IsPreciseGcSupported (#86869)

Fixes #86861

17 months agoImplement resource lookup in satellite assemblies (#86689)
Michal Strehovský [Mon, 29 May 2023 23:58:32 +0000 (08:58 +0900)]
Implement resource lookup in satellite assemblies (#86689)

Fixes #86651.

This was implemented in .NET Native so we just need to resurface it from the compiler.

Note that this is not full support for satellite assemblies (in the assembly binder, etc.) that never existed and nobody ever asked for and I don't even know what it entails.

17 months agoFaster ConstructorInfo.Invoke (#86855)
Michal Strehovský [Mon, 29 May 2023 21:06:42 +0000 (06:06 +0900)]
Faster ConstructorInfo.Invoke (#86855)

* Faster ConstructorInfo.Invoke

Speeds up reflection-invoking constructors by about 30%.

Noticed we spend some time in the `ConstructorInfo` invocation infrastructure for no good reason.

* We'd first allocate an instance of the object using a general purpose allocator (that first needs to dissect the `MethodTable` to figure out how to allocate), and then
* We'd call into general-purpose Invoke infrastructure that would validate the `this` is valid.

Neither of those are necessary - we can figure out the right allocator at the time the method invoker is first accessed, and validating `this` is not necessary because we _just_ allocated the right one.

* This is reachable and the old behavior was needed

* Apply suggestions from code review

---------

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
17 months ago[browser][MT] fix different url base of the worker (#86863)
Pavel Savara [Mon, 29 May 2023 17:09:19 +0000 (19:09 +0200)]
[browser][MT] fix different url base of the worker (#86863)

* fix different url base of the worker

17 months ago[RISC-V] Fix linking problem (#86870)
broudy3 [Mon, 29 May 2023 16:58:32 +0000 (18:58 +0200)]
[RISC-V] Fix linking problem (#86870)

17 months ago[main] Update dependencies from dotnet/roslyn-analyzers (#86793)
dotnet-maestro[bot] [Mon, 29 May 2023 16:53:50 +0000 (11:53 -0500)]
[main] Update dependencies from dotnet/roslyn-analyzers (#86793)

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230525.7

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23270.2 -> To Version 3.3.5-beta1.23275.7

* Fix new findings with CA1822 analyzer

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
17 months ago[main] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet...
dotnet-maestro[bot] [Mon, 29 May 2023 15:58:46 +0000 (10:58 -0500)]
[main] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/emsdk dotnet/runtime (#86678)

* Update dependencies from https://github.com/dotnet/llvm-project build 20230523.1

runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 14.0.0-alpha.1.23269.1 -> To Version 14.0.0-alpha.1.23273.1

* Update dependencies from https://github.com/dotnet/llvm-project build 20230523.3

runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 14.0.0-alpha.1.23269.1 -> To Version 14.0.0-alpha.1.23273.3

* Update dependencies from https://github.com/dotnet/runtime-assets build 20230523.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23273.1

* Update dependencies from https://github.com/dotnet/emsdk build 20230523.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.5.23265.1 -> To Version 8.0.0-preview.5.23273.1

* Update dependencies from https://github.com/dotnet/emsdk build 20230524.4

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.5.23265.1 -> To Version 8.0.0-preview.6.23274.4

* Bump main version to Preview 6

* Update dependencies from https://github.com/dotnet/emsdk build 20230525.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.5.23265.1 -> To Version 8.0.0-preview.6.23275.1

* Update dependencies from https://github.com/dotnet/emsdk build 20230527.2

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.5.23265.1 -> To Version 8.0.0-preview.6.23277.2

* Update dependencies from https://github.com/dotnet/runtime build 20230529.2

Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
 From Version 8.0.0-preview.5.23272.1 -> To Version 8.0.0-preview.5.23279.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
17 months ago[codespaces] Fix V8 error when running lib tests (#86871)
Ilona Tomkowicz [Mon, 29 May 2023 15:02:47 +0000 (17:02 +0200)]
[codespaces] Fix V8 error when running lib tests (#86871)

17 months ago[mono][interp] Use vectorized opcodes for Vector<T> operators (#86859)
Vlad Brezae [Mon, 29 May 2023 13:48:21 +0000 (16:48 +0300)]
[mono][interp] Use vectorized opcodes for Vector<T> operators (#86859)

* [mono][interp] Remove some duplicated code in transform-simd.c

* [mono][interp] Intrinsify Vector<T> operators

They do the same thing as the Vector128 counterpart

* [mono][interp] Add missing simd opcodes

17 months agoFix unfailing helix test run when testResults.xml are missing (#86342)
Marie Píchová [Mon, 29 May 2023 10:47:10 +0000 (12:47 +0200)]
Fix unfailing helix test run when testResults.xml are missing (#86342)

* Attempt to fix unfailing helix test run when testResults.xml are missing

* Feedback and docker image attemted fix

* Commenting out RHEL7 for a test run to see if there are any remaining problems elsewhere

* AlmaLinux 8 instead of RHEL7

* Test docker image

* Kdepak asi soudruzi udelali chybu

* Fixed docker from centos stream 9 to 8

* Test with different Queue

* Fixed docker image name

17 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 218982...
dotnet bot [Mon, 29 May 2023 07:53:51 +0000 (00:53 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2189827 (#86818)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2189200

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2189200

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2189240

17 months agoRevert "Change our Android build and test legs to use the new CBL-Mariner-based image...
Michal Strehovský [Mon, 29 May 2023 05:51:10 +0000 (14:51 +0900)]
Revert "Change our Android build and test legs to use the new CBL-Mariner-based images. (#86776)" (#86854)

This reverts commit 559f630beea2d72e9357505a891ea514e731650c.

17 months ago[browser][mt] Update memory views after growth, refactor string processing, fix Share...
Isabelle Santin [Sun, 28 May 2023 19:57:15 +0000 (14:57 -0500)]
[browser][mt] Update memory views after growth, refactor string processing, fix SharedArrayBuffer detection (#86664)

Co-authored-by: pavelsavara <pavel.savara@gmail.com>
17 months agoMultiple GDV: ignore non-inlineable candidates (#86835)
Egor Bogatov [Sat, 27 May 2023 18:38:16 +0000 (20:38 +0200)]
Multiple GDV: ignore non-inlineable candidates (#86835)

17 months agoFix tiered PGO info in TC Settings event (#86827)
Koundinya Veluri [Sat, 27 May 2023 18:37:18 +0000 (11:37 -0700)]
Fix tiered PGO info in TC Settings event (#86827)

- Moved initialization of the tiered PGO config values in EEConfig to before the TC Settings event is sent
- After this change, the TC Settings event shows the correct flags when tiered PGO is enabled

Fixes https://github.com/dotnet/runtime/issues/84607

17 months agoFix packs subset build (#86832)
Adeel Mujahid [Sat, 27 May 2023 14:31:56 +0000 (17:31 +0300)]
Fix packs subset build (#86832)

17 months agoAdd NativeAOT build and runtime pack for linux-bionic (#86781)
Michal Strehovský [Sat, 27 May 2023 07:38:18 +0000 (16:38 +0900)]
Add NativeAOT build and runtime pack for linux-bionic (#86781)

Build and runtime pack for linux-bionic (Android without the Java part).

I tried not to regress the existing CoreCLR Android build that is based on a crossrootfs (#56622) - the if's basically deal with that. Note that it's likely broken anyway (#66562).

17 months agoUse `u8` literals in `ManagedTextSection`. (#86657)
Theodore Tsirpanis [Sat, 27 May 2023 00:14:23 +0000 (03:14 +0300)]
Use `u8` literals in `ManagedTextSection`. (#86657)

17 months agoCI: Fix running the workaround for `NuGet-Migrations` issue (#85692)
Ankit Jain [Fri, 26 May 2023 23:50:09 +0000 (19:50 -0400)]
CI: Fix running the workaround for `NuGet-Migrations` issue (#85692)

* CI: Fix running the workaround for `NuGet-Migrations` issue

The workaround adds:

`(CONSOLE_TEMP_DIR=&quot;%24(mktemp -d)&quot; %3B &quot;$DOTNET_ROOT/dotnet&quot; new console -o &quot;$CONSOLE_TEMP_DIR&quot; %3B rm -rf &quot;$CONSOLE_TEMP_DIR&quot;) || true`

which uses `$DOTNET_ROOT/dotnet`. But this is set for `HelixPreCommand`
which runs *before* `DOTNET_ROOT` is set.

Instead, use `HelixCommandPrefixItem`.

* rename HelixCommandPrefixItem to HelixCommandPrefixEnvVarItem

* Fix in helixpublishwitharcade.proj also

* Add the workaround for legacy payloads also, which includes wasm runtime tests

* fix typo

17 months agoAddress Metrics APIs issues (#86740)
Tarek Mahmoud Sayed [Fri, 26 May 2023 23:34:55 +0000 (16:34 -0700)]
Address Metrics APIs issues (#86740)

17 months agoAdd support for types with parameterized ctors to config binder gen (#86365)
Layomi Akinrinade [Fri, 26 May 2023 21:58:23 +0000 (14:58 -0700)]
Add support for types with parameterized ctors to config binder gen (#86365)

* Add support for types with parameterized ctors to config binder gen

* Ensure param-prop binding & exception behavior match reflection implementation

* Fix ctor preference logic and enable passing test

17 months agoChange our Android build and test legs to use the new CBL-Mariner-based images. ...
Jeremy Koritzinsky [Fri, 26 May 2023 21:38:17 +0000 (14:38 -0700)]
Change our Android build and test legs to use the new CBL-Mariner-based images. (#86776)

17 months ago[ComInterfaceGenerator] Fix StringMarshalling error message and actually copy attribu...
Jackson Schuster [Fri, 26 May 2023 20:52:09 +0000 (13:52 -0700)]
[ComInterfaceGenerator] Fix StringMarshalling error message and actually copy attributes from methods to shadows (#86731)

Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
17 months agoJIT: Pick some low-hanging fruit in physical promotion throughput (#86792)
Jakob Botsch Nielsen [Fri, 26 May 2023 19:39:48 +0000 (21:39 +0200)]
JIT: Pick some low-hanging fruit in physical promotion throughput (#86792)

* Skip any IR traversals entirely if there are no candidates locals for
  physical promotion
* During accounting, do a quick pre-check for candidates in each
  statement using the linked locals list, before doing the tree walk.

Result:
```
Collection                                       PDIFF
aspnet.run.windows.x64.checked.mch              -0.59%
benchmarks.run.windows.x64.checked.mch          -0.65%
benchmarks.run_pgo.windows.x64.checked.mch      -0.65%
benchmarks.run_tiered.windows.x64.checked.mch   -0.65%
coreclr_tests.run.windows.x64.checked.mch       -0.66%
libraries.crossgen2.windows.x64.checked.mch     -0.61%
libraries.pmi.windows.x64.checked.mch           -0.63%
libraries_tests.pmi.windows.x64.checked.mch     -0.68%
```

17 months agoJIT: Have physical promotion insert read backs before possible implicit control flow...
Jakob Botsch Nielsen [Fri, 26 May 2023 19:15:33 +0000 (21:15 +0200)]
JIT: Have physical promotion insert read backs before possible implicit control flow (#86706)

Physical promotion relies on being able to read back any promoted field
that is fresher in its struct local before control flows to any
successor block. This was failing to take implicit control flow into
account.

Fix #86498

17 months agoJIT: Allow RBO for known relops even without a dominator (#86774)
Jakob Botsch Nielsen [Fri, 26 May 2023 19:12:09 +0000 (21:12 +0200)]
JIT: Allow RBO for known relops even without a dominator (#86774)

Delay the check for whether there is a dominator to the case where we're
actually going to try to infer from it.

17 months agoGuarded devirtualization: multiple type checks (#86551)
Egor Bogatov [Fri, 26 May 2023 18:47:12 +0000 (20:47 +0200)]
Guarded devirtualization: multiple type checks (#86551)

Co-authored-by: Andy Ayers <andya@microsoft.com>
17 months agoUpdate NativeAot with latest ILLink changes (#86712)
Sven Boemer [Fri, 26 May 2023 17:44:43 +0000 (10:44 -0700)]
Update NativeAot with latest ILLink changes (#86712)

This brings us up to date with changes from `dotnet/linker` and
allows us to remove the `ReferenceSource` directories.

* Update Dataflow ReferenceSource

* Update ILCompiler DataFlow

* Update Logging ReferenceSource

* Update ILCompiler Logging

* Update Common/Compiler ReferenceSource

* Apply formatting

* Fix up license headers

* Update Common/Compiler

* Remove ReferenceSource

* Apply suggestions from code review

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
---------

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
17 months ago[mono][debugger] Remove cast bug (#86789)
Ilona Tomkowicz [Fri, 26 May 2023 17:10:03 +0000 (19:10 +0200)]
[mono][debugger] Remove cast bug (#86789)

* Fix.

* Test standardization.

17 months agoRemove inconsistent comments in Convert.cs (#86425)
skyoxZ [Fri, 26 May 2023 16:24:07 +0000 (00:24 +0800)]
Remove inconsistent comments in Convert.cs (#86425)

* Remove inconsistent comments

* Fix inconsistent comments

* Fix inconsistent comments

17 months agoAdd adjacency row length check (#86716)
Stefan [Fri, 26 May 2023 15:45:01 +0000 (17:45 +0200)]
Add adjacency row length check (#86716)

17 months agoupdate MediaTypeNames (#86770)
Tomas Weinfurt [Fri, 26 May 2023 14:56:20 +0000 (16:56 +0200)]
update MediaTypeNames (#86770)

17 months agofix ISA outerloop tests (#86705)
Egor Bogatov [Fri, 26 May 2023 09:55:14 +0000 (11:55 +0200)]
fix ISA outerloop tests (#86705)

17 months agoExpand CORINFO_HELP_CHKCASTANY cast (#86728)
Egor Bogatov [Fri, 26 May 2023 09:08:58 +0000 (11:08 +0200)]
Expand CORINFO_HELP_CHKCASTANY cast (#86728)

17 months ago[mono] Exclude unused bundle files in AppleAppBuilder (#86316)
Milos Kotlar [Fri, 26 May 2023 08:39:48 +0000 (10:39 +0200)]
[mono] Exclude unused bundle files in AppleAppBuilder (#86316)

* Exclude .cs dedup file

* Use excludes list and use a wildcard for icudt_*

* Use variable for ExcludeFromAppDir

17 months agoDump data in proc test (#86784)
Dan Moseley [Fri, 26 May 2023 07:56:47 +0000 (02:56 -0500)]
Dump data in proc test (#86784)

17 months ago[wasm] Add build-runtime-tests make target (#86785)
Ankit Jain [Fri, 26 May 2023 06:22:05 +0000 (02:22 -0400)]
[wasm] Add build-runtime-tests make target (#86785)

17 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 218865...
dotnet bot [Fri, 26 May 2023 05:08:07 +0000 (22:08 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2188652 (#86779)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2188521

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2188521

17 months ago[wasm] Re-enable ~6700 runtime tests that got disabled mistakenly (#86747)
Ankit Jain [Fri, 26 May 2023 03:55:25 +0000 (23:55 -0400)]
[wasm] Re-enable ~6700 runtime tests that got disabled mistakenly (#86747)

* [wasm] Fix running merged test wrappers in runtime tests

- These were all getting removed because it looked for the incorrect
  script path in case of wasm

* [wasm] Disable a multithreaded runtime test

```
Operation is not supported on this platform.
   at System.Threading.Thread.ThrowIfNoThreadStart(Boolean internalThread)
   at System.Threading.Thread.Start(Boolean captureContext, Boolean internalThread)
   at System.Threading.Thread.Start()
   at MutualThdRecur_fptr.main()
   at Program.<>c__DisplayClass0_0.<<Main>$>g__TestExecutor29|30(TestFilter filter, StreamWriter tempLogSw, StreamWriter statsCsvSw)
```

* [wasm] Disable a failing test in JIT.Performance

`JIT/Performance/CodeQuality/Benchstones/MDBenchI/MDPuzzle/`
https://github.com/dotnet/runtime/issues/86772

* [wasm] Disable all JIT.Performance tests for now

17 months agoDefine the managed dependencies of the crossgen-corelib.proj file through ProjectRefe...
Jeremy Koritzinsky [Thu, 25 May 2023 22:38:38 +0000 (15:38 -0700)]
Define the managed dependencies of the crossgen-corelib.proj file through ProjectReferences (#86735)

17 months agoAdd some more testing around shadowing, inheritance, and project boundaries. (#86732)
Jeremy Koritzinsky [Thu, 25 May 2023 22:38:16 +0000 (15:38 -0700)]
Add some more testing around shadowing, inheritance, and project boundaries. (#86732)

17 months ago[wasm] Install latest LTS npm/node for codespaces (#86767)
Radek Doulik [Thu, 25 May 2023 20:00:22 +0000 (22:00 +0200)]
[wasm] Install latest LTS npm/node for codespaces (#86767)

* [wasm] Install latest LTS npm/node for codespaces

* Fix docker build

17 months agoUse cinv and cneg instead of csel when possible (#84926)
SwapnilGaikwad [Thu, 25 May 2023 20:00:09 +0000 (21:00 +0100)]
Use cinv and cneg instead of csel when possible (#84926)

* Use cinv instead of csel when possible

* Fix when the operands of conditional select should be reversed

* Scope down the cinv optimisation to local vars

* Use more generic CSINV instead of CINV instruction

* Add support for CSNEG and refactor conditional selects

* Fix initialisation of srcReg2

* Add RequiresProcessIsolation property to fix test failures

* Address review comments - Part 1

* Remove output type from conditional negate tests

* Ensure operands of cneg/cinv are invariants while optimising

* Update tests to the new format

* Use annotations to run tests through the framework

* Fix conditional negate tests

* Handle conditional negate/invert of shifted operands

17 months agoMake helix-inner-step send job warnaserror the same between windows and non-windows...
Parker Bibus [Thu, 25 May 2023 19:46:50 +0000 (12:46 -0700)]
Make helix-inner-step send job warnaserror the same between windows and non-windows platforms (#86729)

Add warnaserror to the Unix send to Helix step to match the windows send to helix step.

17 months ago[NativeAOT] Handle event pipe environment variable configuration and output to file...
Elinor Fung [Thu, 25 May 2023 19:40:52 +0000 (21:40 +0200)]
[NativeAOT] Handle event pipe environment variable configuration and output to file (#86656)

Updates to NativeAOT event pipe:
- Respect environment variable configuration
- Handle writing out to a file
- Enable tracing/eventpipe/config/name_config_with_pid test, which uses environment variable configuration to write directly to a file.

17 months agoAdd `DiagnosticOr<T>` type for gracefully handling failures in incremental generator...
Jackson Schuster [Thu, 25 May 2023 18:27:07 +0000 (11:27 -0700)]
Add `DiagnosticOr<T>` type for gracefully handling failures in incremental generator transformations (#86603)

17 months ago[mono][debugger] Don't pass uninitialized context to debugger (#86625)
Vlad Brezae [Thu, 25 May 2023 15:37:56 +0000 (18:37 +0300)]
[mono][debugger] Don't pass uninitialized context to debugger (#86625)

mono_dbg_debugger_agent_user_break first tries to initialize a context before sending it to the debugger machinery. If, during unwinding, we don't have a saved context, we were passing uninitialized data (with interpreter for example). On some architectures this was making unwinding break in mono_walk_stack_full, because the stack pointer was invalid. This change makes it so we at least pass a valid context.

17 months ago[Mono] Pass SIMD type variables using SIMD registers (#86634)
Fan Yang [Thu, 25 May 2023 15:35:43 +0000 (11:35 -0400)]
[Mono] Pass SIMD type variables using SIMD registers (#86634)

* Pass SIMD type variables in SIMD registers

* Disable support for 256/512 bit vectors.

---------

Co-authored-by: Zoltan Varga <vargaz@gmail.com>
17 months agoEnsure that the generated JsonSerializerContext.Default static property returns a...
Eirik Tsarpalis [Thu, 25 May 2023 14:38:16 +0000 (15:38 +0100)]
Ensure that the generated JsonSerializerContext.Default static property returns a sigleton. (#86757)

17 months agoInitial work to enable EventPipe in Linux (#86226)
Lakshan Fernando [Thu, 25 May 2023 11:57:41 +0000 (04:57 -0700)]
Initial work to enable EventPipe in Linux (#86226)

* Initial work to enable EventPipe in Linux

* GCC build break fix

* Only enable Unix

* FB

* restricting iOS

* Update src/coreclr/nativeaot/Directory.Build.props

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
* FB

* license header

* Update src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.h

Co-authored-by: Elinor Fung <elfung@microsoft.com>
* FB

---------

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Elinor Fung <elfung@microsoft.com>
17 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 218795...
dotnet bot [Thu, 25 May 2023 10:02:58 +0000 (03:02 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2187956 (#86733)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2187689

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2187689

17 months agoAdd IsEmpty and Length properties to System.BinaryData (#86721)
Cédric Luthi [Thu, 25 May 2023 09:40:39 +0000 (11:40 +0200)]
Add IsEmpty and Length properties to System.BinaryData (#86721)

Fixes #77970

17 months ago[browser] threads & js cleanup (#86278)
Pavel Savara [Thu, 25 May 2023 09:28:47 +0000 (11:28 +0200)]
[browser] threads & js cleanup (#86278)

17 months agoJIT: Adjust physical promotion heuristics (#86660)
Jakob Botsch Nielsen [Thu, 25 May 2023 09:08:22 +0000 (11:08 +0200)]
JIT: Adjust physical promotion heuristics (#86660)

Adjust the heuristics to take into account recent work on liveness and
assignment decomposition.  Stop phrasing things in terms of code size
(multiplied by basic block weights, which does not make sense).

17 months ago[jiterp] Fix rare case where an AOT method's arg_offsets were uninitialized while...
Katelyn Gadd [Thu, 25 May 2023 08:44:05 +0000 (01:44 -0700)]
[jiterp] Fix rare case where an AOT method's arg_offsets were uninitialized while we jitted its transition wrapper (#86745)

17 months ago[interp] Add float32 Vector128.Equals (#86738)
Katelyn Gadd [Thu, 25 May 2023 04:37:39 +0000 (21:37 -0700)]
[interp] Add float32 Vector128.Equals (#86738)

17 months agoAdd Microsoft.Extensions.Diagnostics.* to Aspnet Transport package (#86725)
William Godbe [Thu, 25 May 2023 02:16:53 +0000 (19:16 -0700)]
Add Microsoft.Extensions.Diagnostics.* to Aspnet Transport package (#86725)

17 months agoUse globalization invariant mode + prefer speed for AOT compilers (#86691)
Michal Strehovský [Thu, 25 May 2023 02:07:04 +0000 (11:07 +0900)]
Use globalization invariant mode + prefer speed for AOT compilers (#86691)

17 months agoOnly build specific tracing tests for NativeAOT leg (#86697)
Elinor Fung [Wed, 24 May 2023 23:17:37 +0000 (01:17 +0200)]
Only build specific tracing tests for NativeAOT leg (#86697)

17 months ago[wasm] Exports cleanup (#86718)
Radek Doulik [Wed, 24 May 2023 21:05:45 +0000 (23:05 +0200)]
[wasm] Exports cleanup (#86718)

Remove sections for old emscripten builds

17 months agoImplement byval-out marshalling for unmanaged->managed (#86666)
Jeremy Koritzinsky [Wed, 24 May 2023 20:43:37 +0000 (13:43 -0700)]
Implement byval-out marshalling for unmanaged->managed (#86666)

17 months agoFix timeouts in resourcemanager test (#86680)
madelson [Wed, 24 May 2023 20:38:16 +0000 (16:38 -0400)]
Fix timeouts in resourcemanager test (#86680)

* Update BinaryResourceWriterUnitTest.cs

Apply suggestion from https://github.com/dotnet/runtime/issues/86013#issuecomment-1560231543

Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
17 months agoUse the BannedApiAnalyzer instead of the LinqPoison mechanism to ban Linq in the...
Jeremy Koritzinsky [Wed, 24 May 2023 20:02:50 +0000 (13:02 -0700)]
Use the BannedApiAnalyzer instead of the LinqPoison mechanism to ban Linq in the managed type system (#86673)

17 months agoAvoid unnecessary closure in ServiceProviderEngineScope.CaptureDisposable (#86683)
Stephen Toub [Wed, 24 May 2023 18:07:01 +0000 (14:07 -0400)]
Avoid unnecessary closure in ServiceProviderEngineScope.CaptureDisposable (#86683)

Every call to this method is allocating a closure object, in order to capture `service`, even though it's only needed for a rare case.

17 months ago[ComInterfaceGenerator] Warn if StringMarshalling doesn't match base and warn if...
Jackson Schuster [Wed, 24 May 2023 17:44:05 +0000 (10:44 -0700)]
[ComInterfaceGenerator] Warn if StringMarshalling doesn't match base and warn if base interface cannot be generated (#86467)

17 months agoDelete native AOT interop doc (#86704)
Jan Kotas [Wed, 24 May 2023 17:37:53 +0000 (10:37 -0700)]
Delete native AOT interop doc (#86704)

This document lives at
https://learn.microsoft.com/en-us/dotnet/core/deploying/native-aot/interop
now.

17 months agoAdd comments in asm for R_AI (#86677)
Egor Bogatov [Wed, 24 May 2023 16:49:50 +0000 (18:49 +0200)]
Add comments in asm for R_AI (#86677)

17 months agoReduce allocation in Activity.{Parent}Id (#86685)
Stephen Toub [Wed, 24 May 2023 16:36:58 +0000 (12:36 -0400)]
Reduce allocation in Activity.{Parent}Id (#86685)

17 months agoUnify Roslyn testing SDK version across the repo (#86669)
Jeremy Koritzinsky [Wed, 24 May 2023 16:30:29 +0000 (09:30 -0700)]
Unify Roslyn testing SDK version across the repo (#86669)

17 months ago[mono][aot] Deduplicate runtime invoke wrappers on iOS (#85908)
Milos Kotlar [Wed, 24 May 2023 15:55:07 +0000 (17:55 +0200)]
[mono][aot] Deduplicate runtime invoke wrappers on iOS (#85908)

* Deduplicate runtime invoke wrappers on iOS

* Move log to the add_extra_method_full

17 months ago[ppc64le] Added float32 support and implemented all R4 opcodes (#86092)
Alhad Deshpande [Wed, 24 May 2023 15:15:10 +0000 (20:45 +0530)]
[ppc64le] Added float32 support and implemented all R4 opcodes (#86092)

* [ppc64le] Fixed thunk address 8 byte alignment issue

* Fixed FSharp crash issue

* [ppc64le] Implementation of mono_arch_get_delegate_virtual_invoke_impl method for ppc64le architecture

* Fixed clang15 build issues and returning address of sc_sp instead of value

* Added float32 support and implemented related opcodes

* Correction in OP_RCONV_TO_R cases

* Corrected code for few opcodes

17 months agoUse an mrgctx for all gshared methods on iOS (#86583)
Milos Kotlar [Wed, 24 May 2023 14:51:57 +0000 (16:51 +0200)]
Use an mrgctx for all gshared methods on iOS (#86583)

17 months agoFix MakeGenericType/Method argument validation for function pointers (#86686)
Jan Kotas [Wed, 24 May 2023 12:17:56 +0000 (05:17 -0700)]
Fix MakeGenericType/Method argument validation for function pointers (#86686)

Fixes #86628

17 months ago[OSX] HybridGlobalization implement compare native function (#85965)
Meri Khamoyan [Wed, 24 May 2023 11:08:56 +0000 (15:08 +0400)]
[OSX] HybridGlobalization implement compare native function (#85965)

Implemented CompareStringNative for OSX platforms
Added changes done by @ilonatommy in #86305

17 months agoDelete `GT_ASG` (#85871)
SingleAccretion [Wed, 24 May 2023 10:51:33 +0000 (13:51 +0300)]
Delete `GT_ASG` (#85871)

* Physical promotion

* Early liveness

* Local morph

* Add internal blocks

* Object allocator

* Inlining

* Indirect call transformer

* Patchpoint transformation

* Instrumentation

* Importer: production

* Importer: consumption

* Delete assignment rationalization

* Simple dead code removal

* More code removal

* Fix up some comments and variable names

* Fix stress

* Simplify BasicBlock::FirstNonPhiDef

* Duplicate a comment

* Remove dead code

* Fix naming and comments

17 months agoJIT: Follow related intervals for single-reg LIR temp intervals (#86632)
Jakob Botsch Nielsen [Wed, 24 May 2023 09:31:26 +0000 (11:31 +0200)]
JIT: Follow related intervals for single-reg LIR temp intervals (#86632)

17 months agoFix a bug in type hierarchy marking in the trimmer (#86635)
Vitek Karas [Wed, 24 May 2023 08:20:22 +0000 (01:20 -0700)]
Fix a bug in type hierarchy marking in the trimmer (#86635)

If the base class has DAM annotation on it, but the only access is through a variabled typed as the derived class, the marking of everything on the base class happens during the processing of the derived class.

The bug was that it would only apply marking for the difference in effective annotations between derived and base, so if the annotation is on base, then both have effectively the same annotation and there would be no additional marking on base. So for example private methods would not be marked.

This also affected warnings on virtual methods - see tests for more details.

17 months ago[mono][wasm] Fix support for virtual invokes. (#86687)
Zoltan Varga [Wed, 24 May 2023 08:20:03 +0000 (04:20 -0400)]
[mono][wasm] Fix support for virtual invokes. (#86687)

Fixes https://github.com/dotnet/runtime/issues/86621.

17 months agoadd nuget.projectmodel to version.details (#86650)
Oleksandr Didyk [Wed, 24 May 2023 08:16:28 +0000 (10:16 +0200)]
add nuget.projectmodel to version.details (#86650)

17 months ago[browser][non-icu] `HybridGlobalization` normalization. (#85510)
Ilona Tomkowicz [Wed, 24 May 2023 07:12:11 +0000 (09:12 +0200)]
[browser][non-icu] `HybridGlobalization` normalization. (#85510)

* Normalization.

* Missing measurement.

* Trying to fix trimming error.

* Applied @pavelsavara's idea.

* Code review improvement.

* Feedback: standardize the exceptions.

* Revert changes from #85516 to clean the CI.

* feedback

17 months ago[main] Update dependencies from dotnet/runtime dotnet/xharness dotnet/hotreload-utils...
dotnet-maestro[bot] [Tue, 23 May 2023 20:43:31 +0000 (15:43 -0500)]
[main] Update dependencies from dotnet/runtime dotnet/xharness dotnet/hotreload-utils (#86582)

* Update dependencies from https://github.com/dotnet/runtime build 20230522.1

Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
 From Version 8.0.0-preview.5.23265.1 -> To Version 8.0.0-preview.5.23272.1

* Update dependencies from https://github.com/dotnet/xharness build 20230522.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 8.0.0-prerelease.23259.1 -> To Version 8.0.0-prerelease.23272.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230522.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23265.2 -> To Version 8.0.0-alpha.0.23272.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>