tools/git-buildpackage.git
10 years agoGitRepository: Add clean() method
Markus Lehtonen [Wed, 4 Sep 2013 08:58:21 +0000 (11:58 +0300)]
GitRepository: Add clean() method

Signed-off-by: Lingchaox Xin <lingchaox.xin@intel.com>
Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agoGitRepository.fetch: Add 'all_remotes' option
Lingchaox Xin [Wed, 7 Aug 2013 07:25:21 +0000 (15:25 +0800)]
GitRepository.fetch: Add 'all_remotes' option

Signed-off-by: Lingchaox Xin <lingchaox.xin@intel.com>
Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agoGitRepository.fetch: Add 'refspec' option
Lingchaox Xin [Wed, 10 Jul 2013 03:17:46 +0000 (11:17 +0800)]
GitRepository.fetch: Add 'refspec' option

Signed-off-by: Lingchaox Xin <lingchaox.xin@intel.com>
Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agoGitRepository.describe: add 'tags' and 'extra-match' options
Lingchaox Xin [Thu, 20 Jun 2013 01:34:01 +0000 (09:34 +0800)]
GitRepository.describe: add 'tags' and 'extra-match' options

Signed-off-by: Lingchaox Xin <lingchaox.xin@intel.com>
Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agoGitRepository.has_treeish: minor pylint fix
Lingchaox Xin [Wed, 7 Aug 2013 02:24:36 +0000 (10:24 +0800)]
GitRepository.has_treeish: minor pylint fix

Signed-off-by: Lingchaox Xin <lingchaox.xin@intel.com>
Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agoComponentTestBase: keep tmpdir if GBP_TESTS_NOCLEAN is in env
Markus Lehtonen [Thu, 29 Aug 2013 14:18:03 +0000 (17:18 +0300)]
ComponentTestBase: keep tmpdir if GBP_TESTS_NOCLEAN is in env

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agoimport-orig: import readline in the common module
Markus Lehtonen [Mon, 26 Aug 2013 20:18:39 +0000 (23:18 +0300)]
import-orig: import readline in the common module

Useful common functionality.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agoComponentTestBase: fix env restore in teardown
Markus Lehtonen [Thu, 29 Aug 2013 13:14:38 +0000 (16:14 +0300)]
ComponentTestBase: fix env restore in teardown

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agoComponentTestBase: more verbose output in case of branch mismatch
Markus Lehtonen [Tue, 27 Aug 2013 17:17:45 +0000 (20:17 +0300)]
ComponentTestBase: more verbose output in case of branch mismatch

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agoGitRepository/diff: add 'stat' and 'summary' options
Markus Lehtonen [Thu, 29 Nov 2012 17:17:59 +0000 (19:17 +0200)]
GitRepository/diff: add 'stat' and 'summary' options

For getting diffstat and summary in the output.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agoconfig: restore mangled env in doctests
Markus Lehtonen [Thu, 29 Aug 2013 12:50:15 +0000 (15:50 +0300)]
config: restore mangled env in doctests

Otherwise the mangled GBP_CONF_FILES affects also other doctests when
run with python-nose.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agodocs: minor sgml syntax fix
Markus Lehtonen [Fri, 30 Aug 2013 17:54:11 +0000 (20:54 +0300)]
docs: minor sgml syntax fix

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
10 years agodocs: having an upstream branch is a recommendation
Guido Günther [Thu, 29 Aug 2013 18:11:18 +0000 (20:11 +0200)]
docs: having an upstream branch is a recommendation

rather than a hard requirement, we can use any treeish to build the
upstream tarball from.

10 years agoDocument changes and release 0.6.3 debian/0.6.3
Guido Günther [Wed, 28 Aug 2013 17:37:43 +0000 (19:37 +0200)]
Document changes and release 0.6.3

10 years agoUse open() instead of file()
Guido Günther [Wed, 28 Aug 2013 17:30:12 +0000 (19:30 +0200)]
Use open() instead of file()

since the later doesn't exist in python3

10 years agodocs: remove superfluous at
Guido Günther [Mon, 26 Aug 2013 07:07:26 +0000 (09:07 +0200)]
docs: remove superfluous at

10 years agodocs: Refert to gbp in the introduction
Guido Günther [Wed, 28 Aug 2013 17:25:37 +0000 (19:25 +0200)]
docs: Refert to gbp in the introduction

since this wraps all commands now.

Thanks: Ross Boylan for pointing out that the current wording is confusing.

10 years agopq: exclude patches from Debian packaging branch
Guido Günther [Sat, 24 Aug 2013 09:10:20 +0000 (11:10 +0200)]
pq: exclude patches from Debian packaging branch

When regenerating the patch queue including patches from the Debian
branch is not useful. Addresses parts of See #680705.

Thanks: Benjamin Cama for the detailed analysis

10 years agoGitRepository: allow to use '..' instead of '...'
Guido Günther [Sat, 24 Aug 2013 09:06:11 +0000 (11:06 +0200)]
GitRepository: allow to use '..' instead of '...'

The symmetric difference isn't always useful since it includes changes
from both branches. See #680705.

10 years agodocs: Add recommended branch layout
Guido Günther [Thu, 22 Aug 2013 08:47:15 +0000 (10:47 +0200)]
docs: Add recommended branch layout

It'd be nice to have similar branch layouts among packages so recommend
one that worked well so far.

10 years agoMinor docstring updates
Guido Günther [Thu, 22 Aug 2013 08:22:37 +0000 (10:22 +0200)]
Minor docstring updates

10 years agodch: make automatic adding of new sections more robust
Guido Günther [Wed, 21 Aug 2013 17:21:41 +0000 (19:21 +0200)]
dch: make automatic adding of new sections more robust

This code that determined if we found a snapshot header was obuscated by
the code that determines the commits to add. Split those and better
document their purpose. Also always return the commit to start from so
we don't need to repeat the logic in the uper levels.

10 years agoMove MockedChangelog to testutils
Guido Günther [Wed, 21 Aug 2013 19:10:15 +0000 (21:10 +0200)]
Move MockedChangelog to testutils

and allow to specify the content so we can reuse it for other dch
tests.

11 years ago--git-hooks doesn't take an argument
Guido Günther [Sat, 13 Jul 2013 07:40:14 +0000 (09:40 +0200)]
--git-hooks doesn't take an argument

11 years agoDocument changes and release 0.6.2 debian/0.6.2
Guido Günther [Tue, 9 Jul 2013 19:47:51 +0000 (21:47 +0200)]
Document changes and release 0.6.2

11 years agoBump dephelper dependency
Guido Günther [Tue, 9 Jul 2013 20:12:59 +0000 (22:12 +0200)]
Bump dephelper dependency

11 years agoGitRepository.set_upstream_branch: use --set-upstream-to if available
Guido Günther [Thu, 4 Jul 2013 15:18:29 +0000 (17:18 +0200)]
GitRepository.set_upstream_branch: use --set-upstream-to if available

since --set-upstream is deprecated.

11 years agoGitRepository.set_upstream_branch: Catch errors to set upstream branch
Guido Günther [Thu, 4 Jul 2013 15:00:02 +0000 (17:00 +0200)]
GitRepository.set_upstream_branch: Catch errors to set upstream branch

11 years agoGitRepository.set_upstream_branch: don't try to set upstream twice
Guido Günther [Thu, 4 Jul 2013 15:45:54 +0000 (17:45 +0200)]
GitRepository.set_upstream_branch: don't try to set upstream twice

Move setting of the upstream branch out of the loop. This worked by
accident.

11 years agoGitRepository.set_upstream_branch: Newer git wants a valid remote repo entry
Guido Günther [Thu, 4 Jul 2013 15:36:33 +0000 (17:36 +0200)]
GitRepository.set_upstream_branch: Newer git wants a valid remote repo entry

so set one in the tests before trying to set the upstream branch.

Found with git 1.8.3.2

11 years agoRemove duplicate config files section
Guido Günther [Thu, 4 Jul 2013 08:49:37 +0000 (10:49 +0200)]
Remove duplicate config files section

in the "gbp builpackage" man page

11 years agoAdd gbp buildpackage example
Guido Günther [Thu, 4 Jul 2013 08:38:30 +0000 (10:38 +0200)]
Add gbp buildpackage example

showing git-pbuilder invocation

11 years agoAdd examples for importing upstream sources
Guido Günther [Mon, 1 Jul 2013 21:31:25 +0000 (23:31 +0200)]
Add examples for importing upstream sources

11 years agoFix broken xrefs
Guido Günther [Sun, 30 Jun 2013 21:37:43 +0000 (23:37 +0200)]
Fix broken xrefs

11 years agoAdd symlinks to the manpages for the deprecated commands
Guido Günther [Sun, 30 Jun 2013 21:21:18 +0000 (23:21 +0200)]
Add symlinks to the manpages for the deprecated commands

Closes: #714489

and make lintian happy

11 years agoUpdate Vcs-Browser URL
Guido Günther [Sun, 30 Jun 2013 14:57:46 +0000 (16:57 +0200)]
Update Vcs-Browser URL

11 years agoSwitch to debhelper level 9
Guido Günther [Sun, 30 Jun 2013 14:49:20 +0000 (16:49 +0200)]
Switch to debhelper level 9

which is available in Wheezy

11 years agoMake sure we keep our test coverage
Guido Günther [Sun, 30 Jun 2013 14:34:32 +0000 (16:34 +0200)]
Make sure we keep our test coverage

11 years agoTest succesful import too
Guido Günther [Sun, 30 Jun 2013 14:06:43 +0000 (16:06 +0200)]
Test succesful import too

and make sure we don't spew to stderr during this test

11 years agogbp.git.GitRepository.has_branch(): use _git_command
Guido Günther [Sat, 29 Jun 2013 11:16:38 +0000 (13:16 +0200)]
gbp.git.GitRepository.has_branch(): use _git_command

instead of the deprecated _git_getoutput

11 years agogbp.git.Repository.get_branch(): use _git_command
Guido Günther [Sat, 29 Jun 2013 11:06:43 +0000 (13:06 +0200)]
gbp.git.Repository.get_branch(): use _git_command

instead of the deprecated _git_inout and clarify the return codes and
exceptions raised.

11 years ago.gitignore docbook xref
Guido Günther [Sat, 29 Jun 2013 10:40:57 +0000 (12:40 +0200)]
.gitignore docbook xref

Git-Dch: Ignore

11 years agoGit.Repository.__git_inout: Close all other file descriptors
Guido Günther [Sat, 29 Jun 2013 10:38:42 +0000 (12:38 +0200)]
Git.Repository.__git_inout: Close all other file descriptors

No need to leak fds to the child.

11 years agoGit.Repository.__git_inout: properly set stdin
Guido Günther [Sat, 29 Jun 2013 10:38:42 +0000 (12:38 +0200)]
Git.Repository.__git_inout: properly set stdin

We should set stdin to subprocess.PIPE when piping input according
to the subprocess docs.

11 years agoUse has_key
Guido Günther [Thu, 27 Jun 2013 17:14:38 +0000 (19:14 +0200)]
Use has_key

It's shorter and get's rid of the unused dummy variable.

11 years agoDocument gbp's help option
Guido Günther [Thu, 27 Jun 2013 17:08:59 +0000 (19:08 +0200)]
Document gbp's help option

11 years agoDocument changes and release 0.6.1 debian/0.6.1
Guido Günther [Thu, 27 Jun 2013 09:23:09 +0000 (11:23 +0200)]
Document changes and release 0.6.1

11 years agoDepend on python-pkg-resources
Guido Günther [Thu, 27 Jun 2013 07:36:10 +0000 (09:36 +0200)]
Depend on python-pkg-resources

Closes: #714238

11 years agoSplit {Build-,}Deps per line
Guido Günther [Thu, 27 Jun 2013 07:34:46 +0000 (09:34 +0200)]
Split {Build-,}Deps per line

and sort alphabetically

11 years agoDocument changes and release 0.6.0 debian/0.6.0
Guido Günther [Wed, 26 Jun 2013 14:39:55 +0000 (16:39 +0200)]
Document changes and release 0.6.0

11 years agoimport-dsc: print filename instead of object name
Guido Günther [Wed, 26 Jun 2013 17:14:32 +0000 (19:14 +0200)]
import-dsc: print filename instead of object name

11 years agoconfig: Don't fill in the parser with all defaults
Guido Günther [Wed, 26 Jun 2013 16:43:49 +0000 (18:43 +0200)]
config: Don't fill in the parser with all defaults

There's no need to fill the parser with all the built in defaults since
we can simply copy them to the config from the class dict. This allows
us to first set the values from the old {git,gbp}-* commands and then
only overwrite changed values from the newer "gbp <command>" versions.

Otherwise we'd overwite all old style config with the new style one.
This also fixes the problem where the default section wouldn't be read
at all if the command doesn't even have an empty section in any gbp.conf
file.

11 years agoFix typo
Guido Günther [Wed, 26 Jun 2013 16:36:20 +0000 (18:36 +0200)]
Fix typo

Git-Dch: Ignore

11 years agogbp-import-dscs: invoke gbp import-dsc
Guido Günther [Wed, 26 Jun 2013 16:01:09 +0000 (18:01 +0200)]
gbp-import-dscs: invoke gbp import-dsc

instead of git-import-dsc

11 years agoConsistently call gbp the supercommand
Guido Günther [Wed, 26 Jun 2013 15:15:19 +0000 (17:15 +0200)]
Consistently call gbp the supercommand

and robustify against invalid modules names.

11 years agogbp: support --help
Guido Günther [Wed, 26 Jun 2013 14:59:52 +0000 (16:59 +0200)]
gbp: support --help

11 years agoUpdate package description
Guido Günther [Wed, 26 Jun 2013 11:47:42 +0000 (13:47 +0200)]
Update package description

11 years agoNEWS: add a note about the new gbp super command
Guido Günther [Wed, 26 Jun 2013 11:44:26 +0000 (13:44 +0200)]
NEWS: add a note about the new gbp super command

11 years agoRename the sgml files from git- to gbp-
Guido Günther [Wed, 26 Jun 2013 11:32:32 +0000 (13:32 +0200)]
Rename the sgml files from git- to gbp-

11 years agogbp.conf: Use command names instead of {git,gbp}-
Guido Günther [Wed, 26 Jun 2013 11:28:26 +0000 (13:28 +0200)]
gbp.conf: Use command names instead of {git,gbp}-

11 years agodocs: Rename the entities from &git-<command>; to &gbp-<command>;
Guido Günther [Wed, 26 Jun 2013 11:09:51 +0000 (13:09 +0200)]
docs: Rename the entities from &git-<command>; to &gbp-<command>;

11 years agomanpages: Changes references from git- to gbp-
Guido Günther [Wed, 26 Jun 2013 10:54:48 +0000 (12:54 +0200)]
manpages: Changes references from git- to gbp-

11 years agodocs: Use gbp <command> instead of {git,gbp}-<command>
Guido Günther [Wed, 26 Jun 2013 10:27:05 +0000 (12:27 +0200)]
docs: Use gbp <command> instead of {git,gbp}-<command>

11 years agoAdd gbp manpage
Guido Günther [Wed, 26 Jun 2013 09:56:38 +0000 (11:56 +0200)]
Add gbp manpage

11 years agoBash complete on "gbp <command>" too
Guido Günther [Wed, 26 Jun 2013 09:42:27 +0000 (11:42 +0200)]
Bash complete on "gbp <command>" too

11 years agoGit-Ignore generated gbp.conf.5 too
Guido Günther [Wed, 26 Jun 2013 10:09:31 +0000 (12:09 +0200)]
Git-Ignore generated gbp.conf.5 too

11 years agoGbpOptionParser: add test for 'filter' option handling
Guido Günther [Wed, 19 Jun 2013 09:38:21 +0000 (11:38 +0200)]
GbpOptionParser: add test for 'filter' option handling

11 years agoGbpOptionParser: Make sure we parse the old config sections
Guido Günther [Tue, 18 Jun 2013 22:25:53 +0000 (00:25 +0200)]
GbpOptionParser: Make sure we parse the old config sections

For backward compatibility between {gbp,git}-<subcommand> and "gbp
<subcommand>" make sure we parse the former sections if using the later.

11 years agoGbpOptionParser: Make sure we access the GbpOptionParser*'s default dict
Guido Günther [Wed, 19 Jun 2013 09:31:45 +0000 (11:31 +0200)]
GbpOptionParser: Make sure we access the GbpOptionParser*'s default dict

and not the one from the OptionParser. The instance's default dict this
gets reset to empty when invoking OptionParser.__init__.

11 years agoAdd wrapper for all gbp commands
Guido Günther [Sun, 8 Jan 2012 18:35:34 +0000 (19:35 +0100)]
Add wrapper for all gbp commands

So like git you can now use gbp <command> instead of git-<command> or
gbp-<command>. The manpages and docs aren't adjusted yet.

11 years agoGitRepository/diff: allow single object
Markus Lehtonen [Thu, 29 Nov 2012 17:17:59 +0000 (19:17 +0200)]
GitRepository/diff: allow single object

Allow diffing a single object, e.g. getting diff from single commit.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
11 years agoSimplify expression
Guido Günther [Tue, 11 Jun 2013 13:37:22 +0000 (15:37 +0200)]
Simplify expression

Git-Dch: Ignore

11 years agoGitRepository.get_subject: use get_commit_info
Guido Günther [Tue, 11 Jun 2013 13:20:44 +0000 (15:20 +0200)]
GitRepository.get_subject: use get_commit_info

This kills another _git_getoutput. Also deprecate the method since we
don't need to special case the subject.

11 years agobuildpackage: use get_commit_info() instead of get_subject()
Markus Lehtonen [Mon, 6 May 2013 12:19:58 +0000 (15:19 +0300)]
buildpackage: use get_commit_info() instead of get_subject()

Utilize the get_commit_info() method of GitRepository instead of the
deprecated get_subject().

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
11 years agoRemove unused imports
Guido Günther [Tue, 11 Jun 2013 13:15:58 +0000 (15:15 +0200)]
Remove unused imports

11 years agoimport-orig: keep working copy in sync with branch HEAD
Markus Lehtonen [Wed, 28 Nov 2012 08:43:20 +0000 (10:43 +0200)]
import-orig: keep working copy in sync with branch HEAD

Update working copy and index (to branch HEAD) if we modify the
currently checked-out branch. Otherwise the repository is left in
unclean state when the current branch is upstream or pristine-tar and
the '--no-merge' option is used.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
11 years agoGitRepository/get_commit_info: add patchname to info
Markus Lehtonen [Tue, 7 Aug 2012 13:22:00 +0000 (16:22 +0300)]
GitRepository/get_commit_info: add patchname to info

Add a new 'patchname' field to the information returned by
get_commit_info. That is, the subject in a sanitized format, similar to
what git-format-patch uses.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
11 years agogitmodifier: make the datetime object always have timezone
Markus Lehtonen [Thu, 29 Nov 2012 17:11:21 +0000 (19:11 +0200)]
gitmodifier: make the datetime object always have timezone

To be consistent with the date property and for easier compatibility
with git dates.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
11 years agoDocument changes and release 0.6.0~git20130630 debian/0.6.0_git20130530
Guido Günther [Thu, 30 May 2013 13:24:32 +0000 (15:24 +0200)]
Document changes and release 0.6.0~git20130630

11 years agoAdd Jenkins Scratchbuilder example
Guido Günther [Sun, 5 May 2013 10:59:56 +0000 (12:59 +0200)]
Add Jenkins Scratchbuilder example

It's a simple script that can be used to build Debian packages via gbp
and Jenkins.

11 years agogit-buildpackage: Unbreak overlay mode
Gaudenz Steinlin [Fri, 17 May 2013 12:44:47 +0000 (14:44 +0200)]
git-buildpackage: Unbreak overlay mode

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Closes: #708636

11 years agoGitRepository: Use LC_ALL=C when checking features
Guido Günther [Wed, 8 May 2013 14:40:41 +0000 (16:40 +0200)]
GitRepository: Use LC_ALL=C when checking features

This fixes the doctest and also makes sure we use an up to date manpage.

Thanks: Daniel Dehennin for the report

11 years agoDocument changes and release 0.6.0~git20130506 debian/0.6.0_git20130506
Guido Günther [Mon, 6 May 2013 17:26:22 +0000 (19:26 +0200)]
Document changes and release 0.6.0~git20130506

11 years agomanpages: Document gbp-pull's --ignore-branch option
Guido Günther [Sat, 4 May 2013 12:13:07 +0000 (14:13 +0200)]
manpages: Document gbp-pull's --ignore-branch option

11 years agogbp-pull: Fix typo in help output
Guido Günther [Sat, 4 May 2013 12:00:05 +0000 (14:00 +0200)]
gbp-pull: Fix typo in help output

11 years agoGitRepository Use _git_inout in get_branch
Guido Günther [Thu, 2 May 2013 20:20:02 +0000 (22:20 +0200)]
GitRepository Use _git_inout in get_branch

to suppress the confusiong "fatal: ref HEAD is not a symbolic ref". We
alrady put out a more descriptive error message. This makes using
--ignore-branch look far less dangerous.

11 years agoAdd --ignore-branch to gbp-pull
Guido Günther [Thu, 2 May 2013 19:46:47 +0000 (21:46 +0200)]
Add --ignore-branch to gbp-pull

This allows us to fetch upstream and pristine-tar even when in detached
head state. This can be usefull when e.g. building in jenkins which uses
a detached head by default.

11 years agodch: make sure branch is always defined
Guido Günther [Thu, 2 May 2013 19:35:10 +0000 (21:35 +0200)]
dch: make sure branch is always defined

This fixes a problem when running git-dch form a detached HEAD

11 years agotrivial: simplify option assignment
Guido Günther [Tue, 30 Apr 2013 14:57:38 +0000 (16:57 +0200)]
trivial: simplify option assignment

to ease readability

11 years agoSilence test_debian_missing_author
Guido Günther [Tue, 30 Apr 2013 14:49:34 +0000 (16:49 +0200)]
Silence test_debian_missing_author

and better use the output for verification

11 years agoSilence dpkg --compare-versions
Guido Günther [Mon, 29 Apr 2013 20:33:37 +0000 (22:33 +0200)]
Silence dpkg --compare-versions

and add the error detail to the exception message. This silences the
testsuite and makes sure we have error message and exception output in
sync.

11 years agoUse Popen.communicate instead of subprocess call
Guido Günther [Mon, 29 Apr 2013 17:59:12 +0000 (19:59 +0200)]
Use Popen.communicate instead of subprocess call

so we can capture stderr and use it in error messages intead of spewing
it on the console.

11 years agoMake parse_dsc a classmethod of DscFile
Guido Günther [Mon, 29 Apr 2013 18:55:40 +0000 (20:55 +0200)]
Make parse_dsc a classmethod of DscFile

so we have the object creation close to the object itself.

11 years agoChangeLog: Remove is_native
Guido Günther [Mon, 29 Apr 2013 12:45:44 +0000 (14:45 +0200)]
ChangeLog: Remove is_native

to avoid accidental usage. Use DebianSource.is_native instead.

11 years agodch: Use DebianSource.is_native
Guido Günther [Mon, 29 Apr 2013 12:31:43 +0000 (14:31 +0200)]
dch: Use DebianSource.is_native

instead of ChangeLog.is_native since the former used
debian/source/format in favor of debian/changelog.

11 years agoRevert "Use Popen.communicate instead of subprocess call"
Guido Günther [Mon, 29 Apr 2013 12:31:37 +0000 (14:31 +0200)]
Revert "Use Popen.communicate instead of subprocess call"

This reverts commit 0c582cd827f164168a313e0bb4eabf9487bdd088.

11 years agoUse Popen.communicate instead of subprocess call
Guido Günther [Mon, 29 Apr 2013 12:30:31 +0000 (14:30 +0200)]
Use Popen.communicate instead of subprocess call

so we can caputure stderr and pass it along with any errors.

11 years agoGitRepository.has_feature: capture stderr
Guido Günther [Sat, 27 Apr 2013 20:26:36 +0000 (22:26 +0200)]
GitRepository.has_feature: capture stderr

to avoid spurious output on the console and add the error message to the
exception intead.

11 years agoGitRepository.commit_dir: raise GitRepositoryError instead of GbpError
Guido Günther [Sat, 27 Apr 2013 20:20:04 +0000 (22:20 +0200)]
GitRepository.commit_dir: raise GitRepositoryError instead of GbpError

and make sure the callers forward the error properly

11 years agoSilence GitRepository.write_tree
Guido Günther [Sat, 27 Apr 2013 20:15:43 +0000 (22:15 +0200)]
Silence GitRepository.write_tree

but add any error output to the exception instead. All callers have been
audited to properly output the message if needed.