bungeman [Thu, 18 Feb 2016 19:01:13 +0000 (11:01 -0800)]
Move SkTDStack.h to src/animator.
This file is only used by animator and may or may not be sane. Move
the file from include/core to src/animator since no one else is using
it.
TBR=reed
Make it go away!
Review URL: https://codereview.chromium.org/
1710083002
ethannicholas [Thu, 18 Feb 2016 18:50:50 +0000 (10:50 -0800)]
fixed SkDrawCommand JSON generation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1715443002
Review URL: https://codereview.chromium.org/
1715443002
ethannicholas [Thu, 18 Feb 2016 18:22:34 +0000 (10:22 -0800)]
added server-side breakpoint support to skiaserve
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1707863003
Review URL: https://codereview.chromium.org/
1707863003
borenet [Thu, 18 Feb 2016 18:13:14 +0000 (10:13 -0800)]
Add luci-go isolate.sha1 files
NOTRY=true
BUG=skia:3775, skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1711013002
Review URL: https://codereview.chromium.org/
1711013002
bsalomon [Thu, 18 Feb 2016 18:01:11 +0000 (10:01 -0800)]
Make build_command_buffer.py work on Windows
BUG=skia:4957
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1710983002
Review URL: https://codereview.chromium.org/
1710983002
caryclark [Thu, 18 Feb 2016 17:00:01 +0000 (09:00 -0800)]
check for zero conic weights in interp
this will fix the current (and uncover the next)
ASAN failure
TBR=tomhudson@google.com
BUG=skia:4549
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1711813002
Review URL: https://codereview.chromium.org/
1711813002
bungeman [Thu, 18 Feb 2016 16:53:33 +0000 (08:53 -0800)]
Move SkTDArray to private.
TBR=reed
Moving to private is good.
Review URL: https://codereview.chromium.org/
1707213002
robertphillips [Thu, 18 Feb 2016 16:48:03 +0000 (08:48 -0800)]
Update SkSpecialImage API
This adds some temporary compatibility features:
internal_getBM & internal_fromBM - to convert back & forth from Bitmaps in the ImageFilters
internal_getProxy - to allow the special images to interface with the current ImagerFilter system
It also adds a unique ID, opaque flag and size method.
The unique ID and size method are needed for the image filter's caching system.
The opaque flag is need for swapping back & forth from Bitmaps
These are all calved off of https://codereview.chromium.org/
1695823002/ (Get OffsetImageFilter really working with SkSpecialImages) which actually makes use of them.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1705113002
Review URL: https://codereview.chromium.org/
1705113002
reed [Thu, 18 Feb 2016 16:16:33 +0000 (08:16 -0800)]
lcd blits for sRGB
Unimplemented for F16 for the moment, but not needed yet.
Surprisingly not much slower than current impl (not srgb correct)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1707883002
Review URL: https://codereview.chromium.org/
1707883002
borenet [Thu, 18 Feb 2016 16:05:48 +0000 (08:05 -0800)]
Port Skia recipe to normal Python scripts, move to Skia repo
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703663002
Review URL: https://codereview.chromium.org/
1703663002
mtklein [Thu, 18 Feb 2016 14:58:13 +0000 (06:58 -0800)]
Remove FuzzPaeth now that we have some real Fuzzes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1711753002
Review URL: https://codereview.chromium.org/
1711753002
bsalomon [Thu, 18 Feb 2016 14:40:55 +0000 (06:40 -0800)]
Make build_command_buffer.py work on Mac and Windows.
Also specify GYP_GENERATORS and add flags to gclient sync to make it more likely to succeed.
BUG=skia:4957
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704193002
Review URL: https://codereview.chromium.org/
1704193002
kjlubick [Thu, 18 Feb 2016 14:27:38 +0000 (06:27 -0800)]
Create ParsePath API fuzz
This is based on https://codereview.chromium.org/
1675053002
BUG=skia:4438
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1702383003
Review URL: https://codereview.chromium.org/
1702383003
caryclark [Thu, 18 Feb 2016 14:16:31 +0000 (06:16 -0800)]
remove legacy flags
R=fmalita@chromium.org
BUG=573166
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1707383002
Review URL: https://codereview.chromium.org/
1707383002
caryclark [Thu, 18 Feb 2016 14:13:25 +0000 (06:13 -0800)]
fix asan error deref-ing null ptr
TBR=tomhudson@google.com
BUG=skia:4549
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1709023002
Review URL: https://codereview.chromium.org/
1709023002
scroggo [Thu, 18 Feb 2016 13:59:25 +0000 (05:59 -0800)]
Remove position from FrontBufferedStream
When FrontBufferedStream was written, it implemented getPosition()
and returned true for hasPosition(). The CL that introduced it
(crrev.com/
23717055) does not have any indication why, but I'm guessing
it was because it was easy to implement. None of our decoders rely on
this (only some tests do).
Now that we have a decoder (SkRawCodec) that expects to be able to seek
a stream if it has a position (which makes sense - SkStream.h
associates that with SkStreamSeekable, and there is no other way to
check to see if a stream is seekable), it is failing because
FrontBufferedStream reports it has a position and the decoder tries to
seek.
Remove FrontBufferedStream::hasPosition() (reverting to the default,
false) and ::getPosition() (so it will return 0).
Fix tests - do not call FrontBufferedStream::getPosition()
Update CodexTest to test using an FrontBufferedStream, like Android
does.
BUG=b/
27218441
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703293002
Review URL: https://codereview.chromium.org/
1703293002
caryclark [Thu, 18 Feb 2016 13:45:33 +0000 (05:45 -0800)]
remove legacy bitmap filter
R=fmalita@chromium.org
BUG=skia:2261
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1711683002
Review URL: https://codereview.chromium.org/
1711683002
joshualitt [Thu, 18 Feb 2016 13:04:39 +0000 (05:04 -0800)]
fix comma in GrAuditTrail json
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704133002
Review URL: https://codereview.chromium.org/
1704133002
caryclark [Thu, 18 Feb 2016 12:11:48 +0000 (04:11 -0800)]
add interp path
Add path methods to determine if a pair of paths
can be interpolated, and to interpolate them.
R=reed@google.com, robertphillips@google.com
BUG=skia:4549
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703943003
Review URL: https://codereview.chromium.org/
1703943003
herb [Thu, 18 Feb 2016 03:50:05 +0000 (19:50 -0800)]
Add bilerp filtering.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1705203002
Review URL: https://codereview.chromium.org/
1705203002
reed [Thu, 18 Feb 2016 02:02:49 +0000 (18:02 -0800)]
some modes need clamping due to numerical imprecision
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1710453003
TBR=
Review URL: https://codereview.chromium.org/
1710453003
cblume [Wed, 17 Feb 2016 22:53:23 +0000 (14:53 -0800)]
Adding direct access to SkMipMap levels.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1639693002
Review URL: https://codereview.chromium.org/
1639693002
mtklein [Wed, 17 Feb 2016 22:21:28 +0000 (14:21 -0800)]
try plain-old code for sk_memset16/32 now that NEON is compile-time
Most of these implementations now just say "always inline".
Let's see if we can get away with the simplicity of doing that all the time.
These inlined implementations can autovectorize easily.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1639863002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1639863002
msarett [Wed, 17 Feb 2016 22:14:25 +0000 (14:14 -0800)]
Speculative fix for Google3 iOS build
Now that SkImageGenerator is hooked up to use SkCodec by default,
we need to compile SkCodec in order to compile Skia.
The good news is that we can now turn on/off individual codecs.
This CL enables SkCodec on iOS, but does not turn on any of the
codecs that require third_party libraries.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1710493002
Review URL: https://codereview.chromium.org/
1710493002
msarett [Wed, 17 Feb 2016 22:06:46 +0000 (14:06 -0800)]
Return the proper error code in SkBmpRLECodec
BUG=skia:4963
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1707933002
Review URL: https://codereview.chromium.org/
1707933002
jvanverth [Wed, 17 Feb 2016 22:04:46 +0000 (14:04 -0800)]
Add GrGpu support for Vulkan command buffer flush
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1705133002
Review URL: https://codereview.chromium.org/
1705133002
robertphillips [Wed, 17 Feb 2016 21:57:16 +0000 (13:57 -0800)]
Mark existing image filter entry points that will be going away with Deprecated
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1709753002
Review URL: https://codereview.chromium.org/
1709753002
mtklein [Wed, 17 Feb 2016 21:50:46 +0000 (13:50 -0800)]
Don't you just feel bad every time you type 'delete'?
This should fix
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/4787/steps/nanobench/logs/stdio
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703203003
Review URL: https://codereview.chromium.org/
1703203003
brianosman [Wed, 17 Feb 2016 21:43:40 +0000 (13:43 -0800)]
Further reduction of GPU workload in shapes benchmarks. Hopefully this squelches the random crashes on Mali 400.
BUG=skia:4937
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703233002
Review URL: https://codereview.chromium.org/
1703233002
bungeman [Wed, 17 Feb 2016 21:13:44 +0000 (13:13 -0800)]
Move SkTArray to include/private.
TBR=reed
Agreed moving to private is good.
Review URL: https://codereview.chromium.org/
1702073002
msarett [Wed, 17 Feb 2016 21:10:14 +0000 (13:10 -0800)]
Delete KTX tests to fix Android build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1707053002
Review URL: https://codereview.chromium.org/
1707053002
halcanary [Wed, 17 Feb 2016 21:07:37 +0000 (13:07 -0800)]
bin/sync-and-gyp: better error checking
NOTRY=true
Review URL: https://codereview.chromium.org/
1704143002
iroth [Wed, 17 Feb 2016 20:47:27 +0000 (12:47 -0800)]
Enable GL interfaces for iOS build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703923002
Review URL: https://codereview.chromium.org/
1703923002
caryclark [Wed, 17 Feb 2016 20:16:27 +0000 (12:16 -0800)]
add last move to serialized path
A deserialized path keeps the last move location so that
a subsequent append to the path does not add an unwanted
close verb.
R=reed@oogle.com
BUG=skia:4847
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1702393002
Review URL: https://codereview.chromium.org/
1702393002
herb [Wed, 17 Feb 2016 19:57:24 +0000 (11:57 -0800)]
Fix name creation scope.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1701413003
Review URL: https://codereview.chromium.org/
1701413003
ethannicholas [Wed, 17 Feb 2016 19:49:43 +0000 (11:49 -0800)]
converted skiaserve PNGs from RGBA to RGB
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703893003
Review URL: https://codereview.chromium.org/
1703893003
msarett [Wed, 17 Feb 2016 19:26:55 +0000 (11:26 -0800)]
Do not create BmpMaskCodecs with invalid bits per pixel
BUG=skia:4962
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704063002
Review URL: https://codereview.chromium.org/
1704063002
joshualitt [Wed, 17 Feb 2016 19:20:26 +0000 (11:20 -0800)]
Add batch information to json
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1705093002
Review URL: https://codereview.chromium.org/
1705093002
cdalton [Wed, 17 Feb 2016 19:10:16 +0000 (11:10 -0800)]
Fix "^" in --match flag for nanobench SKPs
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1706923002
Review URL: https://codereview.chromium.org/
1706923002
senorblanco [Wed, 17 Feb 2016 18:59:47 +0000 (10:59 -0800)]
Remove 6-param applyCropRect() from lighting filters (GPU path).
This required adding a texture domain effect if the destination bounds are not contained within the source bounds.
BUG=skia:4502
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1698913004
Review URL: https://codereview.chromium.org/
1698913004
bsalomon [Wed, 17 Feb 2016 18:42:46 +0000 (10:42 -0800)]
Add a script to build and copy the command buffer shared library. This script will be used by the bots to test skia on the command buffer.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1699273002
NOTREECHECKS=true
NOTRY=true
BUG=skia:4957
Review URL: https://codereview.chromium.org/
1699273002
ethannicholas [Wed, 17 Feb 2016 18:30:27 +0000 (10:30 -0800)]
Revert of further skiaserve image performance improvements (patchset #1 id:1 of https://codereview.chromium.org/
1707453003/ )
Reason for revert:
Broke skiaserve GPU rendering
Original issue's description:
> further skiaserve image performance improvements
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1707453003
>
> Committed: https://skia.googlesource.com/skia/+/
68c063bf11c91b2b3b15cb93168cf2af9b2c642d
TBR=joshualitt@google.com,jcgregorio@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1708683002
bungeman [Wed, 17 Feb 2016 18:13:49 +0000 (10:13 -0800)]
Add request cache to SkFontHost_fontconfig.
The current code deduplicates SkTypeface instances as all font lookups
should for better use of the glyph cache. This adds a request cache as
well, so that repeated recent requests will return the cached result
instead of doing a full lookup.
BUG=chromium:424082, chromium:444894
Review URL: https://codereview.chromium.org/
1683883002
msarett [Wed, 17 Feb 2016 18:02:29 +0000 (10:02 -0800)]
Make SkPicture/SkImageGenerator default to SkCodec
Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.
Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.
Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.
Update all clients to use the default.
Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.
This is a rebased version of:
https://codereview.chromium.org/
1671193002/
TBR=reed@google.com
BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1699183004
Review URL: https://codereview.chromium.org/
1699183004
herb [Wed, 17 Feb 2016 18:00:07 +0000 (10:00 -0800)]
Simplified linear pipeline.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704583003
Review URL: https://codereview.chromium.org/
1704583003
ethannicholas [Wed, 17 Feb 2016 17:17:35 +0000 (09:17 -0800)]
further skiaserve image performance improvements
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1707453003
Review URL: https://codereview.chromium.org/
1707453003
halcanary [Wed, 17 Feb 2016 16:39:23 +0000 (08:39 -0800)]
bin/sync-and-gyp: pass --deps='...' to `gclient sync`.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1705063002
Review URL: https://codereview.chromium.org/
1705063002
msarett [Wed, 17 Feb 2016 16:26:31 +0000 (08:26 -0800)]
Individually enable and disable SkCodecs
BUG=skia:4956
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1702533004
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1702533004
ebrauer [Wed, 17 Feb 2016 16:04:00 +0000 (08:04 -0800)]
Updates Piex and uses it to obtain the DNG dimensions.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1659873002
Review URL: https://codereview.chromium.org/
1659873002
mtklein [Wed, 17 Feb 2016 15:23:36 +0000 (07:23 -0800)]
fast sk4f <-> sk4i SSE methods
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1707673002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1707673002
reed [Wed, 17 Feb 2016 15:15:29 +0000 (07:15 -0800)]
misc fixes to make float buffers work a little better
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703013002
TBR=fmalita
Review URL: https://codereview.chromium.org/
1703013002
mtklein [Wed, 17 Feb 2016 14:47:52 +0000 (06:47 -0800)]
dead code: really kill these off again
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1702343002
Review URL: https://codereview.chromium.org/
1702343002
mtklein [Wed, 17 Feb 2016 14:37:51 +0000 (06:37 -0800)]
come on, this is how you drive-by
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1708563002
Review URL: https://codereview.chromium.org/
1708563002
fmalita [Wed, 17 Feb 2016 14:17:12 +0000 (06:17 -0800)]
Use geometric mean when selecting a mipmap scale
Workaround for anisotropic mipmap quality issues.
R=reed@google.com,robertphillips@google.com
BUG=skia:4863,chromium:586894
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1697423002
Review URL: https://codereview.chromium.org/
1697423002
yujieqin [Wed, 17 Feb 2016 14:12:12 +0000 (06:12 -0800)]
Update PIEX version. This should solve the stack buffer overflow issue
BUG=skia:4902
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1690853003
Review URL: https://codereview.chromium.org/
1690853003
joshualitt [Wed, 17 Feb 2016 13:40:00 +0000 (05:40 -0800)]
Fix memory leak
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1706773002
Review URL: https://codereview.chromium.org/
1706773002
kkinnunen [Wed, 17 Feb 2016 07:15:40 +0000 (23:15 -0800)]
Do not try to use GL_texture_rectangle on GL ES
Do not try to use ARB_GL_texture_rectangle on GL ES.
Command buffer exposes it, but it's not recommended. It also
does not work with TexImage2D, and ANGLE does not
have support for it on with GL ES 3.0 source context.
Bug triggered only when trying to use command buffer in
GL ES 3.0 mode.
BUG=angleproject:1313
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1691853003
Review URL: https://codereview.chromium.org/
1691853003
mtklein [Wed, 17 Feb 2016 04:56:13 +0000 (20:56 -0800)]
These files must be in the gypi for GN to remove them...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1696373005
Review URL: https://codereview.chromium.org/
1696373005
mtklein [Wed, 17 Feb 2016 04:23:49 +0000 (20:23 -0800)]
restore empty files so that Chrome GN config can remove them...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1700023005
Review URL: https://codereview.chromium.org/
1700023005
iroth [Wed, 17 Feb 2016 03:17:01 +0000 (19:17 -0800)]
Fix linker errors when skia_ios target is used a dependency of an iOS app.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1701153002
Review URL: https://codereview.chromium.org/
1701153002
mtklein [Wed, 17 Feb 2016 03:06:15 +0000 (19:06 -0800)]
clean up more dead code
- SkSHA1 is unused
- SkRunnable is obsolete now that we have std::function
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1705583003
Review URL: https://codereview.chromium.org/
1705583003
mtklein [Wed, 17 Feb 2016 02:38:14 +0000 (18:38 -0800)]
Delete dead code. SkBitmapHasher has not been used since gm.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704783002
Review URL: https://codereview.chromium.org/
1704783002
kjlubick [Wed, 17 Feb 2016 00:14:23 +0000 (16:14 -0800)]
Add ability to fuzz images using scaling and different modes
This also fixes the tryAllocPixels/SkColorTable mismatch which was causing the
"Image might be too large (32 x 32)" problems.
BUG=skia:4952
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1698963003
Review URL: https://codereview.chromium.org/
1698963003
mtklein [Tue, 16 Feb 2016 22:33:08 +0000 (14:33 -0800)]
add back Sk4i
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1699293002
Review URL: https://codereview.chromium.org/
1699293002
mtklein [Tue, 16 Feb 2016 22:03:14 +0000 (14:03 -0800)]
MSAN: build libc++ with MSAN, link to it.
The errors that we see should now change to the unexplainable,
rather than the explainable errors at head.
We suspect that the original reason to blacklist was this,
not building libc++ with MSAN. So unblacklist everything to start fresh.
BUG=skia:4903,skia:4900
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1694353004
Review URL: https://codereview.chromium.org/
1694353004
senorblanco [Tue, 16 Feb 2016 21:26:56 +0000 (13:26 -0800)]
Remove 6-param applyCropRect() from lighting filters (raster path).
BUG=skia:4502
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1701133002
Review URL: https://codereview.chromium.org/
1701133002
msarett [Tue, 16 Feb 2016 21:24:54 +0000 (13:24 -0800)]
Make kInvalidConversion a fatal failure in DMSrcSink
We just need to abort early on tests that we know
are invalid conversions.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704433003
Review URL: https://codereview.chromium.org/
1704433003
msarett [Tue, 16 Feb 2016 21:16:39 +0000 (13:16 -0800)]
Add SkCodec to the CMake build
BUG=skia:4956
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1705503002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1705503002
cblume [Tue, 16 Feb 2016 21:00:01 +0000 (13:00 -0800)]
There is an unused rowBytes parameter being passed along.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1636873002
Review URL: https://codereview.chromium.org/
1636873002
robertphillips [Tue, 16 Feb 2016 20:09:36 +0000 (12:09 -0800)]
Change signature of SkSpecialImage::draw to take SkScalars
Review URL: https://codereview.chromium.org/
1704603002
halcanary [Tue, 16 Feb 2016 19:48:06 +0000 (11:48 -0800)]
bin/sync-and-gyp: start using gclient
stop using hard-to-maintain git-sync-deps
BUG=skia:4885
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1693963005
Review URL: https://codereview.chromium.org/
1693963005
bsalomon [Tue, 16 Feb 2016 19:36:56 +0000 (11:36 -0800)]
Remove outdated optimization to not flush for new textures in GrSWMaskHelper
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704593002
Review URL: https://codereview.chromium.org/
1704593002
bsalomon [Tue, 16 Feb 2016 19:36:47 +0000 (11:36 -0800)]
Workaround for bug in Tegra 3 when uploading to a render target
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703603002
Review URL: https://codereview.chromium.org/
1703603002
joshualitt [Tue, 16 Feb 2016 19:09:25 +0000 (11:09 -0800)]
Delete GrTextContext
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1699073004
Review URL: https://codereview.chromium.org/
1699073004
ethannicholas [Tue, 16 Feb 2016 19:03:04 +0000 (11:03 -0800)]
tuned skiaserve's png output for better performance
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704573002
Review URL: https://codereview.chromium.org/
1704573002
joshualitt [Tue, 16 Feb 2016 18:36:53 +0000 (10:36 -0800)]
Create GrPathRenderingDrawContext
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1701013002
Review URL: https://codereview.chromium.org/
1701013002
jcgregorio [Tue, 16 Feb 2016 18:31:07 +0000 (10:31 -0800)]
skiaserve: Change alpha setting from GET to POST.
GET shouldn't be used for things that change the state of the server.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1706443002
Review URL: https://codereview.chromium.org/
1706443002
benjaminwagner [Tue, 16 Feb 2016 18:09:40 +0000 (10:09 -0800)]
Change SkMatrix::fixedStepInX to return SkVector (of SkScalar) rather than SkFixed.
All users were immediately converting to SkScalar or SkFixed3232.
This method is not used in Chromium, Android, or Google3.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692013002
Review URL: https://codereview.chromium.org/
1692013002
djsollen [Tue, 16 Feb 2016 17:19:35 +0000 (09:19 -0800)]
Use a statically linked libhwui for testing.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1688383005
Review URL: https://codereview.chromium.org/
1688383005
senorblanco [Tue, 16 Feb 2016 17:11:18 +0000 (09:11 -0800)]
Image filters: change applyCropRect() to take a src rect.
Instead of taking the source bitmap and offset, we simply take the
source rect bounds, and make the caller responsible for computing it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1702683002
Review URL: https://codereview.chromium.org/
1702683002
mtklein [Tue, 16 Feb 2016 16:10:34 +0000 (08:10 -0800)]
SkOSFile_stdio: less ::
It's not clear why we wrote this file in this manner.
On OpenBSD, fileno is a macro, so ::fileno makes no sense.
Also remove some end-of-line whitespace.
BUG=skia:4953
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1695333003
Review URL: https://codereview.chromium.org/
1695333003
msarett [Tue, 16 Feb 2016 16:04:34 +0000 (08:04 -0800)]
Make png filter functions compatible with libpng
We hope to upstream these functions to libpng (a C library).
Let's make the code that Skia tests on look like the code
that we are submitting.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1699953002
Review URL: https://codereview.chromium.org/
1699953002
bsalomon [Tue, 16 Feb 2016 16:00:05 +0000 (08:00 -0800)]
Modify interface to GrPathUtils::convertCubicToQuads
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1694403003
Review URL: https://codereview.chromium.org/
1694403003
bsalomon [Tue, 16 Feb 2016 15:34:17 +0000 (07:34 -0800)]
Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1684313002
Committed: https://skia.googlesource.com/skia/+/
7ea5e28065e5eb797e95f5d81c1a65cf3209d741
Review URL: https://codereview.chromium.org/
1684313002
scroggo [Tue, 16 Feb 2016 14:59:18 +0000 (06:59 -0800)]
Make SkRWBuffer destruct safely
Check for NULL before calling unref.
Add a test.
BUG=483369
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1691383002
Review URL: https://codereview.chromium.org/
1691383002
joshualitt [Tue, 16 Feb 2016 14:47:52 +0000 (06:47 -0800)]
Remove last bit of privacy violation for GrAtlasTextBlob
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1698503002
Review URL: https://codereview.chromium.org/
1698503002
mtklein [Tue, 16 Feb 2016 14:42:51 +0000 (06:42 -0800)]
Setup for -Fast GCE bot.
I'd like a bot that has got optimization turned up to 11,
to let us test things that our Chrome-like bots normally can't.
(Not quite ready to commit this bot to -ffast-math yet.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704473002
Review URL: https://codereview.chromium.org/
1704473002
update-skps [Tue, 16 Feb 2016 14:42:46 +0000 (06:42 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1698013005
Review URL: https://codereview.chromium.org/
1698013005
reed [Mon, 15 Feb 2016 22:26:14 +0000 (14:26 -0800)]
starter kit for colorspaces
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692893003
TBR=jvanverth
Review URL: https://codereview.chromium.org/
1695353002
msarett [Mon, 15 Feb 2016 18:18:45 +0000 (10:18 -0800)]
Fix colorType/alphaType checks in SkCodec
Make getPixels() and startScanlineDecode() behave
consistently.
Require that kGray8 decodes are opaque.
Assert that creating the swizzler succeeds.
BUG=skia:4203
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1695473002
Committed: https://skia.googlesource.com/skia/+/
c7578b6cdd03b61f076ffc7956efd952d6c301c0
Review URL: https://codereview.chromium.org/
1695473002
reed [Mon, 15 Feb 2016 16:27:14 +0000 (08:27 -0800)]
make SkComposeShader.h private
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1697523003
Review URL: https://codereview.chromium.org/
1697523003
reed [Mon, 15 Feb 2016 15:48:35 +0000 (07:48 -0800)]
blitters for sRGB and float16
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1697863002
Review URL: https://codereview.chromium.org/
1697863002
brianosman [Sun, 14 Feb 2016 18:33:03 +0000 (10:33 -0800)]
Roll back ellipse logic for now. This was (probably) still wrong.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692303003
Review URL: https://codereview.chromium.org/
1692303003
update-skps [Sun, 14 Feb 2016 08:47:34 +0000 (00:47 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1696023002
Review URL: https://codereview.chromium.org/
1696023002
benjaminwagner [Fri, 12 Feb 2016 23:20:55 +0000 (15:20 -0800)]
Revert of Add infastructure for gl_SampleMask (patchset #6 id:100001 of https://codereview.chromium.org/
1690963003/ )
Reason for revert:
Several bots failing with error 'invalid profile "es" for version 320'.
Original issue's description:
> Add infastructure for gl_SampleMask
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1690963003
>
> Committed: https://skia.googlesource.com/skia/+/
533cefe5b9c7cec2592fc7ca00ee4cf69a26c094
TBR=egdaniel@google.com,bsalomon@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1693113002
msarett [Fri, 12 Feb 2016 23:00:10 +0000 (15:00 -0800)]
Revert of Fix colorType/alphaType checks in SkCodec (patchset #5 id:80001 of https://codereview.chromium.org/
1695473002/ )
Reason for revert:
Really bad images in Gold.
Original issue's description:
> Fix colorType/alphaType checks in SkCodec
>
> Make getPixels() and startScanlineDecode() behave
> consistently.
>
> Require that kGray8 decodes are opaque.
>
> Assert that creating the swizzler succeeds.
>
> BUG=skia:4203
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1695473002
>
> Committed: https://skia.googlesource.com/skia/+/
c7578b6cdd03b61f076ffc7956efd952d6c301c0
TBR=scroggo@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4203
Review URL: https://codereview.chromium.org/
1694023002
msarett [Fri, 12 Feb 2016 22:47:09 +0000 (14:47 -0800)]
Adding a tool to get images from skps
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1696763002
Review URL: https://codereview.chromium.org/
1696763002
reed [Fri, 12 Feb 2016 22:43:17 +0000 (14:43 -0800)]
re-emable u64 gm
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692903002
TBR=mtklein
Review URL: https://codereview.chromium.org/
1692903002
mtklein [Fri, 12 Feb 2016 22:19:06 +0000 (14:19 -0800)]
Revert of SkNx refactoring (patchset #4 id:60001 of https://codereview.chromium.org/
1690633003/ )
Reason for revert:
Precautionary revert for chromium:586487
Original issue's description:
> SkNx refactoring
>
> - add back Sk4i typedef
> - define SSE casts in terms of Sk4i
> * uint8 <-> float becomes uint8 <-> int <-> float
> * uint16 <-> float becomes uint16 <-> int <-> float
>
> This has the nice side effect of specializing uint8 <-> int
> and uint16 <-> int, which are useful in their own right.
>
> There are many cast specializations now, some of which call each other.
> I have tried to arrange them in some sort of sensible order, subject to
> the constraint that those called must precede those who call.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1690633003
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
c1eb311f4e98934476f1b2ad5d6de772cf140d60
TBR=herb@google.com,mtklein@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:586487
Review URL: https://codereview.chromium.org/
1696903002
mtklein [Fri, 12 Feb 2016 21:56:13 +0000 (13:56 -0800)]
Try fixing unused-variable warnings another way.
If we mark these as extern, the compiler won't complain they're unused.
This is an unsatisfying hack, but last time we tried to condition these
on non-NEON only, Chromium's GN linux ARM bot failed. They must not be
configured to use the NEON procs?
BUG=skia:4798
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1699473002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1699473002