Jakub Adam [Fri, 22 May 2015 07:29:16 +0000 (09:29 +0200)]
shadow_client: dispose encomsp and remdesk
Their threads were kept running after the client's exit.
Bernhard Miklautz [Fri, 22 May 2015 11:36:00 +0000 (13:36 +0200)]
Merge pull request #2638 from kwitaszczyk/master
Assign peer to settings when a new RDP module is being initialized.
Hardening [Fri, 22 May 2015 07:56:59 +0000 (09:56 +0200)]
Merge pull request #2640 from xsumbe00/master
winsock.c Solaris build fixes
Petr Sumbera [Thu, 21 May 2015 20:24:03 +0000 (13:24 -0700)]
winsock.c Solaris build fixes
Konrad Witaszczyk [Thu, 21 May 2015 14:54:19 +0000 (16:54 +0200)]
Assign peer to settings when a new RDP module is being initialized.
Bernhard Miklautz [Thu, 21 May 2015 14:21:09 +0000 (16:21 +0200)]
Merge pull request #2637 from nfedera/fix-shadow_client_context_cleanup
shadow/client context cleanup and unused vars fix
Marc-André Moreau [Thu, 21 May 2015 14:17:54 +0000 (10:17 -0400)]
Merge pull request #2583 from bceverly/OpenBSD-cleanup
Two minor source code changes to remove warnings
Norbert Federa [Thu, 21 May 2015 08:56:56 +0000 (10:56 +0200)]
shadow/client context cleanup and unused vars fix
Norbert Federa [Thu, 21 May 2015 14:04:26 +0000 (16:04 +0200)]
Merge pull request #2630 from hardening/new_2616
Add checks for some XXX_New and XXX_Add functions
Marc-André Moreau [Wed, 20 May 2015 20:26:31 +0000 (16:26 -0400)]
Merge pull request #2557 from realjiangms/shadow_fix_hang2395
shadow fix multi-client hang
Hardening [Wed, 20 May 2015 19:19:20 +0000 (21:19 +0200)]
Merge pull request #2632 from akallabeth/client_bandwidth_measurement_callback
Added client bandwidth measurement result callback.
David FORT [Wed, 20 May 2015 19:01:46 +0000 (21:01 +0200)]
Fixed declaration of xf_event_action_script_init()
David FORT [Wed, 20 May 2015 17:19:50 +0000 (19:19 +0200)]
Take in account nfedera's review
Bryan Everly [Wed, 20 May 2015 16:17:05 +0000 (12:17 -0400)]
Fixed mistake with bitwise operator in previous two commits
Bryan Everly [Wed, 20 May 2015 14:52:24 +0000 (10:52 -0400)]
Moved thread code to OpenBSD only
Armin Novak [Wed, 20 May 2015 08:47:24 +0000 (10:47 +0200)]
Added client bandwidth measurement result callback.
Marc-André Moreau [Wed, 20 May 2015 13:41:18 +0000 (09:41 -0400)]
Merge pull request #2633 from clivest/progressive_codec_new_surface_fix
Fix rounding error in progressive codec surface new
Marc-André Moreau [Wed, 20 May 2015 13:40:24 +0000 (09:40 -0400)]
Merge pull request #2635 from clivest/gdi_gfx_leaked_regions_fix
Fix two memory leaks in gdi/gfx
Clive Stevens [Wed, 20 May 2015 11:35:24 +0000 (12:35 +0100)]
Fix two cases of leaked regions in gdi/gfx
Clive Stevens [Wed, 20 May 2015 11:26:58 +0000 (12:26 +0100)]
Fix rounding error in progressive codec
The grid is composed of 64x64 blocks and should not be smaller
than the surface. If width or height were not a multiple of 64
the previous rounding resulted in a grid smaller than the surface.
David FORT [Tue, 19 May 2015 11:54:43 +0000 (13:54 +0200)]
Fixed last VirtualChannelEntry
David FORT [Tue, 19 May 2015 11:48:57 +0000 (13:48 +0200)]
Fixed functions that return BOOLs
Bernhard Miklautz [Tue, 19 May 2015 09:07:42 +0000 (11:07 +0200)]
Merge pull request #2627 from nfedera/fix-x11-polyregion
client/x11: fix + simplify invalidate_poly_region
Norbert Federa [Mon, 18 May 2015 23:07:51 +0000 (01:07 +0200)]
client/x11: fix + simplify invalidate_poly_region
Marc-André Moreau [Mon, 18 May 2015 12:55:48 +0000 (08:55 -0400)]
Merge pull request #2624 from kwitaszczyk/master
QueryContextAttributes shouldn't return an error when a user or a domain is empty.
Bernhard Miklautz [Mon, 18 May 2015 09:36:31 +0000 (11:36 +0200)]
smartcard: fix compiler warnings
gcc 4.7.2:
warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from
pointer target type
Hardening [Mon, 18 May 2015 09:28:00 +0000 (11:28 +0200)]
Add checks for some XXX_New and XXX_Add functions
Based on PR #2616
Konrad Witaszczyk [Mon, 18 May 2015 07:42:17 +0000 (09:42 +0200)]
QueryContextAttributes shouldn't return an error when a user or a domain
is empty.
Hardening [Sun, 17 May 2015 19:40:38 +0000 (21:40 +0200)]
Merge pull request #2623 from nfedera/fix-xfclient-if-semicolons
client/x11: fixed if statements with empty body
Norbert Federa [Sun, 17 May 2015 16:24:11 +0000 (18:24 +0200)]
client/x11: fixed if statements with empty body
Marc-André Moreau [Fri, 15 May 2015 12:37:10 +0000 (08:37 -0400)]
Merge pull request #2622 from kwitaszczyk/master
Pass valid context to CompleteAuthToken function in Negotiate Security Package.
Konrad Witaszczyk [Fri, 15 May 2015 11:02:40 +0000 (13:02 +0200)]
Pass valid context to CompleteAuthToken function in Negotiate Security Package.
Bernhard Miklautz [Fri, 15 May 2015 09:59:12 +0000 (11:59 +0200)]
Merge pull request #2621 from nfedera/fix-mac-async-transport
transport/mfreerdp: fix async transport
Norbert Federa [Thu, 14 May 2015 19:54:09 +0000 (21:54 +0200)]
transport/mfreerdp: fix async transport
- handle WAIT_TIMEOUT result as error in async transport thread
if an INFINITE timeout was specified in WaitForMultipleObjects
- fix mfreerdp's async transport handling to not use
freerdp_get_event_handles/freerdp_check_event_handles if async
transport is activated
Hardening [Thu, 14 May 2015 19:13:12 +0000 (21:13 +0200)]
Merge pull request #2620 from nfedera/fix-gdi-cache
gdi: fix nullification of instance->context->cache
Norbert Federa [Thu, 14 May 2015 18:33:21 +0000 (20:33 +0200)]
gdi: fix nullification of instance->context->cache
Hardening [Wed, 13 May 2015 06:24:35 +0000 (08:24 +0200)]
Merge pull request #2611 from nfedera/fix-async-transport-thread
transport: fixed multiple errors in async thread
Hardening [Tue, 12 May 2015 14:18:08 +0000 (16:18 +0200)]
Merge pull request #2613 from oshogbo/gethostname
At least at FreeBSD - the gethostname(3) function can fail.
Hardening [Tue, 12 May 2015 13:45:55 +0000 (15:45 +0200)]
Merge pull request #2612 from oshogbo/style
Function return bool, so lets return FALSE if 0 or TRUE if 1.
Mariusz Zaborski [Tue, 12 May 2015 13:33:42 +0000 (15:33 +0200)]
At least at FreeBSD - the gethostname(3) function can fail.
Check returned value.
Mariusz Zaborski [Tue, 12 May 2015 13:31:23 +0000 (15:31 +0200)]
Function return bool, so lets return FALSE if 0 or TRUE if 1.
Norbert Federa [Mon, 11 May 2015 19:54:36 +0000 (21:54 +0200)]
transport: fixed multiple errors in async thread
MartinHaimberger [Mon, 11 May 2015 14:59:32 +0000 (16:59 +0200)]
Merge pull request #2605 from nfedera/fix-2015-05-08-01
fixed multiple missing gdi return value checks
MartinHaimberger [Mon, 11 May 2015 08:14:30 +0000 (10:14 +0200)]
Merge pull request #2607 from nfedera/remove_free_null_checks
free can handle NULL perfectly fine
Norbert Federa [Mon, 11 May 2015 07:07:39 +0000 (09:07 +0200)]
free can handle NULL perfectly fine
zihao.jiang [Sun, 10 May 2015 16:00:02 +0000 (00:00 +0800)]
shadow fix multi-client hang
Merge from commit
d4df3a952b
Conflicts:
server/shadow/shadow_subsystem.c
Norbert Federa [Fri, 8 May 2015 19:39:23 +0000 (21:39 +0200)]
fixed multiple missing gdi return value checks
mainly gdi_Create* functions
Bernhard Miklautz [Fri, 8 May 2015 11:44:26 +0000 (13:44 +0200)]
Merge pull request #2594 from baruchsiach/fix-math-2
Don't disable C99 long double math on non Unix platforms
Norbert Federa [Fri, 8 May 2015 09:17:33 +0000 (11:17 +0200)]
Merge pull request #2577 from hardening/listen_from_socket
Add the ability to have listener from an existing socket
David FORT [Fri, 8 May 2015 08:07:29 +0000 (10:07 +0200)]
Return FALSE under Win32
David FORT [Fri, 8 May 2015 08:05:39 +0000 (10:05 +0200)]
Test the number of listening handles
David FORT [Tue, 7 Apr 2015 13:18:07 +0000 (15:18 +0200)]
Add the ability to have listener from an existing socket
Bernhard Miklautz [Thu, 7 May 2015 22:49:41 +0000 (00:49 +0200)]
Merge pull request #2596 from akallabeth/wlog_default_out_fix
Wlog console output to stderr
Hardening [Thu, 7 May 2015 17:06:59 +0000 (19:06 +0200)]
Merge pull request #2601 from nfedera/fix-2015-05-07-01
Fix some unchecked create calls
Norbert Federa [Thu, 7 May 2015 16:42:15 +0000 (18:42 +0200)]
Merge pull request #2597 from clivest/bitstream_read_fix
Fix bitstream reading bounds check
Norbert Federa [Thu, 7 May 2015 16:24:47 +0000 (18:24 +0200)]
Merge pull request #2598 from clivest/stream_leak_fix
Fix two cases of stream resource leak
Norbert Federa [Thu, 7 May 2015 16:15:01 +0000 (18:15 +0200)]
Merge pull request #2599 from hardening/fix_wayland_colors
Fix colors with the wayland client
Norbert Federa [Thu, 7 May 2015 16:13:09 +0000 (18:13 +0200)]
Merge pull request #2603 from hardening/rail_empty_title_fix
Fix empty window title
Norbert Federa [Thu, 7 May 2015 16:11:38 +0000 (18:11 +0200)]
Merge pull request #2604 from hardening/rail_fix
Fix remoteApps
Norbert Federa [Thu, 7 May 2015 15:42:01 +0000 (17:42 +0200)]
server/shadow: added missing error message
David FORT [Thu, 7 May 2015 13:08:00 +0000 (15:08 +0200)]
Fix empty window title
When the size of a RAIL string was 0, we were reporting an OOM error.
David FORT [Thu, 7 May 2015 12:36:07 +0000 (14:36 +0200)]
Fix remoteApps
The assert that have been removed were preventing RAIL from working when you
have an intermediary screen before seeing the application.
Norbert Federa [Tue, 5 May 2015 17:45:34 +0000 (19:45 +0200)]
Fix unchecked CreateDirectory calls
Norbert Federa [Tue, 5 May 2015 15:32:06 +0000 (17:32 +0200)]
Fix unchecked CreateSemaphore calls
Norbert Federa [Tue, 5 May 2015 15:25:17 +0000 (17:25 +0200)]
Fix unchecked CreateMutex calls
David FORT [Wed, 6 May 2015 19:54:39 +0000 (21:54 +0200)]
Fix colors with the wayland client
Clive Stevens [Wed, 6 May 2015 14:54:23 +0000 (15:54 +0100)]
Fix whitespace
Clive Stevens [Wed, 6 May 2015 14:26:06 +0000 (15:26 +0100)]
Fix bitstream reading
The bounds checks where previously incorrect
Clive Stevens [Wed, 6 May 2015 14:23:37 +0000 (15:23 +0100)]
Fix two cases of potentially leaked streams
Armin Novak [Wed, 6 May 2015 13:36:54 +0000 (15:36 +0200)]
Fixed broken indent.
Armin Novak [Wed, 6 May 2015 08:58:57 +0000 (10:58 +0200)]
Not writing messages if level is WLOG_OFF.
Armin Novak [Wed, 6 May 2015 08:56:30 +0000 (10:56 +0200)]
Console logging to stdout and stderr
With this patch the default for the console logger
changes to writing to stdout for TRACE, DEBUG and INFO
messages and stderr for WARNING, ERROR and FATAL messages.
Martin Fleisz [Wed, 6 May 2015 08:16:26 +0000 (10:16 +0200)]
Merge pull request #2592 from nfedera/fix-2015-05-05-01
Fix unchecked CreateThread calls and misc fixes
Baruch Siach [Tue, 5 May 2015 18:27:17 +0000 (21:27 +0300)]
Don't disable C99 long double math on non Unix platforms
CMakeLists.txt may enable HAVE_MATH_C99_LONG_DOUBLE only on Unix platforms.
Limit the effect of this symbol accordingly.
Bryan Everly [Tue, 5 May 2015 16:35:18 +0000 (12:35 -0400)]
Removed unnecessary include file.
Bryan Everly [Tue, 5 May 2015 16:33:44 +0000 (12:33 -0400)]
Simplified random byte stream generation code to use SSL RAND_bytes() and also eliminated two more compiler warnings.
Marc-André Moreau [Tue, 5 May 2015 14:56:12 +0000 (10:56 -0400)]
Merge pull request #2587 from floppym/armfix
Remove the ARM_FP_ABI option
Marc-André Moreau [Tue, 5 May 2015 14:47:03 +0000 (10:47 -0400)]
Merge pull request #2589 from baruchsiach/fix-math
Don't use unavailable C99 long double math functions
Norbert Federa [Tue, 5 May 2015 11:55:48 +0000 (13:55 +0200)]
Fix unchecked CreateThread calls and misc fixes
Bryan Everly [Mon, 4 May 2015 17:14:00 +0000 (13:14 -0400)]
Freed memory buffer that was allocated in previous commit.
Bryan Everly [Mon, 4 May 2015 13:53:15 +0000 (09:53 -0400)]
Fixed stream leak in modified code
MartinHaimberger [Mon, 4 May 2015 08:14:27 +0000 (10:14 +0200)]
Merge pull request #2582 from nfedera/fix-2015-04-28-01
Fix unchecked CreateEvent calls and misc fixes
Baruch Siach [Sun, 3 May 2015 17:46:22 +0000 (20:46 +0300)]
Don't use unavailable C99 long double math functions
uClibc variants do not provide the C99 long double math functions like ceill,
powl, etc.. For future compatibility use check_symbol_exists() to check
whether these functions are available, and keep the result in
HAVE_MATH_C99_LONG_DOUBLE. Use that instead of the fragile Cygwin version
check in triodef.h.
Fixes build failures under uClibc(-ng) like:
../../libwinpr/utils/libwinpr-utils.so.0.1.0: undefined reference to `powl'
../../libwinpr/utils/libwinpr-utils.so.0.1.0: undefined reference to `fmodl'
../../libwinpr/utils/libwinpr-utils.so.0.1.0: undefined reference to `ceill'
../../libwinpr/utils/libwinpr-utils.so.0.1.0: undefined reference to `log10l'
../../libwinpr/utils/libwinpr-utils.so.0.1.0: undefined reference to `floorl'
collect2: error: ld returned 1 exit status
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Bryan Everly [Sat, 2 May 2015 16:06:18 +0000 (12:06 -0400)]
Fixed unchecked malloc() error
Mike Gilbert [Fri, 1 May 2015 21:35:21 +0000 (17:35 -0400)]
Remove the ARM_FP_ABI option
It's unclear why this option would be necessary, and it causes problems
when people do not match it to their toolchain and CFLAGS.
To set the float abi, either use a toolchain with an appropriate default
or set the float-abi option in the CFLAGS environment variable.
This should resolve #2586.
Bryan Everly [Thu, 30 Apr 2015 14:12:37 +0000 (10:12 -0400)]
Changed the xf_tsmf.c code to test for zero visible rectangles for all platforms. Modified arc4random() change to actually have a skeletal implementation in winpr for BCryptGenRandom() on all platforms.
Bernhard Miklautz [Thu, 30 Apr 2015 12:20:33 +0000 (14:20 +0200)]
Merge pull request #2584 from baruchsiach/fix-eventfd-2
Fix build with newer uclibc versions
Norbert Federa [Thu, 30 Apr 2015 07:20:34 +0000 (09:20 +0200)]
Increase API version to 1.2.3
Baruch Siach [Tue, 28 Apr 2015 06:30:45 +0000 (09:30 +0300)]
Fix build with newer uclibc versions
uClibc master branch, as well as uclibc-ng add eventfd_{read,write}
definitions. Instead of testing for __UCLIBC__, have cmake explicitly check
for the existence of eventfd_read and save the result in
WITH_EVENTFD_READ_WRITE.
Fixes build errors like:
.../winpr/libwinpr/synch/event.c:120:12: error: static declaration of 'eventfd_read' follows non-static declaration
static int eventfd_read(int fd, eventfd_t* value)
^
In file included from .../winpr/libwinpr/synch/event.c:39:0:
.../usr/include/sys/eventfd.h:37:12: note: previous declaration of 'eventfd_read' was here
extern int eventfd_read (int __fd, eventfd_t *__value);
^
.../winpr/libwinpr/synch/event.c:125:12: error: static declaration of 'eventfd_write' follows non-static declaration
static int eventfd_write(int fd, eventfd_t value)
^
In file included from .../winpr/libwinpr/synch/event.c:39:0:
.../usr/include/sys/eventfd.h:40:12: note: previous declaration of 'eventfd_write' was here
extern int eventfd_write (int __fd, eventfd_t __value);
Norbert Federa [Tue, 28 Apr 2015 15:00:41 +0000 (17:00 +0200)]
Fix unchecked CreateEvent calls and misc fixes
1)
Added missing checks for CreateEvent which also required the
following related changes:
- changed freerdp_context_new API to BOOL
- changed freerdp_peer_context_new API to BOOL
- changed pRdpClientNew callback to BOOL
- changed pContextNew callback to BOOL
- changed psPeerAccepted callback to BOOL
- changed psPeerContextNew callback to BOOL
2)
Fixed lots of missing alloc and error checks in the
changed code's neighbourhood.
3)
Check freerdp_client_codecs_prepare result to avoid segfaults
caused by using non-initialized codecs.
4)
Fixed deadlocks in x11 caused by missing xf_unlock_x11() calls
in some error handlers
5)
Some fixes in thread pool:
- DEFAULT_POOL assignment did not match TP_POOL definition
- don't free the pool pointer if it points to the static DEFAULT_POOL
- added error handling and cleanup in InitializeThreadpool
Norbert Federa [Wed, 29 Apr 2015 16:04:59 +0000 (18:04 +0200)]
Merge pull request #2579 from akallabeth/mutex_debug_log
winpr mutex unlock on destroy
Armin Novak [Wed, 29 Apr 2015 06:48:07 +0000 (08:48 +0200)]
Added EBUSY to success states.
Armin Novak [Tue, 28 Apr 2015 15:29:07 +0000 (17:29 +0200)]
Better error handling on mutex destroy.
Bryan Everly [Tue, 28 Apr 2015 14:50:29 +0000 (10:50 -0400)]
Fixed linker warning about insecure crypto and fixed compiler warning about unsigned being compared to less than zero
Hardening [Tue, 28 Apr 2015 12:43:30 +0000 (14:43 +0200)]
Merge pull request #2578 from jonathankap/master
Fix issue when numWindowIds is 0
Armin Novak [Tue, 28 Apr 2015 07:42:46 +0000 (09:42 +0200)]
Ensuring mutex is unlocked on destroy.
Jonathan Kaplan [Tue, 28 Apr 2015 07:21:38 +0000 (00:21 -0700)]
Fix issue when numWindowIds is 0
Armin Novak [Tue, 28 Apr 2015 06:55:26 +0000 (08:55 +0200)]
Added mutex debug flag.
When mutex debugging is enabled now a stack trace
is logged, if a mutex is locked on destruction.
Norbert Federa [Mon, 27 Apr 2015 07:34:13 +0000 (09:34 +0200)]
Merge pull request #2575 from bmiklautz/gdi_fix
gdi: fix problem with gdi_SelectObject check(s)
Bernhard Miklautz [Sun, 26 Apr 2015 20:28:49 +0000 (22:28 +0200)]
gdi: fix problem with gdi_SelectObject check(s)
When a hdc is created no initial or default objects are created
therefore can the first call of gdi_SelectObject return NULL.
Because of this checking the return value of gdi_SelectObject failed
for newly create hdc causing errors (disconnects).
Since all types of HGDIOBJECT are handled and the return value of
gdi_SelectObject isn't used the recently added checks were removed
again.