Father Chrysostomos [Wed, 30 Nov 2011 04:12:56 +0000 (20:12 -0800)]
hv.h: Don’t call a char * parameter ‘sv’!
This goes all the way back to
bbce6d6978 (inseparable changes from
patch from perl5.003_08 to perl5.003_09). It is mightily confusing
for anyone trying to figure out how these things work.
Father Chrysostomos [Wed, 30 Nov 2011 04:08:51 +0000 (20:08 -0800)]
hv.h: remove obsolete comment
This comment was made obsolete by commit
bc5cdc2388.
Father Chrysostomos [Wed, 30 Nov 2011 02:04:35 +0000 (18:04 -0800)]
sv.c/find_uninit_var: Explain kid-scanning loop better
Hopefully this explanation will be clearer and will prevent clumsy
individuals like me from introducing bugs like #103766.
Father Chrysostomos [Wed, 30 Nov 2011 01:59:26 +0000 (17:59 -0800)]
sv.c: typo
Father Chrysostomos [Tue, 29 Nov 2011 02:31:55 +0000 (18:31 -0800)]
panic after cow-to-stash assignment
This type of thing isn’t officially supported, but perl shouldn’t be
freeing unallocated memory (the 9th octet of a freed HEK) as a result:
$::{whatever} = __PACKAGE__;
*{"whatever"};
A string stored in the symbol table like that is actually a subroutine
stub. ‘sub foo($)’ is stored as '$' in the "foo" slot to save space.
gv_init_pvn (formerly known as gv_init) checks SvPOK first thing,
assuming, if it is set, that it can reuse SvPVX as the CV’s prototype,
without reallocating or copying it. That works most of the time.
For COW strings (such as those returned by __PACKAGE__), SvPVX points
to the hek_key field (the 9th octet) of a shared HEK. When the CV is
freed, it ends up trying to do Safefree(that_hek + 8) effectively,
which is bad.
Nicholas Clark [Mon, 28 Nov 2011 15:40:28 +0000 (15:40 +0000)]
As perldoc is linked from perl.pod, it shouldn't be in perltoc's sin list.
perldoc has a manpage prominently linked from the perl manpage. Hence it
makes no sense to also have it listed at the end of perltoc in the section
described as "Here should be listed all the extra programs' documentation,
but they don't all have manual pages yet"
Nicholas Clark [Mon, 28 Nov 2011 14:38:55 +0000 (14:38 +0000)]
Eliminate vestigial reference to unpushed.h from descrip_mms.template
Commit
dcff826f70bf3f64 renamed unpushed.h to git_version.h in early 2009.
So code to delete it is no longer needed :-)
Nicholas Clark [Sun, 27 Nov 2011 22:02:54 +0000 (23:02 +0100)]
pod/buildtoc now generates pod/roffitall
roffitall remains a shell script, identical apart from a dynamically
generated list of man pages (and removal of the comment from 2000 that
this should be done).
Tony Cook [Mon, 28 Nov 2011 07:18:25 +0000 (18:18 +1100)]
avoid double defining the POSIX::TCSANOW constant sub
On Win32 which has no native TCSANOW definition this would produce:
Constant subroutine TCSANOW redefined at ../lib/POSIX.pm line -1.
because the macro wasn't defined when building the unknown symbols
table but was defined when building the defined symbols table.
Father Chrysostomos [Mon, 28 Nov 2011 02:37:14 +0000 (18:37 -0800)]
sv.c: Turn a FIXME comment into an explanation
Father Chrysostomos [Mon, 28 Nov 2011 02:27:09 +0000 (18:27 -0800)]
Remove duplicate comment from sv.h
The ‘or lexical’ in this ‘glob or lexical is just a copy’ comment was
added in perl 5.001 (
748a9306), which added closures.
This comment was later duplicated in commit
120ff8e9d (‘Document a
sixth use for SVf_FAKE’), but in a clearer fashion.
This commit removes the ‘or lexical’ part, as it is now confusing.
Chris 'BinGOs' Williams [Sun, 27 Nov 2011 21:03:49 +0000 (21:03 +0000)]
Update Module-Loaded to CPAN version 0.08
[DELTA]
Changes for 0.08 Sun Nov 27 20:44:00 GMT 2011
=================================================
* Remove trailing spaces and update Makefile.PL
Nicholas Clark [Sun, 27 Nov 2011 20:26:46 +0000 (21:26 +0100)]
Fix two bugs related to pod files outside of pod/
Commit
1721346e4e420217, which allowed buildtoc to handle files outside of
pod/, had two bugs when processing files from outside of pod/
Firstly, the call to podset() for the core pods needs to pass in the short
name of the pod, not the name with the path in it (ie $_->[4], not $_->[1]),
else the =head2 entry for that pod will have the pathname in it.
Secondly, buildtoc must take care to avoid outputting the contents for these
pods twice - once when read from cpan/ or dist/ using the path in pod.lst,
and once from the file as found in lib/
Father Chrysostomos [Sun, 27 Nov 2011 19:41:44 +0000 (11:41 -0800)]
[perl #99850] SEGV when destructor undefs goto &sub
If goto &sub triggers a destructor that undefines &sub, a
crash ensues.
This commit adds an extra check in pp_goto after the unwinding of the
previous sub’s scope.
Father Chrysostomos [Sun, 27 Nov 2011 19:07:44 +0000 (11:07 -0800)]
typo in perlre.pod
Peter Martini [Fri, 25 Nov 2011 23:23:53 +0000 (18:23 -0500)]
Change a semicolon to a colon. This is necessary for the shared mem example to compile
Nicholas Clark [Sun, 27 Nov 2011 12:05:11 +0000 (13:05 +0100)]
Fix two post 5.15.0 perltoc.pod generation bugs.
Commit
1721346e4e420217, which allowed buildtoc to handle files outside of
pod, changed the number of entries in the master structure, but missed
changing one test from 3 to 5, which resulted in all the core documentation
being omitted from the generated perltoc.pod
Commit
f37610d895e1d30b, which eliminated the use of absolute pathnames,
failed to change two regular expressions in the subroutine passed to
File::Find::find(), which resulted in all module pod filenames having
lib/ prepended, and thus all modules being treated as pragmata.
This commit also contained an error in the call to podset() for the core
documentation, which wasn't noticed because that code was never called,
due to the bug introduced by commit
1721346e4e420217.
perltoc.pod now builds correctly once again. Whether anyone uses it is
another matter.
Nicholas Clark [Sat, 26 Nov 2011 21:20:30 +0000 (22:20 +0100)]
In roffitall, explicitly use perl to run rofftoc.
Previously roffitall invoked rofftoc as ./rofftoc (implying a shell script),
and in turn rofftoc used the "sh or perl" construction to cause sh to pass
itself to perl. This was a bit obfuscated at the best of times, and broke
completely when commit
ff906f87ce151941 removed execute permission in 2010.
Father Chrysostomos [Sun, 27 Nov 2011 02:17:45 +0000 (18:17 -0800)]
[perl #97980] Stop tied() from returning a copy
Now tied() returns the actual scalar used to hold the tie object,
so one can write weaken(tied $foo).
Father Chrysostomos [Sun, 27 Nov 2011 00:58:56 +0000 (16:58 -0800)]
Make inlined &CORE::__SUB__ the right-sized op
In commit
1a35f9ffb I forgot to make an inlined OP_RUNCV op a PVOP in
ck_entersub_args_core (which inlines a &CORE::sub).
This caused crashes on Linux, but not on OS X, for some reason.
Father Chrysostomos [Sat, 26 Nov 2011 23:55:48 +0000 (15:55 -0800)]
[perl #98352] perlre: Clarify visibility of $1 in (??{...})
Father Chrysostomos [Sat, 26 Nov 2011 23:39:05 +0000 (15:39 -0800)]
Oops!
Well, I at least ran test_porting after making that ‘only doc’ change!
But then I committed with -a by mistake. Oh well.
Father Chrysostomos [Sat, 26 Nov 2011 20:49:52 +0000 (12:49 -0800)]
sv.h: Consistent use of spaces after dots
Father Chrysostomos [Sat, 26 Nov 2011 20:42:55 +0000 (12:42 -0800)]
[perl #97632] Improve SvTAINT docs
Copied almost verbatim from text supplied by Kevin Ryde.
Father Chrysostomos [Sat, 26 Nov 2011 19:46:58 +0000 (11:46 -0800)]
Remove ‘no warnings deprecated’ from two .t’s
This was added to avoid the warning from $[, but these two test
scripts no longer mention $[.
Father Chrysostomos [Sat, 26 Nov 2011 07:04:22 +0000 (23:04 -0800)]
Optimise substr assignment in void context
In void context we can optimise
substr($foo, $bar, $baz) = $replacement;
to something like
substr($foo, $bar, $baz, $replacement);
except that the execution order must be preserved. So what we actu-
ally do is
substr($replacement, $foo, $bar, $baz);
with a flag to indicate that the replacement comes first. This means
we can also optimise assignment to two-argument substr the same way.
Although optimisations are not supposed to change behaviour,
this one does.
• It stops substr assignment from calling get-magic twice, which means
the optimisation makes things less buggy than usual.
• It causes the uninitialized warning (for an undefined first argu-
ment) to mention the substr operator, as it did before the previous
commit, rather than the assignment operator. I think that sort of
detail is minor enough.
I had to make the warning about clobbering references apply whenever
substr does a replacement, and not only when used as an lvalue. So
four-argument substr now emits that warning. I would consider that a
bug fix, too.
Also, if the numeric arguments to four-argument substr and the
replacement string are undefined, the order of the uninitialized warn-
ings is slightly different, but is consistent regardless of whether
the optimisation is in effect.
I believe this will make 95% of substr assignments run faster. So
there is less incentive to use what I consider the less readable form
(the four-argument form, which is not self-documenting).
Since I like naïve benchmarks, here are Before and After:
$ time ./miniperl -le 'do{$x="hello"; substr ($x,0,0) = 34;0}for 1..1000000'
real 0m2.391s
user 0m2.381s
sys 0m0.005s
$ time ./miniperl -le 'do{$x="hello"; substr ($x,0,0) = 34;0}for 1..1000000'
real 0m0.936s
user 0m0.927s
sys 0m0.005s
Father Chrysostomos [Sat, 26 Nov 2011 00:22:01 +0000 (16:22 -0800)]
Don’t coerce $x immediately in foo(substr $x...)
This program:
#!perl -l
sub myprint { print @_ }
print substr *foo, 1;
myprint substr *foo, 1;
produces:
main::foo
Can't coerce GLOB to string in substr at - line 4.
Ouch!
I would expect \substr simply to give me a scalar that peeks into the
original string, but without modifying the original until the return
value of \substr is actually assigned to.
But it turns out that it coerces the original into a string immedi-
ately, unless it’s GMAGICAL. I find the exception for magical varia-
ble rather befuddling. I can only imagine it was for efficency (since
the stringified form will be overwritten when magic_setsubstr calls
SvGETMAGIC), but that doesn’t make sense as the original variable can
itself be modified between the return of the special lvalue and the
assignment to that lvalue.
Since magic_setsubstr itself coerces the variable into a string upon
assignment to the lvalue, we can just remove the coercion code from
pp_substr.
But that causes double uninitialized warnings in cases like
substr($undef, 0,0) = "lrep".
That happens because pp_substr is still stringifying the variable (but
without modifying it). It has to do that, as it looks at the length
of the original string and accordingly adjusts the offsets stored in
the lvalue if they are negative or if they extend beyond the end of
the string.
So this commit takes the simple route of avoiding the warning in
pp_substr by only stringifying a variable that is SvOK if called in
lvalue context.
Hence, assignment to substr($tied...) will continue to call FETCH
twice, but that is not a new bug.
The ideal solution would be for the offsets to be translated in mg.c,
rather than in pp_substr. But that would be a more involved change
(including most of this commit, which is therefore not wasted) with
potential backward-compatibility issue with negative numbers.
A side effect it that the ‘Attempt to use reference as lvalue in
substr’ warning now occurs during the assignment to the substr lvalue,
rather that substr itself. This means it occurs even for tied varia-
bles, so things are now more consistent.
The example at the beginning could still croak if the glob were
replaced with a null string, so this commit only partially allevi-
ates the pain.
Father Chrysostomos [Fri, 25 Nov 2011 21:36:29 +0000 (13:36 -0800)]
Optimise __SUB__ to a constant
If __SUB__ is not inside a closure, it can be optimised to a constant.
We can only do this in the peephole optimiser, as we cannot tell
whether PL_compcv will become a closure until we reach the end
of the sub.
The __SUB__ op cannot simply be replaced with a const op, as the par-
ent op is not readily available in the peephole optimiser and, hence,
we cannot change its pointer.
So we have to convert the runcv op itself into a const op. So it
has to be the same size. This commit makes it a PVOP, since newPVOP,
unlike newSVOP, allows a null pv. To avoid adding workarounds to B
modules, I put an exception in newPVOP’s assertion, instead of chang-
ing the type in regen/opcodes.
But B::Deparse still had to be updated to avoid infinite recursion.
Chris 'BinGOs' Williams [Sat, 26 Nov 2011 21:22:55 +0000 (21:22 +0000)]
Update Unicode-Collate to CPAN version 0.87
[DELTA]
0.87 Sat Nov 26 17:01:42 2011
- Now Locale/*.pl files are searched in @INC. (see [rt.cpan.org #72666])
- added locale_version method to access the version number of Locale/*.pl.
Ricardo Signes [Sat, 26 Nov 2011 01:26:45 +0000 (20:26 -0500)]
correct some erroneous linking in 5.14.0 delta
Chris 'BinGOs' Williams [Fri, 25 Nov 2011 22:12:44 +0000 (22:12 +0000)]
Add AutoLoader upgrade to perldelta
Chris 'BinGOs' Williams [Fri, 25 Nov 2011 22:09:52 +0000 (22:09 +0000)]
Update B-Debug to CPAN version 1.17
[DELTA]
1.17 2011-11-25 rurban
* FSF address change
Nicholas Clark [Fri, 25 Nov 2011 17:39:04 +0000 (18:39 +0100)]
bisect.pl avoids perl-5.004 and earlier on case insensitive systems.
bisect.pl now probes to see if the checkout is on a case insensitive file
system (such as the default HFS+ on OS X), and if so, uses perl-5.005 as
the earliest stable release to test.
This should make bisect.pl "just work" on a typical OS X system, for the
vast majority of use cases.
Nicholas Clark [Fri, 25 Nov 2011 15:32:26 +0000 (16:32 +0100)]
bisect-runner.pl now builds back to 5.005 on the default OS X filesystem.
OS X defaults to case-insensitive HFS+. perl-5.8.0 and later have hints
files to avoid a clash between Makefile and makefile, and hence can build
without problems. Teaching bisect-runner.pl to replicate this hints tweak
allows it to build perl-5.6.0 and perl-5.005 on a default HFS+.
However, only do this for a case insensitive filesystem, else it breaks
the build for 5.003 and earlier (which hardcode 'makefile' in places).
perl-5.004 and earlier won't work on a default HFS+ without a *lot* of
bodgery, as the distribution from that era has two files, Configure and
configure, which trample over each other and confuse git. There are case
clashes in later revisions, which may create unexpected failures for
some actions (versus the same action on a case sensitive file system) but
they don't appear to affect building any 5.*.0 revisions.
bisect-runner.pl can build back to 5.002 on OS X on a case sensitive HFS+
file system.
Nicholas Clark [Fri, 25 Nov 2011 11:19:45 +0000 (12:19 +0100)]
bisect-runner.pl should avoid ext/Hash/Util/FieldHash being built twice.
Commit
550428fe486b1888 stopped the invocation of ext/Hash/Util/Makefile.PL
automatically recursing to ext/Hash/Util/FieldHash/Makefile.PL, as make_ext
was also calling it directly. This then resulted in two makes running in
parallel in ext/Hash/Util/FieldHash, which could all end in tears (and
failed builds). Hence we need to apply this fix if it isn't present, to
avoid spurious build failures during bisect runs.
Nicholas Clark [Fri, 25 Nov 2011 10:41:14 +0000 (11:41 +0100)]
bisect-runner.pl can now build on AIX back to perl-5.002
Two "one line" fixes to Configure and pp_sys.c are enough to get all .0
stable releases to build. perl-5.001n also builds as far as miniperl.
This makes bisect.pl useful for diagnosing problems on AIX.
Nicholas Clark [Fri, 25 Nov 2011 09:58:16 +0000 (10:58 +0100)]
In bisect-runner.pl, fall back to context diffs for ancient patch binaries.
AIX supplies a pre-historic patch program, which certainly predates Linux
and is probably older than NT. It can't cope with unified diffs. Meanwhile,
it's hard enough to get git diff to output context diffs, let alone git show,
and nearly all the patches embedded here are unified. So it seems that the
path of least resistance is to convert unified diffs to context diffs.
Nicholas Clark [Wed, 23 Nov 2011 21:51:13 +0000 (22:51 +0100)]
In bisect-runner.pl, only shell out to patch from apply_patch().
Previously the system's patch binary was invoked from 3 places. Refactoring
the code to only call it from one place will make it easier to work around
ancient versions of patch that some vendors still supply.
Konovalov, Vadim (Vadim)** CTR ** [Fri, 25 Nov 2011 09:10:24 +0000 (09:10 +0000)]
.\win32\mdelete.bat not needed
From: "Konovalov, Vadim (Vadim)** CTR **" <vadim.konovalov@alcatel-lucent.com>
Subject: [PATCH v5.15.5-187] .\win32\mdelete.bat not needed
Date: Thu, 24 Nov 2011 21:48:26 +0100
Message-ID: <
35BF8D9716175C43BB9D67CA60CC345E2E0284DD@FRMRSSXCHMBSC2.dc-m.alcatel-lucent.com>
Father Chrysostomos [Fri, 25 Nov 2011 03:20:00 +0000 (19:20 -0800)]
Don’t warn for foo+1 with ($) proto
Commit
22393538 added the warning for (;$) prototypes, but
ended up adding it for ($) as well.
Father Chrysostomos [Fri, 25 Nov 2011 01:43:38 +0000 (17:43 -0800)]
evalbytes should ignore outer utf8 declaration
A slight mistake in the evalbytes.t test script caused a lot of tests
not be testing what they were supposed to be testing for. I used
'qq(\x...)' instead of qq('\x...'). (I.e., I was trying to embed lit-
eral Unicode characters in the string, rather than pass escapes to
evalbytes.)
I had wondered at the time why it worked without my doing anything, so
I probably should have looked deeper.
Steffen Mueller [Thu, 24 Nov 2011 18:21:05 +0000 (19:21 +0100)]
Upgrade AutoLoader to 5.72
Mostly just a FSF address update.
Father Chrysostomos [Thu, 24 Nov 2011 16:52:59 +0000 (08:52 -0800)]
regen pod issues
Father Chrysostomos [Thu, 24 Nov 2011 16:52:52 +0000 (08:52 -0800)]
perlgpl.pod: wrap long line
Father Chrysostomos [Thu, 24 Nov 2011 16:36:54 +0000 (08:36 -0800)]
Increase $SelfLoader::VERSION to 1.19
Dominic Hargreaves [Thu, 24 Nov 2011 16:08:04 +0000 (16:08 +0000)]
Update references to the FSF's postal address
Father Chrysostomos [Thu, 24 Nov 2011 16:27:13 +0000 (08:27 -0800)]
Test ambiguous warning with (;$) proto
Matthew Horsfall (alh) [Tue, 23 Aug 2011 03:32:10 +0000 (23:32 -0400)]
When parsing subs with user-defined prototypes, store information needed to throw warnings
Father Chrysostomos [Thu, 24 Nov 2011 09:33:33 +0000 (01:33 -0800)]
Suppress ‘once’ warning in gmagic.t
Father Chrysostomos [Thu, 24 Nov 2011 09:22:38 +0000 (01:22 -0800)]
Add lib/perl5db/t/rt-104168 to MANIFEST
Peter Scott [Thu, 24 Nov 2011 09:21:29 +0000 (01:21 -0800)]
The attached patch adds to the debugger a capability I thought about
ages ago and which turned out to be absurdly easy to implement. It adds
an optional parameter to the t(race) command, a maximum number of stack
frames to trace below the current one:, e.g.:
t 3 - turn tracing on, trace up to 3 levels below current depth, be
silent below that
t 2 fnord() - trace up to 2 levels deep in execution of fnord()
Since it is backwards compatible I added it to the legacy command set as
well, but that's certainly debatable.
Father Chrysostomos [Thu, 24 Nov 2011 09:18:46 +0000 (01:18 -0800)]
‘Inline’ S_sv_unglob
S_sv_unglob is only called in one place, so inline it (but cheat, to
preserve blame history).
Father Chrysostomos [Thu, 24 Nov 2011 09:16:32 +0000 (01:16 -0800)]
Make COW-clobbering faster
There is this special SV_COW_DROP_PV flag that gets passed to
sv_force_normal_flags to signal that the SV is about to be clobbered,
so there is no point in allocating a new PV. But this flag was not
actually being used, until the previous commit commandeered it for
globs (despite the name).
Now it actually does what it says.
Before and after:
$ time ./perl -e '$x = __PACKAGE__, undef $x for 1..8000000'
real 0m5.758s
user 0m5.740s
sys 0m0.008s
$ time ./perl -e '$x = __PACKAGE__, undef $x for 1..8000000'
real 0m3.290s
user 0m3.282s
sys 0m0.006s
Father Chrysostomos [Thu, 24 Nov 2011 09:09:14 +0000 (01:09 -0800)]
Make assignment over glob copies much faster
sv_force_normal is passed the SV_COW_DROP_PV flag if the scalar is
about to be written over. That flag is not currently used. We can
speed up assignment over fake GVs a lot by taking advantage of the flag.
Before and after:
$ time ./perl -e '$x = *foo, undef $x for 1..2000000'
real 0m4.264s
user 0m4.248s
sys 0m0.007s
$ time ./perl -e '$x = *foo, undef $x for 1..2000000'
real 0m1.820s
user 0m1.812s
sys 0m0.005s
Father Chrysostomos [Thu, 24 Nov 2011 07:32:30 +0000 (23:32 -0800)]
Call FETCH once for rcatline
Father Chrysostomos [Thu, 24 Nov 2011 04:40:06 +0000 (20:40 -0800)]
lib/version.t: suppress warning
Father Chrysostomos [Thu, 24 Nov 2011 04:31:55 +0000 (20:31 -0800)]
perlfunc: Don’t put __SUB__ between substr entries
I made the mistake of putting it after the first =item substr,
instead of before it.
Father Chrysostomos [Thu, 24 Nov 2011 04:26:51 +0000 (20:26 -0800)]
sysread should not ignore magic on its buffer
sysread uses SvPV_force, which has a bug in it. Even if the SV_GMAGIC
flag is passed to sv_pvn_force_flags (which SvPV_force does), it
ignores magic in any typeglob argument.
Father Chrysostomos [Thu, 24 Nov 2011 01:48:47 +0000 (17:48 -0800)]
Make sselect call fetch once
Not only does this commit make four-argument select call fetch once
on each argument (instead of sometimes 0 times), but it also checks
whether the argument is a string after calling fetch now, instead of
before, in determining whether to warn about a non-string.
Father Chrysostomos [Wed, 23 Nov 2011 21:41:52 +0000 (13:41 -0800)]
Move substr tests under t/op
Commit
a4499558 moved them under t/re along with the subst tests, but
these are unrelated to regexps.
Father Chrysostomos [Wed, 23 Nov 2011 21:29:48 +0000 (13:29 -0800)]
Call FETCH once when chomping a tied ref
Father Chrysostomos [Wed, 23 Nov 2011 21:11:48 +0000 (13:11 -0800)]
pp.c: Remove useless read-only check from S_do_chomp
After sv_force_normal_flags, the scalar will no longer be read-only,
except in those cases where sv_force_normal_flags croaks. So this
check will never be true when SvFAKE was true.
Father Chrysostomos [Wed, 23 Nov 2011 21:03:06 +0000 (13:03 -0800)]
Call FETCH once for $tied_ref =~ y/a/b/
Father Chrysostomos [Wed, 23 Nov 2011 20:52:33 +0000 (12:52 -0800)]
Increase $IO::File::VERSION to 1.16
Father Chrysostomos [Wed, 23 Nov 2011 20:52:20 +0000 (12:52 -0800)]
Remove ‘use File::Spec’ from IO::File
It is not using it any more.
Father Chrysostomos [Wed, 23 Nov 2011 20:50:38 +0000 (12:50 -0800)]
__SUB__ should warn in void context
Father Chrysostomos [Wed, 23 Nov 2011 20:47:50 +0000 (12:47 -0800)]
Use correct err msg in XS version check
When an XS module’s version is checked when it is loading, the string
"version" should be treated the same way as "versions" and emit the
‘Invalid version format’ error, instead of being treated as a version
object at first and then rejected by the validator with the ‘Invalid
version object’ error.
See also perl #102586.
Father Chrysostomos [Wed, 23 Nov 2011 20:34:49 +0000 (12:34 -0800)]
Remove $SIG{__WARN__} from XSLoader.t
Nothing is using the results of this handler any more.
Father Chrysostomos [Wed, 23 Nov 2011 17:48:01 +0000 (09:48 -0800)]
Produce right error msg for $ver < "version"
"version" was being treated as a version object and then failing
the validation check. It should be treated as a string, just like
"versions":
$ perl5.15.4 -Ilib -e '$^V < "version"'
Invalid version object at -e line 1.
$ perl5.15.4 -Ilib -e '$^V < "versions"'
Invalid version format (dotted-decimal versions require at least three parts) at -e line 1.
See also perl #102586.
Father Chrysostomos [Wed, 23 Nov 2011 16:43:19 +0000 (08:43 -0800)]
gv.c: Remove SV_GMAGIC from sv_catpvn_flags call.
This function doesn’t take that flag. It wasn’t doing anything.
Chris 'BinGOs' Williams [Wed, 23 Nov 2011 21:20:51 +0000 (21:20 +0000)]
Update Pod-LaTeX to CPAN version 0.60
[DELTA]
added another LaTeX escape: --- => -{}-{}-
Pod::LaTeX doesn't handle -- in PODs specially, passing it directly to
LaTeX, which then proceeds to replace it with a single -. This patch
replaces ----- with -{}-{}-{}-{}-
Chris 'BinGOs' Williams [Wed, 23 Nov 2011 21:11:52 +0000 (21:11 +0000)]
Update Unicode-Collate to CPAN version 0.86
[DELTA]
0.86 Wed Nov 23 17:16:00 2011
- tailored compatibility ideographs as well as unified ideographs for
the locales: ja, ko, zh__big5han, zh__gb2312han, zh__pinyin, zh__stroke.
- added loc_cjkc.t in t.
Nicholas Clark [Wed, 23 Nov 2011 20:39:06 +0000 (21:39 +0100)]
Move the implementation of --validate from bisect.pl to bisect-runner.pl
--validate sets a default testcase by assigning to @ARGV if its empty. It
makes more sense to do this in bisect-runner.pl, as that processes options
fully, unlike bisect.pl, which passes most through. Hence bisect.pl doesn't
know if some elements of @ARGV are actually options, and hence no testcase
has been supplied, and hence the default is needed.
This change permits the use of --validate with build options such as -D to
work as expected.
Nicholas Clark [Wed, 23 Nov 2011 14:15:15 +0000 (15:15 +0100)]
Add a --make option to bisect.pl, to specify an alternate make command.
For example, one can utilise this to use gmake instead of the system make.
Father Chrysostomos [Wed, 23 Nov 2011 06:34:07 +0000 (22:34 -0800)]
UNIVERSAL::VERSION should treat "version" as a string
It was treating it as a version object and then failing the validation
test, instead of treating it as an invalid version format, as it does
with "versions":
$ ./perl -Ilib -e'$VERSION = "versions"; main->VERSION(1)'
Invalid version format (dotted-decimal versions require at least three parts) at -e line 1.
$ ./perl -Ilib -e'$VERSION = "version"; main->VERSION(1)'
Invalid version object at -e line 1.
See also perl #102586.
Father Chrysostomos [Wed, 23 Nov 2011 06:22:08 +0000 (22:22 -0800)]
printf "%vd", "version" should not SEGV
See perl #102586.
Nicholas Clark [Wed, 23 Nov 2011 09:59:52 +0000 (10:59 +0100)]
On AIX, bisect-runner.pl must patch Makefile.SH for parallel make issues.
It needs to emulate the bug fix of
e6807d8ab22b761c, to ensure lib/Config.pm
is built before makedef.pl is run.
Nicholas Clark [Wed, 23 Nov 2011 09:08:34 +0000 (10:08 +0100)]
makedef.pl uses Config.pm, so needs a Makefile dependency on it.
Commit
9d6c7f2eccef26a6 changed makedef.pl to use Config.pm
Commit
208d7614b345d1fb refactored makedef.pl to read values from
%Config::Config, instead of reading directly from config.sh
Hence we can replace the dependency on config.sh with one on lib/Config.pm
Father Chrysostomos [Wed, 23 Nov 2011 05:28:15 +0000 (21:28 -0800)]
[perl #102586] version->new("version") SEGVs
This adds an ROK check after calling sv_derived_from, as the latter
also works for class names. It is done after sv_derived_from, rather
than before, as sv_derived_from calls get-magic.
Reini Urban [Tue, 22 Nov 2011 19:30:08 +0000 (13:30 -0600)]
arybase.xs be more defensive
There can be no other keys used with ab_ck_base but clang's static
analyzer has a point in complaining about the missing default case.
This is too fragile if any CHECK is added in BOOT.
Father Chrysostomos [Tue, 22 Nov 2011 22:23:04 +0000 (14:23 -0800)]
Correct spelling of double free warning
The perldiag entry said ‘nonexistent’, which is correct. hv.c said
‘non-existent’, which is, well, questionable. They should be the
same, so I corrected hv.c. I also added the %s%s to the end in
perldiag.
Father Chrysostomos [Tue, 22 Nov 2011 22:18:57 +0000 (14:18 -0800)]
Correct perldiag entry for sv_replace panic
This commit changed the warning to an error and reworded it, but never
updated the docs (this commit completes the TODO):
perl-5.8.0-5715-g30e5c35
commit
30e5c352c9c1099120007e8b6e9318a33d99b3bb
Author: Nicholas Clark <nick@ccl4.org>
Date: Thu Aug 25 13:46:31 2005 +0000
Promote the warning about reference miscount in sv_replace to a panic.
TODO - document the panics
p4raw-id: //depot/perl@25330
Father Chrysostomos [Tue, 22 Nov 2011 22:14:02 +0000 (14:14 -0800)]
perldiag: Fix categories of internal severe warnings
Some severe/default warnings in the internal and debugging categories
were listed as errors (P) or regular warnings (W).
Father Chrysostomos [Tue, 22 Nov 2011 21:43:12 +0000 (13:43 -0800)]
sv.c/sv_insert_flags: typo
Father Chrysostomos [Tue, 22 Nov 2011 21:34:37 +0000 (13:34 -0800)]
amagic_deref_call does not necessitate SPAGAIN
As amagic_deref_call pushes a new stack, PL_stack_sp will always have
the same value before and after, so SPAGAIN is unnecessary.
Father Chrysostomos [Wed, 23 Nov 2011 00:27:38 +0000 (16:27 -0800)]
[Merge] [RT #36079] Convert ` to '
jkeenan [Sun, 20 Nov 2011 15:07:02 +0000 (10:07 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Sun, 20 Nov 2011 15:03:16 +0000 (10:03 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Sun, 20 Nov 2011 14:55:28 +0000 (09:55 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Tue, 22 Nov 2011 23:59:53 +0000 (15:59 -0800)]
[RT #36079] Where sensible, replace consecutive single quotation marks with a double quotation mark.
jkeenan [Sun, 20 Nov 2011 03:12:05 +0000 (22:12 -0500)]
[RT #36079] Due to test failures, revert conversion from backtick to single quote.
jkeenan [Sun, 20 Nov 2011 01:21:40 +0000 (20:21 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Sun, 20 Nov 2011 01:19:56 +0000 (20:19 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Sun, 20 Nov 2011 01:16:47 +0000 (20:16 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Sun, 20 Nov 2011 01:15:33 +0000 (20:15 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Sun, 20 Nov 2011 01:09:26 +0000 (20:09 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Sun, 20 Nov 2011 01:02:17 +0000 (20:02 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Sun, 20 Nov 2011 01:01:01 +0000 (20:01 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Sun, 20 Nov 2011 00:56:56 +0000 (19:56 -0500)]
[RT #36079] Convert ` to '.
jkeenan [Sun, 20 Nov 2011 00:51:11 +0000 (19:51 -0500)]
[RT #36079] Convert ` to '.