mtklein [Wed, 27 Jan 2016 21:08:33 +0000 (13:08 -0800)]
kill SkValue
This is clearly not what we're going to do.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1643753002
Review URL: https://codereview.chromium.org/
1643753002
mtklein [Wed, 27 Jan 2016 21:01:41 +0000 (13:01 -0800)]
sketch hooking into PNG_FILTER_OPTIMIZATIONS
Local timing says this 4-byte Paeth function takes about 0.3x the time the serial libpng code does, dropping from ~10 cycles per byte to ~2.9.
bpp=4 is mainly an easy demo. This approach can work for any bpp up to 16, 1 pixel at a time, at roughly the same cost per pixel. Doing more than 1 pixel at a time is a tricky math problem I have yet to attempt to solve.
Everything here can be trivially downgraded to MMX, supporting bpp up to 8. It seems to be a little slower (~3.5 cycles per byte), but it would make the code compatible with every x86 that can still power on.
I've tried four approaches:
- this way;
- doing things naively in 16-bit;
- a 16-bit version that requires division by 3 (i.e. mulhi_epu16(..., 0x5580) );
- a mostly 8-bit version of the same.
They're all fine, but this one is consistently the fastest I've measured.
I'd be happy to settle on the naive 16-bit version too, which would have a very clear implementation that's only minorly slower than this version. The other two are way more complicated, and would require us to draw some serious ASCII diagrams to explain.
I have learned that the .skp serialization tests (serialize-8888) have a nice side effect of testing the correctness of these filters!
(Since writing the description above, I've bumped things up to {Paeth,Sub,Avg} x { 3 bpp, 4 bpp }.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1573943002
Review URL: https://codereview.chromium.org/
1573943002
jcgregorio [Wed, 27 Jan 2016 20:15:38 +0000 (12:15 -0800)]
skiaserve: Enable /cmd endpoint.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1639403002
Review URL: https://codereview.chromium.org/
1639403002
msarett [Wed, 27 Jan 2016 20:06:22 +0000 (12:06 -0800)]
Revert of Consolidate SkStream copying methods (patchset #1 id:1 of https://codereview.chromium.org/
1640793002/ )
Reason for revert:
Test to see if this fixes the bots.
Original issue's description:
> Consolidate SkStream copying methods
>
> Make SkCopyStreamToData call SkStreamCopy, removing duplicate code.
>
> The former still has its own method of copying with a length, since
> it saves one copy.
>
> BUG=skia:4788
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1640793002
>
> Committed: https://skia.googlesource.com/skia/+/
440c5a98dee428c661b77d149e30c794d264b8cd
TBR=halcanary@google.com,scroggo@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4788
Review URL: https://codereview.chromium.org/
1641853002
msarett [Wed, 27 Jan 2016 20:05:27 +0000 (12:05 -0800)]
Suppress jpeg valgrind errors
Do a better job suppressing these errors until I can prioritize fixing
them.
BUG=skia:4550
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1641763002
Review URL: https://codereview.chromium.org/
1641763002
jcgregorio [Wed, 27 Jan 2016 19:44:38 +0000 (11:44 -0800)]
skiaserve: Set 303 status code on redirect.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1641823002
Review URL: https://codereview.chromium.org/
1641823002
kjlubick [Wed, 27 Jan 2016 19:34:36 +0000 (11:34 -0800)]
Make fuzz output the words success for a 'clean exit'
The analysis looks for "Success" to determine if the fuzz should be considered
a clean exit or not. It classifies clean exists as "grey" fuzzes, i.e. fixed.
TBR=mtklein@google.com
BUG=skia:4438
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1646603002
Review URL: https://codereview.chromium.org/
1646603002
joshualitt [Wed, 27 Jan 2016 19:07:23 +0000 (11:07 -0800)]
Wire up JsonCanvas in skiaserve
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1640333002
Review URL: https://codereview.chromium.org/
1640333002
scroggo [Wed, 27 Jan 2016 18:51:56 +0000 (10:51 -0800)]
Consolidate SkStream copying methods
Make SkCopyStreamToData call SkStreamCopy, removing duplicate code.
The former still has its own method of copying with a length, since
it saves one copy.
BUG=skia:4788
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1640793002
Review URL: https://codereview.chromium.org/
1640793002
ethannicholas [Wed, 27 Jan 2016 17:06:35 +0000 (09:06 -0800)]
switched to SkJSONCPP for JSON output
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1639333002
Review URL: https://codereview.chromium.org/
1639333002
yujieqin [Wed, 27 Jan 2016 17:03:20 +0000 (09:03 -0800)]
Fix Windows build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1633413003
Review URL: https://codereview.chromium.org/
1633413003
scroggo [Wed, 27 Jan 2016 16:26:44 +0000 (08:26 -0800)]
Stop testing SkImageDecoder in DM/nanobench
We have already used it for comparison, and are switching forward
to using SkCodec. This also allows us to simplify the code for checking
the extensions we support for images.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1641663002
Review URL: https://codereview.chromium.org/
1641663002
yujieqin [Wed, 27 Jan 2016 16:25:53 +0000 (08:25 -0800)]
Enable RAW codec for Windows
* Use new DNG SDK version from ASOP, which fixed some build issues.
* Fix SkRawCodec.
* Fix gyp files.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1641533004
Review URL: https://codereview.chromium.org/
1641533004
ebrauer [Wed, 27 Jan 2016 16:21:03 +0000 (08:21 -0800)]
It derives the dng_host and overrides PerformAreaTask() to split the task into several sub-tasks which get added to SkTaskGroup.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1634763002
Review URL: https://codereview.chromium.org/
1634763002
yujieqin [Wed, 27 Jan 2016 15:59:00 +0000 (07:59 -0800)]
Fix complier issue [-Werror, -Wvla]
BUG=skia:4861
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1638323002
Review URL: https://codereview.chromium.org/
1638323002
joshualitt [Wed, 27 Jan 2016 15:40:29 +0000 (07:40 -0800)]
Add primitive url handling system to skiaserve
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1644633002
Review URL: https://codereview.chromium.org/
1644633002
yujieqin [Wed, 27 Jan 2016 15:32:43 +0000 (07:32 -0800)]
Update DEPS to use new PIEX version from AOSP.
Highlight:
* Better support for reading GPS tags
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1646433003
Review URL: https://codereview.chromium.org/
1646433003
joshualitt [Wed, 27 Jan 2016 15:03:29 +0000 (07:03 -0800)]
Allow clients to upload skps to skiaserve
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1638883002
Review URL: https://codereview.chromium.org/
1638883002
robertphillips [Wed, 27 Jan 2016 13:00:04 +0000 (05:00 -0800)]
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1607253002
Committed: https://skia.googlesource.com/skia/+/
8bc3cf88bbf5e5d5724356f076931bb70a6117ba
Review URL: https://codereview.chromium.org/
1607253002
caryclark [Wed, 27 Jan 2016 01:02:30 +0000 (17:02 -0800)]
move more geometry to simd
Remove duplicate quad and cubic code around
computing the polynomial coefficients, and
use common SIMD-based code instead.
R=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1633143002
Review URL: https://codereview.chromium.org/
1633143002
robertphillips [Tue, 26 Jan 2016 20:07:13 +0000 (12:07 -0800)]
Add gpu backend for SkPixelXorXfermode
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1631873002
Review URL: https://codereview.chromium.org/
1631873002
reed [Tue, 26 Jan 2016 18:37:21 +0000 (10:37 -0800)]
remove unused sample
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1634683006
TBR=
Review URL: https://codereview.chromium.org/
1634683006
cblume [Tue, 26 Jan 2016 17:10:48 +0000 (09:10 -0800)]
Cleaning up trailing spaces and typos.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1631993002
Review URL: https://codereview.chromium.org/
1631993002
senorblanco [Tue, 26 Jan 2016 16:41:02 +0000 (08:41 -0800)]
Image filters: fix srcOffset handling in asFragmentProcessor() path.
Filters such as SkMatrixConvolutionImageFilter which use the
asFragmentProcessor() path were not correctly handling srcOffset.
It is correctly applied to the bounds, but the srcRect and dstRect
were computed from the pre-offset bounds.
The fix is to move them to just above where they're used in drawing.
Note: this change adds a new test case to the imagefiltersgraph GM,
so it will have to be rebaselined post-landing.
BUG=skia:4855
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1637443003
Review URL: https://codereview.chromium.org/
1637443003
ethannicholas [Tue, 26 Jan 2016 15:47:57 +0000 (07:47 -0800)]
Initial support for turning Skia draws into a JSON document and vice versa.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1636563002
Committed: https://skia.googlesource.com/skia/+/
3cb582f688822461efa5a034e18008bf2f11e4f8
Review URL: https://codereview.chromium.org/
1636563002
mtklein [Tue, 26 Jan 2016 15:40:30 +0000 (07:40 -0800)]
de-proc sk_float_rsqrt
This is the first of many little baby steps to have us stop runtime-detecting NEON.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1616013003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Committed: https://skia.googlesource.com/skia/+/
efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d
Review URL: https://codereview.chromium.org/
1616013003
lsalzman [Tue, 26 Jan 2016 15:34:51 +0000 (07:34 -0800)]
check for both __ARM_NEON__ and __ARM_NEON
No public API changes.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1630903004
Review URL: https://codereview.chromium.org/
1630903004
bsalomon [Mon, 25 Jan 2016 22:33:25 +0000 (14:33 -0800)]
Make A8 readbacks work from non-A8 surfaces
Expand testing of A8 readbacks.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1613903005
Review URL: https://codereview.chromium.org/
1613903005
robertphillips [Mon, 25 Jan 2016 22:19:56 +0000 (14:19 -0800)]
Remove SkLerpXfermode
This relies on the Chromium CL https://codereview.chromium.org/
1610573004/ (Replace use of SkLerpXfermode with SkArithmeticMode)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1611633002
Review URL: https://codereview.chromium.org/
1611633002
msarett [Mon, 25 Jan 2016 21:57:25 +0000 (13:57 -0800)]
Revert of Initial support for turning Skia draws into a JSON document and vice versa. (patchset #3 id:80001 of https://codereview.chromium.org/
1636563002/ )
Reason for revert:
Breaking the CMake build.
Original issue's description:
> Initial support for turning Skia draws into a JSON document and vice versa.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1636563002
>
> Committed: https://skia.googlesource.com/skia/+/
3cb582f688822461efa5a034e18008bf2f11e4f8
TBR=jcgregorio@google.com,joshualitt@google.com,mtklein@google.com,ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1637643002
ethannicholas [Mon, 25 Jan 2016 21:28:28 +0000 (13:28 -0800)]
Initial support for turning Skia draws into a JSON document and vice versa.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1636563002
Review URL: https://codereview.chromium.org/
1636563002
msarett [Mon, 25 Jan 2016 21:10:58 +0000 (13:10 -0800)]
Disable RAW test when SkRawCodec is not compiled
TBR=scroggo@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1639533002
Review URL: https://codereview.chromium.org/
1639533002
benjaminwagner [Mon, 25 Jan 2016 21:02:40 +0000 (13:02 -0800)]
Add pre_log option to nanobench; make this option default true in nanobench_flags.py and dm_flags.py.
BUG=skia:4826
BUG=skia:4827
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1612483002
Review URL: https://codereview.chromium.org/
1612483002
bungeman [Mon, 25 Jan 2016 21:00:33 +0000 (13:00 -0800)]
Work around vs2013sp2-3 bug in skstd::unique_ptr.
When compiling skstd::unique_ptr::compressed_base with the vc++ in
some intermediate service pack versions of Visual Studio 2013 the
compiler will crash with an internal compiler error. In the interest of
reducing headaches, work around this issue in skstd::unique_ptr until
std::unique_ptr can be used.
BUG=skia:4564
Review URL: https://codereview.chromium.org/
1636503002
msarett [Mon, 25 Jan 2016 19:40:02 +0000 (11:40 -0800)]
Fix gyp files so that gyp_to_Android.mk succeeds
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1630723003
Review URL: https://codereview.chromium.org/
1630723003
robertphillips [Mon, 25 Jan 2016 19:34:16 +0000 (11:34 -0800)]
Fix memory leak in pixelxorxfermode GM
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1633773002
TBR=jvanverth@google.com
Review URL: https://codereview.chromium.org/
1633773002
iroth [Mon, 25 Jan 2016 19:24:57 +0000 (11:24 -0800)]
Changes to public.bzl to support building on iOS with objc_library bazel target.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1639443002
Review URL: https://codereview.chromium.org/
1639443002
msarett [Mon, 25 Jan 2016 19:01:34 +0000 (11:01 -0800)]
Disable RAW test on Chrome OS, Windows
TBR=scroggo@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1633763002
Review URL: https://codereview.chromium.org/
1633763002
msarett [Mon, 25 Jan 2016 18:51:29 +0000 (10:51 -0800)]
Fix leak of SkImageGenerator
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1638463002
Review URL: https://codereview.chromium.org/
1638463002
joshualitt [Mon, 25 Jan 2016 18:50:04 +0000 (10:50 -0800)]
Build and link microhttpd from gyp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1628363002
Review URL: https://codereview.chromium.org/
1628363002
benjaminwagner [Mon, 25 Jan 2016 17:29:08 +0000 (09:29 -0800)]
Remove RAW Codec from Google3 build.
This should fix the build after https://codereview.chromium.org/
1520403003 and allow the autoroller to complete. I will follow up to see if it will be simple to re-enable this codec.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1628393002
Review URL: https://codereview.chromium.org/
1628393002
mtklein [Mon, 25 Jan 2016 17:26:54 +0000 (09:26 -0800)]
spin off some safe parts from AVX2 CL
(reviewed here https://codereview.chromium.org/
1532613002/)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1628333003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1628333003
msarett [Mon, 25 Jan 2016 16:54:50 +0000 (08:54 -0800)]
Revert of AVX 2 SrcOver blits: color32, blitmask. (patchset #24 id:450001 of https://codereview.chromium.org/
1532613002/ )
Reason for revert:
Bot failures
Original issue's description:
> AVX 2 SrcOver blits: color32, blitmask.
>
> As a follow up to the SSE 4.1 CL, this should look pretty familiar.
>
> I've made some organizational changes around how we load, store, pack, and unpack data that I think makes things clearer and more orthogonal, and it'll make it easier to try out a pmaddubsw lerp. I have backported these changes to the SSE 4.1 code, and I hope that I can actually get a lot of this code templated for sharing between the two later.
>
> Perf changes (relative to SSE 4.1):
> Xfermode_SrcOver: 1650 -> 1180 (0.71x) // large opaque blit
> Xfermode_SrcOver_aa: 1794 -> 1653 (0.92x) // large opaque + small transparent
> text_16_AA_{FF,BK,WT}: 1.72 -> 1.59 (0.92x) // small opaque blit
> text_16_AA_88: 1.83 -> 1.77 (0.97x) // small transparent blit
>
> This should be a big throughout win, and a small latency win.
> This should all be pixel-exact to the previous SSE 4.1 code.
>
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1532613002
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
5d2117015eb271e09faf4a7ddd89093c9d618a36
TBR=herb@google.com,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1632713002
robertphillips [Mon, 25 Jan 2016 16:39:08 +0000 (08:39 -0800)]
Add GM for SkPixelXorXfermode
This is in preparation for adding a gpu implementation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1601743009
Review URL: https://codereview.chromium.org/
1601743009
mtklein [Mon, 25 Jan 2016 16:37:30 +0000 (08:37 -0800)]
AVX 2 SrcOver blits: color32, blitmask.
As a follow up to the SSE 4.1 CL, this should look pretty familiar.
I've made some organizational changes around how we load, store, pack, and unpack data that I think makes things clearer and more orthogonal, and it'll make it easier to try out a pmaddubsw lerp. I have backported these changes to the SSE 4.1 code, and I hope that I can actually get a lot of this code templated for sharing between the two later.
Perf changes (relative to SSE 4.1):
Xfermode_SrcOver: 1650 -> 1180 (0.71x) // large opaque blit
Xfermode_SrcOver_aa: 1794 -> 1653 (0.92x) // large opaque + small transparent
text_16_AA_{FF,BK,WT}: 1.72 -> 1.59 (0.92x) // small opaque blit
text_16_AA_88: 1.83 -> 1.77 (0.97x) // small transparent blit
This should be a big throughout win, and a small latency win.
This should all be pixel-exact to the previous SSE 4.1 code.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1532613002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1532613002
yujieqin [Mon, 25 Jan 2016 16:26:16 +0000 (08:26 -0800)]
Add RAW decoding into Skia.
TBR=reed@google.com
BUG=skia:
(Based on the work from ebrauer in https://codereview.chromium.org/
1459473007)
(Based on the work from adaubert in https://codereview.chromium.org/
1494003003)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1520403003
Committed: https://skia.googlesource.com/skia/+/
6bd8639f8c142eedf543f4e5f3b02d2bf11df308
Review URL: https://codereview.chromium.org/
1520403003
msarett [Mon, 25 Jan 2016 16:20:55 +0000 (08:20 -0800)]
Do not test images with alpha to 565
This should handle the untriaged images in Gold.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1635453002
Review URL: https://codereview.chromium.org/
1635453002
cjacek [Mon, 25 Jan 2016 15:27:36 +0000 (07:27 -0800)]
Fixed compilation on mingw.
Found and tested in mingw Firefox build. There are two problems:
- GCC doesn't support __vectorcall calling convention, so its usage needs to be #ifdefed
- GetProcAddress returns FARPROC type (a function pointer) and GCC requires an explicit cast to void*
Review URL: https://codereview.chromium.org/
1589933002
caryclark [Mon, 25 Jan 2016 14:33:01 +0000 (06:33 -0800)]
remove legacy defines
The defines
SK_SUPPORT_LEGACY_ARCTO
SK_SUPPORT_LEGACY_CONIC_MEASURE
SK_SUPPORT_LEGACY_DASH_MEASURE
SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS
SK_SUPPORT_LEGACY_PATH_MEASURE_TVALUE
have been removed from Chrome. This removes the obsolete code
from Skia as well.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1627703002
Review URL: https://codereview.chromium.org/
1627703002
fmalita [Mon, 25 Jan 2016 14:29:44 +0000 (06:29 -0800)]
Delete 2 legacy flags
No longer used in Chrome/Android:
SK_SUPPORT_LEGACY_ANISOTROPIC_MIPMAPS
SK_SUPPORT_LEGACY_PRESCALE_SEMANTICS
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1632633002
Review URL: https://codereview.chromium.org/
1632633002
fmalita [Mon, 25 Jan 2016 14:23:54 +0000 (06:23 -0800)]
SK_SUPPORT_LEGACY_DRAWFLTER typo
s/FLTER/FILTER/
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1634573002
Review URL: https://codereview.chromium.org/
1634573002
kkinnunen [Mon, 25 Jan 2016 14:07:26 +0000 (06:07 -0800)]
Avoid updating glPathStencilFunc unless it changes
Avoid updating glPathStencilFunc unless it changes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1619623005
Review URL: https://codereview.chromium.org/
1619623005
msarett [Mon, 25 Jan 2016 14:05:19 +0000 (06:05 -0800)]
Revert of Prototype of RAW decoding in Skia. (patchset #32 id:610001 of https://codereview.chromium.org/
1520403003/ )
Reason for revert:
A few build failures on Chrome OS/Android.
Original issue's description:
> Add RAW decoding into Skia.
>
> TBR=reed@google.com
>
> BUG=skia:
>
> (Based on the work from ebrauer in https://codereview.chromium.org/
1459473007)
> (Based on the work from adaubert in https://codereview.chromium.org/
1494003003)
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1520403003
>
> Committed: https://skia.googlesource.com/skia/+/
6bd8639f8c142eedf543f4e5f3b02d2bf11df308
TBR=scroggo@google.com,adaubert@google.com,yujieqin@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1635443002
caryclark [Mon, 25 Jan 2016 13:39:04 +0000 (05:39 -0800)]
fix arcto exception handling
To match SVG behavior,
draw a line when either radius is zero,
or when the end point equals the start point.
Update the GM to include these tests, and
take the scale used to test it on a highres display.
R=fmalita@chromium.org
BUG=skia:4849
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1627423002
Review URL: https://codereview.chromium.org/
1627423002
yujieqin [Mon, 25 Jan 2016 13:29:03 +0000 (05:29 -0800)]
Add RAW decoding into Skia.
TBR=reed@google.com
BUG=skia:
(Based on the work from ebrauer in https://codereview.chromium.org/
1459473007)
(Based on the work from adaubert in https://codereview.chromium.org/
1494003003)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1520403003
Review URL: https://codereview.chromium.org/
1520403003
borenet [Mon, 25 Jan 2016 13:00:13 +0000 (05:00 -0800)]
Whitespace change to test SK_IMAGE_VERSION download
TBR=scroggo
BUG=skia:4558
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1633453003
Review URL: https://codereview.chromium.org/
1633453003
kkinnunen [Mon, 25 Jan 2016 09:44:03 +0000 (01:44 -0800)]
Enable GL_CHROMIUM_bind_uniform_location, command buffer is fixed
Enable GL_CHROMIUM_bind_uniform_location, command buffer implementation
is fixed now.
BUG=skia:4454
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1613763003
Review URL: https://codereview.chromium.org/
1613763003
kkinnunen [Mon, 25 Jan 2016 08:47:23 +0000 (00:47 -0800)]
Do not try to get fragment input locations with CHROMIUM_path_rendering
Do not try to get fragment input locations with CHROMIUM_path_rendering,
it uses the binding mechanism in CHROMIUM_path_rendering
BUG=skia:2992
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618773002
Review URL: https://codereview.chromium.org/
1618773002
kkinnunen [Mon, 25 Jan 2016 08:31:49 +0000 (00:31 -0800)]
Make BGRA8888 renderable on CHROMIUM_framebuffer_mixed_samples
Make BGRA8888 renderable on CHROMIUM_framebuffer_mixed_samples.
BUG=skia:2992
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1615833002
Review URL: https://codereview.chromium.org/
1615833002
mtklein [Mon, 25 Jan 2016 03:49:24 +0000 (19:49 -0800)]
Revert of skstd -> std for unique_ptr (patchset #24 id:460001 of https://codereview.chromium.org/
1436033003/ )
Reason for revert:
Still need an answer for SkAdvancedTypefaceMetrics (at least for Google3 iOS build).
Original issue's description:
> skstd -> std for unique_ptr
>
> TBR=reed@google.com
> No public API changes.
>
> BUG=skia:4564
>
> Committed: https://skia.googlesource.com/skia/+/
755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50
>
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
06189155d987db5c7e69015f6ea87c2168d6a065
>
> Committed: https://skia.googlesource.com/skia/+/
70e8dfca4a7f5bce97b8021a6e378c4828b09c8c
>
> Committed: https://skia.googlesource.com/skia/+/
dadfc245cc9a0279ff7b73da3344f2ca5d139907
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1436033003
>
> Committed: https://skia.googlesource.com/skia/+/
ccf1de0d9aa75f29829f1c4c462214b991fd8c9e
TBR=bungeman@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4564
Review URL: https://codereview.chromium.org/
1626873004
mtklein [Mon, 25 Jan 2016 03:18:54 +0000 (19:18 -0800)]
skstd -> std for unique_ptr
TBR=reed@google.com
No public API changes.
BUG=skia:4564
Committed: https://skia.googlesource.com/skia/+/
755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
Committed: https://skia.googlesource.com/skia/+/
06189155d987db5c7e69015f6ea87c2168d6a065
Committed: https://skia.googlesource.com/skia/+/
70e8dfca4a7f5bce97b8021a6e378c4828b09c8c
Committed: https://skia.googlesource.com/skia/+/
dadfc245cc9a0279ff7b73da3344f2ca5d139907
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1436033003
Review URL: https://codereview.chromium.org/
1436033003
reed [Sun, 24 Jan 2016 19:15:14 +0000 (11:15 -0800)]
add 4f support to colorfiltershader
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1625263002
TBR=
Review URL: https://codereview.chromium.org/
1625263002
reed [Sun, 24 Jan 2016 03:37:56 +0000 (19:37 -0800)]
Revert[2] of expand unitests for color4f
This reverts commit
5f34e8ed82e6cbf29401bda5d423a50a2ab6db74.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1622983002
TBR=
Review URL: https://codereview.chromium.org/
1622983002
reed [Sat, 23 Jan 2016 22:19:06 +0000 (14:19 -0800)]
Revert of expand unitests for color4f (patchset #1 id:1 of https://codereview.chromium.org/
1622893002/ )
Reason for revert:
leaking shadercontext in test
Original issue's description:
> expand unitests for color4f
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1622893002
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
fac684502b6047ffc7dc2e59bd7e5a7cbfa5bf78
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1622923002
bsalomon [Sat, 23 Jan 2016 18:41:40 +0000 (10:41 -0800)]
Don't dirty MIP chain when damage bounds is empty
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618383002
Review URL: https://codereview.chromium.org/
1618383002
reed [Sat, 23 Jan 2016 18:15:39 +0000 (10:15 -0800)]
expand unitests for color4f
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1622893002
TBR=
Review URL: https://codereview.chromium.org/
1622893002
caryclark [Sat, 23 Jan 2016 13:07:04 +0000 (05:07 -0800)]
Add svg path arcto
The arcto() used by SVG in Chrome and Android is ported here, using conics
instead of cubics. The logic is a direct transposition of the WebKit code.
The attached GM includes SVG that draws the same as Skia.
R=reed@google.com
BUG=skia:3959
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1613303002
Review URL: https://codereview.chromium.org/
1613303002
msarett [Fri, 22 Jan 2016 22:46:42 +0000 (14:46 -0800)]
Add getYUV8Planes() API to SkCodec
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1549473003
Review URL: https://codereview.chromium.org/
1549473003
msarett [Fri, 22 Jan 2016 22:12:38 +0000 (14:12 -0800)]
SSSE3 opts for RGB -> RGB(FF) or BGR(FF)
Swizzle Bench Runtime
z620 0.21x
Dell Venue 8 0.26x
RGB PNGs Decode Runtime
z620 0.91x
Dell Venus 8 0.96x
BUG=skia:4767
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618603003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1618603003
lsalzman [Fri, 22 Jan 2016 22:03:02 +0000 (14:03 -0800)]
skip zero-length linear gradient intervals to make new code more consistent with older table-based implementation
BUG=skia:4841
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1619413002
Review URL: https://codereview.chromium.org/
1619413002
bsalomon [Fri, 22 Jan 2016 20:54:57 +0000 (12:54 -0800)]
Factor out xcode c/cpp settings into variables to apply to cmake builds.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1619243003
Review URL: https://codereview.chromium.org/
1619243003
herb [Fri, 22 Jan 2016 19:58:55 +0000 (11:58 -0800)]
Change name from ScaleToSides to SkScaleToSides.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618283004
Review URL: https://codereview.chromium.org/
1618283004
mtklein [Fri, 22 Jan 2016 19:51:40 +0000 (11:51 -0800)]
Revert of de-proc sk_float_rsqrt (patchset #3 id:40001 of https://codereview.chromium.org/
1616013003/ )
Reason for revert:
This is somehow blocking the Google3 roll in ways neither Ben nor I understand. Precautionary revert... will try again Monday.
Original issue's description:
> de-proc sk_float_rsqrt
>
> This is the first of many little baby steps to have us stop runtime-detecting NEON.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1616013003
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d
TBR=reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1629503002
fmalita [Fri, 22 Jan 2016 19:45:39 +0000 (11:45 -0800)]
Anisotropic mipmap fixes
1) when selecting a level scale, use max(scaleX, scaleY) instead of
current sqrt(scaleX * scaleY)
2) track and apply non-uniform fixup scales
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617183004
Review URL: https://codereview.chromium.org/
1617183004
joshualitt [Fri, 22 Jan 2016 19:21:43 +0000 (11:21 -0800)]
First rough draft of skiaserve
Please excuse the mess while we iterate
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1621753002
Review URL: https://codereview.chromium.org/
1621753002
joshualitt [Fri, 22 Jan 2016 19:17:46 +0000 (11:17 -0800)]
Update deps to pull microhttpd
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1620813004
Review URL: https://codereview.chromium.org/
1620813004
reed [Fri, 22 Jan 2016 18:35:26 +0000 (10:35 -0800)]
add GM to exercise duplicate color-stops
BUG=skia:4841
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1620423002
TBR=
Review URL: https://codereview.chromium.org/
1620423002
herb [Fri, 22 Jan 2016 18:11:03 +0000 (10:11 -0800)]
Use nextafter instead of nexttoward to avoid using long double calculation.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1621453004
Review URL: https://codereview.chromium.org/
1621453004
msarett [Fri, 22 Jan 2016 17:54:21 +0000 (09:54 -0800)]
Use NEON optimizations for RGB -> RGB(FF) or BGR(FF) in SkSwizzler
Swizzle Bench Runtime Nexus 6P
xxx_xxxa 0.32x
xxx_swaprb_xxxa 0.31x
Swizzle Bench Runtime Nexus 9
xxx_xxxa 1.11x
xxx_swaprb_xxxa 1.14x
(This is a slow down.)
Swizzle Bench Runtime Nexus 5
xxx_xxxa 0.12x
xxx_swaprb 0.12x
RGB PNG Decode Runtime
Nexus 6P 0.94x
Nexus 9 0.98x
I don't know how to explain the fact that the Swizzle Bench was
slower on Nexus 9, but the decode times got faster.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618003002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1618003002
mtklein [Fri, 22 Jan 2016 17:50:20 +0000 (09:50 -0800)]
try removing attribute((aligned(16))
CQ_EXTRA_TRYBOTS=client.skia:Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618873005
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1618873005
ethannicholas [Fri, 22 Jan 2016 17:45:47 +0000 (09:45 -0800)]
Revert of added support for PLS path rendering (patchset #16 id:360001 of https://codereview.chromium.org/
1541903002/ )
Reason for revert:
ASAN failure at src/gpu/GrXferProcessor.cpp:224
Original issue's description:
> added support for PLS path rendering
>
> BUG=skia:3555
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1541903002
>
> Committed: https://skia.googlesource.com/skia/+/
7df3f5e127f8016d17b637cc48a6a4718f1a6822
TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3555
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1626553002
Review URL: https://codereview.chromium.org/
1626553002
benjaminwagner [Fri, 22 Jan 2016 17:45:14 +0000 (09:45 -0800)]
Add SK_SUPPORT_LEGACY_DRAWFILTER guard around calls to SkCanvas::(get|set)DrawFilter.
Fixes Google3 dm build. (Can't enable SK_INTERNAL for Google3 dm without enabling it for all dependents.)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1626543002
Review URL: https://codereview.chromium.org/
1626543002
rmistry [Fri, 22 Jan 2016 16:57:41 +0000 (08:57 -0800)]
Revert of whitespace change to test bugdroid (patchset #1 id:1 of https://codereview.chromium.org/
1625503002/ )
Reason for revert:
one more test
Original issue's description:
> whitespace change to test bugdroid
>
> NOTRY=true
> TBR=
> BUG=skia:4814
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1625503002
>
> Committed: https://skia.googlesource.com/skia/+/
aed5717afddce200b3de88d8dde5252068b131c8
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4814
Review URL: https://codereview.chromium.org/
1626533002
mtklein [Fri, 22 Jan 2016 16:49:26 +0000 (08:49 -0800)]
de-proc sk_float_rsqrt
This is the first of many little baby steps to have us stop runtime-detecting NEON.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1616013003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1616013003
rmistry [Fri, 22 Jan 2016 16:49:20 +0000 (08:49 -0800)]
whitespace change to test bugdroid
NOTRY=true
TBR=
BUG=skia:4814
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1625503002
Review URL: https://codereview.chromium.org/
1625503002
herb [Fri, 22 Jan 2016 16:34:35 +0000 (08:34 -0800)]
Fix bounds of checking if a radii are too long for a side.
BUG=skia:4692,skia:4413
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617763003
Review URL: https://codereview.chromium.org/
1617763003
mtklein [Fri, 22 Jan 2016 16:18:14 +0000 (08:18 -0800)]
DM: dump a zero-results .json file right at startup.
This way, if DM runs, the file will be there, even if it crashes before the
first time we'd ordinarily write out the file (currently, any time
the number of tasks remaining to do becomes evenly divisible by 500).
BUG=skia:4839
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1626493002
Review URL: https://codereview.chromium.org/
1626493002
bsalomon [Fri, 22 Jan 2016 16:16:09 +0000 (08:16 -0800)]
Add ability to query read pixels support without a render target.
Add more checks to onGetReadPixelsInfo.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1615023003
Review URL: https://codereview.chromium.org/
1615023003
mtklein [Fri, 22 Jan 2016 15:54:08 +0000 (07:54 -0800)]
SkBSwap32
Seems handy.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1619923002
Review URL: https://codereview.chromium.org/
1619923002
mtklein [Fri, 22 Jan 2016 15:42:53 +0000 (07:42 -0800)]
Refactor swizzle names and types.
- Plant a flag to say "pretend all the inputs are RGBA".
This is how libpng thinks.
This is the opposite of what the implementation had been doing,
so I've rearranged everything to reflect the new orientation.
- Rewrite the names to be less mysterious looking. No more Xs.
- Make the src type uniformly const void*, to allow for 888 (RGB) srcs.
This should be performance and pixel neutral. (Please revert if it's not.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1626463002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1626463002
bsalomon [Fri, 22 Jan 2016 15:17:34 +0000 (07:17 -0800)]
Make swizzling in read/write pixel copy code more generic
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617433002
Review URL: https://codereview.chromium.org/
1617433002
scroggo [Fri, 22 Jan 2016 14:58:27 +0000 (06:58 -0800)]
Update libwebp to version 0.5.0
This is the version used by Android.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1601253003
Review URL: https://codereview.chromium.org/
1601253003
robertphillips [Fri, 22 Jan 2016 14:53:57 +0000 (06:53 -0800)]
Revert of Add gpu implementation of OverdrawXfermode (patchset #6 id:100001 of https://codereview.chromium.org/
1607253002/ )
Reason for revert:
Overdraw Xfer mode using new fangled glsl features
Original issue's description:
> Add gpu implementation of OverdrawXfermode
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1607253002
>
> Committed: https://skia.googlesource.com/skia/+/
8bc3cf88bbf5e5d5724356f076931bb70a6117ba
TBR=egdaniel@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/
1626443002
djsollen [Fri, 22 Jan 2016 14:50:25 +0000 (06:50 -0800)]
Revert of Consolidate SK_CRASH and sk_throw into SK_ABORT (patchset #5 id:80001 of https://codereview.chromium.org/
1610823002/ )
Reason for revert:
Chrome is calling SK_CRASH
Original issue's description:
> Consolidate SK_CRASH and sk_throw into SK_ABORT
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1610823002
>
> Committed: https://skia.googlesource.com/skia/+/
4c5cd7d527ed29aabfa72aa47b23a4496eeda357
TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1620333002
ethannicholas [Fri, 22 Jan 2016 14:48:46 +0000 (06:48 -0800)]
added support for PLS path rendering
BUG=skia:3555
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1541903002
Review URL: https://codereview.chromium.org/
1541903002
joshualitt [Fri, 22 Jan 2016 14:08:48 +0000 (06:08 -0800)]
Fix GrAtlasTextBlob bounds management
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1605013002
Committed: https://skia.googlesource.com/skia/+/
ae473fdfc3db2d9dd82b05b2568767d6d4038fcd
Review URL: https://codereview.chromium.org/
1605013002
djsollen [Fri, 22 Jan 2016 14:04:55 +0000 (06:04 -0800)]
Consolidate SK_CRASH and sk_throw into SK_ABORT
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1610823002
Review URL: https://codereview.chromium.org/
1610823002
reed [Fri, 22 Jan 2016 09:04:29 +0000 (01:04 -0800)]
Revert[2] of float color components
This reverts commit
2a2bdc698460c38ac9e24ba4abdeefec67bcba37.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1622483002
TBR=
NOTRY=True
Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot seems wicked slow
Review URL: https://codereview.chromium.org/
1622483002
reed [Fri, 22 Jan 2016 08:04:30 +0000 (00:04 -0800)]
Revert of experiment: float color components (patchset #6 id:100001 of https://codereview.chromium.org/
1617813002/ )
Reason for revert:
broke some colormatrix tests
Original issue's description:
> experiment: float color components
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617813002
>
> Committed: https://skia.googlesource.com/skia/+/
353c148d8e8c9031daca34c6f9d6bcc6f08706c7
TBR=fmalita@chromium.org,mtklein@google.com,herb@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1623453002
fmalita [Fri, 22 Jan 2016 02:47:11 +0000 (18:47 -0800)]
Hide SkCanvas::{set,get}DrawFilter
Except for Android, which still makes use of it.
BUG=skia:3587
R=reed@google.com,djsollen@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618843002
Review URL: https://codereview.chromium.org/
1618843002