Michal Michalski [Tue, 7 May 2019 08:59:32 +0000 (10:59 +0200)]
[mediacontroller][common] Use PlatformEnum in MediaController.
Refactor enums in MediaController module using PlatformEnum
template class.
[Verification] Code compiles + MC TCT passed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ie861d1c0aca7651a2f9ce45b966773082abf6045
Michal Michalski [Tue, 7 May 2019 08:36:56 +0000 (10:36 +0200)]
[common] Define PlatformEnum class template.
Will replace current way enums are defined in webapi-plugins.
[Verification] Code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Id8c53df46ae9039e81d699884494b72c20d5cba8
Michal Michalski [Tue, 16 Apr 2019 10:26:16 +0000 (12:26 +0200)]
[mediacontroller] Fix error handling in ReplyCommand.
MediaControllerServerReplyCommand function did not
handle errors returned by MediaControllerServer::CommandReply()
call. This commit handles those errors.
[Verification]
Code compiles.
Change-Id: Ibc5acacc32ff23a6d8fa7cac096ade0e40e2b697
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Wed, 20 Mar 2019 17:19:15 +0000 (18:19 +0100)]
[mediacontroller] Use request_id for listener matching in SendCommand.
SendCommand method was using watchId to identify CommandReply callback which
should be called. It was passed in bundle object to mc_client_send_custom_cmd
function. Now instead of passing watchId we use already available request_id
to perform the same matching for command reply listeners.
[Verification]
Manual test.
tct-mediacontroller-tizen-tests - pass 100%
Change-Id: I57e90dbe36d7726f2e2f66866b11910d5d1d5d0d
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Lukasz Bardeli [Tue, 12 Mar 2019 12:43:18 +0000 (13:43 +0100)]
[MediaController] Change InvalidState to UnknownError.
[Verification] Code compiles without error.
Change-Id: Ibda8a419257caf071c7ed8e08e5b496b5c0efe2e
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
Pawel Wasowski [Thu, 9 May 2019 11:31:49 +0000 (13:31 +0200)]
[messaging] Fix synchronization issues
Due to the delay between updating email with native C API functions and
updates of the corresponding message/thread records in the mail
database, race conditions occured in the previous implementation,
resulting in inconsitencies between thread_ids in the DB and those of
messages in JS layer. Active waits have been added to mitigate this
problems.
[Verification] tct-tizen-messaging-email pass rate: 100%
Change-Id: Ie0771ffc40e6cdee696756a8e831ae56bbe8f84d
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
(cherry picked from commit
1440977fb5202077c98d86da90ee2046bc213132)
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Ie11b3d545d450613ecf61ccee824744108218c73
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I0d282d007e89b4c761fa74d9b0737ca35c29ec57
[Content] isFavorite added to editableAttributes array
[Bug] Since 2.3 isFavorite is an editableAttribute, which was missing
in editableAttributes array. Now added it there.
[Verification] Code compiles without errors.
Change-Id: Ib5266a66920f0050fd5c25287602514bc4ea3762
Piotr Kosko [Wed, 17 Apr 2019 10:35:16 +0000 (10:35 +0000)]
Merge "[Project][Codeformat] Added prettier as partial formatter for JS" into tizen_3.0
Piotr Kosko [Wed, 17 Apr 2019 10:34:30 +0000 (10:34 +0000)]
Merge "[Project][code_formatter] Added u options and changed JS formatting and validating tools" into tizen_3.0
[Project][Codeformat] Added prettier as partial formatter for JS
[Feature] Existing solution check the format using eslint and fix
some issues with predefined rules (which match the requirements
of review.tizen.org CodingRule_Auto bot rules.
However the tool checks the validity, it does not provide auto
formating of too long lines issues.
To ensure such feature, the new tool was introduced and executed before
eslint validation.
Thanks to prettier, the line breaks are unified and handled the same
way in whole project.
Change-Id: I077036521307ef28fda5388ecab01b8d850ad3e3
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I42897295af557b4844c1b9c4a16a687e96045cc5
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I8f28e19de69751b7b92328491366aa0b8c7c6847
[version] 2.32
Change-Id: Idb24a1afa087aa101cebcfde7d46d283d459c956
[Filesystem] listFiles method of File ignores files without access
[Bug] Files with invalid SMACK labels (not allowed to be accessed by app)
caused exception about missing member ("location is required argument").
Fix ignores the files that cannot be accessed.
[Verification] Manually checked with Chrome console and trying to list files
with invalid SMACK label. Files are being ignored.
100% passrate for filesystem module.
Change-Id: I48ed83ebbba5d0c6cfa0e597f083a7a1abce17fa
Arkadiusz Pietraszek [Wed, 27 Mar 2019 14:29:37 +0000 (15:29 +0100)]
[Project][code_formatter] Added u options and changed JS formatting and validating tools
Now eslint is used to format js files.
Not all issues can be fixed by eslint, so it prints list of issues for user to fix.
All 'u' options in formatter format appropriate files, that was changed from last commit.
Since files to format are not commited, this script backs up those files.
[Verification] Script executes without errors and proper files are chosen to format. Formated .js files have 4 spaces of indentation.
Change-Id: I10509ce3f639b25cca7e68e95e7c9419d9d82304
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 12:42:20 +0000 (13:42 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201889/
Change-Id: Ic48f0740da9c73ef676d30eedf72226c7f4d5699
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 11:19:48 +0000 (12:19 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201880/
Change-Id: I26f3ae8991218e97d1a55cf6a0abffba622ed25f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 13:55:22 +0000 (14:55 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201891/
Change-Id: Ia5efe12e79b7f388c2a967a7f118c33edc34d06f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[version] 2.38
Change-Id: If39fca0d841550a2b4d36489374276686adcf14d
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Lukasz Bardeli [Mon, 7 Jan 2019 10:24:28 +0000 (11:24 +0100)]
[Common] Fix preventing crash in argument validator
If to method which takes object as parameter, array with one element
of this object will be passed them applicaiton will crash. This fix prevent
such situations and will throw TypeMissmatch
[Verification] Code compiles without error. Tested in chrome console and
execute automatic TCT (modules which have methods taking platform object as parameter -
account, alarm, application, bluetooth, bookmark, calendar, callhistory, contact,
content, download, exif, filesystem, iotcon, mediacontroller, messageport,
messaging, nfc, notification, push, time)
100% passrate
Change-Id: Idfd9ad6f1acc0a6d5fd140dfd655d1cab7d2291a
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
(cherry picked from commit
faaf457e2aa1307f0c3406208374d71d5c98827b)
Lukasz Bardeli [Thu, 24 Jan 2019 09:40:40 +0000 (10:40 +0100)]
[Messaging] Adding Log to get information about open error
[Verification] Code compiles properly.
Change-Id: I41dcf32e20eea77e1c7f37a7bc3d981baaa2cc32
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Icf1b978d0b5a6dea865fe10426e51ed79fe0d7ae
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I7bdf58474ccd556f444f93dee7856566a65373b6
[version] 2.31
Change-Id: Ic8c3ade13866c7e55ee660346c3a79103f29d006
[Archive][Exif] Added checking return value of fseek
SVACE issues: 246302, 246317
Change-Id: If4f803b9db18c352912290b25df706a21cd07853
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I95d2ae95dbf4f9688dcd3c4beb3fecb0aac52206
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ifadc8944744fa1fe4e944670a51c184f1c36c228
[version] 2.30
Change-Id: I701491ee275a9540c9ddb821f420898629a3f5ca
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Szymon Jastrzebski [Tue, 8 Jan 2019 09:46:38 +0000 (10:46 +0100)]
[Content] Replacing deprecated function
+ Function media_info_create_thumbnail has been deprecated since 5.0,
media_info_generate_thumbnail is used instead.
[Verification] TCT Content 100%
Change-Id: Ic79400e6ed2f8c18aa803e1d3f9953d9c82a78c7
Szymon Jastrzebski [Fri, 4 Jan 2019 14:30:25 +0000 (15:30 +0100)]
[Sound] Replacing deprecated function
[Verification] TCT Sound 100%
Change-Id: I6ad5e1142bc64a731244608a7b5629831570fef3
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Pawel Wasowski [Fri, 21 Dec 2018 13:16:04 +0000 (14:16 +0100)]
Fix ApplicationControlData creation
Verification: 100% TCT pass rate
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Change-Id: I3dc0a7eba685a0ec7e1e111350f9a68ae3f3296d
Piotr Kosko [Thu, 6 Dec 2018 13:50:43 +0000 (13:50 +0000)]
Merge "[Filesystem] Moving execution of FSManager's methods into TaskQueue" into tizen_5.0
Piotr Kosko [Thu, 6 Dec 2018 13:31:29 +0000 (13:31 +0000)]
Merge "[MessagePort] Fixed issue with removeMessagePortListener without any added earlier" into tizen_5.0
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Szymon Jastrzebski [Fri, 24 Aug 2018 10:15:08 +0000 (12:15 +0200)]
Changing scheduling jobs to the main loop/worker
+ Creating stand-alone threads should be only exceptional, thus the
occurrences have been replaced by calling TaskQueue::Async.
[Verification] Callhistory, NBS, Preference, SE, SS, Widget
TCT 100% pass rate
Change-Id: Ibf7493d04c2cd48221d4a4f9f708722e61ee1459
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Thu, 28 Jun 2018 06:35:46 +0000 (08:35 +0200)]
[Common] Adding guard to protect container of Instances*
[Verification] TCT Application, Systeminfo, Filesystem 100%
Change-Id: Ife71f69fc031d14c6bcb1ec694cd2be102ed7f75
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Fri, 22 Jun 2018 11:38:55 +0000 (13:38 +0200)]
[Common] Implementation for parallel Worker
Change-Id: I93a0494cf5c943d2ead9e55957c25468764aebf8
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Fri, 22 Jun 2018 09:24:08 +0000 (11:24 +0200)]
[Common] Moving Filesystem Worker's implementation to common
Change-Id: I0119cee796112d46bbb5e7eb8ebf9fa7042fc9ff
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Mon, 3 Dec 2018 08:00:33 +0000 (09:00 +0100)]
[Filesystem] Moving execution of FSManager's methods into TaskQueue
Change-Id: I97c136014e57ba9d677ce6d8e7633531348bf1c6
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Lukasz Bardeli [Mon, 26 Nov 2018 11:19:29 +0000 (12:19 +0100)]
Merge branch 'tizen_5.0' into tizen
Change-Id: I7c84d15458fb0b79f5379924c0745dc69e963e9c
Lukasz Bardeli [Mon, 26 Nov 2018 10:18:42 +0000 (11:18 +0100)]
[version] 2.35
Change-Id: Ia943de0b76d2e6721838e7dfb8291ed8c99d2446
Signed-off-by: Lukasz Bardeli <l.bardeli@AMDC967.digital.local>
Lukasz Bardeli [Mon, 26 Nov 2018 09:53:30 +0000 (09:53 +0000)]
Merge "[Archive] Fix for preventing errno overwriting" into tizen_5.0
Lukasz Bardeli [Mon, 26 Nov 2018 09:49:53 +0000 (10:49 +0100)]
[Archive] Fix for preventing errno overwriting
Sometimes errno was overwritten and in switch return different values that was
assigned in lstat. This caused issue in throwing errors (IO instead Not Found)
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I79fc23cdd4c9113cab56d42cee6b5df82ed632a1
Signed-off-by: Lukasz Bardeli <l.bardeli@AMDC967.digital.local>
[Filesystem] Fixing return behaviour for FileHandle object
[Bug] When returning the asynchronous error while doing an operation on
FileHandle, the processing was not interrupted. Missing return statement
in those cases was added.
[Verification] Code compiles without errors.
TCT passrate for Filesystem - 100%
Change-Id: Ie8ba77922fa74c0263c40e55a157c2979b893cff
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Fri, 23 Nov 2018 13:11:06 +0000 (13:11 +0000)]
Merge "[Mediacontroller] Removed usage of removed native API" into tizen
Piotr Kosko [Fri, 23 Nov 2018 13:10:24 +0000 (13:10 +0000)]
Merge "Changing scheduling jobs to the main loop/worker" into tizen
Piotr Kosko [Fri, 23 Nov 2018 13:04:37 +0000 (13:04 +0000)]
Merge "[Common] Adding guard to protect container of Instances*" into tizen
Piotr Kosko [Fri, 23 Nov 2018 13:02:40 +0000 (13:02 +0000)]
Merge "[Common] Implementation for parallel Worker" into tizen
[Mediacontroller] Removed usage of removed native API
[Feature] As the native support for old enum values was removed,
there is no need for using multimap in webapi code. It was changed
regular map instead.
[Native ACR] According to removal of native API
http://suprem.sec.samsung.net/jira/browse/ACR-1314 we need to
remove native code which creates buildbreak.
[Verification] Code compiles without errors.
TCT 100% passrate.
Change-Id: I5f23941f12b279b83079eb3d482d651c567fc847
Piotr Kosko [Thu, 22 Nov 2018 13:31:19 +0000 (13:31 +0000)]
Merge "[PPM] Removing unnecessary static casts" into tizen_5.0
Pawel Wasowski [Mon, 15 Oct 2018 14:50:07 +0000 (16:50 +0200)]
[Application] Make launch() and launchAppControl() asynchronous
launch() and launchAppControl() were implemented synchronously, due to
native APIs limitations. Both functions were refactored to use new
native function, enabling sending application controls asynchronously.
[Verification] TCT pass rate: 100%
Change-Id: I6cb809d4b5713ca4a80a1f48649fb680358fa7d4
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Szymon Jastrzebski [Wed, 21 Nov 2018 16:12:23 +0000 (17:12 +0100)]
[PPM] Removing unnecessary static casts
+ SDL-42
+ Useless variables removed
+ Fixed memory leak
[Verification] TCT PPM 100%
Change-Id: Iccc3d6875bae6c2883f44977c22db812d73e5d01
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Pawel Wasowski [Mon, 5 Nov 2018 09:27:50 +0000 (10:27 +0100)]
[Application] Refactor app_control_h construction. Fix minor bugs.
ApplicationUtils::ApplicationControlToService() function did not set
launch_mode in an app_control_h object. As a result, methods using the
function had to set launch_mode. Now the function sets the launch mode.
Apart from that change, this commit introduces minor fixes:
* error codes returned by native functions in
ApplicationUtils::ApplicationControlToService() and
ApplicationUtils::ApplicationControlDataToServiceExtraData()
are now tested
* log messages in modified functions are more informative
* ApplicationManager::LaunchAppControl() no longer sets launch_mode of
an app_control_h object
[Verification] TCT pass rate: 100%
Change-Id: Ibc4c2625ce795c872560d13454895671777c6f2b
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Piotr Kosko [Tue, 20 Nov 2018 11:26:29 +0000 (11:26 +0000)]
Merge "[Common] Moving Filesystem Worker's implementation to common" into tizen
Piotr Kosko [Tue, 20 Nov 2018 10:00:47 +0000 (10:00 +0000)]
Merge "[WidgetService] Unify way of checking watchId in webapi plugins." into tizen_5.0
Lukasz Bardeli [Tue, 20 Nov 2018 09:25:54 +0000 (10:25 +0100)]
[WidgetService] Unify way of checking watchId in webapi plugins.
Unify the way of how passed argument is checked in removeListener methods to be
consistent with other modules in webapi plugins.
[Verification] Code compiles without error.
I/StarFish(22486): console.log: [tct-widgetservice-tizen-test] - 85 passed, 0 failed, 0 timed out, 0 not run.
Change-Id: I904e4f8ef8b536b2a5c0fc22c3aee2b897c7b90b
Signed-off-by: Lukasz Bardeli <l.bardeli@AMDC967.digital.local>
Merge branch 'tizen_5.0' into tizen
Change-Id: I8baf7ed0da8fbe05922fb6e9423b3ff8132018ad
Piotr Kosko [Tue, 20 Nov 2018 08:46:26 +0000 (08:46 +0000)]
Merge "Merge branch 'tizen_4.0' into tizen_5.0" into tizen_5.0
Piotr Kosko [Tue, 20 Nov 2018 08:42:20 +0000 (08:42 +0000)]
Merge "[Application] Fix ApplicationControl object construction and logs" into tizen_5.0
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I1006e7daf1ab5f3375dbb9c39c945cc6ea69365b
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I3142680c3588c1287d4dc23af6aee9832ebe6cd0
[version] 2.29
Change-Id: I27c09aef9adc3ba125477521e95a85633b0e702d
[Common] Added missing return statement
[Bug] When parsing invalid message, exception is catched, but the control
is not finished. Going to following lines, other exception would be raised.
We need to finish execution for invalid message.
[Verification] Code compiles without errors.
Change-Id: I65784e775b9a765332c4a1f0a19b8184e896872c
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Pawel Wasowski [Fri, 2 Nov 2018 14:39:33 +0000 (15:39 +0100)]
[Application] Fix ApplicationControl object construction and logs
This commit fixes 2 issues of
ApplicationUtils::ServiceToApplicationControl function:
1. launchMode field of JS ApplicationControl object was not filled.
Now, this field is filled properly.
2. valid, empty values, obtained from app_control_h object were logged
as erroneous. Now they are logged as empty.
[Verification] TCT pass rate: 100%
Change-Id: I6589d73ccebc35fbede0c9fac6b663b376970174
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Lukasz Bardeli [Tue, 13 Nov 2018 11:15:06 +0000 (12:15 +0100)]
[version] 2.33
Change-Id: Ia46d684e134f26a08b83dd6cfef19b91fe6ea7e1
Signed-off-by: Lukasz Bardeli <l.bardeli@AMDC967.digital.local>
[Common] Fixing building dependency issues part 1
Fixed some modules dependencies issues.
Fixed gyp files for using only dependencies verified by designed tool.
[Verification] Code builds successfully.
Change-Id: I8f419781c1269d53dc77e15322d74a1db45bb266
Lukasz Bardeli [Tue, 13 Nov 2018 11:15:06 +0000 (12:15 +0100)]
[version] 2.33
Change-Id: Ia46d684e134f26a08b83dd6cfef19b91fe6ea7e1
Signed-off-by: Lukasz Bardeli <l.bardeli@AMDC967.digital.local>
[Common] Fixing building dependency issues part 1
Fixed some modules dependencies issues.
Fixed gyp files for using only dependencies verified by designed tool.
[Verification] Code builds successfully.
Change-Id: I8f419781c1269d53dc77e15322d74a1db45bb266
Piotr Kosko [Wed, 31 Oct 2018 08:27:09 +0000 (09:27 +0100)]
[version] 2.32
Change-Id: I015ff1cd7283f17b66f63f1a001952aad58fa596
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 31 Oct 2018 08:14:31 +0000 (08:14 +0000)]
Merge "[MediaController] Replaced deprecated functions." into tizen
Michal Michalski [Fri, 26 Oct 2018 12:51:01 +0000 (14:51 +0200)]
Fix for functions throwing exceptions unspecified by documentation.
Functions for removing listeners threw exceptions if listener id
was not registered. This behavior was not specified in docs.
This commit disables those exception and silently returns from
functions if listener for given id is not found.
[Verification] TCT tests which call changed api functions passed.
Change-Id: I8fe1a07ade9a35bfbfa95c1a628eeff95a420e0f
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Wed, 24 Oct 2018 11:54:58 +0000 (13:54 +0200)]
[MediaController] Replaced deprecated functions.
+ mc_client_send_custom_command --> mc_client_send_custom_cmd
[Verification] tct-mediacontroller-tizen-tests all passed.
Change-Id: Ib39b5aa971fcdb1c8984f432945863af08ddbe80
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Tue, 23 Oct 2018 06:13:10 +0000 (08:13 +0200)]
Merge branch 'tizen_4.0' into tizen
Change-Id: I140b2b7f5d060e2f21c3c99b010aa5c8ef895e50
Piotr Kosko [Tue, 23 Oct 2018 06:11:37 +0000 (06:11 +0000)]
Merge "[Systeminfo] Internal implementation changed to use only public native API" into tizen
Piotr Kosko [Tue, 23 Oct 2018 05:30:19 +0000 (07:30 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I1095cde2fdf145ec952fb0ce220837705982086f
Pawel Wasowski [Mon, 22 Oct 2018 14:07:08 +0000 (16:07 +0200)]
[Common] Fix typo in logger format string
The project failed to build, if "enable_common_debug_logs%" flag in
src/common/common.gyp was set to "1". It was due to LoggerD's format
string, incompatible with the actual type of the logged variable.
[Verification] the project builds without error, if
"enable_common_debug_logs%" is set to "1"
Change-Id: Ic7b7d51341f327ce96003312a93e9cfbb09db5b8
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Piotr Kosko [Mon, 22 Oct 2018 12:16:20 +0000 (14:16 +0200)]
[version] 2.28
Change-Id: Icfae075f33085630150a69087c7dc8ccd78c9697
Piotr Kosko [Mon, 22 Oct 2018 12:04:20 +0000 (12:04 +0000)]
Merge "[Mediacontroller] Refactoring and replacing deprecated functions" into tizen
Pawel Wasowski [Fri, 19 Oct 2018 10:03:02 +0000 (12:03 +0200)]
[Messaging] Refactor MessageConversation related code
Refactoring was requested to get rid of duplicated and unnecessary
code.
[Verification] TCT pass rate: 100%
Change-Id: Iee2eacf50ca89ea60e89b283d3aac24111cfd5e5
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 19 Oct 2018 10:03:02 +0000 (12:03 +0200)]
[Messaging] Refactor MessageConversation related code
Refactoring was requested to get rid of duplicated and unnecessary
code.
[Verification] TCT pass rate: 100%
Change-Id: Iee2eacf50ca89ea60e89b283d3aac24111cfd5e5
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 19 Oct 2018 10:03:02 +0000 (12:03 +0200)]
[Messaging] Refactor MessageConversation related code
Refactoring was requested to get rid of duplicated and unnecessary
code.
[Verification] TCT pass rate: 100%
Change-Id: Iee2eacf50ca89ea60e89b283d3aac24111cfd5e5
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Piotr Kosko [Tue, 16 Oct 2018 08:56:25 +0000 (08:56 +0000)]
Merge "[NBS] Adding and removing routes with new native methods." into tizen
Arkadiusz Pietraszek [Fri, 5 Oct 2018 10:52:18 +0000 (12:52 +0200)]
[NBS] Adding and removing routes with new native methods.
Old implementation used deprecated native methods - changed
to replacement methods.
[Verification] TCT pass rate: 100%
Change-Id: I62f264b547666bc807e8451aec1d216264726750
Piotr Kosko [Mon, 15 Oct 2018 11:36:47 +0000 (11:36 +0000)]
Merge "[Messaging] Fix sorting and filtering issues in findConversations" into tizen
Piotr Kosko [Thu, 11 Oct 2018 12:39:17 +0000 (14:39 +0200)]
[Systeminfo] Internal implementation changed to use only public native API
[Feature] The internal implementaiton was using non-public API of device.h
library, which makes the hazard of not being supported in future versions.
To avoid the risk of that, the implementation was improved to use only
public API. Changed implementation has a guarantee that the API change
is maintained properly and will not disappear (could be removed only following
the deprecation and removal procedure).
[Verification] Methods getAvailableMemory() and getTotalMemory() were checked
with Chrome console.
TCT passrate of systeminfo module was not changed.
Change-Id: If6f651979f3b3010834f91ff6699b53c770ee760
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Pawel Wasowski [Fri, 24 Aug 2018 16:12:09 +0000 (18:12 +0200)]
[Messaging] Fix sorting and filtering issues in findConversations
The commit fixes the following problems of email service's findConversations:
- conversations sorted with regard to timestamp, subject, to, from attributes
were ordered incorrectly
- an attempt to sort results with regard to unreadMessages, isRead, cc,
bcc, lastMessageId attributes resulted in throwing a JS exception
- unreadMessages attribute value depended on the offset argument value
- filtering by unreadMessages, did not work
The commit changes also the method of creation of MessageConversation
from database records. It may be quicker than the previous one,
that unnecessarily retrieved numerous messages from the database several times.
[Verification] TCT Pass rate: 100%
Several filters and sort modes were tested manually,
with Chrome DevTools.
Change-Id: I6196e316ff2b1477c909d528859ef980237454b6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 24 Aug 2018 16:12:09 +0000 (18:12 +0200)]
[Messaging] Fix sorting and filtering issues in findConversations
The commit fixes the following problems of email service's findConversations:
- conversations sorted with regard to timestamp, subject, to, from attributes
were ordered incorrectly
- an attempt to sort results with regard to unreadMessages, isRead, cc,
bcc, lastMessageId attributes resulted in throwing a JS exception
- unreadMessages attribute value depended on the offset argument value
- filtering by unreadMessages, did not work
The commit changes also the method of creation of MessageConversation
from database records. It may be quicker than the previous one,
that unnecessarily retrieved numerous messages from the database several times.
[Verification] TCT Pass rate: 100%
Several filters and sort modes were tested manually,
with Chrome DevTools.
Change-Id: I6196e316ff2b1477c909d528859ef980237454b6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 24 Aug 2018 16:12:09 +0000 (18:12 +0200)]
[Messaging] Fix sorting and filtering issues in findConversations
The commit fixes the following problems of email service's findConversations:
- conversations sorted with regard to timestamp, subject, to, from attributes
were ordered incorrectly
- an attempt to sort results with regard to unreadMessages, isRead, cc,
bcc, lastMessageId attributes resulted in throwing a JS exception
- unreadMessages attribute value depended on the offset argument value
- filtering by unreadMessages, did not work
The commit changes also the method of creation of MessageConversation
from database records. It may be quicker than the previous one,
that unnecessarily retrieved numerous messages from the database several times.
[Verification] TCT Pass rate: 100%
Several filters and sort modes were tested manually,
with Chrome DevTools.
Change-Id: I6196e316ff2b1477c909d528859ef980237454b6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Piotr Kosko [Wed, 3 Oct 2018 05:06:34 +0000 (07:06 +0200)]
Merge branch 'tizen_4.0' into tizen
Commit fixes SVACE issues - 246302, 246317
[Verification] Code compiles successfully, TCT for archive and exif 100%
Change-Id: Ia1ffd75f5460d952c50988f08ef38a6b2acb6e26
Piotr Kosko [Tue, 2 Oct 2018 12:11:27 +0000 (14:11 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Iaff2d9c208f5291dfac1eacb23070b8c4f3f10f2
Piotr Kosko [Tue, 2 Oct 2018 12:08:07 +0000 (14:08 +0200)]
[version] 2.27
Change-Id: I7aa0f9e1384347db1d0b045ef46542fcd5e8c7a2
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 2 Oct 2018 11:25:19 +0000 (13:25 +0200)]
[Archive][Exif] Added missing error checking
[Verification] Code compiles without errors.
Change-Id: I588a1d08f4dea4a19038653b2889a1daa5b45673
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 2 Oct 2018 10:11:10 +0000 (10:11 +0000)]
Merge "[PPM] Add checkPermissions and requestPermissions implementation" into tizen