platform/upstream/efl.git
4 years agotests/loop_timer: add port of ecore_timer behavior tests for loop_timer
Mike Blumenkrantz [Fri, 25 Oct 2019 17:56:04 +0000 (13:56 -0400)]
tests/loop_timer: add port of ecore_timer behavior tests for loop_timer

ensure that the behavior here is also working exactly as expected

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10531

4 years agotests/ecore: make timer behavior test even more strict
Mike Blumenkrantz [Fri, 25 Oct 2019 16:50:48 +0000 (12:50 -0400)]
tests/ecore: make timer behavior test even more strict

we need to also verify that timers will process out of order solely based
on their timestamps and ignoring whether they are "recently-added"

additionally verify the behavior of timer interval changing and re-instantiating

ref T8434

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10530

4 years agoelm/genlist: fix item focus unregister on item move
Mike Blumenkrantz [Mon, 28 Oct 2019 19:45:56 +0000 (15:45 -0400)]
elm/genlist: fix item focus unregister on item move

if the block is realized, its items have been registered into the focus
manager and must be unregistered to avoid double-registering

@fix

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10544

4 years agoelm/genlist: hide cached item contents and mark content unfocusable during calc
Mike Blumenkrantz [Mon, 28 Oct 2019 19:48:08 +0000 (15:48 -0400)]
elm/genlist: hide cached item contents and mark content unfocusable during calc

cached item contents should already be hidden by the edje clipper, so this simply
changes their visible state to break them out of the focus calcs

contents must also be explicitly marked as unfocusable during calc-only realize
operations in order to avoid triggering a full focus recalc which will error due
to missing focus adapter in the item block

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10543

4 years agoelm/genlist: set pan need recalc during item move on item position change
Mike Blumenkrantz [Fri, 25 Oct 2019 19:05:29 +0000 (15:05 -0400)]
elm/genlist: set pan need recalc during item move on item position change

item move operations require pan recalc in order to process the item block
positioning updates

@fix

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10533

4 years agoelm/genlist: fix "drag" smart callback
Mike Blumenkrantz [Thu, 24 Oct 2019 15:36:30 +0000 (11:36 -0400)]
elm/genlist: fix "drag" smart callback

this is only a smart callback and not an eo callback

@fix

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10527

4 years agoelm/genlist: trigger filter,done callback immediately if no filter queue exists
Mike Blumenkrantz [Wed, 23 Oct 2019 14:38:53 +0000 (10:38 -0400)]
elm/genlist: trigger filter,done callback immediately if no filter queue exists

the documentation says this should trigger when filtering is done, and if
no filtering is pending then it is done

@fix

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10526

4 years agoelm/genlist: slightly simplify use of _item_filtered_get()
Mike Blumenkrantz [Wed, 23 Oct 2019 14:36:01 +0000 (10:36 -0400)]
elm/genlist: slightly simplify use of _item_filtered_get()

passing the smart data here (which we always have) makes the function
a little clearer to read. similarly, we can check whether the filter_data
pointer is set inside the function to avoid having to check it everywhere else

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10525

4 years agoelm/genlist: defer recalc when applying a name filter
Mike Blumenkrantz [Wed, 23 Oct 2019 14:27:04 +0000 (10:27 -0400)]
elm/genlist: defer recalc when applying a name filter

this may be called successively during the same mainloop iteration,
so it's important to defer this as much as possible

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10524

4 years agoelm/genlist: remove calc jobs
Mike Blumenkrantz [Mon, 21 Oct 2019 20:05:33 +0000 (16:05 -0400)]
elm/genlist: remove calc jobs

now that we have a sane and consistent sizing calc mechanism, we no longer
need to be randomly creating jobs to do additional side calcs in addition
to our other multiple bespoke calculation methods

instead, we can now call the calc function directly during the group calc
to perform all the calcs at once and avoid the overhead of constantly triggering
calc jobs

a possible future improvement here could be to remove the _calc_job() call in
the internal pan object's group_calculate, as this is likely a duplicated op
but it will require additional testing to verify

unit test performance (e.g., tree) increases roughly 50-80% after this patch

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10523

4 years agoelm/genlist: don't process entire item queue on each item add
Mike Blumenkrantz [Mon, 21 Oct 2019 20:03:56 +0000 (16:03 -0400)]
elm/genlist: don't process entire item queue on each item add

this is a colossal waste of time. it ends up realizing every single item
immediately even if it won't be visible, which defeats the purpose of all
the batching and viewport calculations that genlist explicitly does to
avoid exactly this type of behavior

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10522

4 years agoelm/genlist: freeze/thaw canvas when processing item queue
Mike Blumenkrantz [Mon, 21 Oct 2019 20:01:34 +0000 (16:01 -0400)]
elm/genlist: freeze/thaw canvas when processing item queue

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10521

4 years agoelm/genlist: only add calc job on theme apply if already finalized
Mike Blumenkrantz [Mon, 21 Oct 2019 19:53:35 +0000 (15:53 -0400)]
elm/genlist: only add calc job on theme apply if already finalized

not a required operation otherwise

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10519

4 years agoelm/genlist: remove misleading "changed" signal
Mike Blumenkrantz [Mon, 21 Oct 2019 18:02:34 +0000 (14:02 -0400)]
elm/genlist: remove misleading "changed" signal

this was never implemented or documented anywhere and serves only to be
misleading for anyone reading the code

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10518

4 years agoelm/genlist: fix item highlight/unhighlight eventing on clicks
Mike Blumenkrantz [Mon, 21 Oct 2019 15:02:18 +0000 (11:02 -0400)]
elm/genlist: fix item highlight/unhighlight eventing on clicks

* highlight should only be triggered on mouse down, as that is the point of
  interaction with an item which indicates it is "in use"; a mouse-up event
  cannot occur on an item which has not previously received a mouse-down event,
  so toggling this on mouse-up will be wrong/duplicated 100% of the time
* unhighlight should only be triggered during mouse-up events if the list is
  in no-select mode, as it will otherwise be implicitly during selection if
  necessary

this should ensure that these events are emitted exactly one time and correctly
for each click event

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10517

4 years agotests/ecore: add more grueling timer throughput test
Mike Blumenkrantz [Thu, 24 Oct 2019 18:26:24 +0000 (14:26 -0400)]
tests/ecore: add more grueling timer throughput test

this verifies that:
* newly-created timers are not triggered in the next loop iteration
* newly-created timers can be triggered the second loop after created
* multiple timers can be triggered in a single loop iteration
* timers are effectively added to the pending timer list

ref T8434

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10516

4 years agoefl/timer: correctly handle recursion for timer processing
Mike Blumenkrantz [Thu, 24 Oct 2019 15:22:49 +0000 (11:22 -0400)]
efl/timer: correctly handle recursion for timer processing

if the currently-processed timer is recursively deleted (efl_del) while
it is inside the timer tick event callback, we must correctly handle this
case:

* in the place where a timer's inlist is de-linked, we must check to see
  if the timer is the current timer and then update that pointer with the next
  timer in the list
* in the post-tick part of timer processing, we must NOT update the current timer
  pointer if we detect that it has been updated recursively

this fixes processing of timers in the mainloop to trigger more than one legacy timer
per mainloop iteration and likely has some (positive) impact on mainloop throughput

@fix

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10515

4 years agoefl/timer: don't attempt instantiating timers until they're finalized
Mike Blumenkrantz [Thu, 24 Oct 2019 15:22:17 +0000 (11:22 -0400)]
efl/timer: don't attempt instantiating timers until they're finalized

this will fail anyway so don't bother

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10514

4 years agotests/genlist: fix tree test sizing
Mike Blumenkrantz [Mon, 21 Oct 2019 19:52:17 +0000 (15:52 -0400)]
tests/genlist: fix tree test sizing

for some reason I used 10px as the base height of a genlist item when clearly
they are more like 30px

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10513

4 years agotests/elm: add utility function to trigger a mouse drag
Mike Blumenkrantz [Thu, 24 Oct 2019 15:37:32 +0000 (11:37 -0400)]
tests/elm: add utility function to trigger a mouse drag

a drag may require a lot of internal calculating to successfully trigger
the intended test behavior, so this has a flag which allows it to perform
loop iterations and canvas calcs in order to be more universal, along with
a global #define for determining exactly how many mouse moves were triggered

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10512

4 years agotests/elm: make argv a static char so it never goes out of scope and crashes
Mike Blumenkrantz [Mon, 21 Oct 2019 19:51:28 +0000 (15:51 -0400)]
tests/elm: make argv a static char so it never goes out of scope and crashes

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10511

4 years agotests/elm: add util functions for clicking objects/parts with event flags
Mike Blumenkrantz [Mon, 21 Oct 2019 14:34:57 +0000 (10:34 -0400)]
tests/elm: add util functions for clicking objects/parts with event flags

this is useful for synthesizing e.g., double click events

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10510

4 years agotests/elm: add util callback for incrementing an int data
Mike Blumenkrantz [Mon, 21 Oct 2019 14:30:45 +0000 (10:30 -0400)]
tests/elm: add util callback for incrementing an int data

this is a common functionality

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10509

4 years agoefl_ui_win: Delete useless geometry set for legacy.edje
Woochanlee [Tue, 29 Oct 2019 13:47:48 +0000 (09:47 -0400)]
efl_ui_win: Delete useless geometry set for legacy.edje

Summary:
It will be resized on window_resize_job. when the window got specific size.
I don't think this is needed here. It cause doing a calc in vain.

Test Plan: Launching Test applications.

Reviewers: raster, Hermet, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10550

4 years agoedje_calc: Delete duplicated conditional statement.
Woochanlee [Tue, 29 Oct 2019 13:37:56 +0000 (09:37 -0400)]
edje_calc: Delete duplicated conditional statement.

Summary: this is identical to the conditional above and can be merged
to improve code clarity

Reviewers: raster, Hermet, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10549

4 years agoReplace tabs with spaces
Xavi Artigas [Tue, 29 Oct 2019 13:56:01 +0000 (14:56 +0100)]
Replace tabs with spaces

As our coding conventions mandate.

4 years agovg_common_svg: Free node tree for memory leak after eet write.
JunsuChoi [Tue, 29 Oct 2019 04:17:05 +0000 (13:17 +0900)]
vg_common_svg: Free node tree for memory leak after eet write.

Summary:
The node tree created from vg_common_svg_create_svg_node is not used after eet_data_write().
Therefore, to prevent memory leaks, free the node tree.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10443

4 years agoeolian_cxx: Add key/value to function_def
Lauro Moura [Mon, 28 Oct 2019 23:35:39 +0000 (20:35 -0300)]
eolian_cxx: Add key/value to function_def

Summary:
This commit adds explicit eolian key/value/return info to function_def. The
original parameter/return types are kept for compatibility.

parameter/return -> Mimics the behavior of the generated C API (i.e.
single-valued getters have their lone value translated to be their
return type)

explicit_return -> The actual return value for that block in the EO
file.
keys/values -> The values for respectively key and values blocks.

This should help working with properties in the generators instead of
fumbling with paremeter/return directly

Fixes T8431

Test Plan: extra tests in the diff

Reviewers: felipealmeida, brunobelo, segfaultxavi, YOhoho

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers, woohyun

Tags: #efl

Maniphest Tasks: T8431

Differential Revision: https://phab.enlightenment.org/D10494

4 years agocsharp: Add comparables operator to eina_error.
Bruno da Silva Belo [Mon, 28 Oct 2019 23:34:55 +0000 (20:34 -0300)]
csharp: Add comparables operator to eina_error.

Summary: ref T8394

Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8394

Differential Revision: https://phab.enlightenment.org/D10456

4 years agocsharp: Add comparables operators to eina_value.
Bruno da Silva Belo [Mon, 28 Oct 2019 23:34:25 +0000 (20:34 -0300)]
csharp: Add comparables operators to eina_value.

Summary: ref T8394

Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho, bu5hm4n

Reviewed By: YOhoho

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8394

Differential Revision: https://phab.enlightenment.org/D10458

4 years agoeina_mono: remove exceptions in unexpected locations
Yeongjong Lee [Mon, 28 Oct 2019 23:33:47 +0000 (20:33 -0300)]
eina_mono: remove exceptions in unexpected locations

Summary:
Unexpected locations are listed in
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1065

fix CA1065
ref T8402

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8402

Differential Revision: https://phab.enlightenment.org/D10461

4 years agomono: encapsulate internal NativeModule
Lauro Moura [Mon, 28 Oct 2019 22:06:38 +0000 (19:06 -0300)]
mono: encapsulate internal NativeModule

Summary:
Depends on D10342
Depends on D10338

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers, woohyun

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10343

4 years agomono: encapsulate internal FunctionWrapper
Lauro Moura [Mon, 28 Oct 2019 22:04:33 +0000 (19:04 -0300)]
mono: encapsulate internal FunctionWrapper

Summary: Depends on D10340

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, woohyun, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10342

4 years agomono: encapsulate internal nativemethods
Lauro Moura [Mon, 28 Oct 2019 21:48:26 +0000 (18:48 -0300)]
mono: encapsulate internal nativemethods

Summary: Depends on D10337

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, woohyun, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10340

4 years agomono: encapsulate internal Add/RemoveNativeEventHandler
Yeongjong Lee [Mon, 28 Oct 2019 21:24:15 +0000 (18:24 -0300)]
mono: encapsulate internal Add/RemoveNativeEventHandler

Summary: Depends on D10337

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, woohyun, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10341

4 years agomono: encapsulate internal CustomMarshaler
Yeongjong Lee [Mon, 28 Oct 2019 21:08:01 +0000 (18:08 -0300)]
mono: encapsulate internal CustomMarshaler

Summary: Depends on D10337

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers, woohyun

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10344

4 years agomono: introduce friend assembly
Yeongjong Lee [Mon, 28 Oct 2019 20:10:48 +0000 (17:10 -0300)]
mono: introduce friend assembly

Summary:
Friend assemblies can access efl_mono assembly's internal types and members.
If `build-tests` option is true, `efl-mono-suite.exe` and `efl_mono_test.dll`
will become friend assemblies.

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: felipealmeida, cedric, #reviewers, woohyun, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10337

4 years agodocs: Polished docs for Efl.Ui.Scrollable
Xavi Artigas [Mon, 28 Oct 2019 18:32:23 +0000 (19:32 +0100)]
docs: Polished docs for Efl.Ui.Scrollable

4 years agodocs: Formatting and polishing Efl.Ui.Factory docs
Xavi Artigas [Mon, 28 Oct 2019 17:46:13 +0000 (18:46 +0100)]
docs: Formatting and polishing Efl.Ui.Factory docs

4 years agospec-suite: verify correct widget-hiding behaviour.
Marcel Hollerbach [Mon, 28 Oct 2019 16:40:27 +0000 (12:40 -0400)]
spec-suite: verify correct widget-hiding behaviour.

Summary:
These checks are ensuring that when we are hiding a widget, that
everything inside these widgets are also hidden correctly. Due to
clipper or due to visibility flag.

Depends on D10468

Reviewers: zmike

Reviewed By: zmike

Subscribers: zmike, segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10474

4 years agoefl_ui_spotlight_manager: apply vis changes to subobj
Marcel Hollerbach [Mon, 28 Oct 2019 16:40:17 +0000 (12:40 -0400)]
efl_ui_spotlight_manager: apply vis changes to subobj

Summary:
when the sportlight is hidden, the state should be applied to the
backclip and foreclip, in order to hide the subobjects correctly.

This fixes dangling showing widgets.

Reviewers: Jaehyun_Cho, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10468

4 years agodocs: Improve documentation on cache-related classes
Xavi Artigas [Mon, 28 Oct 2019 15:05:08 +0000 (16:05 +0100)]
docs: Improve documentation on cache-related classes

Also, code comments and typos.

4 years agocsharp: Add missing exception ctor from Errors.cs.
Bruno da Silva Belo [Mon, 28 Oct 2019 14:43:56 +0000 (11:43 -0300)]
csharp: Add missing exception ctor from Errors.cs.

Summary: ref T8392

Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8392

Differential Revision: https://phab.enlightenment.org/D10455

4 years agocsharp: Add missing exception ctr from iwrapper.
Bruno da Silva Belo [Mon, 28 Oct 2019 14:59:52 +0000 (11:59 -0300)]
csharp: Add missing exception ctr from iwrapper.

Summary: ref T8392

Reviewers: felipealmeida, lauromoura, segfaultxavi, YOhoho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8392

Differential Revision: https://phab.enlightenment.org/D10454

4 years agoSilence mono warning in tests
Xavi Artigas [Mon, 28 Oct 2019 14:12:35 +0000 (15:12 +0100)]
Silence mono warning in tests

../src/tests/efl_mono/Model.cs(35,13): warning CS0219: The variable `veggies' is assigned but its value is never used

This was driving me nuts... Am I the only one seeing these things?

4 years agoefreet : Check that the file has a protocol in efreet_desktop_command_file_process()
thierry1970 [Mon, 28 Oct 2019 13:07:12 +0000 (09:07 -0400)]
efreet : Check that the file has a protocol in efreet_desktop_command_file_process()

if a path has a '/' character in it before the ':' character then it
should be treated as a local file which contains a ':' character in
its name

Reviewers: devilhorns, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10409

4 years agoTypo in comment
Xavi Artigas [Mon, 28 Oct 2019 08:40:33 +0000 (09:40 +0100)]
Typo in comment

4 years agoeina_array: add paramName argument of ArgumentNullException
Yeongjong Lee [Fri, 25 Oct 2019 22:14:58 +0000 (19:14 -0300)]
eina_array: add paramName argument of ArgumentNullException

Summary:
ArgumentNullException constructor included `message` is
`public ArgumentNullException (string paramName, string message);`

Fix CA2208
ref T8428

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8428

Differential Revision: https://phab.enlightenment.org/D10464

4 years agoEfl.Ui.Text: Fix Text Cursor composition
Xavi Artigas [Fri, 25 Oct 2019 21:00:31 +0000 (18:00 -0300)]
Efl.Ui.Text: Fix Text Cursor composition

Summary:
This is a temporary fix while Text is being revamped.
Efl.Ui.Text internally composites Efl.Text_Cursor (through some other interfaces)
but this was not being advertised in the EO file.
This caused no trouble to C but was preventing C# from using the Cursors API
(because C# relies on the EO composites section).

On top of this, the cursor_new() method has been removed, since it was redundant.

Test Plan:
Builds and passes tests, and C# is able to do things like:
```
Efl.TextCursorCursor cursor = screen.GetTextCursor(Efl.TextCursorGetType.Main);
screen.InsertCursorText(cursor, str);
```

Reviewers: lauromoura, cedric, tasn

Reviewed By: lauromoura

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10465

4 years agocsharp:Changing ex access modifier from Errors.cs.
Bruno da Silva Belo [Fri, 25 Oct 2019 18:02:54 +0000 (15:02 -0300)]
csharp:Changing ex access modifier from Errors.cs.

Summary: ref T8401

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8401

Differential Revision: https://phab.enlightenment.org/D10502

4 years agoevas: disable Eina Cow Garbage Collection on dynamic content.
Cedric BAIL [Fri, 25 Oct 2019 19:45:14 +0000 (15:45 -0400)]
evas: disable Eina Cow Garbage Collection on dynamic content.

Summary:
Dynamic content are likely to trigger an image state change at pretty
much every frame. This lead to unecessary attempt by Eina_Cow to
deduplicate/cleanup data that are changing all the time. This reduce
memory consumption in Expedite tests that in some small amount. The
gain get bigger the more animation you get on screen. There might be
other potential gain for heavy animated case.

Reviewers: zmike, Hermet, bu5hm4n, smohanty

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8302

Differential Revision: https://phab.enlightenment.org/D10532

4 years agoelm_interface_scrollable: correctly honor looping over
Marcel Hollerbach [Fri, 25 Oct 2019 18:05:00 +0000 (14:05 -0400)]
elm_interface_scrollable: correctly honor looping over

Summary:
when looping is enabled, we need to ensure that the correct arrows are
enabled.

ref D9906

Depends on D9908

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9917

4 years agoelm_interface_scrollable: correctly emit the signals always
Marcel Hollerbach [Fri, 25 Oct 2019 18:04:54 +0000 (14:04 -0400)]
elm_interface_scrollable: correctly emit the signals always

Summary:
our default theme defaults to show everything, the code here assumes
that everything is hidden by default, this fixes all this.

fix T4918

Depends on D9907

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T4918

Differential Revision: https://phab.enlightenment.org/D9908

4 years agoelm_interface_scrollable: correctly handle bouncing
Marcel Hollerbach [Fri, 25 Oct 2019 18:04:46 +0000 (14:04 -0400)]
elm_interface_scrollable: correctly handle bouncing

Summary:
if bounding is enabled, those values can get smaller and bigger than the
max value.

ref T4918

Depends on D9906

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T4918

Differential Revision: https://phab.enlightenment.org/D9907

4 years agotheme: redo scroller theme of elm
Marcel Hollerbach [Fri, 25 Oct 2019 18:04:39 +0000 (14:04 -0400)]
theme: redo scroller theme of elm

Summary:
this was a little bit weird. There was a script that did what we already
do in C and pass it on via signals, however, there was also somewhere a
bug in this script, the arrow was not getting enabled, even if the
position is not completly max and not completly min, the problem here
was that the numbers that are passed to edje are not 100% correct (I
think they got somehwere on the way casted to an int).

With this commit we just use the signals from c in the theme and replace
the theme, this should also make everything a bit easier on the
mainloop, as a single movement of the scroller does not schedule 10
timers anymore.

ref T4918

Reviewers: zmike, eagleeye, woohyun

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T4918

Differential Revision: https://phab.enlightenment.org/D9906

4 years agoci: use shell to directly set base_dir for osx builds
Mike Blumenkrantz [Fri, 25 Oct 2019 17:33:41 +0000 (13:33 -0400)]
ci: use shell to directly set base_dir for osx builds

Summary: this crashes somehow and is impossible to debug remotely

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10529

4 years agocsharp: Using Array.Empty Eina.
Bruno da Silva Belo [Fri, 25 Oct 2019 16:49:24 +0000 (13:49 -0300)]
csharp: Using Array.Empty Eina.

Summary: ref T8421

Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8421

Differential Revision: https://phab.enlightenment.org/D10500

4 years agocsharp:Using Array.Empty genericmodel.
Bruno da Silva Belo [Fri, 25 Oct 2019 16:57:48 +0000 (13:57 -0300)]
csharp:Using Array.Empty genericmodel.

Summary: ref T8421

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8421

Differential Revision: https://phab.enlightenment.org/D10501

4 years agocsharp: Changing Count() to Length on eina_value.
Bruno da Silva Belo [Fri, 25 Oct 2019 16:08:37 +0000 (13:08 -0300)]
csharp: Changing Count() to Length on eina_value.

Summary: ref T8422

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8422

Differential Revision: https://phab.enlightenment.org/D10499

4 years agocsharp: Using Count eina_promises.
Bruno da Silva Belo [Fri, 25 Oct 2019 16:06:59 +0000 (13:06 -0300)]
csharp: Using Count eina_promises.

Summary: ref T8422

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8422

Differential Revision: https://phab.enlightenment.org/D10498

4 years agocsharp: Calling ConfigureAwait on tasks GM.
Bruno da Silva Belo [Fri, 25 Oct 2019 14:23:08 +0000 (11:23 -0300)]
csharp: Calling ConfigureAwait on tasks GM.

Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10497

4 years agocsharp: Calling ConfigureAwait on tasks Model.
Bruno da Silva Belo [Fri, 25 Oct 2019 14:22:35 +0000 (11:22 -0300)]
csharp: Calling ConfigureAwait on tasks Model.

Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10496

4 years agocsharp: Calling ConfigureAwait on task eopromises.
Bruno da Silva Belo [Fri, 25 Oct 2019 14:17:53 +0000 (11:17 -0300)]
csharp: Calling ConfigureAwait on task eopromises.

Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10495

4 years agomono: implement dispose method based on dispose pattern
Yeongjong Lee [Thu, 24 Oct 2019 20:46:13 +0000 (17:46 -0300)]
mono: implement dispose method based on dispose pattern

Summary:
Fix CA1063, CA1816
ref T8400, T8419

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: felipealmeida, brunobelo, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8419, T8400

Differential Revision: https://phab.enlightenment.org/D10460

4 years agotests/layout: add legacy layout test to verify behavior with legacy size hints
Mike Blumenkrantz [Fri, 25 Oct 2019 13:42:41 +0000 (09:42 -0400)]
tests/layout: add legacy layout test to verify behavior with legacy size hints

Summary:
this verifies that user-set legacy size hints will be applied accurately during
calc, and that the size of a layout can accurately decrease when its contents min
sizes decrease

ref 95b5731461c53df2691ef43db61f321de5b366d3

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10453

4 years agoefl_ui/text_scroller: fix null derefs
Mike Blumenkrantz [Fri, 25 Oct 2019 13:42:33 +0000 (09:42 -0400)]
efl_ui/text_scroller: fix null derefs

Summary: CIDs 1403890, 1396964, 1396945

Reviewers: cedric, vtorri

Reviewed By: cedric

Subscribers: vtorri, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10447

4 years agocsharp: Returning only method name iwrapper.
Bruno da Silva Belo [Thu, 24 Oct 2019 21:50:48 +0000 (18:50 -0300)]
csharp: Returning only method name iwrapper.

Summary:
GetUserMethods returning only strings,
not the whole method informations.

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10503

4 years agoefl_ui_relative_layout: change child, target parameter type to Efl.Gfx.Entity
Yeongjong Lee [Tue, 15 Oct 2019 06:21:16 +0000 (06:21 +0000)]
efl_ui_relative_layout: change child, target parameter type to Efl.Gfx.Entity

child, target should be graphical object.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10401

4 years agoelm/code: check save file attrs after opening
Mike Blumenkrantz [Thu, 17 Oct 2019 14:23:34 +0000 (10:23 -0400)]
elm/code: check save file attrs after opening

ensure that they haven't changed between time of check and time of open

CID 1396966

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10440

4 years agoefl_message: add pending queue for filtering message.
Hosang Kim [Thu, 24 Oct 2019 07:27:37 +0000 (07:27 +0000)]
efl_message: add pending queue for filtering message.

Sometimes message is appended when message queue is walking.
In this case, newly added messages are not filtered.
So I add message pending queue for filtering message.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10459

4 years agoeina_mono: re-throw exception to preserve stack details
Yeongjong Lee [Thu, 24 Oct 2019 21:21:39 +0000 (18:21 -0300)]
eina_mono: re-throw exception to preserve stack details

Summary:
fix CA2200
ref T8426

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8426

Differential Revision: https://phab.enlightenment.org/D10462

4 years agoeina_mono: Initialize UNHANDLED_EXCEPTION inline
Yeongjong Lee [Thu, 24 Oct 2019 21:24:07 +0000 (18:24 -0300)]
eina_mono: Initialize UNHANDLED_EXCEPTION inline

Summary:
fix CA2207
ref T8427

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8427

Differential Revision: https://phab.enlightenment.org/D10463

4 years agocsharp: Add since information to EoWrapper.cs
Lauro Moura [Thu, 24 Oct 2019 16:42:40 +0000 (18:42 +0200)]
csharp: Add since information to EoWrapper.cs

Reviewers: brunobelo, segfaultxavi, felipealmeida, woohyun

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10429

4 years agotests/ecore: ensure that we attempt to re-set PATH in ecore-file tests
Mike Blumenkrantz [Thu, 24 Oct 2019 16:23:14 +0000 (18:23 +0200)]
tests/ecore: ensure that we attempt to re-set PATH in ecore-file tests

Summary:
if this test failed before for any reason, PATH would be permanently changed
for the current shell and process, which is obviously not what we want
Depends on D10414

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10415

4 years agotests/ecore: replace all bespoke strcats with snprintf
Mike Blumenkrantz [Thu, 24 Oct 2019 16:23:11 +0000 (18:23 +0200)]
tests/ecore: replace all bespoke strcats with snprintf

Summary:
CID 1400812
Depends on D10413

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10414

4 years agotests/ecore: unset app args after app args unit test to prevent invalid reads
Mike Blumenkrantz [Thu, 24 Oct 2019 16:23:03 +0000 (18:23 +0200)]
tests/ecore: unset app args after app args unit test to prevent invalid reads

Summary:
various internal components in efl access the app args and read them which
will result in invalid memory access since these are stack-allocated strings
Depends on D10412

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10413

4 years agoecore/app: permit resetting app args to uninitialized (zeroed) state
Mike Blumenkrantz [Thu, 24 Oct 2019 16:14:25 +0000 (18:14 +0200)]
ecore/app: permit resetting app args to uninitialized (zeroed) state

Summary:
this is mainly useful for unit testing, but unsetting values should not be
treated as an error

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10412

4 years agotests/eina: use slstr_steal function in slstr_steal test
Mike Blumenkrantz [Thu, 24 Oct 2019 15:53:23 +0000 (17:53 +0200)]
tests/eina: use slstr_steal function in slstr_steal test

Summary: CID 1401043

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10404

4 years agotests/spec: free array in multi selectable tests
Mike Blumenkrantz [Thu, 24 Oct 2019 15:43:19 +0000 (17:43 +0200)]
tests/spec: free array in multi selectable tests

Summary: CIDs 1405810, 1405807, 1405806, 1405805, 1405803, 1405801, 1403902

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10403

4 years agomono: merge namespaces in manual bindings
Yeongjong Lee [Thu, 24 Oct 2019 15:18:44 +0000 (17:18 +0200)]
mono: merge namespaces in manual bindings

Summary:
It will enhance readability.
Before
```
namespace Efl {
namespace Eo {
```

After
```
namespace Efl.Eo {
```

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, Jaehyun_Cho, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10466

4 years agocxx: Add license to CXX bindings.
Felipe Magno de Almeida [Thu, 24 Oct 2019 13:36:42 +0000 (10:36 -0300)]
cxx: Add license to CXX bindings.

Summary:
Like C#, it will also be Apache 2.0

Depends on D9414

Reviewers: vitor.sousa, woohyun, jpeg, lauromoura

Reviewed By: lauromoura

Subscribers: jpeg, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9418

4 years agocsharp: Add licensing information.
Lauro Moura [Thu, 24 Oct 2019 13:01:50 +0000 (10:01 -0300)]
csharp: Add licensing information.

Summary:
C# bindings will be lincensed under Apache Sofware License 2.0.

This commit adds the license text to the licenses folder and a copyright
notice to the binding files.

Fixes T8039

Reviewers: woohyun, felipealmeida, vitor.sousa

Reviewed By: felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8039

Differential Revision: https://phab.enlightenment.org/D9414

4 years agoexamples/efl_thread: fix oob writes
Mike Blumenkrantz [Thu, 24 Oct 2019 12:50:27 +0000 (14:50 +0200)]
examples/efl_thread: fix oob writes

Summary: CIDs 1403896, 1403895, 1403892

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10395

4 years agoexamples/ecore: use correct type for getchar() return
Mike Blumenkrantz [Thu, 24 Oct 2019 12:35:28 +0000 (14:35 +0200)]
examples/ecore: use correct type for getchar() return

Summary:
correct prototype is int getchar(void);

CID 1400794

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10391

4 years agospaces--
Carsten Haitzler (Rasterman) [Thu, 24 Oct 2019 12:13:29 +0000 (13:13 +0100)]
spaces--

4 years agoeina: remove eina_config.h.in
Daniel Kolesa [Wed, 23 Oct 2019 13:51:34 +0000 (15:51 +0200)]
eina: remove eina_config.h.in

This is never actually used since meson generates eina_config.h
from scratch. Apart from the byteswap checks done in the previous
commit, all of the other things already seem to be done by meson,
so just remove it.

4 years agoeina: unbreak byteswap checks
Daniel Kolesa [Wed, 23 Oct 2019 13:44:22 +0000 (15:44 +0200)]
eina: unbreak byteswap checks

For one, eina_config.h.in is never used by anything since meson,
so doing any checks in it and expecting them to work is wrong.
Byteswaps are one place where this is the case, so move the
checks back in their appropriate place.

4 years agodocs: small fixes to Efl.Text
Xavi Artigas [Wed, 23 Oct 2019 08:15:30 +0000 (10:15 +0200)]
docs: small fixes to Efl.Text

4 years agoecore-evas-wayland: Minor formatting fixes
Christopher Michael [Tue, 22 Oct 2019 14:59:29 +0000 (10:59 -0400)]
ecore-evas-wayland: Minor formatting fixes

NB: No functional changes

4 years agoecore-wl2: Minor formatting fix
Christopher Michael [Tue, 22 Oct 2019 14:42:54 +0000 (10:42 -0400)]
ecore-wl2: Minor formatting fix

NB: No functional changes

4 years agoecore_evas_wayland: Fix array step size
Christopher Michael [Tue, 22 Oct 2019 14:12:51 +0000 (10:12 -0400)]
ecore_evas_wayland: Fix array step size

Fix bug where eina_array step size was being increased by 10 everytime
a handler was pushed to the array. There is no need to increase array
size by 10 each time we add 1 pointer to handler.

@fix

4 years agoecore-evas-wayland: Add handler to array
Christopher Michael [Tue, 22 Oct 2019 14:11:24 +0000 (10:11 -0400)]
ecore-evas-wayland: Add handler to array

Small patch to fix bug where last event handler was not being added to
the event_hdls array

@fix

4 years agoecore-evas-wayland: Minor formatting fix
Christopher Michael [Tue, 22 Oct 2019 14:06:23 +0000 (10:06 -0400)]
ecore-evas-wayland: Minor formatting fix

NB: No functional changes

4 years agoecore-evas-wayland: Minor formatting fix
Christopher Michael [Tue, 22 Oct 2019 14:04:01 +0000 (10:04 -0400)]
ecore-evas-wayland: Minor formatting fix

NB: No functional changes

4 years agoeina: fix network byte order swap funcs on big endian
Daniel Kolesa [Sun, 20 Oct 2019 16:49:04 +0000 (18:49 +0200)]
eina: fix network byte order swap funcs on big endian

4 years agobuild: resolve migration build error
Jongmin Lee [Mon, 21 Oct 2019 23:24:41 +0000 (08:24 +0900)]
build: resolve migration build error

Change-Id: I7ab5cb4a3e283546a25670ab35f03db25a1918b3

4 years agoevas_object_textblock: add support for variation sequences
Ali Alzyod [Sat, 19 Oct 2019 05:01:36 +0000 (14:01 +0900)]
evas_object_textblock: add support for variation sequences

Summary: update font processing to handle variation sequences unicodes to select proper glypg in respect to variation seqences

Test Plan:
```

EAPI_MAIN int
elm_main(int argc, char **argv)
{
   Evas_Object *win, *textblock;

   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   win = elm_win_util_standard_add("Main", "");
   elm_win_autodel_set(win, EINA_TRUE);
   textblock = evas_object_textblock_add(win);
   efl_canvas_text_style_set(textblock,NULL,"DEFAULT='font=DejaVuSans font_fallbacks=SamsungColorEmoji color=#000 font_size=20'");
   evas_object_textblock_text_markup_set(textblock, "8&#xfe0f;&#x20E3;&#x262a;&#xfe0f;AAA&#x262a;&#xfe0E;1234567&#xfe0f;&#x20E3;");

   evas_object_size_hint_weight_set(textblock, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(textblock, EVAS_HINT_FILL, EVAS_HINT_FILL);
   evas_object_show(textblock);
   evas_object_move(textblock, 0, 0);
   evas_object_resize(textblock, 320, 320);
   evas_object_resize(win, 320, 320);
   evas_object_show(win);
   elm_run();
   return 0;

}

ELM_MAIN()

```

Reviewers: woohyun, bowonryu, segfaultxavi, cedric, bu5hm4n

Reviewed By: woohyun, cedric

Subscribers: bu5hm4n, subodh6129, herdsman, segfaultxavi, zmike, cedric, #committers, #reviewers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9053

4 years agofix various trivial null derefs
Mike Blumenkrantz [Fri, 18 Oct 2019 17:30:10 +0000 (13:30 -0400)]
fix various trivial null derefs

Summary:
CIDs 1401081, 1401044, 1400983, 1400960, 1400927, 1400799, 1396946, 1396944,
     1383851, 1383847, 1382211, 1379921, 1379921

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10452

4 years agoefl/io: return EINVAL if null slice is passed for writing
Mike Blumenkrantz [Fri, 18 Oct 2019 17:30:03 +0000 (13:30 -0400)]
efl/io: return EINVAL if null slice is passed for writing

Summary: CIDs 1396996, 1396983, 1396953

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10451

4 years agotests/ecore_con: clarify pointer usage in ecore_con_url tests
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:57 +0000 (13:29 -0400)]
tests/ecore_con: clarify pointer usage in ecore_con_url tests

Summary:
this was pretty bizarre

CID 1401029

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10450