Samantha Houts [Fri, 27 Sep 2019 00:28:48 +0000 (17:28 -0700)]
Merge branch '4.3.0'
Samantha Houts [Fri, 27 Sep 2019 00:23:42 +0000 (17:23 -0700)]
Merge branch '4.2.0' into 4.3.0
Shane Neuville [Fri, 27 Sep 2019 00:16:10 +0000 (18:16 -0600)]
JavaSDK build path hack (#7707)
adrianknight89 [Fri, 27 Sep 2019 00:16:03 +0000 (19:16 -0500)]
[iOS] Fix MeasureFirstItem for CollectionView (#7622)
* fix MeasureFirstItem
* added test
* changed file name
* fix path
* added text
* remove 5455
* drop private
fixes #7621
ksemenenko [Thu, 26 Sep 2019 17:43:56 +0000 (20:43 +0300)]
[iOS] Fixes for null check for Shell classes (#7583)
* null check
* currentElement null check
Gerald Versluis [Thu, 26 Sep 2019 17:23:41 +0000 (10:23 -0700)]
[BUG/iOS] Fixed CollectionView Insets ItemSpacing (#7158)
* Fix 7035
* Update Xamarin.Forms.Controls.Issues.Shared.projitems
* Update ItemsViewLayout.cs
* Update test case to show span issue
* Update AppDelegate.cs
Remove test setting
* Update Xamarin.Forms.Controls.Issues.Shared.projitems
* Update Issue7035.xaml
adrianknight89 [Thu, 26 Sep 2019 10:43:43 +0000 (05:43 -0500)]
Update Android UI test instructions (#7579)
* update readme file for Android ui tests
* added extra pounds
* added UI word
* fix error
* removed word
Shane Neuville [Thu, 26 Sep 2019 09:29:32 +0000 (03:29 -0600)]
fix android foreground tinting (#7682) fixes #7577
Rui Marinho [Thu, 26 Sep 2019 09:13:46 +0000 (10:13 +0100)]
Merge branch '4.3.0'
Rui Marinho [Thu, 26 Sep 2019 09:12:54 +0000 (10:12 +0100)]
Merge branch '4.2.0' into 4.3.0
Shane Neuville [Wed, 25 Sep 2019 16:49:26 +0000 (10:49 -0600)]
fix android apk path for ui tests (#7657)
Shane Neuville [Wed, 25 Sep 2019 14:43:20 +0000 (08:43 -0600)]
only set elevation on Lollipop and up (#7662)
Kangho Hur [Wed, 25 Sep 2019 13:50:50 +0000 (22:50 +0900)]
[Tizen] Improves the initialization of VE.props (#7666)
Shane Neuville [Wed, 25 Sep 2019 00:35:33 +0000 (18:35 -0600)]
Try catch Update Bitmap and equate null to empty for FontFamily Check (#7611) fixes #7598 fixes #7597
kingces95 [Tue, 24 Sep 2019 23:52:08 +0000 (13:52 -1000)]
lazily load ResourceManager types (#7596)
adrianknight89 [Tue, 24 Sep 2019 21:39:57 +0000 (16:39 -0500)]
[iOS] Make button click easier to see when turning on CollectionView flag (#7617)
* make button click easier to see
* remove private
* changed event handler name
Stephane Delcroix [Tue, 24 Sep 2019 08:19:01 +0000 (10:19 +0200)]
Merge branch '4.3.0'
Stephane Delcroix [Tue, 24 Sep 2019 08:18:06 +0000 (10:18 +0200)]
Merge branch '4.2.0' into 4.3.0
shane [Tue, 24 Sep 2019 00:38:58 +0000 (18:38 -0600)]
Merge branch '4.3.0'
Shane Neuville [Tue, 24 Sep 2019 00:32:55 +0000 (18:32 -0600)]
set android app to not clear data on restart (#7640)
Gerald Versluis [Mon, 23 Sep 2019 23:04:24 +0000 (01:04 +0200)]
[Mac] Fix NRE on setting non-existing FontFamily (#7636) fixes #7582
* Update FontExtensions.cs
* Added issue to gallery
Rui Marinho [Mon, 23 Sep 2019 23:02:47 +0000 (00:02 +0100)]
[iOS,Android] Better way to get CurrentItem (#7587)
* [iOS] Fix finding center cell
* [UITests] Fix drag on vertical
* [UItests] Make uitest more reliable
* [iOS] Simplify set current item
* [Android] Use scrolled to get CurrentItem
* [UITests] Fix UItests on api19 android
* [Android] Fix merge
Shane Neuville [Mon, 23 Sep 2019 20:36:34 +0000 (14:36 -0600)]
Add retry logic for IsFocus test (#7619)
Javier Suárez Ruiz [Mon, 23 Sep 2019 06:17:44 +0000 (08:17 +0200)]
[CarouselView] Fix CarouselView initial position on Android (#7592)
* Fixed Android CarouselView initial position issue
Rui Marinho [Sat, 21 Sep 2019 16:11:14 +0000 (17:11 +0100)]
[UITests] Try again to run UItests (#7616)
Rui Marinho [Fri, 20 Sep 2019 23:28:30 +0000 (00:28 +0100)]
[UItests] Fix UITests on android
E.Z. Hart [Fri, 20 Sep 2019 22:03:55 +0000 (16:03 -0600)]
Finish ScrollTo implementations for CollectionView on UWP (#7509) partially implements #3172
* Finish ScrollTo implementations for CollectionView on UWP
* Fix NRE when attempting to scroll to index greater than source length
E.Z. Hart [Fri, 20 Sep 2019 17:37:15 +0000 (11:37 -0600)]
Make sure transition from empty CollectionView measures cell size; fixes #7472 (#7580)
fixes #7472
fixes #7548
adrianknight89 [Fri, 20 Sep 2019 16:57:05 +0000 (11:57 -0500)]
[Android] Fix ItemSpacing for last item in CollectionView (#7516)
* fix item spacing
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
Stephane Delcroix [Thu, 19 Sep 2019 13:58:29 +0000 (15:58 +0200)]
[X] do not fail on generic BP (#7588)
While looking for a potential TypeConverter attribute on the static getter of a
generic attached BP, resolve the generic return type.
- fixes #7559
Stephane Delcroix [Thu, 19 Sep 2019 10:33:32 +0000 (12:33 +0200)]
[C] Fix TemplateBinding for non-logicalchildren (#7506)
Spans, e.g., are no LogicalChildren of FormattedString, which is not a
LogicalChildren of Label. The newly introduced way of propagating the
TemplatedParent was top-down, using LogicalChildren, was not assigning
the correct TemplatedParent on Spans.
This reverts to a bottom-up lookup, hooking on ParentSet, like it used to
be.
As a side effect, the TemplateBindings are no longer updated on reparenting,
but this was the original behavior, and I can't think of a case where this
would be needed.
The regression to `{TemplateBinding}` was introduced by #4375.
- fixes #7494
Chris King [Wed, 18 Sep 2019 19:45:53 +0000 (09:45 -1000)]
Update dot file
Chris King [Wed, 18 Sep 2019 19:29:51 +0000 (09:29 -1000)]
Update dot file
Stephane Delcroix [Wed, 18 Sep 2019 14:42:51 +0000 (16:42 +0200)]
Merge branch '4.3.0'
Stephane Delcroix [Wed, 18 Sep 2019 14:41:18 +0000 (16:41 +0200)]
[X] avoid throwing in VisualDiagnostics (#7571)
this fixes a regression introduced in #7474
- fixes #7570
Rui Marinho [Tue, 17 Sep 2019 22:59:28 +0000 (23:59 +0100)]
Merge branch '4.3.0'
Pavel Yakovlev [Tue, 17 Sep 2019 22:50:33 +0000 (01:50 +0300)]
removed MatchParent value from Property Editor (#7551)
Pavel Yakovlev [Tue, 17 Sep 2019 22:35:37 +0000 (01:35 +0300)]
[C] added intellisense for Keyboard property (#7553) fixes azdo 835646
Rui Marinho [Tue, 17 Sep 2019 22:30:30 +0000 (23:30 +0100)]
Merge branch '4.2.0' into 4.3.0
Morten Nielsen [Tue, 17 Sep 2019 22:26:56 +0000 (15:26 -0700)]
Adds UWP support to Shell (#6015)
* Some basics to get started
* more renderers
* Fix titlebar color
* More shell stuff working
* Hacked some more UI in
* Fix null ref issue
* Move renderer registration outside common code (for now)
* Re-write of the renderers to better use a cleaner UWP approach
* Moved functionality around, bug fixesetc
* Added null check
* Added null-check on appearance and use default colors as fallback
* Handle change in flyout behavior to correctly turn the flyout on/off
* Handle the TabBarIsVisible property
* code formatting
* Ensure FlyoutHeader isn't show if the app starts up with a minimal pane
* Throw if used on versions lower than Windows 10 1809
* Added null-check for when ShellContent isn't set
* Support tabs in FlyoutItems with Display AsMultipleItems by using the generated FlyoutGroupings instead
* Improve pane behavior and styling
* Undo Android change used during testing
* Fix platform support check
* Use FileImageSourcePathConverter on NavigationViewItem instead of a custom control (so I deleted ShellNavigationViewItemRenderer which is no longer needed).
Ensure `FileImageSourcePathConverter` won't throw if it didn't get a FileImageSource.
Move the flyout data templates into a resource so they can be overridden and compiled.
* Delete renamed file
* Use a resource instead of parsing a string template
* Handle search box property changes
* Update page title on property change
* Update bottombar when shellitems change
* Guard against API usage not present
* Platform check comments
* Fix problem running in release mode (use Bindable to generate XamlMetadata
* Trigger rebind of menu items source when collection changes
* Added support for Toolbar
* Fix searchbox behavior (still lacks expand/collapse feature)
* Add overload for defining the navigation transition
* Use different navigation transitions based on navigatin direction
* Hides header with show / hide nav command
* collapses header area on hide nav
* Move to use WinUI
* Fix runtime issues after merge.
* - rebase fixes
* - rebase fixes
* - fix spaces/tabs
* - flags, hide apis, delete assembly info
* - set flag on UWP CG
* - expose renderer creations and make them all public
* - formatting fixes
* - address PR comments
* - fix header so it's full width and swappable
Shane Neuville [Tue, 17 Sep 2019 22:12:16 +0000 (16:12 -0600)]
Additional proguard classes (#7527) fixes #5742
Andrei [Tue, 17 Sep 2019 21:40:21 +0000 (00:40 +0300)]
[macOS] PushModalAsync a 2nd time causes a crash (#7250) fixes #6866
* fixes https://github.com/xamarin/Xamarin.Forms/issues/6866
* fixed index boundaries to include 0 index
Stuart Lang [Tue, 17 Sep 2019 20:37:14 +0000 (21:37 +0100)]
[UWP] Check for null Platform in OnDestroy fixes #7331 (#7363)
Javier Suárez Ruiz [Tue, 17 Sep 2019 20:33:55 +0000 (22:33 +0200)]
Implement CarouselView on UWP (#7503)
* Implemented CarouselView on UWP
* Implemented CurrentItem on Carousel UWP
* Fixed ArgumentOutOfRangeException with the Carousel position
* Removed code to update the CurrentItem on UWP (review it to improve)
Rui Marinho [Tue, 17 Sep 2019 20:31:01 +0000 (21:31 +0100)]
Merge branch '4.2.0' into 4.3.0
Shane Neuville [Tue, 17 Sep 2019 15:46:55 +0000 (09:46 -0600)]
Check to see if the BeginRefresh request is no longer needed (#7514) fixes #7313
* fix refresh to not fire twice
* - add automated ui test
adrianknight89 [Tue, 17 Sep 2019 12:42:36 +0000 (07:42 -0500)]
[Android] Refactor the code for setting reverse layout in ItemsViewRenderer (#7468)
* refactor
* fix
* remove the return keyword
Shane Neuville [Tue, 17 Sep 2019 09:32:57 +0000 (03:32 -0600)]
[Android/iOS] Update CollectionView when user changes out the header/footer (#7499)
* update cv when user changes out the header/footer
* - fix android to convert back from pixels on scroll
- fix iOS offset on scroll args to account for header size and content inset
* - fix for new api
* - fix redundant BP
Shane Neuville [Tue, 17 Sep 2019 08:56:36 +0000 (02:56 -0600)]
Add null check when using tablet on MDP (#7513) fixes #7496
E.Z. Hart [Tue, 17 Sep 2019 08:41:00 +0000 (02:41 -0600)]
Remove extra brace; fixes #7545 (#7546)
adrianknight89 [Tue, 17 Sep 2019 08:38:48 +0000 (03:38 -0500)]
[iOS] Remove class variable from CarouselViewLayout whose value is always true (#7484)
* remove unused variable
* comment change
Shane Neuville [Tue, 17 Sep 2019 01:26:30 +0000 (19:26 -0600)]
update unit test to nunit3 apis (#7543)
Rui Marinho [Tue, 17 Sep 2019 00:10:13 +0000 (01:10 +0100)]
Merge branch '4.2.0' into 4.3.0
Shane Neuville [Mon, 16 Sep 2019 22:10:15 +0000 (16:10 -0600)]
await tasks on ViewUnitTests and update MSBuild Locator (#7542)
Konrad Müller [Mon, 16 Sep 2019 21:06:49 +0000 (23:06 +0200)]
[macOS] Only use default font size for Time/DatePicker to avoid clipping issues (#7183)
* Only use default font size
* Always use default font size
* Remove duplicated code
* Remove extra spacing
Shane Neuville [Mon, 16 Sep 2019 15:48:52 +0000 (09:48 -0600)]
Tweak unit test so it's more reliable and fix binlog path (#7530)
* tweak unit test and fix bl path
* - change test to use ThrowsAsync
* - fix for nunit 2
E.Z. Hart [Mon, 16 Sep 2019 14:23:55 +0000 (08:23 -0600)]
Fix horizontal layout issues introduced in 7456; fixes #7519 fixes #7524 (#7522)
E.Z. Hart [Mon, 16 Sep 2019 13:02:58 +0000 (07:02 -0600)]
Implement EmptyView on UWP (#7438)
Javier Suárez Ruiz [Mon, 16 Sep 2019 12:13:07 +0000 (14:13 +0200)]
Added Carousel SnapBehavior Core sample (#7444)
Stephane Delcroix [Mon, 16 Sep 2019 06:59:38 +0000 (08:59 +0200)]
Merge branch '4.3.0'
ShaneN [Sun, 15 Sep 2019 00:52:56 +0000 (18:52 -0600)]
merge 4.2.0 into 4.3.0
Shane Neuville [Sun, 15 Sep 2019 00:40:55 +0000 (18:40 -0600)]
Check if Control is ready before interacting with Native control (#7523)
* Check if control is ready before setting Text
* - make 7.0 compatible
ShaneN [Fri, 13 Sep 2019 17:00:37 +0000 (11:00 -0600)]
Merge branch '4.3.0'
E.Z. Hart [Fri, 13 Sep 2019 09:55:27 +0000 (03:55 -0600)]
Remove extra properties from CarouselView API (#7456)
* Remove Header/Footer properties from CarouselView
* Limit CarouselView to LinearItemsLayout
* Rework inheritance for UWP
* Split files by class
* Fix up Tizen renderer
Samantha Houts [Thu, 12 Sep 2019 22:56:32 +0000 (15:56 -0700)]
Merge branch '4.3.0'
Samantha Houts [Thu, 12 Sep 2019 22:55:09 +0000 (15:55 -0700)]
Merge branch '4.2.0' into 4.3.0
Samantha Houts [Thu, 12 Sep 2019 22:52:45 +0000 (15:52 -0700)]
Merge branch '4.1.0' into 4.2.0
Jonathan Peppers [Thu, 12 Sep 2019 22:36:35 +0000 (17:36 -0500)]
[xamlc] new <XFXamlCValidateOnly> MSBuild property for Debug builds (#7407)
XamlC is currently enabled for most Xamarin.Forms projects in `Debug`
and `Release` configurations. It enables faster startup/runtime
performance, XAML-syntax checking at build time--both quiet useful!
However, there is a build-time cost to using XamlC: each assembly is
loaded via Mono.Cecil, IL generated, and saved back to disk as an
additional step after Rosyln has compiled the assembly.
The proposal would be to add a new experimental MSBuild property, that
can be enabled for `Debug` mode such as:
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<!-- ... -->
<XFXamlCValidateOnly>True</XFXamlCValidateOnly>
</PropertyGroup>
This would do the following:
* `OptimizeIL` is skipped.
* Assemblies are analyzed, but no changes written to disk.
* No symbols are loaded via Mono.Cecil, we don't need them if we
aren't writing back to disk!
This will improve build performance, and we don't lose the build-time
error checking for XAML.
Down the road, we could consider moving the MSBuild property to be the
default for `Debug` builds or change the Xamarin templates. I think it
would be wise to require developers to opt-in to try this out.
~~ Results ~~
I tested this change by building the ControlGallery after changing one
line of XAML:
msbuild Xamarin.Forms.ControlGallery.Android\Xamarin.Forms.ControlGallery.Android.csproj /clp:performancesummary /p:XFXamlCValidateOnly=True
Before:
1979 ms XamlCTask 1 calls
After:
923 ms XamlCTask 1 calls
I *only* tested `Debug` builds.
Right, so it's faster. But let's keep the entire developer loop in
mind, how much slower is startup?
Before:
09-05 14:37:32.274 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s890ms
09-05 14:38:30.178 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s848ms
09-05 14:38:40.300 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s848ms
After:
09-05 14:40:38.512 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s894ms
09-05 14:40:55.497 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s856ms
09-05 14:41:03.754 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s897ms
After three runs, it seems this app suffers 25-50ms slowdown to
startup, and gains 1 second of build time improvement. A good net-win!
Other apps that have significantly more XAML will have different
results. I suspect the build time improvement will be even better, but
the hit to startup could be worse. With this setting opt-in, we can
experiment and find out.
Mahmoud Ali [Thu, 12 Sep 2019 22:36:02 +0000 (19:36 -0300)]
Warn on Styles validation instead of throwing exception (#7495)
* Warn on Styles validation instead of throwing exception
* Correct tests
fixes #6907
Shane Neuville [Thu, 12 Sep 2019 21:27:04 +0000 (15:27 -0600)]
add check to see if ShellContent is Visible one (#7460)
Shane Neuville [Thu, 12 Sep 2019 20:06:39 +0000 (14:06 -0600)]
fix NRE on _itemsSource when using IEnumerable (#7480)
Samantha Houts [Thu, 12 Sep 2019 20:02:49 +0000 (13:02 -0700)]
[iOS] If ListView is disposed before callback happens, return early (#7428)
* Add test case
* Update Issue7371.cs
* Update Issue7371.cs
* [iOS] If ListView is disposed before callback happens, return early
fixes #7371
Stephane Delcroix [Thu, 12 Sep 2019 00:35:40 +0000 (02:35 +0200)]
visualDiagnostics (#7474)
Javier Suárez Ruiz [Wed, 11 Sep 2019 23:40:26 +0000 (01:40 +0200)]
Hide some CarouselView methods from IntelliSense (#7475)
* Hide SetCurrentItem and SetIsDragging CarouselView methods from Intellisense
* Added required using to use EditorBrowsable
E.Z. Hart [Wed, 11 Sep 2019 23:31:29 +0000 (17:31 -0600)]
Leave BindingContext intact when recycling TemplatedItemViewHolder (#7426) fixes #6889
Fixes #6889
Shane Neuville [Wed, 11 Sep 2019 17:29:17 +0000 (11:29 -0600)]
Fix direction of walking when calculating effective FlyoutBehavior (#7459)
* fix direction of walking
* Update Xamarin.Forms.Core/Shell/Shell.cs
Shane Neuville [Wed, 11 Sep 2019 16:28:21 +0000 (10:28 -0600)]
move await to Begin Invoke and check for disposed (#7192)
Joe Manke [Wed, 11 Sep 2019 08:41:06 +0000 (03:41 -0500)]
[Core] Move TextProperty, ITextElement, and IPlaceholderElement to InputView (#4477)
* Implement IPlaceholderElement and ITextElement on InputView
* Move Text property and TextChanged event to InputView
* Default binding mode of TwoWay on InputView.TextProperty
Shane Neuville [Wed, 11 Sep 2019 07:14:27 +0000 (01:14 -0600)]
Wrong type checked after casting to type being searched for (#7461)
* wrong type checked when searching for parent
* Update Xamarin.Forms.Platform.Android/ViewExtensions.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* - add api level check for ui tests
- fixes #7329
Shane Neuville [Wed, 11 Sep 2019 07:10:59 +0000 (01:10 -0600)]
Dispose of HttpResponseMessage after stream is used (#7431)
- fixes #7248
ShaneN [Tue, 10 Sep 2019 21:32:39 +0000 (15:32 -0600)]
Merge 4.2.0 into 4.3.0
Shane Neuville [Tue, 10 Sep 2019 21:25:17 +0000 (15:25 -0600)]
Update support libraries from 28.0.0.1 to 28.0.0.3 (#7389)
* update support to 28.0.0.3
* - bump sandbox support versions
* - update nuspecs
Shane Neuville [Tue, 10 Sep 2019 15:05:55 +0000 (09:05 -0600)]
[Tests]Update to Xamarin.UITest 3.0 and NUnit 3.0 (#6332) (#7031)
* [Tests]Update to Xamarin.UITest 3.0 and NUnit 3.0 (#6332)
* - increment test nugets
* - adapter folder
* - uitest version
* add wait for 34632
Seungkeun Lee [Tue, 10 Sep 2019 15:04:16 +0000 (00:04 +0900)]
[Tizen] Update InitializationOptions (#7441)
Seungkeun Lee [Tue, 10 Sep 2019 15:04:01 +0000 (00:04 +0900)]
[Tizen] Tizen renderer performance optimization (#320) (#7440)
* Apply lazy loading for MD5 checksum (#316)
* Add API to set assemblies for custom renderer (#317)
* [Performance] Add prelaunching API (#315)
* Add prelaunch
* Apply lazy loading for MD5 checksum
* Apply preload systeminfo
* Revert "Apply lazy loading for MD5 checksum"
This reverts commit
dfb9ff8c3bf6c55fb6ebcc583f974b7398d88f73.
* Refactoring preloading
* Revert "Add API to set assemblies for custom renderer (#317)" (#319)
This reverts commit
7d9f86a4456e7b9089411fc6e7eb6b905dd931d8.
* Fix naming
* Fix build error
Samantha Houts [Mon, 9 Sep 2019 21:41:33 +0000 (14:41 -0700)]
Update contributing guide; tweak pull request template (#7317)
* Update contributing guide; tweak pull request template
* Update .github/CONTRIBUTING.md
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
E.Z. Hart [Mon, 9 Sep 2019 15:46:07 +0000 (09:46 -0600)]
[iOS] More intelligent cell resizing (#7285)
* More intelligent cell resizing; fix infinite layout loop and crash;
Reuse template views instead of re-creating them every time;
Fixes #7128
* Fix attribute ambiguity
* Drop trailing 'and'
E.Z. Hart [Mon, 9 Sep 2019 11:00:04 +0000 (05:00 -0600)]
Implement Move, Replace, and Reset for UWP CollectionView collection changes (#7384)
Stephane Delcroix [Mon, 9 Sep 2019 07:51:56 +0000 (09:51 +0200)]
Merge branch '4.3.0'
Stephane Delcroix [Mon, 9 Sep 2019 07:50:17 +0000 (09:50 +0200)]
Merge branch '4.2.0' into 4.3.0
Rui Marinho [Sat, 7 Sep 2019 22:08:26 +0000 (23:08 +0100)]
Merge branch '4.3.0'
Rui Marinho [Sat, 7 Sep 2019 22:07:50 +0000 (23:07 +0100)]
[UItests] Fix CarouselView tests (#7379)
* Update testcloud agent
* [UITests] Fix uitests for CarouselView
* [UITests] Fix the rest of uitests for the position
* [UITests] Use the drag api to swipe the Carousel
* Update CarouselViewUITests.cs
* [Uitests] Enable CarouselViewVertical
* [UITests] Try a new fix for UITests
Shane Neuville [Sat, 7 Sep 2019 07:11:41 +0000 (01:11 -0600)]
[UWP] RefreshView (#7319)
* UWP Swipe Refresh implementation
* - target platform warnings for UWP
* - move dictionary registration to code
* - remove SkipMicrosoftUIXamlCheckTargetPlatformVersion
Shane Neuville [Sat, 7 Sep 2019 07:09:47 +0000 (01:09 -0600)]
Queue Page.Display actions until platform is ready (#7316)
* Queue Page.Display actions until platform is ready
* - fix click
* - set IsPlatformEnabled enabled for Display tests
ShaneN [Fri, 6 Sep 2019 16:18:51 +0000 (10:18 -0600)]
Merge branch '4.3.0'
Jonathan Peppers [Fri, 6 Sep 2019 14:07:34 +0000 (09:07 -0500)]
[build] cleanup MSBuild settings for faster builds (#7381)
Context: https://devblogs.microsoft.com/xamarin/optimize-xamarin-android-builds/
The goal here is to improve the developer loop on Android when working
on Xamarin.Forms using a few settings for `Debug` builds:
* Enable Fast Deployment
* `AndroidLinkMode=None`
* `DebugType=portable`
* `ProduceReferenceAssembly=True` in netstandard projects
After these changes changes:
Before:
Time Elapsed 00:00:37.15
After:
Time Elapsed 00:00:15.79
This was just running:
msbuild Xamarin.Forms.ControlGallery.Android\Xamarin.Forms.ControlGallery.Android.csproj
I was using VS 2019 16.2 on Windows, changing a XAML file.
So one thing to note is that `AndroidLinkMode=Full` was used the
UITests running on CI are using `Debug` builds. I used a `Condition`
to check the `$(CI)` variable, so UITests will be unaffected.
Other cleanup:
* Explicitly set both `AndroidUseSharedRuntime` and
`EmbedAssembliesIntoApk`
* `AndroidSupportedAbis` only needs to be specified for `Release`
builds. `Debug` builds will detect the attached device/emulator and
use the appropriate ABI.
* `JavaMaximumHeapSize` can be removed, it defaults to `1G`.
* Removed other weird/old/empty MSBuild properties.
Rely on `Directory.Build.props`:
* `DebugType` is already defined, so we can remove these.
* `ProduceReferenceAssembly` can be set if
`UsingMicrosoftNETSdk=True`, I could not check `TargetFramework` at
this stage, evaluation, since it was blank. This sets the value for
all netstandard/SDK-style projects.
~~ [ControlGallery] assembly-level [Preserve] ~~
Context: https://github.com/xamarin/Xamarin.Forms/blob/
d7a9c85774502b98460fc740068e264f332bfd82/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla25234.cs#L13
There was also some concern where needing `[Preserve]` attributes
would only be found when the CI is running. You don't want to wait 3+
hours to know if you made a small mistake.
This adds `[assembly:Preserve]` to the ControlGallery project, so this
should be less likely to occur in the future.
Rui Marinho [Thu, 5 Sep 2019 23:33:50 +0000 (00:33 +0100)]
[Build] Bump msbuild locator move to VS2019 (#7415)
* Bump msbuild locator
* Update test adapter
* Update build-windows.yml
* Update azure-pipelines.yml
* Update build-windows.yml
kingces95 [Thu, 5 Sep 2019 21:31:27 +0000 (11:31 -1000)]
anticipate .cctors (#7294)
Samantha Houts [Thu, 5 Sep 2019 17:28:55 +0000 (10:28 -0700)]
Merge branch '4.3.0'
Samantha Houts [Thu, 5 Sep 2019 17:27:20 +0000 (10:27 -0700)]
Merge branch '4.2.0' into 4.3.0