Greg Fischer [Wed, 26 Apr 2017 00:07:35 +0000 (18:07 -0600)]
Inline: Change "--inline-entry-points-all" to "-exhaustive"
Greg Fischer [Tue, 25 Apr 2017 23:47:18 +0000 (17:47 -0600)]
Inline: Fix inliner description in usage message to reflect exceptions.
GregF [Tue, 25 Apr 2017 19:57:20 +0000 (13:57 -0600)]
Inline: Do not inline functions with multiple returns (for now)
qining [Wed, 19 Apr 2017 22:10:59 +0000 (18:10 -0400)]
Add bit pattern interface for setting default value for spec constants
David Neto [Thu, 20 Apr 2017 19:54:10 +0000 (15:54 -0400)]
Update CHANGES with recent news
Andrey Tuganov [Tue, 11 Apr 2017 19:11:04 +0000 (15:11 -0400)]
Added --compact-ids to /tools/opt
The pass remaps ids to a compact set which starts with %1 and
has no gaps.
Andrey Tuganov [Tue, 11 Apr 2017 23:46:15 +0000 (19:46 -0400)]
Added option --preserve-numeric-ids to tools/spirv-as
Added options to tools::Assemble
Andrey Tuganov [Thu, 6 Apr 2017 20:55:26 +0000 (16:55 -0400)]
Added statistical analysis tool (tool/stats)
Currently analyzes percentages of the following:
- version (how many 1.0 or 1.1)
- generator
- extension
- capability
- opcode prevalence
David Neto [Thu, 6 Apr 2017 15:04:09 +0000 (11:04 -0400)]
Test source language HLSL
David Neto [Sun, 26 Mar 2017 01:12:22 +0000 (21:12 -0400)]
Support SPV_KHR_storage_buffer_storage_class
Includes interaction with SPV_KHR_variable_pointers
TODO: Update capabilitly dependency tests for new capabilities.
Ehsan Nasiri [Wed, 1 Feb 2017 20:37:39 +0000 (15:37 -0500)]
Validator support for Variable Pointer extension.
If the variable_pointer extension is used:
* OpLoad's pointer argument may be the result of any of the following:
* OpSelect
* OpPhi
* OpFunctionCall
* OpPtrAccessChain
* OpCopyObject
* OpLoad
* OpConstantNull
* Return value of a function may be a pointer.
* It is valid to use a pointer as the return value of a function.
* OpStore should allow a variable pointer argument.
David Neto [Mon, 20 Mar 2017 16:28:40 +0000 (12:28 -0400)]
Update cap tests for SPV_KHR_16bit_storage
David Neto [Wed, 8 Mar 2017 22:16:04 +0000 (17:16 -0500)]
Test asm,dis support for SPV_KHR_variable_pointers
David Neto [Sat, 1 Apr 2017 20:10:16 +0000 (16:10 -0400)]
Add FlattenDecoration transform
Add --flatten-decorations to spirv-opt
Flattens decoration groups. That is, replace OpDecorationGroup
and its uses in OpGroupDecorate and OpGroupMemberDecorate with
ordinary OpDecorate and OpMemberDecorate instructions.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/602
Lei Zhang [Wed, 5 Apr 2017 21:32:39 +0000 (17:32 -0400)]
Group targets into folders
This plays nicer with IDEs.
David Neto [Sun, 2 Apr 2017 06:36:35 +0000 (02:36 -0400)]
Update spirv-opt to use spvtools::Optimizer
Exercises our public APIs more, and avoid including most
internal headers. It also shortens the processing part
of the code, but does make adding passes look more complex.
Doing this exposed issue 611, a bug in spvtools::Optimizer.
David Neto [Sun, 2 Apr 2017 06:17:41 +0000 (02:17 -0400)]
Fix optimizer on when to write the binary
The spvtools::Optimizer::Run method should also write the output binary
if optimization succeeds without changes but the output binary vector
does not have exactly the same contents as the input binary.
We have to check both the base pointer of the storage and the size of
the vector
Added a test for this too.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/611
Lei Zhang [Mon, 3 Apr 2017 17:41:20 +0000 (13:41 -0400)]
Add /EHs for targets for MSVC
David Neto [Mon, 3 Apr 2017 18:59:18 +0000 (14:59 -0400)]
Fix spelling in SPV_AMD_gcn_shader support
David Neto [Sat, 1 Apr 2017 15:19:40 +0000 (11:19 -0400)]
Fix typo in method name Struct::AddMemberName
Also add a method comment for it.
David Neto [Fri, 31 Mar 2017 14:36:58 +0000 (10:36 -0400)]
Avoid inlining calls to external functions
External functions don't have bodies to inline anyway.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/605
David Neto [Fri, 31 Mar 2017 14:36:10 +0000 (10:36 -0400)]
opt::Function::cbegin and cend are const
David Neto [Wed, 29 Mar 2017 21:11:51 +0000 (17:11 -0400)]
Mention inliner in CHANGES
David Neto [Wed, 29 Mar 2017 21:11:16 +0000 (17:11 -0400)]
Add low priority test suggestions for inliner
Greg Fischer [Thu, 10 Nov 2016 17:11:50 +0000 (10:11 -0700)]
Add exhaustive function call inlining to spirv-opt
Inlining is done for all functions designated as entry points.
Add optional validation to test fixture method SinglePassRunAndCheck.
David Srbecky [Sun, 26 Mar 2017 19:08:41 +0000 (20:08 +0100)]
Add various accessors needed to read and edit SPIRV code.
David Neto [Tue, 21 Mar 2017 16:43:26 +0000 (12:43 -0400)]
Support SPV_AMD_gcn_shader
Supported in assembler, disassembler, and binary parser.
The validator does not check SPV_AMD_gcn_shader validation rules
beyond parsing the extension.
Adds generic support for generating instruction tables for vendor
extensions.
Adds generic support for extensions the validator should recognize
(but not check) but which aren't derived from the SPIR-V core
grammar file.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/594
David Neto [Thu, 16 Mar 2017 20:13:47 +0000 (16:13 -0400)]
Fix validator message for bad logical pointer
Affects OpLoad and OpStore validation.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/588
David Neto [Thu, 23 Mar 2017 19:46:08 +0000 (15:46 -0400)]
Update capability tests for SPV_KHR_16bit_storage rev 7
The SPIR-V core grammar file in a recent SPIRV-Headers
applied the fix from Rev 7 of SPV_KHR_16bit_storage:
FPRoundingMode enums are now enabled by the capabilities
introduced by that extension.
Update the SPIRV-Tools tests accordingly.
David Neto [Mon, 20 Mar 2017 15:23:35 +0000 (11:23 -0400)]
Do nothing if trying to make the current dir
David Neto [Thu, 16 Mar 2017 19:19:51 +0000 (15:19 -0400)]
spirv-val prints warnings
Warnings and info messages go to stdout.
Errors still go to stderr.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/568
David Neto [Thu, 16 Mar 2017 19:06:12 +0000 (15:06 -0400)]
Add SpirvTools::Validate that takes an options object
Add spvtools::ValidatorOptions RAII wrapper around
a spv_validator_options value.
Andrey Tuganov [Mon, 6 Mar 2017 22:21:25 +0000 (17:21 -0500)]
Validator dissallows unsupported Vulkan capability
If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands
which are not supported by Vulkan 1.0.
See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
Andrey Tuganov [Wed, 15 Mar 2017 21:28:24 +0000 (17:28 -0400)]
Autogenererating enum-string mappings from grammar
Autogenerating the following code:
- extension enum
- extension-to-string
- string-to-extension
- capability-to-string
Capability mapping table will not compile if incomplete.
TODO: Use "spirv-latest-version.h" instead of 1.1.
Added function to generate capability tables for tests.
Andrey Tuganov [Fri, 10 Mar 2017 20:58:15 +0000 (15:58 -0500)]
Validator checks if operands require extension
If required extension is not found, returning new error
SPV_ERROR_MISSING_EXTENSION.
Andrey Tuganov [Thu, 9 Mar 2017 23:24:35 +0000 (18:24 -0500)]
Refactored enum_set
- removed forgotten file enum_set.cpp
- added IsEmpty and HasAnyOf
- hidden unsafe functions Add(uint32_t), Contains(uint32_t)
- added new tests
Andrey Tuganov [Wed, 8 Mar 2017 18:51:20 +0000 (13:51 -0500)]
Fix extension grammar parsing
Extensions were not parsed correctly due to a typo in the Python script.
Andrey Tuganov [Wed, 8 Mar 2017 18:59:01 +0000 (13:59 -0500)]
Validator parses and registers OpExtension
Known extensions are saved in validation state. Unknown extension
produce a dignostic message, but do not fail the validation.
Moved extension definitions to their own file.
David Neto [Fri, 27 Jan 2017 01:12:15 +0000 (20:12 -0500)]
Test SPV_KHR_multiview in assembler, disassembler
David Neto [Fri, 27 Jan 2017 01:05:01 +0000 (20:05 -0500)]
Test SPV_KHR_device_group in assembler, disassembler
David Neto [Fri, 27 Jan 2017 01:02:24 +0000 (20:02 -0500)]
Test SPV_KHR_16bit_storage in assembler, disassembler
David Neto [Thu, 26 Jan 2017 23:26:20 +0000 (18:26 -0500)]
Test SPV_KHR_subgroup_vote support in assembler, disassembler
Andrey Tuganov [Wed, 8 Mar 2017 17:06:31 +0000 (12:06 -0500)]
Fix nullptr dereferencing in val_fixtures.cpp
David Neto [Tue, 7 Mar 2017 14:49:43 +0000 (09:49 -0500)]
Change Ids in tests to avoid confusion
The assembler assigns ID numbers sequentially, so it's confusing
to have a %1 in the source assembly when it isn't the first mentioned
ID. Rewrite the ID names to avoid this situation in a few cases.
Aliya Pazylbekova [Sat, 25 Feb 2017 01:43:28 +0000 (20:43 -0500)]
Validate that SpecId decoration target is a OpSpecConstant instruction
on a scalar
Fixes: https://github.com/KhronosGroup/SPIRV-Tools/issues/275
Andrey Tuganov [Thu, 2 Mar 2017 22:24:29 +0000 (17:24 -0500)]
Validator: unique type check allows runtime arrays
OpTypeRuntimeArray is an aggregate and therefore can have duplicate
declarations.
David Neto [Wed, 1 Mar 2017 20:37:20 +0000 (15:37 -0500)]
Use OpenCL extinst definitions from SPIRV-Headers
Remove the local copy of that file.
Ehsan Nasiri [Fri, 27 Jan 2017 16:33:33 +0000 (11:33 -0500)]
Fixes issue #489.
From the SPIR-V Spec 2.16.1:
A function declaration (an OpFunction with no basic blocks), must have
a Linkage Attributes Decoration with the Import Linkage Type.
A function definition (an OpFunction with basic blocks) cannot be
decorated with the Import Linkage Type.
Lei Zhang [Wed, 1 Mar 2017 20:51:44 +0000 (15:51 -0500)]
Allow using FPRoundingMode when see VK_KHR_16bit_storage
According to the extension, FPRoundingMode should be allowed to
use without requiring Kernel capability when VK_KHR_16bit_storage
is enabled.
Andrey Tuganov [Wed, 1 Mar 2017 17:49:17 +0000 (12:49 -0500)]
Validator: downgraded dupl type decl to warning
Validator check for uniqueness of type declarations
(commit
0e9c24fdd112e7742b9b5dcff35aee32e71a66fd)
was causing failures in vulkancts tests.
Downgrading from error to warning.
Jean-Francois Roy [Tue, 28 Feb 2017 19:34:18 +0000 (11:34 -0800)]
Add a default virtual dtor to Pass and check for missing virtual dtors
Andrey Tuganov [Thu, 23 Feb 2017 21:07:52 +0000 (16:07 -0500)]
Issue 559: check type declaration uniqueness
Adds PassTypeUnique to the validator.
Disallows repeated declarations of all types except for aggregates.
Andrey Tuganov [Tue, 28 Feb 2017 16:53:47 +0000 (11:53 -0500)]
Refactored validation_state, added new types
- validation_state.cpp uses functions from opcode.h instead of in-place
switches which need to be updated.
- added new spirv 1.1 type declaration opcodes to a 'is op type
declaration' switch in opcode.cpp.
Ehsan Nasiri [Wed, 15 Feb 2017 18:29:33 +0000 (13:29 -0500)]
Add command line options struct for the validator
The limit for the number of struct members is parameterized using
command line options.
Add --max-struct-depth command line option.
Add --max-switch-branches command line option.
Add --max-function-args command line option.
Add --max-control-flow-nesting-depth option.
Add --max-access-chain-indexes option.
David Neto [Tue, 28 Feb 2017 16:53:05 +0000 (11:53 -0500)]
Update CHANGES for SPV_KHR_16bit_storage validator
David Neto [Wed, 22 Feb 2017 23:10:05 +0000 (18:10 -0500)]
Validation of type decls for SPV_KHR_16bit_storage
Allow declaration of 16bit int or 16bit float in
the presence of capabilities from SPV_KHR_16bit_storage
David Neto [Wed, 22 Feb 2017 22:53:08 +0000 (17:53 -0500)]
Add a Feature struct to validation state.
For now, it is used only for checks of 16bit int and float types.
Adam Van Ymeren [Wed, 15 Feb 2017 18:31:07 +0000 (13:31 -0500)]
Fixes issue #548
Add validation checks for the reserved OpImageSparseSampleProj* opcodes.
David Neto [Thu, 9 Feb 2017 19:23:52 +0000 (14:23 -0500)]
Check strict domination of merge block
If a merge block is reachable, then it must be *strictly* dominated
by its header. Until now we've allowed the header and the merge
block to be the same.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/551
Also: Use dominates and postdominates methods on BasicBlock to
improve readability.
Ehsan Nasiri [Thu, 9 Feb 2017 21:23:40 +0000 (16:23 -0500)]
The Signedness in OpTypeInt must always be 0.
When Kernel capability is used, The Signedness in OpTypeInt must always
be 0. Fixes issue #492.
Kenneth Benzie (Benie) [Wed, 1 Feb 2017 21:35:59 +0000 (21:35 +0000)]
Add vim-spirv plugin description to the README
Fixes #359
David Neto [Fri, 27 Jan 2017 20:30:09 +0000 (15:30 -0500)]
Encourage use of the validator
Ehsan Nasiri [Mon, 23 Jan 2017 23:31:14 +0000 (18:31 -0500)]
Making the unit tests more robust.
It is best to check the error messages of unit tests that fail
validation. This will ensure that a validation failure is due to what we
expect and not due to some secondary reason.
Updating SPIR-V Validator unit tests with error message checks.
Ehsan Nasiri [Tue, 17 Jan 2017 20:10:43 +0000 (15:10 -0500)]
Fixes issue #497.
The Linkage Attributes Decoration cannot be applied to functions
targeted by an OpEntryPoint instruction.
Ehsan Nasiri [Mon, 16 Jan 2017 17:54:15 +0000 (12:54 -0500)]
Check BuiltIn Decoration rules.
When applied to a structure-type member, all members of that structure
type must also be decorated with BuiltIn. (No allowed mixing of built-in
variables and non-built-in variables within a single structure.)
When applied to a structure-type member, that structure type cannot be
contained as a member of another structure type.
There is at most one object per Storage Class that can contain a
structure type containing members decorated with BuiltIn, consumed per
entry-point.
Ehsan Nasiri [Thu, 19 Jan 2017 16:03:04 +0000 (11:03 -0500)]
Fixes issue #532.
It is acceptable for OpAccessChain, OpInBoundsAccessChain,
OpPtrAccessChain, OpInBoundsPtrAccessChain, OpCompositeInsert, and
OpCompositeExtract to not take any indexes as arguments. In such cases,
no indexing will be done on the Base pointer/composite.
Ehsan Nasiri [Tue, 17 Jan 2017 21:28:59 +0000 (16:28 -0500)]
Fixes issue #493.
Check function call operands and return type agree with the called
function type.
The validation code exists. I have fixed the unit tests.
Ehsan Nasiri [Fri, 13 Jan 2017 16:46:21 +0000 (11:46 -0500)]
Validation for decoration rules. Fixes issue #499.
Added a new file where all the decoration validation can be performed.
In this change the SPIRV Spec Section 2.16.1 is implemented:
"It is illegal to initialize an imported variable. This means
that a module-scope OpVariable with initialization value cannot be
marked with the Import Linkage Type."
Also added unit tests.
David Neto [Tue, 17 Jan 2017 20:41:23 +0000 (15:41 -0500)]
Say why we allow override of build timestamp
It's for reproducible builds.
Also, fix Python formatting.
Bernhard M. Wiedemann [Tue, 17 Jan 2017 18:32:28 +0000 (18:32 +0000)]
make build reproducible
see https://reproducible-builds.org/ for why this is good
Ehsan Nasiri [Wed, 11 Jan 2017 15:51:23 +0000 (10:51 -0500)]
Adding decoration class and tests.
* Added the decoration class as well as the code that registers the
decorations for each <id> and also decorations for struct members.
* Added unit tests for decorations in ValidationState as well as
decoration id tests.
Ehsan Nasiri [Mon, 9 Jan 2017 16:10:52 +0000 (11:10 -0500)]
Validation of OpEntryPoint usage.
According to the SPIRV Spec (2.16.1):
* There is at least one OpEntryPoint instruction, unless the Linkage
capability is being used.
* No function can be targeted by both an OpEntryPoint instruction and an
OpFunctionCall instruction.
Also updated unit tests to includ OpEntryPoint.
Ehsan Nasiri [Wed, 11 Jan 2017 20:03:53 +0000 (15:03 -0500)]
Introducing a new flow for running the Validator.
We are adding a new API which can be called to run the SPIR-V validator,
and retrieve the ValidationState_t object. This is very useful for
unit testing.
I have also added basic unit tests that demonstrate usage of this flow
and ease of use to verify correctness.
Lei Zhang [Thu, 12 Jan 2017 19:15:36 +0000 (14:15 -0500)]
Update Travis CI configuration.
* Stop updating brew.
* Shadow clone of dependencies.
* Fix `nproc` on macOS.
David Neto [Wed, 11 Jan 2017 21:12:50 +0000 (16:12 -0500)]
Provide friendly names for true and false
Ehsan Nasiri [Wed, 4 Jan 2017 20:56:17 +0000 (15:56 -0500)]
Validation for Composite Extract and Insert.
The validity of each command is checked based on the descripton in
SPIR-V Spec Section 3.32.12 (Composite Instructions).
Also checked that the number of indexes passed to these commands does
not exceed the limit described in 2.17 (Universal Limits).
Also added unit tests for each one.
Ehsan Nasiri [Thu, 5 Jan 2017 17:53:02 +0000 (12:53 -0500)]
Fixes bug #517.
entry_block_to_construct_ maps an entry block to its construct. The key
in this map (the entry block) is not unique, and therefore the entry for
the continue construct gets overwritten when the selection construct is
discovered.
Since a given block may be the entry block of different types of
constructs, the (basic_block, construct_type) pair should be able to
uniquely identify the construct.
Adds test:
- In this test, a basic block is the entry block of a continue construct
as well as the entry block of a selection construct.
It can be shown that this unit test would crash without the fix in this
PR and passes with the fix in this PR.
David Neto [Wed, 4 Jan 2017 16:04:47 +0000 (11:04 -0500)]
Allow trailing whitespace on version lines in CHANGES
David Neto [Thu, 5 Jan 2017 21:00:58 +0000 (16:00 -0500)]
Use the default Xcode image on OSX
As of November 2016, the default OSX image is Xcode 7.3.1, which works.
Ehsan Nasiri [Thu, 22 Dec 2016 19:31:21 +0000 (14:31 -0500)]
Adding validation code for PtrAccessChain.
Validation for OpPtrAccessChain is similar to OpAccessChain with the
following difference: OpPtrAccessChain takes an extra argument (word 4)
which is the Element <id> argument.
Validation for OpInBoundsPtrAccessChain is also similar to OpPtrAccessChain.
Also added tests for all access chain instructions:
Modified the existing parameterized tests to accommodate OpPtrAccessChain and
OpInBoundsPtrAccessChain.
Also fixed a typo in previous commits.
Ehsan Nasiri [Tue, 3 Jan 2017 19:53:50 +0000 (14:53 -0500)]
Refactoring unit tests using TEST_P.
Using parameterized unit tests to avoid duplicate code that runs the
tests of OpAccessChain and OpInBoundsAccessChain.
This is also a steppingstone to adding tests for OpPtrAccessChain and
OpInBoundsPtrAccessChain.
Ehsan Nasiri [Wed, 21 Dec 2016 19:39:01 +0000 (14:39 -0500)]
Validation code for control flow nesting depth.
According to Section 2.17 (Universal Limits) of the SPIR-V Spec, the
control flow nesting depth may not be larger than 1023.
This is checked only when we are required to have structured
control flow. Otherwise it's not clear how to compute control
flow nesting depth.
David Neto [Mon, 19 Dec 2016 18:26:42 +0000 (13:26 -0500)]
Support building under CYGWIN
- Parse CHANGES file with Universal Python line endings in case
the source tree was checked out with Windows line endings.
- Use our own clone of strnlen_s which might not be available
everywhere.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/508
David Neto [Wed, 21 Dec 2016 15:31:29 +0000 (10:31 -0500)]
Update Travis notification emails
Remove deki, add ehsann
David Neto [Fri, 16 Dec 2016 20:32:56 +0000 (15:32 -0500)]
Generate spvasm.vim
Generate a vim syntax file for SPIR-V assembly.
Copy the resulting spvasm.vim into your $HOME/.vim/syntax directory
to get syntax highlighting in Vim.
Also, suggest that the grammar file include information
about what opcodes can be used in OpSpecConstantOp.
David Neto [Tue, 13 Dec 2016 16:49:50 +0000 (11:49 -0500)]
Start v2016.7-dev
David Neto [Tue, 13 Dec 2016 16:49:09 +0000 (11:49 -0500)]
Finalize v2016.6
David Neto [Fri, 9 Dec 2016 19:01:43 +0000 (14:01 -0500)]
Get vendor tool info from the SPIR-V registry file
Update old tests to use officially registered vendor names;
this affected "Codeplay".
David Neto [Thu, 8 Dec 2016 23:21:17 +0000 (18:21 -0500)]
Document the use of the GitHub Project feature
Ehsan Nasiri [Tue, 6 Dec 2016 16:59:49 +0000 (11:59 -0500)]
Adding validation for OpInBoundsAccessChain.
The validation for this instruction is similar to OpAccessChain.
Include a test for testing a struct with (valid) depth of 255.
Ehsan Nasiri [Sun, 4 Dec 2016 15:48:26 +0000 (10:48 -0500)]
Validation for struct nesting depth.
According to sectin 2.17 in SPIR-V Spec, the structure nesting depth may
not be larger than 255. This is interpreted as structures nested in
structures. The code does not look into arrays or follow pointers to see
if it reaches a structure downstream.
Use memoization to avoid exponential runtime.
David Neto [Wed, 7 Dec 2016 15:33:27 +0000 (10:33 -0500)]
An OpVariable initializer can be a module-scope variable
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/482
Ehsan Nasiri [Mon, 5 Dec 2016 20:11:51 +0000 (15:11 -0500)]
Fixing bug in OpAccessChain validation code.
The validation code for OpAccessChain was missing OpTypeRuntimeArray as
a possible type that can be indexed into.
This was caught by running the validator on VKCTS.
Also adding unit tests for it.
Ehsan Nasiri [Mon, 5 Dec 2016 19:00:18 +0000 (14:00 -0500)]
Add a test that exercises wrong usage of result id
Result <id> resulting from an instruction within a function may not be
used outside that function.
Ehsan Nasiri [Wed, 30 Nov 2016 18:29:12 +0000 (13:29 -0500)]
Adding validation code for OpAccessChain.
* Result Type must be an OpTypePointer. Its Type operand must be the
type reached by walking the Base’s type hierarchy down to the last
provided index in Indexes, and its Storage Class operand must be the
same as the Storage Class of Base.
* Base must be a pointer, pointing to the base of a composite object.
* Indexes walk the type hierarchy to the desired depth, potentially down
to scalar granularity. The first index in Indexes will select the
top-level member/element/component/element of the base composite. All
composite constituents use zero-based numbering, as described by their
OpType... instruction. The second index will apply similarly to that
result, and so on. Once any non-composite type is reached, there must
be no remaining (unused) indexes. Each of the Indexes must:
- be a scalar integer type,
- be an OpConstant when indexing into a structure.
* Check for the case where no indexes are passed to OpAccessChain.
Minor improvements based on code review.
Ehsan Nasiri [Thu, 1 Dec 2016 21:18:15 +0000 (16:18 -0500)]
No need to install cmake for new osx images.
It seems that the osx image has been updated and already includes ctest.
As a result, all jobs fail with this error:
Error: cmake-3.6.2 already installed
Ehsan Nasiri [Tue, 29 Nov 2016 20:50:34 +0000 (15:50 -0500)]
Validate the number of global and local variables.
According to the Universal Limits section of the SPIR-V Spec (2.17), the
number of global variables may not exceed 65,535 and the number of local
variables may not exceed 524,287.
Also added unit tests for each one.
Ehsan Nasiri [Mon, 28 Nov 2016 18:04:32 +0000 (13:04 -0500)]
Validate the number of arguments in OpTypeFunction
According to the SPIR-V spec (section 2.17: Universal Limits), the
OpTypeFunction instruction may not take more than 255 arguments for the
function. Also added unit tests for it.
David Neto [Wed, 30 Nov 2016 20:48:39 +0000 (15:48 -0500)]
Say how the validator checks universal limits
Indicate it's future work to allow parameterization of those
limits.
Ehsan Nasiri [Fri, 25 Nov 2016 14:26:26 +0000 (09:26 -0500)]
Adding validation code for OpSwitch limits
The number of (literal, label) pairs passed to OpSwitch may not exceed
16,383. Added code to validate this and added unit tests for it.
Also fixed a typo in another validor error message.