joshualitt [Fri, 8 Aug 2014 16:41:42 +0000 (09:41 -0700)]
Pretty print of shaders
BUG=skia:
R=bsalomon@chromium.org, senorblanco@chromium.org, bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
437593004
krajcevski [Fri, 8 Aug 2014 15:41:21 +0000 (08:41 -0700)]
Implement BlitRect for SkTCompressedAlphaBlitter
R=robertphillips@google.com, reed@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
451823002
Robert Phillips [Fri, 8 Aug 2014 15:40:08 +0000 (11:40 -0400)]
Add mandill_128.r11.ktx to resources
Review URL: https://codereview.chromium.org/
457693002
krajcevski [Fri, 8 Aug 2014 15:12:29 +0000 (08:12 -0700)]
Fix bug in blitAntiH
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
449223002
bsalomon [Fri, 8 Aug 2014 15:08:50 +0000 (08:08 -0700)]
Add an opaqueness hint to GrDrawState.
Check it when deciding whether to combine draw states.
R=egdaniel@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
446953002
bsalomon [Fri, 8 Aug 2014 14:43:29 +0000 (07:43 -0700)]
Make the rotated rects bench allow more alpha/color variations and an arbitrary xfermode::mode.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
448253002
stephana [Fri, 8 Aug 2014 14:21:00 +0000 (07:21 -0700)]
Rebaseline-server: sorting of columns in asc/desc order in frontend.
NOTRY=true
BUG=skia:1907
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/
449843002
senorblanco [Fri, 8 Aug 2014 14:14:35 +0000 (07:14 -0700)]
Remove external SkImageFilter cache, and rename UniqueIDCache -> Cache.
There Can Only Be One.... Cache for SkImageFilter.
R=bsalomon@google.com
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
452923002
rmistry [Fri, 8 Aug 2014 12:24:06 +0000 (05:24 -0700)]
Whitespace change to test the CQ
BUG=skia:
(SkipBuildbotRuns)
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
454873002
mtklein [Thu, 7 Aug 2014 22:20:02 +0000 (15:20 -0700)]
Fix iOS build by centralizing --writePath.
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
452633002
epoger [Thu, 7 Aug 2014 21:55:34 +0000 (14:55 -0700)]
don't list out all sourceSkpFile names in the rebaseline_server UI
(the list is long and crowds out the results themselves; better to use
a text filter to select the sourceSkpFiles of interest)
R=stephana@google.com
TBR=stephana
NOTREECHECKS=true
NOTRY=true
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
451853002
epoger [Thu, 7 Aug 2014 21:39:05 +0000 (14:39 -0700)]
make rebaseline_server properly handle unescaped URLs
R=rmistry@google.com
TBR=rmistry
NOTREECHECKS=true
NOTRY=true
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
445753005
bsalomon [Thu, 7 Aug 2014 21:28:50 +0000 (14:28 -0700)]
Add option to dump images from nanobench.
Add option to set the repeat count to any number, replacs the --runOnce flag.
R=mtklein@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
450743002
mtklein [Thu, 7 Aug 2014 21:27:03 +0000 (14:27 -0700)]
DM: conserve memory when using --skps
- limit to maximum 1000x1000 viewport like in bench_pictures and nanobench
- use lazy bitmap decoding when reading the pictures from disk
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
448263002
joshualitt [Thu, 7 Aug 2014 20:48:49 +0000 (13:48 -0700)]
Cleanup of context initialization
Cleanup context initialization on linux
BUG=skia:
R=bsalomon@chromium.org, bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
422323003
bungeman [Thu, 7 Aug 2014 20:27:17 +0000 (13:27 -0700)]
Revert of Process Statistics header, add max RSS to render_pdfs (https://codereview.chromium.org/
448993003/)
Reason for revert:
Reverting due to breaking iOS bots.
Original issue's description:
> Process Statistics header, add max RSS to render_pdfs
>
> Committed: https://skia.googlesource.com/skia/+/
6274baae7fe82ce6481da367687aa6168356e1e1
R=mtklein@google.com, halcanary@google.com
TBR=halcanary@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
448243003
halcanary [Thu, 7 Aug 2014 20:13:54 +0000 (13:13 -0700)]
Process Statistics header, add max RSS to render_pdfs
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
448993003
borenet [Thu, 7 Aug 2014 20:02:42 +0000 (13:02 -0700)]
Empty the Recipes bot's GM expectations
BUG=skia:761
NOTRY=true
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
455433002
krajcevski [Thu, 7 Aug 2014 19:58:38 +0000 (12:58 -0700)]
Add astcbitmap to gm slides.
Add additional ASTC formats.
Add astc image decoder files.
R=reed@google.com, robertphillips@google.com, halcanary@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
444093002
mtklein [Thu, 7 Aug 2014 19:46:29 +0000 (12:46 -0700)]
Default --skps to ./skps
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
452553002
reed [Thu, 7 Aug 2014 19:19:50 +0000 (12:19 -0700)]
change drawPicture in SkRecord to just ref the picture
also fix some int/unsigned/size_t warnings
BUG=skia:
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
449933002
epoger [Thu, 7 Aug 2014 19:13:12 +0000 (12:13 -0700)]
rebaseline_server: allow live queries to examine JSONKEY_EXPECTEDRESULTS or JSONKEY_ACTUALRESULTS
See https://goto.google.com/CorrectnessTestingBigIssues for full context
BUG=skia:1942
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
453433004
reed [Thu, 7 Aug 2014 18:48:10 +0000 (11:48 -0700)]
add isRect() check to AAClip, to detect if a soft-clip is really just an irect
taken from (https://codereview.chromium.org/
445233006/)
fix: don't assume that the first yoffset is 0, since we may have performed a translate and not
re-alloced our data.
This reverts commit
0aeea6d344f12e35e29a79f4bbc48af88f913204.
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/
443353004
krajcevski [Thu, 7 Aug 2014 18:33:59 +0000 (11:33 -0700)]
Revert of - Add astcbitmap to gm slides (https://codereview.chromium.org/
444093002/)
Reason for revert:
Breaking DM
Original issue's description:
> - Add astcbitmap to gm slides
> - Add additional ASTC formats
> - Add astc image decoder files
>
> Committed: https://skia.googlesource.com/skia/+/
2fc05823fed4b9649338f3029cd1ba05ef49a02f
R=reed@google.com, robertphillips@google.com, halcanary@google.com
TBR=halcanary@google.com, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
447343002
djsollen [Thu, 7 Aug 2014 18:30:30 +0000 (11:30 -0700)]
Disable suspect NEON function for 64-bit Android
R=halcanary@google.com, mtklein@google.com, kevin.petit@arm.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
451633006
borenet [Thu, 7 Aug 2014 18:28:20 +0000 (11:28 -0700)]
Duplicate NoGPU expectations for new recipes bot
BUG=skia:761
R=epoger@google.com
TBR=epoger
NOTRY=true
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
447323003
reed [Thu, 7 Aug 2014 18:19:11 +0000 (11:19 -0700)]
Revert of add isRect() check to AAClip, to detect if a soft-clip is really just an irect (https://codereview.chromium.org/
445233006/)
Reason for revert:
new code asserts on some pictures
Original issue's description:
> add isRect() check to AAClip, to detect if a soft-clip is really just an irect
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
592cb8d552556b1e922887d506d00b64bc5d0547
R=bsalomon@google.com, humper@google.com
TBR=bsalomon@google.com, humper@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/
452533002
krajcevski [Thu, 7 Aug 2014 18:18:09 +0000 (11:18 -0700)]
- Add astcbitmap to gm slides
- Add additional ASTC formats
- Add astc image decoder files
R=reed@google.com, robertphillips@google.com, halcanary@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
444093002
halcanary [Thu, 7 Aug 2014 18:13:45 +0000 (11:13 -0700)]
Assert allocation so we can catch it sooner.
R=bungeman@google.com, mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
445363007
krajcevski [Thu, 7 Aug 2014 18:10:22 +0000 (11:10 -0700)]
Pass a struct of functions instead of a function to the compressed blitter
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
443303006
krajcevski [Thu, 7 Aug 2014 17:58:43 +0000 (10:58 -0700)]
Add support for compressed alpha ktx files
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
447283002
tomhudson [Thu, 7 Aug 2014 17:20:51 +0000 (10:20 -0700)]
Don't fail unit test if resources not found on device.
Not 100% sure about the right thing to do here; looks like some other
tests warn but don't officially fail.
R=djsollen@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
451703004
reed [Thu, 7 Aug 2014 16:20:12 +0000 (09:20 -0700)]
add isRect() check to AAClip, to detect if a soft-clip is really just an irect
BUG=skia:
R=bsalomon@google.com, humper@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
445233006
fmalita [Thu, 7 Aug 2014 15:39:24 +0000 (08:39 -0700)]
Clamp SkPictureShader's tile size.
Blink used to clamp the max size for its pattern bitmaps (several SVG
pattern tests rely on/verify this behavior).
This CL clamps the maximum tile area to a reasonable value (16M pixels),
and scales beyond that.
R=bsalomon@google.com, reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
446243002
krajcevski [Thu, 7 Aug 2014 15:15:14 +0000 (08:15 -0700)]
Pass compressed blitters to our mask drawing algorithm
R=robertphillips@google.com, reed@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
446103002
dandov [Thu, 7 Aug 2014 14:49:53 +0000 (07:49 -0700)]
Stopped skipping tests in dm of SkPatch by implementing the
corresponding drawPath calls on classes that derive from SkCanvas.
BUG=skia:
R=egdaniel@google.com, bsalomon@google.com, mtklein@google.com, robertphillips@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
429343004
Robert Phillips [Thu, 7 Aug 2014 14:34:03 +0000 (10:34 -0400)]
Remove mandrill_128.r11.ktx from resources directory
Review URL: https://codereview.chromium.org/
449503003
halcanary [Thu, 7 Aug 2014 14:24:47 +0000 (07:24 -0700)]
render_pdfs implements --match
BUG=skia:2743
NOTRY=true
R=djsollen@google.com, mtklein@google.com, borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
441423002
Robert Phillips [Thu, 7 Aug 2014 14:06:24 +0000 (10:06 -0400)]
Added mandrill_128.r11.ktx to resources
Review URL: https://codereview.chromium.org/
443303005
Derek Sollenberger [Wed, 6 Aug 2014 20:34:40 +0000 (16:34 -0400)]
Revert "Remove SkPaintOptionsAndroid"
This reverts commit
27fb94999b8eec448423884e1d071e563c4c95d9.
Review URL: https://codereview.chromium.org/
450513002
Derek Sollenberger [Wed, 6 Aug 2014 20:31:41 +0000 (16:31 -0400)]
Fix Android framework builds
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
450503002
Derek Sollenberger [Wed, 6 Aug 2014 20:30:51 +0000 (16:30 -0400)]
Remove SkPaintOptionsAndroid
Review URL: https://codereview.chromium.org/
447873003
bungeman [Wed, 6 Aug 2014 20:20:59 +0000 (13:20 -0700)]
Fix reference counting on SkStream in SkFontMgr_android.
R=tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
447003002
fmalita [Wed, 6 Aug 2014 20:07:15 +0000 (13:07 -0700)]
Explicit tile bounds for SkPictureShader
The integer picture size is not granular enough to allow precise tiling
in arbitrary coordinate systems. This CL adds an optional tile bounds
float rect param to control the tile size and location.
(this also allows tile spacing emulation for picture
shaders).
R=reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
437393003
krajcevski [Wed, 6 Aug 2014 19:47:59 +0000 (12:47 -0700)]
Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
444433002
reed [Wed, 6 Aug 2014 19:43:09 +0000 (12:43 -0700)]
fix concat order for local matrices
BUG=skia:
R=bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
446013004
humper [Wed, 6 Aug 2014 19:39:59 +0000 (12:39 -0700)]
make the action buttons for rebaseline server stick to the top of the window as you scroll
NOTRY=true
BUG=skia:1912
R=stephana@google.com, epoger@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
446933002
krajcevski [Wed, 6 Aug 2014 19:35:27 +0000 (12:35 -0700)]
Revert of Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes. (https://codereview.chromium.org/
444433002/)
Reason for revert:
Breaking chrome.
Original issue's description:
> Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.
>
> Committed: https://skia.googlesource.com/skia/+/
1840dcd2f1368279df907988a9b584ffd500de4c
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
444103002
krajcevski [Wed, 6 Aug 2014 19:02:49 +0000 (12:02 -0700)]
Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
444433002
mtklein [Wed, 6 Aug 2014 18:57:00 +0000 (11:57 -0700)]
SkPicture: try to no-op away clone().
Will actually enable this by #defining SK_PICTURE_CLONE_NOOP in Chrome's SkUserConfig.h as a separate CL after this rolls in.
BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
447753003
robertphillips [Wed, 6 Aug 2014 18:26:53 +0000 (11:26 -0700)]
Second pass at rebaselining flaky N4 performance triggers
R=bungeman@google.com
TBR=bungeman@google.com
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
444063002
bungeman [Wed, 6 Aug 2014 18:12:20 +0000 (11:12 -0700)]
Implement SkFontMgr_Android::onMatchFamilyStyleCharacter.
This will allow us to replace SkGetFallbackFamilyNameForChar
and also eventually fix issues with it's reliance on names.
R=djsollen@google.com, tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
427293003
krajcevski [Wed, 6 Aug 2014 18:12:14 +0000 (11:12 -0700)]
Allow custom blitters to be passed to SkDraw::drawPath
R=reed@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
444003004
halcanary [Wed, 6 Aug 2014 18:07:11 +0000 (11:07 -0700)]
Roll android/third_party/jpeg DEPS
BUG=skia:2791
R=djsollen@google.com
TBR=djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
449493004
egdaniel [Wed, 6 Aug 2014 18:07:02 +0000 (11:07 -0700)]
Create struct in GrDrawState to hold key DrawState data.
Eventually this struct will be used to easily set values for a reduced, optimized drawstate
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
448453002
djsollen [Wed, 6 Aug 2014 18:01:58 +0000 (11:01 -0700)]
Remove references to __system_property_get from Skia
BUG=392201
R=tomhudson@chromium.org, bungeman@google.com, tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
433163002
bsalomon [Wed, 6 Aug 2014 18:01:44 +0000 (11:01 -0700)]
Fix drawVertices() on GPU when texs=colors=shaders=indices=null
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
449433003
epoger [Wed, 6 Aug 2014 17:56:50 +0000 (10:56 -0700)]
rebaseline_server: add "prefetch" directive that just warms the cache without awaiting results
This will allow the buildbots to warn the production rebaseline_server: "I just
generated some new results; here's a comparison that a human might ask for
soon. Download whatever images and generate whatever diffs you would need to
provide those results."
BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
443013002
bsalomon [Wed, 6 Aug 2014 17:52:33 +0000 (10:52 -0700)]
Add angle config to nanobench and make angle a default config for dm and nanobench.
NOTREECHECKS=true
R=mtklein@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
441333003
mtklein [Wed, 6 Aug 2014 17:08:42 +0000 (10:08 -0700)]
On the bots, there's no need to link GMs into SampleApp.
We build SampleApp on the bots to make sure it's not broken, but we don't run it. So, there's no need to link in all the GMs as samples.
This reduces the number of copies of our GMs from 4 to 3 (gm, dm, and nanobench remain).
NOTREECHECKS=true
BUG=skia:2142
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
447803002
reed [Wed, 6 Aug 2014 16:54:19 +0000 (09:54 -0700)]
parameterize tesselation params
TBR=
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
446913002
mtklein [Wed, 6 Aug 2014 15:39:36 +0000 (08:39 -0700)]
Bye bye bench.
NOTREECHECKS=true
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
442343004
epoger [Wed, 6 Aug 2014 15:37:53 +0000 (08:37 -0700)]
rebaseline_server live queries: allow comparison against summary files within the Skia repo
This is a step towards providing SKP comparisons against expectations, not just
other actual results... we still need to allow the user to select
JSONKEY_EXPECTEDRESULTS vs JSONKEY_ACTUALRESULTS within the summary
files found.
BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
442203002
bungeman [Wed, 6 Aug 2014 15:15:50 +0000 (11:15 -0400)]
Revert "Adds a GrGLPathRendering class that wraps the NV_path_rendering"
This reverts commit
5672da0fa54f31c9727568e9dd5fe82c6e1585bc.
This appears to be blocking the Skia roll by causing failures in the blink layout tests on the canvas-lost-gpu-context.html test.
The bisect for this can be seen at:
https://codereview.chromium.org/
449473002/
Original issue's description:
> Adds a GrGLPathRendering class that wraps the NV_path_rendering
> extension and manages its various API versions. It also provides
> backup implementations when certain NVpr methods from later API
> versions are not present on the current system.
>
> Committed: https://skia.googlesource.com/skia/+/
5672da0fa54f31c9727568e9dd5fe82c6e1585bc
bungeman [Wed, 6 Aug 2014 15:14:31 +0000 (11:14 -0400)]
Revert "Calculate rough approximations for nvpr path sizes"
This reverts commit
61bff7097251755bf9fa9a4ec60cc057c766b4a4.
This is built on
5672da0fa54f31c9727568e9dd5fe82c6e1585bc
which is causing blink test failures on canvas-lost-gpu-context.html.
Robert Phillips [Wed, 6 Aug 2014 14:50:53 +0000 (10:50 -0400)]
Add ASTC resource files
Review URL: https://codereview.chromium.org/
442363003
mtklein [Wed, 6 Aug 2014 14:46:30 +0000 (07:46 -0700)]
DM: expand peak RAM usage to Mac and Android too.
BUG=skia:
NOTREECHECKS=true
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
445963002
reed [Wed, 6 Aug 2014 14:00:27 +0000 (07:00 -0700)]
fix hittest in Patch sample
TBR=
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/
441373002
djsollen [Wed, 6 Aug 2014 13:58:06 +0000 (06:58 -0700)]
Remove ALL font fallback logic from Skia.
R=reed@google.com, bungeman@google.com, caryclark@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
434623002
mtklein [Wed, 6 Aug 2014 13:55:12 +0000 (06:55 -0700)]
SkThreadPool and co. are not public.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
444583006
borenet [Wed, 6 Aug 2014 13:04:00 +0000 (06:04 -0700)]
Remove Mac 10.8 x86 Perf expectations
This is one of the problems with the way the RecreateSKPs bot determines which trybots to run: Rather than use a hard-coded list, it figures out which bots have perf expectations and then runs those bots to generate new expectations. This is problematic when we remove a bot because we have to remove its expectations as well. This is really not that different from maintaining a hard-coded list...
NOTRY=true
BUG=skia:
R=bensong@google.com, rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
443093002
robertphillips [Wed, 6 Aug 2014 12:16:29 +0000 (05:16 -0700)]
Rebaseline flaky N4 & N7 performance triggers
R=bungeman@google.com
TBR=bungeman@google.com
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
440423002
senorblanco [Tue, 5 Aug 2014 21:27:27 +0000 (14:27 -0700)]
Greenify bench bot Perf-Android-Nexus10-MaliT604-Arm7-Release at build 2563
R=bsalomon@google.com
TBR=bsalomon@google.com
Bypassing trybots:
NOTRY=true
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
442083003
senorblanco [Tue, 5 Aug 2014 21:26:28 +0000 (14:26 -0700)]
Greenify bench bot Perf-Android-GalaxyNexus-SGX540-Arm7-Release at build 1811
R=bsalomon@google.com
TBR=bsalomon@google.com
Bypassing trybots:
NOTRY=true
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
443743002
krajcevski [Tue, 5 Aug 2014 21:13:36 +0000 (14:13 -0700)]
Add support for all compressed formats in KTX file format
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
440783004
tomhudson [Tue, 5 Aug 2014 20:35:00 +0000 (13:35 -0700)]
Parses sample code provided by Android project. Attempts to keep FontFamily data structures produced consistent with expectations of previous versions of Skia.
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
446473003
ch.dumez [Tue, 5 Aug 2014 19:20:19 +0000 (12:20 -0700)]
Expose SkColorTable class
Expose SkColorTable class as it is used in SkBitmap::allocPixels(SkColorTable*)
API, which is already exposed.
R=reed@google.com, ben@chromium.org
Author: ch.dumez@samsung.com
Review URL: https://codereview.chromium.org/
418173011
senorblanco [Tue, 5 Aug 2014 19:05:03 +0000 (12:05 -0700)]
Greenify bench bot Perf-Ubuntu12-ShuttleA-GTX660-x86-Release at build 1551
R=bensong@google.com, bensong@chromium.org
Bypassing trybots:
NOTRY=true
BUG=2794
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
442903002
tomhudson [Tue, 5 Aug 2014 19:01:09 +0000 (12:01 -0700)]
Fix bad gypi
Must not depend directly on ports; depend on skialib!
R=bungeman@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
442883002
cdalton [Tue, 5 Aug 2014 17:58:19 +0000 (10:58 -0700)]
Calculate rough approximations for nvpr path sizes
Calculates a rough approximation of the actual value for gpuMemorySize
in GrGLPath and GrGLPathRange, instead of assuming every path is the
same fixed size.
BUG=skia:
R=bsalomon@google.com, markkilgard@gmail.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
442603002
epoger [Tue, 5 Aug 2014 17:07:22 +0000 (10:07 -0700)]
teach rebaseline_server to generate diffs of rendered SKPs
Creates a new live-view.html page, served by the rebaseline_server, that will display diffs between two sets of rendered SKP images.
BUG=skia:1942
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
424263005
bsalomon [Tue, 5 Aug 2014 14:50:06 +0000 (07:50 -0700)]
Move functions from GrDrawState.h to GrDrawState.cpp and delete unused functions.
R=egdaniel@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
427713005
krajcevski [Tue, 5 Aug 2014 14:37:26 +0000 (07:37 -0700)]
Add ETC1 format to SkTextureCompressor
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
432143002
bsalomon [Tue, 5 Aug 2014 14:35:56 +0000 (07:35 -0700)]
Don't compare constant color and coverage between GrDrawStates when they are provided by vertex attributes.
R=egdaniel@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
439273007
mtklein [Tue, 5 Aug 2014 14:19:46 +0000 (07:19 -0700)]
For some reason, starting tests before gms makes DM run much faster.
Must be getting the path ops tests going early helps?
On my desktop,
Release: 50s -> 24s
Debug: 62s -> 40s
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
435423003
bsalomon [Tue, 5 Aug 2014 14:15:57 +0000 (07:15 -0700)]
Replace op== with CombineIfPossible in GrDrawState.
R=egdaniel@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
439853002
rmistry [Tue, 5 Aug 2014 13:55:14 +0000 (06:55 -0700)]
Test new CQ bot
TBR=
(SkipBuildbotRuns)
BUG=skia:
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
441833004
tomhudson [Tue, 5 Aug 2014 13:36:11 +0000 (06:36 -0700)]
Test and generalize font configuration parser
Add a basic unit test for the Android font configuration parser.
Add a check for the new LMP file format; on detection, switch to a new
(as-yet unwritten) parser.
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
439813002
mtklein [Tue, 5 Aug 2014 10:51:04 +0000 (03:51 -0700)]
Revert of whitespace change to force a build (https://codereview.chromium.org/
432183002/)
Reason for revert:
force
Original issue's description:
> whitespace change to force a build
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
490d49c5dcc4b2242c9b25f082b23ec5e842c4e7
R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
442603005
mtklein [Mon, 4 Aug 2014 21:10:19 +0000 (14:10 -0700)]
Print max memory usage on Linux.
This is meant to help debug http://skbug.com/2793
BUG=skia:2793
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
433403005
mtklein [Mon, 4 Aug 2014 20:57:39 +0000 (13:57 -0700)]
Fix calibration loop failure condition.
With the old logic, if the last attempt succeeded, we'd say we failed.
We also print two lines for loop calibration failures. Quiet that down.
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
431503004
mtklein [Mon, 4 Aug 2014 20:11:19 +0000 (13:11 -0700)]
disable all warnings from nanomsg
They're annoying.
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
437323002
egdaniel [Mon, 4 Aug 2014 19:54:39 +0000 (12:54 -0700)]
Enable gpu Debug markers if tracing category skia.gpu is enabled
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
438023004
mtklein [Mon, 4 Aug 2014 19:51:19 +0000 (12:51 -0700)]
Force linking as C++ library.
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
420183004
cdalton [Mon, 4 Aug 2014 18:19:11 +0000 (11:19 -0700)]
Adds a GrGLPathRendering class that wraps the NV_path_rendering
extension and manages its various API versions. It also provides
backup implementations when certain NVpr methods from later API
versions are not present on the current system.
R=bsalomon@google.com, kkinnunen@nvidia.com, markkilgard@gmail.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
437473002
mtklein [Mon, 4 Aug 2014 18:10:14 +0000 (11:10 -0700)]
Don't call out -lstdc++ -lm explicitly.
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
440643004
bsalomon [Mon, 4 Aug 2014 17:56:39 +0000 (10:56 -0700)]
Don't compare coord change matrices to determine effect compatibility when using explicit local coords.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
438053002
mtklein [Mon, 4 Aug 2014 17:18:27 +0000 (10:18 -0700)]
Remove dependency on std::string
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
437253003
dandov [Mon, 4 Aug 2014 17:02:00 +0000 (10:02 -0700)]
SkCanvas interface for drawing a patch.
Added function SkCanvas::drawPatch to the API. This function
receives the patch to draw and the paint.
Added function SkBaseDevice::drawPatch to the API. This function also receives the patch to draw and the paint.
Currently SkGpuDevice and SkBitmapDevice generate the mesh taking into
account the scale factor and call the corresponding device's drawVertices.
BUG=skia:
R=jvanverth@google.com, egdaniel@google.com, bsalomon@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
424663006
mtklein [Mon, 4 Aug 2014 16:57:37 +0000 (09:57 -0700)]
Stop building tests in the Android tree.
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
440653004