platform/upstream/dotnet/runtime.git
5 years agoAdd nullable annotations to System.Runtime.InteropServices.WindowsRuntime ref (dotnet...
Santiago Fernandez Madero [Wed, 19 Jun 2019 17:32:59 +0000 (10:32 -0700)]
Add nullable annotations to System.Runtime.InteropServices.WindowsRuntime ref (dotnet/corefx#38003)

* Add nullable annotations to System.Runtime.InteropServices.WindowsRuntime ref

* Apply nullable attributes

Commit migrated from https://github.com/dotnet/corefx/commit/36ff261d4ec19933dde77c11c78256f62a5a4487

5 years agoAdd nullable annotations to System.Runtime.InteropServices ref assembly (dotnet/coref...
Santiago Fernandez Madero [Wed, 19 Jun 2019 17:30:56 +0000 (10:30 -0700)]
Add nullable annotations to System.Runtime.InteropServices ref assembly (dotnet/corefx#37987)

* Add nullable annotations to System.Runtime.InteropServices ref assembly

* Add nullable attributes

* Address nullable feedback from API Review, object -> notnull constraint

Commit migrated from https://github.com/dotnet/corefx/commit/e1454c1aee299a4f96f718083c89f1b2b952f26c

5 years agoShrink System.Diagnostics.Activity by 40 bytes (dotnet/corefx#37395)
Ben Adams [Wed, 19 Jun 2019 14:21:25 +0000 (15:21 +0100)]
Shrink System.Diagnostics.Activity by 40 bytes (dotnet/corefx#37395)

* Shrink Activity

* fix threading issues

* Handle parsing issues

* Fix

Commit migrated from https://github.com/dotnet/corefx/commit/edc88b0fe55278ee43c821ab05707d8bb0befded

5 years agoGuard for large array support in System.Drawing.Common tests (dotnet/corefx#38672)
Filip Navara [Wed, 19 Jun 2019 10:32:08 +0000 (12:32 +0200)]
Guard for large array support in System.Drawing.Common tests (dotnet/corefx#38672)

Commit migrated from https://github.com/dotnet/corefx/commit/fd9801068f1baf8d69893da2a414eee7556e51b0

5 years agoAdd debugging info for sporadic Dns.GetHostEntry("") CI failures (dotnet/corefx#38665)
Stephen Toub [Wed, 19 Jun 2019 08:31:31 +0000 (04:31 -0400)]
Add debugging info for sporadic Dns.GetHostEntry("") CI failures (dotnet/corefx#38665)

Commit migrated from https://github.com/dotnet/corefx/commit/a3fc1b83b5f1d70d6b8529a9ec55178d959fa70d

5 years agoPort DynamicMetaObjectProviderDebugView (dotnet/corefx#38656)
Charles Stoner [Wed, 19 Jun 2019 08:26:05 +0000 (01:26 -0700)]
Port DynamicMetaObjectProviderDebugView (dotnet/corefx#38656)

* Port DynamicMetaObjectProviderDebugView

* Remove System.Diagnostics.CodeAnalysis.SuppressMessage attributes

* Add explicit private modifier

Commit migrated from https://github.com/dotnet/corefx/commit/af04307b356e38e2b74df1f05f735ebc462850da

5 years agowriting to too small buffer should throw an exception (dotnet/corefx#37661)
Adam Sitnik [Wed, 19 Jun 2019 08:06:28 +0000 (10:06 +0200)]
writing to too small buffer should throw an exception  (dotnet/corefx#37661)

fixes dotnet/corefx#35231

Commit migrated from https://github.com/dotnet/corefx/commit/721a570b005c53a839947603dcf76f8a3e5fc56a

5 years agoUpdate the PackageReferences for crypto OOBs in netstandard.depproj
Jeremy Barton [Wed, 19 Jun 2019 05:18:35 +0000 (22:18 -0700)]
Update the PackageReferences for crypto OOBs in netstandard.depproj

The 4.5.0 ref/netstandard2.0 had three properties declared get/set which were
actually get-only.  Updating the depproj version allows removal of the
ApiCompat errors in the shims.

While only 4.5.1 is required, the consensus was to just upgrade all of these
references to the latest versions.  Cng (4.5.0) is already at the newest.

Commit migrated from https://github.com/dotnet/corefx/commit/8b16e3ebf4f4c8be6ed6d744451c512a4d927750

5 years agoDisable InvokeOnEventsThreadRunsAsynchronously test on netfx (dotnet/corefx#38662)
Stephen Toub [Wed, 19 Jun 2019 02:25:24 +0000 (22:25 -0400)]
Disable InvokeOnEventsThreadRunsAsynchronously test on netfx (dotnet/corefx#38662)

And avoid the whole suite from hanging by changing an ~3hr timeout to a 30s timeout.

Commit migrated from https://github.com/dotnet/corefx/commit/818465ad8624c0231262dba6e7c3a0fc4ca42a7a

5 years agoAdd nullable annotations to System.Collections.Concurrent ref assembly (dotnet/corefx...
Santiago Fernandez Madero [Wed, 19 Jun 2019 01:35:07 +0000 (18:35 -0700)]
Add nullable annotations to System.Collections.Concurrent ref assembly (dotnet/corefx#38189)

* Add nullable annotations to System.Collections.Concurrent ref assembly

* Re-run GenAPI after some attribute fixes

* Update attributes and object -> notnull constraint

Commit migrated from https://github.com/dotnet/corefx/commit/1494abacb0ec55e7065282311966b1c32329a1f5

5 years agoupdate system.transaction owner names (dotnet/corefx#38664)
Hong Li [Wed, 19 Jun 2019 00:34:13 +0000 (17:34 -0700)]
update system.transaction owner names (dotnet/corefx#38664)

Commit migrated from https://github.com/dotnet/corefx/commit/c0ed16860e62eea24620b7144ef72d5819ddb2b2

5 years agoAdd nullable annotations to System.Memory ref assembly (dotnet/corefx#38299)
Santiago Fernandez Madero [Tue, 18 Jun 2019 23:16:18 +0000 (16:16 -0700)]
Add nullable annotations to System.Memory ref assembly (dotnet/corefx#38299)

* Add nullable annotations to System.Memory ref assembly

* Nullable feedback

* Include where T inside pragma to be consistent with sources

* Make CultureInfo nullable in ToLower/Upper to match updates we did on String

* Revert comparer nullable change in BinarySearch per pr feedback in implementation

Commit migrated from https://github.com/dotnet/corefx/commit/ad961d0dc9d9054942c6a7e3a8c96c8684dd16cc

5 years agoAdapt existing HttpClientMiniStress tests to support HTTP/2 (dotnet/corefx#38619)
Stephen Toub [Tue, 18 Jun 2019 22:08:38 +0000 (18:08 -0400)]
Adapt existing HttpClientMiniStress tests to support HTTP/2 (dotnet/corefx#38619)

This adapts the existing HttpClientMiniStress tests to run with HTTP/2 as well as HTTP/1.1.  Some caveats, though:
- All of these existing tests spin up a new server per request, so they're not stressing arguably the most important aspect of the client's HTTP/2 implementation, that of sharing the single connection across all requests.  Our loopback server is not currently robust enough to handle concurrent requests; we should look at switching over to using Kestrel.
- The tests run really slowly, ~40x slower than for HTTP/1.1.  However, the HTTP/1.1 tests are non-SSL, these are of course SSL, and it looks like that's actually the difference.  In particular, something about how our test server gets its test certificate appears to be taking the vast majority of the time. (We should separately see if we could tweak that, not just for this purpose, but more so to help speed up the whole suite.)

Commit migrated from https://github.com/dotnet/corefx/commit/a7c893ab3d3e50b11c7fa2338882c8964e0a290d

5 years agoTry to make MonitoringIsEnabled more stable (dotnet/corefx#38651)
Stephen Toub [Tue, 18 Jun 2019 22:08:20 +0000 (18:08 -0400)]
Try to make MonitoringIsEnabled more stable (dotnet/corefx#38651)

Add a GC.Collect call to ensure the GC.GetMemoryInfo sees the object being kept alive.

Commit migrated from https://github.com/dotnet/corefx/commit/471edf259604905535f147ddfb2c8fe5a37ce81d

5 years agoFix GetLogInformation_UsingLogName_DoesNotThrow test (dotnet/corefx#38653)
Stephen Toub [Tue, 18 Jun 2019 22:06:45 +0000 (18:06 -0400)]
Fix GetLogInformation_UsingLogName_DoesNotThrow test (dotnet/corefx#38653)

The test was doing multiple reads from the underlying log and expecting them to be equivalent.  That's not guaranteed, as it's a global machine resource.

Commit migrated from https://github.com/dotnet/corefx/commit/475056abaaf3b1e9e29088c992157b415a800e54

5 years agoDisable System.Drawing.Common tests for RedHat6 (dotnet/corefx#38649)
Santiago Fernandez Madero [Tue, 18 Jun 2019 18:44:55 +0000 (11:44 -0700)]
Disable System.Drawing.Common tests for RedHat6 (dotnet/corefx#38649)

Commit migrated from https://github.com/dotnet/corefx/commit/a7e0c8d9e14a4f814a7e08ddfd0316353c37dd95

5 years agoremove active issues (dotnet/corefx#38411)
Marco Rossignoli [Tue, 18 Jun 2019 06:26:21 +0000 (08:26 +0200)]
remove active issues (dotnet/corefx#38411)

Commit migrated from https://github.com/dotnet/corefx/commit/1fca079ddec2aabf56e256dab03e39b31b5036c7

5 years agoFixed CaseSenstive Issues (dotnet/corefx#38532)
Erhan Atesoglu [Tue, 18 Jun 2019 05:32:43 +0000 (22:32 -0700)]
Fixed CaseSenstive Issues (dotnet/corefx#38532)

Commit migrated from https://github.com/dotnet/corefx/commit/dc9a0f2c5c3e1718a75a9ed508e8a06309c174fb

5 years agoAdd nullable annotations to System.Numerics.Vectors ref assembly (dotnet/corefx#38511)
Santiago Fernandez Madero [Tue, 18 Jun 2019 04:22:06 +0000 (21:22 -0700)]
Add nullable annotations to System.Numerics.Vectors ref assembly (dotnet/corefx#38511)

* Add nullable annotations to System.Numerics.Vectors ref assembly

* Fix various missing ? on ToString(string format)

Commit migrated from https://github.com/dotnet/corefx/commit/85a2e0c1a3eebf0c937d26de1aafe4e4687b2d4f

5 years agoAdd nullable annotations to System.Runtime.Loader ref (dotnet/corefx#38417)
Santiago Fernandez Madero [Tue, 18 Jun 2019 03:47:53 +0000 (20:47 -0700)]
Add nullable annotations to System.Runtime.Loader ref (dotnet/corefx#38417)

Commit migrated from https://github.com/dotnet/corefx/commit/753ae3bca0330fbf80cf20bed0a676d317eefa08

5 years agoHave consistent Dispose behaviors for AsymmetricAlgorithm objects
Jeremy Barton [Tue, 18 Jun 2019 01:25:56 +0000 (18:25 -0700)]
Have consistent Dispose behaviors for AsymmetricAlgorithm objects

The AsymmetricAlgorithm types weren't consistent in how they handled Dispose. There were four predominant behaviors on use-after-Dispose

* NullReferenceException (mainly from the OpenSsl implementations)
* Generate a new key, like the object was fresh (the public Cng implementations)
* Not notice that anything was Disposed, keep on keepin' on (the private Cng implementations in Algorithms)
* Indirect ObjectDisposedExceptions 95% of the time (the Windows CSP types)

This change makes all of the types consistently go into (and stay in) a Disposed state, throwing ObjectDisposedExceptions when asked to do work in that state.

Commit migrated from https://github.com/dotnet/corefx/commit/fb81332b9643ecf8c0bb34d7938da97aa5e13e03

5 years agoProviding support for duplicate keys in dictionary (dotnet/corefx#38524)
Anirudh Agnihotry [Mon, 17 Jun 2019 22:48:41 +0000 (15:48 -0700)]
Providing support for duplicate keys in dictionary (dotnet/corefx#38524)

* providing support for duplicate keys in dictionary

* Improving failure message

* fixing merge conflicts

Commit migrated from https://github.com/dotnet/corefx/commit/ef0578fd6abeba406ddffbb1591c1a618bca9dae

5 years agoRemove StructLayoutAttribute from GdipImageCodecInfo (dotnet/corefx#38607)
Santiago Fernandez Madero [Mon, 17 Jun 2019 21:52:19 +0000 (14:52 -0700)]
Remove StructLayoutAttribute from GdipImageCodecInfo (dotnet/corefx#38607)

* Remove StructLayoutAttribute from GdipImageCodecInfo

* PR Feedback

* Remove wrong comment

Commit migrated from https://github.com/dotnet/corefx/commit/422e295955841aa2d87d41812e7eef1a755f1e0e

5 years agoRemoving the Manual reference file from System.Text.Json (dotnet/corefx#38409)
Jose Perez Rodriguez [Mon, 17 Jun 2019 21:10:20 +0000 (14:10 -0700)]
Removing the Manual reference file from System.Text.Json (dotnet/corefx#38409)

* Removing the Manual reference file from System.Text.Json

* Readd the netcoreapp and uap configurations so that we don't have to bring AsyncInterfaces package into the shared framework closure

* Revert param name change as per PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/5b3d41c1c63c4ebd93af7e6482e954e104827884

5 years agoAdd missing .ConfigureAwait(false) in HttpConnectionPool (dotnet/corefx#38610)
Stephen Toub [Mon, 17 Jun 2019 20:25:38 +0000 (16:25 -0400)]
Add missing .ConfigureAwait(false) in HttpConnectionPool (dotnet/corefx#38610)

Commit migrated from https://github.com/dotnet/corefx/commit/3b2707b4b672af99d9d7ac3d57352099f1ff3ff1

5 years agoChange DiagnosticsHandler to special-case base cancellation exception (dotnet/corefx...
Stephen Toub [Mon, 17 Jun 2019 20:25:23 +0000 (16:25 -0400)]
Change DiagnosticsHandler to special-case base cancellation exception (dotnet/corefx#38601)

It should be treating all OperationCanceledExceptions as cancellation, not just TaskCanceledException.

Commit migrated from https://github.com/dotnet/corefx/commit/dd6b0669bec5ac3b72b2b3a015f42c403c3ec0f1

5 years agoRe-generate System.Collections.Immutable ref assembly and fix a param name (dotnet...
Santiago Fernandez Madero [Mon, 17 Jun 2019 16:12:53 +0000 (09:12 -0700)]
Re-generate System.Collections.Immutable ref assembly and fix a param name (dotnet/corefx#38264)

* Re-generate System.Collections.Immutable ref assembly and fix a param name

* Use builder as the param name instead

Commit migrated from https://github.com/dotnet/corefx/commit/2e6661d4cceeff2549b0299ec54e9f3b34c09b20

5 years agoMerge pull request dotnet/corefx#38593 from ViktorHofer/YamlOfficialFix
Viktor Hofer [Mon, 17 Jun 2019 14:55:45 +0000 (16:55 +0200)]
Merge pull request dotnet/corefx#38593 from ViktorHofer/YamlOfficialFix

Fix leg configurations in official builds and converge redhat6 with linux

Commit migrated from https://github.com/dotnet/corefx/commit/c7178a34416ceb17240b9b3312a5740616555527

5 years agoMove redhat6 into linux group
Viktor Hofer [Mon, 17 Jun 2019 08:44:59 +0000 (10:44 +0200)]
Move redhat6 into linux group

Commit migrated from https://github.com/dotnet/corefx/commit/519eccdf8e9c8cb0390f91da8561fcf98a19b838

5 years agoRe-activate test Transactions test. (dotnet/corefx#38554)
Stephen Bonikowsky [Mon, 17 Jun 2019 07:59:53 +0000 (00:59 -0700)]
Re-activate test Transactions test. (dotnet/corefx#38554)

* This test was disabled a long time ago with failures only occuring in CI.
* Re-enabling to see if the issue still exists.
* System.Transactions.Tests.AsyncTransactionScopeTests.AsyncTSTest

Commit migrated from https://github.com/dotnet/corefx/commit/7acfe7156497d667fc39bc1cdb5a7e95d12f5dca

5 years agoFix leg configurations in official builds
Viktor Hofer [Mon, 17 Jun 2019 07:34:19 +0000 (09:34 +0200)]
Fix leg configurations in official builds

Commit migrated from https://github.com/dotnet/corefx/commit/32c7d6dad79ec54cd23e5f4bbdf2ce3e827fa1bd

5 years agoFix the failure in RegionInfo Tests (dotnet/corefx#38577)
Tarek Mahmoud Sayed [Sun, 16 Jun 2019 19:38:38 +0000 (20:38 +0100)]
Fix the failure in RegionInfo Tests (dotnet/corefx#38577)

* Fix the failure in RegionInfo Tests

China region name has changed to "China mainland", we are updating the test to accept this new name too.

Commit migrated from https://github.com/dotnet/corefx/commit/d3b6b4aff1dd10afdc83ecfd01ee462737693077

5 years agoAdd support for serializing types that implement IDictionary<string, object> (dotnet...
Layomi Akinrinade [Sun, 16 Jun 2019 10:57:34 +0000 (06:57 -0400)]
Add support for serializing types that implement IDictionary<string, object> (dotnet/corefx#38512)

* Add support for serializing types that implement IDictionary<string, object>

* Add test for string to string IDictionary

* fixup

* Address review feedback

* Rename dict -> dictionary

Commit migrated from https://github.com/dotnet/corefx/commit/e2e5fb23280b3962dcb0422b0df7930387c8ac24

5 years agomake sure we close OS handle if socket is finalized without disposing (dotnet/corefx...
Tomas Weinfurt [Sun, 16 Jun 2019 04:40:37 +0000 (21:40 -0700)]
make sure we close OS handle if socket is finalized without disposing  (dotnet/corefx#38499)

* socket_finalize_37044

* update test

Commit migrated from https://github.com/dotnet/corefx/commit/23faf5d032feef556f5399b46a92a6e4aef7d84a

5 years agoAdd support for more collections (dotnet/corefx#38319)
Layomi Akinrinade [Sat, 15 Jun 2019 23:49:03 +0000 (19:49 -0400)]
Add support for more collections (dotnet/corefx#38319)

* Add support for ISet

* Add support for IEnumerable, IList, and ICollection (non-generic)

* Add support for non-generic IDictionary

* Address review feedback

* Remove unused exception resource and remove ISet<ISet<T>> (de)serialization limitation

* Add support for non-generic collections that have a constructor that takes an IEnumerable or IDictionary

* Condense branches for types we need to set runtime types for

*  Add support for non-generic collections that have a constructor that takes an IList

* Add support for Hashtable and SortedList

* Verify sorted dictionary works

* Add support for KeyValuePair

* Create concrete instance of types Foo where possible

* Use generic constructor for KeyValuePair

* Fix KeyValuePair creation in tests

Commit migrated from https://github.com/dotnet/corefx/commit/4aece7a121a164e68954d79a0ec2569bd71cf125

5 years agoAllow interface names in IPv6 link-local addresses (dotnet/corefx#35278)
Egor Bogatov [Sat, 15 Jun 2019 21:44:42 +0000 (00:44 +0300)]
Allow interface names in IPv6 link-local addresses (dotnet/corefx#35278)

* Handle interface names in ipv6 addresses (link-local)

* fix test projects

* Address feedback

* Add SetLastError to if_nametoindex

* fix tests

* fix tests

* Add more tests

* move native impl to pal_networking.c/h

* add newlines to pal_networking

* fix build

* remove "Vista" comment from Interop.if_nametoindex.cs

* test fix for Uri.cs

* undo changes

* Always return 0 for if_nametoindex on UAP

Commit migrated from https://github.com/dotnet/corefx/commit/fef0f817013ca7ebd39857b7aeecd369a9c36af5

5 years agoEnable project restore for test projects (dotnet/corefx#38151)
Viktor Hofer [Sat, 15 Jun 2019 19:27:13 +0000 (21:27 +0200)]
Enable project restore for test projects (dotnet/corefx#38151)

* Factor out repo restore into seperate props/targets

* Use configuration system msbuild sdk

* Remove XUnit.Runtime.depproj

* Remove TargetGroup usages in test projects

* Fix ILLink configuration

The ILLink package contains netcoreapp2.0 assets which are compatible
with netstandard2.0. Removing the old TargetFramework to restore
successfully.

* Remove usages from TargetGroup in Directory.Build.props

* Remove dead net4* configurations

* Change tests.builds to tests.proj sdk proj

* Make externals dir proj an sdk project

* Consume Microsoft.DotNet.CoreFxTesting as an msbuild sdk

* Use runtimeconfig.template.json

* Remove SupplementalTestData

* Map shared framework version to product version

* Stop binplacing tests

* Move some tool depprojs to targets during restore

* Remove dead code

* Use PackageReference instead of RefFromRuntime in test

* Disable using an apphost

* Copy compression testdata manually cause unicode bug

* Remove target batching in optimizationData

* Reference packaging tools from CoreFx.Private.TestUtilities

Commit migrated from https://github.com/dotnet/corefx/commit/c4c1985531cc1f25c805bbc4801b85c98e0dfee0

5 years agoAdd S.S.C.Pkcs and S.S.C.Cng netstandard2.1 ref and lib (dotnet/corefx#38439)
Jeremy Barton [Sat, 15 Jun 2019 17:28:23 +0000 (10:28 -0700)]
Add S.S.C.Pkcs and S.S.C.Cng netstandard2.1 ref and lib (dotnet/corefx#38439)

* Add S.S.C.Pkcs and S.S.C.Cng netstandard2.1 ref and lib

The netstandard2.1 ref is equivalent to the netcoreapp3.0 ref in these two
OOB packages.

Ref changes:

Cng:
* Adds DSACng and ECDiffieHellmanCng (and related types)

Pkcs:
* Adds RSA-OAEP option to CmsRecipient
* Adds custom private key option to CmsSigner
* Adds custom private key decrypt option to EnvelopedCms
* Adds Pkcs12Info and Pkcs12Builder (and associated types)
* Adds Pkcs8PrivateKeyInfo
* Adds RFC3161 timestamp types
* Adds AddCertificate/RemoveCertificate to SignedCms
* Adds AddUnsignedAttribute/RemoveUnsignedAttribute to SignerInfo
* Adds SignatureAlgorithm/GetSignature to SignerInfo
* Adds MatchesCertificate to SubjectIdentifier

Impl changes:

Cng:
* The netstandard2.1 impl is a generated PNSE, the real impl is inbox on Windows.

Pkcs:
* The impls are the same as the netcoreapp3.0 impls, but are required
because netstandard2.0 is a better match for netstandard2.1 than netcoreapp3.0 is.

* Use shared netstandard21 DefineConstant

* Add netstandard2.1 to ref AdditionalBuildConfigurations

Commit migrated from https://github.com/dotnet/corefx/commit/985334c90d6b181cd47cd42c4c958d9dd34ab90b

5 years agoAdd nullable annotations to System.Threading.Overlapped ref (dotnet/corefx#38298)
Santiago Fernandez Madero [Sat, 15 Jun 2019 01:55:50 +0000 (18:55 -0700)]
Add nullable annotations to System.Threading.Overlapped ref (dotnet/corefx#38298)

* Add nullable attributes to System.Threading.Overlapped ref

* Address feedback from API Review

Commit migrated from https://github.com/dotnet/corefx/commit/5fa3d3b8f89302202091993681391c9b356755a7

5 years agoAdd nullable annotations to System.Threading.ThreadPool ref assembly. (dotnet/corefx...
Santiago Fernandez Madero [Sat, 15 Jun 2019 01:55:23 +0000 (18:55 -0700)]
Add nullable annotations to System.Threading.ThreadPool ref assembly. (dotnet/corefx#38239)

* Re-generate System.Threading.ThreadPool ref assembly against implementation

* Enable nullable context on System.Threading.ThreadPool

* Add nullable annotations to System.Threading.ThreadPool

Commit migrated from https://github.com/dotnet/corefx/commit/040b28ca57fbe57db32a0b56c977d4956991e34c

5 years agoMoving System.Security.Permissions Types from WPF
Dilip Ojha [Fri, 14 Jun 2019 23:27:45 +0000 (16:27 -0700)]
Moving System.Security.Permissions Types from WPF

* moved wpf types

* added new types to ref

* addressed comments

* addressing comments

* addressed more comments

* addressed comment

* updated ref

* added typeforwardedfrom and addressed comment

* updated publickeytoken

* added tests, addressed comments

* added mediapermissionattribute test

Commit migrated from https://github.com/dotnet/corefx/commit/df5bb8e4509ca5166f83abbd4cfe4a063433fee7

5 years agoDelete dead uapaot code (dotnet/corefx#38330)
Viktor Hofer [Fri, 14 Jun 2019 13:12:42 +0000 (15:12 +0200)]
Delete dead uapaot code (dotnet/corefx#38330)

* Delete dead uapaot code

Commit migrated from https://github.com/dotnet/corefx/commit/8c2be7893fa585cba9c094c27b69d7c8e0822ef3

5 years agoAdd nullable annotations to System.Threading.Timer ref assembly (dotnet/corefx#38284)
Santiago Fernandez Madero [Fri, 14 Jun 2019 03:16:26 +0000 (20:16 -0700)]
Add nullable annotations to System.Threading.Timer ref assembly (dotnet/corefx#38284)

Commit migrated from https://github.com/dotnet/corefx/commit/c3f4524c785a226bae79cc82a96f7525460e2b5e

5 years agoAdd nullable annotations to System.Threading.Tasks ref assembly (dotnet/corefx#38265)
Santiago Fernandez Madero [Fri, 14 Jun 2019 03:13:21 +0000 (20:13 -0700)]
Add nullable annotations to System.Threading.Tasks ref assembly (dotnet/corefx#38265)

Commit migrated from https://github.com/dotnet/corefx/commit/3f94d610c133440eeb06f418540be6d8fd782ca0

5 years agoAdd nullable annotations to System.Threading.Thread ref assembly (dotnet/corefx#38236)
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:10:11 +0000 (17:10 -0700)]
Add nullable annotations to System.Threading.Thread ref assembly (dotnet/corefx#38236)

Commit migrated from https://github.com/dotnet/corefx/commit/44d305e2f0a312bb0506e0e1ef1fcafeb07b2bb1

5 years agoAdd nullable annotations to System.Threading ref (dotnet/corefx#38223)
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:09:44 +0000 (17:09 -0700)]
Add nullable annotations to System.Threading ref (dotnet/corefx#38223)

* Add nullable annotations to System.Threading

* Update nullable attributes

Commit migrated from https://github.com/dotnet/corefx/commit/6538c26973d574e9ef92790210f11d11fd2d750f

5 years agoDefine osx.10.15 RID (dotnet/corefx#38509)
Jeremy Barton [Fri, 14 Jun 2019 00:09:16 +0000 (17:09 -0700)]
Define osx.10.15 RID (dotnet/corefx#38509)

Commit migrated from https://github.com/dotnet/corefx/commit/2458de0ada6a2eac4c36cc07628f4e7b3a02ad73

5 years agoUpdate one annotation on System.Runtime ref assembly (dotnet/corefx#38529)
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:08:49 +0000 (17:08 -0700)]
Update one annotation on System.Runtime ref assembly (dotnet/corefx#38529)

Commit migrated from https://github.com/dotnet/corefx/commit/b9bb7c8ec3c6011c0f5815edf38c211982193718

5 years agoEnable nullable context to System.Buffers (dotnet/corefx#38530)
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:08:20 +0000 (17:08 -0700)]
Enable nullable context to System.Buffers (dotnet/corefx#38530)

Commit migrated from https://github.com/dotnet/corefx/commit/66d5a9410a2e163452e9e8b15328d3caf8c336d5

5 years agoUpdate corefx for compiler nullable attribute updates
Stephen Toub [Thu, 13 Jun 2019 20:55:11 +0000 (16:55 -0400)]
Update corefx for compiler nullable attribute updates

Commit migrated from https://github.com/dotnet/corefx/commit/3c129ac0340a3843ab5b00a9c730730e7b60729b

5 years agoTests for nullable reference types in Span apis (dotnet/corefx#38468)
Anirudh Agnihotry [Thu, 13 Jun 2019 22:14:00 +0000 (15:14 -0700)]
Tests for  nullable reference types in Span apis (dotnet/corefx#38468)

Commit migrated from https://github.com/dotnet/corefx/commit/159fbc07c938f5ee6f136c60559ca16dc295d859

5 years agoCorrecting some invalid array json inputs (dotnet/corefx#38323)
Anirudh Agnihotry [Thu, 13 Jun 2019 22:10:13 +0000 (15:10 -0700)]
Correcting some invalid array json inputs (dotnet/corefx#38323)

* correcting some invalid array json inputs

* adding comments and modifiers

* addressing feedback

* correcting issue number

Commit migrated from https://github.com/dotnet/corefx/commit/eaee16b5c9d3e020b5892a28a204ceb5da4d6a4a

5 years agoRemove inbox mark for both packages
Viktor Hofer [Thu, 13 Jun 2019 13:21:00 +0000 (15:21 +0200)]
Remove inbox mark for both packages

Commit migrated from https://github.com/dotnet/corefx/commit/2a26a601ca062223f36bfa0c4e51ea70cfd419f2

5 years agoAdd inbox for xamarin on ref context
Viktor Hofer [Wed, 12 Jun 2019 12:44:11 +0000 (14:44 +0200)]
Add inbox for xamarin on ref context

Commit migrated from https://github.com/dotnet/corefx/commit/1a4c723839585e8ffe82e508bc2a795dfa3fc4db

5 years agoAdd uap test target to ref context
Viktor Hofer [Wed, 12 Jun 2019 08:36:27 +0000 (10:36 +0200)]
Add uap test target to ref context

Commit migrated from https://github.com/dotnet/corefx/commit/5472beffe38d96b39639d57b8993de4064003433

5 years agoMark registration pkg inbox on Xamarin
Viktor Hofer [Wed, 12 Jun 2019 08:26:59 +0000 (10:26 +0200)]
Mark registration pkg inbox on Xamarin

Commit migrated from https://github.com/dotnet/corefx/commit/a57ca7747c2d67f63f5f5bb9eecb0cb4539d7ddc

5 years agoAdd uap configuration to registration tests
Viktor Hofer [Wed, 12 Jun 2019 08:25:42 +0000 (10:25 +0200)]
Add uap configuration to registration tests

Commit migrated from https://github.com/dotnet/corefx/commit/278614e178eaa7a185f8fa5930e5646175ce3fad

5 years agoRemove XamarinTfm support check
Viktor Hofer [Fri, 7 Jun 2019 22:31:07 +0000 (00:31 +0200)]
Remove XamarinTfm support check

Commit migrated from https://github.com/dotnet/corefx/commit/07778aa8dd42b456f1f932f54e0dd2bf3890c597

5 years agoRetarget RefContext and CompRegistration to NS2.1
Viktor Hofer [Tue, 4 Jun 2019 08:45:56 +0000 (10:45 +0200)]
Retarget RefContext and CompRegistration to NS2.1

Commit migrated from https://github.com/dotnet/corefx/commit/97a07058b7cdb4f066fd81562102a44adbde5338

5 years agoMove to up2date macOS pool
Viktor Hofer [Thu, 13 Jun 2019 15:54:11 +0000 (17:54 +0200)]
Move to up2date macOS pool

Commit migrated from https://github.com/dotnet/corefx/commit/6ea902fc02ed698e190fd891416677f51ac3770c

5 years agoChange test matrix and exclude arm64 from PRs
Viktor Hofer [Tue, 11 Jun 2019 21:19:36 +0000 (23:19 +0200)]
Change test matrix and exclude arm64 from PRs

Commit migrated from https://github.com/dotnet/corefx/commit/292042bc9f66778ec3424f394a20e11982e853d5

5 years agoIncrease work item timeout for arm64
Viktor Hofer [Tue, 11 Jun 2019 19:56:45 +0000 (21:56 +0200)]
Increase work item timeout for arm64

Commit migrated from https://github.com/dotnet/corefx/commit/f62a52674e3372d2adcda3e6d43bbc9e881088c3

5 years agoIncrease timeout on Linux
Viktor Hofer [Fri, 7 Jun 2019 15:39:52 +0000 (17:39 +0200)]
Increase timeout on Linux

Commit migrated from https://github.com/dotnet/corefx/commit/24d08259fba225f946a0fa3f0766183f7b019a0d

5 years agoFix stray non-surrogate char handling in TextEncoder (dotnet/corefx#38328)
Abhi Agarwal [Thu, 13 Jun 2019 18:00:18 +0000 (23:30 +0530)]
Fix stray non-surrogate char handling in TextEncoder (dotnet/corefx#38328)

Fixes issue https://github.com/aspnet/AspNetCore/issues/10573

Commit migrated from https://github.com/dotnet/corefx/commit/a741bb2d6b98773123b0d4578ec2a5f654313576

5 years ago[3.0 Bug fix]JsonSerializer.Parse throws for UInt64 backed enum with value -1 (dotnet...
Marco Rossignoli [Thu, 13 Jun 2019 17:10:01 +0000 (19:10 +0200)]
[3.0 Bug fix]JsonSerializer.Parse throws for UInt64 backed enum with value -1 (dotnet/corefx#38373)

* fix ulong enum converter

* save work

* address PR feedback

* add more tests

* remove -1 = Max support for unsigned

* address PR fedback

* update tests

* address PR feedback

* address PR feedback

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/42e11c64d878d5875dbc6f5d228cb034ee4b2e59

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38505)
dotnet-maestro[bot] [Thu, 13 Jun 2019 16:33:31 +0000 (16:33 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38505)

* Update dependencies from https://github.com/dotnet/coreclr build 20190612.2

- Microsoft.NET.Sdk.IL - 3.0.0-preview7.19312.2
- Microsoft.NETCore.ILAsm - 3.0.0-preview7.19312.2
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview7.19312.2

* Fix build errors

Commit migrated from https://github.com/dotnet/corefx/commit/5955ee2583d4509d37ecf55243e9e3c9af128487

5 years agoAdd [DebuggerDisplay] to Json types (dotnet/corefx#38275)
Jeremy Kuhne [Thu, 13 Jun 2019 05:58:08 +0000 (22:58 -0700)]
Add [DebuggerDisplay] to Json types (dotnet/corefx#38275)

* Add [DebuggerDisplay] to Json types

Note that there is an issue with turning the TokenType to string in Utf8JsonReader. Probably reflection related? I've been unable to create a more focused repro.

* Add some simple sanity tests

* Address some feedback.

* Use JsonValueType

Commit migrated from https://github.com/dotnet/corefx/commit/b506d4a4ff6ffe1a1877016811e2266eacc2ebbc

5 years agoAdd nullable annotations to System.Collections ref assembly (dotnet/corefx#38128)
Santiago Fernandez Madero [Thu, 13 Jun 2019 05:33:18 +0000 (00:33 -0500)]
Add nullable annotations to System.Collections ref assembly (dotnet/corefx#38128)

* Add nullable annotations to System.Collections ref assembly

* Run GenAPI again with correct attributes format and output

* Enable nullable to project

* Apply nullable feedback, include attributes and object constraint to notnull

Commit migrated from https://github.com/dotnet/corefx/commit/cc8137ede09cdf16811767a6fb262fb498d85e67

5 years agoDisable Socket_SendReceiveAsync_PropagateToStream_Success test on Windows (dotnet...
Stephen Toub [Thu, 13 Jun 2019 02:19:37 +0000 (22:19 -0400)]
Disable Socket_SendReceiveAsync_PropagateToStream_Success test on Windows (dotnet/corefx#38496)

It's hanging sporadically in CI.

Commit migrated from https://github.com/dotnet/corefx/commit/4d1a20fedc6d99c3dd9192359cad07b19def5cb9

5 years agoUpdating the OS matrix for CI
Jeremy Barton [Thu, 13 Jun 2019 01:39:28 +0000 (18:39 -0700)]
Updating the OS matrix for CI

PRs:
* Remove Debian 8 (not supported in 3.0)
* Add Debian 9 (minimum supported Debian in 3.0)
* Remove openSUSE 42 (end of support this month)
* Add SLES 15 (best upgrade for openSUSE 42)
* Remove Fedora 28 (end of support)
* Add Fedora 29 (best supported version)
* Remove macOS 10.12 (not supported in 3.0, effective end of support)

Full Runs:
* Remove Debian 8 (not supported in 3.0)
* Remove Ubuntu 18.10 (end of support next month)
* Remove openSUSE 42 (end of support this month)
* Remove Fedora 28 (end of support)
* Remove macOS 10.12 (not supported in 3.0, effective end of support)
* Add Windows 10 1903 ("19H1") (current release)

Commit migrated from https://github.com/dotnet/corefx/commit/dda4588873cde2740d15e32749ccfd13eb33db07

5 years agoAdd nullable annotations to System.Runtime.Extensions ref (dotnet/corefx#37905)
Santiago Fernandez Madero [Thu, 13 Jun 2019 01:00:32 +0000 (20:00 -0500)]
Add nullable annotations to System.Runtime.Extensions ref (dotnet/corefx#37905)

* Add nullable annotations to System.Runtime.Extensions ref

* Reflect nullable annotations now with attributes

* Address feedback from API Review

* Fix build errors after re-base

* Fix FrameworkName IEquatable implementation to be oblivous

Commit migrated from https://github.com/dotnet/corefx/commit/8ef985fa7c4fd2333a2d905e3f1f9f93e49c002f

5 years agoExpose and test Timer.ActiveCount
Koundinya Veluri [Mon, 10 Jun 2019 21:24:55 +0000 (14:24 -0700)]
Expose and test Timer.ActiveCount

- Depends on https://github.com/dotnet/coreclr/pull/25061
- Fixes https://github.com/dotnet/corefx/issues/38422

Commit migrated from https://github.com/dotnet/corefx/commit/e2c3de82029f2187b3b0ad36a060e5f7e2ac0e93

5 years agoAdd nullable annotations to System.Runtime.Intrinsics ref assembly (dotnet/corefx...
Santiago Fernandez Madero [Wed, 12 Jun 2019 22:20:28 +0000 (17:20 -0500)]
Add nullable annotations to System.Runtime.Intrinsics ref assembly (dotnet/corefx#37944)

Commit migrated from https://github.com/dotnet/corefx/commit/550c5f5fcc9d5b552be749a1b0c49d6f31e38ade

5 years agoDisable PerformanceCounter_NextValue_ProcessorCounter test (dotnet/corefx#38488)
Stephen Toub [Wed, 12 Jun 2019 19:59:17 +0000 (15:59 -0400)]
Disable PerformanceCounter_NextValue_ProcessorCounter test (dotnet/corefx#38488)

Commit migrated from https://github.com/dotnet/corefx/commit/cb52d275492b968a68245c3fe6ed0324acd5581c

5 years ago[master] Update dependencies from dotnet/arcade (dotnet/corefx#38474)
dotnet-maestro[bot] [Wed, 12 Jun 2019 17:41:32 +0000 (10:41 -0700)]
[master] Update dependencies from dotnet/arcade (dotnet/corefx#38474)

* Update dependencies from https://github.com/dotnet/arcade build 20190611.2

- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19311.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19311.2
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19311.2
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19311.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19311.2
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19311.2
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19311.2
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19311.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19311.2
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19311.2
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19311.2

* Update `where T : object` constraint to be `where T : notnull`

* Update several TODO-NULLABLE comments

Commit migrated from https://github.com/dotnet/corefx/commit/28efaabc4349d11a95f8f31eb932c84f207916ab

5 years agoImprove performance Enumerable.Min() (dotnet/corefx#38393)
Tim [Wed, 12 Jun 2019 16:52:10 +0000 (00:52 +0800)]
Improve performance Enumerable.Min() (dotnet/corefx#38393)

* Fix Enumerable.Min() visit more elements for float sequence leading with NaN. (dotnet/corefx#38392)

* Remove unnecessary comments in tests.

* Use explicit type instead of var.

* Return nullable value instead of valueVal.

Commit migrated from https://github.com/dotnet/corefx/commit/09c7058715b16fe3ec854f5436306b483ddfe16d

5 years agoAdd regression test for SafeSocketHandle getting collected (dotnet/corefx#38471)
Stephen Toub [Wed, 12 Jun 2019 16:48:57 +0000 (12:48 -0400)]
Add regression test for SafeSocketHandle getting collected (dotnet/corefx#38471)

* Add regression test for SafeSocketHandle getting collected

* Uncomment ActiveIssue for Unix

Commit migrated from https://github.com/dotnet/corefx/commit/506700913df9cd22ea13c097cfb2834f8a15677e

5 years agoremoved wrong build instructions for openssl tuning (dotnet/corefx#38458)
Castaneda1914 [Wed, 12 Jun 2019 16:47:47 +0000 (19:47 +0300)]
removed wrong build instructions for openssl tuning (dotnet/corefx#38458)

Commit migrated from https://github.com/dotnet/corefx/commit/28c41fff6f830b8393fd6c7661f33f96aa27f965

5 years agoHPACK fixes and tests (dotnet/corefx#38324)
Cory Nelson [Wed, 12 Jun 2019 16:46:28 +0000 (09:46 -0700)]
HPACK fixes and tests (dotnet/corefx#38324)

* HPACK correctness tests/updates. Resolves dotnet/corefx#31316.

Fixes:
- Fix check allowing out-of-bounds write in IntegerEncoder when an integer requires more than one byte and there is not enough buffer space.
- Encode Content-Type with a "Literal Header Without Indexing -- Indexed Name" rather than with a literal name.

Updates: (ported from ASP.NET HPACK code)
- Dynamic table size update must be the first instruction in the header block. Throw an exception when not the case.
- Throw an exception when we've reached the end of header data and we are still mid-parse.

New:
- Asserts, documentation, and tests for IntegerEncoder and IntegerDecoder.
- Tests to verify HttpClient is correctly encoding the different variants of headers.
- HPackDecoder tests (ported from ASP.NET)

* Address review feedback and fix CI.

* Address review feedback.

* Fix licensing to use ASP.NET's licensing. Add a TPN.

Commit migrated from https://github.com/dotnet/corefx/commit/ed526597f3f0d4653588ba0129fcaf18e2e5a4ef

5 years agoDon't swallow OCE unconditionally (dotnet/corefx#38473)
David Fowler [Wed, 12 Jun 2019 16:09:54 +0000 (09:09 -0700)]
Don't swallow OCE unconditionally (dotnet/corefx#38473)

- Today we swallow OperationCanceledExceptions to avoid throwing if CancelPendingRead/CancelPendingFlush, this unintentionally swallows all exceptions that derive from OperationCancelled that were triggered by the ReadAsync call itself. This change rethrows the error unless we're in that specific case of having called one of those Cancel* methods.
- Added tests and did some other small test cleanup.

Commit migrated from https://github.com/dotnet/corefx/commit/b3d3267abca4ae5bd8d4542a02c08a3173ae1ab9

5 years ago[3.0 System.Text.Json]JsonExtensionData should allow non-JsonElement types during...
Marco Rossignoli [Wed, 12 Jun 2019 15:08:09 +0000 (17:08 +0200)]
[3.0 System.Text.Json]JsonExtensionData should allow non-JsonElement types during serialization (dotnet/corefx#38306)

* fix serialization

* serialize all as dictionary

* address PR feedback

* address PR feedback

* remove redundant test

Commit migrated from https://github.com/dotnet/corefx/commit/4e16caa67a6b15ce270c231720177818f50f1f84

5 years agoAdd AppDomain.CurrentDomain event asserts (dotnet/corefx#38351)
Steve MacLean [Wed, 12 Jun 2019 06:12:34 +0000 (02:12 -0400)]
Add AppDomain.CurrentDomain event asserts (dotnet/corefx#38351)

Add assets related to AppDomain events
Remove ApiCompat workaround

Commit migrated from https://github.com/dotnet/corefx/commit/f5399d9d24536697a3bc36339e13ba085fc28938

5 years agoEnsure JSON TryGetXXX sets values to default if returning false dotnet/corefx#37119...
Christopher Watford [Wed, 12 Jun 2019 06:01:10 +0000 (02:01 -0400)]
Ensure JSON TryGetXXX sets values to default if returning false dotnet/corefx#37119 (dotnet/corefx#37838)

* Add tests to ensure TryGetXXX returns default on false dotnet/corefx#37119

* Ensure TryGetXXX value is default when result is false dotnet/corefx#37119

* Ensure JsonDocument's TryGetXXX use default value on false dotnet/corefx#37119

* Ensure value never leaks on exception path per PR review

- Also use `0` with non-generic default assignments to primitive number types per PR review

Commit migrated from https://github.com/dotnet/corefx/commit/f2c2e2f5907c66f9c4912db55f2cb34923059ea6

5 years agoAdd nullable annotations to System.Runtime (dotnet/corefx#37855)
Santiago Fernandez Madero [Wed, 12 Jun 2019 04:56:16 +0000 (23:56 -0500)]
Add nullable annotations to System.Runtime (dotnet/corefx#37855)

* Add nullable annotations to System.Runtime

* Update to use Nullable property with new compiler

* Fix annotations from API Review

* Address nullable feedback from API Review

* Fix more nullable annotations based on review

* More attributes from review and annotate Uri members

* Enable covariant and contravariant nullable annotation mismatch warnings globally

* Fix build

Commit migrated from https://github.com/dotnet/corefx/commit/aa3a6f2b169a82c44007d84aec57050abd5eeb07

5 years agoUse HTTP Host header for Kerberos auth SPN calculation (dotnet/corefx#38465)
David Shulman [Wed, 12 Jun 2019 02:53:55 +0000 (19:53 -0700)]
Use HTTP Host header for Kerberos auth SPN calculation (dotnet/corefx#38465)

Fixed SocketsHttpHandler so that it will use the request's Host header,
if present, as part of building the Service Principal Name (SPN) when
doing Kerberos authentication. This now matches .NET Framework behavior.

Contributes to dotnet/corefx#34697 and dotnet/corefx#27745

Commit migrated from https://github.com/dotnet/corefx/commit/6cb854630083aac733d5b8001b266b872b56748e

5 years agoAddress System.Runtime and System.Runtime.Extensions nullable feedback (dotnet/corefx...
Santiago Fernandez Madero [Tue, 11 Jun 2019 21:52:22 +0000 (16:52 -0500)]
Address System.Runtime and System.Runtime.Extensions nullable feedback (dotnet/corefx#38459)

* Address System.Runtime and System.Runtime.Extensions nullable feedback

* PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/e3dd986b1ba2ec80bba84aee5a4b4527db087ce2

5 years agoRemove flaky asserts in Marshal.R/WInt16 tests. (dotnet/corefx#38464)
Jeremy Koritzinsky [Tue, 11 Jun 2019 20:56:09 +0000 (13:56 -0700)]
Remove flaky asserts in Marshal.R/WInt16 tests. (dotnet/corefx#38464)

Commit migrated from https://github.com/dotnet/corefx/commit/e02b99b0997ec496873c844b72fccf03b1cca8d5

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38449)
dotnet-maestro[bot] [Tue, 11 Jun 2019 20:02:32 +0000 (13:02 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38449)

* Update dependencies from https://github.com/dotnet/coreclr build 20190610.2

- Microsoft.NET.Sdk.IL - 3.0.0-preview7.19310.2
- Microsoft.NETCore.ILAsm - 3.0.0-preview7.19310.2
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview7.19310.2

* Fix Debug.Print tests after Corelib bug fix

Commit migrated from https://github.com/dotnet/corefx/commit/5ccac16eb797202ce4b7b9e375f769ce31c1005b

5 years agoChange EstablishConnectionAndProcessOneRequestAsync test method to use WhenAllOrAnyFa...
Stephen Toub [Tue, 11 Jun 2019 20:01:14 +0000 (13:01 -0700)]
Change EstablishConnectionAndProcessOneRequestAsync test method to use WhenAllOrAnyFailed (dotnet/corefx#38462)

* Change EstablishConnectionAndProcessOneRequestAsync test method to use WhenAllOrAnyFailed

CI is currently hanging when the client operation fails in a way that the server never hears about the request, and waits forever.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/0b5479dde70fc565c5edefac4259578865496e84

5 years agoProvide more exception details when PlatformDetection.ToVersion fails (dotnet/corefx...
Stephen Toub [Tue, 11 Jun 2019 20:00:42 +0000 (13:00 -0700)]
Provide more exception details when PlatformDetection.ToVersion fails (dotnet/corefx#38463)

Commit migrated from https://github.com/dotnet/corefx/commit/49b6ade10a35e44573da6e851bc09133d5922c0a

5 years agoRemove allocation for empty Activity.Baggage/Tags (dotnet/corefx#38389)
Stephen Toub [Tue, 11 Jun 2019 18:28:40 +0000 (11:28 -0700)]
Remove allocation for empty Activity.Baggage/Tags (dotnet/corefx#38389)

Accessing Activity.Baggage/Tags allocates an enumerable, even when there is no baggage or tags.  This fast-paths the empty case.

Commit migrated from https://github.com/dotnet/corefx/commit/ec93eb4e8a0b225c1bfca093396328e6ba1fe9d2

5 years agoResolves dotnet/corefx#37250. Re-enable tests that dotnet/corefx#38038 resolved....
Cory Nelson [Tue, 11 Jun 2019 18:11:16 +0000 (11:11 -0700)]
Resolves dotnet/corefx#37250. Re-enable tests that dotnet/corefx#38038 resolved. (dotnet/corefx#38461)

Commit migrated from https://github.com/dotnet/corefx/commit/5f5925c0c1a3a87e870db36ca6acce81dedf3bc9

5 years agoFix several comparison issues in ConcurrentBag (dotnet/corefx#38424)
Stephen Toub [Tue, 11 Jun 2019 15:34:32 +0000 (08:34 -0700)]
Fix several comparison issues in ConcurrentBag (dotnet/corefx#38424)

A failed assert now and again in CI highlighted that we weren't properly accounting for overflows in ConcurrentBag.  In a variety of cases we compare the head position to the tail position, e.g. `head < tail` to determine if there are items in the queue, but in some situations when a position is temporarily updated, head can temporarily progress beyond tail, and if it does and wraps around due to overflow, we can end up in a situation where the condition passes even though it shouldn't.  This fixes all of the comparisons to do the subtraction and compare to 0, to avoid the overflow issue.

Separately, TrySteal had an inverted condition that was checking whether the queue contained at least 2 elements rather than checking whether it contained <= 2.  Also fixed that by inverting the check, along with doing the comparison appropriately per the above.

Commit migrated from https://github.com/dotnet/corefx/commit/56496a6dc2583db7ec82e779235813e0b8d32611

5 years agoMake it so GenAPI is only used during online source build (dotnet/corefx#38433)
Eric StJohn [Tue, 11 Jun 2019 15:17:34 +0000 (08:17 -0700)]
Make it so GenAPI is only used during online source build (dotnet/corefx#38433)

Commit migrated from https://github.com/dotnet/corefx/commit/548e58ebe2346c04a3353a53e6d8c64ab38198d0

5 years ago[3.0 Bug fix]Fix JsonSerializer.WriteAsync (dotnet/corefx#38308)
Marco Rossignoli [Tue, 11 Jun 2019 04:56:58 +0000 (06:56 +0200)]
[3.0 Bug fix]Fix JsonSerializer.WriteAsync (dotnet/corefx#38308)

* fix serialization

* create tailored test

* cleanup namespace

* address some feedback

* add poco test

* update test

* simplify loop

Commit migrated from https://github.com/dotnet/corefx/commit/bab7cea4e612c8d0bd13b4a52a2c91ec974f4e96

5 years agoAdd debug state machine tracking to GoAwayFrame_NoPendingStreams_ConnectionClosed...
Stephen Toub [Tue, 11 Jun 2019 03:22:05 +0000 (20:22 -0700)]
Add debug state machine tracking to GoAwayFrame_NoPendingStreams_ConnectionClosed test (dotnet/corefx#38438)

Commit migrated from https://github.com/dotnet/corefx/commit/0b0df51dab6f641e2988846dd6913de2db30789c

5 years agoFix review comments in dotnet/corefx#38280 (dotnet/corefx#38406)
Liudmila Molkova [Tue, 11 Jun 2019 02:09:37 +0000 (19:09 -0700)]
Fix review comments in dotnet/corefx#38280 (dotnet/corefx#38406)

Commit migrated from https://github.com/dotnet/corefx/commit/6d37591d13dd58abc90b7f15b707f605e809be29

5 years agoRework Linux/Kerberos native interop layer (dotnet/corefx#38377)
David Shulman [Tue, 11 Jun 2019 02:06:08 +0000 (19:06 -0700)]
Rework Linux/Kerberos native interop layer (dotnet/corefx#38377)

The latest changes to the System.Net.Security.Native shim layer fixed a lot of important
bugs for Linux Kerberos usage. But this created a new problem since SqlClient ships
in out-of-band NuGet packages separate from the .NET Core runtime. SqlClient builds
out of the CoreFx repo and uses the common source includes for Kerberos authentication.
This created an unexpected dependency on the System.Net.Security.Native shim layer.
The recent changes to these API signatures caused problems with different combinations
of SqlClient NuGet packages and .NET Core 2.x versus .NET Core 3.0.

After discussion with the SqlClient team, we decided to rework the changes to these
native APIs so that they would remain compatible across all .NET Core versions.

Long-term, the plan is to implement dotnet/corefx#36896 to expose a Kerberos API in .NET Core which
could be used by SqlClient and other consumers.

Closes dotnet/corefx#37183
Closes dotnet/corefx#25205

Commit migrated from https://github.com/dotnet/corefx/commit/7f920b2984a97ce8643bc8e64a93e7bd4d8a059e

5 years agoUpdate System.Runtime.Caching owner to Steve (dotnet/corefx#38429)
Hong Li [Tue, 11 Jun 2019 01:01:20 +0000 (18:01 -0700)]
Update System.Runtime.Caching owner to Steve (dotnet/corefx#38429)

Commit migrated from https://github.com/dotnet/corefx/commit/9a42e7974e2cb99cec9cf30058d8681542186e09

5 years agoSome tests imported from Newtonsoft Json (dotnet/corefx#38153)
buyaa-n [Tue, 11 Jun 2019 00:51:30 +0000 (17:51 -0700)]
Some tests imported from Newtonsoft Json (dotnet/corefx#38153)

Tests imported from Newtonsoft Json

Commit migrated from https://github.com/dotnet/corefx/commit/ff6ce7de1c206a5d552d98395b22f47a8eba368e