robertphillips@google.com [Mon, 16 Sep 2013 13:40:12 +0000 (13:40 +0000)]
Revert the revert of 11247, 11250, 11251 and 11279 (Chrome already relies on changes in r11247)
git-svn-id: http://skia.googlecode.com/svn/trunk@11287
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 16 Sep 2013 13:19:11 +0000 (13:19 +0000)]
Revert 11247, 11250, 11251 and 11279 to unblock DEPS roll (https://codereview.chromium.org/
24159002/)
11279 Sanitizing source files in Housekeeper-Nightly - https://code.google.com/p/skia/source/detail?r=11279
11251 More warnings as errors fixes - https://code.google.com/p/skia/source/detail?r=11251
11250 Warnings as errors fix - https://code.google.com/p/skia/source/detail?r=11250
11247 Initial error handling code - https://chromiumcodereview.appspot.com/
23021015
git-svn-id: http://skia.googlecode.com/svn/trunk@11285
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 16 Sep 2013 13:02:52 +0000 (13:02 +0000)]
Split radial_gradients2 GM into two to reproduce its bug.
Android HW rendering seems to be taking the premul-first path, while
Skia takes the interpolate-first path (both SW and HW).
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/
23637008
git-svn-id: http://skia.googlecode.com/svn/trunk@11284
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sun, 15 Sep 2013 07:01:33 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11282
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sun, 15 Sep 2013 02:22:05 +0000 (02:22 +0000)]
Fix mimetype on expectations live-viewer
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@11281
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sun, 15 Sep 2013 02:18:07 +0000 (02:18 +0000)]
Add live Javascript viewer for GM expectations
BUG=skia:1599
This is similar to the live viewer for GM actuals, at
https://skia-autogen.googlecode.com/svn/gm-actual/view.html
It will be the basis for GM expectations analysis as described in bug 1599.
R=rmistry@google.com
Review URL: https://codereview.chromium.org/
23493024
git-svn-id: http://skia.googlecode.com/svn/trunk@11280
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 14 Sep 2013 07:01:34 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11279
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Sep 2013 21:15:17 +0000 (21:15 +0000)]
Rebaseline single GM test: Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release__gradients_local_perspective_pdf-poppler
See http://c128.i.corp.google.com/skia/pixeldiffs/gradients_local_perspective/diffs/
TBR=bsalomon
Review URL: https://codereview.chromium.org/
23457009
git-svn-id: http://skia.googlecode.com/svn/trunk@11278
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Sep 2013 21:06:00 +0000 (21:06 +0000)]
Rebaseline known-bad hairline-gpu GM test on ASAN
Marked as unreviewed and ignore-failure
See http://c128.i.corp.google.com/skia/pixeldiffs/hairmodes/diffs/
TBR=bsalomon
Review URL: https://codereview.chromium.org/
23619053
git-svn-id: http://skia.googlecode.com/svn/trunk@11277
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Sep 2013 20:56:54 +0000 (20:56 +0000)]
Rebaseline GM tests for Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release
See http://c128.i.corp.google.com/skia/pixeldiffs/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/diffs/
TBR=bsalomon
Review URL: https://codereview.chromium.org/
24078010
git-svn-id: http://skia.googlecode.com/svn/trunk@11276
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Sep 2013 20:50:33 +0000 (20:50 +0000)]
Rebaseline known-bad scaled_tilemodes tests on GalaxyNexus
TBR=bsalomon
Review URL: https://codereview.chromium.org/
24038005
git-svn-id: http://skia.googlecode.com/svn/trunk@11275
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Sep 2013 20:41:16 +0000 (20:41 +0000)]
Rebaseline scaled_tilemode_gradient GM tests
See http://c128.i.corp.google.com/skia/pixeldiffs/scaled_tilemode_gradient/diffs/
Review URL: https://codereview.chromium.org/
23661006
git-svn-id: http://skia.googlecode.com/svn/trunk@11273
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Fri, 13 Sep 2013 20:39:50 +0000 (20:39 +0000)]
OK windows, please take my infinity.
BUG=
Review URL: https://codereview.chromium.org/
23526045
git-svn-id: http://skia.googlecode.com/svn/trunk@11272
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Sep 2013 20:36:24 +0000 (20:36 +0000)]
Rebaseline "lighting" GM tests
See diffs at http://c128.i.corp.google.com/skia/pixeldiffs/lighting/diffs/
TBR=bsalomon
Review URL: https://codereview.chromium.org/
23441069
git-svn-id: http://skia.googlecode.com/svn/trunk@11271
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 13 Sep 2013 20:29:55 +0000 (20:29 +0000)]
Whitespace change to test commits.
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
23522045
git-svn-id: http://skia.googlecode.com/svn/trunk@11269
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Fri, 13 Sep 2013 20:11:09 +0000 (20:11 +0000)]
It looks like we're not always running long enough to give the GPU counters time to converge (and possibly the same for CPU too, but GPU is definitely worse off).
This CL changes our convergence logic from
- did the last run take more than x milliseconds?
to
- did the last run take more x milliseconds and are the last two runs within y% of each other?
There's also now an upper limit where we bail out with an error if we haven't yet met the convergence criteria. Keeping the lower bound is important for benches where the constant overhead is much larger than the work done in the loop; without it we'll see T(1 loop) == T(2 loops) and converge way too early.
This CL also exposed that DeferredCanvasBench had a bug: it was running N^2 loops when we told it to run N. (My fault.)
I threw in a couple other linty changes that I'd be happy to split off.
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
23536046
git-svn-id: http://skia.googlecode.com/svn/trunk@11267
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Sep 2013 19:56:14 +0000 (19:56 +0000)]
Speed up GM ~50% by NOT running most renderModes by default
BUG=skia:1566
R=borenet@google.com, bsalomon@google.com
Review URL: https://codereview.chromium.org/
23889030
git-svn-id: http://skia.googlecode.com/svn/trunk@11265
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Fri, 13 Sep 2013 19:52:27 +0000 (19:52 +0000)]
Refactoring: get rid of the SkBenchmark void* parameter.
While I was doing massive sed-ing, I also converted every bench to use DEF_BENCH instead of registering the ugly manual way.
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
23876006
git-svn-id: http://skia.googlecode.com/svn/trunk@11263
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 13 Sep 2013 19:33:42 +0000 (19:33 +0000)]
pdfviewer: do not submit, uploaded for backup, and will be done actually after I refactor the params for functions, to put the char* params in a structure: report errors and warnings in pdf, infrastructure
Review URL: https://codereview.chromium.org/
23902018
git-svn-id: http://skia.googlecode.com/svn/trunk@11262
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Fri, 13 Sep 2013 19:32:43 +0000 (19:32 +0000)]
add a way to get code coverage
BUG=
R=borenet@google.com
Review URL: https://codereview.chromium.org/
23523055
git-svn-id: http://skia.googlecode.com/svn/trunk@11261
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 13 Sep 2013 16:04:49 +0000 (16:04 +0000)]
start to remove lockPixels from bitmapshader
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
23591030
git-svn-id: http://skia.googlecode.com/svn/trunk@11258
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Fri, 13 Sep 2013 15:42:46 +0000 (15:42 +0000)]
Canary build fix
BUG=
R=bsalomon@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
23532068
git-svn-id: http://skia.googlecode.com/svn/trunk@11257
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 13 Sep 2013 15:42:08 +0000 (15:42 +0000)]
N7 Performance trigger rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@11256
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 13 Sep 2013 14:27:54 +0000 (14:27 +0000)]
I don't know what you've been told, rebaselining images never gets old
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23531047
git-svn-id: http://skia.googlecode.com/svn/trunk@11255
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 13 Sep 2013 14:19:53 +0000 (14:19 +0000)]
They're RRRRRrrrrrrreeebaseline!
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23771006
git-svn-id: http://skia.googlecode.com/svn/trunk@11254
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 13 Sep 2013 13:49:18 +0000 (13:49 +0000)]
319 bottles of rebaseline on the wall...
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23629042
git-svn-id: http://skia.googlecode.com/svn/trunk@11252
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 13 Sep 2013 13:13:29 +0000 (13:13 +0000)]
More warnings as errors fixes
git-svn-id: http://skia.googlecode.com/svn/trunk@11251
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 13 Sep 2013 12:54:33 +0000 (12:54 +0000)]
Warnings as errors fix
git-svn-id: http://skia.googlecode.com/svn/trunk@11250
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 13 Sep 2013 12:40:02 +0000 (12:40 +0000)]
Fixed issues found by fuzzer
Last week, the fuzzer found a few numerical issue with filters and I had written some fixes for them. Here are the fixes with some unit tests.
For senorblanco : So I figured out what was asserting when we'd get a 0 width "result" in SkBicubicImageFilter::onFilterImage(). Basically, if the "result" SkBitmap object calls SkBitmap::setConfig() with "width" and/or "height" set to 0, then the SkBitmap object will call SkBitmap::reset(), making the SkBitmap object's config invalid. At this point, calling SkBitmap::getAddr32() will assert, even without attempting to dereference the data pointer, because the SkBitmap's config is invalid. If height is valid, but width is 0, then this call to SkBitmap::getAddr32() happens directly in SkBicubicImageFilter::onFilterImage() a few lines lower and asserts right away.
BUG=
R=senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com
Author: sugoi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
23533042
git-svn-id: http://skia.googlecode.com/svn/trunk@11249
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 13 Sep 2013 12:39:55 +0000 (12:39 +0000)]
Removes uses of unnamed namespace from samplecode.
Skia code prefers static over unnamed namespace.
R=bsalomon@google.com, robertphillips@google.com
Author: tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
23498028
git-svn-id: http://skia.googlecode.com/svn/trunk@11248
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 13 Sep 2013 12:39:34 +0000 (12:39 +0000)]
Initial error handling code
I made it as simple as possible. The impact seems minimal and it should do what's necessary to make this code secure.
BUG=
R=reed@google.com, scroggo@google.com, djsollen@google.com, sugoi@google.com, bsalomon@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
23021015
git-svn-id: http://skia.googlecode.com/svn/trunk@11247
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 13 Sep 2013 12:39:09 +0000 (12:39 +0000)]
ARM Skia NEON patches - 19 - Intrinsics version of the Filter32 routines
BitmapProcState: translate the filtering routines to intrinsics
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://chromiumcodereview.appspot.com/
21915004
git-svn-id: http://skia.googlecode.com/svn/trunk@11246
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 12 Sep 2013 19:50:17 +0000 (19:50 +0000)]
whitespace change to trigger buildbots
Review URL: https://codereview.chromium.org/
23620048
git-svn-id: http://skia.googlecode.com/svn/trunk@11240
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 12 Sep 2013 17:23:21 +0000 (17:23 +0000)]
Rebaseline ANGLE Release bot
(SkipBuildbotRuns)
R=epoger@google.com
BUG=
Review URL: https://codereview.chromium.org/
23851025
git-svn-id: http://skia.googlecode.com/svn/trunk@11227
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 12 Sep 2013 15:59:32 +0000 (15:59 +0000)]
Whitespace change to trigger rebuilds
Review URL: https://codereview.chromium.org/
23523054
git-svn-id: http://skia.googlecode.com/svn/trunk@11224
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 12 Sep 2013 05:37:01 +0000 (05:37 +0000)]
Whitespace commit to trigger the buildbots, and possible downfall of society.
Review URL: https://codereview.chromium.org/
23542031
git-svn-id: http://skia.googlecode.com/svn/trunk@11221
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 11 Sep 2013 21:43:26 +0000 (21:43 +0000)]
The final rebasline?
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23964009
git-svn-id: http://skia.googlecode.com/svn/trunk@11214
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 11 Sep 2013 21:36:56 +0000 (21:36 +0000)]
Rererererebaseline
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23981010
git-svn-id: http://skia.googlecode.com/svn/trunk@11213
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 11 Sep 2013 21:24:00 +0000 (21:24 +0000)]
Did you say rebaseline?
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23964008
git-svn-id: http://skia.googlecode.com/svn/trunk@11212
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 11 Sep 2013 21:11:47 +0000 (21:11 +0000)]
Fresh baselines!
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/
24079005
git-svn-id: http://skia.googlecode.com/svn/trunk@11211
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 11 Sep 2013 20:47:19 +0000 (20:47 +0000)]
More rebaselines due to re-enabling gpu batching.
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23754011
git-svn-id: http://skia.googlecode.com/svn/trunk@11210
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 11 Sep 2013 19:20:12 +0000 (19:20 +0000)]
Rebase after re-enabling GPU batching.
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23546011
git-svn-id: http://skia.googlecode.com/svn/trunk@11208
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 11 Sep 2013 17:31:49 +0000 (17:31 +0000)]
Add README file so git will create empty dir
BUG=skia:1613
(SkipBuildbotRuns)
R=rmistry@google.com
Review URL: https://codereview.chromium.org/
24112002
git-svn-id: http://skia.googlecode.com/svn/trunk@11203
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 11 Sep 2013 16:56:20 +0000 (16:56 +0000)]
various bug fixes.
1. update mac support for md5
2. update default build to be thumb
(SkipBuildbotRuns)
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
23514051
git-svn-id: http://skia.googlecode.com/svn/trunk@11201
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 11 Sep 2013 13:01:27 +0000 (13:01 +0000)]
Ignore the .git directory in sanitize_source_files, remove .git directory...
R=rmistry@google.com
Review URL: https://codereview.chromium.org/
23981006
git-svn-id: http://skia.googlecode.com/svn/trunk@11193
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 11 Sep 2013 07:38:22 +0000 (07:38 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11192
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Tue, 10 Sep 2013 19:51:10 +0000 (19:51 +0000)]
Add explicit double -> SkScalar conversion to fix werror on Windows.
BUG=
Review URL: https://codereview.chromium.org/
23432008
git-svn-id: http://skia.googlecode.com/svn/trunk@11190
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 10 Sep 2013 19:47:01 +0000 (19:47 +0000)]
re-enable GrIODB
R=robertphillips@google.com
BUG=
Review URL: https://codereview.chromium.org/
23542023
git-svn-id: http://skia.googlecode.com/svn/trunk@11189
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Tue, 10 Sep 2013 19:42:07 +0000 (19:42 +0000)]
Add missing dependency to unbreak NOGPU build.
BUG=
Review URL: https://codereview.chromium.org/
23527004
git-svn-id: http://skia.googlecode.com/svn/trunk@11188
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Tue, 10 Sep 2013 19:23:38 +0000 (19:23 +0000)]
Major bench refactoring.
- Use FLAGS_.
- Remove outer repeat loop.
- Tune inner loop automatically.
BUG=skia:1590
R=epoger@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
23478013
git-svn-id: http://skia.googlecode.com/svn/trunk@11187
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 10 Sep 2013 19:12:07 +0000 (19:12 +0000)]
check for --resourcePath in addition to -i to match the --help string
git-svn-id: http://skia.googlecode.com/svn/trunk@11186
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 10 Sep 2013 18:55:27 +0000 (18:55 +0000)]
Rebaseline fontscaler image for Mac 10.8
https://codereview.chromium.org/
23536042/
git-svn-id: http://skia.googlecode.com/svn/trunk@11185
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 10 Sep 2013 18:24:37 +0000 (18:24 +0000)]
Fix for ovals failing on Xoom.
The fallback path for ellipses when we don't have GLSL derivative
instructions was only setting one attribute in the effect stage, but
we use two attributes.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
23514047
git-svn-id: http://skia.googlecode.com/svn/trunk@11184
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 10 Sep 2013 17:37:03 +0000 (17:37 +0000)]
Fix uninitialized string bug
https://codereview.chromium.org/
23499013/
git-svn-id: http://skia.googlecode.com/svn/trunk@11182
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 10 Sep 2013 17:22:43 +0000 (17:22 +0000)]
Fix bench logging for --repeat 1
Addressing https://code.google.com/p/skia/issues/detail?id=1607
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
23923011
git-svn-id: http://skia.googlecode.com/svn/trunk@11181
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 10 Sep 2013 08:49:29 +0000 (08:49 +0000)]
revert experimental r11177
Review URL: https://codereview.chromium.org/
24019006
git-svn-id: http://skia.googlecode.com/svn/trunk@11178
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 10 Sep 2013 07:55:51 +0000 (07:55 +0000)]
experiment: remove 340 of the 664 GM expectations for this platform
BUG=skia:1566
Review URL: https://codereview.chromium.org/
23718007
git-svn-id: http://skia.googlecode.com/svn/trunk@11177
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 10 Sep 2013 07:01:44 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11176
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 23:59:06 +0000 (23:59 +0000)]
stragglers rebaseline. (flakes?)
R=epoger@google.com
BUG=
Review URL: https://codereview.chromium.org/
23904008
git-svn-id: http://skia.googlecode.com/svn/trunk@11175
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 23:48:46 +0000 (23:48 +0000)]
rebaseline cpu configs of scaled_tiledmodes_npot DW bot
R=epoger@google.com, humper@google.com
Review URL: https://codereview.chromium.org/
23548027
git-svn-id: http://skia.googlecode.com/svn/trunk@11174
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 23:42:27 +0000 (23:42 +0000)]
Even more bulk rebaselining
R=epoger@google.com
BUG=
Review URL: https://codereview.chromium.org/
23724025
git-svn-id: http://skia.googlecode.com/svn/trunk@11173
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 20:36:21 +0000 (20:36 +0000)]
More bulk rebaselining. I reviewed all the images, mostly from CLs.
Review URL: https://codereview.chromium.org/
23710019
git-svn-id: http://skia.googlecode.com/svn/trunk@11171
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 9 Sep 2013 20:09:12 +0000 (20:09 +0000)]
Change old PRG to be SkLCGRandom; change new one to SkRandom
The goal here is to get people to start using the new random number
generator, while leaving the old one in place so we don't have to
rebaseline GMs.
R=reed@google.com, bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
23576015
git-svn-id: http://skia.googlecode.com/svn/trunk@11169
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 19:45:23 +0000 (19:45 +0000)]
rebaseline hodge podge
Ran rebaseline.py with no args. Reverted one PDF change that I didn't understand:
Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release__tilemode_gradient_pdf-mac.png
All remaining changes looked equally correct before and after.
Looks like some line snapping flakes in the mix, just rebaseling for now since there is a lot in here to sort through.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23609022
git-svn-id: http://skia.googlecode.com/svn/trunk@11168
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 19:05:13 +0000 (19:05 +0000)]
Third round of GPU gradients
Review URL: https://codereview.chromium.org/
23600019
git-svn-id: http://skia.googlecode.com/svn/trunk@11167
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 18:30:00 +0000 (18:30 +0000)]
More fontscaler rebaselines after test change
Review URL: https://codereview.chromium.org/
23455038
git-svn-id: http://skia.googlecode.com/svn/trunk@11166
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 18:18:45 +0000 (18:18 +0000)]
Second round of GPU gradient rebaselines
Review URL: https://codereview.chromium.org/
23450026
git-svn-id: http://skia.googlecode.com/svn/trunk@11165
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 9 Sep 2013 18:13:41 +0000 (18:13 +0000)]
Committing unreviewed GM expectations generated by r11087: scaled_tilemode_*, scaled_tilemodes_*
BUG=skia:1603
TBR=humper
Review URL: https://codereview.chromium.org/
23757028
git-svn-id: http://skia.googlecode.com/svn/trunk@11164
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 17:45:30 +0000 (17:45 +0000)]
some fontscaler rebaselines
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23856007
git-svn-id: http://skia.googlecode.com/svn/trunk@11163
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 16:26:48 +0000 (16:26 +0000)]
First round of GPU gradient rebaseline
Review URL: https://codereview.chromium.org/
23465012
git-svn-id: http://skia.googlecode.com/svn/trunk@11161
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 16:19:40 +0000 (16:19 +0000)]
Reduce number of glyphs drawn by fontscaler GM to avoid N4 MSAA4 crash
R=reed@google.com
Review URL: https://codereview.chromium.org/
23454017
git-svn-id: http://skia.googlecode.com/svn/trunk@11160
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Sep 2013 15:36:26 +0000 (15:36 +0000)]
Two and three color GPU gradients without textures.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
22854005
git-svn-id: http://skia.googlecode.com/svn/trunk@11158
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 9 Sep 2013 15:24:40 +0000 (15:24 +0000)]
Fix for r11156
Unreviewed.
Review URL: https://codereview.chromium.org/
23498023
git-svn-id: http://skia.googlecode.com/svn/trunk@11157
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 9 Sep 2013 15:13:25 +0000 (15:13 +0000)]
Add viewport CPU and GPU bench_pictures configs
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
23498021
git-svn-id: http://skia.googlecode.com/svn/trunk@11156
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 9 Sep 2013 14:55:37 +0000 (14:55 +0000)]
Improve handling of FF vertex array state
R=robertphillips@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
23542013
git-svn-id: http://skia.googlecode.com/svn/trunk@11154
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 9 Sep 2013 14:20:55 +0000 (14:20 +0000)]
remove SK_IGNORE_IMAGE_PRESCALE flag (no longer used)
git-svn-id: http://skia.googlecode.com/svn/trunk@11153
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 9 Sep 2013 13:42:39 +0000 (13:42 +0000)]
move decision to smash invmatrix into unit-space (for faster repeat/mirror to after the call to possiblyScaleImage(), so we don't confuse that code with a munged matrix. Fixes the scaled_tilemodes gm for HQ
BUG=
R=humper@google.com
Review URL: https://codereview.chromium.org/
23470005
git-svn-id: http://skia.googlecode.com/svn/trunk@11152
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 9 Sep 2013 13:38:37 +0000 (13:38 +0000)]
Remove GrRefCnt.h in favor of SkRefCnt.h
This removes GrRefCnt.h with all its tyepdefs and #defines and just switch them
to the Sk* equivalents.
GrSafeSetNull was promoted to SkSafeSetNull in SkRefCnt.h.
BUG=None
TEST=none, no functional changes.
R=bsalomon@google.com, robertphillips@google.com
Author: tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
23904003
git-svn-id: http://skia.googlecode.com/svn/trunk@11151
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 9 Sep 2013 12:34:40 +0000 (12:34 +0000)]
Whitespace change to trigger rebuilds now that all (hopefully) slaves have been resynced.
git-svn-id: http://skia.googlecode.com/svn/trunk@11150
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 9 Sep 2013 11:40:49 +0000 (11:40 +0000)]
Whitespace change to trigger rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@11149
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 9 Sep 2013 11:30:19 +0000 (11:30 +0000)]
Whitespace change to test emailing on the master.
git-svn-id: http://skia.googlecode.com/svn/trunk@11147
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Sun, 8 Sep 2013 19:36:58 +0000 (19:36 +0000)]
Return canonical logfont size to 64.
This is to fix crbug/277301. With skia:r9057 the canonical logfont size
was set to 2048 in an attempt to get better font metrics. The font size
is now being handled in a cleaner way, so this motivation no longer
exists. However, when the logfont size is large GDI will substitute a
vector font for a bitmap font. This results in incorrect results for
bitmap fonts as they are no longer properly detected by the typeface.
git-svn-id: http://skia.googlecode.com/svn/trunk@11145
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Sat, 7 Sep 2013 16:18:33 +0000 (16:18 +0000)]
Rebaselines for r11137.
https://codereview.chromium.org/
23785005/
git-svn-id: http://skia.googlecode.com/svn/trunk@11144
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 7 Sep 2013 07:01:16 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11143
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Sep 2013 23:13:05 +0000 (23:13 +0000)]
Replace uses of GR_DEBUGCODE by SkDEBUGCODE.
BUG=None
TEST=none, no functional changes.
R=bsalomon@google.com, robertphillips@google.com
Author: tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
23703010
git-svn-id: http://skia.googlecode.com/svn/trunk@11142
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Sep 2013 21:46:30 +0000 (21:46 +0000)]
Remove dead code from libwebp image decoder
R=scroggo@google.com, markkilgard@gmail.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
23480043
git-svn-id: http://skia.googlecode.com/svn/trunk@11141
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Sep 2013 20:19:56 +0000 (20:19 +0000)]
Add a requiresVertexShader method to GrGLEffect
Adds requiresVertexShader to GrGLEffect and updates the necessary
effects to override it and return true. Also reworks GrGLProgram
and GrGLShaderBuilder so the program creates all the GL effects
at the beginning, and determines if it needs a vertex shader before
creating the shader builder.
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/
23471008
git-svn-id: http://skia.googlecode.com/svn/trunk@11140
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 6 Sep 2013 20:08:50 +0000 (20:08 +0000)]
Remove coverage msaa func from android grglinterface setup
git-svn-id: http://skia.googlecode.com/svn/trunk@11139
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Sep 2013 20:00:41 +0000 (20:00 +0000)]
Rip out CSAA support
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
23882009
git-svn-id: http://skia.googlecode.com/svn/trunk@11138
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Sep 2013 19:46:48 +0000 (19:46 +0000)]
Fix for aliasing in device-independent ovals on Nexus 10.
Switch to using two attributes so that dFdx and dFdy generate valid results.
R=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
23992005
git-svn-id: http://skia.googlecode.com/svn/trunk@11137
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Sep 2013 19:05:11 +0000 (19:05 +0000)]
Switch out random number generator for tests, benches, samples.
This change makes tests, benches and samples use the new SkMWCRandom PRNG. GMs will be saved for another time, as they'll require rebaselining.
R=reed@google.com, bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
23653018
git-svn-id: http://skia.googlecode.com/svn/trunk@11136
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Sep 2013 18:57:14 +0000 (18:57 +0000)]
Fallback to GLES context when GL context setup fails at any stage.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
23902015
git-svn-id: http://skia.googlecode.com/svn/trunk@11135
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 6 Sep 2013 18:00:04 +0000 (18:00 +0000)]
Update the freetype backed fonthost to keep the style and fixed width attributes for a font stream.
This fixes a regression in Android when switching from FontHost_android
R=reed@google.com
Review URL: https://codereview.chromium.org/
23966003
git-svn-id: http://skia.googlecode.com/svn/trunk@11134
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 6 Sep 2013 17:26:09 +0000 (17:26 +0000)]
rebaseline.py: add bug-filing URL to error message
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
23968002
git-svn-id: http://skia.googlecode.com/svn/trunk@11133
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 6 Sep 2013 16:57:29 +0000 (16:57 +0000)]
Move oval and rect renderer includes to private interface
R=bsalomon@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
23513016
git-svn-id: http://skia.googlecode.com/svn/trunk@11132
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Sep 2013 15:31:06 +0000 (15:31 +0000)]
alpha threshold bitmap shader
Committed: http://code.google.com/p/skia/source/detail?r=11122
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
23707019
git-svn-id: http://skia.googlecode.com/svn/trunk@11131
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Sep 2013 15:28:01 +0000 (15:28 +0000)]
Update to allow packed depth-stencil on ES3
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
22880023
git-svn-id: http://skia.googlecode.com/svn/trunk@11130
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 6 Sep 2013 14:16:12 +0000 (14:16 +0000)]
Push sigma-based blur interface into our GMs/benches/tests/samplecode
https://codereview.chromium.org/
23701006/
git-svn-id: http://skia.googlecode.com/svn/trunk@11129
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 6 Sep 2013 12:59:50 +0000 (12:59 +0000)]
fix regression in fallback chain where we don't account for the original font style.
This CL also enforces that the language and variant are the same for all fonts
within a given fallback family.
R=reed@google.com
Review URL: https://codereview.chromium.org/
23670009
git-svn-id: http://skia.googlecode.com/svn/trunk@11128
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 6 Sep 2013 12:57:45 +0000 (12:57 +0000)]
move platformConvolutionProcs() call to right before we need it
git-svn-id: http://skia.googlecode.com/svn/trunk@11127
2bbb7eff-a529-9590-31e7-
b0007b416f81