Karol Herbst [Thu, 3 Aug 2023 12:09:37 +0000 (14:09 +0200)]
rusticl/kernel: move things around in lower_and_optimize_nir
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: @LingMan <18294-LingMan@users.noreply.gitlab.freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24470>
Karol Herbst [Thu, 3 Aug 2023 10:59:06 +0000 (12:59 +0200)]
rusticl/kernel: merge lower_and_optimize_nir_pre_inputs and lower_and_optimize_nir_late
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: @LingMan <18294-LingMan@users.noreply.gitlab.freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24470>
Karol Herbst [Thu, 3 Aug 2023 10:18:10 +0000 (12:18 +0200)]
rusticl/kernel: rename res to internal_args inside lower_and_optimize_nir_late
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: @LingMan <18294-LingMan@users.noreply.gitlab.freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24470>
Samuel Pitoiset [Thu, 3 Aug 2023 13:10:08 +0000 (15:10 +0200)]
radv: track if vertex binding stride is dynamic from the cmdbuf state
This allows us to remove one more pipeline occurence during cmdbuf
recording. Note that shader object always uses dynamic vertex input.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24473>
Samuel Pitoiset [Thu, 3 Aug 2023 13:09:47 +0000 (15:09 +0200)]
radv: re-emit binning state if the framebuffer is dirty
This used to depend on the graphics pipeline, but now that everything
is dynamic it should be fine to trigger it on fb changes.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24473>
Samuel Pitoiset [Thu, 3 Aug 2023 13:09:25 +0000 (15:09 +0200)]
radv: track if patch control points is dynamic from the cmdbuf state
This allows us to remove one more pipeline occurence during cmdbuf
recording. Note that patch control points is always dynamic with
shader object.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24473>
Samuel Pitoiset [Thu, 3 Aug 2023 13:09:05 +0000 (15:09 +0200)]
radv: remove redundant check in radv_cmd_buffer_after_draw()
RADV_CMD_FLAG_PS_PARTIAL_FLUSH is only used for draws with
RADV_DEBUG=syncshaders, which implies a valid graphics pipeline.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24473>
Rhys Perry [Tue, 11 Jul 2023 19:29:12 +0000 (20:29 +0100)]
radv: don't set vertex_attribute_strides on GFX8+
Bounds checking no longer compares against the stride.
fossil-db (navi21):
Totals from 5 (0.00% of 133461) affected shaders:
Instrs: 1532 -> 1520 (-0.78%)
CodeSize: 8144 -> 8084 (-0.74%)
Latency: 5104 -> 5102 (-0.04%)
InvThroughput: 686 -> 680 (-0.87%)
VClause: 19 -> 17 (-10.53%)
PreVGPRs: 118 -> 116 (-1.69%)
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24115>
Feng Jiang [Wed, 17 Aug 2022 01:54:09 +0000 (09:54 +0800)]
virgl: Only PIPE_BUFFER with VIRGL_BIND_CUSTOM flag is considered busy during creation
When the virglrenderer performs the attach action for the PIPE_BUFFER
with the VIRGL_BIND_CUSTOM flag, it will synchronize the data from
res->ptr to res->iov, at this time we need to treat it as busy,
otherwise it will cause some race conditions.
This optimizes commit:
fe9333f7b5e ("virgl: Set res->maybe_busy to true when creating resources")
Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18098>
Kenneth Graunke [Thu, 3 Aug 2023 22:24:53 +0000 (15:24 -0700)]
intel/compiler: Fix sparse cube map array coordinate lowering
Brown paper bag fix for my untested review feedback comments.
Cube array images use a coordinate of the form <X, Y, 6*Slice+Face>,
while cube array textures use a <X, Y, Slice, Face> style coordinate.
This code tried to convert one to the other, but instead of writing
Z / 6 and Z % 6, we tried to reuse our original division result. What
we wanted was Z - (Z/6) * 6, but instead we botched it and wrote Z-Z*6
which produced...totally invalid cube faces.
Fixes:
fe81d40bff26 ("intel/nir: add lower for sparse images & textures")
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24481>
Biswapriyo Nath [Thu, 3 Aug 2023 06:14:09 +0000 (11:44 +0530)]
radv/video: Match function definitions to declarations
This adds the same function attributes from definitions to declarations
and fixes the following compiler errors for 32 bit Windows OS.
../src/amd/vulkan/radv_video.c:270:1: error: conflicting types for 'radv_CreateVideoSessionKHR'
src/amd/vulkan/radv_entrypoints.h:3963:34: note: previous declaration of 'radv_CreateVideoSessionKHR'
../src/amd/vulkan/radv_video.c:319:1: error: conflicting types for 'radv_DestroyVideoSessionKHR'
src/amd/vulkan/radv_entrypoints.h:3971:30: note: previous declaration of 'radv_DestroyVideoSessionKHR'
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24460>
Eric Engestrom [Tue, 20 Jun 2023 13:42:01 +0000 (14:42 +0100)]
bin/pick-ui: use venv wrapper
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24367>
Eric Engestrom [Fri, 28 Jul 2023 12:47:06 +0000 (13:47 +0100)]
bin/ci/update_traces_checksum: use venv wrapper
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24367>
Eric Engestrom [Fri, 28 Jul 2023 12:45:40 +0000 (13:45 +0100)]
bin/ci/gitlab_gql: use venv wrapper
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24367>
Eric Engestrom [Wed, 3 May 2023 16:52:57 +0000 (17:52 +0100)]
bin/ci/ci_run_n_monitor: use venv wrapper
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24367>
Eric Engestrom [Wed, 3 May 2023 16:52:57 +0000 (17:52 +0100)]
bin: add wrapper to run scripts in a python venv
This isolates the script environment from the rest of the machine,
avoiding missing/incompatible dependencies and avoiding polluting the
rest of the machine with python packages.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24367>
Alyssa Rosenzweig [Wed, 2 Aug 2023 15:35:54 +0000 (11:35 -0400)]
nir: Simplify alu_instr_is_copy
mov is considered vec.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Wed, 2 Aug 2023 14:19:33 +0000 (10:19 -0400)]
nir: Drop no-op all_srcs_are_ssa
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Wed, 2 Aug 2023 14:15:21 +0000 (10:15 -0400)]
nir: Remove no-op remove_def_cb
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Wed, 2 Aug 2023 14:14:33 +0000 (10:14 -0400)]
lima: Clean up after deleting asserts
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 18:49:58 +0000 (14:49 -0400)]
nir: Remove nir_foreach_def
Leftover.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Wed, 2 Aug 2023 17:01:09 +0000 (13:01 -0400)]
nir: Remove nir_alu_dest::write_mask
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Wed, 2 Aug 2023 14:24:59 +0000 (10:24 -0400)]
ntt: Evaluate write_mask check
In light of the input necessarily being SSA.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 18:40:38 +0000 (14:40 -0400)]
intel/vec4: Don't use legacy write mask
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Wed, 2 Aug 2023 19:30:56 +0000 (15:30 -0400)]
etnaviv: What if we just didn't have a compiler?
alyssa: please no.
etnaviv: ok but we'll just not run nir_validate so it's fine.
alyssa: please no.
etnaviv: ok but we have ci now so you have to keep it working.
alyssa: please no.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 18:38:57 +0000 (14:38 -0400)]
etnaviv: Don't use alu->dest.write_mask
Just plug n chug tbh all of this code is bad.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 18:25:24 +0000 (14:25 -0400)]
rogue: Stop reading write masks
Scalar SSA.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 18:22:08 +0000 (14:22 -0400)]
ir3: Drop write_mask handling
It's all scalar SSA.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 17:47:00 +0000 (13:47 -0400)]
nir/from_ssa: Remove pointless union
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Suggested-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:50:24 +0000 (12:50 -0400)]
nir: Drop nir_register
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Thu, 3 Aug 2023 19:11:26 +0000 (15:11 -0400)]
nir: Remove nir_{src,dest}::is_ssa
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:45:29 +0000 (12:45 -0400)]
nir: Collapse more SSA checks
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Thu, 3 Aug 2023 19:15:49 +0000 (15:15 -0400)]
nir: Initialize source as a NULL SSA def
This keeps src_is_valid working without depending on registers.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:43:05 +0000 (12:43 -0400)]
nir: Do not init dests
There is no sensible way to do this. It is a hard requirement that the dest is
initialized with nir_ssa_dest_init immediately after creating the instruction.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:38:26 +0000 (12:38 -0400)]
nir: Remove def_is_register
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:33:53 +0000 (12:33 -0400)]
nir: Collapse more SSA checks
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:33:31 +0000 (12:33 -0400)]
nir/instr_set: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:31:54 +0000 (12:31 -0400)]
treewide: Collapse more SSA checks
Via Coccinelle patch:
@@
expression x;
@@
-if (x->is_ssa) {
...
-}
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:31:21 +0000 (12:31 -0400)]
nir/range_analysis: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:31:06 +0000 (12:31 -0400)]
nir/worklist: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:30:31 +0000 (12:30 -0400)]
nir/gather_ssa_types: Collapse SSA checks
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:27:30 +0000 (12:27 -0400)]
radeonsi: Collapse SSA check
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:27:09 +0000 (12:27 -0400)]
lima: Collapse is_ssa checks
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:26:02 +0000 (12:26 -0400)]
ir3: Collapse is_ssa checks
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:25:24 +0000 (12:25 -0400)]
llvmpipe: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:24:31 +0000 (12:24 -0400)]
intel: Collapse is_ssa checks
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:22:21 +0000 (12:22 -0400)]
aco: Remove is_ssa check
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:17:17 +0000 (12:17 -0400)]
nir: Drop trivial reg handling
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:13:17 +0000 (12:13 -0400)]
treewide: Drop some is_ssa if's
Via Coccinelle patch:
@@
expression x;
@@
-if (!x.is_ssa) {
-...
-}
and likewise with x->is_ssa, with invalid hunks manually filtered out.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:10:24 +0000 (12:10 -0400)]
pan/mdg: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:07:25 +0000 (12:07 -0400)]
treewide: sed out more is_ssa
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:55:12 +0000 (11:55 -0400)]
nir: Drop nir_alu_src::{negate,abs}
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:51:55 +0000 (11:51 -0400)]
nir/print: Drop legacy NIR
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:46:42 +0000 (11:46 -0400)]
nir: Remove stale todo
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:45:49 +0000 (11:45 -0400)]
nir: Remove reg-only dest manipulation
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:36:45 +0000 (11:36 -0400)]
treewide: Remove more is_ssa asserts
Stuff Coccinelle missed.
sed -i -e '/assert(.*\.is_ssa)/d' $(git grep -l is_ssa)
sed -i -e '/ASSERT.*\.is_ssa)/d' $(git grep -l is_ssa)
+ a manual fixup to restore the assert for parallel copy lowering.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:29:43 +0000 (11:29 -0400)]
nir: Collapse some SSA checks
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:17:24 +0000 (11:17 -0400)]
treewide: Drop is_ssa asserts
We only see SSA now.
Via Coccinelle patch:
@@
expression x;
@@
-assert(x.is_ssa);
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:05:53 +0000 (11:05 -0400)]
nir: Remove nir_alu_dest::saturate
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:03:10 +0000 (11:03 -0400)]
nir: Remove impl->{registers,reg_alloc}
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:02:13 +0000 (11:02 -0400)]
nir/validate: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:00:23 +0000 (11:00 -0400)]
nir/serialize: Drop legacy NIR
Assume SSA, no modifiers.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:55:28 +0000 (10:55 -0400)]
nir/clone: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:53:43 +0000 (10:53 -0400)]
nir/print: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:52:04 +0000 (10:52 -0400)]
ntt: Drop nir_register reference
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:51:04 +0000 (10:51 -0400)]
nir: remove nir_{src,dest}_for_reg
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:49:48 +0000 (10:49 -0400)]
nir: Remove nir_foreach_register
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:49:23 +0000 (10:49 -0400)]
nir/schedule: Drop more nir_register handling
No-op.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:48:27 +0000 (10:48 -0400)]
nir: Remove nir_index_local_regs and callers
With no registers seen, it is now a no-op.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:46:53 +0000 (10:46 -0400)]
nir: Drop NIR reg create/destroy
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:38:47 +0000 (10:38 -0400)]
nir/schedule: Drop nir_schedule_dest_pressure
Unused.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:36:56 +0000 (10:36 -0400)]
nir/from_ssa: Drop legacy reg support
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 19:00:41 +0000 (15:00 -0400)]
nir: Add {...} before case
Will prevent a clang regression.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Yonggang Luo [Wed, 2 Aug 2023 11:24:14 +0000 (19:24 +0800)]
intel/compiler,intel/blorp,intel/vulkan: decouple vulkan driver and compiler from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
Yonggang Luo [Wed, 2 Aug 2023 11:41:53 +0000 (19:41 +0800)]
crocus: #include "program/prog_instruction.h" for SWIZZLE_*
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
Yonggang Luo [Wed, 2 Aug 2023 11:36:27 +0000 (19:36 +0800)]
intel/brw: Define and use BRW_SWIZZLE_* instead of SWIZZLE_*
This is for avoid #include "program/prog_instrunction.h" in intel/brw code
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
Yonggang Luo [Wed, 2 Aug 2023 11:12:12 +0000 (19:12 +0800)]
intel/blorp: brw_sampler_prog_key_data::swizzles is only and should only accessed in crocus
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
Yonggang Luo [Wed, 2 Aug 2023 11:10:49 +0000 (19:10 +0800)]
intel/blorp: Use float directly to avoid #include "mesa/main/format_utils.h"
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
Yonggang Luo [Wed, 2 Aug 2023 07:08:33 +0000 (15:08 +0800)]
compiler: Move WRITEMASK_* from prog_instruction.h into shader_enums.h
Because both compiler/glsl/* and intel/compiler accessed it, so do the move
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
David Heidelberg [Thu, 3 Aug 2023 05:11:07 +0000 (08:11 +0300)]
bin/ci: handle errors more gracefully in update_traces_checksum script
UnicodeDecodeError is present very often, since GitLab logs are scary.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24444>
Faith Ekstrand [Wed, 2 Aug 2023 16:58:38 +0000 (11:58 -0500)]
nir/builder: Don't assume we have compiler options
We use nir_builder a variety of places where we may not yet have
back-end compiler options such as for building meta shaders. Don't
assume we always have an options struct.
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24459>
xurui [Fri, 28 Jul 2023 07:57:10 +0000 (15:57 +0800)]
glx: There is no need to psc++
Signed-off-by: xurui <xurui@kylinos.cn>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24360>
Felix DeGrood [Fri, 7 Jul 2023 17:15:01 +0000 (17:15 +0000)]
anv: debug messaging for sparse texture usage
Enable sparse debug messages with INTEL_DEBUG=sparse
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24046>
Felix DeGrood [Fri, 7 Jul 2023 17:48:00 +0000 (17:48 +0000)]
anv: enable fake sparse for Elden Ring
Elden Ring requires sparse support to be advertised but does not
use the feature. Enable fake sparse support for Elden Ring through
dri-conf.
This change fixes Elden Ring on Intel graphics.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24046>
Felix DeGrood [Fri, 7 Jul 2023 20:21:01 +0000 (20:21 +0000)]
anv: add fake sparse support
Some DX12 games require sparse resource support but don't
actually use sparse resources. Add a way to make these games work
while we still don't have sparse resources fully working on every
KMD backend.
When fake_sparse=true, anv advertises sparse resource support
despite lacking full support.
Based-on-patch-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24046>
Yonggang Luo [Sun, 4 Jun 2023 20:46:32 +0000 (04:46 +0800)]
asahi: decouple layout from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24465>
Yonggang Luo [Sun, 4 Jun 2023 20:46:07 +0000 (04:46 +0800)]
etnaviv: decouple drm from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24465>
Eric Engestrom [Thu, 3 Aug 2023 14:54:27 +0000 (15:54 +0100)]
docs/ci: expand the description of test suites
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24472>
Eric Engestrom [Thu, 3 Aug 2023 13:13:02 +0000 (14:13 +0100)]
docs/ci: drop mention of build systems variants in the CI
We managed to get rid of all the other ones, so let's forget about them
now :P
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24472>
Eric Engestrom [Thu, 3 Aug 2023 13:13:02 +0000 (14:13 +0100)]
docs/ci: in paragraph about the CI being overwhelmed, mention our tool to help with that
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24472>
Eric Engestrom [Thu, 3 Aug 2023 13:13:02 +0000 (14:13 +0100)]
docs/ci: stop trying to enumerate drivers that are tested using VK-GL-CTS
Most of our drivers are tested by now.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24472>
Eric Engestrom [Wed, 2 Aug 2023 15:48:53 +0000 (16:48 +0100)]
ci: include some timing information in the git cache download script
In https://gitlab.freedesktop.org/zmike/mesa/-/jobs/
46476087 it is unclear
whether this script is where 30+ minutes were lost, or if this ran fine and
the `git clone` afterwards is where the issue was.
Printing these timestamps will help next time something like this happens.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24452>
David Heidelberg [Tue, 1 Aug 2023 20:40:39 +0000 (23:40 +0300)]
docs/ci: remove default nginx config, which we don't need for proxy
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24445>
David Heidelberg [Tue, 1 Aug 2023 20:39:37 +0000 (23:39 +0300)]
docs/ci: update to systemd and used version of the trace for testing
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24445>
David Heidelberg [Tue, 1 Aug 2023 20:37:46 +0000 (23:37 +0300)]
docs/ci: default to port 80 for the caching proxy
Also use `caching-proxy` as a name which is automatically
generated from `NFS_SERVER_IP`.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24445>
David Heidelberg [Thu, 3 Aug 2023 12:22:53 +0000 (15:22 +0300)]
ci/amd: fix timeouting radeonsi-raven-va-full job
LAVA needs to know that job will run more than default 30 minutes.
Fixes:
ae9c67d773a7 ("ci/amd: add radeonsi-raven-va-full job to cover all VA-API tests")
Reviewed-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24469>
David Rosca [Sun, 30 Jul 2023 10:55:16 +0000 (12:55 +0200)]
radeonsi: Enable PIPE_VIDEO_CAP_SUPPORTS_CONTIGUOUS_PLANES_MAP
This is needed for vaDeriveImage to map multi-plane surfaces.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7947
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24389>
David Rosca [Sun, 30 Jul 2023 10:39:15 +0000 (12:39 +0200)]
radeonsi: Copy all planes with multi-plane staging textures
Multi-plane format textures are allocated as a single buffer
for all planes, so when mapping first plane it will map
all planes.
However, when staging texture is used, only the first
plane will be available.
When asked to map first plane of multi-plane texture,
create a staging texture with matching multi-plane format
and copy all planes on map/unmap.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24389>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:22:39 +0000 (12:22 -0400)]
zink: Collapse is_ssa check
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24471>
Alyssa Rosenzweig [Tue, 1 Aug 2023 18:14:13 +0000 (14:14 -0400)]
vc4,broadcom/compiler: Drop write_mask handling
There's no legacy register support so we ncessarily write a contiguous vector.
In other words, the write_mask is of the form `(1 << x) - 1`. Meanwhile this
code asserts the write mask is of the form (1 << x)`. Putting it together the
write mask is necessarily always 0x1, writing out a single scalar.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24471>
projects / platform / upstream / mesa.git / log