profile/ivi/pulseaudio.git
13 years agosink: Fix lazy commenting
Arun Raghavan [Mon, 15 Aug 2011 05:53:59 +0000 (11:23 +0530)]
sink: Fix lazy commenting

13 years agopactl: Add a set-sink-formats command
Arun Raghavan [Mon, 15 Aug 2011 04:17:09 +0000 (09:47 +0530)]
pactl: Add a set-sink-formats command

This uses the module-device-restore protocol extension to save formats
on sinks that support it.

13 years agoformat: Add string to pa_format_info conversion function
Arun Raghavan [Fri, 12 Aug 2011 16:25:48 +0000 (21:55 +0530)]
format: Add string to pa_format_info conversion function

This will help accept string formats from the command like (so we can
set formats using pactl).

13 years agoformat: Make pa_format_info_snprint() more parseable
Arun Raghavan [Fri, 12 Aug 2011 15:34:38 +0000 (21:04 +0530)]
format: Make pa_format_info_snprint() more parseable

Removes the comma as the proplist separator since that makes
pa_proplist_from_string() break and prints only the encoding if there
are no properties (instead of "<encoding>, (no properties)").

13 years agodevice-restore: Set sink format when possible
Arun Raghavan [Fri, 12 Aug 2011 14:57:34 +0000 (20:27 +0530)]
device-restore: Set sink format when possible

This implements the actual setting of sink formats when a new sink is
added or when the set of available formats changes.

13 years agodevice-restore: Make bools not be bit fields
Arun Raghavan [Fri, 12 Aug 2011 14:03:41 +0000 (19:33 +0530)]
device-restore: Make bools not be bit fields

This makes the pa_bool_t members of userdata not be a single bit field
since pa_bool_t can be an int, potentially causing signedness issues in
comparisons.

13 years agoalsa: Implement get/set_formats()
Arun Raghavan [Fri, 12 Aug 2011 11:06:00 +0000 (16:36 +0530)]
alsa: Implement get/set_formats()

This implements the sink get_formats() and set_formats() API in
alsa-sink. Modules can use this to allow users to specify what formats
their receivers support.

13 years agosink: Add a set_formats() API
Arun Raghavan [Fri, 12 Aug 2011 11:04:28 +0000 (16:34 +0530)]
sink: Add a set_formats() API

This adds API to let external sources specify what formats a sink
supports. Sinks must opt-in to allow this, and can perform some
validation if required.

13 years agoPlug some memory leaks and an invalid read
Maarten Bosmans [Thu, 11 Aug 2011 22:17:39 +0000 (00:17 +0200)]
Plug some memory leaks and an invalid read

Note in protocol-dbus.c specifically, method_signatures needs to be freed
before method_handlers, because otherwise h->method_name is freed while it is
still in use as a key in the method_signatures hashmap.

13 years agosink-input: Drop redundant assert (PA_SINK_INPUT_IS_LINKED() checked already)
Colin Guthrie [Thu, 11 Aug 2011 15:51:52 +0000 (17:51 +0200)]
sink-input: Drop redundant assert (PA_SINK_INPUT_IS_LINKED() checked already)

13 years agolog: Add missing pulsecore/thread.h include
Arun Raghavan [Fri, 12 Aug 2011 14:29:19 +0000 (19:59 +0530)]
log: Add missing pulsecore/thread.h include

13 years agoi18n: po file fixes
Lu Guanqun [Thu, 11 Aug 2011 16:07:26 +0000 (00:07 +0800)]
i18n: po file fixes

Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
13 years agoalsa: resets POLLOUT event
Wang Xingchao [Fri, 5 Aug 2011 14:33:17 +0000 (10:33 -0400)]
alsa: resets POLLOUT event

revents marked as POLLOUT|POLLERR|POLLWRNORM in "underrun" case that will
trigger unexpected log "ALSA woke us up to write new data to the device, but
there was acturally nothing to write...".

This patch avoids this log message.

13 years agoalsa: Update process_usec before going to sleep
Wang Xingchao [Tue, 9 Aug 2011 14:14:40 +0000 (10:14 -0400)]
alsa: Update process_usec before going to sleep

During check_left_to_play/record(), the watermark may increase/decrease. So before
sleeping, update the actural sleep time based on latest watermark.

13 years agoMove i18n.[ch] to src/pulsecore
Maarten Bosmans [Wed, 10 Aug 2011 08:30:15 +0000 (10:30 +0200)]
Move i18n.[ch] to src/pulsecore

The header is used in files troughout the tree and is not included in the public api,
so it belongs in pulsecore, not in pulse.

13 years agoAdd some missing format.h includes
Maarten Bosmans [Wed, 10 Aug 2011 08:30:14 +0000 (10:30 +0200)]
Add some missing format.h includes

13 years agoInclude config.h consistently in source files and not in headers
Maarten Bosmans [Wed, 10 Aug 2011 08:30:13 +0000 (10:30 +0200)]
Include config.h consistently in source files and not in headers

13 years agosample-util: use built-in function
Lu Guanqun [Wed, 10 Aug 2011 15:12:12 +0000 (23:12 +0800)]
sample-util: use built-in function

use built-in function pa_frame_aligned().

Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
13 years agoext-device-restore: Include format.h
Colin Guthrie [Wed, 10 Aug 2011 11:16:28 +0000 (13:16 +0200)]
ext-device-restore: Include format.h

13 years agoalsa: Ensure that volumes are written to the h/w at startup.
Colin Guthrie [Wed, 10 Aug 2011 08:39:57 +0000 (10:39 +0200)]
alsa: Ensure that volumes are written to the h/w at startup.

If the device support SYNC_VOLUMES then we need to do an additional push
to get the actual change on to the h/w.

13 years agoalsa-mixer: Fix rounding direction on mixer initialisation
Colin Guthrie [Mon, 18 Jul 2011 09:48:25 +0000 (10:48 +0100)]
alsa-mixer: Fix rounding direction on mixer initialisation

13 years agopactl: Make stat backwards compatible with previous versions.
Colin Guthrie [Tue, 9 Aug 2011 14:29:30 +0000 (16:29 +0200)]
pactl: Make stat backwards compatible with previous versions.

This is not ideal but in order to aid people using it in scripts
etc, we will maintain backwards compatibiliy here.

Also add a 'short' mode and mention in the man page that this
will ultimately become the default at some point in the future.

13 years agopactl: Split help string up in shorter pieces for easier translation
Maarten Bosmans [Sat, 6 Aug 2011 10:29:53 +0000 (12:29 +0200)]
pactl: Split help string up in shorter pieces for easier translation

13 years agopactl: Short --help output a bit by consolidating sink/source commands
Maarten Bosmans [Sat, 6 Aug 2011 10:29:52 +0000 (12:29 +0200)]
pactl: Short --help output a bit by consolidating sink/source commands

13 years agopactl: Update manpage
Maarten Bosmans [Sat, 6 Aug 2011 10:29:51 +0000 (12:29 +0200)]
pactl: Update manpage

13 years agolog: add thread name
Lu Guanqun [Mon, 8 Aug 2011 02:24:13 +0000 (10:24 +0800)]
log: add thread name

This patch displays thread name in the log, that would be more descriptive.
It improves Xingchao (xingchao.wang@intel.com)'s patch which shows thread id.

Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
13 years agodevice-restore: Various fixes for the protocol extension.
Colin Guthrie [Mon, 8 Aug 2011 21:29:47 +0000 (23:29 +0200)]
device-restore: Various fixes for the protocol extension.

 * Fix extension API function export list.
 * Ensure we trigger a subscription event when things change.
 * Send the index with our subscription events.
 * Clear out any existing formats when saving.
 * Call the correct extension command for subscriptions.

13 years agoFix default.pa on non udev systems
Maarten Bosmans [Fri, 5 Aug 2011 13:33:48 +0000 (15:33 +0200)]
Fix default.pa on non udev systems

13 years agostream-restore: Save/restore source output volume/mute
Colin Guthrie [Sat, 6 Aug 2011 23:08:28 +0000 (01:08 +0200)]
stream-restore: Save/restore source output volume/mute

13 years agosource-output: Fix resampling.
Colin Guthrie [Sat, 6 Aug 2011 21:05:27 +0000 (23:05 +0200)]
source-output: Fix resampling.

When recording, we need to reverse the order of sample specs
(origin<->destination) from the sink code this was copied form.

13 years agoDocument PA_COMMAND_UNDERFLOW protocol change
David Henningsson [Thu, 4 Aug 2011 08:33:54 +0000 (10:33 +0200)]
Document PA_COMMAND_UNDERFLOW protocol change

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
13 years agoFix crash in path subset elimination
David Henningsson [Thu, 4 Aug 2011 09:13:37 +0000 (11:13 +0200)]
Fix crash in path subset elimination

As reported in http://kpaste.net/04f1f3f
it is possible to call enumeration_is_subset with null pointers.
Handle that case instead of crashing. (It is also possible that
Tanuk's pending element_is_subset patch solves the issue, but this
nevertheless gives some extra security.)

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
13 years agobuild-sys: bump soname
Colin Guthrie [Tue, 2 Aug 2011 14:56:50 +0000 (15:56 +0100)]
build-sys: bump soname

13 years agoprotocol-native: Allow clients to know at what index underrun occurred
David Henningsson [Tue, 2 Aug 2011 12:34:20 +0000 (14:34 +0200)]
protocol-native: Allow clients to know at what index underrun occurred

This patch introduces some extra protocol information, so protocol
version is bumped. This functionality is primarily needed to solve
a long standing issue in alsa-plugins, which should ignore underruns
if and only if it is obsolete, i e, if more data has been written to
the pipe in the meantime (which will automatically end the underrun).

BugLink: http://bugs.launchpad.net/bugs/805940
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
13 years agoman: add manpage for start-pulseaudio-kde and start-pulseaudio-x11
Daniel Schaal [Sat, 2 Jul 2011 19:17:43 +0000 (21:17 +0200)]
man: add manpage for start-pulseaudio-kde and start-pulseaudio-x11

13 years agobuild-sys: Check for necessary programs in bootstrap.sh
Maarten Bosmans [Wed, 27 Jul 2011 12:13:53 +0000 (14:13 +0200)]
build-sys: Check for necessary programs in bootstrap.sh

Also use glib-gettextize instead of plain gettextize.

13 years agodoc: Document subscription events better
Arun Raghavan [Wed, 27 Jul 2011 16:21:01 +0000 (21:51 +0530)]
doc: Document subscription events better

Add an explanation and some example code to make it easier for people
writing client-side code to figure out how subscription events work.

13 years agorygel: Fix introspection XML for MediaItem2
Jens Georg [Fri, 22 Jul 2011 16:25:57 +0000 (18:25 +0200)]
rygel: Fix introspection XML for MediaItem2

13 years agorygel: Properly close {sv} iters for GetAll
Jens Georg [Fri, 22 Jul 2011 16:00:13 +0000 (18:00 +0200)]
rygel: Properly close {sv} iters for GetAll

This fixes browsing the PA Sink and Source container.

13 years agovirtual: Fix volume callback setting.
Tanu Kaskinen [Thu, 21 Jul 2011 03:50:56 +0000 (06:50 +0300)]
virtual: Fix volume callback setting.

We want to set the volume callbacks only if volume sharing
is not used. When volume sharing is used, we don't want to
mess with the stream volumes.

This was broken in 6c6b50

13 years agoreserve: Fix compile warning when compiling without dbus
Colin Guthrie [Sun, 17 Jul 2011 17:14:52 +0000 (18:14 +0100)]
reserve: Fix compile warning when compiling without dbus

13 years agoalsa-mixer: Remove workaround for USB head/handsets
Colin Guthrie [Thu, 7 Jul 2011 09:42:35 +0000 (10:42 +0100)]
alsa-mixer: Remove workaround for USB head/handsets

Now that subset mixer paths are removed, this workaround is no longer needed.

This effectively reverts 1c38b5d4787d9466bd7bd5910d27e501298ec778 but due
to me forgetting to add files and adding a couple extra workarounds after,
it's easier to just do this manually rather than run git-revert.

13 years agoalsa: No need to go via sink/source to get the core.
Colin Guthrie [Thu, 7 Jul 2011 09:37:25 +0000 (10:37 +0100)]
alsa: No need to go via sink/source to get the core.

13 years agoalsa-mixer: Detect and then drop pointless paths in the path set.
Colin Guthrie [Sat, 2 Jul 2011 17:14:48 +0000 (18:14 +0100)]
alsa-mixer: Detect and then drop pointless paths in the path set.

In order to try and avoid 'spamming' the user with port choices,
attempt to detect and remove any pointless paths in a path set. That is
any paths which are subsets of other paths.

This should solve a problem case with some USB Headsets which result in
two paths both involving the 'Speaker' element. When no 'Master' element
exists (which is quite common on head/handsets), then the first path
(analog-output) will contain the 'Speaker' in a way that completely fits
with in the use of the 'Speaker' element in the other path
(analog-output-speaker).

13 years agoalsa-mixer: Do not 'unify' mixer paths.
Colin Guthrie [Sat, 2 Jul 2011 15:29:00 +0000 (16:29 +0100)]
alsa-mixer: Do not 'unify' mixer paths.

Unification is really just a 'lowest common denominator' system. If any
paths do not support volume, mute or decibels, then mark them all as not
having them.

This was originally done this way because the flags set on sinks that
dictate if it supports h/w volume, mute etc. could not be changed after
the sink was created.

The fact that these flags could not change has now been change in the
previous commits, and thus there is now no need to use this 'lowest
common denominator' approach as we can fully support the various
different combinations, even if they change after initial creation
of the sinks/source.

13 years agoalsa: Reinitialise the mixer on port change.
Colin Guthrie [Sat, 2 Jul 2011 15:23:01 +0000 (16:23 +0100)]
alsa: Reinitialise the mixer on port change.

This allows us to flip from software to hardware volume control as the port's
mixer path dictates.

13 years agodevices: Set certain sink/source flags automatically.
Colin Guthrie [Tue, 5 Jul 2011 22:44:06 +0000 (23:44 +0100)]
devices: Set certain sink/source flags automatically.

Some sink flags are really just a product of what callbacks
are set on the device. We still enforce a degree of sanity
that the flags match the callbacks set, but we also set the
flags automatically in our callback setter functions to
help ensure that a) people use them and b) flags & callbacks
are kept in sync.

13 years agodevices: Use wrapper functions to set the *_volume and *_mute callbacks.
Colin Guthrie [Sun, 17 Jul 2011 14:29:29 +0000 (15:29 +0100)]
devices: Use wrapper functions to set the *_volume and *_mute callbacks.

This is not currently useful but future commits will make further
changes concerning automatic setting of flags and event delivery
that makes this structure necessary.

13 years agoFix two comment typos.
Ralph Giles [Thu, 14 Jul 2011 20:59:38 +0000 (13:59 -0700)]
Fix two comment typos.

13 years agoprotocol-native: Trivial fix for a compiler warning
Arun Raghavan [Tue, 12 Jul 2011 21:46:21 +0000 (14:46 -0700)]
protocol-native: Trivial fix for a compiler warning

13 years agopadsp: Handle eol in info callbacks correctly
Arun Raghavan [Tue, 12 Jul 2011 03:59:30 +0000 (20:59 -0700)]
padsp: Handle eol in info callbacks correctly

When receiving an eol, the object will be NULL and we're not handling
this correctly. Thanks to Drew Ogle <dantealiegri@gmail.com> for
reporting this and providing a patch.

13 years agoprotocol-native: Fix invalid assert
Arun Raghavan [Tue, 12 Jul 2011 03:52:41 +0000 (20:52 -0700)]
protocol-native: Fix invalid assert

For source and sinks, we allow both the index and name to be invalid
while introspecting (the default source/sink will be used). This
modifies the assert appropriately. Thanks to Drew Ogle
<dantealiegri@gmail.com> for reporting and providing a patch.

13 years agoprotocol-native: Fix backward compatibility break
Arun Raghavan [Sun, 10 Jul 2011 01:27:45 +0000 (18:27 -0700)]
protocol-native: Fix backward compatibility break

This makes sure we don't perform a check on record stream volumes for
clients that don't support them.

13 years agoecho-cancel: Set sane defaults for module initialisation
Arun Raghavan [Sat, 9 Jul 2011 19:55:18 +0000 (12:55 -0700)]
echo-cancel: Set sane defaults for module initialisation

This picks sane defaults for the sample spec used (32 kHz, mono) and
preprocessing (on by default). This should make it unncessary to provide
additional parameters in the default desktop case.

The main exception would be decreasing the sample rate for hardware with
limited processing power (can bring it down to 16 or 8 kHz).

13 years agomodule-waveout: Correctly handle mono volume controls on waveout device
Maarten Bosmans [Sat, 2 Jul 2011 10:12:43 +0000 (12:12 +0200)]
module-waveout: Correctly handle mono volume controls on waveout device

13 years agobuild-sys: equalizer-sink needs DBus aswell as FFTW
Colin Guthrie [Thu, 30 Jun 2011 10:58:30 +0000 (11:58 +0100)]
build-sys: equalizer-sink needs DBus aswell as FFTW

13 years agobuild-sys: Fix handling of Bluez, Hal dependency on D-Bus
Maarten Bosmans [Wed, 29 Jun 2011 13:16:12 +0000 (15:16 +0200)]
build-sys: Fix handling of Bluez, Hal dependency on D-Bus

13 years agobuild-sys: Add more build-time conditionals to config files
Maarten Bosmans [Wed, 29 Jun 2011 13:16:11 +0000 (15:16 +0200)]
build-sys: Add more build-time conditionals to config files

13 years agobuild-sys: Process configuration files with m4
Maarten Bosmans [Wed, 29 Jun 2011 13:16:10 +0000 (15:16 +0200)]
build-sys: Process configuration files with m4

This allows for build-time conditionals to be processed,
eliminating the need for a separate default.pa.win32.

13 years agobuild-sys: Use configure AC_OUTPUT to process config files
Maarten Bosmans [Wed, 29 Jun 2011 13:16:09 +0000 (15:16 +0200)]
build-sys: Use configure AC_OUTPUT to process config files

Don't use sed to replace @variable@ in file.in.

13 years agobuild-sys: Move some more defines to configure.ac
Maarten Bosmans [Wed, 29 Jun 2011 13:16:08 +0000 (15:16 +0200)]
build-sys: Move some more defines to configure.ac

13 years agoalsa-sink: fix mmap_write() work_done
Wu Fengguang [Tue, 28 Jun 2011 16:57:33 +0000 (09:57 -0700)]
alsa-sink: fix mmap_write() work_done

mmap_write() work_done is wrongly initilized to TRUE. It ends up never
being FALSE. Fix it to reduce the costly update_smoother() calls.

13 years agoparecord: Automatically detect file format from extension
Maarten Bosmans [Sun, 26 Jun 2011 23:19:07 +0000 (01:19 +0200)]
parecord: Automatically detect file format from extension

And fix a small bug in pa_sndfile_format_from_string.

13 years agobuild-sys: look for function 'backtrace' also in library 'ubacktrace'
Henning Heinold [Sun, 22 May 2011 21:02:44 +0000 (23:02 +0200)]
build-sys: look for function 'backtrace' also in library 'ubacktrace'

Using OpenEmbedded with 'minimal-uclibc' for 'MACHINE = "beagleboard"'
compilation fails with the following error [1].

        […]
          CCLD   pulseaudio
        ./.libs/libpulsecommon-0.9.22.so: undefined reference to `backtrace_symbols'
        ./.libs/libpulsecommon-0.9.22.so: undefined reference to `backtrace'
        collect2: ld returned 1 exit status
        make[3]: *** [pulseaudio] Error 1

Using uClibc 'backtrace' is in the library 'ubacktrace' and needs to be
searched in there. This patch is used successfully in OpenEmbedded[2].

[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032979.html
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=0086e0506eb4939150bb50ec337d7f6787b8ae8a

13 years agoalsa-mixer: Whoops, forgot to git-add this in a previous.
Colin Guthrie [Sun, 26 Jun 2011 13:51:31 +0000 (14:51 +0100)]
alsa-mixer: Whoops, forgot to git-add this in a previous.

13 years agoalsa-mixer: Add UAC1.0 Sennheiser Dongle to the usb-headset profile.
Colin Guthrie [Sun, 26 Jun 2011 13:22:06 +0000 (14:22 +0100)]
alsa-mixer: Add UAC1.0 Sennheiser Dongle to the usb-headset profile.

Reported by Sean McNamara

13 years agobuild-sys: Move some more defines from CFLAGS to config.h
Maarten Bosmans [Sat, 25 Jun 2011 14:36:08 +0000 (16:36 +0200)]
build-sys: Move some more defines from CFLAGS to config.h

13 years agobuild-sys: Use AX_DEFINE_DIR macro instead of setting AM_CFLAGS
Maarten Bosmans [Sat, 25 Jun 2011 14:36:07 +0000 (16:36 +0200)]
build-sys: Use AX_DEFINE_DIR macro instead of setting AM_CFLAGS

This makes the compiler command line a bit shorter, useful for compiling with make V=1.

13 years agobuild-sys: Use ax_check_flag macros from autoconf archive
Maarten Bosmans [Sat, 25 Jun 2011 14:36:06 +0000 (16:36 +0200)]
build-sys: Use ax_check_flag macros from autoconf archive

Those macros cover almost all functionality of attributes.m4 that was
used, so that file can be removed.
The CC_NOUNDEFINED macro is used directly in configure.ac.

13 years agoalsa-mixer: Add an mixer profile exception for a BT Agile handset
Colin Guthrie [Sat, 25 Jun 2011 12:02:02 +0000 (13:02 +0100)]
alsa-mixer: Add an mixer profile exception for a BT Agile handset

13 years agoalsa-mixer: Add workaround for some USB headsets
David Henningsson [Tue, 5 Apr 2011 09:37:59 +0000 (11:37 +0200)]
alsa-mixer: Add workaround for some USB headsets

This is a workaround - these usb headsets have one output volume
control only, labeled "Speaker". This causes the default profile
set to not control the volume at all, which is a bug. Workaround
that by creating a separate profile set.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
13 years agobuild-sys: Update orc.m4 to latest upstream version
Maarten Bosmans [Thu, 23 Jun 2011 20:21:06 +0000 (22:21 +0200)]
build-sys: Update orc.m4 to latest upstream version

ORCC is now correctly set to orcc on build system instead of host for cross-compiling

13 years agoRemove libpulse-browse and pabrowse
Maarten Bosmans [Thu, 23 Jun 2011 20:21:05 +0000 (22:21 +0200)]
Remove libpulse-browse and pabrowse

13 years agoUpdate todo
Maarten Bosmans [Thu, 23 Jun 2011 20:21:04 +0000 (22:21 +0200)]
Update todo

13 years agowin32: Make some unused-variable warnings go away
Maarten Bosmans [Thu, 23 Jun 2011 20:21:03 +0000 (22:21 +0200)]
win32: Make some unused-variable warnings go away

13 years agowin32: Make once-test work
Maarten Bosmans [Thu, 23 Jun 2011 20:21:02 +0000 (22:21 +0200)]
win32: Make once-test work

The barrier is not used when pthread is not available.

13 years agobuild-sys: Cleanup Makefile.am
Maarten Bosmans [Thu, 23 Jun 2011 20:21:01 +0000 (22:21 +0200)]
build-sys: Cleanup Makefile.am

No need to keep some tests in two lists.

13 years agoAdd sys/time.h include to rtclock.c
Maarten Bosmans [Thu, 23 Jun 2011 20:21:00 +0000 (22:21 +0200)]
Add sys/time.h include to rtclock.c

Cross-compiling for win32 failed after the previous #include removal.
Somehow when building for Linux the struct timeval definition got picked up elsewhere.

13 years agoRemove obsolete description property from modules
Maarten Bosmans [Tue, 29 Mar 2011 20:40:49 +0000 (22:40 +0200)]
Remove obsolete description property from modules

13 years agobuild-sys: bump soname
Colin Guthrie [Thu, 23 Jun 2011 20:22:19 +0000 (21:22 +0100)]
build-sys: bump soname

13 years agoraop: Change socket buffer size handling to avoid playback underruns
Bryan Gleeson [Fri, 10 Jun 2011 20:02:20 +0000 (13:02 -0700)]
raop: Change socket buffer size handling to avoid playback underruns

When a TCP socket is created the size of the send buffer (SO_SNDBUF) used is
determined by the OS, using the net.ipv4.tcp_wmem sysctl parameter. Previously
a call to setsockopt set the buffer size to a value that was too small, and
that in some cases could result in underruns and choppy playback. This
setsockopt call has now been removed so that the value determined by the OS
is used unchanged.

Note that the value used for the send buffer size is the 2nd value in
net.ipv4.tcp_wmem, e.g. if this is set to "4096 65536 8388608" the send buffer
size is set to 65536.

13 years agoRemove unnecessary #includes
Maarten Bosmans [Mon, 13 Jun 2011 13:04:33 +0000 (15:04 +0200)]
Remove unnecessary #includes

13 years agodatabase: Support legacy format database entries.
Colin Guthrie [Tue, 7 Jun 2011 23:47:19 +0000 (00:47 +0100)]
database: Support legacy format database entries.

This adds code to specifically support legacy entries.
I kept this code in a separate commit so that it can be (relatively)
easily removed at some point in the future.

13 years agodevice-restore: Add a new protocol extension for device-restore.
Colin Guthrie [Tue, 7 Jun 2011 10:18:17 +0000 (12:18 +0200)]
device-restore: Add a new protocol extension for device-restore.

This simply exposes the formats that a device supports
via a simple protocol extension that will allow clients
to setup what a connected receiver supports format wise.

13 years agodatabase: Convert our use of database files to save in tagstruct format.
Colin Guthrie [Tue, 7 Jun 2011 22:21:04 +0000 (23:21 +0100)]
database: Convert our use of database files to save in tagstruct format.

This has the advantage of allowing versioned updates in the future,
thus allowing us to be more user friendly going forward (as opposed
to just ignoring entries from old versions).

The primary motivation for this, however, is to allow variable length
storage in each entry which will be needed for upcoming work.

At present this commit will ignore any legacy entries but support
for reading and subsequently converting legacy entries will be added
shortly.

13 years agoesound,streams: Fix some crashes.
Colin Guthrie [Wed, 8 Jun 2011 19:18:12 +0000 (20:18 +0100)]
esound,streams: Fix some crashes.

After the rework to the add pa_sink_input_new_data_set_sink() (and
the source equiv) calling with a NULL sink object will hit an assert.

This caused crashes with the esd protocol and there was the potential
(albeit unlikely) for a crash when creating a sink input without any
sinks available (module-always-sink mitigates this risk but it's still
a potential crasher).

13 years agopactl: Add a set-source-output-volume command
Arun Raghavan [Sun, 22 May 2011 07:41:30 +0000 (13:11 +0530)]
pactl: Add a set-source-output-volume command

13 years agosource-output: Trivial code move
Arun Raghavan [Sun, 22 May 2011 07:41:02 +0000 (13:11 +0530)]
source-output: Trivial code move

Makes diff'ing with sink-input.c easier

13 years agocapture: Remove support for synchronised capture streams.
Colin Guthrie [Fri, 20 May 2011 07:33:56 +0000 (08:33 +0100)]
capture: Remove support for synchronised capture streams.

This was added to ensure symmetry between playback and recording streams
code, but in reality this makes little sense practically speaking and thus
it is removed.

13 years agoalsa-mixer: select nearest alsa volume step in sync-volume mode
Juho Hämäläinen [Mon, 20 Dec 2010 16:25:59 +0000 (18:25 +0200)]
alsa-mixer: select nearest alsa volume step in sync-volume mode

13 years agoalsa-mixer: When setting hw volume, always round up with playback and down with capture.
Colin Guthrie [Sun, 8 May 2011 11:44:50 +0000 (12:44 +0100)]
alsa-mixer: When setting hw volume, always round up with playback and down with capture.

The previous logic in ade0a6f88464d8aecf83982d400ccfc402341920
does not work with for input volumes.

This was discussed on the mailing list:

https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-May/010091.html

This approach can introduce a problem when setting the volumes
for sources. What follows is Tanu Kaskinen's analysis:

[quote]
I'll quote the log:

D: protocol-native.c: Client pavucontrol changes volume of source alsa_input.pci-0000_00_1b.0.analog-stereo.
D: alsa-source.c: Requested volume: 0:  45% 1:  45%
D: alsa-source.c:            in dB: 0: -20.71 dB 1: -20.71 dB
D: alsa-source.c: Got hardware volume: 0:  45% 1:  45%
D: alsa-source.c:               in dB: 0: -21.00 dB 1: -21.00 dB
D: alsa-source.c: Calculated software volume: 0: 101% 1: 101% (accurate-enough=no)
D: alsa-source.c:                      in dB: 0: 0.29 dB 1: 0.29 dB
D: source.c: Volume going up to 29273 at 270475970821
D: source.c: Volume change to 29273 at 270475970821 was written 34 usec late
D: alsa-source.c: Written HW volume did not match with the request: 0: 45% 1:  45% (request) != 0:  42% 1:  42%
D: alsa-source.c:                                            in dB: 0: -21.00 dB 1: -21.00 dB (request) != 0: -22.50 dB 1: -22.50 dB

Looking at the last line, the requested volume seems to hit exactly the
right step (-21.00dB), but for some reason Alsa decides to choose
something else. I'm pretty sure that this happens because of rounding
errors. In the first phase we ask Alsa what dB value we should set, and
it returns -21.00 dB. The value is given as a long int, but we convert
that to pa_cvolume. Then when we set the volume, we convert the
pa_cvolume value back to a long integer. At this point I believe it gets
converted to -2101. This is not visible in the debug message for some
reason - the rounding algorithm must be different from what was used
with the pa_cvolume -> long conversion.
[/quote]

The commit after this contains a patch that addresses this issue.

13 years agostreams: Tidy up includes
Colin Guthrie [Wed, 11 May 2011 10:54:04 +0000 (11:54 +0100)]
streams: Tidy up includes

13 years agoalsa: Remove unneeded include
Colin Guthrie [Wed, 11 May 2011 10:53:23 +0000 (11:53 +0100)]
alsa: Remove unneeded include

13 years agointrospect: Get format of source output
Colin Guthrie [Mon, 16 May 2011 21:23:24 +0000 (22:23 +0100)]
introspect: Get format of source output

This gets the negotiated format of source outputs in
pa_context_get_source_output*(). Also prints the format and volume
in 'pactl list'.

13 years agocapture: Implement per-stream volume control for capture streams.
Colin Guthrie [Tue, 17 May 2011 21:31:10 +0000 (22:31 +0100)]
capture: Implement per-stream volume control for capture streams.

This piggy backs onto the previous changes for protocol 22 and
thus does not bump the version. This and the previous commits should be
seen as mostly atomic. Apologies for any bisecting issues this causes
(although I would expect these to be minimal)

13 years agointrospect: Get formats for sources
Colin Guthrie [Mon, 16 May 2011 21:15:57 +0000 (22:15 +0100)]
introspect: Get formats for sources

This gets the list of supported formats for a source in
pa_context_get_source_info*(). Also prints these in 'pactl list'.

13 years agocapture: Add the passthrough format negotiation to capture streams.
Colin Guthrie [Tue, 17 May 2011 20:56:10 +0000 (21:56 +0100)]
capture: Add the passthrough format negotiation to capture streams.

This helps to keep the API more symmetrical and also potentially
allows support for passthrough monitor sources at some point in the future.

13 years agodef: Add some flags for source outputs.
Colin Guthrie [Tue, 17 May 2011 20:48:29 +0000 (21:48 +0100)]
def: Add some flags for source outputs.

These flags will be required in upcoming work to integrate format and volume
support for source outputs.

13 years agointrospect: Clear out memory properly on error.
Colin Guthrie [Mon, 16 May 2011 21:14:48 +0000 (22:14 +0100)]
introspect: Clear out memory properly on error.

13 years agoalsa-sink: Some trivial tidyups
Colin Guthrie [Tue, 17 May 2011 18:50:32 +0000 (19:50 +0100)]
alsa-sink: Some trivial tidyups

Mostly typo fixes but also a change to make a function relating
to sink inputs use more generic variable names.