Shraddha Barke [Fri, 11 Sep 2015 05:10:59 +0000 (10:40 +0530)]
Staging: rtl8188eu: os_dep: osdep_service.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:58 +0000 (10:40 +0530)]
Staging: rtl8188eu: os_dep: mlme_linux.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:57 +0000 (10:40 +0530)]
Staging: rtl8188eu: os_dep: recv_linux.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:56 +0000 (10:40 +0530)]
Staging: rtl8188eu: hal: rtl8188eu_xmit.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:55 +0000 (10:40 +0530)]
Staging: rtl8188eu: hal: Hal8188ERateAdaptive.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:54 +0000 (10:40 +0530)]
Staging: rtl8188eu: hal: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:39:26 +0000 (11:09 +0530)]
Staging: lustre: obdclass: genops.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:39:25 +0000 (11:09 +0530)]
Staging: lustre: obdclass: obd_config.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:39:24 +0000 (11:09 +0530)]
Staging: lustre: libcfs: libcfs_mem.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:39:23 +0000 (11:09 +0530)]
Staging: lustre: libcfs: libcfs_lock.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:53 +0000 (10:40 +0530)]
Staging: rtl8188eu: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:52 +0000 (10:40 +0530)]
Staging: rtl8188eu: core: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 06:02:28 +0000 (11:32 +0530)]
Staging: speakup: kobjects.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 06:02:27 +0000 (11:32 +0530)]
Staging: speakup: serialio.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 06:02:26 +0000 (11:32 +0530)]
Staging: speakup: devsynth.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 06:02:29 +0000 (11:32 +0530)]
Staging: speakup: varhandlers.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:32:41 +0000 (22:02 +0530)]
Staging: comedi: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 10 Sep 2015 07:16:33 +0000 (23:16 -0800)]
Staging: rtl8192u: space prohibited before close parenthesis
This is a style change to remove whitespace before close parentheses in
ieee80211_softmac_wx.c
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 10 Sep 2015 07:16:28 +0000 (23:16 -0800)]
Staging: rtl8192u: space required after close braces
This is a style change to insert spaces before closed braces in
ieee80211_softmac_wx.c
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 10 Sep 2015 07:16:21 +0000 (23:16 -0800)]
Staging: rtl8192u: space required before open braces
This is a change to add spaces before open braces to
ieee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 10 Sep 2015 07:16:13 +0000 (23:16 -0800)]
Staging: rtl8192u: Space not allowed after &
This is a change to ieee80211_softmac_wx.c to remove spaces after unary
& operators.
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 03:32:58 +0000 (09:02 +0530)]
Staging: rtl8192u: ieee80211: ieee80211_softmac.c: Replace "#include <asm/uaccess>" with "#include <linux/uaccess>"
Fix checkpatch.pl warning "Use #include <linux/uaccess.h>
instead of <asm/uaccess.h>"
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 03:32:59 +0000 (09:02 +0530)]
Staging: rtl8192u: ieee80211: ieee80211_module.c: Replace "#include <asm/uaccess>" with "#include <linux/uaccess>"
Fix checkpatch.pl warning "Use #include <linux/uaccess.h>
instead of <asm/uaccess.h>"
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 03:32:57 +0000 (09:02 +0530)]
Staging: rtl8192u: ieee80211: Replace "#include <asm/uaccess>" with "#include <linux/uaccess>"
Fix checkpatch.pl warning "Use #include <linux/uaccess.h> instead of
<asm/uaccess.h>"
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alexander Kuleshov [Fri, 11 Sep 2015 18:22:15 +0000 (00:22 +0600)]
staging/dgap: Use strpbrk() instead of dgap_sindex()
The <linux/string.h> provides strpbrk() function that does
the same that the dgap_sindex(). Let's use already defined
function instead of writing custom.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Junesung Lee [Sat, 12 Sep 2015 00:58:47 +0000 (09:58 +0900)]
staging: android: fix typo
'syncrhronization' is wrong spell. 'synchronization' is correct.
Signed-off-by: Junesung Lee <junesoung412@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 10 Sep 2015 11:54:59 +0000 (17:24 +0530)]
staging: dgap: remove unused variable
These variables were assigned some values but they were never used.
Removed them but kept one call to ioread8() as it might affect the
hardware.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 10 Sep 2015 11:54:58 +0000 (17:24 +0530)]
staging: dgap: fix possible NULL dereference
The return pointer from dgap_getword() is used in strcmp() where it is
dereferenced. But dgap_getword() can return NULL.
Lets put a check there and return 0 as error.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sakshi Vaid [Thu, 10 Sep 2015 17:05:10 +0000 (22:35 +0530)]
staging: lustre: lustre: obdclass: Fixed space checkpatch
Removed the space between function name and open parenthesis '('.
Signed-off-by: Sakshi Vaid <sakshivaid95@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:32:40 +0000 (22:02 +0530)]
Staging: lustre: ptlrpc: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:30:31 +0000 (22:00 +0530)]
Staging: lustre: libcfs: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Wed, 9 Sep 2015 22:57:10 +0000 (15:57 -0700)]
staging/rtl8712 : Remove duplicated BIT() definitions
The BIT() macro is already defined in bitops.h,
remove duplicate definitions.
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Wed, 9 Sep 2015 22:57:08 +0000 (15:57 -0700)]
staging/rtl8712 : Remove unused macro definitions.
WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN
are unused, duplicate or unnecessary, remove.
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Wed, 9 Sep 2015 22:57:07 +0000 (15:57 -0700)]
staging/rtl8188eu : Remove unused macro definitions.
WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN
are unused, duplicate or unnecessary, remove.
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:30:29 +0000 (22:00 +0530)]
Staging: iio: addac: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:30:30 +0000 (22:00 +0530)]
Staging: iio: meter: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:32:39 +0000 (22:02 +0530)]
Staging: iio: cdc: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 11 Sep 2015 03:04:20 +0000 (12:04 +0900)]
staging: wilc1000: coreconfigurator.c: remove unused functions
This patch removes following unused funtions which will not be used anymore.
ascii_hex_to_dec
get_hex_char
extract_mac_addr
create_mac_addr
conv_ip_to_int
conv_int_to_ip
get_wid_type
get_type
CreateConfigPacket
ConfigWaitResponse
ConfigProvideResponse
ConfigPktReceived
ParseWriteResponse
CreatePacketHeader
ParseResponse
ProcessBinWid
ProcessAdrWid
ProcessStrWid
ProcessIPwid
ProcessIntWid
ProcessShortWid
ProcessCharWid
As a result, four global variable causes defined but not used compile warnings.
So just remove unused varialbs g_seqno, g_wid_num, Res_Len and g_oper_mode.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 10 Sep 2015 09:26:29 +0000 (18:26 +0900)]
staging: wilc1000: remove unused enum
This patch removes a unused enum tenuFrameClass.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Thu, 10 Sep 2015 09:26:28 +0000 (18:26 +0900)]
staging: wilc1000: remove unused global variables
This patch removes the followings from the driver because they are in
debugging purpose but not used anymore.
- int_clrd
- int_rcvdU
- int_rcvdB
- android_wifi_priv_cmd structure
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Thu, 10 Sep 2015 09:26:27 +0000 (18:26 +0900)]
staging: wilc1000: remove firmware definition
This patch removes the firmware definitions, STA_FIRMWARE, AP_FIRMWARE, and
P2P_CONCURRENCY_FIRMWARE from the linux_wlan.c file because they are
defined in the Makefile.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Thu, 10 Sep 2015 09:26:26 +0000 (18:26 +0900)]
staging: wilc1000: remove STATIC_MACADDRESS
This patch removes unused definition, STATIC_MACADDRESS from the
linux_wlan.c file.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 03:33:01 +0000 (09:03 +0530)]
Staging: wilc1000: Replace "#include <asm/uaccess>" with "#include <linux/uaccess>"
Fix checkpatch.pl warning "Use #include <linux/uaccess.h>
instead of <asm/uaccess.h>"
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 10 Sep 2015 03:03:05 +0000 (12:03 +0900)]
staging: wilc1000: delete wilc_memory.c and wilc_memory.h
The macro WILC_MALLOC is not used in the driver anymore, so just
delete files.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 10 Sep 2015 03:03:04 +0000 (12:03 +0900)]
staging: wilc1000: remove kmalloc wrapper
This patch calls kmalloc() directly. No need to wrap kmalloc().
All is not holding a spin lock or in interrupt context. So use GFP_KERNEL
flag for kmalloc.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Thu, 10 Sep 2015 02:59:11 +0000 (11:59 +0900)]
staging: wilc1000: remove BROKEN status
This patch removes BROKEN status from the Kconfig.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Mon, 7 Sep 2015 14:28:23 +0000 (19:58 +0530)]
Staging: comedi: addi_apci_3120: Remove unnecessary if
Remove the if condition, as the code inside the if condition is
commented and does not have any FIXME or TODO comment.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Raphaël Beamonte [Sun, 6 Sep 2015 02:15:12 +0000 (22:15 -0400)]
staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue
Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
are __aligned(2)
The values used are stored as dev_addr in net_device (declared in
include/linux/netdevice.h) and sa_data in sockaddr (declared in
include/linux/socket.h). Both these elements are u16 aligned as
shown by using pahole (position must be a multiple of sizeof(u16)):
unsigned char * dev_addr; /* 888 8 */
char sa_data[14]; /* 2 14 */
It is thus safe to use ether_addr_copy() instead of memcpy() for
that call, as it is already done in multiple files in the Linux
kernel sources:
drivers/net/ethernet/broadcom/genet/bcmgenet.c
drivers/net/ethernet/brocade/bna/bnad.c
drivers/net/ethernet/emulex/benet/be_main.c
drivers/net/ethernet/ezchip/nps_enet.c
drivers/net/ethernet/ibm/ibmveth.c
drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
drivers/net/ethernet/intel/i40e/i40e_main.c
drivers/net/ethernet/mellanox/mlx5/core/en_main.c
drivers/net/usb/lan78xx.c
net/8021q/vlan_dev.c
net/batman-adv/soft-interface.c
net/dsa/slave.c
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Mon, 7 Sep 2015 12:38:22 +0000 (18:08 +0530)]
staging: gdm72xx: NULL comparison style
checkpatch complains if NULL comparison is done as if (var == NULL)
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Mon, 7 Sep 2015 12:38:21 +0000 (18:08 +0530)]
staging: gdm72xx: fix memory leak
We were successfully requesting the firmware but on error it was not
being released.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Sat, 5 Sep 2015 13:43:44 +0000 (19:13 +0530)]
staging: fbtft: do not use magic numbers
Using magic numbers are not good coding practise. Use
FBTFT_GPIO_NAME_SIZE as defined in the header files.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Sat, 5 Sep 2015 13:43:43 +0000 (19:13 +0530)]
staging: fbtft: use strncpy instead of strcpy
Using strcpy() is a security risk as the destination buffer size is not
checked and we may over-run the buffer. Use strncpy() instead, while
mentioning the buffer size leaving place for the NULL termination.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 5 Sep 2015 13:28:28 +0000 (18:58 +0530)]
Staging: rtl8192e: rtl_wx.c: Remove braces for single statement blocks
The linux kernel coding style discourages use of braces for single
statement blocks. This patch removes the unnecessary braces.
The warning was detected using checkpatch.pl. Coccinelle was used to
make the change.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 5 Sep 2015 13:28:27 +0000 (18:58 +0530)]
Staging: speakup: Remove braces for single statement blocks
The linux kernel coding style discourages use of braces for single
statement blocks. This patch removes the unnecessary braces.
The warning was detected using checkpatch.pl. Coccinelle was used to
make the change.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 5 Sep 2015 13:28:26 +0000 (18:58 +0530)]
Staging: android: Remove unnecessary braces.
The linux kernel coding style discourages use of braces for single
statement blocks. This patch removes the unnecessary braces.
The warning was detected using checkpatch.pl. Coccinelle was used
to make the change.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 5 Sep 2015 13:28:19 +0000 (18:58 +0530)]
Staging: rtl8723au: hal: Remove braces for single statement blocks
The linux kernel coding style discourages use of braces for single
statement blocks. This patch removes the unnecessary braces.
The error was detected using checkpatch.pl. Coccinelle was used
to make the change.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Fri, 4 Sep 2015 21:00:30 +0000 (14:00 -0700)]
staging/wlan-ng : Remove duplicated defines from p80211
ETH_ALEN/ETH_HLEN can be used instead of
WLAN_ETHADDR_LEN & WLAN_ETHHDR_LEN, replace directly or
use eth_addr* functions where applicable.
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nayeemahmed Badebade [Fri, 4 Sep 2015 17:00:33 +0000 (22:30 +0530)]
Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues
Fixed coding style issues where kernel types u16,u64,u32 should
be preferred over uint16_t,uint64_t,uint32_t
Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ravi Teja Darbha [Tue, 8 Sep 2015 15:48:51 +0000 (21:18 +0530)]
staging: emxx_udc: Remove unused parameter from function parameter list parameter list
struct nbu2ss_ep *ep parameter in functions _nbu2ss_ep0_in_transfer()
and _nbu2ss_ep0_out_transfer() is not used anywhere inside. Hence,
removed.
Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ravi Teja Darbha [Fri, 4 Sep 2015 19:38:29 +0000 (01:08 +0530)]
staging: emxx_udc: Remove cleanup1 label
The cleanup1 label does nothing but return. Better way is to return
immediately instead of using goto. Hence, removed.
Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ravi Teja Darbha [Fri, 4 Sep 2015 08:18:22 +0000 (13:48 +0530)]
staging: emxx_udc: Fix NULL comparison style
Fixed NULL comparison style as suggested by checkpatch.pl
Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ravi Teja Darbha [Fri, 4 Sep 2015 08:16:32 +0000 (13:46 +0530)]
staging: emxx_udc: Avoid using multiple blank lines
Fixed multiple blank lines warning by checkpatch.pl
Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ravi Teja Darbha [Fri, 4 Sep 2015 07:59:52 +0000 (13:29 +0530)]
staging: emxx_udc: Remove FSF mailing address
FSF mailing address is no longer required to be specified. Hence
removed.
Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Tue, 8 Sep 2015 16:23:02 +0000 (21:53 +0530)]
staging: lustre: lov: remove always false condition
The member qc_idx of struct if_quotactl is unsigned and hence it can
never be less than zero.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Tue, 8 Sep 2015 16:23:01 +0000 (21:53 +0530)]
staging: lustre: lov: fix dereference of ERR_PTR
If lov_sub_get() fails then it returns the error code in ERR_PTR, but
here we were dereferencing sub without checking if lov_sub_get() has
actually succeeded or not. And on error we can directly return the error
code from lov_io_fault_start() as it return 0 on success and the error
code on error.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anders Fridlund [Mon, 7 Sep 2015 22:56:48 +0000 (00:56 +0200)]
staging: lustre: ptlrpc: include ptlrpc_internal.h
Remove sparse warning "symbol 'sptlrpc_plain_init' was not declared"
by including ptlrpc_internal.h, which includes sptlrpc_plain_init.
Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Mon, 7 Sep 2015 13:05:15 +0000 (16:05 +0300)]
staging: lustre: use linux/statfs.h instead of asm/statfs.h
Fix the following checkpatch warning:
drivers/staging/lustre/lustre/include/linux/lustre_lite.h:46:
WARNING:INCLUDE_LINUX: Use #include <linux/statfs.h> instead of <asm/statfs.h>
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthew Needes [Sat, 5 Sep 2015 20:03:38 +0000 (13:03 -0700)]
staging: lustre/obdclass/linux/linux-module.c
Fixed sparse warning by removing unused variable "proc_version".
Signed-off-by: Matthew Needes <mneedes@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 5 Sep 2015 13:28:25 +0000 (18:58 +0530)]
Staging: lustre: lnet: Remove braces for single statement blocks
The linux kernel coding style discourages use of braces for single
statement blocks. This patch removes the unnecessary braces.
The warning was detected using checkpatch.pl. Coccinelle was used
to make the change.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 5 Sep 2015 13:28:24 +0000 (18:58 +0530)]
Staging: lustre: llite: llite_lib.c: Remove unnecessary braces
The linux kernel coding style discourages use of braces for single
statement blocks. This patch removes the unnecessary braces.
The warning was detected using checkpatch.pl. Coccinelle was used to
make the change.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 5 Sep 2015 13:28:23 +0000 (18:58 +0530)]
Staging: lustre: llite: llite_close.c: Remove unnecessary braces
The linux kernel coding style discourages use of braces for single
statement blocks. This patch removes the unnecessary braces.
The warning was detected using checkpatch.pl. Coccinelle was used to
make the change.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 5 Sep 2015 13:28:22 +0000 (18:58 +0530)]
Staging: lustre: obdclass: Remove braces for single statement blocks
The linux kernel coding style discourages use of braces for single
statement blocks. This patch removes the unnecessary braces.
The warning was detected using checkpatch.pl. Coccinelle was used to
make the change.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 5 Sep 2015 13:28:21 +0000 (18:58 +0530)]
Staging: lustre: libcfs: Remove braces for single statement blocks
The linux kernel coding style discourages use of braces for single
statement blocks. This patch removes the unnecessary braces.
The warning was detected using checkpatch.pl. Coccinelle was used to
make the change.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 5 Sep 2015 13:28:20 +0000 (18:58 +0530)]
Staging: lustre: ptlrpc: Remove braces for single statement blocks
The linux kernel coding style discourages use of braces for single
statement blocks. This patch removes the unnecessary braces.
The warning was detected using checkpatch.pl. Coccinelle was used to
make the change.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 4 Sep 2015 06:38:49 +0000 (12:08 +0530)]
Staging: lustre: osc: Space prohibited between function name and open parenthesis
This patch fixes the checkpatch.pl warning:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 4 Sep 2015 06:38:48 +0000 (12:08 +0530)]
Staging: lustre: obdclass: Insert blank line from declarations
This patch fixes the checkpatch.pl warning
WARNING: Missing a blank line after declarations
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 4 Sep 2015 06:38:47 +0000 (12:08 +0530)]
Staging: lustre: obdclass: Remove unnecessary return statements
This patch removes return statement which are not required.
The warning was detected by checkpatch.pl
WARNING: void function return statements are not generally useful
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 4 Sep 2015 06:38:45 +0000 (12:08 +0530)]
Staging: lustre: mdc: Remove useless cast on void pointer
void pointers do not need to be cast to other pointer types.
The semantic patch used to find this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 4 Sep 2015 06:38:44 +0000 (12:08 +0530)]
Staging: lustre: lnet: Remove useless cast on void pointer
void pointers do not need to be cast to other pointer types.
The semantic patch used to find this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 4 Sep 2015 06:38:42 +0000 (12:08 +0530)]
Staging: lustre: obdclass: Use kasprintf instead of kzalloc and sprintf
This patch uses kasprintf which combines kzalloc and sprintf.
kasprintf also takes care of the size calculation.
Semantic patch used is as follows:
@@
expression a,flag;
expression list args;
statement S;
@@
a =
- \(kmalloc\|kzalloc\)(...,flag)
+ kasprintf (flag,args)
<... when != a
if (a == NULL || ...) S
...>
- sprintf(a,args);
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 4 Sep 2015 06:38:41 +0000 (12:08 +0530)]
Staging: lustre: obdclass: Remove typedefs for struct
The Linux kernel coding style guidelines suggest not using typedefs for
structure and enum types. This patch gets rid of the typedefs for
lu_site_stats_t.
The following Coccinelle semantic patch detects the cases for struct type:
@tn@
identifier i;
type td;
@@
-typedef
struct i { ... }
-td
;
@@
type tn.td;
identifier tn.i;
@@
-td
+ struct i
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 4 Sep 2015 06:38:40 +0000 (12:08 +0530)]
Staging: lustre: libcfs: Remove typedefs for struct
The Linux kernel coding style guidelines suggest not using typedefs for
structure and enum types. This patch gets rid of the typedefs for
cfs_wi_sched_t.
The following Coccinelle semantic patch detects the cases for struct type:
@tn@
identifier i;
type td;
@@
-typedef
struct i { ... }
-td
;
@@
type tn.td;
identifier tn.i;
@@
-td
+ struct i
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 9 Sep 2015 07:08:13 +0000 (16:08 +0900)]
staging: wilc1000: remove unused PLAT_RK3026_TCHIP
This patch removes the preprocessor definition, PLAT_RK3026_TCHIP which
is not used anymore.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kim, Leo [Tue, 8 Sep 2015 08:08:03 +0000 (17:08 +0900)]
staging: wilc1000: delete definition USE_WIRELESS
The preprocessor definition, USE_WIRELESS is always in use.
So, this patch deletes the definitions from the makefile and source codes.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kim, Leo [Tue, 8 Sep 2015 08:08:02 +0000 (17:08 +0900)]
staging: wilc1000: remove unused NM73131_0_BOARD
This patch removes the preprocessor definition, NM73131_0_BOARD which is
not used anymore.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Tue, 8 Sep 2015 08:08:01 +0000 (17:08 +0900)]
staging: wilc1000: add maintainers for Atmel 802.11 driver
This patch adds new maintainers who develops new design for Atmel 802.11
link controller and deletes Dean Lee who cannot maintain the wireless
driver anymore.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johnny Kim [Tue, 8 Sep 2015 08:08:00 +0000 (17:08 +0900)]
staging: wilc1000: remove meaningless line
The current driver is calling skb_reserve function to align memory in
frmw_to_linux function. However, the wrong value is used as the input argument.
Besides, the process is not necessary because the address already is algined
in dev_alloc_skb function. So, this patch removes the line for dummy headroom.
Signed-off-by: Johnny Kim <johnny.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johnny Kim [Tue, 8 Sep 2015 08:07:59 +0000 (17:07 +0900)]
staging: wilc1000: define undefined operation mode
This patch adds new define, IDLE_MODE to change comparison statement which
is wrong due to typecasting to null.
Signed-off-by: Johnny Kim <johnny.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 7 Sep 2015 15:36:36 +0000 (00:36 +0900)]
staging: wilc1000: linux_wlan.c: add kzalloc error check
This patch adds error check if kzalloc is failed.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 7 Sep 2015 15:36:38 +0000 (00:36 +0900)]
staging: wilc1000: wilc_msgqueue.c: use kmalloc with GFP_ATOMIC
This patch use kmalloc with GFP_ATOMIC instead of WILC_MALLOC.
It is inside the spin lock region.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 7 Sep 2015 15:36:35 +0000 (00:36 +0900)]
staging: wilc1000: linux_wlan.c: use kzalloc instead of WILC_MALLOC
This patch replaces WILC_MALLOC with kzalloc.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 7 Sep 2015 10:09:31 +0000 (19:09 +0900)]
staging: wilc1000: fix potential memory leak
This patch adds kfree(mgmt_tx) when memory allocation of mgmt_tx->buff
fails in the second calls of kmalloc() to avoid the memory leak from mgmt_tx
first allocated before the second calls of kmalloc().
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Chris Park <chirs.park@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 7 Sep 2015 10:09:30 +0000 (19:09 +0900)]
staging: wilc1000: remove unused preprocessor definition
This patch removes a preprocessor definition, SWITCH_LOG_TERMINAL,
which is not used. Enabling this definition affects the performance.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 7 Sep 2015 10:09:29 +0000 (19:09 +0900)]
staging: wilc1000: remove dead codes
This patch removes the preprocessor definition from the codes, as shown in the
following, which is not used anymore.
- WILC_FULLY_HOSTING_AP
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Fri, 4 Sep 2015 10:52:06 +0000 (16:22 +0530)]
staging: most: style of bool comparison
BOOLEAN tests do not need any comparison to TRUE or FALSE.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Fri, 4 Sep 2015 10:52:05 +0000 (16:22 +0530)]
staging: most: remove unneeded NULL check
The loop cursor of list_for_each_entry_safe() can never be NULL.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Fri, 4 Sep 2015 10:52:04 +0000 (16:22 +0530)]
staging: most: remove driver owner
The platform driver core will set the owner value, we do not need to do
it in the module.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Fri, 4 Sep 2015 10:52:03 +0000 (16:22 +0530)]
staging: most: return NULL instead of integer
The return type of get_aim_dev() is a pointer but we were returning 0
incase of failure.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Fri, 4 Sep 2015 10:52:02 +0000 (16:22 +0530)]
staging: most: remove always true comparison
channel->dev has already been checked for NULL and if it was NULL then
we have returned with -EPIPE. So at this point it can not be NULL.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Sell [Fri, 4 Sep 2015 16:25:49 +0000 (12:25 -0400)]
staging: unisys: documentation and TODO tweaks
Update documentation (including TODO) to reflect the current state of
the drivers.
Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / platform / kernel / linux-rpi.git / log