platform/upstream/coreclr.git
6 years agoUpdate CoreClr, CoreFx to preview1-26029-02, preview1-26029-02, respectively (#15636)
dotnet-maestro-bot [Fri, 29 Dec 2017 15:50:32 +0000 (09:50 -0600)]
Update CoreClr, CoreFx to preview1-26029-02, preview1-26029-02, respectively (#15636)

6 years agoRemove reflection block on methods with MethodAttributes.RequireSecObject flag (...
Jan Kotas [Fri, 29 Dec 2017 13:17:57 +0000 (05:17 -0800)]
Remove reflection block on methods with MethodAttributes.RequireSecObject flag (#15663)

This is not applicable for CoreCLR since CoreCLR does not have CAS, and this flag was overloaded for other purpose.

Fixes #15662

6 years agoMake HandleRef fields private
Jan Kotas [Fri, 29 Dec 2017 00:26:46 +0000 (16:26 -0800)]
Make HandleRef fields private

6 years agoMerge pull request dotnet/corert#5148 from dotnet/nmirror
Jan Kotas [Sat, 23 Dec 2017 05:42:41 +0000 (21:42 -0800)]
Merge pull request dotnet/corert#5148 from dotnet/nmirror

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
6 years agoMerge pull request #15341 from tannergooding/simd-scalar
Tanner Gooding [Fri, 29 Dec 2017 00:54:20 +0000 (16:54 -0800)]
Merge pull request #15341 from tannergooding/simd-scalar

Adding scalar hardware intrinsics for x86.

6 years agoRecognize STA\MTA Attribute For Main Function (#15652)
Anirudh Agnihotry [Fri, 29 Dec 2017 00:35:12 +0000 (16:35 -0800)]
Recognize STA\MTA Attribute For Main Function (#15652)

* Apartment state set for main method

* g_fWeownprocess removed and CLRConfig::GetConfigValue(CLRConfig::EXTERNAL_FinalizeOnShutdown) set

6 years agoRemoved redundant null tests when sorting a secondary values array. (#14277)
Colin Green [Fri, 29 Dec 2017 00:15:24 +0000 (00:15 +0000)]
Removed redundant null tests when sorting a secondary values array. (#14277)

6 years agoMerge pull request #15658 from BruceForstall/FixBuildWarnings
Bruce Forstall [Thu, 28 Dec 2017 22:28:38 +0000 (14:28 -0800)]
Merge pull request #15658 from BruceForstall/FixBuildWarnings

Fix desktop build warnings

6 years agoFix desktop build warnings
Bruce Forstall [Thu, 28 Dec 2017 18:11:47 +0000 (10:11 -0800)]
Fix desktop build warnings

6 years agoExtending FormatException's message with datetime/format (#15635)
Szabolcs Dézsi [Thu, 28 Dec 2017 18:11:30 +0000 (13:11 -0500)]
Extending FormatException's message with datetime/format (#15635)

* Extending FormatException's message with datetime/format

* Applying feedback from review

6 years agoLink to the File Header Example for C# was broken. (#15655)
Atanu [Thu, 28 Dec 2017 17:21:33 +0000 (22:51 +0530)]
Link to the File Header Example for C# was broken. (#15655)

The File Header example for C# was redirecting to (../../src/mscorlib/src/System/Collections/Generic/List.cs) which was missing in the master repository. The example file has been changed to Comparer.cs which is another file in the same repo path.

6 years agoUpdated CreateMethodDesc to pass along the `IsJitIntrinsic` flag for generic methods...
Tanner Gooding [Thu, 28 Dec 2017 04:23:26 +0000 (20:23 -0800)]
Updated CreateMethodDesc to pass along the `IsJitIntrinsic` flag for generic methods. (#15653)

6 years agoUpdated links to ABI conventions (#15651)
Alfred Myers [Wed, 27 Dec 2017 20:31:09 +0000 (17:31 -0300)]
Updated links to ABI conventions (#15651)

6 years agoUpdate the version of the xUnit Performance Api (#15620)
José Rivero [Wed, 27 Dec 2017 17:48:34 +0000 (09:48 -0800)]
Update the version of the xUnit Performance Api (#15620)

- This version fail broken benchmarks, so we can catch bad codegen and bug earlier.
- Changed the harness to exit with non-zero code when an exception is thrown.

6 years agoResolve race in ShimProxyCallback::AddRef (#15643)
Ben Adams [Wed, 27 Dec 2017 16:12:14 +0000 (16:12 +0000)]
Resolve race in ShimProxyCallback::AddRef (#15643)

6 years agoUpdate CoreClr, CoreFx to preview1-26026-01, preview1-26026-01, respectively (#15630)
dotnet-maestro-bot [Tue, 26 Dec 2017 08:40:15 +0000 (02:40 -0600)]
Update CoreClr, CoreFx to preview1-26026-01, preview1-26026-01, respectively (#15630)

6 years agoUpdate CoreClr, CoreFx to preview1-26024-02, preview1-26024-01, respectively (#15628)
dotnet-maestro-bot [Sun, 24 Dec 2017 08:02:03 +0000 (02:02 -0600)]
Update CoreClr, CoreFx to preview1-26024-02, preview1-26024-01, respectively (#15628)

6 years agoMake DangerousGetPinnableReference internal and remove DangerousTryGetArray (#15557)
Ahson Khan [Sun, 24 Dec 2017 01:43:26 +0000 (17:43 -0800)]
Make DangerousGetPinnableReference internal and remove DangerousTryGetArray (#15557)

* Make DangerousGetPinnableReference internal and remove DangerousTryGetArray

* Change DangerousGetPinnableReference to return ref readonly

6 years agoUpdate CoreClr, CoreFx to preview1-26023-03, preview1-26023-03, respectively (#15624)
dotnet-maestro-bot [Sat, 23 Dec 2017 22:41:05 +0000 (16:41 -0600)]
Update CoreClr, CoreFx to preview1-26023-03, preview1-26023-03, respectively (#15624)

6 years agoUpdate CoreClr, CoreFx to preview1-26023-01, preview1-26023-01, respectively (#15622)
dotnet-maestro-bot [Sat, 23 Dec 2017 07:37:43 +0000 (01:37 -0600)]
Update CoreClr, CoreFx to preview1-26023-01, preview1-26023-01, respectively (#15622)

6 years ago[Arm64] Disable HW Intrinsic NGEN (#15603)
Steve MacLean [Sat, 23 Dec 2017 00:54:35 +0000 (19:54 -0500)]
[Arm64] Disable HW Intrinsic NGEN (#15603)

6 years agoUpdate BuildTools, CoreClr, CoreFx to prerelease-02322-02, preview1-26022-02, preview...
dotnet-maestro-bot [Fri, 22 Dec 2017 22:00:09 +0000 (16:00 -0600)]
Update BuildTools, CoreClr, CoreFx to prerelease-02322-02, preview1-26022-02, preview1-26022-02, respectively (#15612)

6 years agoFix manual GC_PROTECTs around StackTraceArray (#15621)
Jan Kotas [Fri, 22 Dec 2017 21:57:20 +0000 (13:57 -0800)]
Fix manual GC_PROTECTs around StackTraceArray (#15621)

StackTraceArray wraps GC reference that needs to be GC_PROTECTED exactly once accross all GC triggering points. The calls from copy constructor and assignment operator were violating this invariant. I have fixed this by deleting the copy constructor and assignment operator, and replaced their use by explicit CopyFrom method.

Fixes #15537

6 years agoSmall changes around stack levels. (#15616)
Sergey Andreenko [Fri, 22 Dec 2017 21:15:41 +0000 (13:15 -0800)]
Small changes around stack levels. (#15616)

* add ifdef for fgThrowHlpBlkStkLevel

* fgFindExcptnTarget should not be called fof dbg code compilation mode.

6 years agoMinor tweaks (#15590)
Alfred Myers [Fri, 22 Dec 2017 19:50:16 +0000 (16:50 -0300)]
Minor tweaks (#15590)

6 years agoOrganizing the tests/src/JIT/HardwareIntrinsics/X86 folder by ISA to make it more...
Tanner Gooding [Fri, 22 Dec 2017 19:11:08 +0000 (11:11 -0800)]
Organizing the tests/src/JIT/HardwareIntrinsics/X86 folder by ISA to make it more manageable. (#15617)

6 years agomark call->fgArgInfo with hasStackArgs for arm32 split args (#15615)
Sergey Andreenko [Fri, 22 Dec 2017 17:58:21 +0000 (09:58 -0800)]
mark call->fgArgInfo with hasStackArgs for arm32 split args (#15615)

6 years agoicushim: try using the build-time libicu version (#15562)
Tom Deseyn [Fri, 22 Dec 2017 12:25:43 +0000 (13:25 +0100)]
icushim: try using the build-time libicu version (#15562)

* icushim: try using the build-time libicu version

* Based on ICU packaging doc, use major instead of (major, minor)

* Verify we can look-up symbols on the build version

* First find Major; add FEATURE_FIXED_ICU_VERSION

* Move FindSymbolVersion check in OpenICULibraries

* Remove FEATURE_FIXED_ICU_VERSION

6 years agoMerge pull request #15610 from BruceForstall/UpBuildOnlyTimeout
Bruce Forstall [Thu, 21 Dec 2017 20:35:10 +0000 (12:35 -0800)]
Merge pull request #15610 from BruceForstall/UpBuildOnlyTimeout

Increase build only job timeouts

6 years agoIncrease build only job timeouts
Bruce Forstall [Thu, 21 Dec 2017 20:20:52 +0000 (12:20 -0800)]
Increase build only job timeouts

Jobs such as checked_windows_nt_bld that now build Pri-1 tests
are timing out. Increase BuildOnly timeouts to compensate.

6 years agoRevert "Enable EventPipe across Unix and Windows (#14772)" (#15609)
Victor "Nate" Graf [Thu, 21 Dec 2017 19:48:14 +0000 (11:48 -0800)]
Revert "Enable EventPipe across Unix and Windows (#14772)" (#15609)

This reverts commit 7524d72d4f0f634fe5407280b83c25181dc8c556.

6 years agoUpdate BuildTools, CoreClr, CoreFx to prerelease-02320-01, preview1-26020-03, preview...
dotnet-maestro-bot [Thu, 21 Dec 2017 16:23:48 +0000 (10:23 -0600)]
Update BuildTools, CoreClr, CoreFx to prerelease-02320-01, preview1-26020-03, preview1-26021-02, respectively (#15558)

6 years agoMerge pull request #15600 from BruceForstall/FixPri0Builds
Bruce Forstall [Thu, 21 Dec 2017 04:40:08 +0000 (20:40 -0800)]
Merge pull request #15600 from BruceForstall/FixPri0Builds

Fix build-only test priority

6 years agoFix build-only test priority
Bruce Forstall [Thu, 21 Dec 2017 04:30:14 +0000 (20:30 -0800)]
Fix build-only test priority

Build-only jobs used to create non-Windows test assets were changed
undesirably to build only pri-0 tests.

Addresses #15569

6 years agoMerge pull request #15599 from BruceForstall/IncreaseDebugTimeout
Bruce Forstall [Thu, 21 Dec 2017 04:27:53 +0000 (20:27 -0800)]
Merge pull request #15599 from BruceForstall/IncreaseDebugTimeout

Add an hour to test job timeouts to account for their slowness

6 years agoAdd an hour to test job timeouts to account for their slowness
Bruce Forstall [Thu, 21 Dec 2017 04:07:14 +0000 (20:07 -0800)]
Add an hour to test job timeouts to account for their slowness

6 years agoFix build error when using VS2015. (#15598)
Brian Robbins [Thu, 21 Dec 2017 03:56:58 +0000 (19:56 -0800)]
Fix build error when using VS2015. (#15598)

6 years agoEnable EventPipe across Unix and Windows (#14772)
Victor "Nate" Graf [Thu, 21 Dec 2017 02:07:52 +0000 (18:07 -0800)]
Enable EventPipe across Unix and Windows (#14772)

* [squashed] most work complete to enable EventPipe on Windows

* Eventpipe now builds on Windows

* Ensure evevntpipe is intialized on Windows

* Resolve the location of python from build.cmd

* Ensure eventing files are generated when needed

* moving linkage declaration to cmake

* create new event from constructor

* enable FEATURE_EVENT_TRACE and FEATURE_PERF_TRACE everywhere

* [WIP] checkpoint in fixing contarct errors

* add another possible python location

* Fix double delete bug in EventPipeConfiguration destructor

* Fix typo in function name

* Revert changes to .gitgnore

* bump to netstandard1.6 in preperation for new version of TraceEvent

* Revert changes to groovy files

* revert changes to perf-prep scripts

* add common.h and use nothrow

* Fix issue which was causing double delete of configprovider

* Add new test utilizing TraceEvent

* Remove accidentally added local directory reference

* Add comment to explain the addition of misc/tracepointprovider.cpp

* Add back sys.exit(0) and refactor

* Change conditional to be more direct

* Better handle NULL config

* Initialize m_deleteDefered

* Eliminate obsolete field

* Fix spelling error

* Fix nits

* Make smaple progiler timing functions easier to read

* Move projects back to netstandard1.4

* Incomplete improvements to EventPipeTrace test

* Add event integrity checks to test

* Clean up some left over code

* Add EventSource based test

* Remove unused PAL tests on Windows

* Fix Linux build breaks

* Minor changes to CMake files

* Remove //HACK for hack that was previously removed

* Fix formatting and negate a #ifdef

* Add conditional to ensure PERFTRACING is not enabled without EVENT_TRACE

* Take lock on EventPipeProvider and EventPipeConfiguration destruction

* Load winmm.dll at runtime

* Change function name and compile conditions

* Move typedef into #ifndef

* Use the correct config in setup

* Change lifecycle managment of EventPipeConfiguration's configuration provider

* Enable EventPipe tests pri0 and disable broken tests

* Replace python3 only error with python2 compatable one

* Make common.csproj build pri0

* Change TraceEvent version to 2.0.2 to match published verison

* Address cross build failure

* Remove use of undefined variable

* Add crossgen fix to .cmd

* Use more specific types to avoid marshalling errors

* Use Assert-style statements and remove one check

* Fix cross arch build

* Fix flipped branch

* Bring build.cmd changes to build.sh

* Fix cmake writing

* Revert "Bring build.cmd changes to build.sh"

This reverts commit 893c6492548d8bc9859ebba5b1b810aa630fac63.

* remove stdlib.h

* Fix out of order null check

6 years agoMerge pull request #15514 from fiigii/14930
Bruce Forstall [Thu, 21 Dec 2017 01:36:54 +0000 (17:36 -0800)]
Merge pull request #15514 from fiigii/14930

IsSupported returns false for not-fully-implemented ISA classes

6 years agofix template method that nobody calls. (#15584)
Sergey Andreenko [Wed, 20 Dec 2017 23:09:22 +0000 (15:09 -0800)]
fix template method that nobody calls. (#15584)

6 years agoBlock diamondshape and sharedgenerics tests on #15591 (#15593)
Michal Strehovský [Wed, 20 Dec 2017 22:45:14 +0000 (23:45 +0100)]
Block diamondshape and sharedgenerics tests on #15591 (#15593)

6 years agoMerge pull request #15404 from CarolEidt/ElimLsraInfo
Carol Eidt [Wed, 20 Dec 2017 22:31:59 +0000 (14:31 -0800)]
Merge pull request #15404 from CarolEidt/ElimLsraInfo

Eliminate gtLsraInfo from GenTree

6 years agoFix the dump of LIR flags
Carol Eidt [Wed, 20 Dec 2017 22:24:28 +0000 (14:24 -0800)]
Fix the dump of LIR flags

6 years agoAdd COMPlus_EnableIncompleteISAClass and streamline IsSupported
Fei Peng [Wed, 20 Dec 2017 22:13:47 +0000 (14:13 -0800)]
Add COMPlus_EnableIncompleteISAClass and streamline IsSupported

6 years agoMerge pull request #15594 from BruceForstall/TestTimeout
Bruce Forstall [Wed, 20 Dec 2017 22:04:25 +0000 (14:04 -0800)]
Merge pull request #15594 from BruceForstall/TestTimeout

Fix per-test timeout

6 years agoMerge pull request #15588 from fiigii/movetest
Tanner Gooding [Wed, 20 Dec 2017 21:55:44 +0000 (13:55 -0800)]
Merge pull request #15588 from fiigii/movetest

Move x86 intrinsic tests into X86 folder

6 years agoMerge pull request #15396 from BruceForstall/LimitArm64Hardware
Bruce Forstall [Wed, 20 Dec 2017 21:42:02 +0000 (13:42 -0800)]
Merge pull request #15396 from BruceForstall/LimitArm64Hardware

Limit Windows ARM64 non-PR testing to certain branches

6 years agoFix per-test timeout
Bruce Forstall [Wed, 20 Dec 2017 21:37:02 +0000 (13:37 -0800)]
Fix per-test timeout

1. Add "timeout" option to runtest.cmd to set the per-test timeout, in ms.
2. Change NETCI to use this new option.

This should fix various random test failures that frequently occur
in Debug test runs due to timeout (e.g., chaos and type generator tests).

6 years agoRemove unused TYP_ARRAY/PTR/FUNC (#15529)
mikedn [Wed, 20 Dec 2017 21:31:53 +0000 (23:31 +0200)]
Remove unused TYP_ARRAY/PTR/FUNC (#15529)

6 years agoMerge pull request #15586 from jkotas/revert
Bruce Forstall [Wed, 20 Dec 2017 20:27:07 +0000 (12:27 -0800)]
Merge pull request #15586 from jkotas/revert

Revert "Respect STA/MTAThread attributes (#15512)"

6 years agoMove x86 intrinsic tests into X86 folder
Fei Peng [Wed, 20 Dec 2017 19:34:18 +0000 (11:34 -0800)]
Move x86 intrinsic tests into X86 folder

6 years agoRevert "Respect STA/MTAThread attributes (#15512)"
Jan Kotas [Wed, 20 Dec 2017 15:52:29 +0000 (07:52 -0800)]
Revert "Respect STA/MTAThread attributes (#15512)"

This reverts commit 21cfdb6f5bb8c596aa55cc50892be0bfabee5de3.

6 years agoif getter is under #ifdef, then the setter should be either. (#15581)
Sergey Andreenko [Wed, 20 Dec 2017 03:31:52 +0000 (19:31 -0800)]
if getter is under #ifdef, then the setter should be either. (#15581)

Signed-off-by: Sergey Andreenko <seandree@microsoft.com>
6 years agoFix sos/dac long named dlls (#15580)
Mike McLaughlin [Wed, 20 Dec 2017 00:52:20 +0000 (16:52 -0800)]
Fix sos/dac long named dlls (#15580)

Extra "0" added in the official builds.

6 years agoFix for armel double passed as long
Carol Eidt [Tue, 19 Dec 2017 23:34:37 +0000 (15:34 -0800)]
Fix for armel double passed as long

6 years agoMerge pull request #15574 from BruceForstall/AddArmBenchmarksGameTesting
Bruce Forstall [Tue, 19 Dec 2017 17:36:54 +0000 (09:36 -0800)]
Merge pull request #15574 from BruceForstall/AddArmBenchmarksGameTesting

Manually add arm/arm64 BenchmarksGame testing

6 years agoManually add arm/arm64 BenchmarksGame testing
Bruce Forstall [Tue, 19 Dec 2017 01:52:57 +0000 (17:52 -0800)]
Manually add arm/arm64 BenchmarksGame testing

It was removed in #13994 when these benchmarks were updated, expecting
a tests.lst autogeneration would follow. I'm adding them manually now
to ensure we have test coverage for these.

Fixes #15503

6 years agoEnable gdbjit while NI file exist (#15501)
chunseoklee [Tue, 19 Dec 2017 01:41:50 +0000 (10:41 +0900)]
Enable gdbjit while NI file exist (#15501)

Current gdbjit does not work with NI files.
This patch allows breakpoint to work with NI files when COMPlus_ZapDisable=1

Signed-off-by: chunseok lee <chunseok.lee@samsung.com>
6 years agoMerge pull request #15573 from echesakovMSFT/FixDesktopBuildPR15524
Egor Chesakov [Tue, 19 Dec 2017 01:24:30 +0000 (17:24 -0800)]
Merge pull request #15573 from echesakovMSFT/FixDesktopBuildPR15524

Fix desktop build break

6 years agoEliminate gtLsraInfo from GenTree
Carol Eidt [Fri, 15 Sep 2017 19:44:12 +0000 (12:44 -0700)]
Eliminate gtLsraInfo from GenTree

Generate TreeNodeInfo into the map when building RefPositions.
Add some new methods and flags for former gtLsraInfo functionality that's used outside of LSRA:
- GenTree::GetRegisterDstCount() (number of registers defined by a node)
- LIR::Flags::RegOptional
- gtDebugFlags::GTF_DEBUG_NODE_LSRA_ADDED

Fix #7255

6 years agoFix desktop build break
Egor Chesakov [Tue, 19 Dec 2017 00:29:17 +0000 (16:29 -0800)]
Fix desktop build break

codegenlegacy.cpp(16025): warning C4389: '!=' : signed/unsigned mismatch
codegenlegacy.cpp(16025): error C2220: warning treated as error - no 'object' file generated

6 years agoMerge pull request #15567 from BruceForstall/Disable15291
Bruce Forstall [Mon, 18 Dec 2017 23:23:25 +0000 (15:23 -0800)]
Merge pull request #15567 from BruceForstall/Disable15291

Disable GitHub_15291.cmd for x86

6 years agoMerge pull request #15571 from BruceForstall/ReduceCrossgenVerbosity
Bruce Forstall [Mon, 18 Dec 2017 23:05:58 +0000 (15:05 -0800)]
Merge pull request #15571 from BruceForstall/ReduceCrossgenVerbosity

Reduce arm/armlb/arm64 R2R test crossgen logging verbosity

6 years agoReduce arm/armlb/arm64 R2R test crossgen logging verbosity
Bruce Forstall [Mon, 18 Dec 2017 22:48:45 +0000 (14:48 -0800)]
Reduce arm/armlb/arm64 R2R test crossgen logging verbosity

6 years agoPut ToolDir property back on restore command
Chad Nedzlek [Mon, 18 Dec 2017 21:18:51 +0000 (13:18 -0800)]
Put ToolDir property back on restore command

Without this, init-tools drops files in unexpected places on the drives.

6 years agoDisable GitHub_15291.cmd for x86
Bruce Forstall [Mon, 18 Dec 2017 20:16:02 +0000 (12:16 -0800)]
Disable GitHub_15291.cmd for x86

It fails under MinOpts. Disable until it is fixed.

Tracked with #15566.

6 years agoPut ToolDir property back on restore command
Chad Nedzlek [Mon, 18 Dec 2017 19:29:41 +0000 (11:29 -0800)]
Put ToolDir property back on restore command

6 years agoMerge pull request #15560 from fiigii/simdexp
Carol Eidt [Mon, 18 Dec 2017 18:58:23 +0000 (10:58 -0800)]
Merge pull request #15560 from fiigii/simdexp

SIMD hardware intrinsics throw PNSE

6 years agoMerge pull request #15549 from BruceForstall/AddCrossgenFx
Bruce Forstall [Mon, 18 Dec 2017 17:46:55 +0000 (09:46 -0800)]
Merge pull request #15549 from BruceForstall/AddCrossgenFx

For arm/armlb/arm64 R2R testing, add crossgen compilation of FX assems

6 years agogtNewMustThrowException works with SIMD and struct
Fei Peng [Mon, 18 Dec 2017 02:17:46 +0000 (18:17 -0800)]
gtNewMustThrowException works with SIMD and struct

6 years agoUpdate CoreClr, CoreFx to preview1-26017-01, preview1-26016-06, respectively (#15556)
dotnet-maestro-bot [Sun, 17 Dec 2017 07:00:16 +0000 (01:00 -0600)]
Update CoreClr, CoreFx to preview1-26017-01, preview1-26016-06, respectively (#15556)

6 years agoFix naming convention of hardware intrinsic APIs (#15471)
Fei Peng [Sun, 17 Dec 2017 04:10:43 +0000 (20:10 -0800)]
Fix naming convention of hardware intrinsic APIs (#15471)

6 years agoRespect STA/MTAThread attributes (#15512)
Anirudh Agnihotry [Sat, 16 Dec 2017 22:50:09 +0000 (14:50 -0800)]
Respect STA/MTAThread attributes (#15512)

* Apartment state set for main method

* Default apartment state is Unknown

* Removed Extra validation of token

* Removed legacy apartment code

6 years agoUpdate CoreClr, CoreFx to preview1-26016-03, preview1-26016-05, respectively (#15554)
dotnet-maestro-bot [Sat, 16 Dec 2017 19:32:56 +0000 (13:32 -0600)]
Update CoreClr, CoreFx to preview1-26016-03, preview1-26016-05, respectively (#15554)

6 years agoMerge pull request #15555 from dotnet-bot/from-tfs
Jan Kotas [Sat, 16 Dec 2017 16:49:54 +0000 (11:49 -0500)]
Merge pull request #15555 from dotnet-bot/from-tfs

Merge changes from TFS

6 years agoMerge pull request #15553 from BruceForstall/FixTypeinfoMode
Bruce Forstall [Sat, 16 Dec 2017 16:43:32 +0000 (08:43 -0800)]
Merge pull request #15553 from BruceForstall/FixTypeinfoMode

Remove executable bit from _typeinfo.h

6 years agoRemove executable bit from _typeinfo.h
Bruce Forstall [Sat, 16 Dec 2017 06:52:21 +0000 (22:52 -0800)]
Remove executable bit from _typeinfo.h

6 years agoConvert uses of the Dangerous APIs to use MemoryMarshal.GetReference (#15532)
Ahson Khan [Sat, 16 Dec 2017 06:36:38 +0000 (22:36 -0800)]
Convert uses of the Dangerous APIs to use MemoryMarshal.GetReference (#15532)

* Convert uses of the Dangerous APIs to use MemoryMarshal.GetReference

* Adding Unsafe.AsRef(in...) and using that for ReadOnlySpan GetReference

* Fix typo - add missing bracket.

* Change AsRef(ref...) to AsRef(in...)

* Remove unnecessary whitespace

* Remove Unsafe.AsRef(in...) and its uses.

* Revert "Remove unnecessary whitespace"

This reverts commit 4dbe38cae472e868f74afbabde358f3a7609f6ae.

* Revert "Revert "Remove unnecessary whitespace""

This reverts commit 44d79483423ac9ffcf7c566b79d4a42c6aa15dac.

* Remove extra space to fix formatting.

6 years agoUpdate CoreClr to preview1-26015-09 (master) (#15550)
dotnet-maestro-bot [Sat, 16 Dec 2017 05:06:47 +0000 (23:06 -0600)]
Update CoreClr to preview1-26015-09 (master) (#15550)

* Update CoreClr to preview1-26015-09

* Fix formatting

6 years agoClean up clrjit from using sizeof(void*) when meant TARGET_POINTER_SIZE (#15524)
Egor Chesakov [Sat, 16 Dec 2017 04:30:58 +0000 (20:30 -0800)]
Clean up clrjit from using sizeof(void*) when meant TARGET_POINTER_SIZE (#15524)

6 years agoReadOnlySpan GetReference returns ref instead of ref readonly (#15548)
Ahson Khan [Sat, 16 Dec 2017 01:45:18 +0000 (17:45 -0800)]
ReadOnlySpan GetReference returns ref instead of ref readonly (#15548)

6 years agoMerge pull request #15528 from fiigii/simd32
Carol Eidt [Sat, 16 Dec 2017 00:55:39 +0000 (16:55 -0800)]
Merge pull request #15528 from fiigii/simd32

Enable Vector256<T> on AVX CPUs

6 years agoUpdate CoreFx to preview1-26015-09 (#15547)
dotnet-maestro-bot [Sat, 16 Dec 2017 00:53:51 +0000 (18:53 -0600)]
Update CoreFx to preview1-26015-09 (#15547)

6 years agoEnable Vector256<T> with AVX
Fei Peng [Sat, 16 Dec 2017 00:51:21 +0000 (16:51 -0800)]
Enable Vector256<T> with AVX

6 years agoFor arm/armlb/arm64 R2R testing, add crossgen compilation of FX assemblies
Bruce Forstall [Sat, 16 Dec 2017 00:47:01 +0000 (16:47 -0800)]
For arm/armlb/arm64 R2R testing, add crossgen compilation of FX assemblies

6 years agoEnabling temporarily disabled tests that call ReadOnlySpan indexer (#15546)
Ahson Khan [Sat, 16 Dec 2017 00:23:16 +0000 (16:23 -0800)]
Enabling temporarily disabled tests that call ReadOnlySpan indexer (#15546)

6 years agoFix legacy JIT to adjust for https://github.com/dotnet/coreclr/pull/15456
Bruce Forstall [Fri, 15 Dec 2017 23:34:17 +0000 (15:34 -0800)]
Fix legacy JIT to adjust for https://github.com/dotnet/coreclr/pull/15456

[tfs-changeset: 1684002]

6 years agoMerge pull request #15534 from BruceForstall/EnableArmR2RTesting
Bruce Forstall [Fri, 15 Dec 2017 22:43:37 +0000 (14:43 -0800)]
Merge pull request #15534 from BruceForstall/EnableArmR2RTesting

Enable ReadyToRun testing for arm/armlb/arm64

6 years agoMake EventArgs base class serializable (#15541)
Viktor Hofer [Fri, 15 Dec 2017 21:46:52 +0000 (13:46 -0800)]
Make EventArgs base class serializable (#15541)

6 years agoUpdate CoreClr, CoreFx, PgoData to preview1-26015-05, preview1-26015-06, master-20171...
dotnet-maestro-bot [Fri, 15 Dec 2017 16:55:37 +0000 (10:55 -0600)]
Update CoreClr, CoreFx, PgoData to preview1-26015-05, preview1-26015-06, master-20171215-0045, respectively (#15535)

6 years agoMerge pull request #15370 from MichalStrehovsky/defaultintf-merge
Michal Strehovský [Fri, 15 Dec 2017 10:52:33 +0000 (11:52 +0100)]
Merge pull request #15370 from MichalStrehovsky/defaultintf-merge

Merge dev/defaultintf to master

6 years agoEnable ReadyToRun testing for arm/armlb/arm64
Bruce Forstall [Fri, 15 Dec 2017 02:30:01 +0000 (18:30 -0800)]
Enable ReadyToRun testing for arm/armlb/arm64

Sets RunCrossGen variable, which is used by generated wrappers
to crossgen tests before running them.

Still to-do: crossgen framework assemblies before running tests.

6 years agoChange ReadOnlySpan indexer to return ref readonly (#14727)
Ahson Khan [Fri, 15 Dec 2017 02:24:05 +0000 (18:24 -0800)]
Change ReadOnlySpan indexer to return ref readonly (#14727)

* Change ReadOnlySpan indexer to return ref readonly.

Update JIT to handle changes to ReadOnlySpan indexer

Resolving merge conflict and fixing jit importer

Update ReadOnlySpan Enumerator Current to use indexer.

Removing readonly keyword.

* Temporarily disabling Span perf and other tests that use ReadOnlySpan

* Isolating the ref readonly indexer change only to CoreCLR for now.

Reverting the change to Enumerator Current for now

Fix file formatting

Enable Alpine CI (#15502)

* Enable Alpine CI

This enables Alpine CI leg on every PR using the pipelines.

compare type size instead of var_types

get rid of TYP_CHAR

Adding support for Acosh, Asinh, Atanh, and Cbrt to Math and MathF

Updating the PAL layer to support acosh, asinh, atanh, and cbrt

Adding some PAL tests for acosh, asinh, atanh, and cbrt

Adding valuenum support for acosh, asinh, atanh, and cbrt

Lsra Documentation

Update LinearScan section of ryujit-overview.md, and add lsra-detail.md

Refactor Unsafe.cs to get it more in sync with CoreRT. (#15510)

* Refactor Unsafe.cs to get it more in sync with CoreRT.

* Format the document.

* Unifying the copies of Unsafe using ifdefs

* Change exception thrown to PlatformNotSupportedException

* Addressing PR feedback and moving Unsafe to shared.

* Addressing PR feedback

* Addressing PR review - adding intrinsic attribute

Update CoreClr, CoreFx to preview1-26014-01, preview1-26013-12, respectively (#15513)

Revert "Add optional integer offset to OwnedMemory Pin (#15410)"

This reverts commit 8931cfa4ebe94f57698b4c1b3ab5689cd467cb8e.

Get rid of old -altjitcrossgen argument now that CI has been updated

Merge pull request dotnet/corert#5109 from dotnet/nmirror (#15518)

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Revert " Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (#14982)""

Fix typo `_TARGET_ARM` to `_TARGET_ARM_`. This happens mostly in comments except lsra.cpp.

Update CoreClr, CoreFx, PgoData to preview1-26014-04, preview1-26014-03, master-20171214-0043, respectively (#15520)

* Disabling a test that uses ReadOnlySpan indexer

* Temporarily disabling the superpmi test and fixing nit

* Remove debug statements.

6 years ago[RyuJit][Armel] Do not lose type information (#15449)
Sergey Andreenko [Fri, 15 Dec 2017 02:17:53 +0000 (18:17 -0800)]
[RyuJit][Armel] Do not lose type information (#15449)

* Do not lose type information

fgMorphMultiregStructArg could lose type information when replaced smth like this:
 GT_OBJ - TYP_STRUCT     <== arg
  + GT_ADDR - TYP_I_IMPL
   +  + GT_LCL_VAR - TYP_BLK  <== argValue

* Move the test to pri0 to test in ci.

* add an assert

* add the test to the arm list

* make the optimization only if struct handlers match.

* format job

* fix for the unoptimized case.

* check that we have addr node.

* change the reason to lvaSetVarDoNotEnregister

6 years agoUpdate CoreClr to preview1-26014-09 (#15531)
dotnet-maestro-bot [Fri, 15 Dec 2017 02:11:40 +0000 (20:11 -0600)]
Update CoreClr to preview1-26014-09 (#15531)

6 years agoFixing build by casting IntPtr to nint. (#15530)
dotnet bot [Fri, 15 Dec 2017 01:28:39 +0000 (17:28 -0800)]
Fixing build by casting IntPtr to nint. (#15530)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
6 years agoMerge pull request #15448 from jashook/rebase_dutw
Jarret Shook [Thu, 14 Dec 2017 23:58:32 +0000 (15:58 -0800)]
Merge pull request #15448 from jashook/rebase_dutw

Remove CoreFX runtest dependency

6 years agoAdding Unsafe API Add nuint that is used by SpanHelpers (#15527)
Ahson Khan [Thu, 14 Dec 2017 22:34:42 +0000 (14:34 -0800)]
Adding Unsafe API Add nuint that is used by SpanHelpers (#15527)

* Adding Unsafe API Add nuint that is used by SpanHelpers

* Change elementOffset to IntPtr in method signature.

6 years agoAdding scalar hardware intrinsics for x86.
Tanner Gooding [Sat, 2 Dec 2017 00:25:07 +0000 (16:25 -0800)]
Adding scalar hardware intrinsics for x86.

6 years agoChange non-exclusive Check postconditions to null checks (#15523)
Jan Kotas [Thu, 14 Dec 2017 21:15:49 +0000 (16:15 -0500)]
Change non-exclusive Check postconditions to null checks (#15523)

The Check macro is trying to be helpful and trigger DebugBreak when the condition
is false and debugger is attached. It makes it hard to exercise the recent jump stub
changes with debugger attached. The fix is to change the non-exclusive Check postconditions
to a simple null check.