platform/upstream/ofono.git
9 years agoinclude: No need for OFONO_FLAG* defines
Denis Kenzior [Wed, 10 Dec 2014 16:28:49 +0000 (10:28 -0600)]
include: No need for OFONO_FLAG* defines

9 years agotest: Add AvailableTechnologies to list-modems
Alfonso Sanchez-Beato [Tue, 9 Dec 2014 12:34:39 +0000 (13:34 +0100)]
test: Add AvailableTechnologies to list-modems

9 years agosrc: Implement RAT list property
Alfonso Sanchez-Beato [Tue, 9 Dec 2014 12:34:38 +0000 (13:34 +0100)]
src: Implement RAT list property

9 years agoinclude: Add method to list RATs to radio-settings
Alfonso Sanchez-Beato [Tue, 9 Dec 2014 12:34:37 +0000 (13:34 +0100)]
include: Add method to list RATs to radio-settings

9 years agodoc: Add AvailableTechnologies property
Alfonso Sanchez-Beato [Tue, 9 Dec 2014 12:34:36 +0000 (13:34 +0100)]
doc: Add AvailableTechnologies property

This new property in org.ofono.RadioSettings interface will hold the
possible values for radio access technology for the modem.

9 years agosim: Fix pin retries bogus values on some arch-es
Denis Kenzior [Wed, 3 Dec 2014 23:31:09 +0000 (17:31 -0600)]
sim: Fix pin retries bogus values on some arch-es

On some architectures the SimManager.Retries property was getting bogus
values.  This is because we were sending an array which pointed to int
values instead of the expected unsigned char values.

This fix allocates a temporary array of unsigned chars to hold the
actual D-Bus values being sent.  Additionally, the dictionary array is
changed to point to the temporary unsigned char based values instead of
the raw 'int' based retry values.

9 years agotest: Support receiving SMS with non-ASCII chars
Neil Jerram [Fri, 21 Nov 2014 01:48:26 +0000 (01:48 +0000)]
test: Support receiving SMS with non-ASCII chars

Without this I get the following Python traceback, for an SMS that
contains the UK pound sign.

ERROR:dbus.connection:Exception in handler for D-Bus signal:
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/dbus/connection.py", line 230, in maybe_handle_message
    self._handler(*args, **kwargs)
  File "./receive-sms", line 9, in incoming_message
    print("%s" % (message))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xa3' in position 51: ordinal not in range(128)

9 years agohe910: Update copyright
Kuba Pawlak [Mon, 20 Oct 2014 17:12:05 +0000 (19:12 +0200)]
he910: Update copyright

9 years agohe910: enable location raporting atom
Kuba Pawlak [Thu, 16 Oct 2014 12:34:44 +0000 (14:34 +0200)]
he910: enable location raporting atom

9 years agoudev: add GPS port definition for HE910
Kuba Pawlak [Thu, 16 Oct 2014 12:29:05 +0000 (14:29 +0200)]
udev: add GPS port definition for HE910

9 years agotelitmodem: Fix a few coding style violations
Denis Kenzior [Thu, 23 Oct 2014 02:21:49 +0000 (21:21 -0500)]
telitmodem: Fix a few coding style violations

9 years agoAUTHORS: Mention Kuba's contributions
Denis Kenzior [Thu, 23 Oct 2014 02:21:18 +0000 (21:21 -0500)]
AUTHORS: Mention Kuba's contributions

9 years agotelitmodem: location reporting driver
Kuba Pawlak [Thu, 16 Oct 2014 12:28:34 +0000 (14:28 +0200)]
telitmodem: location reporting driver

9 years agodoc: new file doc/telit-modem.txt
Kuba Pawlak [Tue, 21 Oct 2014 16:04:42 +0000 (18:04 +0200)]
doc: new file doc/telit-modem.txt

9 years agoemulator: Refine +BIND support
Denis Kenzior [Mon, 10 Feb 2014 17:01:28 +0000 (11:01 -0600)]
emulator: Refine +BIND support

9 years agohfp_ag_bluez5: Bump HFP version to 1.7
Denis Kenzior [Sat, 1 Feb 2014 15:11:17 +0000 (09:11 -0600)]
hfp_ag_bluez5: Bump HFP version to 1.7

9 years agoemulator_fuzz: Add test plugin
Denis Kenzior [Sat, 1 Feb 2014 15:05:10 +0000 (09:05 -0600)]
emulator_fuzz: Add test plugin

This plugin creates an org.ofono.test.EmulatorFuzz interface on path
/test.  Currently only one method is implemented, SetIndicatorActive.

SetIndicatorActive("DistractedDrivingReduction", True|False) allows to
activate / deactivate the HF indicator via +BIND unsolicited
notification.

9 years agoemulator: Implement new API
Denis Kenzior [Sat, 1 Feb 2014 15:04:52 +0000 (09:04 -0600)]
emulator: Implement new API

9 years agoinclude: Add API to (de)activate HF indicators
Denis Kenzior [Sat, 1 Feb 2014 15:04:17 +0000 (09:04 -0600)]
include: Add API to (de)activate HF indicators

9 years agotest: Add test/set-ddr
Denis Kenzior [Fri, 31 Jan 2014 21:17:23 +0000 (15:17 -0600)]
test: Add test/set-ddr

Script to set DistractedDrivingReduction property

9 years agohandsfree: Be extra pedantic with booleans
Denis Kenzior [Fri, 31 Jan 2014 21:14:08 +0000 (15:14 -0600)]
handsfree: Be extra pedantic with booleans

9 years agohfp_hf_bluez5: Use latest HFP version
Denis Kenzior [Fri, 31 Jan 2014 21:07:40 +0000 (15:07 -0600)]
hfp_hf_bluez5: Use latest HFP version

9 years agohandsfree: Don't try to send a method return
Denis Kenzior [Fri, 31 Jan 2014 21:05:40 +0000 (15:05 -0600)]
handsfree: Don't try to send a method return

When we are simply updating the AG of HF indicator changes, do not try
to send a method return message.

9 years agoslc: Make sure to initialize variables
Denis Kenzior [Fri, 31 Jan 2014 21:05:25 +0000 (15:05 -0600)]
slc: Make sure to initialize variables

9 years agohfp: Implement +BIND notifications
Denis Kenzior [Mon, 27 Jan 2014 17:56:33 +0000 (11:56 -0600)]
hfp: Implement +BIND notifications

9 years agohfp: Notify core of HF indicators supported by AG
Denis Kenzior [Mon, 27 Jan 2014 17:56:44 +0000 (11:56 -0600)]
hfp: Notify core of HF indicators supported by AG

This information was obtained from SLC negotiation

9 years agohfp: Track supported / active indicators
Denis Kenzior [Mon, 27 Jan 2014 17:54:21 +0000 (11:54 -0600)]
hfp: Track supported / active indicators

This information is obtained during SLC establishment

9 years agohandsfree: Implement new HF indicators API
Denis Kenzior [Mon, 27 Jan 2014 17:53:45 +0000 (11:53 -0600)]
handsfree: Implement new HF indicators API

9 years agoinclude: Add HF Indicators related API
Denis Kenzior [Mon, 27 Jan 2014 17:52:21 +0000 (11:52 -0600)]
include: Add HF Indicators related API

9 years agohfp: Add implementation of +BIEV
Denis Kenzior [Wed, 22 Jan 2014 16:16:01 +0000 (10:16 -0600)]
hfp: Add implementation of +BIEV

9 years agoemulator: Refactor data types
Denis Kenzior [Wed, 22 Jan 2014 16:10:44 +0000 (10:10 -0600)]
emulator: Refactor data types

9 years agohfp: Add HF Indicators BRSF feature for 1.7
Denis Kenzior [Tue, 21 Jan 2014 03:43:37 +0000 (21:43 -0600)]
hfp: Add HF Indicators BRSF feature for 1.7

If HFP 1.7 client is used, enable the right BRSF feature

9 years agohandsfree: Skeleton implementation of DDR
Denis Kenzior [Mon, 20 Jan 2014 04:06:21 +0000 (22:06 -0600)]
handsfree: Skeleton implementation of DDR

Distracted Driving Reduction or Enhanced Safety is implemented using HF
indicator 0x0001

9 years agohandsfree: Add new driver method for HF indicators
Denis Kenzior [Mon, 20 Jan 2014 04:06:03 +0000 (22:06 -0600)]
handsfree: Add new driver method for HF indicators

9 years agohfp: Add initial SLC negotiation for HFP 1.7
Denis Kenzior [Mon, 20 Jan 2014 03:39:26 +0000 (21:39 -0600)]
hfp: Add initial SLC negotiation for HFP 1.7

9 years agodoc: Add Distracted Driving Reduction to Handsfree
Denis Kenzior [Mon, 20 Jan 2014 04:05:49 +0000 (22:05 -0600)]
doc: Add Distracted Driving Reduction to Handsfree

9 years agohandsfree: Implement new Features property value
Denis Kenzior [Mon, 20 Jan 2014 04:05:15 +0000 (22:05 -0600)]
handsfree: Implement new Features property value

9 years agodoc: Add 'hf-indicators' feature to Handsfree API
Denis Kenzior [Mon, 20 Jan 2014 04:04:53 +0000 (22:04 -0600)]
doc: Add 'hf-indicators' feature to Handsfree API

9 years agoemulator: Enable HF Indicator feature
Denis Kenzior [Tue, 21 Jan 2014 03:42:58 +0000 (21:42 -0600)]
emulator: Enable HF Indicator feature

9 years agoemulator: Extend BRSF bitmap
Denis Kenzior [Tue, 21 Jan 2014 03:41:23 +0000 (21:41 -0600)]
emulator: Extend BRSF bitmap

The current check of 8 bits is not enough with HFP 1.7

9 years agoemulator: Add +BIEV implementation
Denis Kenzior [Fri, 17 Jan 2014 20:38:56 +0000 (14:38 -0600)]
emulator: Add +BIEV implementation

9 years agoemulator: Add +BIND implementation
Denis Kenzior [Fri, 17 Jan 2014 20:38:39 +0000 (14:38 -0600)]
emulator: Add +BIND implementation

9 years agoemulator: Fix CHLD=? not treated as part of SLC
Denis Kenzior [Tue, 21 Jan 2014 03:42:13 +0000 (21:42 -0600)]
emulator: Fix CHLD=? not treated as part of SLC

9 years agoemulator: Improve SLC establishment logic
Denis Kenzior [Fri, 17 Jan 2014 20:37:41 +0000 (14:37 -0600)]
emulator: Improve SLC establishment logic

9 years agohfp: Add enum for known HF Indicators
Denis Kenzior [Fri, 17 Jan 2014 20:36:28 +0000 (14:36 -0600)]
hfp: Add enum for known HF Indicators

9 years agohfp: Update for new HFP 1.7 values
Denis Kenzior [Fri, 17 Jan 2014 05:04:30 +0000 (23:04 -0600)]
hfp: Update for new HFP 1.7 values

9 years agodoc: Fixup Handsfree API
Denis Kenzior [Mon, 20 Jan 2014 04:03:53 +0000 (22:03 -0600)]
doc: Fixup Handsfree API

9 years agohandsfree-audio: Fix broken coding style in switch statement
Marcel Holtmann [Sat, 20 Sep 2014 14:13:45 +0000 (16:13 +0200)]
handsfree-audio: Fix broken coding style in switch statement

9 years agogdbus: Fix match rule for NameOwnerChanged
Alban Crequy [Tue, 15 Jul 2014 10:29:41 +0000 (11:29 +0100)]
gdbus: Fix match rule for NameOwnerChanged

When subscribing to the D-Bus signal NameOwnerChanged from the bus driver,
specify the object path and the sender in the match rule. Otherwise, random
connections on the bus could impersonate the bus driver.

9 years agogdbus: Fix crash when watch is toggled or disconnected
Luiz Augusto von Dentz [Tue, 12 Aug 2014 12:31:24 +0000 (15:31 +0300)]
gdbus: Fix crash when watch is toggled or disconnected

This partially reverts 510b32b7156625b9df737c916b7a7a5c6fb285b9 since it
still necessary to take a reference before calling dbus_watch_handle
since internally it can call watch_info_free as in the following trace:

 Invalid read of size 8
   at 0x121085: watch_func (mainloop.c:105)
   by 0x4C72694: g_main_context_dispatch (gmain.c:2539)
   by 0x4C729C7: g_main_context_iterate.isra.23 (gmain.c:3146)
   by 0x4C72DC1: g_main_loop_run (gmain.c:3340)
   by 0x120541: main (main.c:551)
 Address 0x5bbcd90 is 16 bytes inside a block of size 24 free'd
   at 0x4A079AE: free (vg_replace_malloc.c:427)
   by 0x4C7837E: g_free (gmem.c:252)
   by 0x4F708BF: dbus_watch_set_data (dbus-watch.c:614)
   by 0x4F70938: _dbus_watch_unref (dbus-watch.c:132)
   by 0x4F6E9A7: _dbus_transport_handle_watch (dbus-transport.c:884)
   by 0x4F59AFB: _dbus_connection_handle_watch (dbus-connection.c:1497)
   by 0x4F70AF9: dbus_watch_handle (dbus-watch.c:683)
   by 0x121084: watch_func (mainloop.c:103)
   by 0x4C72694: g_main_context_dispatch (gmain.c:2539)
   by 0x4C729C7: g_main_context_iterate.isra.23 (gmain.c:3146)
   by 0x4C72DC1: g_main_loop_run (gmain.c:3340)
   by 0x120541: main (main.c:551)

9 years agogdbus: Fix crash when calling g_dbus_add_service_watch
Luiz Augusto von Dentz [Tue, 12 Aug 2014 12:11:29 +0000 (15:11 +0300)]
gdbus: Fix crash when calling g_dbus_add_service_watch

If g_dbus_add_service_watch is called for service which bus name is
already known the following crash can happen:

invalid read of size 1
  at 0x4C2A2F2: strlen (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
  by 0x4E97722: g_strdup (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x405B0C: update_name_cache (watch.c:435)
  by 0x405C37: update_service (watch.c:593)
  by 0x4E7A2A5: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x4E7A627: ??? (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x4E7AA39: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x4038EA: client_ready (test-gdbus-client.c:1014)
  by 0x4E9E5E0: ??? (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x4E9E7A5: ??? (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x4E9EB1A: g_test_run_suite (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x403614: main (test-gdbus-client.c:1058)
Address 0x5dbe5d0 is 0 bytes inside a block of size 7 free'd
  at 0x4C28577: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
  by 0x4E7FF7E: g_free (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x405B04: update_name_cache (watch.c:434)
  by 0x405C37: update_service (watch.c:593)
  by 0x4E7A2A5: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x4E7A627: ??? (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x4E7AA39: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x4038EA: client_ready (test-gdbus-client.c:1014)
  by 0x4E9E5E0: ??? (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x4E9E7A5: ??? (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x4E9EB1A: g_test_run_suite (in /usr/lib64/libglib-2.0.so.0.3800.2)
  by 0x403614: main (test-gdbus-client.c:1058)

9 years agoRevert "gdbus: Don't include just added interfaces in GetManagedObjects"
Luiz Augusto von Dentz [Mon, 11 Aug 2014 14:58:37 +0000 (17:58 +0300)]
Revert "gdbus: Don't include just added interfaces in GetManagedObjects"

This actually creates a problem since the code now does flush any pending
message on the queue any signal will be send right away before the
actual reply to GetManagedObjects which will not contain those interfaces.

9 years agogdbus: Fix use after free
Andrei Emeltchenko [Mon, 11 Aug 2014 07:50:44 +0000 (10:50 +0300)]
gdbus: Fix use after free

Refactor filter_data_remove_callback so that we do not iterate over
freed pointer.

9 years agogdbus: Avoid reporting GDBusClient disconnect twice
Claudio Takahasi [Wed, 2 Apr 2014 18:30:21 +0000 (15:30 -0300)]
gdbus: Avoid reporting GDBusClient disconnect twice

No matter if disconnection was reported previously, g_dbus_client_unref()
was always calling service disconnect callback. This patch fix the
following scenario:
1) service disconnects from the bus
2) disconnect callback gets called
3) client calls g_dbus_client_unref(), disconnect callback is called
   again.

9 years agobuild: Avoid warnings about _FORTIFY_SOURCE
Denis Kenzior [Fri, 1 Aug 2014 14:29:40 +0000 (09:29 -0500)]
build: Avoid warnings about _FORTIFY_SOURCE

Gentoo (and others) define _FORTIFY_SOURCE=2 by default.  We redefine
it, resulting in an error / configure failure.

9 years agoublox: Minor style cleanup
Denis Kenzior [Tue, 8 Jul 2014 13:58:48 +0000 (08:58 -0500)]
ublox: Minor style cleanup

9 years agoublox: Remove unneeded VENDOR flags
Denis Kenzior [Tue, 8 Jul 2014 13:56:55 +0000 (08:56 -0500)]
ublox: Remove unneeded VENDOR flags

devinfo and netreg atoms don't use vendor specific behavior

9 years agoplugins: new driver for u-blox SARA-U270 modems
Philip Paeps [Thu, 3 Jul 2014 10:32:04 +0000 (12:32 +0200)]
plugins: new driver for u-blox SARA-U270 modems

This driver may also work (perhaps with more or less trivial changes)
with other u-blox modems (SARA, LISA, LEON) but this hasn't been tested.

9 years agoatmodem: set the auth method for u-blox modems
Philip Paeps [Thu, 3 Jul 2014 10:32:06 +0000 (12:32 +0200)]
atmodem: set the auth method for u-blox modems

9 years agosim: query u-blox PIN retries with AT+UPINCNT
Philip Paeps [Thu, 3 Jul 2014 10:32:05 +0000 (12:32 +0200)]
sim: query u-blox PIN retries with AT+UPINCNT

9 years agoudevng: add detection logic for u-blox modems
Philip Paeps [Thu, 3 Jul 2014 10:32:03 +0000 (12:32 +0200)]
udevng: add detection logic for u-blox modems

9 years agoquectel: Minor style cleanup
Denis Kenzior [Tue, 8 Jul 2014 13:44:21 +0000 (08:44 -0500)]
quectel: Minor style cleanup

9 years agoquectel: Remove unneeded VENDOR flags
Denis Kenzior [Tue, 8 Jul 2014 13:43:01 +0000 (08:43 -0500)]
quectel: Remove unneeded VENDOR flags

Only the sim atom has QUECTEL specific code

9 years agoplugins: add a new driver for Quectel UC15 modems
Philip Paeps [Mon, 7 Jul 2014 09:54:47 +0000 (11:54 +0200)]
plugins: add a new driver for Quectel UC15 modems

9 years agogprs: add support for u-blox +UREG URCs
Philip Paeps [Thu, 26 Jun 2014 18:28:17 +0000 (20:28 +0200)]
gprs: add support for u-blox +UREG URCs

9 years agoatmodem: add vendor u-blox
Philip Paeps [Thu, 26 Jun 2014 18:28:13 +0000 (20:28 +0200)]
atmodem: add vendor u-blox

9 years agoatmodem: Minor style fixups
Denis Kenzior [Mon, 30 Jun 2014 18:44:40 +0000 (13:44 -0500)]
atmodem: Minor style fixups

9 years agosim: query Quectel UC15 PIN retries with AT+QPINC?
Philip Paeps [Thu, 26 Jun 2014 17:08:14 +0000 (19:08 +0200)]
sim: query Quectel UC15 PIN retries with AT+QPINC?

9 years agoudevng: add detection logic for Quectel modems
Philip Paeps [Thu, 26 Jun 2014 17:08:12 +0000 (19:08 +0200)]
udevng: add detection logic for Quectel modems

9 years agoatmodem: add vendor Quectel
Philip Paeps [Thu, 26 Jun 2014 17:08:11 +0000 (19:08 +0200)]
atmodem: add vendor Quectel

9 years agohfpmodem: Fix crash with more than two calls
Sergio Checa Blanco [Fri, 27 Jun 2014 07:56:07 +0000 (09:56 +0200)]
hfpmodem: Fix crash with more than two calls

A periodic CLCC polling is started when there is an ongoing multiparty
call and a new call appears in the system. A simple way to reproduce
the crashing scenario is:

1. Place a call.
2. Place a second call.
3. Create a multiparty call with both calls.
4. Place a third call (incoming or outgoing does not matter).
5. Disconnect HFP from the modem.

Within the function ciev_callheld_notify, the AT+CLCC command is also
invoked, thus a new cyclic CLCC polling is started, and it overwrites
the timer resource identifier stored in voicecall_data.clcc_source.
This means that there are several timers doing the CLCC polling, but
only one of those is under control, i.e. it can be removed through its
source identifier, hence a timer source leak.

This has a fatal consequence when the HFP modem is disconnected. The
function hfp_voicecall_remove stops the timer that is under control
before freeing the voicecall_data struct. However there are other timers
that are still active and will execute its handler poll_clcc afterwards.
Inside poll_clcc the driver_data is accessed, which is already NULL.

A solution for this is to avoid starting a CLCC polling if there is
already one active, i.e. clcc_source is not 0. By doing this the
uncontrolled timers will not cycle forever.

9 years agoRelease 1.15 1.15 upstream/1.15
Marcel Holtmann [Sun, 29 Jun 2014 20:20:08 +0000 (22:20 +0200)]
Release 1.15

9 years agogprs: provision the authentication method
Philip Paeps [Tue, 24 Jun 2014 09:57:06 +0000 (11:57 +0200)]
gprs: provision the authentication method

9 years agombpi: add support for provisioning the auth method
Philip Paeps [Tue, 24 Jun 2014 09:57:05 +0000 (11:57 +0200)]
mbpi: add support for provisioning the auth method

Use the authentication method from the mobile-broadband-provider-info
database if it is specified and supported (we support CHAP and PAP).
Default to CHAP if the database does not specify a method (i.e.: the
previous behaviour).

9 years agoinclude: add auth method to the provisioning API
Philip Paeps [Tue, 24 Jun 2014 09:57:04 +0000 (11:57 +0200)]
include: add auth method to the provisioning API

9 years agoAUTHORS: Mention Philip's contributions
Denis Kenzior [Sat, 21 Jun 2014 17:05:43 +0000 (12:05 -0500)]
AUTHORS: Mention Philip's contributions

9 years agoatmodem: set the PPP authentication method to use
Philip Paeps [Thu, 19 Jun 2014 10:07:07 +0000 (12:07 +0200)]
atmodem: set the PPP authentication method to use

9 years agogprs: Make the code a bit easier to read
Denis Kenzior [Sat, 21 Jun 2014 17:02:05 +0000 (12:02 -0500)]
gprs: Make the code a bit easier to read

9 years agogprs: make PPP authentication method configurable
Philip Paeps [Thu, 19 Jun 2014 10:07:08 +0000 (12:07 +0200)]
gprs: make PPP authentication method configurable

Add a new "AuthenticationMethod" property to select between "pap"
and "chap" PPP authentication, defaulting to "chap" (i.e.: previous
behaviour).

9 years agoinclude: add auth method to the gprs context API
Philip Paeps [Thu, 19 Jun 2014 10:07:06 +0000 (12:07 +0200)]
include: add auth method to the gprs context API

9 years agodoc: describe the AuthenticationMethod property
Philip Paeps [Thu, 19 Jun 2014 10:07:09 +0000 (12:07 +0200)]
doc: describe the AuthenticationMethod property

9 years agogatchat: Fix up minor coding style issues
Denis Kenzior [Sat, 21 Jun 2014 16:54:26 +0000 (11:54 -0500)]
gatchat: Fix up minor coding style issues

9 years agogatchat: implement PAP authentication
Philip Paeps [Thu, 19 Jun 2014 10:07:05 +0000 (12:07 +0200)]
gatchat: implement PAP authentication

Make the authentication method configurable, CHAP or PAP, defaulting to
CHAP (i.e.: previous behaviour).

Implementation details:

 o If PAP is configured, we NAK the CHAP authentication protocol option
   in LCP configuration requests and suggest PAP instead.  This works
   around the amusing requirement of 3GPP TS 29.061 that modems must
   send a forced positive acknowledgement of the authentication method
   tried (i.e.: the modem will successfully accept any CHAP handshake,
   but if the network only supports PAP, the modem will hang up
   when it tries and fails to activate the PDP context)

 o The PAP Authenticate-Request is resent a hard-coded three times at
   ten-second intervals.  This may be a bit too persistent.  Chances
   are if it doesn't work the first time, it'll never work, but the
   RFC insists that we MUST retry.

9 years agoAUTHORS: Mention Sergio's contributions
Denis Kenzior [Sat, 21 Jun 2014 16:46:28 +0000 (11:46 -0500)]
AUTHORS: Mention Sergio's contributions

9 years agohfpmodem: Split AT+VTS command into multiple +VTS
Sergio Checa Blanco [Fri, 20 Jun 2014 08:03:51 +0000 (10:03 +0200)]
hfpmodem: Split AT+VTS command into multiple +VTS

According to the standard "3GPP 27.007 v6.8.0" Appendix C.2.11,
when sending multiple DTMF characters, these must go in individual
+VTS commands for each tone. This adopts the AT modem approach.

Before: AT+VTS=1234\r
After:  AT+VTS=1;+VTS=2;+VTS=3;+VTS=4\r

10 years agotest: Adapt data test scripts to multi-modem
Alfonso Sanchez-Beato [Tue, 10 Jun 2014 08:27:17 +0000 (10:27 +0200)]
test: Adapt data test scripts to multi-modem

Some tests scripts were not ready to handle situations with more than
one modem present. This change fixes the data context scripts.

10 years agotest: Adapt voice call test scripts to multi-modem
Alfonso Sanchez-Beato [Tue, 10 Jun 2014 08:27:16 +0000 (10:27 +0200)]
test: Adapt voice call test scripts to multi-modem

Some tests scripts were not ready to handle situations with more than
one modem present. This change fixes the scripts that handle voice
calls.

10 years agohfp: Fix case where RING never arrives
Denis Kenzior [Fri, 30 May 2014 17:25:23 +0000 (12:25 -0500)]
hfp: Fix case where RING never arrives

10 years agohfp: Use proper prefix
Denis Kenzior [Wed, 21 May 2014 17:08:37 +0000 (12:08 -0500)]
hfp: Use proper prefix

Otherwise the BCS command can consume unsolicited notifications.

ofonod[3270]: < \r\n+BCS: 2\r\n
ofonod[3270]: > AT+BCS=2\r
ofonod[3270]: < \r\n+CIEV: 1,1\r\n
ofonod[3270]: < \r\n+CIEV: 2,0\r\n
ofonod[3270]: < \r\nOK\r\n

10 years agohandsfree: correct crash on connect of hfp
Andrew Earl [Tue, 22 Apr 2014 15:22:40 +0000 (16:22 +0100)]
handsfree: correct crash on connect of hfp

10 years agohandsfree: Rename driver function
Denis Kenzior [Thu, 10 Apr 2014 15:04:36 +0000 (10:04 -0500)]
handsfree: Rename driver function

To be more consistent with others in the same file

10 years agohandsfree: Simplify logic
Denis Kenzior [Thu, 10 Apr 2014 15:04:12 +0000 (10:04 -0500)]
handsfree: Simplify logic

10 years agohfp: Add CNUM query to handsfree interface for subscriber number
Andrew Earl [Tue, 8 Apr 2014 08:21:47 +0000 (09:21 +0100)]
hfp: Add CNUM query to handsfree interface for subscriber number

10 years agohandsfree: Rename variable
Denis Kenzior [Thu, 10 Apr 2014 14:40:57 +0000 (09:40 -0500)]
handsfree: Rename variable

10 years agohandsfree: Reflow logic
Denis Kenzior [Thu, 10 Apr 2014 14:36:11 +0000 (09:36 -0500)]
handsfree: Reflow logic

10 years agohandsfree: Remove function
Denis Kenzior [Thu, 10 Apr 2014 14:33:25 +0000 (09:33 -0500)]
handsfree: Remove function

No need for one line functions that are only used once

10 years agohandsfree: Rename function
Denis Kenzior [Thu, 10 Apr 2014 14:31:58 +0000 (09:31 -0500)]
handsfree: Rename function

No need for the ofono_ prefix here

10 years agohandsfree: Remove unneeded variable
Denis Kenzior [Thu, 10 Apr 2014 14:29:32 +0000 (09:29 -0500)]
handsfree: Remove unneeded variable

10 years agohandsfree: Remove unneeded variable i
Denis Kenzior [Thu, 10 Apr 2014 14:29:11 +0000 (09:29 -0500)]
handsfree: Remove unneeded variable i

10 years agohandsfree: style fixes for previous commit
Denis Kenzior [Thu, 10 Apr 2014 14:25:30 +0000 (09:25 -0500)]
handsfree: style fixes for previous commit