José Rivero [Thu, 18 Apr 2019 20:18:26 +0000 (13:18 -0700)]
If IPC connections fails, then remove active session. (#24082)
Russ Keldorph [Thu, 18 Apr 2019 18:11:59 +0000 (11:11 -0700)]
Merge pull request #24071 from AndyAyersMS/Fix24055
JIT: fix arm64 crossgen simd issue
Omair Majid [Thu, 18 Apr 2019 17:36:25 +0000 (13:36 -0400)]
Add a destructor for sos::GCHeap (#24072)
The constructor allocates memory via new[]. It should be freed up via
delete[] by a destructor to avoid a memory leak.
Jan Vorlicek [Thu, 18 Apr 2019 15:42:30 +0000 (17:42 +0200)]
Merge pull request #23853 from jkoritzinsky/cmake-ninja-fix
Fix CMake warning about clrjit.exports.in file when using Ninja generator
Jan Vorlicek [Thu, 18 Apr 2019 14:53:57 +0000 (16:53 +0200)]
Merge pull request #24066 from janvorli/put-back-cpu-limits
Put back the CPU limiting in GC
Jan Kotas [Thu, 18 Apr 2019 14:13:33 +0000 (07:13 -0700)]
Skip type sanity checks for CoreLib (#24074)
Benjamin Bartels [Thu, 18 Apr 2019 12:53:22 +0000 (13:53 +0100)]
Fixed ChunkEnumerator.Current NRE (#24076)
* Fixed ChunkEnumerator.Current NRE
* Added Nullable Flow analysis annotation comment
* Changed TODO-NULLABLE comment to link to appropriate issue
Jan Vorlicek [Thu, 18 Apr 2019 08:27:27 +0000 (10:27 +0200)]
Merge pull request #23934 from franksinankaya/gcc_cleanup_18
Integer Conversion Issues from GCC
Santiago Fernandez Madero [Thu, 18 Apr 2019 01:17:55 +0000 (20:17 -0500)]
Merge pull request #23762 from dotnet/NullableFeature
Nullable feature into master
Andy Ayers [Thu, 18 Apr 2019 00:03:12 +0000 (17:03 -0700)]
another similar fix
Andrew Au [Wed, 17 Apr 2019 18:37:26 +0000 (11:37 -0700)]
Removing the unnecessary friend relationship
Brian Sullivan [Wed, 17 Apr 2019 22:23:02 +0000 (15:23 -0700)]
Merge pull request #24067 from briansull/desktop-fix2
Fix for Desktop build break
Brian Sullivan [Wed, 17 Apr 2019 22:21:03 +0000 (15:21 -0700)]
Added comment on #endif
Andy Ayers [Wed, 17 Apr 2019 21:32:07 +0000 (14:32 -0700)]
JIT: fix arm64 crossgen simd issue
Need to check `supportSIMDType()` and not `featureSIMD` in rationalize.
Fixes #24055.
Andy Ayers [Wed, 17 Apr 2019 21:23:11 +0000 (14:23 -0700)]
JIT: ignore pinning of non-gc types (#24010)
We may see pin modifiers on locals that are not gc types.
Ignore these modifiers.
Closes #23950.
Also added a missing copyright header on an unrelated test.
Santiago Fernandez Madero [Wed, 17 Apr 2019 20:10:13 +0000 (15:10 -0500)]
Fix StringBuilder annotations and debug.asserts (#24069)
Sung Yoon Whang [Wed, 17 Apr 2019 20:05:57 +0000 (13:05 -0700)]
Runtime counters naming change and setting default rates. (#24052)
* Renaming runtime counters and giving them DisplayNames
* fix build err
* Adding default DisplayRateTimeScale to runtime counters
Eugene Rozenfeld [Wed, 17 Apr 2019 19:59:31 +0000 (12:59 -0700)]
Restrict morph add rearrangement. (#23984)
Morph has transformations
((x + const) + y) => ((x + y) + const)
and
((x + const1) + (y + const2)) => ((x + y) + (const1 + const2))
If x or y is a GC pointer and one of the int operands may be negative,
this may result in a byref temp that points outside of the ref object.
If the code is in a non-interruptible region and a GC happens, the byref
won't be updated.
This change disallows the transformations if one of the non-const
operands is a GC pointer.
Fixes #23792.
Sergey Andreenko [Wed, 17 Apr 2019 19:31:33 +0000 (12:31 -0700)]
Merge pull request #24065 from sandreenko/fixCoreFXScripts
Add --runtime-path to CoreFX test runner.
Brian Sullivan [Wed, 17 Apr 2019 18:18:09 +0000 (11:18 -0700)]
Fix for Desktop build break
Jarret Shook [Wed, 17 Apr 2019 18:06:16 +0000 (11:06 -0700)]
Add lvIsImplicitByRef information to lvaSetStruct (#19223)
Before implicit byrefs were tracked by setting lvIsParam and lvIsTemp.
This change explicitly adds a flag for implicitByRef instead of overloading.
In addition, it fixes the decision to copy an implicitByRef for arm64 varargs.
Temporarily bump weight on byref params to match old behavior and avoid codegen
diffs.
Re-enabled various tests and parts of tests.
Closes #20046
Closes #19860
Jan Vorlicek [Wed, 17 Apr 2019 17:59:41 +0000 (10:59 -0700)]
Put back the CPU limiting in GC
The CPU limiting was accidentally removed during refactoring of the CPU
groups support in GC. This change puts them back.
Sergey Andreenko [Wed, 17 Apr 2019 17:52:05 +0000 (10:52 -0700)]
Add --runtime-path to CoreFX test runner.
Tarek Mahmoud Sayed [Wed, 17 Apr 2019 16:54:51 +0000 (17:54 +0100)]
Update the types consumers of Index and Range (#24036)
* Update the types consumers of Index and Range
The C# compiler now can automatically support the indexers with Index and Range parameters on any type meet the conditions:
- The type exposes Length or Count property which returning integer.
- The type has indexer of integer parameter.
- The type has a Slice method which takes 2 integers
The change here is to remove the methods and indexers of the types which we previously added it as the compiler will automatically provide those.
* Remove the JIT failing test
Santiago Fernandez Madero [Wed, 17 Apr 2019 04:19:13 +0000 (21:19 -0700)]
Exclude ToString_NullFrame_ThrowsNullReferenceException test from nullable change
Omair Majid [Wed, 17 Apr 2019 03:18:37 +0000 (23:18 -0400)]
Fix a ZeroMemory call in methodcontext.cpp (#23843)
The argument is of type `GetArgTypeValue` and so the `sizeof()` should be
done on `GetArgTypeValue`, not on the different type `GetArgType`.
Next Turn [Wed, 17 Apr 2019 03:17:33 +0000 (11:17 +0800)]
Nit: Update comment (#23896)
dotnet-maestro-bot [Wed, 17 Apr 2019 03:15:18 +0000 (20:15 -0700)]
Update CoreClr to preview5-27616-71 (#24020)
dotnet-maestro[bot] [Wed, 17 Apr 2019 03:14:41 +0000 (20:14 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190415.16 (#24030)
- Microsoft.NETCore.Platforms - 3.0.0-preview5.19215.16
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19215.16
dotnet-maestro[bot] [Wed, 17 Apr 2019 03:14:22 +0000 (20:14 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190415.12 (#24029)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19215.12
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19215.12
Jeremy Koritzinsky [Wed, 17 Apr 2019 03:13:29 +0000 (20:13 -0700)]
Remove limits on IVT public key lengths. (#24042)
Tanner Gooding [Wed, 17 Apr 2019 03:13:12 +0000 (20:13 -0700)]
Changing Math.Max, Math.Min, Math.MaxMagnitude, and Math.MinMagnitude to propagate NaN inputs (#24039)
Levi Broderick [Wed, 17 Apr 2019 03:12:12 +0000 (20:12 -0700)]
Fix incorrect EHCount calculation (#24048)
Jan Vorlicek [Wed, 17 Apr 2019 03:11:35 +0000 (05:11 +0200)]
Fix incorrect thread affinitization (#24045)
The PAL_SetCurrentThreadAffinity was incorrectly adding the specified processor
to the current thread affinity set instead of setting the affinity to only
the processor specified.
It was causing significant performance hit in aspnet benchmarks on machines with
many cores.
This change crept in when I was refactoring the related code while removing
CPU groups emulation.
José Rivero [Wed, 17 Apr 2019 01:58:31 +0000 (18:58 -0700)]
[EventPipe] Minor bug fixes, and remove redundant/unused code. (#23956)
- Update MicrosoftDiagnosticsTracingTraceEventPackageVersion
- Delete connection if the request is unknown/unhandled
- Adding missing error handling.
- Provider names must be defined.
- Some renaming, error handling, and build warnings.
- Removing test code, and merge EventPipe::Enable functions.
- Remove commented/non-used lines.
Bruce Forstall [Tue, 16 Apr 2019 23:28:49 +0000 (16:28 -0700)]
Merge pull request #24037 from BruceForstall/ReduceStackRequirement
Reduce stack requirements of test
Sergey Andreenko [Tue, 16 Apr 2019 21:52:15 +0000 (14:52 -0700)]
Merge pull request #24002 from sandreenko/fixDesktopFailure
Another surgery fix for genPutArgStk to fix desktop build.
Santiago Fernandez Madero [Tue, 16 Apr 2019 20:24:55 +0000 (13:24 -0700)]
Fix if condition in AssemblyLoadContext
Sergey Andreenko [Tue, 16 Apr 2019 19:48:27 +0000 (12:48 -0700)]
Merge pull request #23947 from sandreenko/reenableSystem.ComponentModel.Composition.Tests
Reenable System.ComponentModel.Composition.Tests arm64 Windows.
Bruce Forstall [Tue, 16 Apr 2019 18:52:04 +0000 (11:52 -0700)]
Reduce stack requirements of test
Fixes #24021
Sergey Andreenko [Tue, 16 Apr 2019 18:12:13 +0000 (11:12 -0700)]
Use lvaGetDesc.
Stephen Toub [Tue, 16 Apr 2019 17:24:31 +0000 (13:24 -0400)]
Nullable: Addition COM types (#24032)
Somehow these slipped through previous rounds of annotating.
Santiago Fernandez Madero [Tue, 16 Apr 2019 16:55:59 +0000 (09:55 -0700)]
Merge remote-tracking branch 'dotnet/master' into NullableFeature
Egor Chesakov [Tue, 16 Apr 2019 16:49:38 +0000 (09:49 -0700)]
Downgrade xUnit package version (#23944)
* Use the same version of xUnit that arcade uses (2.4.1-pre.build.4059)
Carol Eidt [Tue, 16 Apr 2019 16:35:49 +0000 (09:35 -0700)]
Arm64 vector ABI (#23675)
* Support for Arm64 Vector ABI
Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.
Also, fix and re-enable the disabled Arm64 Simd tests.
Fix #16022
Steve MacLean [Tue, 16 Apr 2019 15:23:43 +0000 (11:23 -0400)]
Test remove ContextualReflectionProxy (#24006)
Steve MacLean [Tue, 16 Apr 2019 15:20:31 +0000 (11:20 -0400)]
Update ContextualReflection doc (#24018)
* Update ContextualReflection doc
* PR Feedback
Omair Majid [Tue, 16 Apr 2019 14:43:09 +0000 (10:43 -0400)]
Use delete [] on array types (#24027)
Calling delete on types allocated with new[] leads to undefined
behaviour.
Filip Navara [Tue, 16 Apr 2019 13:52:53 +0000 (15:52 +0200)]
Move EventSource to shared CoreLib partition (#23925)
* Move most of EventSource to shared CoreLib partition
* Reenable some code that can be shared with Microsoft.Diagnostics.Tracing.EventSource.Redist in CoreFX
* Remove unused functions
* Fix placement of #endregion
* Clean up P/Invoke prototypes
* Move remaining code from EventSource_CoreCLR to shared partition (guarded by !CORERT)
* Remove more unnecessary marshalling attributes
* Move remaining CoreRT/ProjectN code to shared partition
* Avoid using Windows errors on non-Windows platforms
Sergey Andreenko [Tue, 16 Apr 2019 08:49:23 +0000 (01:49 -0700)]
Merge pull request #24009 from sandreenko/fixLsraBlockEpochCheck
Fix lsraBlockEpoch check.
Omair Majid [Tue, 16 Apr 2019 05:14:48 +0000 (01:14 -0400)]
Use NewArrayHolder for array types in src/debug (#24013)
Using a NewHolder with array types means that when the holder is ready
to release the memory, it ends up invoking `delete` (instead of
`delete[]`) on that array. This is an undefined behaviour.
Use NewArrayHolder isntead to fix this.
Omair Majid [Tue, 16 Apr 2019 05:12:39 +0000 (01:12 -0400)]
Use NewArrayHolder for array types (#24017)
This touches all the code outside of src/debug/.
Using a NewHolder with array types means that when the holder is ready
to release the memory, it ends up invoking `delete` (instead of
`delete[]`) on that array. This is an undefined behaviour.
Use NewArrayHolder instead to fix this.
Sinan Kaya [Fri, 12 Apr 2019 05:57:37 +0000 (05:57 +0000)]
Conversion issues
Egor Chesakov [Tue, 16 Apr 2019 04:07:33 +0000 (21:07 -0700)]
Fix an issue with literal 0xFFFFFFFFFFFFF000LL being treated as unsigned long long int (#24011)
Adeel Mujahid [Tue, 16 Apr 2019 02:36:44 +0000 (03:36 +0100)]
Update clr-configuration-knobs and cleanups (#24016)
Levi Broderick [Tue, 16 Apr 2019 01:28:39 +0000 (18:28 -0700)]
Fix incorrect bit match pattern in UTF-16 validation (#24015)
Jan Kotas [Tue, 16 Apr 2019 00:37:41 +0000 (17:37 -0700)]
Fold ResourceSet::CommonInit into constructor (#23993)
Sergey Andreenko [Mon, 15 Apr 2019 22:38:44 +0000 (15:38 -0700)]
Fix lsraBlockEpoch check.
Steve MacLean [Mon, 15 Apr 2019 23:59:36 +0000 (19:59 -0400)]
Initialize IsolatedComponentLoadContext.Name (#24001)
Egor Bogatov [Mon, 15 Apr 2019 23:44:04 +0000 (02:44 +0300)]
Add "partial" to MarshalAsAttribute (#24014)
Jan Kotas [Mon, 15 Apr 2019 23:30:00 +0000 (16:30 -0700)]
Delete unused YieldProcessorScalingFactor from GC (#23994)
Jan Kotas [Mon, 15 Apr 2019 23:29:41 +0000 (16:29 -0700)]
Remove redundant UnderlyingSystemType calls (#24000)
UnderlyingSystemType is virtual
Fadi Hanna [Mon, 15 Apr 2019 23:25:16 +0000 (16:25 -0700)]
Check for null methodhandle before checking if the method is in the same version bubble (#23940)
Sergiy Kuryata [Mon, 15 Apr 2019 23:07:35 +0000 (16:07 -0700)]
Fix precompiling CoreRoot overlay with crossgen for Windows arm/arm64 (#23946)
Jeremy Koritzinsky [Mon, 15 Apr 2019 22:54:51 +0000 (15:54 -0700)]
Opt COM methods out of the new Windows instance-method handling. (#23974)
* Opt COM methods out of the new Windows instance-method handling.
* Add test for an HResult "struct" returned from a COM method.
* Update ErrorMarshalTesting.cs
* Update "is member function" check on the ilmarshalers.h side to only consider thiscall.
Benjamin Bartels [Mon, 15 Apr 2019 22:09:10 +0000 (23:09 +0100)]
Improved performance of System.Reflection.Emit API (#23833)
* Improved performance of System.Reflection.Emit API
* Moved heap allocation to stack
* Eliminating conditional branch by casting sbyte to byte
* Reduced heap allocation of ScopeTree
* Removed redundant `unsafe` from function signature
Santiago Fernandez Madero [Mon, 15 Apr 2019 21:19:32 +0000 (16:19 -0500)]
Merge pull request #23997 from safern/merge-master-nullable
Merge master into nullable feature
Santiago Fernandez Madero [Mon, 15 Apr 2019 18:25:36 +0000 (11:25 -0700)]
Fix build errors from merge conflicts and compiler update
Sergey Andreenko [Mon, 15 Apr 2019 20:25:43 +0000 (13:25 -0700)]
Get rid of varNumInp.
Sergey Andreenko [Mon, 15 Apr 2019 19:15:26 +0000 (12:15 -0700)]
Another surgery fix for genPutArgStk to fix desktop build.
Vladimir Sadov [Mon, 15 Apr 2019 18:27:02 +0000 (18:27 +0000)]
Merge pull request #23981 from VSadov/arm32fix22422
Adjust plug_size_to_fit to consider large alignment on ARM32
Bruce Forstall [Mon, 15 Apr 2019 18:22:35 +0000 (11:22 -0700)]
Merge pull request #23996 from BruceForstall/Fix64BitAlignment
Fix test for 64-bit platforms
Bruce Forstall [Mon, 15 Apr 2019 18:19:39 +0000 (11:19 -0700)]
Fix test for 64-bit platforms
Object type in structs apparently must be 8 byte aligned.
Fixes #23986
dotnet-maestro[bot] [Mon, 15 Apr 2019 18:09:39 +0000 (11:09 -0700)]
[master] Update dependencies from dotnet/arcade (#23977)
* Update dependencies from https://github.com/dotnet/arcade build
20190414.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19214.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19214.2
dotnet-maestro[bot] [Mon, 15 Apr 2019 18:08:58 +0000 (11:08 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190414.10 (#23990)
- Microsoft.NETCore.App - 3.0.0-preview5-27614-10
Santiago Fernandez Madero [Mon, 15 Apr 2019 17:46:25 +0000 (10:46 -0700)]
Merge remote-tracking branch 'dotnet/master' into merge-master-nullable
dotnet-maestro-bot [Mon, 15 Apr 2019 16:39:47 +0000 (09:39 -0700)]
Update CoreClr to preview5-27615-71 (#23991)
dotnet-maestro[bot] [Mon, 15 Apr 2019 16:07:41 +0000 (09:07 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190414.16 (#23989)
- Microsoft.NETCore.Platforms - 3.0.0-preview5.19214.16
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19214.16
Marco Rossignoli [Mon, 15 Apr 2019 03:01:31 +0000 (05:01 +0200)]
improve entropy (#23591)
dotnet-maestro-bot [Mon, 15 Apr 2019 02:51:06 +0000 (19:51 -0700)]
Update CoreClr to preview5-27614-72 (#23985)
Stephen Toub [Mon, 15 Apr 2019 02:50:55 +0000 (22:50 -0400)]
Fix a few internal nullable annotations and comments (#23987)
Gergely Kalapos [Mon, 15 Apr 2019 02:44:53 +0000 (04:44 +0200)]
Fix typo in environment variable name - profiler loading doc (#23983)
Stephen Toub [Mon, 15 Apr 2019 01:29:22 +0000 (21:29 -0400)]
Nullable: System.Runtime.InteropServices.CustomMarshalers/WindowsRuntime (#23930)
Raz Friman [Mon, 15 Apr 2019 01:29:10 +0000 (11:29 +1000)]
Remove unused offset calculation (#23793)
Utf8Parser has a redundant calculation of date time offset.
Fix #21834
Levi Broderick [Mon, 15 Apr 2019 01:26:05 +0000 (18:26 -0700)]
Remove old method names from Rune (#23938)
* Remove old method names from Rune, reenable suppressed tests
* Revert re-enablement of failing ArraySegment tests
vsadov [Sun, 14 Apr 2019 21:21:28 +0000 (14:21 -0700)]
Removed support for short plug padding in `fit`.
Best fit is only done for gen1->gen2, and thus there is no padding.
dotnet-maestro-bot [Sun, 14 Apr 2019 20:49:39 +0000 (13:49 -0700)]
Update CoreClr to preview5-27614-71 (#23978)
vsadov [Sun, 14 Apr 2019 18:02:35 +0000 (11:02 -0700)]
Adjust plug_size_to_fit to consider large alignment om ARM32
Gergely Kalapos [Sun, 14 Apr 2019 17:16:24 +0000 (19:16 +0200)]
Fix broken new lines (#23979)
These files don't render correctly on github due to broken new lines - fixing it. Only new line characters replaced, nothing else touched.
Jan Kotas [Sun, 14 Apr 2019 04:54:08 +0000 (21:54 -0700)]
Move GCMemoryInfo to shared partition
Jan Kotas [Sat, 13 Apr 2019 21:10:26 +0000 (14:10 -0700)]
Fix AssemblyName regression
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jan Kotas [Sat, 13 Apr 2019 16:36:03 +0000 (09:36 -0700)]
Move GCMemoryInfo to shared partition
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-maestro-bot [Sun, 14 Apr 2019 03:18:15 +0000 (20:18 -0700)]
Update BuildTools, CoreClr to preview4-03913-01, preview5-27612-73, respectively (master) (#23916)
* Update BuildTools, CoreClr to preview4-03913-01, preview5-27612-73, respectively
* Fix nullable build errors
Jan Kotas [Sun, 14 Apr 2019 03:15:48 +0000 (20:15 -0700)]
Delete unused AssemblyName._hashForControl and related code (#23972)
Steve MacLean [Sat, 13 Apr 2019 23:03:56 +0000 (19:03 -0400)]
EnterContextualReflection handle null (#23953)
* EnterContextualReflection handle null
* Add ContextualReflection MockAssembly test
* Fix ContextualReflection typo
Egor Chesakov [Sat, 13 Apr 2019 19:09:53 +0000 (12:09 -0700)]
Use xUnit TestOutputHelper to get proper test output in Azure DevOps Tests Explorer (#23957)
Jan Kotas [Sat, 13 Apr 2019 19:07:09 +0000 (12:07 -0700)]
Delete outdated comment (#23967)
Next Turn [Sat, 13 Apr 2019 19:06:35 +0000 (03:06 +0800)]
Remove unnecessary ThrowIfCreated call (#23839)
dotnet-maestro[bot] [Sat, 13 Apr 2019 19:04:11 +0000 (12:04 -0700)]
[master] Update dependencies from dotnet/arcade (#23926)
* Update dependencies from https://github.com/dotnet/arcade build
20190412.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19212.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19212.2
mikedn [Sat, 13 Apr 2019 17:39:20 +0000 (20:39 +0300)]
Fix ARM's genPutArgStk codegen (#23867)
* Fix ARM's genPutArgStk codegen
When the OBJ node wraps a LCL_VAR node the code uses the type information (struct size, GC layout) from LclVarDsc. This is not always correct because the OBJ may actually have a different struct type due to type reinterpretation (e.g. Unsafe.As<X, Y>).
* Fix genPutArgStk comment