Philip Withnall [Sat, 13 Aug 2011 17:56:30 +0000 (18:56 +0100)]
inspect: Fix listing GStrv properties
We have to work around bgo#656467 for the moment.
Philip Withnall [Sat, 13 Aug 2011 17:05:50 +0000 (18:05 +0100)]
inspect: Update folks-inspect for the FieldDetails changes
Travis Reitter [Sat, 13 Aug 2011 10:18:29 +0000 (12:18 +0200)]
Make the EDS backend's system address book the default writeable
Closes: bgo#648818 - Support the EDS backend being a primary
Travis Reitter [Sat, 13 Aug 2011 10:20:02 +0000 (12:20 +0200)]
Trivial NEWS clean-up.
Travis Reitter [Thu, 11 Aug 2011 14:44:53 +0000 (16:44 +0200)]
Remove FieldDetails (obsoleted by AbstractFieldDetails and implementors)
Travis Reitter [Thu, 11 Aug 2011 14:37:22 +0000 (16:37 +0200)]
Support vCard-like parameters for URLs
Closes: bgo#655922 - Rebase UrlDetails.urls upon an
AbstractFieldDetails-derived class
Travis Reitter [Thu, 11 Aug 2011 11:23:01 +0000 (13:23 +0200)]
Support vCard-like parameters for Roles
Closes: bug#655921 - Change RoleDetails.roles to support vCard-like arbitrary parameters
Travis Reitter [Tue, 9 Aug 2011 15:40:41 +0000 (17:40 +0200)]
Support vCard-like parameters for web service addresses
Closes: bgo#653682 - Change WebServiceDetails.web_service_addresses to support
vCard-like arbitrary parameters
Travis Reitter [Tue, 9 Aug 2011 13:59:16 +0000 (15:59 +0200)]
Rebase PhoneDetails.phone_numbers upon PhoneFieldDetails
Closes: bgo#655920 - Rebase PhoneDetails.phone_numbers upon an
AbstractFieldDetails-derived class
Travis Reitter [Mon, 8 Aug 2011 15:27:04 +0000 (17:27 +0200)]
Allow for Individual replacement in the EDS add-persona test.
Travis Reitter [Mon, 8 Aug 2011 14:08:36 +0000 (16:08 +0200)]
Rebase NoteDetails.notes upon NoteFieldDetails
Closes: bgo#655919 - Rebase NoteDetails.notes upon an
AbstractFieldDetails-derived class
Travis Reitter [Thu, 4 Aug 2011 01:43:17 +0000 (18:43 -0700)]
Set the eds backend as the primary for the eds tests.
This fixes the eds/link-personas test.
Travis Reitter [Wed, 3 Aug 2011 20:49:32 +0000 (13:49 -0700)]
Rebase EmailDetails.email_addresses upon EmailFieldDetails
Closes: bgo#655917 - Rebase EmailDetails.email_addresses upon an
AbstractFieldDetails-derived class
Travis Reitter [Wed, 3 Aug 2011 20:47:24 +0000 (13:47 -0700)]
Run key-file tests later, since it's a low-priority backend.
Travis Reitter [Wed, 3 Aug 2011 20:29:44 +0000 (13:29 -0700)]
Run Tracker tests last, since it's a low-priority backend.
They're also most likely to fail for reasons outside of our control.
Travis Reitter [Tue, 2 Aug 2011 22:12:24 +0000 (15:12 -0700)]
Add utility function to compare MultiMaps of AbstractFieldDetails.
Travis Reitter [Fri, 22 Jul 2011 23:49:40 +0000 (16:49 -0700)]
Clarify parameters for PostalAddressOwnerDetails.
Travis Reitter [Tue, 12 Jul 2011 18:20:56 +0000 (11:20 -0700)]
Add basic equality testing for ImFieldDetails.
Helps: bug#653680 - Change ImDetails.im_addresses to support vCard-like
arbitrary parameters
Travis Reitter [Thu, 14 Jul 2011 18:08:43 +0000 (11:08 -0700)]
Support vCard-like parameters for IM addresses
Helps: bug#653680 - Change ImDetails.im_addresses to support vCard-like
arbitrary parameters
Travis Reitter [Fri, 8 Jul 2011 23:35:15 +0000 (16:35 -0700)]
Clean up the way the Tracker backend tracks IM addresses.
Helps: bug#653680 - Change ImDetails.im_addresses to support vCard-like
arbitrary parameters
Travis Reitter [Fri, 8 Jul 2011 21:14:21 +0000 (14:14 -0700)]
Don't spill over 80 characters.
Travis Reitter [Thu, 14 Jul 2011 18:38:31 +0000 (11:38 -0700)]
Support vCard-like parameters for addresses in PostalAddressDetails.
This also removes the older, less-functional, less-consistent
PostalAddress.types.
Helps: bgo#653679 - Change PostalAddressDetails.postal_addresses to
support vCard-like arbitrary parameters
Travis Reitter [Tue, 12 Jul 2011 18:48:43 +0000 (11:48 -0700)]
Add test for parameter equality in FieldDetails.
Helps: bgo#653679 - Change PostalAddressDetails.postal_addresses to
support vCard-like arbitrary parameters
Travis Reitter [Tue, 12 Jul 2011 18:17:12 +0000 (11:17 -0700)]
Add basic equality testing for FieldDetails.
Helps: bgo#653679 - Change PostalAddressDetails.postal_addresses to
support vCard-like arbitrary parameters
Travis Reitter [Fri, 15 Jul 2011 23:36:33 +0000 (16:36 -0700)]
Add parameters as an optional argument to the FieldDetails constructor.
Helps: bgo#653679 - Change PostalAddressDetails.postal_addresses to
support vCard-like arbitrary parameters
Travis Reitter [Wed, 13 Jul 2011 22:35:00 +0000 (15:35 -0700)]
Implement FieldDetails.equal()/hash() in terms of the default.
This allows explicit references to FieldDetails.equal()/hash() for
structures storing them (in case it changes from the
AbstractFieldDetails implementation in the future).
Helps: bgo#653679 - Change PostalAddressDetails.postal_addresses to
support vCard-like arbitrary parameters
Travis Reitter [Tue, 12 Jul 2011 00:20:54 +0000 (17:20 -0700)]
Add equal() and hash() functions to AbstractFieldDetails.
Helps: bgo#653679 - Change PostalAddressDetails.postal_addresses to
support vCard-like arbitrary parameters
Travis Reitter [Thu, 14 Jul 2011 23:57:01 +0000 (16:57 -0700)]
Centralize parameters to AbstractFieldDetails.
This cuts some lines of code from the derived classes.
Helps: bgo#653679 - Change PostalAddressDetails.postal_addresses to
support vCard-like arbitrary parameters
Travis Reitter [Thu, 7 Jul 2011 18:10:58 +0000 (11:10 -0700)]
Rebase FieldDetails upon an abstract and generic version of itself.
This should be useful for cases where the value has a very specific type
(eg, for PostalAddressDetails.postal_addresses). We'll create subclasses of
FieldDetails for those cases.
When we've created all the appropriate derived classes, we'll remove
FieldDetails entirely.
Helps: bgo#653679 - Change PostalAddressDetails.postal_addresses to
support vCard-like arbitrary parameters
Philip Withnall [Tue, 9 Aug 2011 10:49:31 +0000 (12:49 +0200)]
core: Expand the documentation of EmailDetails.email_addresses
Philip Withnall [Tue, 9 Aug 2011 10:23:27 +0000 (12:23 +0200)]
build: Add VAPI dependencies for eds backend
Philip Withnall [Tue, 9 Aug 2011 10:23:13 +0000 (12:23 +0200)]
core: Fix a typo in NoteDetails documentation
Philip Withnall [Tue, 9 Aug 2011 10:19:11 +0000 (12:19 +0200)]
Bug 653619 — Add company details
I dislike Tracker, ontologies, Sparql and drinking games.
Closes: bgo#653619
Philip Withnall [Sun, 7 Aug 2011 11:52:40 +0000 (13:52 +0200)]
eds: Fix a minor type problem in the add-contacts-stress-test
Philip Withnall [Sun, 7 Aug 2011 11:36:11 +0000 (13:36 +0200)]
build: Build eds backend by default
Signed-off-by: Raul Gutierrez Segales <rgs@collabora.co.uk>
Raul Gutierrez Segales [Fri, 5 Aug 2011 18:49:58 +0000 (19:49 +0100)]
e-d-s: fix link personas test
We've changed the way we set up the writeable store in
commit
5c062183b (bug #654907) and that broke this test.
Raul Gutierrez Segales [Wed, 3 Aug 2011 09:13:42 +0000 (10:13 +0100)]
Don't set a timeout for contacts adding stress test
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=655008
Philip Withnall [Wed, 20 Jul 2011 21:08:00 +0000 (22:08 +0100)]
Bug 655008 — Tidy up error handling in eds backend
Return more specific error codes from Edsf.PersonaStore methods where
possible, and in all cases make sure we've got a switch statement on the
incoming error code. Closes: bgo#655008
Philip Withnall [Tue, 2 Aug 2011 22:20:07 +0000 (23:20 +0100)]
Clarify the documentation of PersonaStore.is_writeable
Closes: bgo#652657
Philip Withnall [Tue, 2 Aug 2011 22:04:58 +0000 (23:04 +0100)]
Bug 649296 — Folks backend files shouldn't begin with "lib"
Rename the backend library files from “libfolks-backend-${BACKEND_NAME}.so”
to “${BACKEND_NAME}.so”.
Closes: bgo#649296
Philip Withnall [Wed, 3 Aug 2011 20:41:38 +0000 (21:41 +0100)]
eds: Minor fixes to documentation comment syntax
Raul Gutierrez Segales [Tue, 2 Aug 2011 10:47:37 +0000 (11:47 +0100)]
e-d-s: add test for Gender property
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=655745
Raul Gutierrez Segales [Tue, 2 Aug 2011 10:45:34 +0000 (11:45 +0100)]
e-d-s: Implement read/write support for gender property
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=655745
Raul Gutierrez Segales [Thu, 21 Jul 2011 00:33:50 +0000 (01:33 +0100)]
Configure the writeable store by type_id and store id
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=654907
Travis Reitter [Tue, 2 Aug 2011 17:48:53 +0000 (10:48 -0700)]
Add rules for uploading generated docs to freedesktop.org
In the future, we should copy the remaining rules from telepathy-glib's setup,
which restrict doc uploads to releases (as well as simplifying other details of
releases).
Travis Reitter [Mon, 1 Aug 2011 22:16:26 +0000 (15:16 -0700)]
Build eds docs along with others.
Travis Reitter [Mon, 1 Aug 2011 22:31:04 +0000 (15:31 -0700)]
Fix syntax error in valadoc for Edsf.PersonaStore.remove_persona.
Travis Reitter [Mon, 1 Aug 2011 22:25:04 +0000 (15:25 -0700)]
Fix syntax error in valadoc for Edsf.PersonaStore.prepare.
Travis Reitter [Mon, 1 Aug 2011 22:21:18 +0000 (15:21 -0700)]
Fix link in Edsf.Persona docs to Folks.AvatarDetails.avatar.
Travis Reitter [Mon, 1 Aug 2011 21:43:18 +0000 (14:43 -0700)]
Build libsocialweb docs along with others.
Travis Reitter [Mon, 1 Aug 2011 21:58:25 +0000 (14:58 -0700)]
Fix link in Swf.Persona docs to Folks.AvatarDetails.avatar.
Travis Reitter [Mon, 1 Aug 2011 22:22:12 +0000 (15:22 -0700)]
Fix link in Trf.Persona docs to Folks.AvatarDetails.avatar.
Travis Reitter [Mon, 1 Aug 2011 22:01:16 +0000 (15:01 -0700)]
Centralize .PHONY doc targets.
Travis Reitter [Mon, 1 Aug 2011 21:45:17 +0000 (14:45 -0700)]
Centralize definition of doc dirs to distclean.
Travis Reitter [Mon, 1 Aug 2011 21:16:39 +0000 (14:16 -0700)]
Bump the required version of valadoc.
Travis Reitter [Mon, 1 Aug 2011 21:16:24 +0000 (14:16 -0700)]
Actually check for the valadoc version when building docs.
Travis Reitter [Mon, 1 Aug 2011 21:09:10 +0000 (14:09 -0700)]
Work around valadoc parsing bug with indented comments.
Raul Gutierrez Segales [Mon, 1 Aug 2011 18:31:37 +0000 (19:31 +0100)]
Give public access to properties for which there is write support
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=655610
Raul Gutierrez Segales [Mon, 1 Aug 2011 17:52:14 +0000 (18:52 +0100)]
Make the Edsf.Persona class follow our coding style
Besides adhering to our coding style, this also
works around a bug in Vala that allows accessing
public string foo { get; set; }
through _foo.
Works around: https://bugzilla.gnome.org/show_bug.cgi?id=655741
Philip Withnall [Fri, 29 Jul 2011 19:44:50 +0000 (20:44 +0100)]
core: Remove unused PotentialMatch.result_to_string() method
Philip Withnall [Fri, 29 Jul 2011 19:06:55 +0000 (20:06 +0100)]
docs: Fix up lots of minor issues in the documentation comments
Philip Withnall [Fri, 29 Jul 2011 16:24:59 +0000 (17:24 +0100)]
core: Make PotentialMatch.jaro_dist() private
Philip Withnall [Wed, 27 Jul 2011 22:44:43 +0000 (23:44 +0100)]
inspect: Add a linking command
Philip Withnall [Wed, 27 Jul 2011 22:43:14 +0000 (23:43 +0100)]
individual: Fix linking when personas are moved between individuals weirdly
It's possible (likely, even) for a set of personas to move between two
individuals during linking. Previously, bad things would happen to
persona.individual if the personas weren't correctly removed from the first
individual before being added to the second (e.g. if they were added to the
second individual before being removed from the first). This fixes that.
Philip Withnall [Tue, 26 Jul 2011 21:56:44 +0000 (22:56 +0100)]
tests: Add a basic refcounting test for linked individuals
Philip Withnall [Tue, 26 Jul 2011 21:32:51 +0000 (22:32 +0100)]
individual: Add more debug output to Individual
Philip Withnall [Mon, 25 Jul 2011 21:58:15 +0000 (22:58 +0100)]
aggregator: Ensure we don't remove Personas we're adding
If a two Personas with the same UID are in the added and removed sets for a
single call to personas_changed_cb() in the individual aggregator, make sure
that we remove the old instance and replace it with the new instance, instead
of just removing both instances. This covers the case where the real instance
of a (Tpf.) Persona disappears and is immediately replaced by its cached
copy.
NOTE: This needs more testing.
Philip Withnall [Thu, 16 Jun 2011 17:35:52 +0000 (18:35 +0100)]
Bug 652643 — Add PersonaStore cache
Use ObjectCache in Tpf.PersonaStore.
Closes: bgo#652643
Philip Withnall [Thu, 16 Jun 2011 17:33:26 +0000 (18:33 +0100)]
Add a generic caching object to the core of folks
This adds the ObjectCache API.
Helps: bgo#652643
Philip Withnall [Thu, 16 Jun 2011 17:32:06 +0000 (18:32 +0100)]
Unset the self-contact on Tpf.PersonaStore when resetting the store
Philip Withnall [Mon, 13 Jun 2011 09:54:23 +0000 (10:54 +0100)]
Bug 650414 — Need better APIs to handle image data
Change AvatarDetails.avatar to have type LoadableIcon. By introducing
a libfolks-wide avatar cache, propagate this change to all the backends.
This breaks the API of AvatarDetails.
Closes: bgo#650414
Travis Reitter [Thu, 21 Jul 2011 14:46:38 +0000 (07:46 -0700)]
Add missing copyright/license notices to tests.
Travis Reitter [Wed, 20 Jul 2011 18:28:40 +0000 (11:28 -0700)]
Don't notify twice for EDS Persona nickname changes.
Closes: bgo#655019 - Don't notify twice for nickname changes
Travis Reitter [Wed, 20 Jul 2011 18:28:12 +0000 (11:28 -0700)]
Return early when setting an Edsf.Persona attribute to its current value.
Helps: bgo#655019 - Don't notify twice for nickname changes
Travis Reitter [Thu, 21 Jul 2011 20:16:08 +0000 (13:16 -0700)]
Allow Edsf.PersonaStore._set_*name() sname arg to be null.
Helps: bgo#655019 - Don't notify twice for nickname changes
Travis Reitter [Thu, 21 Jul 2011 20:14:15 +0000 (13:14 -0700)]
Allow Edsf.PersonaStore._set_*avatar() avatar arg to be null.
Helps: bgo#655019 - Don't notify twice for nickname changes
Travis Reitter [Wed, 20 Jul 2011 18:29:57 +0000 (11:29 -0700)]
Make Folks.Utils public and add Gee structure equality checking.
Helps: bgo#655019 - Don't notify twice for nickname changes
Travis Reitter [Thu, 21 Jul 2011 16:41:58 +0000 (09:41 -0700)]
Update for
142f9b74: make Individual.calendar_event_id nullable
Travis Reitter [Wed, 20 Jul 2011 18:29:45 +0000 (11:29 -0700)]
Un-break the EDS PersonaStore test for groups.
Philip Withnall [Sun, 10 Jul 2011 18:52:03 +0000 (19:52 +0100)]
Make BirthdayDetails.calendar_event_id nullable
This includes expanding its documentation a little.
Philip Withnall [Sun, 10 Jul 2011 18:43:20 +0000 (19:43 +0100)]
Fix visibility of TrfPersona.postal_addresses setter
Philip Withnall [Sun, 10 Jul 2011 18:42:25 +0000 (19:42 +0100)]
Add a default implementation of TrfPersona.calendar_event_id
It was missing; it might as well return a sensible default value and not
allow setting of the value rather than doing nothing.
Philip Withnall [Sun, 10 Jul 2011 18:41:46 +0000 (19:41 +0100)]
Fix visibility of TpfPersona.avatar and SwfPersona.avatar setters
Philip Withnall [Sun, 10 Jul 2011 18:41:23 +0000 (19:41 +0100)]
Minor documentation fix for SwfPersona.avatar
Philip Withnall [Sun, 10 Jul 2011 18:38:16 +0000 (19:38 +0100)]
Bug 650422 — Add API for easily checking whether details are writeable
Add Persona.writeable_properties, listing the properties of that Persona
for which updated values will be stored. It's intended that the property
value will be constant for a given Persona subclass, but this isn't
guaranteed; it's possible that Persona subclasses may vary the value of
writeable-properties at run time in future.
Closes: bgo#650422
Tiffany Antopolski [Wed, 20 Jul 2011 13:48:01 +0000 (15:48 +0200)]
Minor style change in presence-details.vala
Moved left brace of enum from end of line
to start of next line to match Folks style.
Philip Withnall [Sun, 3 Jul 2011 19:38:29 +0000 (20:38 +0100)]
Bug 645549 — Add a way to get the individual from a persona
Add a Persona.individual property which is updated by
Individual._connect_to_persona() and ._disconnect_from_persona() as
appropriate, so should remain in lock-step with the Individual whose persona
set the Persona instance is currently in.
Closes: bgo#645549
Philip Withnall [Sun, 3 Jul 2011 19:18:33 +0000 (20:18 +0100)]
Ensure that all modifications of Individual.personas happen in _set_personas()
This ensures that signals are handled consistently, and the overall internal
state of the Individual is kept consistent. This probably also fixes the
implementation of store_removed signal handling for Individuals, which looked
rather broken.
Philip Withnall [Sun, 10 Jul 2011 17:44:31 +0000 (18:44 +0100)]
Fix the error domain of PersonaStore.remove_persona()
Philip Withnall [Sun, 10 Jul 2011 17:41:25 +0000 (18:41 +0100)]
Bug 652425 — Failure codes for removing personas needed in PersonaStoreError
Add PersonaStoreError.PERMISSION_DENIED and PersonaStoreError.REMOVE_FAILED,
which will be useful for the e-d-s backend.
Closes: bgo#652425
Philip Withnall [Sat, 25 Jun 2011 09:13:01 +0000 (10:13 +0100)]
Remove AliasDetails support from Trf.Persona
The persona's alias was being stored as its nickname. Since we want to make
nicknames writeable (bgo#652048) we have to store the nickname there
instead. There's no ontology for storing aliases, so AliasDetails support
has to be dropped.
Closes: bgo#652048 — Make Individual.nickname writeable
Travis Reitter [Tue, 19 Jul 2011 16:03:59 +0000 (09:03 -0700)]
Support nickname writability in the EDS backend.
Helps: bgo#652048 — Make Individual.nickname writeable
Philip Withnall [Sat, 25 Jun 2011 09:11:39 +0000 (10:11 +0100)]
Allow NameDetails.nickname to be writeable
Helps: bgo#652048 — Make Individual.nickname writeable
Travis Reitter [Mon, 18 Jul 2011 23:09:53 +0000 (16:09 -0700)]
Un-break parallel building the eds backend.
It would fail after a maintainer-clean or distclean with:
make[4]: *** No rule to make target `folks-eds.vapi', needed by `all-am'.
Stop.
make[4]: *** Waiting for unfinished jobs....
This is because we were setting VALAFLAGS, which was overriding the
definition from configure.ac and generally causing havok.
Travis Reitter [Mon, 18 Jul 2011 22:07:48 +0000 (15:07 -0700)]
Cut unreachable libsocialweb test code.
Philip Withnall [Wed, 13 Jul 2011 22:06:50 +0000 (23:06 +0100)]
eds: Add support for contact groups/categories
Philip Withnall [Wed, 13 Jul 2011 22:04:45 +0000 (23:04 +0100)]
eds: Mark read-only address books as non-addable-to and non-removable-from
Philip Withnall [Wed, 13 Jul 2011 22:02:52 +0000 (23:02 +0100)]
eds: Fix persona store removal in the Backend
Embarrassing typo.
Philip Withnall [Wed, 13 Jul 2011 22:01:55 +0000 (23:01 +0100)]
inspect: Don't print details of unprepared persona stores
We're not supposed to, and they're not very useful anyway. Instead, we now
print a message saying that the persona store is not prepared.
Philip Withnall [Wed, 13 Jul 2011 18:30:01 +0000 (19:30 +0100)]
eds: Fix linker warnings for the e-d-s backend tests