danmosemsft [Mon, 23 Jan 2017 17:47:29 +0000 (09:47 -0800)]
Remove disabled FEATURE_COMPRESSEDSTACK
danmosemsft [Mon, 23 Jan 2017 17:45:52 +0000 (09:45 -0800)]
Remove disabled FEATURE_COMINTEROP_WINRT_DESKTOP_HOST
danmosemsft [Mon, 23 Jan 2017 17:43:51 +0000 (09:43 -0800)]
Remove disabled FEATURE_COMINTEROP_MANAGED_ACTIVATION
danmosemsft [Mon, 23 Jan 2017 17:34:23 +0000 (09:34 -0800)]
Remove disabled FEATURE_CODEPAGES_FILE
danmosemsft [Mon, 23 Jan 2017 17:32:26 +0000 (09:32 -0800)]
Remove disabled FEATURE_CASE_SENSITIVE_FILESYSTEM
danmosemsft [Mon, 23 Jan 2017 17:31:11 +0000 (09:31 -0800)]
Remove disabled FEATURE_ADVANCED_MANAGED_ETW_CHANNELS
Dan Moseley [Mon, 23 Jan 2017 18:26:40 +0000 (11:26 -0700)]
Merge pull request #9044 from dotnet/redundant_defs
Remove always-defined symbols
danmosemsft [Mon, 23 Jan 2017 17:03:41 +0000 (09:03 -0800)]
Disable and remove FEATURE_APPDOMAIN_RESOURCE_MONITORING. This is a behavior change
Gaurav Khanna [Mon, 23 Jan 2017 16:56:08 +0000 (08:56 -0800)]
Merge pull request #9035 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24923-01, beta-24923-01, respectively (master)
Pat Gavlin [Mon, 23 Jan 2017 16:43:59 +0000 (16:43 +0000)]
Merge pull request #8724 from hqueue/arm/ryujit/fpaddconst
[Ryujit/ARM32] Implement const, comparion and intrinsic for floating-point
danmosemsft [Mon, 23 Jan 2017 16:43:46 +0000 (08:43 -0800)]
Revert "remove FEATURE_APPDOMAIN_RESOURCEMONITORING from corelib"
This reverts commit
9c6de0b7af3716eea3fc16a91ab8b7c2c92e6e98.
Ben Adams [Mon, 23 Jan 2017 16:24:21 +0000 (16:24 +0000)]
Remove some Diagnostics.Eventing allocations (#8869)
Remove some closure allocations
escapes string[] to static rather than function alloc
dotnet-bot [Mon, 23 Jan 2017 15:16:37 +0000 (15:16 +0000)]
Update CoreClr, CoreFx to beta-24923-01, beta-24923-01, respectively
Jonghyun Park [Mon, 23 Jan 2017 12:00:34 +0000 (21:00 +0900)]
[x86/Linux] Port two assertions in stackwalk.cpp (#9046)
Hyeongseok Oh [Mon, 23 Jan 2017 11:19:43 +0000 (20:19 +0900)]
[ARM32/Linux] cross-architecture build errro: stub for crossgen (#8917)
Fix union name in T_CONTEXT used by arm/stubs.cpp
Jonghyun Park [Mon, 23 Jan 2017 10:46:37 +0000 (19:46 +0900)]
[x86/Linux] Enable FEATURE_EH_FUNCLETS (#8889)
* [x86/Linux] (Partially) Enable FEATURE_EH_FUNCLETS
* Update CLR ABI Document
* Add TODO (for Funclet Prolog/Epilog Gen)
Koundinya Veluri [Mon, 23 Jan 2017 07:10:14 +0000 (23:10 -0800)]
Report by-ref-like types to the GC (SpanOfT) (#9034)
Report by-ref-like types to the GC (SpanOfT)
Fixes #8517
danmosemsft [Mon, 23 Jan 2017 04:55:11 +0000 (20:55 -0800)]
Remove FEATURE_WINDOWSPHONE
danmosemsft [Mon, 23 Jan 2017 04:50:23 +0000 (20:50 -0800)]
Remove FEATURE_VERSIONING
danmosemsft [Mon, 23 Jan 2017 04:48:38 +0000 (20:48 -0800)]
FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
danmosemsft [Mon, 23 Jan 2017 04:47:11 +0000 (20:47 -0800)]
Remove FEATURE_STRONGNAME_MIGRATION
danmosemsft [Mon, 23 Jan 2017 04:45:52 +0000 (20:45 -0800)]
Remove FEATURE_SPAN_OF_T and UseLegacyCompiler
danmosemsft [Mon, 23 Jan 2017 04:42:43 +0000 (20:42 -0800)]
Remove FEATURE_MULTICOREJIT
danmosemsft [Mon, 23 Jan 2017 04:41:06 +0000 (20:41 -0800)]
Remove FEATURE_MANAGED_ETW_CHANNELS
danmosemsft [Mon, 23 Jan 2017 04:37:25 +0000 (20:37 -0800)]
Remove FEATURE_MAIN_CLR_MODULE_USES_CORE_NAME
danmosemsft [Mon, 23 Jan 2017 04:36:11 +0000 (20:36 -0800)]
Remove FEATURE_LOADER_OPTIMIZATION
danmosemsft [Mon, 23 Jan 2017 04:34:38 +0000 (20:34 -0800)]
Remove FEATURE_HOST_ASSEMBLY_RESOLVER
danmosemsft [Mon, 23 Jan 2017 04:32:11 +0000 (20:32 -0800)]
Remove FEATURE_EXCEPTION_NOTIFICATIONS
danmosemsft [Mon, 23 Jan 2017 04:29:22 +0000 (20:29 -0800)]
Remove FEATURE_EXCEPTIONDISPATCHINFO
danmosemsft [Mon, 23 Jan 2017 04:27:03 +0000 (20:27 -0800)]
Remove FEATURE_CORRUPTING_EXCEPTIONS
danmosemsft [Mon, 23 Jan 2017 04:15:12 +0000 (20:15 -0800)]
remove FEATURE_CORESYSTEM
danmosemsft [Mon, 23 Jan 2017 04:08:05 +0000 (20:08 -0800)]
remove FEATURE_CORECLR (not used in cs)
danmosemsft [Tue, 17 Jan 2017 23:46:45 +0000 (15:46 -0800)]
Remove FEATURE_COLLECTIBLE_TYPES symbol
danmosemsft [Fri, 13 Jan 2017 00:26:06 +0000 (16:26 -0800)]
remove FEATURE_APPDOMAIN_RESOURCEMONITORING from corelib
Jan Vorlicek [Sat, 21 Jan 2017 09:46:27 +0000 (10:46 +0100)]
Remove __GNUC__ version checks (#8978)
This change removes obsolete `__GNUC__` version checks at several places.
The minimum supported clang version is 3.5 and that generates __GNUC__
value of 4.
James Ko [Sat, 21 Jan 2017 04:02:54 +0000 (23:02 -0500)]
Delete unused AppDomain{Setup} types/members (#8768)
* Delete unused AppDomain members
* Delete unused AppDomainSetup members
Joseph Tremoulet [Sat, 21 Jan 2017 03:36:31 +0000 (22:36 -0500)]
Merge pull request #9027 from JosephTremoulet/Comment
Fix incorrect comment
Mike McLaughlin [Sat, 21 Jan 2017 01:46:06 +0000 (17:46 -0800)]
Fix debugger launch race hitting breakpoints in startup code. (#8951)
The attached flag was been set asynchronously relative to the DebugActiveProcess
returning. This could cause a race where the initial module load notification being
missed/not sent to the debugger.
This fix sets the attached flag before any notifications sent during launch if the runtime was
launched/attached using the startup handshake after dbgshim tells the runtime to "continue"
when the runtime startup API callback returns.
Also fixes another race condition in dbgshim where EnumerateCLRs returns a NULL continue event
handle because the coreclr module was loaded but the g_hContinueStartupEvent wasn't initialized
on the runtime side yet. Changed the static initialization of g_hContinueStartupEvent to
INVALID_HANDLE_VALUE and the InternalEnumerateCLRs sleep/retry loop to retry when any of the
handles are INVALID_HANDLE_VALUE. This fixes the race only when you have the latest dbgshim
and coreclr binaries and the old/new mixes still function but don't fix the race.
Joseph Tremoulet [Fri, 20 Jan 2017 21:42:28 +0000 (16:42 -0500)]
Fix incorrect comment
Rewrite bogus reference to nonexistsent `m_HeapDef` to correctly refer to
`block->bbHeapDef`. Also change "doesn't kill heap" to "doesn't kill heap
liveness" (since it still kills availability).
Also add clarifying comments where `bbHeapUse` and `bbHeapDef` are
declared.
Jan Kotas [Sat, 21 Jan 2017 01:13:50 +0000 (17:13 -0800)]
Fixup Span<T> implementation to be more similar to the corefx one (#9028)
- Reorder methods, adjust comments and formatting to make it easier to see the diff with corefx
- Delete extra implicit conversion operator
Jan Vorlicek [Fri, 20 Jan 2017 23:32:12 +0000 (00:32 +0100)]
Remove PLATFORM_UNIX and FEATURE_PAL checks in PAL (#8982)
This change removes all ifdefs for PLATFORM_UNIX and FEATURE_PAL
from PAL and also removes dead code that was never compiled in PAL
due to both of them being always defined for PAL.
Carol Eidt [Fri, 20 Jan 2017 21:53:17 +0000 (13:53 -0800)]
Merge pull request #8814 from YongseopKim/impl_genIntToIntCast
[RyuJIT/ARM32]Implement NYI("Cast")
Gaurav Khanna [Fri, 20 Jan 2017 20:45:07 +0000 (12:45 -0800)]
Merge pull request #9008 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24920-03, beta-24919-06, respectively (master)
dotnet-bot [Fri, 20 Jan 2017 17:25:57 +0000 (17:25 +0000)]
Update CoreClr, CoreFx to beta-24920-03, beta-24919-06, respectively
Joseph Tremoulet [Fri, 20 Jan 2017 12:20:09 +0000 (07:20 -0500)]
Merge pull request #9004 from JosephTremoulet/MoreLessKillHeap
More heap liveness fixes
Evgeny Pavlov [Fri, 20 Jan 2017 11:59:34 +0000 (14:59 +0300)]
[GDB-JIT][Linux] Fix incorrect displaying of (s)byte and char in lldb (#9022)
* [GDB-JIT] Initial support of typedef for correct displaying 'byte' and 'sbyte'
* [GDB-JIT] Add char typedef to show correct type in lldb
* Code cleanup
Jonghyun Park [Fri, 20 Jan 2017 10:34:16 +0000 (19:34 +0900)]
[x86/Linux] Allow push/pop in funclet prolog and epilog (#9001)
* [x86/Linux] Allow Push/Pop in Funclet Prolog and Epilog
Jonghyun Park [Fri, 20 Jan 2017 10:33:06 +0000 (19:33 +0900)]
[x86/Linux] Port 'TransitionFrame::UpdateRegDisplay' (#8964)
* [x86/Linux] Port 'TransitionFrame::UpdateRegDisplay'
* Use different ControlPC/Esp values for WIN64EXCEPTIONS
Jonghyun Park [Fri, 20 Jan 2017 09:30:49 +0000 (18:30 +0900)]
[x86/Linux] Port 'CallerStackFrame::FromRegDisplay' (#9021)
Yongseop Kim [Wed, 4 Jan 2017 07:43:24 +0000 (16:43 +0900)]
Implement NYI(Cast) of codegen for Ryujit ARM32
Implement genIntToIntCast(), genFloatToFloatCast(),
genIntToFloatCast() and genFloatToIntCast() in codegenarm.cpp.
This commit bases upon ARM64 code.
(Code for int64/uint64 is marked as NYI_ARM)
Justin Van Patten [Fri, 20 Jan 2017 04:23:39 +0000 (23:23 -0500)]
Cleanup uses of string.Split (#9010)
Carol Eidt [Fri, 20 Jan 2017 02:24:45 +0000 (18:24 -0800)]
Merge pull request #8402 from CarolEidt/Fix7508
Enable promotion of SIMD fields of structs
Carol Eidt [Tue, 29 Nov 2016 17:18:31 +0000 (09:18 -0800)]
Enable promotion of SIMD fields of structs
Only look for SIMD fields if a SIMD type has been found.
Also, since more cases of local struct values are no longer marked GTF_GLOB_REF, adjust the heuristics for allocating a temporary for a struct arrRef.
Fix #7508
Jarret Shook [Fri, 20 Jan 2017 00:35:07 +0000 (16:35 -0800)]
Merge pull request #9013 from jashook/arm32_build_fix
Fix arm32 build break
jashook [Thu, 19 Jan 2017 22:15:43 +0000 (14:15 -0800)]
Fix arm32 build break
fgClearFinallyTargetBit requires computePreds to have happened in order
to sucessfully leave the bit unset for cases where there are multiple
CALLFINALLY / BBJ_ALWAYS pairs that point to the same finally target on
ARM.
The change adds an assertion to fgClearFinallyTargetBit in addition
to disabling the optimization on ARM.
Hyung-Kyu Choi [Thu, 22 Dec 2016 11:38:26 +0000 (20:38 +0900)]
Implement const, comparion and intrinsic for floating-point
Implement float/double const (GT_CNS_DBL) generation for ARM32 RyuJIT.
Implement binary operators for floating point for ARM32 RyuJIT
Implement of GT_INTRINSIC for ARM32 RyuJIT
Implement comparison (e.g. GT_GT and etc.) for floating-point
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Drew Scoggins [Thu, 19 Jan 2017 18:57:26 +0000 (10:57 -0800)]
Add mkdir for CoreFx directory
In PR 8997 I accidentally removed the mkdir that creates the corefx
directory for us to copy the test zip into. I did this when I was
adding Https to the URLs that we use to download the information from
Jenkins. This adds back that bit.
Gaurav Khanna [Thu, 19 Jan 2017 19:34:20 +0000 (11:34 -0800)]
Merge pull request #9005 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24919-03, beta-24919-02, respectively (master)
Pat Gavlin [Thu, 19 Jan 2017 18:33:24 +0000 (18:33 +0000)]
Merge pull request #8992 from seanshpark/remlegacyjit
[x86/Linux] Remove legacyjit and compatjit build
Pat Gavlin [Thu, 19 Jan 2017 18:32:36 +0000 (18:32 +0000)]
Merge pull request #8731 from mskvortsov/arm32-set-reg-to-cond
RyuJIT/ARM32: genSetRegToCond implementation
Pat Gavlin [Thu, 19 Jan 2017 18:30:08 +0000 (18:30 +0000)]
Merge pull request #8715 from mskvortsov/fix-icon-str-hdl-disp
Fix gtDispConst for GTF_ICON_STR_HDL.
Pat Gavlin [Thu, 19 Jan 2017 18:29:48 +0000 (18:29 +0000)]
Merge pull request #8725 from mskvortsov/fix-gtdisp-spacing
Fix gtDispLIRNode space alignment.
Drew Scoggins [Thu, 19 Jan 2017 18:27:43 +0000 (10:27 -0800)]
Merge pull request #8996 from DrewScoggins/LinuxCorefxNativeFix
Fix Linux perf run script
Drew Scoggins [Thu, 19 Jan 2017 18:27:22 +0000 (10:27 -0800)]
Merge pull request #8997 from DrewScoggins/HttpsFix
Change Http to Https
dotnet-bot [Thu, 19 Jan 2017 17:33:45 +0000 (17:33 +0000)]
Update CoreClr, CoreFx to beta-24919-03, beta-24919-02, respectively
Jonghyun Park [Thu, 19 Jan 2017 12:10:45 +0000 (21:10 +0900)]
[x86/Linux] Port 'FaultingExceptionFrame::UpdateRegDisplay' (#8993)
Jonghyun Park [Thu, 19 Jan 2017 12:05:51 +0000 (21:05 +0900)]
[x86/Linux] Port 'HelperMethodFrame::UpdateRegDisplay' (#8914)
* [x86/Linux] Port 'HelperMethodFrame::UpdateRegDisplay'
* Reduce code duplication
Michelle McDaniel [Thu, 19 Jan 2017 04:57:50 +0000 (20:57 -0800)]
Fix PInvoke Inline decision (#8975)
Originally, the condition was !impCanPInvokeInline, but when change
1e63ca0 pulled out impCanPInvokeInlineCall, the condition was flipped.
This was exposed by an internal debugger test.
Fixes DevDiv 366669.
Stephen Toub [Thu, 19 Jan 2017 03:17:04 +0000 (22:17 -0500)]
Merge pull request #8994 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24919-01, beta-24918-13, respectively (master)
dotnet-bot [Thu, 19 Jan 2017 01:45:52 +0000 (01:45 +0000)]
Update CoreClr, CoreFx to beta-24919-01, beta-24918-13, respectively
Drew Scoggins [Wed, 18 Jan 2017 19:19:22 +0000 (11:19 -0800)]
Change Http to Https
When we download things from Jenkins we used to use http for the
address we need to change this to https.
Jonghyun Park [Thu, 19 Jan 2017 00:56:56 +0000 (09:56 +0900)]
Fix an error in build-test.cmd (#8890)
* Fix an error in CMake Probe
* Add double qutation around %__ProjectDir
* Revert "Fix an error in CMake Probe"
This reverts commit
78be1c0a2909d633023758fdebcc558bf07e3a4c.
Carol Eidt [Thu, 19 Jan 2017 00:38:12 +0000 (16:38 -0800)]
Merge pull request #8991 from CarolEidt/Arm64ArrOffConsume
Fix consumeReg order for ArrOffs on arm64
Jonghyun Park [Thu, 19 Jan 2017 00:22:50 +0000 (09:22 +0900)]
[x86/Linux] Fix RtlRestoreContext (#8916)
* [x86/Linux] Fix RtlRestoreContext
* Use mov instead of push/pop
mikedn [Wed, 18 Jan 2017 23:49:36 +0000 (01:49 +0200)]
Remove ILDASM GUI cruft (#8954)
Jonghyun Park [Wed, 18 Jan 2017 23:35:46 +0000 (08:35 +0900)]
[x86/Linux] Do NOT use Shadow SP (#8913)
Gaurav Khanna [Wed, 18 Jan 2017 22:27:10 +0000 (14:27 -0800)]
Merge pull request #8977 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24918-03, beta-24918-07, respectively (master)
SaeHie Park [Wed, 18 Jan 2017 22:11:42 +0000 (07:11 +0900)]
[x86/Linux] Remove legacyjit and compatjit build
Enable legacyjit and compatjit build on i386 for Win32 but disable for Linux
Carol Eidt [Wed, 18 Jan 2017 20:39:29 +0000 (12:39 -0800)]
Fix consumeReg order for ArrOffs on arm64
The change in operand order for GenTreeArrOffs was not reflected in code generation for arm64. This fixes that.
Drew Scoggins [Wed, 18 Jan 2017 18:53:16 +0000 (10:53 -0800)]
Fix Linux perf run script
We rely on the build of CoreFX that we grab from the Corefx runs on the
main Jenkins instance. With the recent changes the name of one of the
folders as been changed from "Native" to "native". The checking that we
were doing was not case insensitive and as a result we started failing.
I have made that check now look for both the upper case and lower case
version of the word.
Joseph Tremoulet [Wed, 18 Jan 2017 18:10:11 +0000 (13:10 -0500)]
Merge pull request #8986 from JosephTremoulet/Unreachable
Refactor GT_IND value-numbering
Joseph Tremoulet [Wed, 18 Jan 2017 18:09:29 +0000 (13:09 -0500)]
Unsuppress heap use marking for legacy codegen
This change extends the same fix from #8757 to legacy-codegen.cpp; a prior
heap def in a block is not sufficient to avoid marking a subsequent heap
use in that block upwards-exposed (without proof that the def writes the
same memory read by the use).
Stephen Toub [Wed, 18 Jan 2017 18:08:39 +0000 (13:08 -0500)]
Merge pull request #8987 from stephentoub/remove_serialization_compat_workaround
Remove EnumEqualityComparer serialization compat workarounds
Joseph Tremoulet [Tue, 17 Jan 2017 19:42:24 +0000 (14:42 -0500)]
Fix inter-block heap-live-in calculation
Similar to the intra-block case fixed in #8757, without proving that a
heap def completely covers a subsequent heap use, we must propagate heap
liveness up past the heap def. Fix failure to so propagate liveness in
`LiveVarAnalysis::PerBlockAnalysis`.
dotnet-bot [Wed, 18 Jan 2017 17:36:17 +0000 (17:36 +0000)]
Update CoreClr, CoreFx to beta-24918-03, beta-24918-07, respectively
Jan Kotas [Wed, 18 Jan 2017 16:58:03 +0000 (08:58 -0800)]
Rollback parameter name change to fix failing corefx tests (#8985)
Stephen Toub [Wed, 18 Jan 2017 15:51:01 +0000 (10:51 -0500)]
Remove EnumEqualityComparer serialization compat workaround
This code exists to support serialization roundtrip between .NET 4 and .NET 4.5, which we don't need for .NET Core.
Stephen Toub [Wed, 18 Jan 2017 15:49:47 +0000 (10:49 -0500)]
Merge pull request #8984 from stephentoub/fix_dtfi_serialization
Fix DateTimeFormatInfo serialization on Unix
Stephen Toub [Wed, 18 Jan 2017 15:23:42 +0000 (10:23 -0500)]
Merge pull request #8970 from stephentoub/cwt_enum
Add ConditionalWeakTable.Clear and IEnumerable implementation
Joseph Tremoulet [Wed, 18 Jan 2017 14:59:53 +0000 (06:59 -0800)]
Refactor GT_IND value-numbering
Method `fgValueNumberTree` had two pieces of code each attempting to
assume responsibility for `GT_IND` and some block ops. The one later in
the function wasn't reachable because those ops would always take the
first path. This change moves the special logic for `GTF_IND_ARR_LEN`,
which was only present in the unreachable code, up to the reachable code,
and removes the unreachable code.
Stephen Toub [Wed, 18 Jan 2017 13:31:56 +0000 (08:31 -0500)]
Address PR feedback
Stephen Toub [Wed, 18 Jan 2017 13:22:54 +0000 (08:22 -0500)]
Fix DateTimeFormatInfo serialization on Unix
The Unix copy of the src is missing some [NonSerialized] attribution on a few of its fields, one of which is for a field of type TokenHashValue, which isn't [Serializable]. This is causing DateTimeFormatInfo to itself fail to serialize.
Jonghyun Park [Wed, 18 Jan 2017 09:45:09 +0000 (18:45 +0900)]
[x86/Linux] Port RtlVirtualUnwind (#8911)
* [x86/Linux] (Partially) port RtlVirtualUnwind
* Rewrite x86 Unwinder using UnwindStackFrame
* Extract UnwindStackFrame from EECodeManager
* Port 'InlinedCallFrame::UpdateRegDisplay'
Bruce Forstall [Wed, 18 Jan 2017 01:36:58 +0000 (17:36 -0800)]
Merge pull request #8851 from parjong/fix/JIT32_GCENCODER_build_error
Fix JIT32_GCENCODER-related build errors
Bruce Forstall [Wed, 18 Jan 2017 01:26:46 +0000 (17:26 -0800)]
Merge pull request #8886 from YongseopKim/impl_gt_div
[RyuJIT/ARM32]Impl GT_DIV in genCodeForTreeNode
Jan Vorlicek [Wed, 18 Jan 2017 00:49:55 +0000 (01:49 +0100)]
Remove obsolete platforms ifdefs from PAL (#8971)
There were many ifdefs for obsolete platforms and processors like AIX, HPUX,
SPARC, ALPHA etc. This change is a cleanup that removes them.
Andy Ayers [Wed, 18 Jan 2017 00:49:15 +0000 (16:49 -0800)]
Merge pull request #8952 from AndyAyersMS/FixEndLFinAssert
JIT: fix bad assumption in non-funclet EH models
Jan Vorlicek [Wed, 18 Jan 2017 00:48:48 +0000 (01:48 +0100)]
Add generic instantion argument passing description on x86 (#8940)
This change adds missing information on generic instantion argument
passing description on x86 to the CLR ABI document.
Pat Gavlin [Tue, 17 Jan 2017 23:37:33 +0000 (23:37 +0000)]
Merge pull request #8972 from pgavlin/ExactSizeSIMD
GS checkes: only set lVExactSize for SIMD vars.
Stephen Toub [Tue, 17 Jan 2017 23:16:04 +0000 (18:16 -0500)]
Merge pull request #8942 from stephentoub/fix_tpl_event
Fix TplEventSource diagnostic error due to mismatched signature