Adeel Kazmi [Fri, 27 Jun 2014 16:10:10 +0000 (01:10 +0900)]
(Touch) Ensure touch-events are cleared before emitting to stage and documentation update
[problem] Stage signal has the wrong touch-event information.
[cause] We change it when we emit the interrupted event for the original down actor.
[solution] Revert to original.
Change-Id: Ib93364a8df74204c5f15c8d33e264189dc1a752c
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Fri, 27 Jun 2014 12:24:19 +0000 (21:24 +0900)]
(Touch) Emit Up to down consumer (if different from current consumer)
[problem] Actor receiving touch-down may never receive touch-up and it cannot rely on leave.
[cause] Can be moved away and another actor may be hit.
[solution] Emit an Interrupted event to the touch-down actor if it's not the current one
consumed.
Change-Id: Icb59c3434eac12cffebf4d58dff9a2310764099b
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Fri, 20 Jun 2014 08:22:17 +0000 (17:22 +0900)]
(Gestures) Remove Functor usage from processors
[problem] Functor usage is confusing and they need to be stack-allocated at the start of every
gesture.
[cause] N/A
[solution] Use deriving methods instead which is a bit clearer and does not require stack allocation
when the gesture starts.
Change-Id: I099eed5677914301559c5ff7ca55a170b5a99816
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Kimmo Hoikka [Tue, 24 Jun 2014 17:22:36 +0000 (18:22 +0100)]
Prevent event thread from picking up notifications too soon
[problem] Animation-finished and property-notifications can be fired off too soon.
[cause] We queue the message from update straight away, even before the scene has been
updated.
[solution] Create another buffer in the notification-manager which is only swapped at the end
of the update.
Change-Id: I7b72fa2485ed9faa606b52a3925e111df2931776
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
David Steele [Mon, 23 Jun 2014 10:15:52 +0000 (11:15 +0100)]
Added more unit tests for NinePatchImage
Double checking the ImageActor behaviour with 9 patch images.
Change-Id: If00f9ca4425305885c965202a09d7862fe813d49
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Adeel Kazmi [Tue, 24 Jun 2014 12:53:25 +0000 (21:53 +0900)]
(UpdateManager) Fire animation notifications ONLY when scene is actually updated
[problem] Timing problem where animation finsihed callbacks are emitted before the scene has
been updated.
[cause] We add messages to the event-queue before we've updated the scene. The queues can
be swapped while we're still updating and the finished callback can be then fired.
Any attempt to get current values in this callback will be from the previous frame.
[solution] Delay adding animation-finished messages to the queue till just before update ends.
Change-Id: I3c610e5139e1bfe32873cf3f85474ab7d61ed343
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Kimmo Hoikka [Sat, 21 Jun 2014 13:11:50 +0000 (14:11 +0100)]
fixing a potential memory corruption/crash if Dali::Vector is Resized before putting any elements into it
Change-Id: Idb66f6938421ca53ddc3199e0677f0bc87ceeceb
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
David Steele [Thu, 12 Jun 2014 18:11:43 +0000 (19:11 +0100)]
Added image renderer clip space culling
[problem] Render thread taking too long setting up renderers that will be clipped by GPU
[solution] Calculate which renderers are in clip space, and cull those that aren't.
Now uses OBB culling (which is relatively expensive, but still less expensive than drawing)
Adds an API to RenderTask to disable culling (enabled by default)
Change-Id: Ibe0c9c454b97fb02d8a63d17aeed9e2d4ff5d12e
Signed-off-by: David Steele <david.steele@partner.samsung.com>
David Steele [Fri, 20 Jun 2014 13:59:46 +0000 (14:59 +0100)]
Fixed segfault if nine-patch image failed to load
[problem] If nine patch image fails to load, e.g. file not found,
then empty bitmap pointer is accessed when image actor tries to use it.
[cause] Not checking bitmap pointer before dereference
[solution] Ensured bitmap pointers are checked, if NULL, then an error is logged.
Change-Id: If42d2db4f662fc2323057f71b365a741e254d125
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Paul Wisbey [Thu, 19 Jun 2014 17:56:41 +0000 (18:56 +0100)]
Optimization to reduce Handle size by 50%
[problem] Memory usage is too high, event-thread operations are too heavy.
[cause] Too much Dali::Handle data copied around.
[solution] Remove all virtual methods from handles, to avoid needing a C++ vptr
Change-Id: Ib03898bc8fe073d41e5a44cc49af91958d164ee1
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Wed, 18 Jun 2014 01:17:26 +0000 (10:17 +0900)]
(HitTest) Added API to layer so that it can consume all touch if required
[problem] Currently, the only way to stop gestures being delivered to actors behind a layer is
by attaching the layer to a gesture detector which is cumbersome.
[cause] N/A
[solution] Implemented an API which allows the user to set whether a layer should consume all
touch. When this is set on a layer, any layers behind that layer are not hit-test.
Change-Id: I34468c13a3b7b5f81a53ca4746a5c97a4ece09ba
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Wed, 18 Jun 2014 02:46:59 +0000 (11:46 +0900)]
(AutomatedTests) Ensure dali automated tests can be built for target
[problem] Tests cannot be built for target on a clean gbs-root.
[cause] Missing boost-devel dependency.
[solution] Add dependency to test spec files.
Change-Id: I6f2663f281c5006eb6a54e5355cdcb2a395f2f2c
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Mon, 16 Jun 2014 08:47:08 +0000 (17:47 +0900)]
(PanGesture) Added pan velocities as a property.
[problem] Unable to use the pan velocity values in constraint.
[cause] They are not properties.
[solution] Add properties which use this.
Change-Id: I066a528ab0f56c1208e891d2f0d7a698ce09feac
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Victor Cebollada [Fri, 23 May 2014 09:50:57 +0000 (10:50 +0100)]
Any type - const getters added.
[problem] Getter methods from clases which store values inside an Any container can't be const.
[cause] Some const getters are missing in the Any class.
[solution] Add them.
Change-Id: Icdf4276a8efe31ee7d9ba3b17c3fcf075081d41d
Signed-off-by: Victor Cebollada <v.cebollada@samsung.com>
Paul Wisbey [Fri, 13 Jun 2014 11:36:28 +0000 (20:36 +0900)]
Fixed RenderTask bug when source actor is off-stage.
[problem] If a render-once RenderTask's source actor is off-stage, this will cause Dali to render continuously.
[cause] The RenderTask is waiting, but not ready to render.
[solution] Change update logic to only keepUpdating if a waiting task is ready.
Change-Id: I8f6e400a4f19ba731460bcda7e9ea83bd3593268
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Richard Underhill [Thu, 22 May 2014 08:54:24 +0000 (09:54 +0100)]
(Dali-Core) Memory optimisation for Text-Styles
[problem] TextStyles create structure for all attributes, the moment
one is created taking up more memory than needed
[cause] Single structure of attributes
[solution] A container is created when attributes (or a set of attributes) are created.
Change-Id: Ibcb69df8b8f8f84ec862f295125fe0d9c83d511e
Signed-off-by: Richard Underhill <r.underhill@partner.samsung.com>
Signed-off-by: Victor Cebollada <v.cebollada@samsung.com>
Agnelo Vaz [Wed, 11 Jun 2014 15:11:24 +0000 (16:11 +0100)]
Hit test algorithm fixed to traverse hit actor tree if stencil first
[problem] If stencil is added to layer before a tree of actors only the first actor in the tree will be returned, it's children will not be traversed.
[solution] Only stop traversal if current actor is a stencil and that stencil was hit, else traverse children.
Change-Id: I19bf8b3a24b2ac5629079bec7131b266db460143
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Andrew Cox [Wed, 11 Jun 2014 17:18:51 +0000 (18:18 +0100)]
Remove cropping from ImageAttributes
[problem] We have a cropping feature advertised but not used and not
really implemented so confusing potential users and wasting space in our
current builds.
[cause] No users have wanted this feature.
[solution] Remove the partial implementation of this feature.
Change-Id: I24d604c439111ed5a2048908bcdb17795d7a82df
Signed-off-by: Andrew Cox <andrew.cox@partner.samsung.com>
Xiangyin Ma [Wed, 11 Jun 2014 10:24:25 +0000 (11:24 +0100)]
(MeshActor) Add a reference to AnimatableMesh
[problem] AnimatableMesh get deleted before MeshActor
[solution] Keep a reference to the AnimatableMesh so it would not be destroyed before the MeshActor object
Change-Id: Ib56bd23ddd630e4fb25f65310bd639f76a656fa3
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Andrew Cox [Wed, 11 Jun 2014 12:55:43 +0000 (13:55 +0100)]
Document the processing pipeline applied to images at load time
[problem] Dali applications cannot use image attributes with confidence
and they are not obeyed in our image loading code.
[cause] There is no clear wording on how the use of ImageAttributes is
expected to affect the loading of images by Dali in our documentation.
[solution] Clearly lay out an order of operations and the handling of
special parameter values (zero dimensions).
Change-Id: I30399cc17dc6581606fa85886ab8b51c79e4a94f
Signed-off-by: Andrew Cox <andrew.cox@partner.samsung.com>
Adeel Kazmi [Tue, 10 Jun 2014 14:07:59 +0000 (15:07 +0100)]
(BaseObject) If type-name is not found then show a warning instead of an error
[problem] Too many error messages when launching apps that do not use the type-registry
(not an bug, apps can choose not to use it).
[solution] Change to warning.
Change-Id: I9900fcf987aa7b02a904d1f304e43f0fe7e556c5
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Fri, 6 Jun 2014 16:45:19 +0000 (17:45 +0100)]
(Gestures) Use the actor-gesture-data containers and use raw Actor pointers.
Use the containers provided by actor-gesture-data rather than checking if the actor
is available in attached detectors (should be faster).
Using raw Internal::Actor pointers instead of handles.
Removing unnecessary templates.
Next step is to remove gesture-processor functors and use deriving methods instead.
Change-Id: I130cc8cbd0dae293713b74156fcbf3c1c3eaa758
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Wed, 11 Jun 2014 10:30:33 +0000 (11:30 +0100)]
Updated spec file and removed unrequired shader binaries
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Change-Id: I5be805be1b4d8c6fe6ecd64daa9f107b8ab3b5aa
Adeel Kazmi [Fri, 6 Jun 2014 14:23:38 +0000 (15:23 +0100)]
(Gestures) Extract out GestureData from Actor
[problem] Actor is too closely coupled with gesture-detectors.
[cause] GestureData is private within Actor which stores info about gesture detection.
[solution] Move GestureData out of actor-impl.cpp and Actor provides a method to retrieve this.
Change-Id: I534723f5cfb772c88f13d2d90ab97d8c64571f8f
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
David Steele [Thu, 5 Jun 2014 16:38:59 +0000 (17:38 +0100)]
Fixed test case build & some test cases
Change-Id: Id86bef87e2f24bf4b31a02cea3358a36fd7efa32
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Julien Heanley [Mon, 2 Jun 2014 19:32:43 +0000 (20:32 +0100)]
Pan Gesture Prediction - Fixed issue where initial displacement could be close to zero
This used to result in 0 pixel movement in first frame
Change-Id: Ia12ba1660a6ae8c17c8596437dfbb3be5e506fb4
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Andrew Cox [Thu, 5 Jun 2014 10:23:25 +0000 (11:23 +0100)]
Image Load Cancelation - Downgrade error log to warning and note the cause of it
[problem] A rare event that will probably continue to happen until we do
some rewrites is firing as an error.
[solution] Turn error into a warning and document why it currently
Signed-off-by: Andrew Cox <andrew.cox@partner.samsung.com>
Julien Heanley [Thu, 5 Jun 2014 09:26:59 +0000 (10:26 +0100)]
Pan Gestures - Changed Pan gesture prediction amount units to millis
Instead of 0.7 the prediction amount to set should be (0.7 * 16)
Change-Id: I4cb5a10018b35ab3d2000eaf796b1c7994927dd3
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Taeyoon [Tue, 3 Jun 2014 09:55:46 +0000 (18:55 +0900)]
Conversion to Apache 2.0 license
Change-Id: I841fa42a784c2ae44266b579dad04db62ad9c246
Adeel Kazmi [Wed, 4 Jun 2014 12:59:57 +0000 (13:59 +0100)]
(Gestures) Each actor is now aware of what gestures it requires which is used when hit-testing
[problem] Cannot tap anything behind invisible status bar.
[cause] Status bar consumes all gestures even though it doesn't require them.
[solution] Change the system so that actors are aware of what gestures they have so it is
possible to gesture actors behind the status bar.
Change-Id: I713c907c764445263362803a98af0fa514ffd955
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Wed, 4 Jun 2014 13:10:52 +0000 (14:10 +0100)]
(HitTest) Ensure we do not create Actor handles when using the hit-test callback
[problem] Whenever we call the hit-test callback, we create a temporary Actor handle which
can be quite an expensive operation (as constructors are called). We HAVE to do
this for public hit-testing, but we are paying the penalty on internal hit-testing
as well.
[cause] Using the same interface for public and internal hit-testing.
[solution] Use a functor internally which uses a specialised functor with an Actor handle for
external hit-testing and another functor for the internal hit-test which uses
an Internal::Actor* so we do not pay the penalty of creating a handle then.
Change-Id: I7bb81265b9c03aa3c7a714f0dd2ceec22e6a997b
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
jonghyun.ho [Thu, 5 Jun 2014 01:27:47 +0000 (10:27 +0900)]
Upload package dali_0.9.21
daemyung jang [Thu, 5 Jun 2014 05:38:12 +0000 (14:38 +0900)]
Change the default pan algorithm
[problem] Jitter problem is happend.
[cause] Cause by the prediction algorithm.
[solution] Use the average algorithm.
Richard Huang [Wed, 4 Jun 2014 13:04:11 +0000 (14:04 +0100)]
Fixed build error
Julien Heanley [Fri, 30 May 2014 09:30:59 +0000 (10:30 +0100)]
Pan Gesture Prediction - Added DALI_PAN_GESTURE_PREDICTION_AMOUNT environment variable
Increase how far pan gestures try to predict position 1.0f is 1 frame further ahead. Can use decimals like 0.6 or 1.3.
Change-Id: Id5ac2e6c7273e25f51d41aa16ad113ec6632256d
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
jonghyun.ho [Mon, 2 Jun 2014 00:36:46 +0000 (09:36 +0900)]
Upload package dali_0.9.20
jonghyun.ho [Sat, 31 May 2014 02:05:16 +0000 (11:05 +0900)]
Guard against constraint sending messages during core destruction
[cause] ProxyObject was about to send a message after core is already destroyed.
[solution] Guard against constraint sending messages during core destruction
Adeel Kazmi [Fri, 30 May 2014 10:22:56 +0000 (11:22 +0100)]
Fixed Image & Model problems with TypeRegistry
[problem] A lot of error messages shown with images & model related to type-registry which
can slow startup time due to a lot of error logging
[cause] Image types not registering with type-registry
[solution] Register with type-registry
Change-Id: Id38bf29974e672a00171ec803707ff23c1610d5a
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Fri, 30 May 2014 06:12:45 +0000 (07:12 +0100)]
PanGestures - Adjust average gesture movement for better displacement value
Change-Id: Ia5af0c9c3c5178d51449ac85f0040a821d380cbd
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Julien Heanley [Tue, 22 Apr 2014 09:42:01 +0000 (10:42 +0100)]
(PanGesture) Refining of smoothing algorithms
Change-Id: I85cddd4c63f2a2ba1f38e5781717c33694a36ed1
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Kimmo Hoikka [Thu, 29 May 2014 12:08:38 +0000 (13:08 +0100)]
(cleanup) Stop including std::vector directly inside dali
Change-Id: Iefe976f24129a890f645a8f33acd67153fa291d4
jonghyun.ho [Thu, 29 May 2014 01:44:08 +0000 (10:44 +0900)]
Upload package dali_0.9.19
Paul Wisbey [Wed, 28 May 2014 08:09:55 +0000 (17:09 +0900)]
Avoid showing garbage when dali-demo is launched
[problem] When window transition effect is disabled, dali-demo shows
random framebuffer contents when launched.
[cause] First glClear is delayed until renderers are ready.
[solution] Always do the first glClear regardless of renderers.
Adeel Kazmi [Tue, 10 Jun 2014 14:52:59 +0000 (15:52 +0100)]
Merge branch 'master' into tizen
Adeel Kazmi [Tue, 10 Jun 2014 14:49:22 +0000 (07:49 -0700)]
Revert "License conversion from Flora to Apache 2.0"
This reverts commit
7dcb0a38005dd8c6d71e466c1ea0ec4d7d57239f.
Change-Id: I5091ba33989ecc9707f787e0a4f7e8df3c06e24e
jonghyun.ho [Wed, 28 May 2014 01:35:54 +0000 (10:35 +0900)]
Fixed PREVENT "Using invalid iterator"
[problem] Using invalid iterator
[cause] std::vector::erase invalidates interator "iter".
then invalidated "iter" is used again in next while loop.
[solution] "iter" is set again once it's invalidated.
Jonghyun Ho [Mon, 26 May 2014 04:40:28 +0000 (13:40 +0900)]
Avoid PanGesture circular buffer overflow
[problem] ScrollView sometimes moves in the wrong direction.
[cause] Motion events received in excess of PanGesture PAN_GESTURE_HISTORY limit,
before the update-thread can process in the correct order.
[solution] Increase PAN_GESTURE_HISTORY value.
jonghyun.ho [Sat, 24 May 2014 02:31:38 +0000 (11:31 +0900)]
Upload package dali_0.9.18.
David Steele [Mon, 12 May 2014 13:23:13 +0000 (14:23 +0100)]
Added object sizes to platform abstraction in profiling section
[Problem] No measure of object sizes in object profiler
[Cause] New requirement
[Solution] Use constants to accumulate sizes of related objects (keeps number of constants small)
Added Image as a registered type (Requires that object registration is done as a second stage
process; also requires that all newly allocated objects are stored to an intrusive pointer (otherwise
signal generation creates a handle, triggers, then throws the handle away and deletes the new object...)
Change-Id: I1b9c0a427fa7b2ed67f93cde94a50377c0ed560d
[Verification] Build Repo
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Adeel Kazmi [Tue, 27 May 2014 14:59:06 +0000 (15:59 +0100)]
Removed open-gles-20 dependency
jonghyun.ho [Wed, 21 May 2014 05:18:23 +0000 (14:18 +0900)]
Upload package dali-0.9.17.
Paul Wisbey [Wed, 21 May 2014 09:09:40 +0000 (18:09 +0900)]
Revert "[SRUK] Avoid creating unnecessary strings for built in shader uniforms"
[problem] Crash while registering uniforms
[cause] Invalid pointer into mExternalUniformNames std::set
[solution] Rollback to previous version (does not use std::set)
Change-Id: I63ea051fc9b7c182515463b3ad8c801eb73636b1
David Steele [Thu, 15 May 2014 19:28:33 +0000 (20:28 +0100)]
Fixed dynamic shapes using meshes.
[problem] Cloth demos crash
[cause] DynamicsShape of type mesh is using discardable meshes
[solution] Need to ensure that the meshes used for dynamics shapes are not
discardable. Needs a new API to create mesh actors from such a mesh.
(Don't want to have non-discardable meshes in public API)
New API is:
Cloth cloth = Cloth::New(width, height, numXDivisions, numYDivisions);
DynamicsShape meshShape = DynamicsShape::NewMesh( cloth );
MeshActor clothActor = MeshActor::New( cloth );
Change-Id: I5c89bfd481d6162f8f17e03710c320e8fbb249bf
Signed-off-by: David Steele <david.steele@partner.samsung.com>
jonghyun.ho [Wed, 14 May 2014 08:00:03 +0000 (17:00 +0900)]
Upload pacakge dali_0.9.16.
David Steele [Wed, 14 May 2014 17:09:07 +0000 (18:09 +0100)]
Fixed saving of models to binary format
Change-Id: I294751226e9b44adf202982eabe8907daf5069ed
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Adeel Kazmi [Wed, 14 May 2014 14:56:09 +0000 (15:56 +0100)]
(Scripting) Removing const from parameters
Change-Id: Ie9d7011092e60f0b279c6e979e21260901f47d2b
Francisco Santos [Wed, 14 May 2014 13:08:35 +0000 (14:08 +0100)]
Fix color overflow in faded text.
Change-Id: I276a89f7187f9a6501013e994b7589519f234728
Signed-off-by: Francisco Santos <f1.santos@samsung.com>
Adeel Kazmi [Fri, 9 May 2014 18:05:42 +0000 (19:05 +0100)]
(Scripting) Some internal structs/templates public so that they can be re-used in toolkit
Change-Id: I08966d5ce46918957027e776450fdaebdee3c31e
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Taeyoon [Thu, 22 May 2014 04:53:03 +0000 (13:53 +0900)]
License conversion from Flora to Apache 2.0
LICENSE file change.
Boilerplate notice changed to apply the Apache License to dali
SPEC file change.
Change-Id: I5ee51b5dcb44087a48bb81a92459bb8dfd451c2d
Taeyoon [Thu, 22 May 2014 04:16:57 +0000 (13:16 +0900)]
Revert "License conversion from Flora to Apache 2.0"
This reverts commit
df59eea2434495c32414fcf9ffafe4cb7dff5324.
Taeyoon [Thu, 22 May 2014 02:47:39 +0000 (11:47 +0900)]
License conversion from Flora to Apache 2.0
Richard Underhill [Tue, 13 May 2014 13:47:32 +0000 (14:47 +0100)]
TextParameters object now contains only the specific parameters set
[Issue#] N/A
[Problem] TextParameters contained Outline, Glow, DropShadow and Gradient
values even if some were not used.
[Cause]
[Solution] A container of Dali::Any objects describe the TextParameters
Change-Id: I73ff83b01b8e84df72f0fc3659e035c6a730d747
Signed-off-by: Richard Underhill <r.underhill@partner.samsung.com>
Kingsley Stephens [Tue, 13 May 2014 12:19:48 +0000 (13:19 +0100)]
(Image) Make Image GetWidth and GetHeight return natural size
[Issue#] N/A
[Problem] The size of the image should be available at all times
[Cause] N/A
[Solution] Make GetWidth and GetHeight return the natural size
Change-Id: I92f9374b8582c92a356abd62af277cf6b73af86c
Andrew Cox [Tue, 13 May 2014 17:14:31 +0000 (18:14 +0100)]
Revert "[SRUK] Bitmap core patch 2 of 4 - Replace all uses of the Bitmap class with new simpler type ImageData in core / adaptor communication"
This reverts commit
fffd4cca80c05dbc332a2b28ade580894a3915f3.
!! Note !! This code is good but we want to delay this series of Adaptor
changes until late May for client stability reasons.
Change-Id: I35e2c3d6940c0b531f9e47f87b15bcbc1c0abfbc
Signed-off-by: Andrew Cox <andrew.cox@partner.samsung.com>
Artem Dergachev [Thu, 17 Apr 2014 14:29:41 +0000 (18:29 +0400)]
Optimize HitTestWithinLayer (20% faster HitTest).
Whenever a temporary HitActor structure instance is created, constructor and destructor functions
are called for its .actor field.
In certain scenarios this results in creating and instantly deleting around 1000 dummy Actor
objects during a single call of HitTest().
HitTestWithinLayer is an important bottleneck in such scenarios, second only to
UpdateNodesAndAttachments (depending on the touchevent:framerate ratio).
This change makes the test around 20% faster and additionally reduces power consumption.
Change-Id: Iad9f59f39f6229516f036cc49025c2e0ef72ad3d
Paul Wisbey [Wed, 7 May 2014 12:54:28 +0000 (13:54 +0100)]
Stubbed-out Dynamics implementation to reduce binary size
[Issue#] N/A
[Problem] Binary size
[Cause] Lots of optional features built by default
[Solution] Don't build dynamics support by default. A stub API is
still provided; applications should anyway have been checking whether
DynamicsWorld was available i.e. whether bullet plugin was installed.
libdali-core.so sizes:
Before:
1.4 MB (1,433,052 bytes)
After:
1.3 MB (1,369,312 bytes)
Note - apps should check Stage::InitializeDynamics() return value, before
using any other Dynamics APIs.
/**
* @return A handle to the world object of the dynamics simulation, or an empty handle if Dynamics capable
* of supporting the requirement in config is not available on the platform.
*/
DynamicsWorld InitializeDynamics(DynamicsWorldConfig config);
David Steele [Tue, 13 May 2014 13:05:38 +0000 (14:05 +0100)]
Removing unnecessary dependencies
Change-Id: I50d11b88986777f29ca094e8934b920de136d402
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Francisco Santos [Thu, 8 May 2014 15:39:21 +0000 (16:39 +0100)]
Add missing uniforms.
Change-Id: I528d0108c4bd58adeac6cbf0d64b8ef6b96ca812
Signed-off-by: Ferran Sole <ferran.sole@samsung.com>
Andrew Cox [Wed, 26 Mar 2014 11:06:55 +0000 (11:06 +0000)]
Bitmap core patch 2 of 4 - Replace all uses of the Bitmap class with new simpler type ImageData in core / adaptor communication
[Issue#] N/A
[Problem]
Bitmap is a complicated abstract base class with several
interactions across core. Exposing it to the adaptor for the simple
job of moving some pixels and metadata from disk and application
memory buffers back to the core is unnecessary complication.
[Cause]
Legacy implementation.
[Solution]
Update all users of Bitmap at the core / adaptor boundary to employ the
simpler ImageData class instead and translate that to a Bitmap within
core.
A follow-up patch moves the code for Bitmap out of integration API altogether.
http://slp-info.sec.samsung.net/gerrit/#/c/455649/
A second follow-up patch refactors Bitmap:
http://slp-info.sec.samsung.net/gerrit/#/c/460583/
Will build fine alone but needs the following adaptor patch to
send back images in ImageData objects instead of Bitmap ones:
http://slp-info.sec.samsung.net/gerrit/#/c/460595/
Toolkit TCT tests are fixed by this patch:
http://slp-info.sec.samsung.net/gerrit/#/c/477139/
Signed-off-by: Andrew Cox <andrew.cox@partner.samsung.com>
Change-Id: I6150b29121adca9c7be84b7b0620d6406d6717ca
Kimmo Hoikka [Tue, 6 May 2014 12:50:23 +0000 (13:50 +0100)]
ContextObserver removal, part II: Its gone
[Issue#] N/A
[Problem] memory consumption
[Cause] observer pattern causes classes to be virtual unnecessarily
[Solution] remove observer pattern
Change-Id: Id0223b54cf989caf12a55ccadcaf9f48dff9a5b9
Signed-off-by: Ferran Sole <ferran.sole@samsung.com>
jonghyun.ho [Wed, 7 May 2014 05:11:03 +0000 (14:11 +0900)]
Upload package dali_0.9.15.
Related packages : dali_0.9.15, dali-adaptor_0.9.15, dali-toolkit_0.9.15
Change-Id: I182f2c5a4d9ae7ad2298a48c3162e8681eebcc77
Signed-off-by: Ferran Sole <ferran.sole@samsung.com>
Kimmo Hoikka [Wed, 7 May 2014 13:18:50 +0000 (14:18 +0100)]
Fix regression by previous optimization for mDirtyFlags
[Issue#] N/A
[Problem] TextInput demo working in a funny way
[Cause] regression in flag handling
[Solution] fix it
Change-Id: I4a1b5ddf5cfabdc67d6c2148ad925e7c14be3868
Signed-off-by: Ferran Sole <ferran.sole@samsung.com>
Kingsley Stephens [Tue, 6 May 2014 12:55:26 +0000 (13:55 +0100)]
(9 patch) Make ImageActor SetImage handle 9 patch images
[Issue#] N/A
[Problem] SetImage would not load the 9 patch image
[Cause] Only ImageActor New would load the 9 patch image
[Solution] Make SetImage load the 9 patch
Change-Id: I3b8dea9aefd520dedb253671345307fff536f309
Signed-off-by: Ferran Sole <ferran.sole@samsung.com>
Kimmo Hoikka [Thu, 1 May 2014 19:29:41 +0000 (20:29 +0100)]
ContextObserver removal, part I: Program no longer is context observer
[Issue#] N/A
[Problem] too many context observers
[Cause] observer pattern
[Solution] remove observer pattern
Change-Id: Ica8dd62613d689d97b7a9846154a589f7626450d
Signed-off-by: Ferran Sole <ferran.sole@samsung.com>
Paul Wisbey [Sat, 3 May 2014 11:27:56 +0000 (12:27 +0100)]
Fix regression with BitmapImage (width/height variety)
[Issue#] N/A
[Problem] Pointer returned by BitmapImage::GetBuffer() is invalid. This only
affects the variety of BitmapImage where the data is allocated by ResourceClient.
[Cause] Regression from "[SRUK] Compressed Texture Support for Dali Core"
[Solution] Partial rollback of BitmapExternal, Integration::Bitmap etc.
Change-Id: I3480e935ce908c1ced6cd57f0df87f6072292e3b
Signed-off-by: Ferran Sole <ferran.sole@samsung.com>
Francisco Santos [Fri, 2 May 2014 14:52:18 +0000 (15:52 +0100)]
Clamp text color values to valid range.
Signed-off-by: Francisco Santos <f1.santos@samsung.com>
Kimmo Hoikka [Wed, 30 Apr 2014 15:25:05 +0000 (16:25 +0100)]
Align data members, pointers first, classes then, next built in types and flags last. saves 8 bytes per actor on desktop
Signed-off-by: Paul Wisbey <p.wisbey@samsung.com>
Javon Prince [Fri, 2 May 2014 12:25:44 +0000 (13:25 +0100)]
Add 'ExclusiveArch: armv7l' limit build to arm architecture
Signed-off-by: Javon Prince <javon.prince@samsung.com>
Richard Underhill [Wed, 30 Apr 2014 16:53:49 +0000 (17:53 +0100)]
Build Optimization for size ( -Os )
Signed-off-by: Richard Underhill <r.underhill@partner.samsung.com>
Kimmo Hoikka [Thu, 1 May 2014 12:43:14 +0000 (13:43 +0100)]
GPUBuffer is unnecessarily large
Signed-off-by: Paul Wisbey <p.wisbey@samsung.com>
Javon Prince [Tue, 29 Apr 2014 18:16:09 +0000 (19:16 +0100)]
Add BakeFinal to Animation::EndAction
When an animation is stopped, it will save the property
values as if it's duration had normally elapsed.
Signed-off-by: Javon Prince <javon.prince@samsung.com>
Adeel Kazmi [Thu, 1 May 2014 12:52:17 +0000 (13:52 +0100)]
(AutomatedTests) Fixed build break.
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Kimmo Hoikka [Thu, 1 May 2014 09:45:03 +0000 (10:45 +0100)]
Fix code to not include std set directly
[Issue#] N/A
[Problem] set exports its allocator causing extra symbols in symbol table
[Cause] including set directly
[Solution] include set-wrapper instead
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Change-Id: Ic2590137403d7d4d6d39971960098ffda9b5a9b2
Kimmo Hoikka [Wed, 30 Apr 2014 14:20:29 +0000 (15:20 +0100)]
Avoid creating unnecessary strings for built in shader uniforms
[Issue#] N/A
[Problem] 270 x 19 string objects created unnecessarily
[Cause] generic API
[Solution] specialize API for two cases
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Change-Id: I07975c3c8b7ab629084029c0e2012f98cb6401dd
Julien Heanley [Wed, 30 Apr 2014 12:33:40 +0000 (13:33 +0100)]
(Observers)Fix memory issues during observer iteration
[Issue#] N/A
[Problem] Crash could occur when adding a previously removed actor back into the scene
[Cause] Observer classes were using SceneObjectRemoved callback to remove themselves
from that object's observer list while the object is in process of iterating over the list
[Solution] Mark object as disconnected from scene and remove observer later
Change-Id: I552017a0d8284973f565cd08275f1270fc8e9668
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Adeel Kazmi [Thu, 3 Apr 2014 14:30:24 +0000 (15:30 +0100)]
(Properties) Ensure TypeInfo is set when creating Type via TypeInfo
[Problem] When created named types, the wrong type-info is used
when setting/getting properties.
[Cause] Gets the type-info related to the current type as it
does not know how it was created.
[Solution] Set the type-info when creating the object.
Change-Id: I3942ccf7c2c3ba36601dae1c4dd79f64a3c64e2c
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
jonghyun.ho [Mon, 28 Apr 2014 23:39:26 +0000 (08:39 +0900)]
Upload package dali_0.9.14.
Related packages : dali_0.9.14, dali-adaptor_0.9.14, dali-toolkit_0.9.14
Change-Id: I37c4cfff77f58046f0d195c4f2ad3067cccf4415
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Javon Prince [Thu, 10 Apr 2014 08:20:15 +0000 (09:20 +0100)]
Text: Quality improvement
Adjust amount of anti-aliased pixels dependent on the font pixel size.
This will only be accurate for text that is not scaled and not rotated
[Issue#] (N/A)
[Problem]
[Cause]
[Solution]
Change-Id: If83426348a970a93c250e31d7abbd5e7fb221a4c
Signed-off-by: Javon Prince <javon.prince@samsung.com>
Adeel Kazmi [Fri, 25 Apr 2014 14:36:06 +0000 (15:36 +0100)]
(Gestures) Ensure an update is done if gesture properties are updated.
[Problem] If gesture properties are updated and if there are no queued messaged from the event
thread, then update is still not run.
[Cause] Gesture properties are updated directly rather than via a message.
[Solution] Process gestures whenever we have an update, if the properties are updated, then we
should update the scene as well.
Change-Id: Ief1ee545fb7a3af289623cf100fe24e18f296569
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Adeel Kazmi [Fri, 25 Apr 2014 12:11:47 +0000 (13:11 +0100)]
MessageQueue now correctly reports that an update is not required
[Problem] The message queue always reports that it has messages even if it does not.
[Cause] The sceneUpdate counter never gets decremented to 0. This causes the update to run
every time.
[Solution] It was being cleared within a for loop where messages are being processed, it should be
outside this loop so is cleared if there are no messages.
Change-Id: I1d490c9c25f07813f2f904d659e5116e6b27a50c
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Ferran Sole [Mon, 28 Apr 2014 07:52:44 +0000 (08:52 +0100)]
Fix bug when reusing renderlist on stencil renderers
[Issue#] N/A
[Problem] When reusing renderlists for stencil renderers, the stencil renderers
are rendered in the color buffer sometimes.
[Cause] When reusing a renderlist for stencil renderers the appropiate flags
where not seted on the renderlist which causes this renderers to be rendered in
the color buffer.
[Solution] Added a function to reset the flags correctly for stencil
renderlists as in the rest of renderlists (opaque, transparent and overlay)
Change-Id: Ic80a33af8ac8ac6bf606610fae5d6279cee8cf81
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Paul Wisbey [Mon, 14 Apr 2014 17:35:26 +0000 (18:35 +0100)]
Share a single weight property between constraints
[Issue#] (N/A)
[Problem] Not easy to blend between layouts using Constraints
[Cause] Each constraint weight has to be animated individually
[Solution] Provide an API for sharing a single weight property
between many Constraints
Change-Id: Icd81656930d85a8335ca8ee334843df6d2fdf179
Signed-off-by: David Steele <david.steele@partner.samsung.com>
jonghyun.ho [Thu, 24 Apr 2014 05:44:56 +0000 (14:44 +0900)]
Upload package dali_0.9.13.
Related packages : dali_0.9.13, dali-adaptor_0.9.13, dali-toolkit_0.9.13
Change-Id: I3845908ec388826f5c9eeb928f9d62c15f57a2c3
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Andrew Cox [Wed, 26 Mar 2014 11:06:55 +0000 (11:06 +0000)]
ImageData class to replace Bitmap class with new simpler type for core / adaptor communication
[Issue#] N/A
[Problem]
Bitmap is a complicated abstract base class with several
interactions across core. Exposing it to the adaptor for
the simple job of moving some pixels and metadata from
disk and application memory buffers back to the core is
unnecessary complication.
[Cause]
Legacy implementation.
[Solution]
Introduce a simpler and concrete ImageData class.
Change-Id: Ia3595f496326554d73dca24215f197c97fa86b6e
Signed-off-by: Andrew Cox <andrew.cox@partner.samsung.com>
Kingsley Stephens [Tue, 22 Apr 2014 15:08:58 +0000 (16:08 +0100)]
(prevnet) Fix prevnet issues
[Issue#] N/A
[Problem] Prevnet identified some issues needing fixing
[Cause] N/A
[Solution] Adjust code to satisfy prevnet
Change-Id: I501e0f51eaeee823cc428fce0edb6c0b2de27bea
Signed-off-by: Andrew Cox <andrew.cox@partner.samsung.com>
jonghyun.ho [Thu, 17 Apr 2014 01:35:01 +0000 (10:35 +0900)]
Upload package dali_0.9.12.
Related packages : dali_0.9.12, dali-adaptor_0.9.12, dali-toolkit_0.9.12
Signed-off-by: Andrew Cox <andrew.cox@partner.samsung.com>
Change-Id: I295fd2e3c3aafb97d1cf3d5a35fa4272db6a386d
Julien Heanley [Fri, 4 Apr 2014 10:24:37 +0000 (11:24 +0100)]
(PanGesture) Added environment variable "PAN_PREDICTION_MODE" for selecting gesture algorithm
Change-Id: I726d7567c67f7ecdec18c102d788d932500d1b43
Signed-off-by: Andrew Cox <andrew.cox@partner.samsung.com>
Javon Prince [Wed, 16 Apr 2014 12:30:22 +0000 (13:30 +0100)]
Move view-mode.h from unmanaged to managed api
[Issue#] (N/A)
[Problem] Causes build bream with core-api test
[Cause] view-mode.h was not in capi
[Solution] move view-mode.h to capi
Change-Id: I3acdc090a5d05c3e80ee5299233cce75c2c6b3e9
Signed-off-by: Javon Prince <javon.prince@samsung.com>
Adeel Kazmi [Wed, 16 Apr 2014 16:11:53 +0000 (17:11 +0100)]
Updated Tests style
Ferran Sole [Tue, 15 Apr 2014 09:01:28 +0000 (10:01 +0100)]
Added tag ( id ) to Constraints so they can be identified ( and removed ) by its tag value
[Issue#] N/A
[Problem] ItemView is not flexible enough
[Cause] ItemView removes all constraints from actors it manages
[Solution] Added tag to constraints so ItemView can tag its constraints and remove only those when needed
Change-Id: Id2e016f7b9f906bd4fa62d6fe249bd1ad60a1d97