Trevor Norris [Tue, 7 May 2013 19:38:14 +0000 (12:38 -0700)]
stream_wrap: remove unused arg from WriteBuffer
WriteBuffer was changed in the cork/uncork implementation (
60ed2c54).
The unused argument has been removed.
Timothy J Fontaine [Tue, 7 May 2013 18:59:22 +0000 (11:59 -0700)]
test: report test duration in TAP progress
Timothy J Fontaine [Mon, 6 May 2013 18:31:57 +0000 (11:31 -0700)]
test: reap children when cluster-bind-twice fails
Timothy J Fontaine [Thu, 2 May 2013 20:54:37 +0000 (13:54 -0700)]
build: only use DESTDIR instead of PREFIX for pkg
Preserve default install prefix seen in process.config, but use DESTDIR
for installing to deliniate 32/64 versions, avoid conflicts with PREFIX
settings in config.mk
Bert Belder [Fri, 3 May 2013 09:33:47 +0000 (11:33 +0200)]
Merge branch 'v0.10'
Miroslav Bajtoš [Fri, 3 May 2013 06:51:51 +0000 (08:51 +0200)]
build: vcbuild.bat fix for Visual Studio 2012
Change vcbuild.bat to ignore VCINSTALLDIR environment variable,
always check for specific VS version and set GYP_MSVS_VERSION
accordingly. Otherwise GYP generates project files in format
that cannot be compiled by VS2012.
Sam Roberts [Thu, 2 May 2013 23:38:16 +0000 (16:38 -0700)]
test: EventEmitter#setMaxListeners() returns this
Add a regression test for commit f8d8122.
Sam Roberts [Tue, 30 Apr 2013 22:26:14 +0000 (15:26 -0700)]
event: make setMaxListeners() return this
setMaxListeners was the only EventEmitter method that returned
undefined, so could not be chained.
Ben Noordhuis [Thu, 2 May 2013 23:13:44 +0000 (01:13 +0200)]
Merge remote-tracking branch 'origin/v0.10'
Sam Roberts [Tue, 30 Apr 2013 22:24:48 +0000 (15:24 -0700)]
doc: document return values of EventEmitter methods
isaacs [Thu, 2 May 2013 16:47:46 +0000 (09:47 -0700)]
doc: link joyent logo in website footer
Miroslav Bajtoš [Fri, 26 Apr 2013 06:05:33 +0000 (08:05 +0200)]
debugger: breakpoints in scripts not loaded yet
When developer calls setBreakpoint with an unknown script name,
we convert the script name into regular expression matching all
paths ending with given name (name can be a relative path too).
To create such breakpoint in V8, we use type `scriptRegEx`
instead of `scriptId` for `setbreakpoint` request.
To restore such breakpoint, we save the original script name
send by the user. We use this original name to set (restore)
breakpoint in the new child process.
This is a back-port of commit 5db936d from the master branch.
Ben Noordhuis [Wed, 1 May 2013 14:21:21 +0000 (16:21 +0200)]
Revert "deps: downgrade openssl to v1.0.0f"
After much investigation it turns out that the affected servers are
buggy. user-service.condenastdigital.com:443 in particular seems to
reject large TLS handshake records. Cutting down the number of
advertised ciphers or disabling SNI fixes the issue.
Similarly, passing { secureOptions: constants.SSL_OP_NO_TLSv1_2 }
seems to fix most connection issues with IIS servers.
Having to work around buggy servers is annoying for our users but not
a reason to downgrade OpenSSL. Therefore, revert it.
This reverts commit
4fdb8acdaef4c3cb1d855e992ada0e63fee520a6.
isaacs [Tue, 30 Apr 2013 14:40:43 +0000 (07:40 -0700)]
doc: Fix require.extensions documentation
1. The stability index must come first, or it messes up the markdown
2. require.extensions is an Object, not an Array.
Close #5387
Ben Noordhuis [Tue, 30 Apr 2013 10:43:32 +0000 (12:43 +0200)]
https: implement https.Server#setTimeout()
Like commit d258fb0 ("http: More useful setTimeout API on server") but
this time for the https module.
Fixes #5361.
Andrew Paprocki [Mon, 8 Oct 2012 19:24:08 +0000 (21:24 +0200)]
vm: add support for timeout argument
Add a watchdog class which executes a timer in a separate event loop in
a separate thread that will terminate v8 execution if it expires.
Add timeout argument to functions in vm module which use the watchdog
if a non-zero timeout is specified.
Ben Noordhuis [Mon, 29 Apr 2013 21:08:02 +0000 (23:08 +0200)]
tools: fix test.py after v8 upgrade
test.py imports deps/v8/tools/utils.py but that file is gone after the
upgrade to 3.18.4 in commit 2f75785. Resurrect the file in tools/
Ben Noordhuis [Mon, 8 Apr 2013 18:34:11 +0000 (20:34 +0200)]
v8: reapply floating patches
Ben Noordhuis [Mon, 29 Apr 2013 20:35:21 +0000 (22:35 +0200)]
deps: upgrade v8 to 3.18.4
Miroslav Bajtoš [Mon, 29 Apr 2013 12:09:26 +0000 (14:09 +0200)]
debugger: fix bug in breakpoint regex escaping
Fix a bug in setBreakpoint() where not all regex characters are escaped
when constructing scriptRegEx for V8.
Ben Noordhuis [Mon, 29 Apr 2013 12:15:07 +0000 (14:15 +0200)]
Revert "deps: downgrade openssl to v1.0.0f"
This commit undoes the downgrade from OpenSSL v1.0.1e to v1.0.0f,
effectively upgrading OpenSSL to v1.0.1e again. The reason for the
downgrade was to work around compatibility issues with certain TLS
servers in the stable branch. See the commit log of 4fdb8ac and the
linked issue for details. We're going to revisit that in the master
branch.
This reverts commit
4fdb8acdaef4c3cb1d855e992ada0e63fee520a6.
Ben Noordhuis [Mon, 29 Apr 2013 12:12:24 +0000 (14:12 +0200)]
http: forward-port missing bits from 01e2920
Forward-port the comments from commit 01e2920 (v0.10) to the master
branch. Everything else from that patch already exists in master.
It didn't merge cleanly because lib/http.js has been split up in
several files.
Ben Noordhuis [Mon, 29 Apr 2013 12:08:51 +0000 (14:08 +0200)]
Merge remote-tracking branch 'origin/v0.10'
Conflicts:
AUTHORS
ChangeLog
deps/uv/ChangeLog
deps/uv/src/version.c
lib/http.js
src/node_crypto.cc
src/node_os.cc
src/node_version.h
test/simple/helper-debugger-repl.js
Ben Noordhuis [Fri, 26 Apr 2013 12:49:54 +0000 (14:49 +0200)]
deps: downgrade openssl to v1.0.0f
Several people have reported issues with IIS and Resin servers (or maybe
SSL terminators sitting in front of those servers) that are fixed by
downgrading OpenSSL. The AESNI performance improvements were nice but
stability is more important. Downgrade OpenSSL from 1.0.1e to 1.0.0f.
Fixes #5360 (and others).
Ben Noordhuis [Mon, 29 Apr 2013 10:06:30 +0000 (12:06 +0200)]
doc: cluster: s/server.destroy/server.close/
Fixes #5379.
isaacs [Mon, 29 Apr 2013 05:10:24 +0000 (22:10 -0700)]
doc: Deprecate require.extensions
isaacs [Sun, 28 Apr 2013 06:41:16 +0000 (23:41 -0700)]
doc: stream writev cleanups
Fedor Indutny [Mon, 8 Apr 2013 22:04:38 +0000 (02:04 +0400)]
benchmark: add chunked-encoding benchmark
Fedor Indutny [Mon, 8 Apr 2013 12:40:31 +0000 (16:40 +0400)]
test: fix timing sensitive tests
Fedor Indutny [Mon, 8 Apr 2013 12:40:21 +0000 (16:40 +0400)]
http: write buffers when chunked to embrace writev
Fedor Indutny [Tue, 9 Apr 2013 08:56:56 +0000 (12:56 +0400)]
net: implement ._writev for .cork/uncork() support
Add Writev method to StreamWrap class for writing mixed array of strings
and buffers. Expose this method for TCP class.
Fedor Indutny [Sun, 14 Apr 2013 12:15:15 +0000 (08:15 -0400)]
streams: introduce .cork/.uncork/._writev
Miroslav Bajtoš [Fri, 26 Apr 2013 06:05:33 +0000 (08:05 +0200)]
debugger: breakpoints in scripts not loaded yet
When developer calls setBreakpoint with an unknown script name,
we convert the script name into regular expression matching all
paths ending with given name (name can be a relative path too).
To create such breakpoint in V8, we use type `scriptRegEx`
instead of `scriptId` for `setbreakpoint` request.
To restore such breakpoint, we save the original script name
send by the user. We use this original name to set (restore)
breakpoint in the new child process.
Miroslav Bajtoš [Fri, 26 Apr 2013 19:07:56 +0000 (21:07 +0200)]
debugger: `restart` with custom debug port
Fixed a bug in debugger repl where `restart` command did not work
when a custom debug port was specified via command-line option
--port={number}.
File test/simple/helper-debugger-repl.js was extracted
from test/simple/test-debugger-repl.js
Miroslav Bajtoš [Fri, 26 Apr 2013 19:09:08 +0000 (21:09 +0200)]
debugger: print port number when connecting to debuggee
To improve troubleshooting of debugger problems in the future,
the debugger repl now prints the port it is connecting to.
Miroslav Bajtoš [Fri, 26 Apr 2013 19:07:56 +0000 (21:07 +0200)]
debugger: `restart` with custom debug port
Fixed a bug in debugger repl where `restart` command did not work
when a custom debug port was specified via command-line option
--port={number}.
File test/simple/helper-debugger-repl.js was extracted
from test/simple/test-debugger-repl.js
Ben Noordhuis [Thu, 25 Apr 2013 20:01:24 +0000 (22:01 +0200)]
test: cluster: unhide child errors in bind-twice
Errors in leaf child processes weren't picked up by the test runner
because they didn't get bubbled up to the main process. Don't forcibly
kill the child processes; tell them to quit gracefully, then inspect
their exit codes.
Ben Noordhuis [Thu, 25 Apr 2013 20:02:42 +0000 (22:02 +0200)]
test: cluster: rename bind-twice-v2 to bind-twice
Ben Noordhuis [Thu, 25 Apr 2013 20:00:06 +0000 (22:00 +0200)]
test: cluster: remove bind-twice-v1 test
It tests the same thing as bind-twice-v2, only not as in-depth.
Timothy J Fontaine [Wed, 24 Apr 2013 17:15:36 +0000 (10:15 -0700)]
build: Makefile should respect configure --prefix
Fixes a regression that got introduced in commit ddf4d1a.
isaacs [Tue, 23 Apr 2013 21:43:46 +0000 (14:43 -0700)]
ChangeLog: Merge in v0.8
Close #5355
isaacs [Tue, 23 Apr 2013 21:08:01 +0000 (14:08 -0700)]
blog: Post for v0.10.5
isaacs [Tue, 23 Apr 2013 21:07:23 +0000 (14:07 -0700)]
Now working on 0.10.6
isaacs [Tue, 23 Apr 2013 21:07:09 +0000 (14:07 -0700)]
Merge branch 'v0.10.5-release' into v0.10
Olof Johansson [Tue, 23 Apr 2013 18:17:09 +0000 (20:17 +0200)]
install: Support $(PREFIX) install target directory prefix
This change introduces support for the common PREFIX variable in the
Makefile and install.py, instead of having /usr/local hardcoded. This
makes it much easier to install node to custom locations e.g. in a
user's home directory.
The PREFIX variable defaults to /usr/local.
isaacs [Tue, 23 Apr 2013 01:00:41 +0000 (18:00 -0700)]
2013.04.23, Version 0.10.5 (Stable)
* uv: Upgrade to 0.10.5 (isaacs)
* build: added support for Visual Studio 2012 (Miroslav Bajtoš)
* http: Don't try to destroy nonexistent sockets (isaacs)
* crypto: LazyTransform on properties, not methods (isaacs)
* assert: put info in err.message, not err.name (Ryan Doenges)
* dgram: fix no address bind() (Ben Noordhuis)
* handle_wrap: fix NULL pointer dereference (Ben Noordhuis)
* os: fix unlikely buffer overflow in os.type() (Ben Noordhuis)
* stream: Fix unshift() race conditions (isaacs)
Miroslav Bajtoš [Tue, 23 Apr 2013 07:38:17 +0000 (09:38 +0200)]
build: added support for Visual Studio 2012
isaacs [Tue, 23 Apr 2013 00:39:05 +0000 (17:39 -0700)]
uv: Upgrade to 0.10.5
isaacs [Mon, 22 Apr 2013 17:18:46 +0000 (10:18 -0700)]
os: Fix uname() error handling on sunos
The uname function can return any non-negative int to indicate success.
Strange, but that's how it is documented. This also fixes a similar
buffer overflow in the even more unlikely event that info.release is
> 255 characters, similar to how 78c5de5 did for info.sysname.
isaacs [Mon, 22 Apr 2013 15:52:42 +0000 (08:52 -0700)]
http: Don't try to destroy nonexistent sockets
Fixes #3740
In the case of pipelined requests, you can have a situation where
the socket gets destroyed via one req/res object, but then trying
to destroy *another* req/res on the same socket will cause it to
call undefined.destroy(), since it was already removed from that
message.
Add a guard to OutgoingMessage.destroy and IncomingMessage.destroy
to prevent this error.
isaacs [Mon, 22 Apr 2013 15:52:42 +0000 (08:52 -0700)]
http: Don't try to destroy nonexistent sockets
Fixes #3740
In the case of pipelined requests, you can have a situation where
the socket gets destroyed via one req/res object, but then trying
to destroy *another* req/res on the same socket will cause it to
call undefined.destroy(), since it was already removed from that
message.
Add a guard to OutgoingMessage.destroy and IncomingMessage.destroy
to prevent this error.
isaacs [Fri, 19 Apr 2013 15:32:24 +0000 (08:32 -0700)]
test: fix dgram-bind-default-address on osx
Allow the IPv4-mapped-as-IPv6 style address.
isaacs [Mon, 8 Apr 2013 15:43:20 +0000 (08:43 -0700)]
crypto: LazyTransform on properties, not methods
It needs to apply the Transform class when the _readableState,
_writableState, or _transformState properties are accessed,
otherwise things like setEncoding and on('data') don't work
properly.
Also, the methods wrappers are no longer needed, since they're only
problematic because they access the undefined properties.
mscdex [Sun, 21 Apr 2013 03:21:13 +0000 (23:21 -0400)]
src: fix potential memory leak on early return
mscdex [Sun, 21 Apr 2013 03:21:05 +0000 (23:21 -0400)]
src: don't initialize variable before assignment
Ben Noordhuis [Mon, 15 Apr 2013 12:17:17 +0000 (14:17 +0200)]
cluster: clean up lib/cluster.js
Clean up and DRY the cluster source code. Fix a few bugs while we're
here:
* Short-lived handles in long-lived worker processes were never
reclaimed, resulting in resource leaks.
* Handles in the master process are now closed when the last worker
that holds a reference to them quits. Previously, they were only
closed at cluster shutdown.
* The cluster object no longer exposes functions/properties that are
only valid in the 'other' process, e.g. cluster.fork() is no longer
exported in worker processes.
So much goodness and still manages to reduce the line count from 590
to 320.
isaacs [Fri, 19 Apr 2013 23:25:11 +0000 (16:25 -0700)]
lint
Ben Noordhuis [Fri, 4 May 2012 15:45:27 +0000 (17:45 +0200)]
events: add EventEmitter.defaultMaxListeners
Class property that controls the maximum number of listeners for all
instances of EventEmitter.
Fixes #3014.
Conflicts:
lib/events.js
Ben Noordhuis [Mon, 8 Apr 2013 18:34:11 +0000 (20:34 +0200)]
v8: reapply floating patches
isaacs [Fri, 19 Apr 2013 17:50:44 +0000 (10:50 -0700)]
V8: Upgrade to 3.18.1
Ryan Doenges [Sun, 14 Apr 2013 19:44:40 +0000 (12:44 -0700)]
path: add path.isAbsolute(path)
An absolute path will always open the same location regardless of your
current working directory. For posix, this just means path.charAt(0) ===
'/', but on Windows it's a little more complicated.
Fixes joyent/node#5299.
isaacs [Fri, 19 Apr 2013 16:21:29 +0000 (09:21 -0700)]
blog: v0.11.1 does not work on windows x64
isaacs [Fri, 19 Apr 2013 16:14:44 +0000 (09:14 -0700)]
Now working on 0.11.2
isaacs [Fri, 19 Apr 2013 16:14:24 +0000 (09:14 -0700)]
Merge branch 'v0.11.1-release'
isaacs [Fri, 19 Apr 2013 16:12:34 +0000 (09:12 -0700)]
blog: Post about 0.11.1
isaacs [Fri, 19 Apr 2013 16:12:22 +0000 (09:12 -0700)]
blog: Post about 0.10.4
isaacs [Fri, 19 Apr 2013 14:39:44 +0000 (07:39 -0700)]
2013.04.19, Version 0.11.1 (Unstable)
* V8: upgrade to 3.18.0
* uv: Upgrade to v0.11.1
* http: split into multiple separate modules (Timothy J Fontaine)
* http: escape unsafe characters in request path (Ben Noordhuis)
* url: Escape all unwise characters (isaacs)
* build: depend on v8 postmortem-metadata if enabled (Paddy Byers)
* etw: update prototypes to match dtrace provider (Timothy J Fontaine)
* buffer: change output of Buffer.prototype.toJSON() (David Braun)
* dtrace: actually use the _handle.fd value (Timothy J Fontaine)
* dtrace: pass more arguments to probes (Dave Pacheco)
* build: allow building with dtrace on osx (Dave Pacheco)
* zlib: allow passing options to convenience methods (Kyle Robinson Young)
isaacs [Fri, 19 Apr 2013 15:32:24 +0000 (08:32 -0700)]
test: fix dgram-bind-default-address on osx
Allow the IPv4-mapped-as-IPv6 style address.
Trevor Norris [Thu, 18 Apr 2013 23:52:07 +0000 (16:52 -0700)]
src: replace Holder() with This()
Switch to always use args.This() to retrieve object instance.
Ben Noordhuis [Fri, 19 Apr 2013 12:54:21 +0000 (14:54 +0200)]
build: fix arm build after v8 upgrade
V8 was upgraded to 3.18 in commit 9f68226. The knobs that control the
ARM build have changed in a number of ways. This commit patches the
configure script to reflect that. Should fix the Raspberry Pi build.
Fixes #5329.
Sean Silva [Thu, 18 Apr 2013 22:34:12 +0000 (18:34 -0400)]
doc: document value of `this` inside listeners
Fixes #5326.
isaacs [Thu, 18 Apr 2013 23:21:24 +0000 (16:21 -0700)]
Merge remote-tracking branch 'ry/v0.10'
Ryan Doenges [Sun, 14 Apr 2013 01:48:00 +0000 (18:48 -0700)]
assert: put info in err.message, not err.name
4716dc6 made assert.equal() and related functions work better by
generating a better toString() from the expected, actual, and operator
values passed to fail(). Unfortunately, this was accomplished by putting
the generated message into the error's `name` property. When you passed
in a custom error message, the error would put the custom error into
`name` *and* `message`, resulting in helpful string representations like
"AssertionError: Oh no: Oh no".
This commit resolves that issue by storing the generated message in the
`message` property while leaving the error's name alone and adding
a regression test so that this doesn't pop back up later.
Closes #5292.
Ben Noordhuis [Thu, 18 Apr 2013 20:06:03 +0000 (22:06 +0200)]
website: add link to nightlies on download page
Ben Noordhuis [Thu, 18 Apr 2013 10:14:30 +0000 (12:14 +0200)]
Merge remote-tracking branch 'origin/v0.10'
Conflicts:
src/node_os.cc
Trevor Norris [Wed, 17 Apr 2013 18:45:13 +0000 (11:45 -0700)]
crypto: fix return Local Handle w/o scope.Close()
A new String was being created and returned, but was not sent through
the scope.Close(), which caused it to be cleaned up before being
returned.
Timothy J Fontaine [Wed, 17 Apr 2013 22:37:22 +0000 (15:37 -0700)]
build: libv8_base.a is now libv8_base.<arch>.a
This fixes generating the v8 contstants for dtrace on smartos
Ben Noordhuis [Wed, 17 Apr 2013 22:44:53 +0000 (00:44 +0200)]
dgram: fix no address bind()
I broke dgram.Socket#bind(port, cb) almost a year ago in
332fea5a but
it wasn't until today that someone complained and none of the tests
caught it because they all either specify the address or omit the
callback.
Anyway, now it works again and does what you expect: it binds the
socket to the "any" address ("0.0.0.0" for IPv4 and "::" for IPv6.)
Ben Noordhuis [Wed, 17 Apr 2013 21:59:49 +0000 (23:59 +0200)]
test: make stdout-close-unref work in test runner
process.stdout isn't fully initialized yet by the time the test starts
when invoked with `python tools/test.py`. Use process.stdin instead and
force initialization with process.stdin.resume().
Ben Noordhuis [Wed, 17 Apr 2013 14:59:19 +0000 (16:59 +0200)]
buffer: upgrade to new V8 profiler API
Ben Noordhuis [Mon, 8 Apr 2013 18:34:11 +0000 (20:34 +0200)]
v8: reapply floating patches
Ben Noordhuis [Wed, 17 Apr 2013 14:10:37 +0000 (16:10 +0200)]
deps: upgrade v8 to 3.18.0
Timothy J Fontaine [Thu, 11 Apr 2013 23:11:12 +0000 (16:11 -0700)]
http: split Client into _http_client.js
Timothy J Fontaine [Thu, 11 Apr 2013 23:00:19 +0000 (16:00 -0700)]
http: move Server and ServerResponse out
Timothy J Fontaine [Thu, 11 Apr 2013 22:37:14 +0000 (15:37 -0700)]
http: move OutgoingMessage into it's own file
Timothy J Fontaine [Thu, 11 Apr 2013 22:15:41 +0000 (15:15 -0700)]
http: move parsers into _http_common.js
Timothy J Fontaine [Thu, 11 Apr 2013 22:00:45 +0000 (15:00 -0700)]
http: move IncomingMessage into its own file
Timothy J Fontaine [Thu, 11 Apr 2013 21:47:15 +0000 (14:47 -0700)]
http: split Agent into its own file
Kelly Gerber [Tue, 9 Apr 2013 20:36:34 +0000 (13:36 -0700)]
docs: update path.join() example for v0.10
The current example shows the behavior of v0.8. In v0.10 arguments
to path.join() must be strings; otherwise, an exception is thrown.
Ryan Graham [Tue, 16 Apr 2013 20:52:52 +0000 (13:52 -0700)]
doc: note a gotcha with http.Server sockets
Ben Noordhuis [Tue, 16 Apr 2013 20:59:35 +0000 (22:59 +0200)]
handle_wrap: fix NULL pointer dereference
Fix a NULL pointer dereference in src/handle_wrap.cc which is really a
use-after-close bug.
The test checks that unref() after close() works on process.stdout but
this bug affects everything that derives from HandleWrap. I discovered
it because child processes would sometimes quit for no reason (that is,
no reason until I turned on core dumps.)
Stanislav Ochotnicky [Tue, 16 Apr 2013 07:51:56 +0000 (09:51 +0200)]
test: preserve process.env after test-init exec
When LD_LIBRARY_PATH is overriden for custom builds we need to preserve
it for child processes. To be sure we preserve whole environment of
parent process and just add TEST_INIT variable to it.
Stanislav Ochotnicky [Wed, 10 Apr 2013 13:38:02 +0000 (15:38 +0200)]
test: preserve process.env in forked child_process
When LD_LIBRARY_PATH is overriden for custom builds we need to preserve
it for forked process. There are possibly other environment variables
that could cause test failures so we preserve whole environment of
parent process.
Ben Noordhuis [Mon, 15 Apr 2013 20:36:49 +0000 (22:36 +0200)]
os: unbreak windows build
Windows doesn't have MAXHOSTNAMELEN. Introduced in afbadde.
Ben Noordhuis [Mon, 15 Apr 2013 19:05:20 +0000 (21:05 +0200)]
os: handle 256 character hostnames
Fix a (rather academic) buffer overflow. MAXHOSTNAMELEN is 256 on most
platforms, which means the buffer wasn't big enough to hold the
trailing nul byte on a system with a maximum length hostname.
Ben Noordhuis [Mon, 15 Apr 2013 18:51:28 +0000 (20:51 +0200)]
os: fix unlikely buffer overflow in os.type()
* Fix a buffer overflow that happens iff strlen(info.sysname) > 255.
* Check the return value of uname().
Ben Noordhuis [Fri, 12 Apr 2013 14:16:18 +0000 (16:16 +0200)]
test: add extra checks
Ben Noordhuis [Fri, 12 Apr 2013 13:54:31 +0000 (15:54 +0200)]
http: escape unsafe characters in request path
Make http.request() and friends escape unsafe characters in the request
path. That is, a request for '/foo bar' is now escaped as '/foo%20bar'.
Before this commit, the path was used as-is in the request status line,
creating an invalid HTTP request ("GET /foo bar HTTP/1.1").
Fixes #4381.
isaacs [Fri, 12 Apr 2013 23:27:42 +0000 (16:27 -0700)]
url: ~ is not actually an unwise char
isaacs [Fri, 12 Apr 2013 18:39:28 +0000 (11:39 -0700)]
url: Escape all unwise characters
This makes node's http URL handling logic identical to Chrome's
Re #5284