platform/core/uifw/multi-assistant-service.git
21 months agoBump version to 0.3.38 89/286589/1
Ji-hoon Lee [Tue, 10 Jan 2023 08:59:11 +0000 (17:59 +0900)]
Bump version to 0.3.38

Change-Id: Ibfc511e8953a4d9df1bc86803806f6f7a0f5a283

21 months agoPrevent duplicated requests from canceling active streaming session 88/286588/1
Ji-hoon Lee [Tue, 10 Jan 2023 08:58:51 +0000 (17:58 +0900)]
Prevent duplicated requests from canceling active streaming session

Change-Id: Ie0444f1b7bfa86bec4a415bc393e29ccee5839d0

22 months agoPostpone restart operation when streaming audio data 59/285659/1
Ji-hoon Lee [Thu, 15 Dec 2022 03:59:39 +0000 (12:59 +0900)]
Postpone restart operation when streaming audio data

Change-Id: I0189262b57d89885c4463a8443939cbc5f67660b

22 months agoMerge branch 'tizen' into tizen_7.0 84/285484/1
Ji-hoon Lee [Tue, 13 Dec 2022 11:12:23 +0000 (20:12 +0900)]
Merge branch 'tizen' into tizen_7.0

Change-Id: I905bc6257b4a774ad8d783bb871ca61cd68d3f5c

22 months agoAllow audio processor applications to send start streaming request 75/285475/1
Ji-hoon Lee [Tue, 13 Dec 2022 09:40:48 +0000 (18:40 +0900)]
Allow audio processor applications to send start streaming request

Change-Id: I36707c55cfc4e64331d2228c30ed051950c15bdf

22 months agoPostpone voice key release event emission until streaming completes 74/285474/1
Ji-hoon Lee [Fri, 9 Dec 2022 03:02:07 +0000 (12:02 +0900)]
Postpone voice key release event emission until streaming completes

Change-Id: I5931b2502c06fc645188a20c71a6ea1776ce7e63

23 months agoRemove unnecessary pid<->appid conversion logic 56/285056/1
Ji-hoon Lee [Mon, 5 Dec 2022 10:39:51 +0000 (19:39 +0900)]
Remove unnecessary pid<->appid conversion logic

Change-Id: If0439c8fae6c8ba65d8249eef9dbe4a9ac7d13d7

23 months agoReduce blocking time when streaming audio data 50/284950/3
Ji-hoon Lee [Wed, 30 Nov 2022 09:05:43 +0000 (18:05 +0900)]
Reduce blocking time when streaming audio data

When the CPU is busy handling many tasks, there are times
that the streaming thread gets blocked while calling some
undelying platform API functions. To avoid this problem,
applied several methods for reducing the blocking time
and added log messages for displaying time information.

List of methods used for reducing the blocking time:
1. Cache appid / pid information that is acquired by
   calling AUL API functions, since they sometimes
   do not return immediately and take a while to complete.
2. Instead of passing a pointer to the shared audio data
   into the message transmission module while holding the
   lock to protect the shared audio data, make a copy of
   audio data and release the lock immediately so that
   the copy of audio data can be used without the risk of
   race condition. This is because sometimes the message
   transmission also takes a bit of time to complete, and
   the other threads waiting for the lock cannot proceed
   in such cases.

Change-Id: I6c6959fadddbc557dbb77849fa25ce4949155f4b

23 months agoPrevent restarting service when conversation session exists 49/284949/1
Ji-hoon Lee [Wed, 30 Nov 2022 06:46:51 +0000 (15:46 +0900)]
Prevent restarting service when conversation session exists

Change-Id: I79771d40e67e2bda2efdd6a50474ef500fd5230c

2 years agoSkip application running check when acquiring PID or AppID 08/283308/1
Ji-hoon Lee [Mon, 24 Oct 2022 02:31:38 +0000 (11:31 +0900)]
Skip application running check when acquiring PID or AppID

Since the application running check is already performed
when wakeup event gets processed, there is no need to
check the running status every time PID or AppID is acquired.

Change-Id: If93f64f67cfde458123fca6c16f18713fd5118e8

2 years agoRegister package manager event handler before loading wakeup engines 99/282299/1
Ji-hoon Lee [Thu, 29 Sep 2022 11:33:06 +0000 (20:33 +0900)]
Register package manager event handler before loading wakeup engines

If the wakeup engine app gets installed while
multi-assistant-service is being launched and also
is trying to load wakeup engines, the newly installed
wakeup engine will not be loaded since at the time of
launching the installation was not completed,
and the installation completion event would not be
received also, since the package manager event handler
might not be registered yet.
So if we register package manager event handler first
and then load wakeup engines, even if the wakeup engine
currently being installed fails to be loaded, the
installation completion event is guaranteed to be received
by the package manager event handler, making sure that
the multi-assistant-service would restart for re-loading.

Change-Id: I1e8f57d6a08c9290a0ae11422d1404188c97c3df

2 years agoBump version to 0.3.37 38/282238/3 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/20221110.062230 accepted/tizen/7.0/unified/hotfix/20221116.110202 accepted/tizen/unified/20220930.020601 tizen_7.0_m2_release
InHong Han [Thu, 29 Sep 2022 03:12:24 +0000 (12:12 +0900)]
Bump version to 0.3.37

Change-Id: I5660de15f66039d338edee05bafbd9d05fe3ec01

2 years agoModified not to restart the daemon repeatedly 33/282233/2
InHong Han [Thu, 29 Sep 2022 00:59:16 +0000 (09:59 +0900)]
Modified not to restart the daemon repeatedly

Change-Id: I4fd0822ac19d5cd010a39afe79410e13f4162805

2 years agoChange log level for debugging 32/281832/1 accepted/tizen/unified/20220923.125147
InHong Han [Thu, 22 Sep 2022 07:40:19 +0000 (16:40 +0900)]
Change log level for debugging

Change-Id: I3050e5e4e9febd52d2adf131566cb3e90a9438af

2 years agoFix issue detected by static analysis tool 66/279366/1 accepted/tizen/unified/20220809.213751 submit/tizen/20220808.061214
InHong Han [Mon, 8 Aug 2022 04:54:32 +0000 (13:54 +0900)]
Fix issue detected by static analysis tool

Change-Id: I3d296586e161a2a024b301c1ef21e2f406799109

2 years agoBump version to 0.3.36 94/278694/6 accepted/tizen/unified/20220726.132003 submit/tizen/20220725.104008
InHong Han [Mon, 25 Jul 2022 06:27:30 +0000 (15:27 +0900)]
Bump version to 0.3.36

Change-Id: Id0a6a7523197ff665329ab7e5e988c91d6bb1dd7

2 years agoFix issue detected by static analysis tool 81/278681/8
InHong Han [Mon, 25 Jul 2022 05:29:28 +0000 (14:29 +0900)]
Fix issue detected by static analysis tool

Change-Id: I573bfa8478cad77c9f38f4eaa00304ea2d854bfa

2 years agoMerge changes I0271d097,If55e1690 into tizen
InHong Han [Mon, 25 Jul 2022 04:57:54 +0000 (04:57 +0000)]
Merge changes I0271d097,If55e1690 into tizen

* changes:
  Bump version to 0.3.35
  Modified not to load wakeup engine with wake_word_detection turned off

2 years agoBump version to 0.3.35 72/278472/4
InHong Han [Thu, 21 Jul 2022 02:32:35 +0000 (11:32 +0900)]
Bump version to 0.3.35

Change-Id: I0271d097f9b17f03899bc7189a41207a065b9fba

2 years agoModified not to load wakeup engine with wake_word_detection turned off 32/278432/7
InHong Han [Wed, 20 Jul 2022 09:58:46 +0000 (18:58 +0900)]
Modified not to load wakeup engine with wake_word_detection turned off

Change-Id: If55e1690071f43540e008bead090a6ecb3dc206b

2 years agoFix issue detected by static analysis tool 46/278646/4
Jihoon Kim [Sun, 24 Jul 2022 08:01:18 +0000 (17:01 +0900)]
Fix issue detected by static analysis tool

Change-Id: Iba3c2542af7a18ccf2b765a2cc2847c2b5d50219
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
2 years agoSend voice key support mode after changing default assistant 81/277781/3
InHong Han [Wed, 13 Jul 2022 08:04:03 +0000 (17:04 +0900)]
Send voice key support mode after changing default assistant

Change-Id: I718cab051170ae75d4ffc49de8675cbb3be969c5

2 years agoBump version to 0.3.34 42/277642/1 accepted/tizen/unified/20220715.141411 submit/tizen/20220711.100900 submit/tizen/20220713.011249
InHong Han [Mon, 11 Jul 2022 10:06:37 +0000 (19:06 +0900)]
Bump version to 0.3.34

Change-Id: I41e15c0c78de3b8942a946b0868673a51c35fa5f

2 years agoModified to load only required wakeup engines 63/277263/5
InHong Han [Mon, 4 Jul 2022 07:36:43 +0000 (16:36 +0900)]
Modified to load only required wakeup engines

Change-Id: I5088222fbe6217cf8381de5280f552efe3889599

2 years agoSupport checking recording_by_voice_key state for TTT 03/276703/2
Ji-hoon Lee [Thu, 23 Jun 2022 06:20:45 +0000 (15:20 +0900)]
Support checking recording_by_voice_key state for TTT

Change-Id: Ie91e1ece1e9eeb459b1ec18d3d22703bddbc1240

2 years agoBump version to 0.3.33 79/276579/1 accepted/tizen/unified/20220622.133914 submit/tizen/20220621.092214 submit/tizen/20220622.034918
InHong Han [Tue, 21 Jun 2022 05:31:52 +0000 (14:31 +0900)]
Bump version to 0.3.33

Change-Id: I4c1061b997357760dea6fc78e3cc77a5a748832a

2 years agoAdd missing wakeup_info assignment 78/276578/1
InHong Han [Tue, 21 Jun 2022 05:30:20 +0000 (14:30 +0900)]
Add missing wakeup_info assignment

Change-Id: Ib192e1c2ade1e922c19f5e5c6ee85431738be3e9

2 years agoBump version to 0.3.32 54/276454/1 accepted/tizen/unified/20220620.131724 submit/tizen/20220617.052105
Ji-hoon Lee [Fri, 17 Jun 2022 04:22:46 +0000 (13:22 +0900)]
Bump version to 0.3.32

Change-Id: Ia95d45786550312020aefe738eb5e5df04b4bdf3

2 years agoMake default wakeup policy to choose the first wakeup event 22/276322/1
Ji-hoon Lee [Tue, 14 Jun 2022 12:26:38 +0000 (21:26 +0900)]
Make default wakeup policy to choose the first wakeup event

Change-Id: I9c7ca76a001983198d6ffbb458911e28aceffac3

2 years agoAdd the new API for sending wakeup_word 21/276321/1
InHong Han [Fri, 13 May 2022 09:21:08 +0000 (18:21 +0900)]
Add the new API for sending wakeup_word

Change-Id: Idfac593bbc829a25036fa9093bb219e157cf1d2d

2 years agoPreserve wakeup manager state on proactive default assistant change 20/276320/1
Ji-hoon Lee [Thu, 9 Jun 2022 09:05:22 +0000 (18:05 +0900)]
Preserve wakeup manager state on proactive default assistant change

Change-Id: I772c2000e4201a7798226faeb70279fd36aca92e

2 years agoRemove media-audio-io and appcore-agent dependency 25/275325/4
Jihoon Kim [Fri, 20 May 2022 11:05:24 +0000 (20:05 +0900)]
Remove media-audio-io and appcore-agent dependency

Change-Id: If9ce14cfe817d90778e2e8c97bfe6dea9b1ca53a
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
2 years agoRemove app manager and network connection dependency 24/275324/3
Jihoon Kim [Fri, 20 May 2022 10:47:45 +0000 (19:47 +0900)]
Remove app manager and network connection dependency

Change-Id: I056f3a8ba87fb63cf1344c27a26319deaf6ec5ab
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
2 years agoRemove unused dependency 07/275307/3
Jihoon Kim [Fri, 20 May 2022 09:51:33 +0000 (18:51 +0900)]
Remove unused dependency

Change-Id: I493439e0bd4617fc0f98c1e5f03970d3bcb9e56d
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
2 years agoMerge branch 'tizen_6.5' into tizen 06/274906/4
Ji-hoon Lee [Thu, 26 May 2022 09:07:52 +0000 (18:07 +0900)]
Merge branch 'tizen_6.5' into tizen

Change-Id: I7d5d642fe7609f656a7e0214ad3136f18a3535bc

2 years agoBump version to 0.3.31 66/275566/1 accepted/tizen/unified/20220528.144339 submit/tizen/20220526.094642
Ji-hoon Lee [Thu, 26 May 2022 08:37:06 +0000 (17:37 +0900)]
Bump version to 0.3.31

Change-Id: Ibcf463383e6c15c3cc9ee4ee2a4d9abdb90b8b33

2 years agoAdd logs for checking if audio fetching is being retried properly 65/275565/1
Ji-hoon Lee [Thu, 26 May 2022 08:36:47 +0000 (17:36 +0900)]
Add logs for checking if audio fetching is being retried properly

Change-Id: I1cae28820288888d3bba0a75b6e5706244ea7d09

2 years agoSeparate config setter and value change handler 67/275267/1
Ji-hoon Lee [Thu, 19 May 2022 07:14:03 +0000 (16:14 +0900)]
Separate config setter and value change handler

Change-Id: Ia659b1cc4a56eca2a4293493c6ce5c3e21b0e565

2 years agoUpdate default assistant appid on wakeup event 25/274825/2
Ji-hoon Lee [Tue, 10 May 2022 05:59:05 +0000 (14:59 +0900)]
Update default assistant appid on wakeup event

Change-Id: I04e3059320e4a9f8e6d4c8902219297d47239a97

2 years agoBump version to 0.3.30 13/274813/1 submit/tizen/20220510.015603
Ji-hoon Lee [Tue, 10 May 2022 01:48:56 +0000 (10:48 +0900)]
Bump version to 0.3.30

Change-Id: I47826ad2f0aa95d062c40d89cc7f0ce3bbd4b526

2 years agoFix defects detected by static analysis tool 12/274812/1
Ji-hoon Lee [Tue, 10 May 2022 01:48:49 +0000 (10:48 +0900)]
Fix defects detected by static analysis tool

Change-Id: I34bf30e5c04dc391d185b8f3a8042ebf0530531a

2 years agoValidate sender information for every request from client 94/274794/1 submit/tizen/20220510.005443
Ji-hoon Lee [Mon, 9 May 2022 11:45:12 +0000 (20:45 +0900)]
Validate sender information for every request from client

Change-Id: I3d3b51e8b70dec4f8a25eb2827c5f647f6cca273

2 years agoBump version to 0.3.29 81/273581/2
Ji-hoon Lee [Fri, 8 Apr 2022 03:04:32 +0000 (12:04 +0900)]
Bump version to 0.3.29

Change-Id: I697921c3ed2f1169c640d9bd0ae2a7e0ea869fb9

2 years agoAdd metadata profile for providing metadata information 80/273580/2
Ji-hoon Lee [Fri, 8 Apr 2022 03:03:58 +0000 (12:03 +0900)]
Add metadata profile for providing metadata information

Change-Id: I51a2c31f29c032d68ea7830d7e348b29bd0e6457

2 years agoCall stop_recording on stop streaming request in UTTERANCE mode 79/273579/2
Ji-hoon Lee [Wed, 16 Mar 2022 04:41:20 +0000 (13:41 +0900)]
Call stop_recording on stop streaming request in UTTERANCE mode

Change-Id: Iea8789ee57a7cb6d64b1e8a47a5735f104e19155

2 years agoMerge "Ignore voice key press event during follow-up speech session" into tizen_6.5 tizen_6.5
Ji-hoon Lee [Wed, 13 Apr 2022 06:00:53 +0000 (06:00 +0000)]
Merge "Ignore voice key press event during follow-up speech session" into tizen_6.5

2 years agoMerge branch 'tizen_6.5' into tizen 35/273735/1
Ji-hoon Lee [Wed, 13 Apr 2022 05:56:10 +0000 (14:56 +0900)]
Merge branch 'tizen_6.5' into tizen

Change-Id: Icf05bbf20fbf9826582438208ea0c35ffe2957cc

2 years agoIgnore voice key press event during follow-up speech session 34/273734/1
Ji-hoon Lee [Wed, 13 Apr 2022 05:53:02 +0000 (14:53 +0900)]
Ignore voice key press event during follow-up speech session

Change-Id: Ia48da94500eb9e084fe17431e0b54fe43b9f89f7

2 years agoAdd engine load failure log messages to the ERROR group 90/272090/2
Ji-hoon Lee [Tue, 8 Mar 2022 09:21:58 +0000 (18:21 +0900)]
Add engine load failure log messages to the ERROR group

Change-Id: I341411c17a6c8511501d240039438df2a41faf31

2 years agoMerge branch 'tizen_6.5' into tizen 99/271299/1
Ji-hoon Lee [Fri, 18 Feb 2022 02:34:31 +0000 (11:34 +0900)]
Merge branch 'tizen_6.5' into tizen

Change-Id: Ifa3a76349c061f47bd67cd733400db6d36a52015

2 years agoBump version to 0.3.28 98/271298/1
Ji-hoon Lee [Fri, 18 Feb 2022 02:34:15 +0000 (11:34 +0900)]
Bump version to 0.3.28

Change-Id: I0769d4d1a80e5527c5c342dc7551ad0d5537e55b

2 years agoChange default streaming timeout value to 15 seconds 97/271297/1
Ji-hoon Lee [Fri, 18 Feb 2022 02:29:58 +0000 (11:29 +0900)]
Change default streaming timeout value to 15 seconds

Change-Id: Id5de962d01300918ef7032b1e365053eb5f27c0c

2 years agoPrint memory usage 46/269646/1
Ji-hoon Lee [Fri, 26 Nov 2021 03:27:16 +0000 (12:27 +0900)]
Print memory usage

Change-Id: I95f908f82e9d8a33b24a8710be109d99bfa6c976

2 years agoMerge branch 'tizen_6.5' into tizen 29/267829/1
Ji-hoon Lee [Fri, 10 Dec 2021 07:42:09 +0000 (16:42 +0900)]
Merge branch 'tizen_6.5' into tizen

Change-Id: Idd9643d757bdd1ac297bd1492ecd63cdc5fcb599

2 years agoBump version to 0.3.27 27/267827/1 submit/tizen_6.5/20211210.090952
Ji-hoon Lee [Fri, 10 Dec 2021 07:10:27 +0000 (16:10 +0900)]
Bump version to 0.3.27

Change-Id: I2dad772ca17773518574818eafb4a96d3b7dd54e

2 years agoHandle default assistant change event in UTTERANCE state 26/267826/1
Ji-hoon Lee [Fri, 10 Dec 2021 06:49:57 +0000 (15:49 +0900)]
Handle default assistant change event in UTTERANCE state

Previously, if default assistant gets changed in
UTTERANCE state, the state doesn't get reset.
Modified to generate recognition result ERROR
event in this case.

Change-Id: Ie9a58cdf8220d5f4d92ac19e79394b7e5145470c

2 years agoMerge branch 'tizen_6.5' into tizen 78/266678/1 accepted/tizen/unified/20211125.003817 submit/tizen/20211117.060824
Ji-hoon Lee [Wed, 17 Nov 2021 05:49:51 +0000 (14:49 +0900)]
Merge branch 'tizen_6.5' into tizen

Change-Id: Id5816241a659f19ba8862c94f7a672975fd7f1ca

2 years agoFix build error in 64bit profile 76/266676/1 accepted/tizen_6.5_unified accepted/tizen/6.5/unified/20211117.210602 submit/tizen_6.5/20211117.060654
Ji-hoon Lee [Wed, 17 Nov 2021 05:48:44 +0000 (14:48 +0900)]
Fix build error in 64bit profile

Change-Id: Iaf71b5f63c361b1942fc9b418720b9fa47aa354d

2 years agoMerge branch 'tizen' into tizen_6.5 65/266665/1 submit/tizen_6.5/20211117.043410
Ji-hoon Lee [Wed, 17 Nov 2021 04:17:12 +0000 (13:17 +0900)]
Merge branch 'tizen' into tizen_6.5

Change-Id: I3aace61b867207bd99cd70cd4cb21670babd2080

2 years agoAdd audio data transmission mileage in thread safe way 35/266335/1
Ji-hoon Lee [Wed, 10 Nov 2021 14:59:06 +0000 (23:59 +0900)]
Add audio data transmission mileage in thread safe way

Change-Id: I6de9199e4c70ec3f04682a52add02a2164e2eb5c

2 years agoExecute background volume control command in a separate thread 19/266319/1
Ji-hoon Lee [Wed, 10 Nov 2021 12:45:45 +0000 (21:45 +0900)]
Execute background volume control command in a separate thread

Change-Id: I1f07ef289514850cc179eb7cd2ff8c16b2918b31

2 years agoAdd audio data mileage and long-running dbus events in logs 18/266318/1
Ji-hoon Lee [Wed, 10 Nov 2021 12:44:52 +0000 (21:44 +0900)]
Add audio data mileage and long-running dbus events in logs

Change-Id: Iba38154d8bf3d3bdcf59658679c8b6108a1bc789

2 years agoBump version to 0.3.26 66/266266/1
Ji-hoon Lee [Wed, 10 Nov 2021 05:40:47 +0000 (14:40 +0900)]
Bump version to 0.3.26

Change-Id: I26f1ec4f35754a8ed757609f556c26fdf94a6710

2 years agoChange localtime to localtime_r for thread safety 74/266174/1
wn.jang [Tue, 9 Nov 2021 02:02:05 +0000 (11:02 +0900)]
Change localtime to localtime_r for thread safety

Change-Id: I809c8460625f2a10641252b6f0f43ec3853e12e6

3 years agoBump version to 0.3.25 67/266067/1 accepted/tizen/unified/20211108.181240 submit/tizen/20211105.070710
Ji-hoon Lee [Fri, 5 Nov 2021 06:57:16 +0000 (15:57 +0900)]
Bump version to 0.3.25

Change-Id: I33c503dd82c26130c77ea8613b1f713c29ab5138

3 years agoAdd lock to avoid race condition and add more log messages 66/266066/3
Ji-hoon Lee [Fri, 5 Nov 2021 06:51:38 +0000 (15:51 +0900)]
Add lock to avoid race condition and add more log messages

Change-Id: I52f7022d9e9ec2df82b09f45e32a7fd8b63aa041

3 years agoAdd more log messages to the ERROR level group 17/265817/1 accepted/tizen/unified/20211101.140215 submit/tizen/20211029.093841
Ji-hoon Lee [Fri, 29 Oct 2021 05:35:37 +0000 (14:35 +0900)]
Add more log messages to the ERROR level group

Change-Id: Ic0cffc1ce5f0a422a8947cd50944bbfc40e90526

3 years agoSend voice key status after recording control 86/265786/1
Ji-hoon Lee [Thu, 28 Oct 2021 11:19:11 +0000 (20:19 +0900)]
Send voice key status after recording control

Change-Id: I0df6b18411a218ec5eb271fc6dba6858276db74b

3 years agoBump version to 0.3.24 76/265776/1 submit/tizen/20211028.085023
Ji-hoon Lee [Thu, 28 Oct 2021 08:07:48 +0000 (17:07 +0900)]
Bump version to 0.3.24

Change-Id: I2bfd26b2f4636651ad802374d13d96ff0879b898

3 years agoRestore background volume if last requester gets deactivated 75/265775/1
Ji-hoon Lee [Thu, 28 Oct 2021 07:53:22 +0000 (16:53 +0900)]
Restore background volume if last requester gets deactivated

Change-Id: I8e70185d093741ff87a7084a915d65453c385f0d

3 years agoBump version to 0.3.23 33/265533/1 submit/tizen/20211021.124150
Ji-hoon Lee [Thu, 21 Oct 2021 12:11:06 +0000 (21:11 +0900)]
Bump version to 0.3.23

Change-Id: I8517a5b7bb727d671fbdb9c0879977e53ea25f4d

3 years agoAdd retry logic in case open_connection fails 32/265532/1
Ji-hoon Lee [Thu, 21 Oct 2021 11:08:55 +0000 (20:08 +0900)]
Add retry logic in case open_connection fails

Change-Id: I24abf21cafcadb752f40fc4945114b3bbb2dbbe1

3 years agoFix memory leak issue found while running tests 66/264766/1
Ji-hoon Lee [Wed, 29 Sep 2021 09:17:29 +0000 (18:17 +0900)]
Fix memory leak issue found while running tests

Change-Id: Id4509ed014382aab7938d06ce7920fb9478f8ccf

3 years agoBump version to 0.3.22 26/264626/1 accepted/tizen/6.5/unified/20211028.121805 accepted/tizen/unified/20210928.125345 submit/tizen/20210927.095004 submit/tizen_6.5/20211028.163101 tizen_6.5.m2_release
Ji-hoon Lee [Mon, 27 Sep 2021 09:41:08 +0000 (18:41 +0900)]
Bump version to 0.3.22

Change-Id: Ibc1d76df5a8adb85f1bf0f5fbcee1806f5d7ca96

3 years agoRetry at most 3 times if aul_app_get_appid_bypid() fails 22/264622/4
Ji-hoon Lee [Mon, 27 Sep 2021 09:15:11 +0000 (18:15 +0900)]
Retry at most 3 times if aul_app_get_appid_bypid() fails

If AMD and Launchpad is busy processing other tasks,
it might not respond to aul_app_get_appid_bypid() request
in its timeout limit, which is 5 seconds.
For this reason, after discussing with AppFW team,
we decided to add a retry logic at most 3 times if
the given function unexpectedly fails.

[==========] Running 4 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 4 tests from DefaultFixture
[ RUN      ] DefaultFixture.HardcodedAppIDReturnedForHardcodedPID
[       OK ] DefaultFixture.HardcodedAppIDReturnedForHardcodedPID (0 ms)
[ RUN      ] DefaultFixture.AppIDNotFoundForNonExistingPID
[       OK ] DefaultFixture.AppIDNotFoundForNonExistingPID (0 ms)
[ RUN      ] DefaultFixture.RetriesForAtLeastThreeTimes
[       OK ] DefaultFixture.RetriesForAtLeastThreeTimes (0 ms)
[ RUN      ] DefaultFixture.RetriesNoMoreThanThreeTimes
[       OK ] DefaultFixture.RetriesNoMoreThanThreeTimes (0 ms)
[----------] 4 tests from DefaultFixture (0 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 1 test suite ran. (0 ms total)
[  PASSED  ] 4 tests.

Change-Id: I49d42e6d664cf1bead1a00fb088ac0c8c2933514

3 years agoAdd more tests for verifying the behavior of CAudioManager class 66/264566/1
Ji-hoon Lee [Fri, 24 Sep 2021 10:36:13 +0000 (19:36 +0900)]
Add more tests for verifying the behavior of CAudioManager class

Previously, only a single test was available for CAudioManager class,
which definitely is not an adequate number to verify its behavior.
For this reason, added more tests to verify the current implementation
of CAudioManager class and also to guarantee the future modification
will not cause any unexpected results.

[==========] Running 11 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 11 tests from DefaultFixture
[ RUN      ] DefaultFixture.StreamsAllDataFed
[       OK ] DefaultFixture.StreamsAllDataFed (1 ms)
[ RUN      ] DefaultFixture.StreamsAllDataFedAfterClear
[       OK ] DefaultFixture.StreamsAllDataFedAfterClear (0 ms)
[ RUN      ] DefaultFixture.OnRecordingAudioDataCallbackProperlyCalled
[       OK ] DefaultFixture.OnRecordingAudioDataCallbackProperlyCalled (1 ms)
[ RUN      ] DefaultFixture.OnRecordingAudioDataCallbackProperlyCalledAfterFinalizing
[       OK ] DefaultFixture.OnRecordingAudioDataCallbackProperlyCalledAfterFinalizing (0 ms)
[ RUN      ] DefaultFixture.RecordingStartsWhenRequestedWithSoundFocus
[       OK ] DefaultFixture.RecordingStartsWhenRequestedWithSoundFocus (0 ms)
[ RUN      ] DefaultFixture.RecordingDoesNotStartWhenRequestedWithSoundFocus
[       OK ] DefaultFixture.RecordingDoesNotStartWhenRequestedWithSoundFocus (0 ms)
[ RUN      ] DefaultFixture.RecordingStopsWhenRequested
[       OK ] DefaultFixture.RecordingStopsWhenRequested (0 ms)
[ RUN      ] DefaultFixture.RecordingStopsWhenSoundFocusLost
[       OK ] DefaultFixture.RecordingStopsWhenSoundFocusLost (0 ms)
[ RUN      ] DefaultFixture.RecordingStartsWhenSoundFocusAcquiredAgain
[       OK ] DefaultFixture.RecordingStartsWhenSoundFocusAcquiredAgain (0 ms)
[ RUN      ] DefaultFixture.RecordingStartsWhenSoundFocusAcquiredLater
[       OK ] DefaultFixture.RecordingStartsWhenSoundFocusAcquiredLater (0 ms)
[ RUN      ] DefaultFixture.RecordingDoesNotStartWhenSoundFocusAcquiredAgainIfStopped
[       OK ] DefaultFixture.RecordingDoesNotStartWhenSoundFocusAcquiredAgainIfStopped (0 ms)
[----------] 11 tests from DefaultFixture (2 ms total)

[----------] Global test environment tear-down
[==========] 11 tests from 1 test suite ran. (2 ms total)
[  PASSED  ] 11 tests.

Change-Id: I50939d259e0b4f1072c6f7e1e2948ea1856eae38

3 years agoAdd tests for verifying the behavior of CWakeupManager 45/264545/1
Ji-hoon Lee [Fri, 24 Sep 2021 07:59:40 +0000 (16:59 +0900)]
Add tests for verifying the behavior of CWakeupManager

To make sure the modification made to CWakeupManager
would not cause any unexpected side-effect especially
on the observer modules, added tests for checking the
behavioral correctness of each operations.

[==========] Running 10 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 10 tests from DefaultFixture
[ RUN      ] DefaultFixture.SettingValueObserverCalledWhenLanguageChanges
[       OK ] DefaultFixture.SettingValueObserverCalledWhenLanguageChanges (2 ms)
[ RUN      ] DefaultFixture.SettingValueObserverCalledWhenAssistantAdded
[       OK ] DefaultFixture.SettingValueObserverCalledWhenAssistantAdded (2 ms)
[ RUN      ] DefaultFixture.SettingValueObserverCalledWhenAssistantDeleted
[       OK ] DefaultFixture.SettingValueObserverCalledWhenAssistantDeleted (2 ms)
[ RUN      ] DefaultFixture.WakeupEventNotTriggeredWhenInactiveMode
[       OK ] DefaultFixture.WakeupEventNotTriggeredWhenInactiveMode (1 ms)
[ RUN      ] DefaultFixture.WakeupEventTriggeredWhenVoiceKeyGetsPressed
[       OK ] DefaultFixture.WakeupEventTriggeredWhenVoiceKeyGetsPressed (1 ms)
[ RUN      ] DefaultFixture.AudioDataReceivedWhenVoiceKeyGetsPressed
[       OK ] DefaultFixture.AudioDataReceivedWhenVoiceKeyGetsPressed (12 ms)
[ RUN      ] DefaultFixture.FinishAudioDataReceivedWhenStoppedBeforeReleasingWithInterval
[       OK ] DefaultFixture.FinishAudioDataReceivedWhenStoppedBeforeReleasingWithInterval (604 ms)
[ RUN      ] DefaultFixture.FinishAudioDataReceivedWhenStoppedBeforeReleasingWithoutInterval
[       OK ] DefaultFixture.FinishAudioDataReceivedWhenStoppedBeforeReleasingWithoutInterval (303 ms)
[ RUN      ] DefaultFixture.FinishAudioDataReceivedOnResultBeforeReleasingWithInterval
[       OK ] DefaultFixture.FinishAudioDataReceivedOnResultBeforeReleasingWithInterval (607 ms)
[ RUN      ] DefaultFixture.FinishAudioDataReceivedOnResultBeforeReleasingWithoutInterval
[       OK ] DefaultFixture.FinishAudioDataReceivedOnResultBeforeReleasingWithoutInterval (303 ms)
[----------] 10 tests from DefaultFixture (1837 ms total)
[----------] Global test environment tear-down
[==========] 10 tests from 1 test suite ran. (1837 ms total)
[  PASSED  ] 10 tests.

Change-Id: I95054494410f2583874e94cd48277cc205dc1353

3 years agoBump version to 0.3.21 23/263623/2
Ji-hoon Lee [Tue, 7 Sep 2021 05:59:37 +0000 (14:59 +0900)]
Bump version to 0.3.21

Change-Id: I6865542b46dafda9670e8f6fd73ea3c52b9a56dc

3 years agoMake string members of wakeup event struct to be deep copied 21/263621/2
Ji-hoon Lee [Mon, 6 Sep 2021 12:00:04 +0000 (21:00 +0900)]
Make string members of wakeup event struct to be deep copied

This fixes the problem found when running the previously added test.

[ RUN      ] DefaultFixture.WakeupEventInfoPreservedForStringLiterals
[       OK ] DefaultFixture.WakeupEventInfoPreservedForStringLiterals (2 ms)
[ RUN      ] DefaultFixture.WakeupEventInfoPreservedForDynamicallyAllocatedStrings
[       OK ] DefaultFixture.WakeupEventInfoPreservedForDynamicallyAllocatedStrings (0 ms)
[----------] 2 tests from DefaultFixture (2 ms total)

Change-Id: I24fecd9a78767beda7fafce67f69fae6d53ebf1d

3 years agoAdd tests for wakeup-policy-default 20/263620/2
Ji-hoon Lee [Mon, 6 Sep 2021 12:04:50 +0000 (21:04 +0900)]
Add tests for wakeup-policy-default

These new tests shows that the existing WakeupPolicyDefault
store the string values using shallow copy method and thus
accessing the string value on timer expired event might cause
unexpected behavior.

[ RUN      ] DefaultFixture.WakeupEventInfoPreservedForStringLiterals
[       OK ] DefaultFixture.WakeupEventInfoPreservedForStringLiterals (1 ms)
[ RUN      ] DefaultFixture.WakeupEventInfoPreservedForDynamicallyAllocatedStrings
/home/abuild/ttpo/tests/test_main.cpp:128: Failure
Expected equality of these values:
  mWakeupAppID.compare(appid)
    Which is: -5
  0
[  FAILED  ] DefaultFixture.WakeupEventInfoPreservedForDynamicallyAllocatedStrings (1 ms)

Change-Id: I3fe82b3269cff96e74de1bbf86e0c2a9ffba2fc2

3 years agoFix build error in test code caused by a base type change 19/263619/1
Ji-hoon Lee [Mon, 6 Sep 2021 10:25:24 +0000 (19:25 +0900)]
Fix build error in test code caused by a base type change

Change-Id: Icabc735fba71657d871baaf5049cf3e063f1c33d

3 years agoBump version to 0.3.20 56/262556/1 accepted/tizen/unified/20210813.125502 submit/tizen/20210813.074603
Ji-hoon Lee [Fri, 13 Aug 2021 07:21:35 +0000 (16:21 +0900)]
Bump version to 0.3.20

Change-Id: I8a37b70f83315e382db4b7c35c8e19cffd8dfbf4

3 years agoFix defects detected by static analysis tool 55/262555/1
Ji-hoon Lee [Fri, 13 Aug 2021 07:17:20 +0000 (16:17 +0900)]
Fix defects detected by static analysis tool

Change-Id: I4a6ca3464e5a9c9c54b034fe7fa7f8a3577a7493

3 years agoFix defects detected by static analysis tool 51/262451/1 accepted/tizen/unified/20210813.005937 submit/tizen/20210811.070045
Ji-hoon Lee [Wed, 11 Aug 2021 06:20:50 +0000 (15:20 +0900)]
Fix defects detected by static analysis tool

Change-Id: I31b8d14b703b4e86693fe5dbbcae98f004380848

3 years agoBump version to 0.3.19 08/262408/1
Ji-hoon Lee [Tue, 10 Aug 2021 05:40:42 +0000 (14:40 +0900)]
Bump version to 0.3.19

Change-Id: I757f7140a29a080b71470c32087d187d5024ca0a

3 years agoRevert "Revert "Use trusted message port for secure audio transmission"" 07/262407/1
Ji-hoon Lee [Tue, 10 Aug 2021 05:26:04 +0000 (14:26 +0900)]
Revert "Revert "Use trusted message port for secure audio transmission""

This reverts commit 46fe031f38df204e591eaddb99e22d93d1d3964d.

Change-Id: I360abb42e85a73fd8bc13ac5108c323115a262fb

3 years agoMerge branch 'tizen_6.0' into tizen 06/262406/1
Ji-hoon Lee [Tue, 10 Aug 2021 05:25:55 +0000 (14:25 +0900)]
Merge branch 'tizen_6.0' into tizen

Change-Id: I51d38a7e2b5dd59d359cb7fd1dc99fbbc6d5aa0d

3 years agoBump version to 0.3.18 57/262357/1 accepted/tizen/unified/20210809.125005 submit/tizen/20210809.054836
Ji-hoon Lee [Mon, 9 Aug 2021 04:58:24 +0000 (13:58 +0900)]
Bump version to 0.3.18

Change-Id: I5007c7ba46627ea43fdcf205530dfb6fc9179c26

3 years agoFix crash when specified wakeup engine does not exist 56/262356/1
Ji-hoon Lee [Mon, 9 Aug 2021 04:57:27 +0000 (13:57 +0900)]
Fix crash when specified wakeup engine does not exist

Change-Id: I6e26ba9dc10031c45886491e9e1235602ebfca0b

3 years agoFix build break in 64bit profile 80/262180/1 accepted/tizen/unified/20210804.120436 submit/tizen/20210803.113947 submit/tizen/20210804.013324
Ji-hoon Lee [Tue, 3 Aug 2021 11:30:55 +0000 (20:30 +0900)]
Fix build break in 64bit profile

Change-Id: I2e525632de5565d824ac7c6e19002f78054f2715

3 years agoBump version to 0.3.17 62/262162/1 submit/tizen/20210803.074409
Ji-hoon Lee [Tue, 3 Aug 2021 07:11:25 +0000 (16:11 +0900)]
Bump version to 0.3.17

Change-Id: I2af56339b0b723a74af66ec4e1b57a361c4acfad

3 years agoFix log not printed bug and add more log messages 87/262087/1
Ji-hoon Lee [Mon, 2 Aug 2021 13:33:16 +0000 (22:33 +0900)]
Fix log not printed bug and add more log messages

Change-Id: I922eeb94469d52a8b47882a3f51412687e6877e2

3 years agoPrevent buffer overflow in case the audio data size is too large 86/262086/1
Ji-hoon Lee [Tue, 27 Jul 2021 05:27:43 +0000 (14:27 +0900)]
Prevent buffer overflow in case the audio data size is too large

Change-Id: Ibfe33f6baec68667fe5f82371d5374a9889b36e1

3 years agoAdd minimum flush time constraint 85/262085/1
Ji-hoon Lee [Fri, 23 Jul 2021 03:18:21 +0000 (12:18 +0900)]
Add minimum flush time constraint

Change-Id: If353d23ae3995f7e9e945053da82debc4b6672fe

3 years agoSupport multiple wakeup engines for single assistant 84/262084/1
Ji-hoon Lee [Thu, 29 Apr 2021 08:19:04 +0000 (17:19 +0900)]
Support multiple wakeup engines for single assistant

Change-Id: I417c1692707274eb2a727151f446fa6f170475e7

3 years agoFix errors found while adding tests for CPackageUpdateMonitor 03/260603/3
Ji-hoon Lee [Tue, 24 May 2016 23:09:33 +0000 (08:09 +0900)]
Fix errors found while adding tests for CPackageUpdateMonitor

While adding new tests for CPackageUpdateMonitor,
unexpected errors were found and fixed the main cause
that the 'ret' variable was used for both application
filter result and the function invocation result.

Since all the errors found while adding new tests are fixed,
the existing package related code is now replaced with the
CPackageUpdateMonitor class implementation.

Change-Id: Ia3af5644ac41aaae26248456103d042a76031fe2

3 years agoExtract package update monitor class and add test cases 02/260602/2
Ji-hoon Lee [Fri, 25 Jun 2021 10:48:34 +0000 (19:48 +0900)]
Extract package update monitor class and add test cases

Since the Package Update Monitor feature can be isolated
in a separate class, first copied the existing code
into a new class and added tests for verifying the
behavior of the new class.

While extracting, it was required to extract client info
struct into a new class also to avoid circular dependency.
At the moment, the newly extracted CClientInfo is not
well-organized, merely a struct revealing internal member
variable. This should be refactored in the future also.

Change-Id: I179540b5ba2890d40d4e1440a8e88861863dc416

3 years agoFix build break 33/259633/1 accepted/tizen/unified/20210611.014107 submit/tizen/20210610.090552
Ji-hoon Lee [Tue, 8 Jun 2021 07:45:51 +0000 (16:45 +0900)]
Fix build break

Change-Id: Ie8824f8d6377d8299bcd7319e1d568833884b226

3 years agoAccess audio buffer mutually exclusive using state variable 48/258848/1 tizen_6.0
Ji-hoon Lee [Wed, 26 May 2021 12:53:39 +0000 (21:53 +0900)]
Access audio buffer mutually exclusive using state variable

The previous implementation replies on the thread's
joinable value, which is not set back to false
if the thread exits but no join() gets called.
For this reason, use a dedicated state variable
instead of joinable state, which correctly reflects
the active state of the streaming thread.

Change-Id: I1596a4649109011f8acb412896bfe9fdbefb7e05

3 years agoFix bug detected from static analysis tool 97/258597/1 submit/tizen/20210521.041733 submit/tizen/20210610.085603
wn.jang [Fri, 21 May 2021 02:05:26 +0000 (11:05 +0900)]
Fix bug detected from static analysis tool

Change-Id: I044c80d5d5f291adaed1b49d21a06da621907341