Anil Belur [Thu, 19 Jun 2014 16:01:47 +0000 (02:01 +1000)]
staging: lustre: lustre: ldlm: ldlm_lib.c - removed unnecessary braces
- this change fixes "WARNING: braces {} are not necessary for single
statement blocks"
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 11:50:42 +0000 (21:50 +1000)]
staging: lustre: lustre: fld: lproc_fld.c fixed warning
fixed warning "WARNING: EXPORT_SYMBOL(foo); should immediately follow its
function/variable"
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 11:50:41 +0000 (21:50 +1000)]
staging: lustre: lustre: fld: lproc_fld.c fixed warning
fixed warning for line over 80 characters by moving the struct init
onto a diff line.
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 15:02:08 +0000 (01:02 +1000)]
staging: lustre: ldlm: ldlm_resource.c replace obsolete function with kstrtoul()
- this change fixes the warning "WARNING: simple_strtoul is obsolete, use
kstrtoul instead"
- removed the unused var 'end' as this is no longer required for
kstrtoul()
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 15:35:48 +0000 (01:35 +1000)]
staging: lustre: ldlm: ldlm_resource.c removed unecessary braces
- this fixed the "WARNING: braces {} are not necessary for
single statement blocks"
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 07:29:01 +0000 (17:29 +1000)]
staging : lustre : lustre : fid : lproc_fid.c: fixed warning
fixed warning for line over 80 characters by moving the initilation
onto a diff line.
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Skvortsov [Thu, 19 Jun 2014 07:24:13 +0000 (11:24 +0400)]
staging: lustre: obdclass: linux-sysctl.c: fix unnecessary spaces coding style issue
Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Skvortsov [Thu, 19 Jun 2014 07:24:12 +0000 (11:24 +0400)]
staging: lustre: obdclass: linux-sysctl.c: fix checkpatch warnings about included headers
Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Skvortsov [Thu, 19 Jun 2014 07:24:11 +0000 (11:24 +0400)]
staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue
Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Paul Bolle [Wed, 18 Jun 2014 15:05:47 +0000 (17:05 +0200)]
staging: Remove useless "default N" lines
Two Kconfig entries default to (uppercase) "N". It was clearly intended
to use "default n". But since (lowercase) "n" is the default anyway,
these lines might as well be removed.
Reported-by: Martin Walch <walch.martin@web.de>
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benedict Boerger [Thu, 19 Jun 2014 18:18:51 +0000 (20:18 +0200)]
staging: sep: Fix checkpatch.pl warnings
Fix checkpatch.pl warnings:
Missing blank line after Declarations
Signed-off-by: Benedict Boerger <benedict.boerger@cs.tu-dortmund.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Adithya Krishnamurthy [Thu, 19 Jun 2014 03:48:00 +0000 (09:18 +0530)]
Staging:tidspbridge Fix minor checkpatch.pl warning
Fixed checkpatch "WARNING: Missing a blank line after declarations"
Signed-off-by: Adithya Krishnamurthy <linux.challenge1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wolfgang Ocker [Sun, 15 Jun 2014 11:03:29 +0000 (13:03 +0200)]
staging cxt1e1: refactored ring buffer dump functions to avoid sparse warnings
Sparse spit out these warnings:
drivers/staging/cxt1e1/musycc.c:68:1: warning: context imbalance in 'musycc_dump_rxbuffer_ring' - different lock contexts for basic block
drivers/staging/cxt1e1/musycc.c:136:1: warning: context imbalance in 'musycc_dump_txbuffer_ring' - different lock contexts for basic block
The new functions musycc_dump_[rt]xbuffer_ring_locked() assume that the lock is
held. musycc_dump_[rt]xbuffer_ring() take the lock.
Signed-off-by: Wolfgang Ocker <weo@weo1.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sat, 14 Jun 2014 22:56:32 +0000 (00:56 +0200)]
staging: ced1401: userspace: use1401.c: Cleaning up if statement that always evaluates to true
Unsigned variable can't be negative so it is unnecessary to test it.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
A Raghavendra Rao [Wed, 11 Jun 2014 04:58:58 +0000 (10:28 +0530)]
Staging: rtl8192e: dot11d: Fixed printk coding style issues
Replaced 'printk' with 'netdev_' function
Signed-off-by: A Raghavendra Rao <arrao@cdac.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kees Cook [Tue, 10 Jun 2014 18:10:03 +0000 (11:10 -0700)]
staging: r8192ee: avoid leaking format string
This makes sure a format string cannot leak into the work queue name nor
the printk buffer.
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Tue, 17 Jun 2014 14:59:20 +0000 (23:59 +0900)]
staging: unisys: Remove trailing semicolon from macro
This patch removed trailing semicolon from macro in guestlinuxdebug.h
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Robin Schroer [Thu, 12 Jun 2014 23:17:30 +0000 (01:17 +0200)]
drivers/staging/speakup/main: fixed jiffie comparison
speakup_key() used manual comparison of jiffies to determine the time
since the last keypress, replaced it with time_after()
Signed-off-by: Robin Schroer <sulamiification@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alexey Khoroshilov [Tue, 10 Jun 2014 20:22:50 +0000 (00:22 +0400)]
staging: line6: do not return 0 from probe if no initialization done
There is a strange "return 0" in line6_probe() before any initialization of
the module is done. It can lead to NULL pointer dereference in other functions.
The patch proposes to return -ENODEV in this case.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vincent Heuken [Tue, 3 Jun 2014 12:41:33 +0000 (05:41 -0700)]
Staging: dgnc: fixed brace coding style issue in dgnc_driver.c
This is a patch to the dgnc_driver.c file that fixes the following
error:
ERROR: open brace '{' following function declarations go on
the next line
Signed-off-by: Vincent Heuken <me@vincentheuken.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arnd Bergmann [Thu, 5 Jun 2014 20:48:14 +0000 (22:48 +0200)]
staging: wlags49_h2: avoid PROFILE_ALL_BRANCHES warnings
Using an 'if()' inside of an 'extern inline' function causes
a gcc warning when CONFIG_PROFILE_ALL_BRANCHES is set every
time the function is called, which gets very noisy:
In file included from /git/arm-soc/drivers/staging/wlags49_h2/wl_wext.c:73:0:
drivers/staging/wlags49_h2/wl_internal.h:1035:216: warning: '______f' is static but declared in inline function 'wl_act_int_off' which is not static [enabled by default]
if(lp->is_handling_int == WL_HANDLING_INT) {
Fortunately there is a trivial workaround, so we can avoid
the problem by making the functions in question 'static inline'
rather than 'extern inline'.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Henk de Groot <pe1dnn@amsat.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arnd Bergmann [Thu, 5 Jun 2014 20:48:11 +0000 (22:48 +0200)]
staging: lirc: remove sa1100 support
The LIRC support for sa1100 appears to have never worked
because it relies on header files that have never been
present in git history. Actually trying to build the
driver on an ARM sa1100 kernel fails, so let's just remove
the broken support.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Jarod Wilson <jarod@wilsonet.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
Cc: linux-media@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arnd Bergmann [Thu, 5 Jun 2014 20:48:13 +0000 (22:48 +0200)]
staging: sn9c102 depends on USB
If the USB code is a loadable module, this driver cannot
be built-in. This adds an explicit dependency on CONFIG_USB
so that Kconfig can force sn9c102 to be a module in this case.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Luca Risolia <luca.risolia@studio.unibo.it>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: linux-media@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Robin Schroer [Mon, 16 Jun 2014 11:01:48 +0000 (13:01 +0200)]
drivers/staging/bcm/Misc: style: removed void returns
Signed-off-by: Robin Schroer <sulamiification@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Robin Schroer [Mon, 16 Jun 2014 11:01:47 +0000 (13:01 +0200)]
drivers/staging/bcm/Misc: style: removed duplicate parentheses
Signed-off-by: Robin Schroer <sulamiification@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Robin Schroer [Mon, 16 Jun 2014 11:01:46 +0000 (13:01 +0200)]
drivers/staging/bcm/Misc: style: added blank lines after declarations
Signed-off-by: Robin Schroer <sulamiification@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Tue, 17 Jun 2014 14:48:54 +0000 (23:48 +0900)]
staging: bcm: Remove unnecessary parentheses
This patch remove unnecessary parentheses in PHSModule.c
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sun, 8 Jun 2014 21:45:28 +0000 (23:45 +0200)]
staging: bcm: nvm.c: Cleaning up a array that is filled incompletely
Array 'SigBuff' is filled incompletely.
Someone forget to multiply for the sizeof type.
This was partly found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chuong Ngo [Fri, 6 Jun 2014 17:55:20 +0000 (13:55 -0400)]
drivers/staging/bcm: Added a space after a comma.
Signed-off-by: Chuong Ngo <cngo.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James A Shackleford [Mon, 2 Jun 2014 00:07:35 +0000 (20:07 -0400)]
staging: skein: fix sparse warning for static arrays
This patch fixes the following sparse warnings:
skein_iv.h:23:11: warning: symbol 'SKEIN_256_IV_128' was not declared. Should it be static?
skein_iv.h:31:11: warning: symbol 'SKEIN_256_IV_160' was not declared. Should it be static?
skein_iv.h:39:11: warning: symbol 'SKEIN_256_IV_224' was not declared. Should it be static?
skein_iv.h:47:11: warning: symbol 'SKEIN_256_IV_256' was not declared. Should it be static?
skein_iv.h:55:11: warning: symbol 'SKEIN_512_IV_128' was not declared. Should it be static?
skein_iv.h:67:11: warning: symbol 'SKEIN_512_IV_160' was not declared. Should it be static?
skein_iv.h:79:11: warning: symbol 'SKEIN_512_IV_224' was not declared. Should it be static?
skein_iv.h:91:11: warning: symbol 'SKEIN_512_IV_256' was not declared. Should it be static?
skein_iv.h:103:11: warning: symbol 'SKEIN_512_IV_384' was not declared. Should it be static?
skein_iv.h:115:11: warning: symbol 'SKEIN_512_IV_512' was not declared. Should it be static?
skein_iv.h:127:11: warning: symbol 'SKEIN_1024_IV_384' was not declared. Should it be static?
skein_iv.h:147:11: warning: symbol 'SKEIN_1024_IV_512' was not declared. Should it be static?
skein_iv.h:167:11: warning: symbol 'SKEIN_1024_IV_1024' was not declared. Should it be static?
by declaring the initialization vectors in question as static. The header
skein_iv.h is only included by skein.c
Signed-off-by: James A Shackleford <shack@linux.com>
Acked-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marcus Farkas [Sun, 1 Jun 2014 15:18:26 +0000 (17:18 +0200)]
staging: rtl8821ae: fix sparse warning for static declarations
This commit fixes the following sparse warnings in ps.c:
- 702: warning: symbol 'rtl_p2p_noa_ie' was not declared. Should it be static?
- 802: warning: symbol 'rtl_p2p_action_ie' was not declared. Should it be static?
Signed-off-by: Marcus Farkas <marcus.farkas@finitebox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vitaly Osipov [Sat, 14 Jun 2014 11:47:21 +0000 (21:47 +1000)]
staging: rtl8712: replace kmalloc(..., sizeof(T))
As suggested by Andy Shevchenko on driverdev-devel, replace
v = ... sizeof(struct type_of_v) -> sizeof(*v)
Based on a cocci patch along the lines of
@@
type T;
expression E;
identifier V;
@@
T *V;
...
- V = kmalloc(sizeof(T), E);
+ V = kmalloc(sizeof(*V), E);
@@
type T;
expression E;
identifier V;
@@
T *V;
...
- V = kzalloc(sizeof(T), E);
+ V = kzalloc(sizeof(*V), E);
Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sun, 15 Jun 2014 17:20:58 +0000 (19:20 +0200)]
staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement
The same code regardless of the outcome of the if statement.
And clean up another duplicate line of code.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arnd Bergmann [Thu, 5 Jun 2014 20:48:15 +0000 (22:48 +0200)]
staging: rtl8712, rtl8712: avoid lots of build warnings
The rtl8712 driver has an 'extern inline' function that contains an
'if', which causes lots of warnings with CONFIG_PROFILE_ALL_BRANCHES
overriding the definition of 'if':
drivers/staging/rtl8712/ieee80211.h:759:229: warning: '______f' is static but declared in inline function 'ieee80211_get_hdrlen' which is not static [enabled by default]
This changes the driver to use 'static inline' instead, which happens
to be the correct annotation anyway.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thomas Vegas [Sun, 1 Jun 2014 12:34:40 +0000 (14:34 +0200)]
staging: rtl8712: Remove useless variable 'fw_found'
The net device only exists when firmware is loaded successfully.
Firmware presence variable is only used through r871xu_dev_remove() and
this function already checks for net device existence.
Signed-off-by: Thomas Vegas <thomas@grouk.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thomas Vegas [Sun, 1 Jun 2014 12:34:39 +0000 (14:34 +0200)]
staging: rtl8712: Fix oops on dongle removal if firmware is not available
When firmware is not available, net device is not created. Upon
disconnect, we must check for net device existence before trying to
release net device private data.
Signed-off-by: Thomas Vegas <thomas@grouk.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Merlin Chlosta [Thu, 19 Jun 2014 17:59:32 +0000 (19:59 +0200)]
staging: vt6655: coding style: use C89 comments
fix coding style: use C89 comments, not C99
Signed-off-by: Merlin Chlosta <eudyptula@merlin.geekmail.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Kepplinger [Mon, 16 Jun 2014 16:05:36 +0000 (18:05 +0200)]
staging: vt6655: remove unnecessary typedef struct.
Remove a totally unnecessary typedef and rename it to lowercase.
This is more readable now.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James A Shackleford [Mon, 2 Jun 2014 03:06:57 +0000 (23:06 -0400)]
staging: vt6655: replace C99 style comments
Signed-off-by: James A Shackleford <shack@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James A Shackleford [Mon, 2 Jun 2014 02:19:33 +0000 (22:19 -0400)]
staging: vt6655: fix sparse warning for static declarations
This patch fixes the following sparse warnings:
iwctl.c:76:22: warning: symbol 'iwctl_get_wireless_stats' was not declared. Should it be static?
iwctl.c:118:5: warning: symbol 'iwctl_giwname' was not declared. Should it be static?
iwctl.c:131:5: warning: symbol 'iwctl_siwscan' was not declared. Should it be static?
iwctl.c:192:5: warning: symbol 'iwctl_giwscan' was not declared. Should it be static?
iwctl.c:344:5: warning: symbol 'iwctl_siwfreq' was not declared. Should it be static?
iwctl.c:390:5: warning: symbol 'iwctl_giwfreq' was not declared. Should it be static?
iwctl.c:420:5: warning: symbol 'iwctl_siwmode' was not declared. Should it be static?
iwctl.c:486:5: warning: symbol 'iwctl_giwmode' was not declared. Should it be static?
iwctl.c:520:5: warning: symbol 'iwctl_giwrange' was not declared. Should it be static?
iwctl.c:626:5: warning: symbol 'iwctl_siwap' was not declared. Should it be static?
iwctl.c:684:5: warning: symbol 'iwctl_giwap' was not declared. Should it be static?
iwctl.c:711:5: warning: symbol 'iwctl_giwaplist' was not declared. Should it be static?
iwctl.c:784:5: warning: symbol 'iwctl_siwessid' was not declared. Should it be static?
iwctl.c:893:5: warning: symbol 'iwctl_giwessid' was not declared. Should it be static?
iwctl.c:923:5: warning: symbol 'iwctl_siwrate' was not declared. Should it be static?
iwctl.c:1004:5: warning: symbol 'iwctl_giwrate' was not declared. Should it be static?
iwctl.c:1049:5: warning: symbol 'iwctl_siwrts' was not declared. Should it be static?
iwctl.c:1077:5: warning: symbol 'iwctl_giwrts' was not declared. Should it be static?
iwctl.c:1096:5: warning: symbol 'iwctl_siwfrag' was not declared. Should it be static?
iwctl.c:1123:5: warning: symbol 'iwctl_giwfrag' was not declared. Should it be static?
iwctl.c:1141:5: warning: symbol 'iwctl_siwretry' was not declared. Should it be static?
iwctl.c:1176:5: warning: symbol 'iwctl_giwretry' was not declared. Should it be static?
iwctl.c:1205:5: warning: symbol 'iwctl_siwencode' was not declared. Should it be static?
iwctl.c:1336:5: warning: symbol 'iwctl_giwencode' was not declared. Should it be static?
iwctl.c:1398:5: warning: symbol 'iwctl_siwpower' was not declared. Should it be static?
iwctl.c:1448:5: warning: symbol 'iwctl_giwpower' was not declared. Should it be static?
iwctl.c:1478:5: warning: symbol 'iwctl_giwsens' was not declared. Should it be static?
iwctl.c:1502:5: warning: symbol 'iwctl_siwauth' was not declared. Should it be static?
iwctl.c:1603:5: warning: symbol 'iwctl_giwauth' was not declared. Should it be static?
iwctl.c:1611:5: warning: symbol 'iwctl_siwgenie' was not declared. Should it be static?
iwctl.c:1644:5: warning: symbol 'iwctl_giwgenie' was not declared. Should it be static?
iwctl.c:1669:5: warning: symbol 'iwctl_siwencodeext' was not declared. Should it be static?
iwctl.c:1783:5: warning: symbol 'iwctl_giwencodeext' was not declared. Should it be static?
iwctl.c:1791:5: warning: symbol 'iwctl_siwmlme' was not declared. Should it be static?
iwctl.c:1900:21: warning: symbol 'iwctl_private_args' was not declared. Should it be static?
iwctl.c:1906:33: warning: symbol 'iwctl_handler_def' was not declared. Should it be static?
Signed-off-by: James A Shackleford <shack@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James A Shackleford [Mon, 2 Jun 2014 02:19:32 +0000 (22:19 -0400)]
staging: vt6655: update iwctl_private_args extern declaration
Update declaration of iwctl_private_args to match definition in iwctl.c
Signed-off-by: James A Shackleford <shack@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James A Shackleford [Mon, 2 Jun 2014 02:19:31 +0000 (22:19 -0400)]
staging: vt6655: update out-of-date function declaration
The function iwctl_siwscan() is defined in iwctl.c as:
int iwctl_siwscan(struct net_device *dev,
struct iw_request_info *info,
struct iw_point *wrq,
char *extra)
{
...
This patch updates iwctl.h so that the type of the 3rd parameter (*wqr) in the
function declaration matches the definition.
Signed-off-by: James A Shackleford <shack@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James A Shackleford [Mon, 2 Jun 2014 00:26:55 +0000 (20:26 -0400)]
staging: vt6655: fix sparse warning for static declarations
This patch fixes the following sparse warnings:
dpc.c:65:21: warning: symbol 'acbyRxRate' was not declared. Should it be static?
dpc.c:272:9: warning: symbol 'MngWorkItem' was not declared. Should it be static?
dpc.c:288:1: warning: symbol 'device_receive_frame' was not declared. Should it be static?
Signed-off-by: James A Shackleford <shack@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James A Shackleford [Sun, 1 Jun 2014 00:09:05 +0000 (20:09 -0400)]
staging: vt6655: fix sparse warning "cast removes address space of expression"
Add missing __user macro to second parameter of ethtool_ioctl().
This removes the need for the offending (void *) cast of the user space pointer
rq->ifr_data.
Signed-off-by: James A Shackleford <shack@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Scott Weir [Sat, 31 May 2014 11:54:58 +0000 (21:54 +1000)]
staging: gdm724x: Added blank lines after declarations in gdm_lte.c
This patch fixes following checkpatch.pl warning:
WARNING: Missing a blank line after declarations in gdm_lte.c
Signed-off-by: Scott Weir <sjw0410@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:35 +0000 (18:25 +0100)]
staging: vt6656: rename BBuGetFrameTime to vnt_get_frame_time
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:34 +0000 (18:25 +0100)]
staging: vt6656: rename BBvCalculateParameter to vnt_get_phy_field
The function returns the phy fields rename to vnt_get_phy_field
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:33 +0000 (18:25 +0100)]
staging: vt6656: rename FIRMWAREbCheckVersion to vnt_check_firmware_version
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:32 +0000 (18:25 +0100)]
staging: vt6656: rename FIRMWAREbBrach2Sram to vnt_firmware_branch_to_sram
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:31 +0000 (18:25 +0100)]
staging: vt6656: rename FIRMWAREbDownload to vnt_download_firmware
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:30 +0000 (18:25 +0100)]
staging: vt6656: firmware.c replace DBG_PRT debug messages
Replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:29 +0000 (18:25 +0100)]
staging: vt6656: FIRMWAREbCheckVersion remove camel case
camel case changes
pDevice -> priv
ntStatus -> status
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:28 +0000 (18:25 +0100)]
staging: vt6656: FIRMWAREbBrach2Sram remove camel case
camel case changes
pDevice -> priv
NdisStatus -> status
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:27 +0000 (18:25 +0100)]
staging: vt6656: FIRMWAREbDownload remove camel case
camel case changes
pDevice -> priv
NdisStatus -> status
pBuffer -> buffer
wLength -> length
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:26 +0000 (18:25 +0100)]
staging: vt6656: rename PSbIsNextTBTTWakeUp to vnt_next_tbtt_wakeup
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:25 +0000 (18:25 +0100)]
staging: vt6656: rename PSvDisablePowerSaving to vnt_disable_power_saving
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:24 +0000 (18:25 +0100)]
staging: vt6656: rename PSvEnablePowerSaving to vnt_enable_power_saving
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:23 +0000 (18:25 +0100)]
staging: vt6656: PSbIsNextTBTTWakeUp remove camel case
camel case changes
pDevice -> priv
pMgmt -> mgmt
bWakeup -> wake_up
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:22 +0000 (18:25 +0100)]
staging: vt6656: PSvDisablePowerSaving remove camel case
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 4 Jun 2014 17:25:21 +0000 (18:25 +0100)]
staging: vt6656: PSvEnablePowerSaving remove camel case
camel case changes
pDevice -> priv
wListenInterval -> listen_interval
pMgmt -> mgmt
wAID -> aid
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 12:35:00 +0000 (13:35 +0100)]
staging: vt6656: rxtx replace adwTxKey[4]
Replace with tx_key with size of WLAN_KEY_LEN_CCMP(16)
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 12:34:59 +0000 (13:34 +0100)]
staging: vt6656: rxtx s_vFillTxKey use vnt_usb_send_context
Use struct vnt_usb_send_context to get mac header and
priv pointers
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 12:34:58 +0000 (13:34 +0100)]
staging: vt6656: rxtx add mac header to vnt_tx_datahead_* structures
Add vnt_mac_hdr_pos to set mac header pointer and the calculate header size.
Pass ieee80211 hdr pointer and tx_hdr_size in vnt_usb_send_context.
Remove old pointer arithmetic and attach pMACHeader to hdr.
cbHeaderLength/cbHeaderSize now uses the value of tx_hdr_size.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 12:34:57 +0000 (13:34 +0100)]
staging: vt6656: rxtx move vnt_usb_send_context into tx structure.
Replacing struct vnt_private.
Where struct vnt_private is needed pointer to priv is added.
This allows to move tx signaling into vnt_usb_send_context.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:49 +0000 (11:50 +0100)]
staging: vt6656: rename MACvWriteBeaconInterval to vnt_mac_set_beacon_interval
Drop write for set
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:48 +0000 (11:50 +0100)]
staging: vt6656: rename MACvDisableBarkerPreambleMd to vnt_mac_disable_barker_preamble_mode
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:47 +0000 (11:50 +0100)]
staging: vt6656: rename MACvEnableBarkerPreambleMd to vnt_mac_enable_barker_preamble_mode
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:46 +0000 (11:50 +0100)]
staging: vt6656: rename MACvDisableProtectMD to vnt_mac_disable_protect_mode
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:45 +0000 (11:50 +0100)]
staging: vt6656: rename MACvEnableProtectMD to vnt_mac_enable_protect_mode
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:44 +0000 (11:50 +0100)]
staging: vt6656: rename MACvWriteBSSIDAddress to vnt_mac_set_bssid_addr
drop write for set and shorten address.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:43 +0000 (11:50 +0100)]
staging: vt6656: rename MACvWriteWord to vnt_mac_write_word
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:42 +0000 (11:50 +0100)]
staging: vt6656: rename MACvRegBitsOff to vnt_mac_reg_bits_off
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:41 +0000 (11:50 +0100)]
staging: vt6656: rename MACvRegBitsOff to vnt_mac_reg_bits_off
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:40 +0000 (11:50 +0100)]
staging: vt6656: rename MACvSetKeyEntry to vnt_mac_set_keyentry
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:39 +0000 (11:50 +0100)]
staging: vt6656: rename MACvDisableKeyEntry to vnt_mac_disable_keyentry
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:38 +0000 (11:50 +0100)]
staging: vt6656: rename MACvSetBBType to vnt_mac_set_bb_type
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:37 +0000 (11:50 +0100)]
staging: vt6656: rename MACbShutdown to vnt_mac_shutdown
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 31 May 2014 10:50:36 +0000 (11:50 +0100)]
staging: vt6656: rename MACvWriteMultiAddr to vnt_mac_set_filter
The function sets the mac filter so rename to vnt_mac_set_filter
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 22:22:54 +0000 (23:22 +0100)]
staging: vt6656: rename CARDvSetBSSMode to vnt_set_bss_mode
drop card and rename to vnt_set_bss_mode
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 22:22:53 +0000 (23:22 +0100)]
staging: vt6656: rename CARDbRadioPowerOn to vnt_radio_power_on
Drop card and rename to vnt_radio_power_on
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 22:22:52 +0000 (23:22 +0100)]
staging: vt6656: rename CARDbRadioPowerOff to vnt_radio_power_off
Drop card and rename to vnt_radio_power_off
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 22:22:51 +0000 (23:22 +0100)]
staging: vt6656: rename CARDvUpdateNextTBTT to vnt_update_next_tbtt
Drop card and rename to vnt_update_next_tbtt
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 22:22:50 +0000 (23:22 +0100)]
staging: vt6656: rename CARDvSetFirstNextTBTT to vnt_reset_next_tbtt
Drop card, set and first. The device resets the next tbtt rename
to vnt_reset_next_tbtt
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 22:22:49 +0000 (23:22 +0100)]
staging: vt6656: rename CARDqGetNextTBTT to vnt_get_next_tbtt
Drop card and rename to vnt_get_next_tbtt
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 22:22:48 +0000 (23:22 +0100)]
staging: vt6656: rename CARDbClearCurrentTSF to vnt_clear_current_tsf
Drop card and rename to vnt_clear_current_tsf
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 22:22:47 +0000 (23:22 +0100)]
staging: vt6656: rename CARDbGetCurrentTSF to vnt_get_current_tsf
Drop card and rename to vnt_get_current_tsf
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:51 +0000 (16:27 +0100)]
staging: vt6656: rename CARDvAdjustTSF to vnt_adjust_tsf
drop card and rename to vnt_adjust_tsf
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:50 +0000 (16:27 +0100)]
staging: vt6656: rename CARDqGetTSFOffset to vnt_get_tsf_offset
drop card and rename to vnt_get_tsf_offset
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:49 +0000 (16:27 +0100)]
staging: vt6656: rename CARDbyGetPktType to vnt_get_pkt_type
drop card rename to vnt_get_pkt_type
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:48 +0000 (16:27 +0100)]
staging: vt6656: rename CARDbIsOFDMinBasicRate to vnt_ofdm_min_rate
drop card and basic rename to vnt_ofdm_min_rate
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:47 +0000 (16:27 +0100)]
staging: vt6656: rename CARDbAddBasicRate to vnt_add_basic_rate
Drop card and rename to vnt_add_basic_rate
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:46 +0000 (16:27 +0100)]
staging: vt6656: rename CARDvSetRSPINF to vnt_set_rspinf
Drop card and rename to vnt_set_rspinf
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:45 +0000 (16:27 +0100)]
staging: vt6656: rename CARDvUpdateBasicTopRate to vnt_update_top_rates
Drop card basic. The function updates the top rates vnt_update_top_rates
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:44 +0000 (16:27 +0100)]
staging: vt6656: rename vUpdateIFS to vnt_update_ifs
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:43 +0000 (16:27 +0100)]
staging: vt6656: rename CARDvCalculateOFDMRParameter to vnt_calculate_ofdm_rate
Drop card and Parameter. R is the rate to rename to vnt_calculate_ofdm_rate
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:42 +0000 (16:27 +0100)]
staging: vt6656: rename swGetOFDMControlRate to vnt_get_ofdm_rate
Drop control and rename vnt_get_ofdm_rate
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:41 +0000 (16:27 +0100)]
staging: vt6656: rename swGetCCKControlRate to vnt_get_cck_rate
Drop control and just use vnt_get_cck_rate.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 30 May 2014 15:27:40 +0000 (16:27 +0100)]
staging: vt6656: rename CARDbSetMediaChannel to vnt_set_channel
Drop card and media and just use vnt_set_channel.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tair Rzayev [Sat, 31 May 2014 19:47:42 +0000 (22:47 +0300)]
staging: android: ion: ion_chunk_heap.c: Fix checkpatch warning
Fix the over 80 character line
Signed-off-by: Tair Rzayev <tair.rzayev@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Miguel Oliveira [Fri, 30 May 2014 16:44:26 +0000 (17:44 +0100)]
staging: nokia_h4: nokia_core.c Fixed coding style
Inserted a blank line after a declaration.
Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>
Acked-by: Pavel Machek <Pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>