platform/upstream/v8.git
14 years agoAdd void operator to fast compiler.
whesse@chromium.org [Fri, 30 Oct 2009 11:32:42 +0000 (11:32 +0000)]
Add void operator to fast compiler.
Review URL: http://codereview.chromium.org/342055

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix new snapshot compilation on ARM.
erik.corry@gmail.com [Fri, 30 Oct 2009 11:28:49 +0000 (11:28 +0000)]
Fix new snapshot compilation on ARM.
Review URL: http://codereview.chromium.org/349001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoIntroduce a switch for the new snapshot code and switch
erik.corry@gmail.com [Fri, 30 Oct 2009 10:23:12 +0000 (10:23 +0000)]
Introduce a switch for the new snapshot code and switch
it on by default.  Includes bug fixes for new snapshots.
Review URL: http://codereview.chromium.org/342054

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3184 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoSupport for calls on named and keyed properties in the fast compiler of the form:
fschneider@chromium.org [Fri, 30 Oct 2009 10:22:31 +0000 (10:22 +0000)]
Support for calls on named and keyed properties in the fast compiler of the form:

o.x() and o[expr]()

other changes:
- Fix missing relocation info for StoreIC on global object.
- Generate only one common return sequence instead of always appending
  "return <undefined>" at the end of each function: The first JS
  return-statement will generate the common return sequence. All
  other return-statements will generate a unconditional branch to the common
  return sequence.

Review URL: http://codereview.chromium.org/340037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix thinko in assertion.
kmillikin@chromium.org [Fri, 30 Oct 2009 09:57:08 +0000 (09:57 +0000)]
Fix thinko in assertion.

TBR=whesse@chromium.org

Review URL: http://codereview.chromium.org/343055

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3182 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoMove the Location class into the AST Expression class as a member.
kmillikin@chromium.org [Fri, 30 Oct 2009 08:36:46 +0000 (08:36 +0000)]
Move the Location class into the AST Expression class as a member.
Since it is (currently) only an enum, change it to an enum (for now).

Review URL: http://codereview.chromium.org/342035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3181 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoSupport for property assignment in the fast compiler.
fschneider@chromium.org [Fri, 30 Oct 2009 07:56:38 +0000 (07:56 +0000)]
Support for property assignment in the fast compiler.

The code for .result = (b.y = 99) where b is a global variable is:

  push [esi+0x17]
  mov ecx,0xf5c229ad          ;; object: 0xf5c229ad <String[1]: b>
  call LoadIC_Initialize
  nop
  mov [esp],eax
  mov eax,0xc6
  mov ecx,0xf5c25c41          ;; object: 0xf5c25c41 <String[1]: y>
  call StoreIC_Initialize
  nop
  mov [esp],eax
  pop [ebp+0xf4]

There is still some room for improvement in the generated code.

Other changes:
 - Replaced switch-statement in FastCodeGenerator::VisitProperty with DropAndMove(...)
 - Do not emit nop after IC calls on ARM.

Review URL: http://codereview.chromium.org/347001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd a test which verifies that weak reference callbacks cannot be invoked while scave...
antonm@chromium.org [Thu, 29 Oct 2009 23:06:59 +0000 (23:06 +0000)]
Add a test which verifies that weak reference callbacks cannot be invoked while scavenging.

BUG=25819

Review URL: http://codereview.chromium.org/334043

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoPrepare to push to trunk. We are now working on 1.3.19
sgjesse@chromium.org [Thu, 29 Oct 2009 14:33:51 +0000 (14:33 +0000)]
Prepare to push to trunk. We are now working on 1.3.19
Review URL: http://codereview.chromium.org/348010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3176 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoRename the Location type tags to be consistent with our current naming
kmillikin@chromium.org [Thu, 29 Oct 2009 13:58:04 +0000 (13:58 +0000)]
Rename the Location type tags to be consistent with our current naming
scheme for enumerations (eg, EFFECT => kEffect).

Remove the ability to move from one Location to another, which should
never be necessary.

Review URL: http://codereview.chromium.org/340034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3175 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoReverting 3159, 3151 and 3150
sgjesse@chromium.org [Thu, 29 Oct 2009 13:17:11 +0000 (13:17 +0000)]
Reverting 3159, 3151 and 3150

TBR=christian.plesner.hansen@gmail.com
Review URL: http://codereview.chromium.org/343035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3174 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix x64 build.
kmillikin@chromium.org [Thu, 29 Oct 2009 12:19:20 +0000 (12:19 +0000)]
Fix x64 build.

TBR=whesse@chromium.org

Review URL: http://codereview.chromium.org/346012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd binary operations to fast compiler.
whesse@chromium.org [Thu, 29 Oct 2009 11:55:03 +0000 (11:55 +0000)]
Add binary operations to fast compiler.
Review URL: http://codereview.chromium.org/342019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoRename the kinds of locations to be consistent with the (codegen)
kmillikin@chromium.org [Thu, 29 Oct 2009 10:35:29 +0000 (10:35 +0000)]
Rename the kinds of locations to be consistent with the (codegen)
context of the expressions they label.  Introduce an "unintialized"
location to catch failure to assign any location at all.

Changed the object literal initialization on ARM to use a Store IC in
the same cases where it did on the other platforms.  This was required
because the location of the literal property name is given an
"unitialized" location.

Review URL: http://codereview.chromium.org/339045

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoReverting 3153
sgjesse@chromium.org [Thu, 29 Oct 2009 07:31:23 +0000 (07:31 +0000)]
Reverting 3153

TBR=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/341031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoPrepare push to trunk. Now working on version 1.3.18.
ager@chromium.org [Wed, 28 Oct 2009 14:30:55 +0000 (14:30 +0000)]
Prepare push to trunk.  Now working on version 1.3.18.
Review URL: http://codereview.chromium.org/338063

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3166 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoARM still not quite right with new serialization code.
erik.corry@gmail.com [Wed, 28 Oct 2009 14:28:20 +0000 (14:28 +0000)]
ARM still not quite right with new serialization code.
Review URL: http://codereview.chromium.org/339043

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3165 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoIssue 485: Fix leak of builtins object through call and apply functions.
lrn@chromium.org [Wed, 28 Oct 2009 13:51:30 +0000 (13:51 +0000)]
Issue 485: Fix leak of builtins object through call and apply functions.

Review URL: http://codereview.chromium.org/345007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3164 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoIn the toplevel compiler, shift the responsibility of assigning a
kmillikin@chromium.org [Wed, 28 Oct 2009 13:25:40 +0000 (13:25 +0000)]
In the toplevel compiler, shift the responsibility of assigning a
location to an Expression AST node from the node's parent to the node
itself.

This allows an inherited code generation context from a parent node to
be passed arbitrarily far down the tree (eg, the subexpression of a
unary not is in the same context as the unary expression itself, the
then and else subexpressions of the ternary operator are in the same
context as the whole expression, and so forth).

We do not yet take advantage of this in the backend (eg, the right
subexpression of short-circuited OR is still compiled by using the
parent's destination location, rather than the subexpression's
itself).

Review URL: http://codereview.chromium.org/340005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoDerive string size constants
sgjesse@chromium.org [Wed, 28 Oct 2009 13:10:36 +0000 (13:10 +0000)]
Derive string size constants

* The maximum length of short and medium sized strings is now derived from other constants.
* Remove the redundant String part of their names.
Review URL: http://codereview.chromium.org/347002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3162 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years ago* Fix new snapshot code on ARM.
erik.corry@gmail.com [Wed, 28 Oct 2009 12:37:54 +0000 (12:37 +0000)]
* Fix new snapshot code on ARM.
Review URL: http://codereview.chromium.org/344011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3161 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoMarking test as expected to flake.
christian.plesner.hansen@gmail.com [Wed, 28 Oct 2009 12:23:35 +0000 (12:23 +0000)]
Marking test as expected to flake.

Review URL: http://codereview.chromium.org/343016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3160 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoChanged accessor ICs to using direct calls.
christian.plesner.hansen@gmail.com [Wed, 28 Oct 2009 12:14:20 +0000 (12:14 +0000)]
Changed accessor ICs to using direct calls.

Review URL: http://codereview.chromium.org/343015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3159 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd fast check for NaN in NumberCompare slow case.
ager@chromium.org [Wed, 28 Oct 2009 10:19:56 +0000 (10:19 +0000)]
Add fast check for NaN in NumberCompare slow case.
Review URL: http://codereview.chromium.org/344010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3158 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix missing recording of source position for property access in fast compiler.
fschneider@chromium.org [Wed, 28 Oct 2009 10:14:32 +0000 (10:14 +0000)]
Fix missing recording of source position for property access in fast compiler.

Review URL: http://codereview.chromium.org/341002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3157 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFactor out a commonly used code sequence to DropAndMove(Location, Register)
whesse@chromium.org [Wed, 28 Oct 2009 09:56:14 +0000 (09:56 +0000)]
Factor out a commonly used code sequence to DropAndMove(Location, Register)
Review URL: http://codereview.chromium.org/337060

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3156 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd snapshot option to test runner.
sgjesse@chromium.org [Wed, 28 Oct 2009 09:38:09 +0000 (09:38 +0000)]
Add snapshot option to test runner.

Passing option --snapshot to test.py has the same effect as passing -S snapshot=on.
Review URL: http://codereview.chromium.org/346004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3155 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix crbug/24815. Changes affect profiler "lazy" mode used for V8 in Chromium.
mikhail.naganov@gmail.com [Wed, 28 Oct 2009 09:13:11 +0000 (09:13 +0000)]
Fix crbug/24815. Changes affect profiler "lazy" mode used for V8 in Chromium.

- don't engage the processing thread of CPU profiling until the first time profiling is resumed, this saves us a thread allocation for the majority of users;
- don't log shared libraries addresses: this is useless for JS-only profiling, and also consumes time on startup.

Review URL: http://codereview.chromium.org/340013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3154 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoDon't use string slices when processing RexExp replace.
sgjesse@chromium.org [Wed, 28 Oct 2009 09:11:45 +0000 (09:11 +0000)]
Don't use string slices when processing RexExp replace.

String slices from RegExp replace results is now encoded in either one or two smis. Substrings are not used any more.

If the existing one smi encoding cannot hold the start/length information two smis are used the first having the negative length and the second having the start.

This is in preparation for removing string slices.
Review URL: http://codereview.chromium.org/342015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3153 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoSupport for property access (named, keyed) in the fast compiler.
fschneider@chromium.org [Tue, 27 Oct 2009 16:11:12 +0000 (16:11 +0000)]
Support for property access (named, keyed) in the fast compiler.

The generated code is similar to the existing code, but we never
inline any IC code in the fast compiler.

Review URL: http://codereview.chromium.org/337045

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFixed build error on x64.
christian.plesner.hansen@gmail.com [Tue, 27 Oct 2009 15:57:21 +0000 (15:57 +0000)]
Fixed build error on x64.

Review URL: http://codereview.chromium.org/339027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3151 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoImplemented specialized stubs for API getters. This includes a number
christian.plesner.hansen@gmail.com [Tue, 27 Oct 2009 15:38:49 +0000 (15:38 +0000)]
Implemented specialized stubs for API getters.  This includes a number
of individual changes:

  - Added infrastructure for custom stub caching.
  - Push the code object onto the stack in exit calls instead of a
    debug/non-debug marker.
  - Remove the DEBUG_EXIT frame type.
  - Add a new exit stub generator for API getters.

Committed: http://code.google.com/p/v8/source/detail?r=3130
Review URL: http://codereview.chromium.org/330017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3150 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoRemove --check-stack flag from V8.
whesse@chromium.org [Tue, 27 Oct 2009 14:56:50 +0000 (14:56 +0000)]
Remove --check-stack flag from V8.
Review URL: http://codereview.chromium.org/338017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd VisitCallNew to fast compiler.
whesse@chromium.org [Tue, 27 Oct 2009 14:52:55 +0000 (14:52 +0000)]
Add VisitCallNew to fast compiler.
Review URL: http://codereview.chromium.org/334041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoLanding http://codereview.chromium.org/339026
sgjesse@chromium.org [Tue, 27 Oct 2009 14:40:50 +0000 (14:40 +0000)]
Landing http://codereview.chromium.org/339026

TBR=lrn@chromium.org
Review URL: http://codereview.chromium.org/334044

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3147 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoMake it more pleasant to work with expression locations in the
kmillikin@chromium.org [Tue, 27 Oct 2009 13:38:57 +0000 (13:38 +0000)]
Make it more pleasant to work with expression locations in the
top-level code generator backend.  Introduce function to move one
location to another (source cannot be nowhere); to move registers,
slots, and literals into a location; and to move a location to a
register or slot.

Review URL: http://codereview.chromium.org/338043

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3146 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix bug in test on Windows.
lrn@chromium.org [Tue, 27 Oct 2009 13:26:22 +0000 (13:26 +0000)]
Fix bug in test on Windows.

Review URL: http://codereview.chromium.org/335044

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3145 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoStart using snapshot VM configuration in internal benchmark
erik.corry@gmail.com [Tue, 27 Oct 2009 13:19:14 +0000 (13:19 +0000)]
Start using snapshot VM configuration in internal benchmark
graphing tool.  Fix nonportable fopen call in new snapshot code.
Review URL: http://codereview.chromium.org/340002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3144 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFixed problem with test on big-endian-float ARM.
lrn@chromium.org [Tue, 27 Oct 2009 12:26:21 +0000 (12:26 +0000)]
Fixed problem with test on big-endian-float ARM.

Review URL: http://codereview.chromium.org/338044

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3143 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoNew snapshot framework. Doesn't work on ARM yet (code targets
erik.corry@gmail.com [Tue, 27 Oct 2009 11:54:01 +0000 (11:54 +0000)]
New snapshot framework.  Doesn't work on ARM yet (code targets
are different).  Is able to deserialize the whole heap and run
some stuff.  Not available as the primary snapshot system yet.
Review URL: http://codereview.chromium.org/335009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3142 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd fucomip instruction to disassembler. Fix some other floating point instructions.
whesse@chromium.org [Tue, 27 Oct 2009 10:47:01 +0000 (10:47 +0000)]
Add fucomip instruction to disassembler.  Fix some other floating point instructions.
Review URL: http://codereview.chromium.org/316010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3141 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix x64 breakage in r3136.
sgjesse@chromium.org [Tue, 27 Oct 2009 10:40:43 +0000 (10:40 +0000)]
Fix x64 breakage in r3136.

Make sure that the return value is moved to rax. The line added back was accidently removed in r3136.

TBR=lrn@chromium.org
Review URL: http://codereview.chromium.org/339021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3140 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix x64 DEBUG build.
kmillikin@chromium.org [Tue, 27 Oct 2009 10:27:08 +0000 (10:27 +0000)]
Fix x64 DEBUG build.

TBR=lrn@chromium.org

Review URL: http://codereview.chromium.org/338042

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3139 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoWindows: Change test to not assume ebp is frame-pointer.
lrn@chromium.org [Tue, 27 Oct 2009 08:50:24 +0000 (08:50 +0000)]
Windows: Change test to not assume ebp is frame-pointer.

Review URL: http://codereview.chromium.org/329007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3138 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoEliminate the constant location used for literals in the AST.
kmillikin@chromium.org [Tue, 27 Oct 2009 08:48:01 +0000 (08:48 +0000)]
Eliminate the constant location used for literals in the AST.
Literals now have a location of temporary by default and are
responsible for moving themselves into their location like all other
expressions.

The constant location turned out not to allow us to avoid checking
subexpressions in AST interior nodes, and it turned out to require
checking after some normal calls to Visit (like for the arguments to a
call).  With this change do not have to check after a call to Visit
that we got our result in the expected location.

Review URL: http://codereview.chromium.org/339004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3137 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoPort optimization of calls to GenericBinaryStub to x64.
sgjesse@chromium.org [Tue, 27 Oct 2009 08:20:21 +0000 (08:20 +0000)]
Port optimization of calls to GenericBinaryStub to x64.

See description of the change in the ia32 changelist at http://codereview.chromium.org/246075.

Minor changes to the ia32 version using variables for the registers to pass parameters in (edx and eax) to make the parameter set up code easier to read.
Review URL: http://codereview.chromium.org/335005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3136 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoChange NaN-test to only check for QNaNs, and API to only introduce QNaNs.
lrn@chromium.org [Tue, 27 Oct 2009 08:13:59 +0000 (08:13 +0000)]
Change NaN-test to only check for QNaNs, and API to only introduce QNaNs.

Review URL: http://codereview.chromium.org/339002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3135 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoApply patch by Timur Iskhodzhanov to add valgrind notifications on
ager@chromium.org [Mon, 26 Oct 2009 17:53:34 +0000 (17:53 +0000)]
Apply patch by Timur Iskhodzhanov to add valgrind notifications on
code modification to the x64 build.  The same notifications are
already in place in the ia32 build.

Review URL: http://codereview.chromium.org/335028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3134 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoReverted 3130-3131 since they don't work on mac.
christian.plesner.hansen@gmail.com [Mon, 26 Oct 2009 15:16:42 +0000 (15:16 +0000)]
Reverted 3130-3131 since they don't work on mac.

Review URL: http://codereview.chromium.org/335027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3133 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoGenerate more compact XOR on 64-bit architecture when using xor to zero out registers.
fschneider@chromium.org [Mon, 26 Oct 2009 14:38:22 +0000 (14:38 +0000)]
Generate more compact XOR on 64-bit architecture when using xor to zero out registers.

When using xor to zero a 64-bit register, generate 32-bit instruction instead.
(according to Intel 64-bit mode coding guidelines)

previous code for zeroing RAX:
  xor rax, rax

==>

new code for zeroing RAX:
  xor eax, eax

The 32-bit operand form has the same semantics: It also zeroes the upper
32-bit of rax and its encoding uses 1 byte less.

Review URL: http://codereview.chromium.org/330018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3132 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFixed release test build breakage.
christian.plesner.hansen@gmail.com [Mon, 26 Oct 2009 14:33:13 +0000 (14:33 +0000)]
Fixed release test build breakage.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3131 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoImplemented specialized stubs for API getters. This includes a number
christian.plesner.hansen@gmail.com [Mon, 26 Oct 2009 13:54:47 +0000 (13:54 +0000)]
Implemented specialized stubs for API getters.  This includes a number
of individual changes:

  - Added infrastructure for custom stub caching.
  - Push the code object onto the stack in exit calls instead of a
    debug/non-debug marker.
  - Remove the DEBUG_EXIT frame type.
  - Add a new exit stub generator for API getters.

Review URL: http://codereview.chromium.org/330017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3130 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoSupport for object literals in fast compiler.
fschneider@chromium.org [Mon, 26 Oct 2009 13:21:48 +0000 (13:21 +0000)]
Support for object literals in fast compiler.

I also added more unit tests for literals.

Right now, the fast compiler produces code very similar to
the existing code generator. We may consider different ways to
further compact the generated code for top-level code.

ARM always goes through a runtime function to initialize computed
properties in an object literal whereas IA32 and x64 use StoreIC.

Review URL: http://codereview.chromium.org/316009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAllocate global handles in chunks.
antonm@chromium.org [Mon, 26 Oct 2009 12:54:41 +0000 (12:54 +0000)]
Allocate global handles in chunks.

Review URL: http://codereview.chromium.org/327008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3128 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoHandle the list of code-stub types using macro expansion.
sgjesse@chromium.org [Mon, 26 Oct 2009 12:26:42 +0000 (12:26 +0000)]
Handle the list of code-stub types using macro expansion.

As the list of code-stubs is used in two places it is now handled through a macro to keep this in sync. As some code-stubs is only used on ARM the list have been split into two parts to indicate this and get rid of dummy implementation on ia32 and x64 platforms.

BUG=484
Review URL: http://codereview.chromium.org/335025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3127 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix retainer profile test regression
mikhail.naganov@gmail.com [Mon, 26 Oct 2009 11:59:55 +0000 (11:59 +0000)]
Fix retainer profile test regression

TBR=sgjesse@chromium.org

Review URL: http://codereview.chromium.org/338014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3126 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoMake V8::LowMemoryNotification GC for all platforms.
antonm@chromium.org [Mon, 26 Oct 2009 11:35:07 +0000 (11:35 +0000)]
Make V8::LowMemoryNotification GC for all platforms.

Review URL: http://codereview.chromium.org/330004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoHeap profiler improvements.
mikhail.naganov@gmail.com [Mon, 26 Oct 2009 10:51:30 +0000 (10:51 +0000)]
Heap profiler improvements.

- account code objects in retainers profile;
- differentiate between function boilerplates and closures;
- simplify code;

Review URL: http://codereview.chromium.org/335016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3124 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoRemove a check which was not needed
sgjesse@chromium.org [Fri, 23 Oct 2009 12:54:48 +0000 (12:54 +0000)]
Remove a check which was not needed
Review URL: http://codereview.chromium.org/326011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoUse RtlCaptureContext instead of inline assembly to capture execution context on...
sgjesse@chromium.org [Fri, 23 Oct 2009 12:47:44 +0000 (12:47 +0000)]
Use RtlCaptureContext instead of inline assembly to capture execution context on Windows

Inline assembly is not available in Visual C++ 64-bit version so use RtlCaptureContext to capture execution context. RtlCaptureContext is not available on Windows 2000 so this change removes Windows 2000 support. If this turns up causing trouble we can revert to only use RtlCaptureContext in 64-bit and inline assembly in 32-bit.
Review URL: http://codereview.chromium.org/335008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix issue with running some constructors having only this.x = ... assignments.
sgjesse@chromium.org [Fri, 23 Oct 2009 12:18:47 +0000 (12:18 +0000)]
Fix issue with running some constructors having only this.x = ... assignments.

If we had compiled the comment instead of the code it would have worked.

BUG=483
TEST=mjsunit/regress/regress-483.js
Review URL: http://codereview.chromium.org/332007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3120 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoX64/Win64: Fix bug in returning ObjectPair.
lrn@chromium.org [Fri, 23 Oct 2009 10:53:20 +0000 (10:53 +0000)]
X64/Win64: Fix bug in returning ObjectPair.
Used the registers to test for failure before loading the result from the stack.

Review URL: http://codereview.chromium.org/335006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3119 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoSimple toplevel code generator support for short-circuited boolean OR
kmillikin@chromium.org [Fri, 23 Oct 2009 10:42:14 +0000 (10:42 +0000)]
Simple toplevel code generator support for short-circuited boolean OR
in a non-test (ie, value or effect) context.  (It is implicitly not in
a test context because the code generator does not support expressions
in a test context yet.)

Compilation is essentially the same as in the optimized code
generator.  The expression (e0 || e1) is compiled as if it were
(let (temp = e0) temp ? temp : e1).

On ia32 and x64 a single shared ToBoolean stub is used to convert a
value to a flag.  The inlined checks assumed by the stub are reordered
to compare to undefined (the common case in toplevel code?) first.  On
ARM a call to the runtime is used.  In the interest of code size no
checks are yet inlined on ARM.

Review URL: http://codereview.chromium.org/334006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoStop throwing exceptions for out-of-range accesses to CanvasArrays.
kbr@chromium.org [Fri, 23 Oct 2009 09:19:17 +0000 (09:19 +0000)]
Stop throwing exceptions for out-of-range accesses to CanvasArrays.
This is per resolution in the WebGL working group to make these types
match the WebIDL IndexSetter and IndexGetter semantics, which are
still being defined but will very likely not throw.

Review URL: http://codereview.chromium.org/328007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3117 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoX64/Win64: Alternative implementation of fmod in general.
lrn@chromium.org [Fri, 23 Oct 2009 09:18:19 +0000 (09:18 +0000)]
X64/Win64: Alternative implementation of fmod in general.

Review URL: http://codereview.chromium.org/303034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3116 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix bug that meant that dependent tests were never reported as
erik.corry@gmail.com [Thu, 22 Oct 2009 19:09:09 +0000 (19:09 +0000)]
Fix bug that meant that dependent tests were never reported as
failing (though they could still crash).
(Cache the result of the test in the output object, not in the
test object which is reused from the prerequisite to the dependent.)
Review URL: http://codereview.chromium.org/321001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3115 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix lint errors.
kbr@chromium.org [Thu, 22 Oct 2009 15:21:00 +0000 (15:21 +0000)]
Fix lint errors.

Review URL: http://codereview.chromium.org/307037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3114 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd optimized ICs for new CanvasArray types introduced in WebGL
kbr@chromium.org [Thu, 22 Oct 2009 14:49:00 +0000 (14:49 +0000)]
Add optimized ICs for new CanvasArray types introduced in WebGL
specification under development. This is a follow-on CL to
http://codereview.chromium.org/293023 .

Based on review feedback, defined the behavior of storing NaN and
+/-Infinity into external arrays of integer types as storing 0. Added
test cases. Added fucomi instruction to assembler. Fixed bug in
KeyedLoadIC::GenerateExternalArray when allocation of HeapNumber
failed. Fixed bug in encoding of 16-bit immediate arithmetic
instructions in 64-bit port.

Removed raising of exceptions for negative array indices passed to
external arrays and associated tests. Based on current discussion in
WebGL working group, will probably end up removing the exception
throwing altogether.

Review URL: http://codereview.chromium.org/294022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3113 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoThe runtime function DeclareGlobals is not called from JavaScript.
kmillikin@chromium.org [Thu, 22 Oct 2009 11:32:12 +0000 (11:32 +0000)]
The runtime function DeclareGlobals is not called from JavaScript.
Add it to the exclusions list in the fuzz-natives test.

Review URL: http://codereview.chromium.org/306047

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3112 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd --trace flag to fast compiler.
whesse@chromium.org [Thu, 22 Oct 2009 11:21:29 +0000 (11:21 +0000)]
Add --trace flag to fast compiler.
Review URL: http://codereview.chromium.org/306026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3111 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdded support for array literals to the toplevel compiler. They are
kmillikin@chromium.org [Thu, 22 Oct 2009 10:07:45 +0000 (10:07 +0000)]
Added support for array literals to the toplevel compiler.  They are
currently compiled the same as with the optimizing compiler: they are
cloned from a boilerplate object and the boilerplate objects are
lazily constructed.

Also changed argument pushing on ARM to use stm (store multiple),
which required changing the order of arguments to the runtime
functions DeclareGlobals and NewClosure.  They were only used from
generated code.

Finally, changed the toplevel code generator so that stack pops to
discard a temporary became addition to the stack pointer on ia32 and
x64.

Review URL: http://codereview.chromium.org/303021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFast compiler support for regexp literals.
fschneider@chromium.org [Thu, 22 Oct 2009 09:29:03 +0000 (09:29 +0000)]
Fast compiler support for regexp literals.

For .result = /abc.*/g we generate the following IA-32 code:

   ...
   mov ebx,[edi+0x17]
   mov eax,[ebx+0xb]
   cmp eax, 0xf5d0e135         ;; object: 0xf5d0e135 <undefined>
   jnz done
   push ebx
   push 0x2
   push 0xf5d13805             ;; object: 0xf5d13805 <String[5]: abc.*>
   push 0xf5d13815             ;; object: 0xf5d13815 <String[1]: g>
   call RuntimeStub_MaterializeRegExpLiteral
 done:
   push eax
   pop [ebp+0xf4]
   ...

This is very similar to the code previously generated except we do not
generate deferred code for the case where we call the runtime.

On ARM we use the stm instruction to make pushing the arguments more compact.

Review URL: http://codereview.chromium.org/300037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3109 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd "Version" command
peter.rybin@gmail.com [Wed, 21 Oct 2009 17:07:43 +0000 (17:07 +0000)]
Add "Version" command

Review URL: http://codereview.chromium.org/274080

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3108 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix lint error.
kmillikin@chromium.org [Wed, 21 Oct 2009 15:37:14 +0000 (15:37 +0000)]
Fix lint error.

TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/293048

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3107 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAllow resource constraints to specify the max committed new space size
ager@chromium.org [Wed, 21 Oct 2009 15:03:34 +0000 (15:03 +0000)]
Allow resource constraints to specify the max committed new space size
when using snapshots.

The alignment of new space has to match the alignment in the snapshot,
but the max committed amount of memory does not.

For now, we assume that the default semispace size is always used in a
snapshot.
Review URL: http://codereview.chromium.org/300036

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3106 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoHeap profiler: guard calls to Producer profile.
mikhail.naganov@gmail.com [Wed, 21 Oct 2009 13:04:53 +0000 (13:04 +0000)]
Heap profiler: guard calls to Producer profile.

Patch by Steve Block.

TBR=ager@chromium.org

Review URL: http://codereview.chromium.org/307018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3105 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoHeap profiler: use Heap::CommittedMemory to report the "total" memory size.
mikhail.naganov@gmail.com [Wed, 21 Oct 2009 12:39:45 +0000 (12:39 +0000)]
Heap profiler: use Heap::CommittedMemory to report the "total" memory size.

This is the second change to eliminate reporting >100% VM memory usage.

BUG=http://crbug/23623

Review URL: http://codereview.chromium.org/300029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3104 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoUse WriteToFlat instead of to C strings methods as WriteToFlat performs notably
antonm@chromium.org [Wed, 21 Oct 2009 12:14:50 +0000 (12:14 +0000)]
Use WriteToFlat instead of to C strings methods as WriteToFlat performs notably
better for various kinds of strings.

Review URL: http://codereview.chromium.org/293027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3103 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoSupport empty statements in the fast compiler.
fschneider@chromium.org [Wed, 21 Oct 2009 11:56:05 +0000 (11:56 +0000)]
Support empty statements in the fast compiler.

Review URL: http://codereview.chromium.org/313003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3102 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd support for global variable references in toplevel code. We use
kmillikin@chromium.org [Wed, 21 Oct 2009 09:38:21 +0000 (09:38 +0000)]
Add support for global variable references in toplevel code. We use
the normal named load IC mechanism for now.  Generated code is similar
to the case for global variable assignments.

Review URL: http://codereview.chromium.org/294021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3101 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoCommit fucomip change 197037 http://codereview.chromium.org/197037/show
whesse@chromium.org [Wed, 21 Oct 2009 09:24:25 +0000 (09:24 +0000)]
Commit fucomip change 197037 codereview.chromium.org/197037/show

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3100 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdding declaration of global variables and functions in new compiler.
fschneider@chromium.org [Wed, 21 Oct 2009 09:17:39 +0000 (09:17 +0000)]
Adding declaration of global variables and functions in new compiler.
Adding calls to global functions to the new compiler.

Review URL: http://codereview.chromium.org/302002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoapplied patch
mikhail.naganov@gmail.com [Tue, 20 Oct 2009 23:25:05 +0000 (23:25 +0000)]
applied patch

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3098 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix buildbot breakage. Neglected to run tests with --verify-heap and
kbr@chromium.org [Tue, 20 Oct 2009 17:44:21 +0000 (17:44 +0000)]
Fix buildbot breakage. Neglected to run tests with --verify-heap and
missed case statements for heap verification and printing needed by
http://codereview.chromium.org/293023 .

tbr=plesner

Review URL: http://codereview.chromium.org/308004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3097 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdded infrastructure for optimizing new CanvasArray types in WebGL
kbr@chromium.org [Tue, 20 Oct 2009 15:26:17 +0000 (15:26 +0000)]
Added infrastructure for optimizing new CanvasArray types in WebGL
specification under development. The optimizations are patterned after
those previously done for CanvasPixelArray. This CL adds all of the
necessary framework but continues to use the generic KeyedLoadIC and
KeyedStoreIC code, to create a baseline for benchmarking purposes. The
next CL will add the optimized ICs to ic-ia32.cc and ic-x64.cc.

These new CanvasArray types have different semantics than
CanvasPixelArray; out-of-range values are clamped via C cast
semantics, which is cheaper than the clamping behavior specified by
CanvasPixelArray. Out-of-range indices raise exceptions instead of
being silently ignored.

As part of this work, pulled FloatingPointHelper::AllocateHeapNumber
up to MacroAssembler on ia32 and x64 platforms. Slightly refactored
KeyedLoadIC and KeyedStoreIC. Fixed encoding for fistp_d on x64 and
added a few more instructions that are needed for the new ICs. The
test cases in test-api.cc have been verified by hand to exercise all
of the generated code paths in the forthcoming specialized ICs.

Review URL: http://codereview.chromium.org/293023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3096 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdded support for assignments to global variables in the toplevel code
kmillikin@chromium.org [Tue, 20 Oct 2009 13:37:26 +0000 (13:37 +0000)]
Added support for assignments to global variables in the toplevel code
generator.  We use the normal store IC mechanism with the global
object as the receiver.  The following code is generated for 'x=true'
at toplevel.

======== IA32:

27  mov eax,0xf5d06161          ;; object: 0xf5d06161 <true>
32  mov ecx,0xf5d09c35          ;; object: 0xf5d09c35 <String[1]: x>
37  push [esi+0x17]
40  call StoreIC_Initialize  (0xf5ce75c0)    ;; code: STORE_IC, UNINITIALIZED
45  mov [esp],eax

======== X64:

25  movq rax,0x7f867a7b6199    ;; object: 0x7f867a7b6199 <true>
35  movq rcx,0x7f867a7bae71    ;; object: 0x7f867a7bae71 <String[1]: x>
45  push [rsi+0x2f]
49  call StoreIC_Initialize  (0x7f8655929ac0)    ;; code: STORE_IC, UNINITIALIZED
54  movq [rsp],rax

======== ARM:

32  e59f0054       ldr r0, [pc, #+84]          ;; object: 0xf5b78161 <true>
36  e59f2054       ldr r2, [pc, #+84]          ;; object: 0xf5b7bc35 <String[1]: x>
40  e598c017       ldr ip, [r8, #+23]
44  e52dc004       str ip, [sp, #-4]!
48  e1a0e00f       mov lr, pc
52  e59ff048       ldr pc, [pc, #+72]          ;; debug: statement 0
                                               ;; code: STORE_IC, UNINITIALIZED
56  e58d0000       str r0, [sp, #+0]

Review URL: http://codereview.chromium.org/305005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix issue 475
sgjesse@chromium.org [Tue, 20 Oct 2009 12:13:31 +0000 (12:13 +0000)]
Fix issue 475

The check for arguments in registers in one of the three versions of GenericBinaryOpStub::GenerateCall was plain wrong.

BUG=475
TEST=mjsunit/regress/regress-475.js
Review URL: http://codereview.chromium.org/307002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoA simple change to enable empty top-level function bodies in the
kmillikin@chromium.org [Tue, 20 Oct 2009 09:12:53 +0000 (09:12 +0000)]
A simple change to enable empty top-level function bodies in the
fast-mode compiler.  Support was already present, but disabled.

Review URL: http://codereview.chromium.org/295004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3091 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoVerify correctness of external string only if slow asserts are enabled.
antonm@chromium.org [Tue, 20 Oct 2009 09:10:26 +0000 (09:10 +0000)]
Verify correctness of external string only if slow asserts are enabled.

Review URL: http://codereview.chromium.org/294019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3090 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoAdd an API to V8 to get simple heap statistics.
ager@chromium.org [Tue, 20 Oct 2009 07:51:49 +0000 (07:51 +0000)]
Add an API to V8 to get simple heap statistics.
Review URL: http://codereview.chromium.org/261037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3089 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoRecognize in the fast-mode code generator when a subexpression is a
kmillikin@chromium.org [Mon, 19 Oct 2009 10:36:42 +0000 (10:36 +0000)]
Recognize in the fast-mode code generator when a subexpression is a
constant known at compile time.  Do not ever use the stack to
materialize (non-function-argument) constants.  Currently, constants
are only the non-materialized, non-function literals in the AST.

It is a known issue that there is no test coverage for the cases of
assigning a non-literal to a variable and returning a literal.  Those
code paths are unreachable and tests will be added when they become
reachable.

For the code '.result = true', we had previously on ia32:

27  push 0xf5c28161             ;; object: 0xf5c28161 <true>
32  pop [ebp+0xf4]

Now:

27  mov eax,0xf5c26161          ;; object: 0xf5c26161 <true>
32  mov [ebp+0xf4],eax

======== We had previously on x64:

25  movq r10,0x7fb8c2f78199    ;; object: 0x7fb8c2f78199 <true>
35  push r10
37  pop [rbp-0x18]

Now:

25  movq r10,0x7fb131386199    ;; object: 0x7fb131386199 <true>
35  movq [rbp-0x18],r10

The generated code for ARM did not include the extra memory traffic.
It was already eliminated by the ARM assembler's push/pop elimination.

Review URL: http://codereview.chromium.org/300003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3088 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoRemove unused 'unsafe smi' code on x64.
kmillikin@chromium.org [Mon, 19 Oct 2009 07:54:39 +0000 (07:54 +0000)]
Remove unused 'unsafe smi' code on x64.
Review URL: http://codereview.chromium.org/293003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3087 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoFix mac x64 build.
antonm@chromium.org [Fri, 16 Oct 2009 15:00:45 +0000 (15:00 +0000)]
Fix mac x64 build.

BUG=472

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3086 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoMove implementation of Integer::NewFromUnsigned into api.cc.
antonm@chromium.org [Fri, 16 Oct 2009 12:51:18 +0000 (12:51 +0000)]
Move implementation of Integer::NewFromUnsigned into api.cc.

Review URL: http://codereview.chromium.org/269105

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3084 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoDo not do post GC processing for scavenges.
antonm@chromium.org [Fri, 16 Oct 2009 12:11:59 +0000 (12:11 +0000)]
Do not do post GC processing for scavenges.

Typically there is no or few global handles to delete (only manually deleted, but those might be
reused).

Review URL: http://codereview.chromium.org/274050

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3083 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoPreparing to push to trunk. Now working on 1.3.17.
christian.plesner.hansen@gmail.com [Fri, 16 Oct 2009 11:33:39 +0000 (11:33 +0000)]
Preparing to push to trunk.  Now working on 1.3.17.

Review URL: http://codereview.chromium.org/283009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3081 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoRemove dependency on V8_TARGET_ARCH in v8.h
lrn@chromium.org [Fri, 16 Oct 2009 10:29:10 +0000 (10:29 +0000)]
Remove dependency on V8_TARGET_ARCH in v8.h

Review URL: http://codereview.chromium.org/287004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3080 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoDo not visit slots in the top-level code generator's backend.
kmillikin@chromium.org [Fri, 16 Oct 2009 09:46:09 +0000 (09:46 +0000)]
Do not visit slots in the top-level code generator's backend.

Slots appear only indirectly in the AST (through variables linked to
variable proxies).  Slots are shared among variable references, so
putting compilation-time state on them is potentially a source of
bugs.  Avoid it for now.

Review URL: http://codereview.chromium.org/284009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3079 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoRemove stray debugging code with no effect or explanation from RelocIterator.
whesse@chromium.org [Fri, 16 Oct 2009 09:31:03 +0000 (09:31 +0000)]
Remove stray debugging code with no effect or explanation from RelocIterator.
Review URL: http://codereview.chromium.org/287003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3078 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14 years agoRedo "running" field in debug-delay.js and support "suspend" command
peter.rybin@gmail.com [Thu, 15 Oct 2009 20:06:08 +0000 (20:06 +0000)]
Redo "running" field in debug-delay.js and support "suspend" command

It also fixes "backtrace" command so that it didn't give away random stack if we are running

Review URL: http://codereview.chromium.org/242034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3077 ce2b1a6d-e550-0410-aec6-3dcde31c8c00