Tomas Weinfurt [Thu, 9 Sep 2021 15:28:23 +0000 (08:28 -0700)]
only cache credentials on success (#58594)
Fan Yang [Thu, 9 Sep 2021 13:05:26 +0000 (09:05 -0400)]
Use XHarnessApkToTest to create helix work items for runtime tests when running on Android (#57292)
* Try to use CustomCommand for Android jobs
* Moved property group outside of item group.
* Reverted commenting in runtime.yml
* reverted comment change to global-build.yml
* Target->TestTarget
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
* Fixed item group nesting.
* Added version string.
* Define HelixWorkItem and XHarnessApkToTest after defining Payloads
* Disable more unrelated lanes when experimenting
* Remove the code to only run one test
* Uncomment global-build
* Uncomment some jobs
* Uncomment mono and library build jobs
* Uncomment more mono build jobs
* Uncomment more mono jobs
* Fix app path
* Keep full path
* Use zip files as XHarnessApkToTest inputs
* Fix attribute error
* Fix syntax
* Update src/tests/Common/helixpublishwitharcade.proj
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
* Zip payload folder after target PreparePayloadsDirectories
* Revert the hack
* Revert unwanted changes
* Remove typo
* Address review feedback
* Add back timeout threshold
* Remove redundant var
Co-authored-by: Nathan Ricci <naricc@microsoft.com>
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
Filip Navara [Thu, 9 Sep 2021 11:51:01 +0000 (13:51 +0200)]
[MonoVM] Report correct DLL name when P/Invoke lookup fails (#58206)
https://github.com/dotnet/runtime/issues/58185
Alexander Köplinger [Thu, 9 Sep 2021 11:40:05 +0000 (13:40 +0200)]
System.Net.Ping: Skip TimeoutIsRespected test if network is unreachable (#58745)
The TestSettings.UnreachableAddress is using 192.0.2.0 which is documented in RFC5735 as a network to be used in docs/example code.
On the Android devices in Helix the upstream network is configured to not route this address which results in a "Destination Net Unreachable" response
which causes the timeout argument to ping to be ignored and ping returns immediately.
Skip the test in these cases.
Example output from ping on the device:
```
1|sunfish:/ $ time ping -c 1 -W 2 -s 50 192.0.2.0
PING 192.0.2.0 (192.0.2.0) 50(78) bytes of data.
From 131.107.5.118: icmp_seq=1 Destination Net Unreachable
--- 192.0.2.0 ping statistics ---
1 packets transmitted, 0 received, +1 errors, 100% packet loss, time Oms
0m00.03s real 0m00.00s user 0m00.00s system
```
Aleksey Kliger (λgeek) [Thu, 9 Sep 2021 11:25:05 +0000 (07:25 -0400)]
[build] Bump XHarness version (#58830)
Pick up the changes from https://github.com/dotnet/xharness/pull/706 to fix
conflicting `-d` option that was preventing wasm test runs
Alexander Köplinger [Thu, 9 Sep 2021 10:17:38 +0000 (12:17 +0200)]
Use non-deprecated Android Helix queue (#58809)
Ubuntu.1804.Amd64.Android.Open was redirected to Ubuntu.1804.Amd64.Android.29.Open, use that in the .yml
Fixes https://github.com/dotnet/core-eng/issues/13179
Pavel Savara [Thu, 9 Sep 2021 09:30:21 +0000 (11:30 +0200)]
[wasm] WebSocket perf test (#58730)
- benchmark for WebSocket buffering
- async before and after batch setup
Jan Vorlicek [Thu, 9 Sep 2021 08:54:27 +0000 (10:54 +0200)]
Fix x86 EH for UnmanagedCallersOnly methods (#58796)
* Fix x86 EH for UnmanagedCallersOnly methods
There is a bug in the exception handling on x86 when exception is
propagated from a method marked with UnmanagedCallersOnly attribute to
an immediate caller that's also managed (and calls the method via a
native delegate). In this case, there is no native frame in between and
the stack walker accidentally skips the InlinedCallFrame processing
during first pass of exception handling. The InlinedCallFrame is expected
to be processed before the related PInvoke IL stub and it doesn't happen
in this case, as a native frame is required to make the stack frame iterator
move to the explicit InlinedCallFrame. The fact that it is not processed
results in ignoring the upper limit on the stack walk and walking the stack
further than expected.
This change fixes it by detecting the direct transition from
UnmanagedCallersOnly to managed caller and forces the stack frame
iterator to process the InlinedCallFrame.
* Reflect PR feedback, use GCInfo instead of parsing the attribute
Jakob Botsch Nielsen [Thu, 9 Sep 2021 08:19:59 +0000 (10:19 +0200)]
Fix reporting of live var ranges after callf+always pairs (#58815)
We were basing the decision on whether a home update was needed on the
live out variables of the previous block, but that block is skipped for
callf+finally pairs. Change the logic to use the callf block instead.
Fix #57752
Fan Yang [Thu, 9 Sep 2021 07:44:37 +0000 (03:44 -0400)]
Create a separate RuntimeConfig test for Android and add incremental build (#58835)
* Create a separate RuntimeConfig test for Android
* Add incremental build
Johan Lorensson [Thu, 9 Sep 2021 05:55:39 +0000 (07:55 +0200)]
Always write sample events in EventPipe based on sample frequency. (#58720)
* Always write sample events in EventPipe based on sample frequency.
If no managed frames (including helper frames) are located on stack,
sample was dropped and not emitted into EventPipe. This cause issues
in tooling that try to do thread time calculations based on sample,
especially in cases where embedded threads returned to native
code during several samples before calling back into runtime. In such
scenarios the last sampled event would be prolonged, giving false
information that that stackframe lasted much longer than it really did.
Always writing samples into EventPipe will also visualize time an attached
thread spend outside of runtime, not running managed code.
Bruce Forstall [Thu, 9 Sep 2021 04:50:09 +0000 (21:50 -0700)]
Remove dead code (#58475)
Remove unused `isFloat` argument to `getRegName`, as well
as some additional unused reg name functions (probably left over
from the old x86 back-end).
Bruce Forstall [Thu, 9 Sep 2021 04:48:35 +0000 (21:48 -0700)]
Fix zero initialization use of "initReg" (#58410)
If the only local is an enregistered must-init struct,
we were setting `initReg` to its register (in this case, `xmm0`).
However, `initReg` is expected to be an integer register. In the
test case, with GS cookie stress, the GS cookie code asserted
that `initReg` was an integer register, but it wasn't.
The fix is the change the condition to use the actual register
assigned to the variable (in this case, `xmm0`), not the variable
type (here, `TYP_STRUCT`).
No spmi asm diffs.
Fixes #57911
Bruce Forstall [Thu, 9 Sep 2021 04:36:26 +0000 (21:36 -0700)]
Fix incorrect SIMD temp allocation for Vector256 with AVX2 disabled (#58820)
* Fix incorrect SIMD temp allocation for Vector256 with AVX2 disabled
The NI_Vector256_GetElement intrinsic, in some situations, requires
a stack temporary. With AVX2 disabled, this temporary was getting
allocated as a TYP_SIMD16 instead of a TYP_SIMD32, leading to overwriting
the local variable.
Add a type argument to the temp variable allocation, and allocate the
temp as the largest sized type required by any use.
Fixes #58295
* Code review change: improve arm64 SIMD temp creation type
Tomas Weinfurt [Thu, 9 Sep 2021 02:47:48 +0000 (19:47 -0700)]
add W11 test queue (#58570)
Juan Hoyos [Thu, 9 Sep 2021 01:35:00 +0000 (18:35 -0700)]
Deallocate resources for DacDbiArrayList with a matching deallocator (#58791)
Deleted InfoStoreForDbiNew as there were no users.
Added DeleteDbiMemory to deal with destruction of items and proper usage of the corresponding allocator. However, using this custom new here across dll boundaries is risky as the T type will get its destructor called then the array list is destructed. The old implementation that used the CLR allocators didn't call the destructors on the inner elements (we had a potential leak, in practice it wasn't very noticeable - most objects are never deleted). After #55945, the standard array delete expression - as well as this change - call the destructor on every object. Currently, the instantiations of this type are all devoid of special destructors and are largely blittable structs, so this remains working as it was:
- ICorDebugInfo::NativeVarInfo
- GUID
- FieldData
- DebuggerIPCE_TypeArgData
- DebuggerIPCE_ExpandedTypeData
- DebuggerIPCE_BasicTypeData
- DebuggerILToNativeMap
- DacExceptionCallStackData
- CordbType *
- CORDB_ADDRESS
- COR_SEGMENT
- COR_MEMORY_RA
Prashanth Govindarajan [Wed, 8 Sep 2021 21:43:42 +0000 (14:43 -0700)]
Add explicit APIs to Double/Single/Half/TimeOnly (#58774)
* Add explicit APIs to Double/Single/Half/TimeOnly
* sq
* Fix get accessor in ref
Viktor Hofer [Wed, 8 Sep 2021 20:04:23 +0000 (22:04 +0200)]
Upgrade to net7.0 and remove target frameworks (#58011)
* Remove EOL tfms and upgrade to net7.0
* Make linker tests net7 aware
Make installer tests run on net7.0
Don't attempt to use live apphost
Fix payloads
Regenerate test files
Fix package testing
Theodore Tsirpanis [Wed, 8 Sep 2021 18:49:13 +0000 (21:49 +0300)]
Fix Windows 8 detection in Pbkdf2 (#58736)
* Fix Windows 8 detection.
Windows 8's actual version is 6.2, not 8. The test would succeed only on Windows 10+.
* Explain that Windows 8's version is 6.2.
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Vladimir Sadov [Wed, 8 Sep 2021 18:16:36 +0000 (11:16 -0700)]
More cleanups in Assembly/Loader/Binder area (#58462)
- [x] fold the native `AssemblyLoadContext` into its base `AssemblyBinder`
Now `DefaultAssemblyBinder` and `CustomAssemblyBinder` derive directly from `AssemblyBinder`
- [x] rename: NativeAssemblyLoadContext -> NativeAssemblyBinder
- [x] misc. renames:
TPABinderContext -> DefaultBinder, FallbackLoadContextBinder -> FallbackBinder, etc ...
- [x] remove `CoreBindResult` and everything under `src/coreclr/vm/coreclr` folder
The type is basically a tuple of `BINDER_SPACE::Assembly` and `HRESULT` and `HRESULT` is used in a single place right after it is set. The rest is COM support, ref-counting, holder, init/reset/delete, and other plumbing. We can just use `Assembly` directly.
Eric StJohn [Wed, 8 Sep 2021 17:22:29 +0000 (10:22 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20210907.3 (#58808)
Theodore Tsirpanis [Wed, 8 Sep 2021 14:42:56 +0000 (17:42 +0300)]
Use BitOperations.Log2 in SortedSet. (#58793)
Eric StJohn [Wed, 8 Sep 2021 14:15:32 +0000 (07:15 -0700)]
Revert "[main] Update dependencies from 9 repositories (#58751)" (#58804)
This reverts commit
1115c43390fdaa232d082114be1bb4eb79387a71.
Filip Toth [Wed, 8 Sep 2021 14:08:58 +0000 (16:08 +0200)]
Add documentation to System.Net (#57855)
Co-authored-by: ManickaP <mapichov@microsoft.com>
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
dotnet-maestro[bot] [Wed, 8 Sep 2021 13:39:28 +0000 (06:39 -0700)]
[main] Update dependencies from 9 repositories (#58751)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20210906.2
optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.21455.2 -> To Version 1.0.0-prerelease.21456.2
* Update dependencies from https://github.com/dotnet/arcade build
20210906.1
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 7.0.0-beta.21453.2 -> To Version 7.0.0-beta.21456.1
* Update dependencies from https://github.com/dotnet/icu build
20210906.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 7.0.0-alpha.1.21430.1 -> To Version 7.0.0-alpha.1.21456.1
* Update dependencies from https://github.com/dotnet/xharness build
20210906.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.21451.1 -> To Version 1.0.0-prerelease.21456.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20210906.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.21454.1 -> To Version 1.0.2-alpha.0.21456.1
* Update dependencies from https://github.com/dotnet/llvm-project build
20210906.1
runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 11.1.0-alpha.1.21430.1 -> To Version 11.1.0-alpha.1.21456.1
* Update dependencies from https://github.com/dotnet/arcade build
20210907.3
* Update dependencies from https://github.com/dotnet/arcade build
20210906.1
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 7.0.0-beta.21453.2 -> To Version 7.0.0-beta.21456.1
* Update dependencies from https://github.com/dotnet/xharness build
20210907.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.21451.1 -> To Version 1.0.0-prerelease.21457.1
* Update dependencies from https://github.com/dotnet/runtime-assets build
20210907.4
System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
From Version 7.0.0-beta.21430.2 -> To Version 7.0.0-beta.21457.4
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20210907.2
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.21452.7 -> To Version 7.0.0-preview1.21457.2
* Update dependencies from https://github.com/dotnet/sdk build
20210908.18
Microsoft.DotNet.Compatibility
From Version 1.0.0-rc.1.21455.4 -> To Version 1.0.0-rc.1.21458.18
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Alexander Nikolaev [Wed, 8 Sep 2021 12:36:04 +0000 (14:36 +0200)]
Send RST_STREAM instead EOF when sending request body is cancelled (#58548)
Fixes #58498
Alexander Köplinger [Wed, 8 Sep 2021 07:32:26 +0000 (09:32 +0200)]
Change namespace of embedded Cecil in ILStrip task (#58764)
We hit a case where the ILStrip task assembly is IL-merged with a few other task assemblies on the Xamarin side which causes a clash because of trying to merge different Mono.Cecil versions.
Rename the Mono.Cecil used here to avoid that clash. Brings in https://github.com/dotnet/runtime-assets/pull/169
Adeel Mujahid [Wed, 8 Sep 2021 06:30:59 +0000 (09:30 +0300)]
Update both TPN files with missing notices (#57300)
Bruce Forstall [Wed, 8 Sep 2021 04:52:43 +0000 (21:52 -0700)]
Fix JitDump crash (#58778)
The `idFlags` field was uninitialized, so garbage could be
incorrectly considered a handle flag. I was seeing crashes
generating JitDump on Linux/Mac.
Also, `emitDispCommentForHandle` already masks with `GTF_ICON_HDL_MASK`,
so the caller doesn't need to do that.
Eric StJohn [Wed, 8 Sep 2021 04:33:00 +0000 (21:33 -0700)]
Retarget DOTNETHOME when installing x64 on ARM64 (#58669)
Elinor Fung [Tue, 7 Sep 2021 22:13:17 +0000 (15:13 -0700)]
Clean up tests under src/tests/reflection (#58673)
Jakob Botsch Nielsen [Tue, 7 Sep 2021 21:29:43 +0000 (23:29 +0200)]
Switch weights to doubles to mitigate rounding inaccuracies and use epsilon when sorting locals (#58630)
Mitigate issues where the compiler might evaluate intermediate
computations with higher precisions due to optimizations, causing
different results between x86 windows checked/release.
Fix #58063
Pent Ploompuu [Tue, 7 Sep 2021 20:40:25 +0000 (23:40 +0300)]
Fix PerfScore inconcistencies (#56812)
Elinor Fung [Tue, 7 Sep 2021 20:32:05 +0000 (13:32 -0700)]
Remove unused test libraries under classloader (#58596)
Kunal Pathak [Tue, 7 Sep 2021 20:31:38 +0000 (13:31 -0700)]
Skip allocation for ZeroInit writeThru intervals (#58677)
* Do not allocate register if ZeroInit/EHWriteThru
* Update the comments about zero-init heuristics
* jit format
Steve Harter [Tue, 7 Sep 2021 19:59:39 +0000 (14:59 -0500)]
Support duplicated type names with src gen (#58448)
Aaron Robinson [Tue, 7 Sep 2021 17:13:25 +0000 (10:13 -0700)]
Add support for variance to IDIC (#58646)
Viktor Hofer [Tue, 7 Sep 2021 15:49:37 +0000 (17:49 +0200)]
Avoid S.S.Permissions dependency in S.S.Crypto.Xml (#58731)
Avoid the S.S.Permissions dependency by referencing the
latest available System.Security.AccessControl package
which contans the Evidence types in all tfms in the
System.Security.Cryptography.Xml project.
Add suppression file for Permissions
Viktor Hofer [Tue, 7 Sep 2021 15:33:15 +0000 (17:33 +0200)]
Revert "Fix HAVE_PTHREAD_CONDATTR_SETCLOCK detection on Android (#58701)" (#58755)
This reverts commit
a6d9e63dc472ac57edea2a2c407c75f9ec33066f.
Stephen Toub [Tue, 7 Sep 2021 14:56:20 +0000 (10:56 -0400)]
Add threading test for Regex (#58595)
Tom Deseyn [Tue, 7 Sep 2021 14:06:32 +0000 (16:06 +0200)]
PosixSignalRegistrationTests.Unix: validate signal pal mapping (#58711)
* PosixSignalRegistrationTests.Unix: validate signal pal mapping
* Use InvariantCulture for pid ToString
* Invoke kill through shell.
* Remove InvariantCulture
Fan Yang [Tue, 7 Sep 2021 13:16:18 +0000 (09:16 -0400)]
Disable failing test (#58634)
Vlad Brezae [Tue, 7 Sep 2021 12:57:39 +0000 (15:57 +0300)]
[mono] Disable tests relying on precise GC (#58719)
From GC/Scenarios and GC/Features/Finalizer
CW2 [Tue, 7 Sep 2021 12:16:47 +0000 (14:16 +0200)]
Fixed paths above repo root level (#55628) (#56239)
`__RootBinDir` and `DotNetCli` paths based on `__RepoRootDir` as suggested in https://github.com/dotnet/runtime/issues/55628#issuecomment-
884569242, updated `REVIEW` comment to help future cleanup (if any).
Theodore Tsirpanis [Tue, 7 Sep 2021 10:33:08 +0000 (13:33 +0300)]
Remove Reflection.Emit packages from the Windows Compatibility Pack on frameworks greater than .NET Standard 2.0. (#56973)
Kevin Jones [Tue, 7 Sep 2021 08:16:57 +0000 (04:16 -0400)]
Remove conditional compilation conditions that are no longer possible. (#58377)
Since the Cng and OpenSsl packages have been dead-ended, some of the conditional
compilation is no longer applicable.
dotnet-maestro[bot] [Tue, 7 Sep 2021 07:35:34 +0000 (09:35 +0200)]
[main] Update dependencies from dotnet/runtime dnceng/internal/dotnet-optimization dotnet/arcade dotnet/hotreload-utils dotnet/sdk (#58681)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20210903.6
optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.21452.5 -> To Version 1.0.0-prerelease.21453.6
* Update dependencies from https://github.com/dotnet/arcade build
20210903.2
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 7.0.0-beta.21452.4 -> To Version 7.0.0-beta.21453.2
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20210903.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.21452.1 -> To Version 1.0.2-alpha.0.21453.1
* Update dependencies from https://github.com/dotnet/sdk build
20210903.86
Microsoft.DotNet.Compatibility
From Version 1.0.0-rc.1.21453.1 -> To Version 1.0.0-rc.1.21453.86
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20210904.6
optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.21452.5 -> To Version 1.0.0-prerelease.21454.6
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20210904.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.21452.1 -> To Version 1.0.2-alpha.0.21454.1
* Update dependencies from https://github.com/dotnet/runtime build
20210906.1
Microsoft.NETCore.ILAsm , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.App.Runtime.win-x64 , runtime.native.System.IO.Ports , Microsoft.NET.Sdk.IL , System.Text.Json , System.Runtime.CompilerServices.Unsafe
From Version 7.0.0-alpha.1.21430.3 -> To Version 7.0.0-alpha.1.21456.1
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20210905.2
optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.21452.5 -> To Version 1.0.0-prerelease.21455.2
* Update dependencies from https://github.com/dotnet/sdk build
20210905.4
Microsoft.DotNet.Compatibility
From Version 1.0.0-rc.1.21453.1 -> To Version 1.0.0-rc.1.21455.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Filip Navara [Tue, 7 Sep 2021 07:07:35 +0000 (09:07 +0200)]
Add test for implicit time zone conversion for mobile platforms (#58717)
Michal Strehovský [Mon, 6 Sep 2021 23:53:35 +0000 (08:53 +0900)]
Fix HAVE_PTHREAD_CONDATTR_SETCLOCK detection on Android (#58701)
Android puts pthread stuff into libc. Because this wasn't detected, we are using some iOS fallbacks in System.Native. I'm propagating how pthreads are detected in the CoreCLR PAL (that was fixed up for Android in the CoreCLR PAL a couple years ago).
Failure to properly detect it here was causing build breaks in CoreCLR on Android (that's how I found this).
Egor Bogatov [Mon, 6 Sep 2021 12:14:11 +0000 (15:14 +0300)]
Allow instrumentation for methods with explicit tail calls (#58632)
Eirik Tsarpalis [Mon, 6 Sep 2021 11:57:45 +0000 (12:57 +0100)]
fix ValueTuple source generation support (#58644)
Egor Bogatov [Mon, 6 Sep 2021 11:44:40 +0000 (14:44 +0300)]
Remove redundant zeroing for small stackallocs with SkipLocalsInit (#55004)
Egor Bogatov [Mon, 6 Sep 2021 11:44:04 +0000 (14:44 +0300)]
JIT: Skip covariant store checks when jit sees exact Array's type (#58696)
Mitchell Hwang [Mon, 6 Sep 2021 09:06:38 +0000 (05:06 -0400)]
[Libraries] Fix TimeZoneInfoTests IsIanaIdTest for iOS/MacCatalyst/tvOS (#58562)
* [Libraries] Fix TimeZoneInfoTests IsIanaIdTest for iOS/MacCatalyst/tvOS
* [Libraries] Fix IsIanaIdTest to assert throw for iOS/MacCatalyst/tvOS
* Readd new line
* [Mobile][Libraries] System.Runtime.Tests TimeZoneInfoTests remove mobile from iana conversion support
* [libraries] System.Runtime.Tests revert IsIanaIdTest iOS tvOS special casing
* Remove active issue added in recently merged PR
Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
Mitchell Hwang [Mon, 6 Sep 2021 09:04:22 +0000 (05:04 -0400)]
[libraries] Restrict ILLink Suppression xml to mobile platforms (#58519)
Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
Krzysztof Wicher [Mon, 6 Sep 2021 08:04:52 +0000 (10:04 +0200)]
Fix ConfigurationManager when BaseDirectory starts with \\?" (#58627)
Johan Lorensson [Mon, 6 Sep 2021 06:33:23 +0000 (08:33 +0200)]
Make sure EventPipe streaming thread won't write session->streaming_thread after session free. (#58615)
In case where ep_disable is called by a different thread (close IPC command) there was a race between streaming threads setting session->streaming_thread to NULL and IPC command triggering a call to disable_holding_lock and freeing session.
Resetting the streaming_thread in streaming thread must happens before it signals its shutdown event to prevent the race.
Andy Ayers [Sun, 5 Sep 2021 17:27:21 +0000 (10:27 -0700)]
JIT: relax assert in lvaSetDoNotEnregister (#58597)
If user code reinterprets a non-struct local as a struct (say via `Unsafe.As`)
at a call site, then we may see `DNER_IsStructArg` ussed for that local. Remove
an assert and update the descriptive text.
Fixes #58515.
James Truher [MSFT] [Sat, 4 Sep 2021 13:02:20 +0000 (06:02 -0700)]
The signal enum in the native library should match the managed code. (#58658)
Kunal Pathak [Sat, 4 Sep 2021 04:18:05 +0000 (21:18 -0700)]
Do Contain analysis after inserting node in block range (#58605)
Tomas Weinfurt [Sat, 4 Sep 2021 02:23:23 +0000 (19:23 -0700)]
add TLS 1.3 support to WinHttp (#58590)
* add TLS 1.3 support to WinHttp
* remove extra line
* fix comment
* add check if WINHTTP_FLAG_SECURE_PROTOCOL_TLS1_3 is supported
Tarek Mahmoud Sayed [Sat, 4 Sep 2021 00:01:50 +0000 (17:01 -0700)]
Fix Native Digit Reading (#58598)
dotnet-maestro[bot] [Sat, 4 Sep 2021 00:00:19 +0000 (17:00 -0700)]
[main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/arcade dotnet/roslyn-analyzers dotnet/hotreload-utils dotnet/sdk (#58621)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20210902.5
optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.21451.4 -> To Version 1.0.0-prerelease.21452.5
* Update dependencies from https://github.com/dotnet/arcade build
20210902.4
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21451.3 -> To Version 7.0.0-beta.21452.4
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20210902.7
Microsoft.CodeAnalysis.NetAnalyzers
From Version 6.0.0-rc1.21413.4 -> To Version 7.0.0-preview1.21452.7
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20210902.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.21451.1 -> To Version 1.0.2-alpha.0.21452.1
* Update dependencies from https://github.com/dotnet/sdk build
20210903.1
Microsoft.DotNet.Compatibility
From Version 1.0.0-rc.1.21426.26 -> To Version 1.0.0-rc.1.21453.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Viktor Hofer [Fri, 3 Sep 2021 22:16:15 +0000 (00:16 +0200)]
Update solution files for correct ordering of elements (#58655)
With the newest udpate of slngen, the order of elements (configuration, folders, etc.) is in sync with how Visual Studio arranges them.
Also the order is now deterministic.
Based on that, updating all solution files to have the correct ordering of elements. This change also unblocks adding CI protection for
making sure that solution files are up-to-date in regards to their dependencies as slngen is now generating the files deterministically.
Tomas Weinfurt [Fri, 3 Sep 2021 22:03:02 +0000 (15:03 -0700)]
Tls resume PoC (server stateless) (#57079)
* tls resume
* fix alpn
* fix build with old openssl
* remove handling of empty ALPN
* more OpenSSL1.0 fixes
* fix android
* feedback from review
* dispose innerContext if we don't cache
* disable TLS resume with CipherSuitePolicy
* partial feedback from review
* fix build
* feedback from review
* refactor protocol selection to helper function
Steve Pfister [Fri, 3 Sep 2021 22:01:58 +0000 (18:01 -0400)]
Run minimal set of iOS / tvOS device tests (#58444)
With each test suite app taking up ~100MB in space, it's not practical to build the tests on the build machine. Only enable a few now as an interim step.
Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Steve Harter [Fri, 3 Sep 2021 19:48:54 +0000 (14:48 -0500)]
Support JsonConverterFactory with src-gen (#58398)
github-actions[bot] [Fri, 3 Sep 2021 18:11:03 +0000 (11:11 -0700)]
[main] Conditionally pack symbols based on keepNativeSymbols (#58577)
* Conditionally pack symbols based on keepNativeSymbols
* Fix casing issue
* Add clarifing comment
Co-authored-by: Michael Simons <msimons@microsoft.com>
Mitchell Hwang [Fri, 3 Sep 2021 17:22:20 +0000 (13:22 -0400)]
[libraries] Skip test suites crashing on CI for iOS/tvOS/MacCatalyst (#57208)
* [MacCatalyst][Libraries] Reenable MacCatalyst x64 crashing test suites
* [MacCatalyst][Libraries] Reenable MacCatalyst arm64 crashing test suites
* Temporarily enable MacCatalyst arm64 lane
* Readd consistently crashing suites to iOS tvOS MacCatalyst skips
* Address crashes and PNSE failures on iOS MacCatalyst
* Temporarily bump timeout for tvOS
* fix typo
* Skip more crashed suites
* Undo temporary changes and Add ActiveIssue
* Skip more crashing suites
* Skip iOS.Simulator.Aot.Test flake on MacCatalyst CI
* Add a couple crashing suites
* Remove sample skip in tests.proj as it doesnt do anything
* Add another flakey crashed test for MacCatalyst
* Skip System.Xml.Xsl.XslCompiledTransformApi on MacCatalyst
* Temporarily remove test suite skips and enable arm64 lanes and bump lane timeout to evaluate crashes
* Reenable a test that was fixed
* Update Microsoft.DotNet.Helix.Sdk
Fixes an issue with mismatched dotnet SDK versions we're hitting in runtime-staging on mobile platforms (see https://github.com/dotnet/arcade/pull/7788)
* [iOS] Skip ValidAccessLevelCombinations ReadWriteExecute for iOSSimulator arm64
* Skip failing test suites
* Extend trampoline bump to iOS tvOS MacCatalyst
* Fixup typo
* Fix MonoAOTCompiler typo
* Bump trampolines for osxlike lanes
* Add active issues for failing tests
* Remove ActiveIssue that was fixed
* Add IsIanaIdTest skip
* Bump trampolines even higher
* Address feedback
* Fix typo
* Undo runtime-staging temporary changes and cleanup test skips
* Fix path typo
* Skip iOS sample
* Add new activeIssue and skip flakey Android test crash
* Skip functional tests crashing with exit code 0
Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Andy Ayers [Fri, 3 Sep 2021 15:53:19 +0000 (08:53 -0700)]
JIT: adjust assert in optUnmarkCSE (#58600)
Modify the assert we use to check that someone forgot to set `optCSEweight`,
so that it works if we have blocks with max weight.
Fixes #58371.
Alexander Köplinger [Fri, 3 Sep 2021 14:07:55 +0000 (16:07 +0200)]
Fix Android device issues related to filesystem/IO (#58586)
- Use F_SETLK64 for fcntl to fix an issue where 32bit arm Android apps would get the wrong flag
- Add numerical magic numbers for missing file systems to Interop.UnixFileSystemTypes so they are correctly recognized
- Make ping test a bit more forgiving if the process returns a few milliseconds _before_ the timeout
Aleksey Kliger (λgeek) [Fri, 3 Sep 2021 13:31:25 +0000 (09:31 -0400)]
[mini] Don't add unbox tramopline on generic DIM calls (#58521)
* [mini] Don't add unbox tramopline on generic DIM calls
Don't unbox a valuetype `this` if the generic method is a DIM
Fixes https://github.com/dotnet/runtime/issues/58394
* Add regression test
Adam Sitnik [Fri, 3 Sep 2021 11:03:34 +0000 (13:03 +0200)]
run System.IO.Tests .NET 5 compat tests on every OS (#58611)
Ulrich Weigand [Fri, 3 Sep 2021 10:39:06 +0000 (12:39 +0200)]
Fix source-build on the s390x platform (#58553)
* Do not disable Mono in source-build if it is the primary runtime
This fixes a build failure when building runtime via the source-build method on s390x: with source-build, the Mono runtime is currently not supported -- but this doesn't make sense on s390x where Mono is the *primary* (only) supported runtime.
Maxim Lipnin [Fri, 3 Sep 2021 10:34:10 +0000 (13:34 +0300)]
Remove unnecessary unsafe keyword (#58606)
A small cleanup after https://github.com/dotnet/runtime/pull/56713.
Anton Firszov [Fri, 3 Sep 2021 10:24:28 +0000 (12:24 +0200)]
Increase some of the DnsEndPointTest timeouts (#58129)
Long story short:
I have spent several hours trying to get a test run on SLES in order to repro #57929, no success so far, and it may take days to make progress, since I'm unfamiliar with SLES.
I recommend to bump the timeout values for now, and see if it helps with the issue. If not, we may invest into another round of investigation.
(hopefully) fixes #57929
dotnet-maestro[bot] [Fri, 3 Sep 2021 08:48:46 +0000 (10:48 +0200)]
[main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/arcade dotnet/xharness dotnet/hotreload-utils (#58551)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20210901.4
optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.21431.4 -> To Version 1.0.0-prerelease.21451.4
* Update dependencies from https://github.com/dotnet/arcade build
20210901.3
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21430.1 -> To Version 6.0.0-beta.21451.3
* Update dependencies from https://github.com/dotnet/xharness build
20210901.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.21431.1 -> To Version 1.0.0-prerelease.21451.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20210901.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.21431.1 -> To Version 1.0.2-alpha.0.21451.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Mateo Torres-Ruiz [Fri, 3 Sep 2021 08:45:59 +0000 (01:45 -0700)]
Add support for build.cmd -vs corehost.sln (#58520)
* Add support for -vs corehost.sln
* Avoid variable dup
Peter Sollich [Fri, 3 Sep 2021 08:33:13 +0000 (10:33 +0200)]
Ensure proper memory ordering when background_ephemeral_sweep copies over the free list data that it found for gen 0. (#58564)
The method allocator::copy_with_no_repair is called at the end of background_ephemeral_sweep to copy over the free list data that it found for gen 0. There is no synchronization, but we are careful to copy items in a sequence that makes sure things work correctly for x86 and x64. However, on other platforms, we need a memory barrier.
This is a tentative fix for issue #57956 - it seems possible that the issue is caused by the lack of synchronization in copy_with_no_repair, but there is no proof yet.
Jakob Botsch Nielsen [Fri, 3 Sep 2021 08:30:38 +0000 (10:30 +0200)]
Fix crossgen2 calli GC hole by unifying MethodDesc/MethodSignature IsMarshallingRequired logic (#58430)
For unmanaged calli crossgen2 was not properly checking all necessary
conditions for a pinvoke being required. In particular it did not check
for managed byrefs. Unify the MethodDesc/MethodSignature logic to get
all the checks.
Fix #58259
Tomas Weinfurt [Fri, 3 Sep 2021 08:01:43 +0000 (01:01 -0700)]
fix spelling (#58593)
Kunal Pathak [Fri, 3 Sep 2021 05:16:02 +0000 (22:16 -0700)]
Undo struct promotion on "RetInd" code path (#58582)
* TOREVERT: small repro case
* Fix the undone struct promotion for return
* Display lclVar number
* Revert "TOREVERT: small repro case"
This reverts commit
9ef80ba45d52257f0b2b33404206ecda3823c92c.
* Add test case
* jit format
* Combine the condition
* Add an assert to catch the missing places
* Remove unneeded variable setting from csproj
Jeremy Koritzinsky [Fri, 3 Sep 2021 02:18:59 +0000 (19:18 -0700)]
Implement support for passing a .env file to corerun to easily set environment variables for stress testing. (#58222)
* Implement support for passing a .env file to corerun to easily set environment variables for stress testing.
* Load the parsed dotenv into the process.
* Implement support for # comments
* Clean up code
* Avoid copy
* PR feedback
* Update docs and bash/batch scripts to support the dotenv files.
* Use what clang recommends to not copy
* Apply suggestions from code review
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
SingleAccretion [Fri, 3 Sep 2021 01:10:34 +0000 (04:10 +0300)]
Import `KEEPALIVE(BOX)` as `KEEPALIVE(ADDR(TEMP))` (#54412)
* Prototype removing boxes from GC.KeepAlive
Instead, import KEEPALIVE(BOX) as a sequence of
KEEPALIVE for object fields (flattened).
* Clean things up
Move the importation to its own method.
Add debug output.
Rename a few things.
* Add a test
Basic verification of the new optimization.
* Fix formatting
* Disable the test on Mono
It relies on a precise GC.
* Add a class field scenario to the test
* Fix a test
Running diffs for win-x64, there was exactly one result,
in this test. GC.KeepAlive here is used as a generic
"make sure that there is a use for the variable
beyond an assigment" function. The new optimization
eliminates this use as the struct in question has
no GC fields. Fix the test by using an actual generic
"use me" function.
Will be broken by advanced interprocediral analysis
that is apparently not as far away as one would expect,
but will do for now.
* Use advanced DEBUG features for even nicer dumps
* Add two simple EH scenarios to the test
* Fix the test
It is possible for a GC to occur just after
the KeepAlive calls and for CheckSuccess to
wrongly conclude the objects weren't kept alive.
* Only elide copies for GT_LCL_VARs
If the source is a GT_LCL_FLD, then we would only want
too keep alive the fields it encloses (or, since TYP_STRUCT
local fields are currently not supported, nothing).
* Use the address of the whole struct for KEEPALIVE
The field-by-field approach results in the struct getting
address-exposed anyway, so there is no good reason to bloat
the IR. Just have the address escape directly.
Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Andy Ayers [Fri, 3 Sep 2021 00:53:15 +0000 (17:53 -0700)]
JIT: fix jump threading to keep track of preds instead of reanalyzing (#58579)
In #58368 we see an issue where a previously ambiguous pred becomes a true pred
once other pred flow is redirected. While this may be a missed opportunity, we
are better off just keeping with our initial assessment for now.
So during the initial pred walk, track which preds are ambiguous and true (and
by implication, false) and then use that classification during the second walk.
Fixes #58368.
Maledong [Thu, 2 Sep 2021 22:25:53 +0000 (06:25 +0800)]
docs: add missing xml document's comments (#57329)
Aaron Robinson [Thu, 2 Sep 2021 20:46:24 +0000 (13:46 -0700)]
Convert test from using XUnitBase to typical CoreCLR test pattern so (#58573)
test can be run under GCStress.
Elinor Fung [Thu, 2 Sep 2021 19:13:30 +0000 (12:13 -0700)]
Clean up tests under CoreMangLib/system/runtime/interopservices/safehandle (#58528)
* Delete redundant SafeHandle tests
* Move DangerousGetHandle and SetHandleAsInvalid tests to libraries
Remove IsClosed and SetHandle tests - covered by existing/new checks in
libraries tests.
Andy Ayers [Thu, 2 Sep 2021 18:53:09 +0000 (11:53 -0700)]
JIT: fix some issues in fgIsThrowHlpBlk (#58510)
We may see no return calls that are not the roots of their trees, so don't
assert that the last node must be a call.
Update the list of helpers we check for to reflect current practice.
Remove the unused SCK_PAUSE_EXEC.
Fixes #58372.
Elinor Fung [Thu, 2 Sep 2021 18:07:35 +0000 (11:07 -0700)]
Delete redundant AssemblyName test (#58477)
Aaron Robinson [Thu, 2 Sep 2021 18:02:47 +0000 (11:02 -0700)]
Notify Reference Tracker runtime of disconnect at the right time (#58472)
* Notify Reference Tracker runtime of disconnect at the right time
Based on misunderstanding of SyncBlock clean-up modes the indication of
when an Native Object Wrapper was being collected was being done after
the wrapper's Finalizer was run. However, this information must be conveyed
prior to wrapper finalization and synchronously during the GC.
Tarek Mahmoud Sayed [Thu, 2 Sep 2021 17:19:29 +0000 (10:19 -0700)]
Change compile time dependency of ICU API ucol_setMaxVariable to be runtime instead. (#58485)
* Change compile time dependency of ICU API ucol_setMaxVariable to be runtime instead.
* Fix Android Build Break
Steve Harter [Thu, 2 Sep 2021 16:52:49 +0000 (11:52 -0500)]
Pass a null getter\setter with [JsonIgnore] and src gen (#58405)
Eirik Tsarpalis [Thu, 2 Sep 2021 16:45:25 +0000 (17:45 +0100)]
Disable fast path serialization for types with properties using custom converters. (#58291)
Alexander Köplinger [Thu, 2 Sep 2021 16:18:44 +0000 (18:18 +0200)]
Reenable a few OperatingSystem tests on MacCatalyst (#58428)
https://github.com/dotnet/runtime/issues/56084 was fixed.
Radek Doulik [Thu, 2 Sep 2021 15:33:08 +0000 (17:33 +0200)]
[mono] win32 implementation of g_get_current_dir (#58523)
Fix https://github.com/dotnet/runtime/issues/56163
The getcwd call is returning the string encoded in system character
encoding instead of utf-8.
Use native GetCurrentDirectoryW call instead and convert to utf-8.
Maksym Koshovyi [Thu, 2 Sep 2021 14:17:30 +0000 (17:17 +0300)]
[Group 1] Enable nullable annotations for `Microsoft.Extensions.DependencyModel` (#57445)
* Annotate src
* Annotate ref
* Update ref csproj
* runtimeSignature can be null
* reader.GetString() can be null
* CodeBase is obsolete
* Update ref for HashCodeCombiner
* Annotate RuntimeAssetGroup
* Null check resolvers
* Update ReferenceAssemblyPathResolver's constructor
* DisableImplicitAssemblyReferences
* Use ProjectReference in ref
* PR feedback and fix build
* Fix unit tests -
* Don't throw for null assemblies in TryResolveAssemblyPaths
* Fix up ref source
* Fix RuntimeLibrary constructor overloads
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Maxim Lipnin [Thu, 2 Sep 2021 13:53:31 +0000 (16:53 +0300)]
Fix Console.Write on iOS (#56713)
Viktor Hofer [Thu, 2 Sep 2021 12:25:38 +0000 (14:25 +0200)]
Fix netfx assets referencing netstandard ones (#58499)
From
56894f09aaac6e635136dec68dfc174159911796.
A few projects didn't reference the .NETFramework assets in dependencies
and instead the .NETStandard ones.
Also a few assets specific a "-windows" RID even though they don't need
them. A .NETFramework "-windows" RID is only required when:
1. A netstandard2.0-windows tfm is present in the same project or
2. If a dependency is windows RID specific.
Michael Simons [Thu, 2 Sep 2021 11:53:05 +0000 (06:53 -0500)]
[Main] Don't always build source build with ci flag (#58497)