platform/upstream/freerdp.git
4 years agoRemoved invalid use of strnlen
Armin Novak [Tue, 5 Nov 2019 10:30:26 +0000 (11:30 +0100)]
Removed invalid use of strnlen

5 years agoFixed warnings from TestEnvironmentGetEnvironmentStrings
Armin Novak [Tue, 29 Oct 2019 11:57:19 +0000 (12:57 +0100)]
Fixed warnings from TestEnvironmentGetEnvironmentStrings

5 years agoCleaned up TestCryptoHash
Armin Novak [Tue, 29 Oct 2019 11:23:06 +0000 (12:23 +0100)]
Cleaned up TestCryptoHash

5 years agoRemoved strlen from GetComputerNameExA
Armin Novak [Tue, 29 Oct 2019 10:33:27 +0000 (11:33 +0100)]
Removed strlen from GetComputerNameExA

5 years agoFixed length checks for GetComputerNameA
Armin Novak [Tue, 29 Oct 2019 10:29:47 +0000 (11:29 +0100)]
Fixed length checks for GetComputerNameA

5 years agoRemoved strlen use in wlog (and speed up check)
Armin Novak [Tue, 29 Oct 2019 10:25:44 +0000 (11:25 +0100)]
Removed strlen use in wlog (and speed up check)

5 years agoFixed int/size_t use for channel add functions.
Armin Novak [Tue, 29 Oct 2019 10:12:15 +0000 (11:12 +0100)]
Fixed int/size_t use for channel add functions.

5 years agoFixed tmpnam warning.
Armin Novak [Tue, 29 Oct 2019 10:11:53 +0000 (11:11 +0100)]
Fixed tmpnam warning.

5 years agoRemoved strcpy use.
Armin Novak [Tue, 29 Oct 2019 09:23:48 +0000 (10:23 +0100)]
Removed strcpy use.

5 years agoCode cleanups (strlen, casts, size_t, ...)
Armin Novak [Tue, 29 Oct 2019 09:18:09 +0000 (10:18 +0100)]
Code cleanups (strlen, casts, size_t, ...)

5 years agoMerge pull request #5673 from akallabeth/audin_format_leak_fix
Martin Fleisz [Mon, 28 Oct 2019 14:19:30 +0000 (15:19 +0100)]
Merge pull request #5673 from akallabeth/audin_format_leak_fix

Fixed memory leak when freeing up audin formats.

5 years agoMerge pull request #5670 from akallabeth/cairo_detection_fix
Martin Fleisz [Mon, 28 Oct 2019 14:18:59 +0000 (15:18 +0100)]
Merge pull request #5670 from akallabeth/cairo_detection_fix

Fix #5669: If cairo is detected as part of other dependencies ignore it

5 years agoMerge pull request #5668 from akallabeth/xfreerdp_mon_check
Martin Fleisz [Mon, 28 Oct 2019 13:13:07 +0000 (14:13 +0100)]
Merge pull request #5668 from akallabeth/xfreerdp_mon_check

Added missing check for monitor indices

5 years agoserver: proxy: export config utils functions to be used by modules
kubistika [Sun, 27 Oct 2019 11:39:22 +0000 (13:39 +0200)]
server: proxy: export config utils functions to be used by modules

5 years agoserver: proxy: stop loading session captures config if it is disabled
kubistika [Sun, 27 Oct 2019 11:38:31 +0000 (13:38 +0200)]
server: proxy: stop loading session captures config if it is disabled

5 years agoMerge pull request #5676 from akallabeth/hotplug_leak_fix
Martin Fleisz [Mon, 28 Oct 2019 12:06:36 +0000 (13:06 +0100)]
Merge pull request #5676 from akallabeth/hotplug_leak_fix

Hotplug leak fix

5 years agoMerge pull request #5680 from akallabeth/fixes2
Martin Fleisz [Mon, 28 Oct 2019 10:54:23 +0000 (11:54 +0100)]
Merge pull request #5680 from akallabeth/fixes2

Some smaller Fixes

5 years agoMerge pull request #5684 from akallabeth/disp_static_fkt
Bernhard Miklautz [Mon, 28 Oct 2019 10:43:17 +0000 (11:43 +0100)]
Merge pull request #5684 from akallabeth/disp_static_fkt

Made disp channel internal functions static.

5 years agoMade disp channel internal functions static.
Armin Novak [Mon, 28 Oct 2019 08:31:50 +0000 (09:31 +0100)]
Made disp channel internal functions static.

5 years agoMerge pull request #5679 from akallabeth/gdi_clamp
Martin Fleisz [Mon, 28 Oct 2019 07:03:44 +0000 (08:03 +0100)]
Merge pull request #5679 from akallabeth/gdi_clamp

Fix gdi coordinate clamping.

5 years agoFix #5687: check for file extensions case insensitive.
Armin Novak [Fri, 25 Oct 2019 12:23:01 +0000 (14:23 +0200)]
Fix #5687: check for file extensions case insensitive.

5 years agowts_read_drdynvc_close_response quit message queue.
Armin Novak [Fri, 25 Oct 2019 11:20:28 +0000 (13:20 +0200)]
wts_read_drdynvc_close_response quit message queue.

5 years agoAdded MessageQueue_Dispatch argument checks
Armin Novak [Fri, 25 Oct 2019 11:19:42 +0000 (13:19 +0200)]
Added MessageQueue_Dispatch argument checks

5 years agoFix gdi coordinate clamping.
Armin Novak [Fri, 25 Oct 2019 10:57:32 +0000 (12:57 +0200)]
Fix gdi coordinate clamping.

5 years agoRemoved experimental warning from gfx
Armin Novak [Thu, 24 Oct 2019 12:44:01 +0000 (14:44 +0200)]
Removed experimental warning from gfx

5 years agodevman_load_device_service device argument can be const.
Armin Novak [Thu, 24 Oct 2019 12:34:26 +0000 (14:34 +0200)]
devman_load_device_service device argument can be const.

5 years agoserver: proxy: refactor config loader
kubistika [Thu, 24 Oct 2019 07:51:52 +0000 (10:51 +0300)]
server: proxy: refactor config loader

5 years agoserver: proxy: capture: refactor path creation
kubistika [Wed, 23 Oct 2019 09:39:58 +0000 (12:39 +0300)]
server: proxy: capture: refactor path creation

5 years agoserver: proxy: add python script to create a video from session frames
kubistika [Tue, 22 Oct 2019 13:06:28 +0000 (16:06 +0300)]
server: proxy: add python script to create a video from session frames

5 years agoserver: proxy: implement session capture feature
kubistika [Tue, 22 Oct 2019 13:06:05 +0000 (16:06 +0300)]
server: proxy: implement session capture feature

5 years agoserver: proxy: client use PIXEL_FORMAT_BGRA32 (easier to write frames to bitmap)
kubistika [Tue, 22 Oct 2019 13:01:00 +0000 (16:01 +0300)]
server: proxy: client use PIXEL_FORMAT_BGRA32 (easier to write frames to bitmap)

5 years agochannels: rdpgfx: export API to create rdpgfx client
kubistika [Tue, 22 Oct 2019 12:58:05 +0000 (15:58 +0300)]
channels: rdpgfx: export API to create rdpgfx client

5 years agowinpr: utils: image: fix const correctness
kubistika [Mon, 2 Sep 2019 13:02:55 +0000 (16:02 +0300)]
winpr: utils: image: fix const correctness

5 years agoFixed memory leak when freeing up audin formats.
Armin Novak [Thu, 24 Oct 2019 10:18:24 +0000 (12:18 +0200)]
Fixed memory leak when freeing up audin formats.

5 years agoFix #5669: If cairo is detected as part of other dependencies ignore it
Armin Novak [Wed, 23 Oct 2019 14:13:25 +0000 (16:13 +0200)]
Fix #5669: If cairo is detected as part of other dependencies ignore it

If WITH_CAIRO=OFF it was still used when the library was detected as
part of some other dependency. With this commit the dependency is
only added if WITH_CAIRO=ON

5 years agoAdded missing check for monitor indices
Armin Novak [Wed, 23 Oct 2019 13:03:39 +0000 (15:03 +0200)]
Added missing check for monitor indices

5 years agoFixes hub was not found! error
AzureusNation [Fri, 18 Oct 2019 09:44:24 +0000 (10:44 +0100)]
Fixes hub was not found! error

Again as with auto usb detection strtol needs to use base 10 and force to use base 10 else the conversion does not work correctly.

5 years agoFixes Auto USB Redirection
AzureusNation [Fri, 18 Oct 2019 09:21:58 +0000 (10:21 +0100)]
Fixes Auto USB Redirection

Base 0 does not work when converting the string to long int. This ends up not showing the correct device id and sometimes the wrong bus id. By changing it to base 10 conversion instead of base 0 this fixes the issue of auto redirect usb devices.

5 years agordp: count in/out bytes and packets
David Fort [Tue, 22 Oct 2019 21:35:18 +0000 (23:35 +0200)]
rdp: count in/out bytes and packets

5 years agoFix some static analizer warnings
asapelkin [Wed, 16 Oct 2019 16:49:24 +0000 (19:49 +0300)]
Fix some static analizer warnings

5 years agoserver: proxy: client: terminate the connection if pre connect hook fails
kubistika [Tue, 22 Oct 2019 07:38:25 +0000 (10:38 +0300)]
server: proxy: client: terminate the connection if pre connect hook fails

5 years agochannels: cliprdr: client: fix leak in cliprdr_packet_send
kubistika [Fri, 18 Oct 2019 12:02:59 +0000 (15:02 +0300)]
channels: cliprdr: client: fix leak in cliprdr_packet_send

5 years agochannels: cliprdr: improved common cliprdr api
kubistika [Thu, 17 Oct 2019 15:59:07 +0000 (18:59 +0300)]
channels: cliprdr: improved common cliprdr api

5 years agochannels: cliprdr: reformat cliprdr_common.c
kubistika [Sun, 15 Sep 2019 11:48:12 +0000 (14:48 +0300)]
channels: cliprdr: reformat cliprdr_common.c

5 years agochannels: cliprdr: get rid of duplicated server and client code
kubistika [Sun, 15 Sep 2019 10:53:56 +0000 (13:53 +0300)]
channels: cliprdr: get rid of duplicated server and client code

5 years agochannels: cliprdr: remove formatDataResp.dwFlags
kubistika [Sun, 15 Sep 2019 10:51:32 +0000 (13:51 +0300)]
channels: cliprdr: remove formatDataResp.dwFlags

According to the channel docs, this field is only used in format data
request. Therefore, there's no need to hold it in the response. cliprdr
server code was copy-pasted from client code, therefore this must be
some leftover.

5 years agoMerge pull request #5657 from akallabeth/warning_fixes2
Martin Fleisz [Thu, 17 Oct 2019 15:00:57 +0000 (17:00 +0200)]
Merge pull request #5657 from akallabeth/warning_fixes2

Warning fixes2

5 years agoMerge pull request #5648 from akallabeth/h264_dyn
Martin Fleisz [Thu, 17 Oct 2019 10:54:43 +0000 (12:54 +0200)]
Merge pull request #5648 from akallabeth/h264_dyn

H264 runtime detection

5 years agoFixed compilation warnings.
Armin Novak [Wed, 16 Oct 2019 12:54:05 +0000 (14:54 +0200)]
Fixed compilation warnings.

5 years agoFixed missing initializer
Armin Novak [Wed, 16 Oct 2019 12:53:42 +0000 (14:53 +0200)]
Fixed missing initializer

5 years agoFixed floating point calculations.
Armin Novak [Wed, 16 Oct 2019 12:53:27 +0000 (14:53 +0200)]
Fixed floating point calculations.

5 years agoMerge pull request #5646 from akallabeth/realloc_fixes
Martin Fleisz [Mon, 7 Oct 2019 08:43:11 +0000 (10:43 +0200)]
Merge pull request #5646 from akallabeth/realloc_fixes

Fixed #5645: realloc return handling

5 years agoLet shadow server detect H264 support at runtime
Armin Novak [Mon, 7 Oct 2019 07:47:03 +0000 (09:47 +0200)]
Let shadow server detect H264 support at runtime

5 years agoAllow freerdp clients to function with WITH_OPENH264_LOADING
Armin Novak [Mon, 7 Oct 2019 07:31:20 +0000 (09:31 +0200)]
Allow freerdp clients to function with WITH_OPENH264_LOADING

If no library can be loaded at runtime ignore H264 capabilities.
This allows a build with only OpenH264 support and dynamic loading
enabled to function when no openh264 library was detected.

5 years agoMerge pull request #5644 from akallabeth/nsc_cleanup
Martin Fleisz [Mon, 7 Oct 2019 07:01:26 +0000 (09:01 +0200)]
Merge pull request #5644 from akallabeth/nsc_cleanup

Cleaned up NSC API

5 years agoFixed windows shadow server startup issue.
Armin Novak [Fri, 4 Oct 2019 15:13:00 +0000 (17:13 +0200)]
Fixed windows shadow server startup issue.

5 years agoFixed leak in verify_cb.
Armin Novak [Fri, 4 Oct 2019 13:52:46 +0000 (15:52 +0200)]
Fixed leak in verify_cb.

5 years agoAdded /buildconfig command line for shadow.
Armin Novak [Fri, 4 Oct 2019 13:02:08 +0000 (15:02 +0200)]
Added /buildconfig command line for shadow.

5 years agoFixed #5645: realloc return handling
Armin Novak [Fri, 4 Oct 2019 12:49:30 +0000 (14:49 +0200)]
Fixed #5645: realloc return handling

5 years agoMerge pull request #5639 from akallabeth/error_category
Martin Fleisz [Fri, 4 Oct 2019 11:32:07 +0000 (13:32 +0200)]
Merge pull request #5639 from akallabeth/error_category

Added function to get an error category for better error handling.

5 years agoRemoved check for wrong buffer size.
Armin Novak [Fri, 4 Oct 2019 09:46:14 +0000 (11:46 +0200)]
Removed check for wrong buffer size.

5 years agoMerge pull request #5643 from akallabeth/openh264_fixes
Martin Fleisz [Fri, 4 Oct 2019 09:23:29 +0000 (11:23 +0200)]
Merge pull request #5643 from akallabeth/openh264_fixes

fixed openh264 related issues, thx to mythos from IRC

5 years agoMerge pull request #5641 from akallabeth/settings_use_after_free
Martin Fleisz [Fri, 4 Oct 2019 09:07:37 +0000 (11:07 +0200)]
Merge pull request #5641 from akallabeth/settings_use_after_free

Fixed use after free.

5 years agoCleaned up NSC API
Armin Novak [Fri, 4 Oct 2019 08:13:43 +0000 (10:13 +0200)]
Cleaned up NSC API

5 years agofixed openh264 related issues, thx to mythos from IRC
Armin Novak [Fri, 4 Oct 2019 08:23:43 +0000 (10:23 +0200)]
fixed openh264 related issues, thx to mythos from IRC

5 years agoFixed use after free.
Armin Novak [Thu, 3 Oct 2019 14:15:52 +0000 (16:15 +0200)]
Fixed use after free.

5 years agoAdded function to get an error category for better error handling.
Armin Novak [Thu, 3 Oct 2019 08:59:45 +0000 (10:59 +0200)]
Added function to get an error category for better error handling.

5 years agoMerge pull request #5634 from akallabeth/error_code_update
Martin Fleisz [Thu, 3 Oct 2019 06:45:44 +0000 (08:45 +0200)]
Merge pull request #5634 from akallabeth/error_code_update

Added missing error codes.

5 years agoMerge pull request #5636 from akallabeth/silence_cmake
Martin Fleisz [Wed, 2 Oct 2019 14:48:42 +0000 (16:48 +0200)]
Merge pull request #5636 from akallabeth/silence_cmake

Fix #5635: Silence double WITH_CUPS definition.

5 years agoMerge pull request #5633 from akallabeth/event_fd_fix
David Fort [Wed, 2 Oct 2019 14:34:34 +0000 (16:34 +0200)]
Merge pull request #5633 from akallabeth/event_fd_fix

GetEventFileDescriptor return handle internal event.

5 years agoFix #5635: Silence double WITH_CUPS definition.
Armin Novak [Wed, 2 Oct 2019 14:24:12 +0000 (16:24 +0200)]
Fix #5635: Silence double WITH_CUPS definition.

5 years agoFixed format string.
Armin Novak [Wed, 2 Oct 2019 14:01:36 +0000 (16:01 +0200)]
Fixed format string.

5 years agoAdded missing error codes.
Armin Novak [Wed, 2 Oct 2019 13:15:59 +0000 (15:15 +0200)]
Added missing error codes.

5 years agoGetEventFileDescriptor return handle internal event.
Armin Novak [Wed, 2 Oct 2019 12:58:32 +0000 (14:58 +0200)]
GetEventFileDescriptor return handle internal event.

5 years agorail: Update to latest spec version 28.0
Martin Fleisz [Wed, 2 Oct 2019 09:32:30 +0000 (11:32 +0200)]
rail: Update to latest spec version 28.0

5 years agoMerge pull request #5630 from akallabeth/fastpath_reset
Martin Fleisz [Wed, 2 Oct 2019 09:10:07 +0000 (11:10 +0200)]
Merge pull request #5630 from akallabeth/fastpath_reset

Reset fastpath on disconnect, fixes #5629

5 years agoReset fastpath on disconnect, fixes #5629
Armin Novak [Wed, 2 Oct 2019 08:21:48 +0000 (10:21 +0200)]
Reset fastpath on disconnect, fixes #5629

5 years agoMerge pull request #5628 from akallabeth/handle_fix
Martin Fleisz [Wed, 2 Oct 2019 07:18:50 +0000 (09:18 +0200)]
Merge pull request #5628 from akallabeth/handle_fix

Fix WINPR_EVENT and WINPR_TIMER structs.

5 years agoFix WINPR_EVENT and WINPR_TIMER structs.
akallabeth [Tue, 1 Oct 2019 19:03:03 +0000 (21:03 +0200)]
Fix WINPR_EVENT and WINPR_TIMER structs.

Both structs must have the same base members so that the event
handle can be extracted at the same offset.

5 years agoMerge pull request #5596 from akallabeth/wlog_cache_ptr
Martin Fleisz [Tue, 1 Oct 2019 13:57:17 +0000 (15:57 +0200)]
Merge pull request #5596 from akallabeth/wlog_cache_ptr

Speedup for WLog_* macros, cache the log pointer

5 years agocommon: Fix handling of redirectdrives setting
Martin Fleisz [Tue, 1 Oct 2019 13:38:31 +0000 (15:38 +0200)]
common: Fix handling of redirectdrives setting

5 years agordpdr: Fix error code reporting for create PDUs
Martin Fleisz [Tue, 1 Oct 2019 12:04:10 +0000 (14:04 +0200)]
rdpdr: Fix error code reporting for create PDUs

5 years agowlog: Fix uninitialized type in wLogMessage
Martin Fleisz [Tue, 1 Oct 2019 10:14:45 +0000 (12:14 +0200)]
wlog: Fix uninitialized type in wLogMessage

5 years agoMerge pull request #5623 from akallabeth/gateway_error_string
Martin Fleisz [Tue, 1 Oct 2019 09:41:01 +0000 (11:41 +0200)]
Merge pull request #5623 from akallabeth/gateway_error_string

Map gateway errors in freerdp_get_last_error_name

5 years agoMerge pull request #5616 from akallabeth/drive_prefer_absolute_path
Martin Fleisz [Tue, 1 Oct 2019 09:40:38 +0000 (11:40 +0200)]
Merge pull request #5616 from akallabeth/drive_prefer_absolute_path

Fix #5603: Prefer absolute path for /drive: syntax.

5 years agoMap gateway errors in freerdp_get_last_error_name
Armin Novak [Tue, 1 Oct 2019 07:47:26 +0000 (09:47 +0200)]
Map gateway errors in freerdp_get_last_error_name

5 years agoserver: proxy: register input and update callbacks in post connect
kubistika [Wed, 25 Sep 2019 13:10:04 +0000 (16:10 +0300)]
server: proxy: register input and update callbacks in post connect

To avoid a race in which the server received an input event before
proxy's client is initialized, we now only register input and update
callbacks after client is initialized and safe to use.

5 years agoserver: proxy: refactor pf_context_create_client_context
kubistika [Wed, 25 Sep 2019 13:09:36 +0000 (16:09 +0300)]
server: proxy: refactor pf_context_create_client_context

5 years agoserver: proxy: support auto reconnect
kubistika [Wed, 25 Sep 2019 13:09:15 +0000 (16:09 +0300)]
server: proxy: support auto reconnect

5 years agoserver: proxy: separate client and server security settings
kubistika [Wed, 18 Sep 2019 13:08:25 +0000 (16:08 +0300)]
server: proxy: separate client and server security settings

5 years agoMerge pull request #5621 from akallabeth/santize_rdp_file_strings
Martin Fleisz [Fri, 27 Sep 2019 07:28:20 +0000 (09:28 +0200)]
Merge pull request #5621 from akallabeth/santize_rdp_file_strings

Trim all RDP file string options except passwords.

5 years agoTrim all RDP file string options except passwords.
Armin Novak [Thu, 26 Sep 2019 14:58:41 +0000 (16:58 +0200)]
Trim all RDP file string options except passwords.

5 years agoFix #5603: Prefer absolute path for /drive: syntax.
Armin Novak [Tue, 24 Sep 2019 13:44:34 +0000 (15:44 +0200)]
Fix #5603: Prefer absolute path for /drive: syntax.

5 years agoMerge pull request #5614 from akallabeth/better_gateway_error
Martin Fleisz [Tue, 24 Sep 2019 14:28:17 +0000 (16:28 +0200)]
Merge pull request #5614 from akallabeth/better_gateway_error

Better gateway error reporting

5 years agoMerge pull request #5615 from akallabeth/rdp_relaxed_parse
Martin Fleisz [Tue, 24 Sep 2019 14:27:54 +0000 (16:27 +0200)]
Merge pull request #5615 from akallabeth/rdp_relaxed_parse

Added option to parse RDP files relaxed.

5 years agoAdded option to parse RDP files relaxed.
Armin Novak [Tue, 24 Sep 2019 08:01:08 +0000 (10:01 +0200)]
Added option to parse RDP files relaxed.

5 years agoFix #5612: proper return values.
Armin Novak [Tue, 24 Sep 2019 07:45:35 +0000 (09:45 +0200)]
Fix #5612: proper return values.

5 years agoSetting freerdp_last_error in gateway error response.
Armin Novak [Mon, 23 Sep 2019 09:26:55 +0000 (11:26 +0200)]
Setting freerdp_last_error in gateway error response.

5 years agoBetter log message for resetting last error state.
Armin Novak [Mon, 23 Sep 2019 09:22:45 +0000 (11:22 +0200)]
Better log message for resetting last error state.

5 years agoMerge pull request #5610 from akallabeth/centos_fix
Martin Fleisz [Mon, 23 Sep 2019 08:31:51 +0000 (10:31 +0200)]
Merge pull request #5610 from akallabeth/centos_fix

Centos fix