fix duplicate signature

fix set pixel params

update from remote

rename method

Merge remote-tracking branch 'origin/xamarin-mobile-bindings' into xamarin-mobile-bindings

add colortable setting support to c api

Revert "add support to change color table"

This reverts commit 856a21dcb8c77cb43aa6a2390315d6d5c67c8403.

add support to change color table

add support to change color table

Merge pull request #34 from Tylerflick/xamarin-mobile-bindings

Add support for getting & setting gray8 pixel values

Merge pull request #35 from google/chrome/m55

Pull from chrome/m55

Using SkSafeUnref to avoid nullrefex

A canvas constructed via constructor needs a "destructor"

add get color support to skbitmap for index8

add color table setting support to sk_bitmap

add sk_bitmap_get_pixel_colors for gray8

Merge remote-tracking branch 'upstream/xamarin-mobile-bindings' into xamarin-mobile-bindings

use built in macros for grayscale

add support for changing index8 pixel values

SkPDF: Always individually position glyphs in Windows.

Confirmed to fix BUG=chromium:659604

cherry-pick 7bb9301b161fce4cccee0cb43661b9f65d71dabb to chrome/m55

Change-Id: Ied25284e285ee51ee1a4712b7e17d752f50d88d2
Reviewed-on: https://skia-review.googlesource.com/4202
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
NOTRY=true
Reviewed-on: https://skia-review.googlesource.com/4342

Fall back on stencil clip when SW mask fails to allocate

When generating a SW clip mask, we didn't used to verify that the
pixels had been successfully allocated. This would obviously crash
when the allocation was not successful. This change checks the
allocation first, and falls back on a stencil clip when it doesn't
succeed.

TBR=bsalomon@google.com
BUG=656589
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2469753002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true

Committed: https://skia.googlesource.com/skia/+/af9321799d99d3d6f4b77ff2bcea6ce87c97e134
Review-Url: https://codereview.chromium.org/2469753002

Revert of Fall back on stencil clip when SW mask fails to allocate (patchset #1 id:1 of https://codereview.chromium.org/2469753002/ )

Reason for revert:
Build failure: src/gpu/GrClipStackClip.cpp:303:41: error: use of undeclared identifier 'renderTargetContext'

Original issue's description:
> Fall back on stencil clip when SW mask fails to allocate
>
> When generating a SW clip mask, we didn't used to verify that the
> pixels had been successfully allocated. This would obviously crash
> when the allocation was not successful. This change checks the
> allocation first, and falls back on a stencil clip when it doesn't
> succeed.
>
> TBR=bsalomon@google.com
> BUG=656589
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2469753002
> NOTREECHECKS=true
> NOTRY=true
> NOPRESUBMIT=true
>
> Committed: https://skia.googlesource.com/skia/+/af9321799d99d3d6f4b77ff2bcea6ce87c97e134

TBR=csmartdalton@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=656589

Review-Url: https://codereview.chromium.org/2466363002

Fall back on stencil clip when SW mask fails to allocate

When generating a SW clip mask, we didn't used to verify that the
pixels had been successfully allocated. This would obviously crash
when the allocation was not successful. This change checks the
allocation first, and falls back on a stencil clip when it doesn't
succeed.

TBR=bsalomon@google.com
BUG=656589
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2469753002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2469753002

Updated the SkCodec.getValidSubset to return a bool

Merge pull request #32 from mono/update-m55

Update master with v55

Merge pull request #33 from mono/revert-31-revert-29-xamarin-mobile-bindings

Revert "Revert "Add SkRegion C API""

Revert "Revert "Add SkRegion C API""

Merge pull request #31 from mono/revert-29-xamarin-mobile-bindings

Revert "Add SkRegion C API"

Revert "Add SkRegion C API"

Added missing members

Use the correct referencing.

sk_region_op_t is an enum, not a class

Make the decision about the region clip in managed code so we can re-use the method.

Merge pull request #30 from mono/xamarin-mobile-bindings

Update the new version branch

Merge pull request #29 from Tylerflick/xamarin-mobile-bindings

Add SkRegion C API

fix cast in sk_regionx

add sk_region to buildx

add SkRegion bindings to C API

Fix build

Revert "Add region support"

This reverts commit 63ad119e007dcb768fa8103a8cbd94d0610f0132.

Add region support

Added the additional arcTo members to SkPath

Removed unused enum

Merge pull request #28 from google/chrome/m55

Revert "Resubmit issue 2221103002 to fix the iOS build by declaring t…

Revert "Resubmit issue 2221103002 to fix the iOS build by declaring the flag in"

This reverts commit 38911a7cb53474575e1cd1cb545902b50ee00889.

Revert "Make global use-analytic-AA bit threadsafe."

This reverts commit 511f2d79bf6ea0ee858a3468d3aa8dcbfca58648.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2425673004
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2425673004

Merge pull request #27 from google/chrome/m55

Remove restrictive format pattern for Fontconfig matching

Added additional SkTypeface members

Add support for copying SkPaint

Added member to get current picture recorder canvas

Added SkPathMeasure to the C API

Remove restrictive format pattern for Fontconfig matching

This pattern pushes CFF fonts too far low in the list. Instead
it is enough to rely on the isValidPattern function to skip
Type 1 fonts.

Merged to m55 branch in order to unblock chromium:649468

BUG=skia:5846
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2410063002

Review-Url: https://codereview.chromium.org/2410063002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2423433002

Wrong enum type

Added SkPath::ConvertConicToQuads to the C API

Added SkPaint.getFillPath

Updated the C API with all the changes to the C++ API

Merge from google/chrome/m55

Merge pull request #26 from google/chrome/m54

[M54] Improve ColorStopOptimizer safety

Merge pull request #25 from xoofx/fix_gyp_msvs_config_bug

Fix a bug where skia binaries are built with asserts even in Release, 15Mo instead of 5Mo DLL

[M54] Improve ColorStopOptimizer safety

Could potentially access uninitialized memory.

M54 cherry-pick for http://crbug.com/647481

BUG=647481
TBR=brianosman@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345343002

Review-Url: https://codereview.chromium.org/2345343002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2405853002

Fix a bug where the SK_DEBUG=1 was set for the Release config (at least on msvc). Resulting in a DLL/LIB bloated with many asserts (15Mo instead of 5Mo), most likely also slower.

The bug is caused by the config "Release_Developer" which is getting incorrectly merged by gyp into the "Release" config.

gyp and specifically the function _GetConfigurationAndPlatform in `msvc.py` which is expecting a single _ to separate from the platform (x64)  https://chromium.googlesource.com/external/gyp/+/702ac58e477214c635d9b541932e75a95d349352/pylib/gyp/generator/msvs.py#2645

gyp projects should not use any _ in the configuration name (before the optional platform part)

fix printf warning in dumpcanvas

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3040

Change-Id: I850609e499a670cda0fd09941345fe221fbeeffb
Reviewed-on: https://skia-review.googlesource.com/3040
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints"

This reverts commit c245574ba3d0e2ade6c94b2812de3baa383bf4c4.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2396953002

TBR=

Review-Url: https://codereview.chromium.org/2396953002

tight bounds optimization

Add support for tight bounds to detect and return moveTo
followed by close or zero-length lineTo.

Also short circuit so that hard work is avoided when
the path bounds is also the tight bounds.

Avoid doing work if the bounds can be trivially computed.
Include naked moveTo coordinates in the tight bounds.

R=fmalita@chromium.org
BUG=skia:5555, skia:5553
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004

Review-Url: https://codereview.chromium.org/2394443004

Revert[7] "replace SkXfermode obj with SkBlendMode enum in paints"

This reverts commit Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8.

Reason for revert: new assert from 100K bot

Original change's description:
> Revert[6] "replace SkXfermode obj with SkBlendMode enum in paints"
>
> - perform version check in CreateProc for XfermodeImageFilter and ArithmeticImageFilter
> This reverts commit 3ed485f4249e17abb4b11f5018d03175fd1afb44.
>
> BUG=skia:
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2992
>
> Change-Id: Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8
> Reviewed-on: https://skia-review.googlesource.com/2992
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
>

TBR=reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I848e5a69c5cd67f2c14889f4f0a346652578c4ff
Reviewed-on: https://skia-review.googlesource.com/3023
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>

Revert "add cast for printf"

This reverts commit Ib9277facab87747b3cf9b71585e63067b4be9a58.

Reason for revert: reverted related CL

Original change's description:
> add cast for printf
>
> BUG=skia:
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3020
>
> Change-Id: Ib9277facab87747b3cf9b71585e63067b4be9a58
> Reviewed-on: https://skia-review.googlesource.com/3020
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
>

TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I1621d4ea42e9a9403ce78db147c62e8a458b4e00
Reviewed-on: https://skia-review.googlesource.com/3024
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>

add cast for printf

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3020

Change-Id: Ib9277facab87747b3cf9b71585e63067b4be9a58
Reviewed-on: https://skia-review.googlesource.com/3020
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

update deferred

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2994

Change-Id: I49e029d5825e84ba36331586bfcfbf0fe34f7c2c
Reviewed-on: https://skia-review.googlesource.com/2994
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>

validate using nx to match bounds

Check the path against the bounds
using Nx instead of straight scalars,

R=mtklein@google.com
BUG=skia:5541
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388903006

Review-Url: https://codereview.chromium.org/2388903006

Use calendar.timegm instead of time.mktime in recipes

Timezones are hard.

BUG=skia:5823
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392143004

Review-Url: https://codereview.chromium.org/2392143004

Revert[6] "replace SkXfermode obj with SkBlendMode enum in paints"

- perform version check in CreateProc for XfermodeImageFilter and ArithmeticImageFilter
This reverts commit 3ed485f4249e17abb4b11f5018d03175fd1afb44.

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2992

Change-Id: Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8
Reviewed-on: https://skia-review.googlesource.com/2992
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

Fix public API msg in PRESUBMIT.py

BUG=skia:5825

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2989

Change-Id: Ia074ab00ccd1500bee10a5b313636581e8265461
Reviewed-on: https://skia-review.googlesource.com/2989
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>

Make test lower-level, make const_cast more visible.

I can only think there's something funky going on with the hidden
const_cast inside SkRasterPipeline.cpp, or with the Sk4h -> Sk4f
conversion.  So make the const_cast visible and write the test
directly in halfs instead of floats.

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN-Trybot

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3003

Change-Id: I3a7e19ae165fce44f177b4968a63ec04e25c4b93
Reviewed-on: https://skia-review.googlesource.com/3003
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

Presubmit recipe: call presubmit_support.py directly

For some reason, presubmit_support.py can't find PRESUBMIT.py
unless it has a diff. Calling this script directly allows us
to specify a fake upstream to force it to find a diff and
therefore be able to find PRESUBMIT.py.

BUG=skia:5823
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2398653002

Review-Url: https://codereview.chromium.org/2398653002

Make local coords be highp in default geometry processor

This fixes some regressions on the Nexus 10 that were introduced when the device coordinate feature was removed from GrCoordTransform.

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2987

Change-Id: Ib0286b1e056d6d8f875a45beee8b0eda85dc1382
Reviewed-on: https://skia-review.googlesource.com/2987
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

update defer-canvas for lattice and regions

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2985

Change-Id: I9106841d1cc246064d0a963b0a1e9feae109589d
Reviewed-on: https://skia-review.googlesource.com/2985
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>

PRESUBMIT.py improvements

* Updated code to check for owners in reviewers for Gerrit issues instead for in the TBR= line.
* The previous TBR parsing code was not accounting for adding comments. Eg: "TBR=rmistry (Testing only)".

BUG=skia:5825

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2981

Change-Id: I910a3ae71a9f57c14f80c0b0404041cbe451a77c
Reviewed-on: https://skia-review.googlesource.com/2981
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>

Harden degenerate gradient context handling

Certain inputs produce degenerate values at context creation time only.

Detect such cases after context creation, and abort drawing by returning
a null shader context instead.

BUG=skia:5821
R=reed@google.com,brianosman@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397473003

Review-Url: https://codereview.chromium.org/2397473003

skpbench: add option for gpu timing

Adds a gpu timing option with a GL implementation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388433003

Committed: https://skia.googlesource.com/skia/+/c06720d06faab3b01eba1b8693e0ac791f06dc96
Review-Url: https://codereview.chromium.org/2388433003

webpages_playback: use new skia-skps bucket

BUG=skia:2969
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2393043003

Review-Url: https://codereview.chromium.org/2393043003

fix fuzz

This fix is slightly interesting; if the final
close of the contour degenerates into a zero-length
line, remove the previous line from the generated
contour.

TBR=reed@google.com
BUG=skia:5822

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3004

Change-Id: Id668d13ccf6aad9bc81d78588fc77437527a0b7b
Reviewed-on: https://skia-review.googlesource.com/3004
Reviewed-by: Cary Clark <caryclark@google.com>

Fixes for presubmit recipe

- Add depot_tools to PATH
- Run on a branch
- Use max verbosity

BUG=skia:5823
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394853002

Review-Url: https://codereview.chromium.org/2394853002

Fix bmp bug exposed by fuzzer

BUG=skia:5820
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391933004

Review-Url: https://codereview.chromium.org/2391933004

Add action_foreach, copy, and proper target naming.

Also properly handles dependencies across OBJECT libraries.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2939

Change-Id: I4aa48c896caf262772fe9769e742b54f6e265ab0
Reviewed-on: https://skia-review.googlesource.com/2939
Reviewed-by: Brian Salomon <bsalomon@google.com>

looks like red and blue start wrong (more unit test debugging)

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3001

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN-Trybot

Change-Id: I8d26b5484a2bf67d5d5891475640970046e470d8
Reviewed-on: https://skia-review.googlesource.com/3001
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>

initialize result in SkRasterPipelineTest... more debugging

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2982

Change-Id: I7c40766c3df61fb66f63e17a2da61219d1d95d1b
Reviewed-on: https://skia-review.googlesource.com/2982
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

Add swarm_presubmit recipe

This allows us to add a Housekeeper-PerCommit-Presubmit bot/trybot

BUG=skia:5823
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392663004

Review-Url: https://codereview.chromium.org/2392663004

remove dead code

Use code coverage and a new '-c' flag to find
and remove unneeded code.

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397593002

patch from issue 2397593002 at patchset 1 (http://crrev.com/2397593002#ps1)

Change-Id: I741a82de9191146c10457d4c0b9cb9605dff2069
Reviewed-on: https://skia-review.googlesource.com/2983
Reviewed-by: Cary Clark <caryclark@google.com>

more debugging for this test.

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2965

Change-Id: I583bcdeb199212840ff227942ab6ebbf57a481d7
Reviewed-on: https://skia-review.googlesource.com/2965
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

Mac: Remove use of deprecated font APIs

Remove use of CGContextSelectFont CGContextShowTextAtPoint APIs.
Verified that the new calls create the same pixel value for the
smoothing test as before.

Also remove workarounds for 10.6, because it is not supported anymore.

BUG=skia:5803
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2395613002

Review-Url: https://codereview.chromium.org/2395613002

Fold extra_*_flags into GN as a config.

This should make them visible to things like gn_to_cmake.py.
I'm not exactly sure what this implies about ordering and overriding.

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2938

Change-Id: I0740613993fb5bbfb8363cfa126d1f59768abf60
Reviewed-on: https://skia-review.googlesource.com/2938
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

Revert "Debug Mac test failure."

This reverts commit I0ed569b585f4962a90a0b6993acc484a74055177.

Reason for revert: Mac bots look okay now.  I am puzzled.

Original change's description:
> Debug Mac test failure.
>
> CQ_EXTRA_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN-Trybot
> TBR=
>
> BUG=skia:
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2933
>
> Change-Id: I0ed569b585f4962a90a0b6993acc484a74055177
> Reviewed-on: https://skia-review.googlesource.com/2933
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
>

TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I4feef1f58172d1cc649bc311c9e6d3c86f915617
Reviewed-on: https://skia-review.googlesource.com/2963
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

Revert[5] "replace SkXfermode obj with SkBlendMode enum in paints"

This reverts commit I0fa5c58af428f3da8565465d1219a34ef8417d9a.

Reason for revert: failing to deserialize some of the 100K

Original change's description:
> Revert[4] "replace SkXfermode obj with SkBlendMode enum in paints"
>
> This reverts commit 2cbcd12281ee807214df094964c584c78932e10b.
>
> BUG=skia:
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2924
>
> Change-Id: I0fa5c58af428f3da8565465d1219a34ef8417d9a
> Reviewed-on: https://skia-review.googlesource.com/2924
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
>

TBR=reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I1805a57eef5ebcac203da5989c8539345ecf806f
Reviewed-on: https://skia-review.googlesource.com/2962
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

Remove SK_SUPPORT_LEGACY_TEXTBLOB_BUILDER from public.bzl

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2960

Change-Id: I945782a5aaf416b630181bf65f517f89bae95d9f
Reviewed-on: https://skia-review.googlesource.com/2960
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>

Use uint64_t for PlatformFence

VkFence is 64 bit even on 32-bit platforms.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391113002

Review-Url: https://codereview.chromium.org/2391113002

Make the housekeeper upload doxygen to a newer bucket

BUG=skia:2969
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370153003
DOCS_PREVIEW= https://skia.org/?cl=2370153003

Review-Url: https://codereview.chromium.org/2370153003

Make global use-analytic-AA bit threadsafe.

I also had to cut it down to just a global atomic bool... as a field in a global singleton accessed through instance(), it's very hard to make threadsafe.

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2937

Change-Id: If80be987906dd521fbe644d1d0d577009f06d0e3
Reviewed-on: https://skia-review.googlesource.com/2937
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

Revert[4] "replace SkXfermode obj with SkBlendMode enum in paints"

This reverts commit 2cbcd12281ee807214df094964c584c78932e10b.

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2924

Change-Id: I0fa5c58af428f3da8565465d1219a34ef8417d9a
Reviewed-on: https://skia-review.googlesource.com/2924
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

disallow -4 pointer

A user's homegrown unsigned integer overflow tool
complains if a nullptr is decremented.
The conicWeight pointer likes to predecrement
before walking, but this is unnecessary if
its value is nullptr.

R=reed@google.com
BUG=skia:5415
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061833005

Review-Url: https://codereview.chromium.org/2061833005

Revert of skpbench: add option for gpu timing (patchset #7 id:120001 of https://codereview.chromium.org/2388433003/ )

Reason for revert:
many bots failing

Original issue's description:
> skpbench: add option for gpu timing
>
> Adds a gpu timing option with a GL implementation.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388433003
>
> Committed: https://skia.googlesource.com/skia/+/c06720d06faab3b01eba1b8693e0ac791f06dc96

TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2390383002

Add --test to gen_tasks.go, add presubmit check

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392083002

Review-Url: https://codereview.chromium.org/2392083002