platform/upstream/mesa.git
17 months agofreedreno: Add FD_DIRTY_QUERY
Rob Clark [Tue, 7 Feb 2023 17:07:28 +0000 (09:07 -0800)]
freedreno: Add FD_DIRTY_QUERY

Replace update_active_queries, which was really just a dirty-bit in
disguise.  This also lets us associate it with FD_DIRTY_RESOURCE so
we can skip the associated resource tracking when it isn't dirty.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21202>

17 months agofreedreno: Remove impossible NULL check
Rob Clark [Tue, 7 Feb 2023 16:48:50 +0000 (08:48 -0800)]
freedreno: Remove impossible NULL check

All gens implement query support now.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21202>

17 months agofreedreno: Move num_vertices calc to backend
Rob Clark [Sun, 5 Feb 2023 19:34:37 +0000 (11:34 -0800)]
freedreno: Move num_vertices calc to backend

Only used by a2xx and a3xx backends, so move it there.

Also make it more clear that fd6_emit::draw is only used in the
driver-params case.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21202>

17 months agofreedreno/a6xx: Move num_driver_params to program state
Rob Clark [Sun, 5 Feb 2023 19:15:14 +0000 (11:15 -0800)]
freedreno/a6xx: Move num_driver_params to program state

No need to re-calculate this at draw time.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21202>

17 months agonir: Apply a maximum stack depth to avoid stack overflows.
Bas Nieuwenhuizen [Tue, 10 Jan 2023 15:12:34 +0000 (16:12 +0100)]
nir: Apply a maximum stack depth to avoid stack overflows.

A stackless (or at least using allocated memory for stack) version
might be nice but for now this works around some games compiling
large shaders and hitting stack overflows.

CC: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21231>

17 months agodzn: Enable 16bit types when supported
Jesse Natalie [Fri, 27 Jan 2023 21:15:46 +0000 (13:15 -0800)]
dzn: Enable 16bit types when supported

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agodzn: Get options4
Jesse Natalie [Fri, 27 Jan 2023 21:15:11 +0000 (13:15 -0800)]
dzn: Get options4

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agodzn: Delete unused extensions table
Jesse Natalie [Fri, 27 Jan 2023 21:06:39 +0000 (13:06 -0800)]
dzn: Delete unused extensions table

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agodzn: Enable get_surface_capabilities2
Jesse Natalie [Fri, 27 Jan 2023 21:05:53 +0000 (13:05 -0800)]
dzn: Enable get_surface_capabilities2

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agospirv2dxil: Support 16bit types
Jesse Natalie [Mon, 30 Jan 2023 19:12:15 +0000 (11:12 -0800)]
spirv2dxil: Support 16bit types

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agospirv2dxil: Move shader model into runtime conf struct
Jesse Natalie [Wed, 1 Feb 2023 18:52:57 +0000 (10:52 -0800)]
spirv2dxil: Move shader model into runtime conf struct

We'll want to use it to control the shape of the nir that we generate

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agospirv2dxil: Lower unaligned loads and stores
Jesse Natalie [Mon, 30 Jan 2023 23:17:16 +0000 (15:17 -0800)]
spirv2dxil: Lower unaligned loads and stores

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agospirv2dxil: Set min UBO/SSBO alignments
Jesse Natalie [Wed, 1 Feb 2023 19:03:52 +0000 (11:03 -0800)]
spirv2dxil: Set min UBO/SSBO alignments

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Support lowering SSBO accesses to 16bit vectors
Jesse Natalie [Wed, 1 Feb 2023 18:58:18 +0000 (10:58 -0800)]
microsoft/compiler: Support lowering SSBO accesses to 16bit vectors

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Support raw buffer load/store intrinsics with 16bit alignment
Jesse Natalie [Wed, 1 Feb 2023 18:57:30 +0000 (10:57 -0800)]
microsoft/compiler: Support raw buffer load/store intrinsics with 16bit alignment

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Handle 48-bit stores to SSBO/shared
Jesse Natalie [Wed, 1 Feb 2023 17:06:55 +0000 (09:06 -0800)]
microsoft/compiler: Handle 48-bit stores to SSBO/shared

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Pass an alignment to constant buffer load lowering
Jesse Natalie [Wed, 1 Feb 2023 00:29:06 +0000 (16:29 -0800)]
microsoft/compiler: Pass an alignment to constant buffer load lowering

This means we can stop doing conditionals and shifts if we know the
alignment of a load for a small amount of data.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Simplify bitpacking for load/store lowering with nir_extract_bits
Jesse Natalie [Wed, 1 Feb 2023 00:26:58 +0000 (16:26 -0800)]
microsoft/compiler: Simplify bitpacking for load/store lowering with nir_extract_bits

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Pass deref modes to unaligned pass and handle push const
Jesse Natalie [Wed, 1 Feb 2023 00:40:30 +0000 (16:40 -0800)]
microsoft/compiler: Pass deref modes to unaligned pass and handle push const

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Move unaligned load/store pass from CL
Jesse Natalie [Mon, 30 Jan 2023 22:08:45 +0000 (14:08 -0800)]
microsoft/compiler: Move unaligned load/store pass from CL

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Handle undef-rounding f2f16 as rtz
Jesse Natalie [Mon, 30 Jan 2023 19:11:58 +0000 (11:11 -0800)]
microsoft/compiler: Handle undef-rounding f2f16 as rtz

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Ensure native_low_precision is set for 16-bit bitcasts/stores
Jesse Natalie [Mon, 30 Jan 2023 19:11:39 +0000 (11:11 -0800)]
microsoft/compiler: Ensure native_low_precision is set for 16-bit bitcasts/stores

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Handle frcp for float16/float64
Jesse Natalie [Mon, 30 Jan 2023 19:11:04 +0000 (11:11 -0800)]
microsoft/compiler: Handle frcp for float16/float64

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agomicrosoft/compiler: Handle struct consts in DXIL module dumper
Jesse Natalie [Mon, 30 Jan 2023 19:10:34 +0000 (11:10 -0800)]
microsoft/compiler: Handle struct consts in DXIL module dumper

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agonir_lower_fp16_casts: Allow opting out of lowering certain rounding modes
Jesse Natalie [Mon, 30 Jan 2023 19:10:03 +0000 (11:10 -0800)]
nir_lower_fp16_casts: Allow opting out of lowering certain rounding modes

Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agonir: Add alignment to load_push_constant
Jesse Natalie [Wed, 1 Feb 2023 00:20:31 +0000 (16:20 -0800)]
nir: Add alignment to load_push_constant

Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>

17 months agoci/windows: Update LLVM to 15
Jesse Natalie [Tue, 7 Feb 2023 17:21:07 +0000 (09:21 -0800)]
ci/windows: Update LLVM to 15

Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21168>

17 months agomicrosoft/clc: Set features that are used by CL tests
Jesse Natalie [Tue, 7 Feb 2023 19:17:03 +0000 (11:17 -0800)]
microsoft/clc: Set features that are used by CL tests

Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21168>

17 months agoclc: Include opencl-c-base.h with LLVM 15 (using builtins)
Jesse Natalie [Tue, 7 Feb 2023 19:16:11 +0000 (11:16 -0800)]
clc: Include opencl-c-base.h with LLVM 15 (using builtins)

Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21168>

17 months agoturnip: fix use of align() instead of util_align_npot() with tile_align_w
Jonathan Marek [Fri, 10 Feb 2023 22:08:43 +0000 (17:08 -0500)]
turnip: fix use of align() instead of util_align_npot() with tile_align_w

tile_align_w isn't always a power of two.

Fixes: aae679e22137

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21251>

17 months agorusticl/icd: Make it work in case Rustc shuffles struct around
Karol Herbst [Fri, 10 Feb 2023 16:01:37 +0000 (17:01 +0100)]
rusticl/icd: Make it work in case Rustc shuffles struct around

Nothing guarentees fields are in order or anything like that. So do proper offset math

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21242>

17 months agorusticl/util: extract offset_of macro
Karol Herbst [Fri, 10 Feb 2023 16:00:24 +0000 (17:00 +0100)]
rusticl/util: extract offset_of macro

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21242>

17 months agonir/deref: Preserve alignments in opt_remove_cast_cast()
Faith Ekstrand [Fri, 10 Feb 2023 22:21:19 +0000 (16:21 -0600)]
nir/deref: Preserve alignments in opt_remove_cast_cast()

This also removes the loop so opt_remove_cast_cast() will only optimize
cast(cast(x)) and not cast(cast(cast(x))).  However, since nir_opt_deref
walks instructions top-down, there will almost never be a tripple cast
because the parent cast will have opt_remove_cast_cast() run on it.

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21252>

17 months agoanv: Handle VkAccelerationStructureBuildRangeInfoKHR::transformOffset
Sviatoslav Peleshko [Thu, 9 Feb 2023 15:56:32 +0000 (17:56 +0200)]
anv: Handle VkAccelerationStructureBuildRangeInfoKHR::transformOffset

Previously it was not actually handled. This meant that all geometries
with the same transform buffer were using the same (first) transformation
matrix.

Fixes: f3ddfd81 ("anv: Build BVHs on the GPU with GRL")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7575
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21227>

17 months agointel/compiler/mesh: use U888X packed index format
Marcin Ślusarz [Wed, 25 Jan 2023 14:06:23 +0000 (15:06 +0100)]
intel/compiler/mesh: use U888X packed index format

Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20910>

17 months agoturnip: Disable draw states after dyn renderpass in all cases
Danylo Piliaiev [Tue, 7 Feb 2023 15:52:53 +0000 (16:52 +0100)]
turnip: Disable draw states after dyn renderpass in all cases

Draw states were not disabled after a dynamic renderpass which
spans several command buffers, the next renderpass if started in
the same command buffer wouldn't emit the full draw state,
since TU_CMD_DIRTY_DRAW_STATE was not set by previous renderpass.

The issue could be observed when corrupting all regs at cmdbuf start in:
 dEQP-VK.dynamic_rendering.primary_cmd_buff.random.seed7_geometry

Fixes: cb0f414b2aed88f48b2593dad833844be2f5f42b
("tu: Add support for suspending and resuming renderpasses")

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21148>

17 months agoturnip: Ensure that there is no renderpass rotation in binning
Danylo Piliaiev [Mon, 6 Feb 2023 19:38:41 +0000 (20:38 +0100)]
turnip: Ensure that there is no renderpass rotation in binning

It appears that A6XX_GRAS_SC_CNTL::rotation applies to the binning,
so we should ensure there is no unexpected rotations and apply with
A6XX_GRAS_SC_CNTL during the binning pass.

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21148>

17 months agofreedreno: Document A6XX_GRAS_SC_CNTL::rotation field
Danylo Piliaiev [Mon, 6 Feb 2023 19:36:48 +0000 (20:36 +0100)]
freedreno: Document A6XX_GRAS_SC_CNTL::rotation field

Likely used for VK_QCOM_render_pass_transform.

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21148>

17 months agotu: Prevent using stale value of GRAS_SC_CNTL in sysmem clear
Danylo Piliaiev [Mon, 6 Feb 2023 13:56:35 +0000 (14:56 +0100)]
tu: Prevent using stale value of GRAS_SC_CNTL in sysmem clear

cc: mesa-stable

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21148>

17 months agotu: Prevent using stale value of RB_UNKNOWN_88D0 on BLIT
Danylo Piliaiev [Fri, 3 Feb 2023 16:02:52 +0000 (17:02 +0100)]
tu: Prevent using stale value of RB_UNKNOWN_88D0 on BLIT

Fixes: def56b531c86f529bc32d1834ccb479457717db7
("tu: Support GMEM with layered rendering and multiview")

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21148>

17 months agofreedreno: use blendcoherent to set FLUSH_PER_OVERLAP
Amber [Tue, 7 Feb 2023 10:53:26 +0000 (11:53 +0100)]
freedreno: use blendcoherent to set FLUSH_PER_OVERLAP

FLUSH_PER_OVERLAP is only necessary for gmem if coherent blending is
enabled.

Signed-off-by: Amber Amber <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21161>

17 months agogallium: make BlendCoherent usable from gallium drivers
Amber [Tue, 7 Feb 2023 10:53:01 +0000 (11:53 +0100)]
gallium: make BlendCoherent usable from gallium drivers

Signed-off-by: Amber Amber <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21161>

17 months agofreedreno: use A6XX_GRAS_SC_CNTL_SINGLE_PRIM_MODE with fb readback
Amber [Mon, 6 Feb 2023 13:39:19 +0000 (14:39 +0100)]
freedreno: use A6XX_GRAS_SC_CNTL_SINGLE_PRIM_MODE with fb readback

fixes:
dEQP-GLES31.functional.blend_equation_advanced.msaa.*

Signed-off-by: Amber Amber <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21161>

17 months agozink: add newlines to some debug printfs
Mike Blumenkrantz [Fri, 10 Feb 2023 13:20:01 +0000 (08:20 -0500)]
zink: add newlines to some debug printfs

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21239>

17 months agohasvk: Tell spirv_to_nir float controls are always supported
Väinö Mäkelä [Thu, 8 Dec 2022 15:59:05 +0000 (17:59 +0200)]
hasvk: Tell spirv_to_nir float controls are always supported

This gets rid of the "Unsupported SPIR-V capability" warnings when
compiling shaders using float controls on gfx7.

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20232>

17 months agohasvk: Don't claim shaderDenormPreserveFloat32 on gfx7
Väinö Mäkelä [Thu, 8 Dec 2022 15:53:03 +0000 (17:53 +0200)]
hasvk: Don't claim shaderDenormPreserveFloat32 on gfx7

From the Haswell PRM Vol. 7, "IEEE Floating Point Mode":
     "Single precision (F, Float) denorms are flushed to sign-preserved
      zero on input and output of any floating-point mathematical
      operation."

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20232>

17 months agointel/vec4: Don't optimize multiply by 1.0 away
Väinö Mäkelä [Thu, 8 Dec 2022 15:52:04 +0000 (17:52 +0200)]
intel/vec4: Don't optimize multiply by 1.0 away

The SPIR-V compiler's implementation of tanh generates a multiply by 1.0
to flush denorms to zero.

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20232>

17 months agointel/vec4: Set the rounding mode
Väinö Mäkelä [Thu, 8 Dec 2022 15:41:32 +0000 (17:41 +0200)]
intel/vec4: Set the rounding mode

The rounding mode only needs to be set once, because 16-bit floats or
preserving denorms aren't supported for the platforms where vec4 is
used.

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20232>

17 months agopanfrost: drop no-longer-needed libglsl
Eric Engestrom [Wed, 18 Jan 2023 18:50:39 +0000 (18:50 +0000)]
panfrost: drop no-longer-needed libglsl

Fixes: 551c2aadd4d85e922aa6 ("pan/bi: Remove standalone compiler")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21240>

17 months agoradv: implement graphics shaders relocation for a RGP workaround
Samuel Pitoiset [Thu, 2 Feb 2023 15:52:15 +0000 (16:52 +0100)]
radv: implement graphics shaders relocation for a RGP workaround

RGP requires shaders to be uploaded consecutively inside the same
buffer object. Otherwise, either it makes the driver generating
huge traces (ie. in GiB) or it fails to load traces at all. Hopefully,
this will be improved soon when AMDGPU drivers will have GPL support.

To workaround this, the driver relocates graphics shaders in the same
buffer object when a pipeline is created. Then at draw time, it
overwrites SPI_SHADER_PGM_xxx registers to make sure SQTT can match
between emitted and exported shaders. It's a bit suboptimal because
graphics shaders are uploaded twice but it's the best solution I found.

This will allow to implement GPL caching without breaking capturing
shaders with RGP.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21078>

17 months agoradv: restore uploading shaders individually instead of consecutively
Samuel Pitoiset [Wed, 12 Oct 2022 12:26:39 +0000 (14:26 +0200)]
radv: restore uploading shaders individually instead of consecutively

The shaders were uploaded consecutively to fit a RGP constraint but
this was more like a workaround. This upload path doesn't work well for
graphics pipeline library and it was the main blocker for GPL caching.

This commit breaks capturing shaders with RGP if the offset between
shaders is too big. Next commit should fix it by using shaders reloc.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21078>

17 months agoaco: remove stale TODOs about v_interp opsel
Georg Lehmann [Fri, 3 Feb 2023 13:46:29 +0000 (14:46 +0100)]
aco: remove stale TODOs about v_interp opsel

These are already handled correctly according to the ISA docs.

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21096>

17 months agovulkan/wsi/wayland: fix acquire_next_image to report timeouts properly
Philipp Zabel [Wed, 8 Feb 2023 12:36:54 +0000 (13:36 +0100)]
vulkan/wsi/wayland: fix acquire_next_image to report timeouts properly

The Vulkan Specification states about possible return values from
vkAcquireNextImageKHR:

 * VK_NOT_READY is returned if timeout is zero and no image was
   available.
 * VK_TIMEOUT is returned if timeout is greater than zero and less than
   UINT64_MAX, and no image beae available within the time allowed.

That is, if info->timeout is larger than zero, the function must return
VK_TIMEOUT instead of VK_NOT_READY if no image became available before
the timeout elapsed.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21190>

17 months agoradv/ci: bump the number of runners to 3 for vkcts-navi21-valve
Samuel Pitoiset [Thu, 9 Feb 2023 11:45:18 +0000 (12:45 +0100)]
radv/ci: bump the number of runners to 3 for vkcts-navi21-valve

RADV_PERFTEST=gpl increased execution time, so let's try with a 3d
runner.

dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.basic
seems reliably fixed now for some reasons.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21214>

17 months agoradv/ci: set RADV_PERFTEST=GPL for all VKCTS jobs
Samuel Pitoiset [Wed, 8 Feb 2023 17:37:49 +0000 (18:37 +0100)]
radv/ci: set RADV_PERFTEST=GPL for all VKCTS jobs

The Vulkan CTS version in Mesa CI is so old that a bunch of tests
are broken, but it's expected.

This runs +283939 tests and the overall VKCTS execution time increased
from ~23 minutes to ~26 minutes (+~13%) on my Threadripper 1950X.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21214>

17 months agonir: shrink phi nodes in nir_opt_shrink_vectors
Pavel Ondračka [Tue, 31 Jan 2023 12:20:53 +0000 (13:20 +0100)]
nir: shrink phi nodes in nir_opt_shrink_vectors

While this change helps with few shaders, the main benefit is
that it allows to unroll loops comming from nine+ttn on vec4
backends. D3D9 REP ... ENDREP type loops are unrolled now already,
LOOP ... ENDLOOP need some nine changes that will come later.

r300 RV530 shader-db:
total instructions in shared programs: 132481 -> 132344 (-0.10%)
instructions in affected programs: 3532 -> 3395 (-3.88%)
helped: 13
HURT: 0

total temps in shared programs: 16961 -> 16957 (-0.02%)
temps in affected programs: 88 -> 84 (-4.55%)
helped: 4
HURT: 0

Reviewed-by: Emma Anholt <emma@anholt.net>
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Partial fix for: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8102
Partial fix for: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7222

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21038>

17 months agodocs: stop reporting RADV_PERFTEST=gpl as experimental/suboptimal
Samuel Pitoiset [Wed, 8 Feb 2023 14:47:55 +0000 (15:47 +0100)]
docs: stop reporting RADV_PERFTEST=gpl as experimental/suboptimal

The graphics pipeline library implementation in RADV has been
improved considerably lately.

There is still a bit of work for caching individual libraries
and optimized (LTO) pipelines but I think overall it seems good
enough to stop reporting it as experimental and suboptimal.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21213>

17 months agovulkan: Use static_assert for check HWVULKAN_DISPATCH_MAGIC == ICD_LOADER_MAGIC
Yonggang Luo [Thu, 3 Nov 2022 15:48:31 +0000 (23:48 +0800)]
vulkan: Use static_assert for check HWVULKAN_DISPATCH_MAGIC == ICD_LOADER_MAGIC

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21210>

17 months agofreedreno: avoid conditional ib in fd6_emit_tile
Chia-I Wu [Wed, 8 Feb 2023 23:14:55 +0000 (15:14 -0800)]
freedreno: avoid conditional ib in fd6_emit_tile

CP_REG_TEST (or any command that reads registers) is slow on a618
(gen1).  Since SQE can early return, we don't necessarily need
emit_conditional_ib in fd6_emit_tile.

We still CP_REG_TEST twice for load and store when there is no clear.
Not sure if we can simply drop emit_conditional_ib instead?

glmark2 score goes from 943 to 1067.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21208>

17 months agomesa/st: fix possible crash related to arb invalid memory access
Patrick Lerda [Wed, 8 Feb 2023 14:28:08 +0000 (15:28 +0100)]
mesa/st: fix possible crash related to arb invalid memory access

This invalid memory access is a consequence of wrong assumptions,
for instance:
"prog->sh.data is NULL if it's ARB_fragment_program"

This issue is triggered with piglit/fp-formats -auto -fbo:
==9747==ERROR: AddressSanitizer: heap-use-after-free on address 0x007f7c812d90 at pc 0x007f833c09f8 bp 0x007fd7eca750 sp 0x007fd7eca768
READ of size 4 at 0x007f7c812d90 thread T0
    #0 0x7f833c09f4 in st_get_sampler_views ../src/mesa/state_tracker/st_atom_texture.c:109
    #1 0x7f833c0b48 in update_textures ../src/mesa/state_tracker/st_atom_texture.c:266
    #2 0x7f82b2d120 in st_validate_state ../src/mesa/state_tracker/st_util.h:128
    #3 0x7f82b2d120 in prepare_draw ../src/mesa/state_tracker/st_draw.c:88
    #4 0x7f82b2de64 in st_draw_gallium ../src/mesa/state_tracker/st_draw.c:141
    #5 0x7f83105940 in _mesa_draw_arrays ../src/mesa/main/draw.c:1202
    #6 0x7f8d5fa5cc in piglit_draw_rect_from_arrays piglit/tests/util/piglit-util-gl.c:711
    #7 0x7f8d5fac34 in piglit_draw_rect_custom piglit/tests/util/piglit-util-gl.c:833
    #8 0x4019e0 in piglit_display piglit/tests/shaders/fp-formats.c:67
    #9 0x7f8d643fc4 in run_test piglit/tests/util/piglit-framework-gl/piglit_fbo_framework.c:52
    #10 0x401624 in main piglit/tests/shaders/fp-formats.c:39

Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21175>

17 months agofreedreno/registers: document more bits of CP_REG_TEST
Chia-I Wu [Wed, 8 Feb 2023 04:43:48 +0000 (20:43 -0800)]
freedreno/registers: document more bits of CP_REG_TEST

On gen3+, there are 32 predicate bits instead of 1.

I set out to see why CP_REG_TEST (and others commands that read
registers) is slower on gen1 but could not find anything.  Since the
blob seems to use multiple predicate bits, let's keep them documented.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21206>

17 months agoturnip: skip unnecessary CP_REG_TEST for cond load/store
Chia-I Wu [Wed, 8 Feb 2023 20:25:21 +0000 (12:25 -0800)]
turnip: skip unnecessary CP_REG_TEST for cond load/store

When no attachment allows conditional load/store, skip the unnecessary
CP_REG_TEST.

This is done to avoid a performance trap on a618 (gen1).  CP_REG_TEST or
any command that reads a register is slow on a618.

glmark2 score goes from 830 to 1001.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8162
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21206>

17 months agoturnip: add a comment to tu_render_pass_cond_config
Chia-I Wu [Wed, 8 Feb 2023 20:25:17 +0000 (12:25 -0800)]
turnip: add a comment to tu_render_pass_cond_config

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21206>

17 months agozink: implement cross-program pipeline library sharing
Mike Blumenkrantz [Thu, 9 Feb 2023 17:17:25 +0000 (12:17 -0500)]
zink: implement cross-program pipeline library sharing

some games/apps (e.g., DOOM2016) compile+link shaders in one context
and then use them in another, expecting that the compiled shaders
will be reused. vulkan has pipeline (library) objects, which are not
specific to shaders but are in theory representing the shaders being used

thus, pipeline (library) objects need to be reusable for any case where
a shader can be reused

to handle this:
* extract pipeline library cache to a refcounted object
* store these objects on the screen
* make them owned by shaders

separable programs are slightly different since they'll use their own
fastpath, thus making their library caches owned by the programs to avoid
polluting the optimized caches

fixes #8264

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21223>

17 months agozink: break out zink_gfx_program::libs into refcounted object
Mike Blumenkrantz [Thu, 9 Feb 2023 17:16:12 +0000 (12:16 -0500)]
zink: break out zink_gfx_program::libs into refcounted object

no functional changes yet, and these are still 1:1 with their programs

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21223>

17 months agozink: store gfx_hash on zink_gfx_program
Mike Blumenkrantz [Thu, 9 Feb 2023 17:12:16 +0000 (12:12 -0500)]
zink: store gfx_hash on zink_gfx_program

this avoids needing to reference ctx->gfx_hash in threads or recalc the hash

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21223>

17 months agonir/inline_uniforms: Add inot condition support
Ian Romanick [Fri, 3 Feb 2023 23:57:22 +0000 (15:57 -0800)]
nir/inline_uniforms: Add inot condition support

From the 96c19d23c95700 commit message:

    Ever since 4246c2869c3c and 7d85dc4f350b loop unrolling can no
    longer depend on inot being eliminated from the loop
    terminator condition so we need to be able to handle it.

Support these conditions here too.

Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21179>

17 months agonir/inline_uniforms: Make add_inlinable_uniforms public
Ian Romanick [Mon, 6 Feb 2023 20:32:48 +0000 (12:32 -0800)]
nir/inline_uniforms: Make add_inlinable_uniforms public

This is step 5 in an attempt to unify a bunch of nir_inline_uniforms.c
and lvp_inline_uniforms.c code.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21179>

17 months agonir/inline_uniforms: Make src_only_uses_uniforms public, change name
Ian Romanick [Mon, 6 Feb 2023 20:17:45 +0000 (12:17 -0800)]
nir/inline_uniforms: Make src_only_uses_uniforms public, change name

While making the function public, rename it to
nir_collect_src_uniforms. The old name makes it sound like it's just a
query that doesn't have side effects. That is, however, not the case.

This is step 4 in an attempt to unify a bunch of nir_inline_uniforms.c
and lvp_inline_uniforms.c code.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21179>

17 months agonir/inline_uniforms: Allow possibility of uni_offsets and num_offsets being NULL
Ian Romanick [Mon, 6 Feb 2023 20:41:49 +0000 (12:41 -0800)]
nir/inline_uniforms: Allow possibility of uni_offsets and num_offsets being NULL

This is step 3 in an attempt to unify a bunch of nir_inline_uniforms.c
and lvp_inline_uniforms.c code.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21179>

17 months agonir/inline_uniforms: Allow possibility of more than one UBO
Ian Romanick [Mon, 6 Feb 2023 19:25:19 +0000 (11:25 -0800)]
nir/inline_uniforms: Allow possibility of more than one UBO

Only caller in this file still only passes 1.

This is step 2 in an attempt to unify a bunch of nir_inline_uniforms.c
and lvp_inline_uniforms.c code.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21179>

17 months agonir/inline_uniforms: Pass max_num_bo and max_offset around as parameters
Ian Romanick [Mon, 6 Feb 2023 19:05:11 +0000 (11:05 -0800)]
nir/inline_uniforms: Pass max_num_bo and max_offset around as parameters

max_num_bo is currently limited to 1. That will change in the next
commit.

This is step 1 in an attempt to unify a bunch of nir_inline_uniforms.c
and lvp_inline_uniforms.c code.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21179>

17 months agonir/inline_uniforms: Change num_offsets type to uint8_t
Ian Romanick [Mon, 6 Feb 2023 18:51:34 +0000 (10:51 -0800)]
nir/inline_uniforms: Change num_offsets type to uint8_t

This is step 0 in an attempt to unify a bunch of nir_inline_uniforms.c
and lvp_inline_uniforms.c code.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21179>

17 months agoci/crocus: Update HSW expectations.
Emma Anholt [Wed, 8 Feb 2023 23:56:26 +0000 (15:56 -0800)]
ci/crocus: Update HSW expectations.

2 good-looking trace updates, one new crash.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21205>

17 months agoci/radv: Update navi21 llvm xfails.
Emma Anholt [Wed, 8 Feb 2023 21:06:22 +0000 (13:06 -0800)]
ci/radv: Update navi21 llvm xfails.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21205>

17 months agoci/nouveau: Disable the gm20b jobs entirely.
Emma Anholt [Wed, 8 Feb 2023 20:58:59 +0000 (12:58 -0800)]
ci/nouveau: Disable the gm20b jobs entirely.

The old (broken, hw failure) board isn't really hooked up right now, and
I'm waiting on buying some remaining bits to set up the 10 boards sitting
in the box here.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21205>

17 months agoci/freedreno: Update a3xx piglit_shader xfails.
Emma Anholt [Wed, 8 Feb 2023 20:55:48 +0000 (12:55 -0800)]
ci/freedreno: Update a3xx piglit_shader xfails.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21205>

17 months agoci/freedreno: Add an xfail for a618 VK full run.
Emma Anholt [Wed, 8 Feb 2023 20:53:30 +0000 (12:53 -0800)]
ci/freedreno: Add an xfail for a618 VK full run.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21205>

17 months agoci/freedreno: Update a530 manual-run xfails.
Emma Anholt [Wed, 8 Feb 2023 20:43:11 +0000 (12:43 -0800)]
ci/freedreno: Update a530 manual-run xfails.

A lot of this looks like fractional run test list updates.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21205>

17 months agoci/freedreno: Disable the a306_piglit_gl job.
Emma Anholt [Wed, 8 Feb 2023 20:30:36 +0000 (12:30 -0800)]
ci/freedreno: Disable the a306_piglit_gl job.

It's broken with recurring hangchecks.  Someone would need to restabilize
it, but turn it off for anyone to find until someone (me? :( ) cares.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21205>

17 months agoci/zink: Update TGL full-run xfails.
Emma Anholt [Wed, 8 Feb 2023 20:19:59 +0000 (12:19 -0800)]
ci/zink: Update TGL full-run xfails.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21205>

17 months agoci: Disable systems in my farm that haven't recovered.
Emma Anholt [Wed, 8 Feb 2023 20:17:03 +0000 (12:17 -0800)]
ci: Disable systems in my farm that haven't recovered.

We lost power in a storm, and these ones didn't come back afterwards.  I
suspect I need a new PSU.  And maybe some surge protection for the future.
:(

I've left the CI code in place for some day when I hopefully swap out the
power supplies.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21205>

17 months agomesa/st: Measure compressed fallback unmap paths
Nanley Chery [Mon, 14 Nov 2022 22:42:53 +0000 (14:42 -0800)]
mesa/st: Measure compressed fallback unmap paths

Add code to help find performance issues. The logging is disabled by
default.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19827>

17 months agomesa/st: Enable compute-based transcoding to DXT5
Nanley Chery [Fri, 22 Jul 2022 00:28:22 +0000 (17:28 -0700)]
mesa/st: Enable compute-based transcoding to DXT5

By enabling this path, we get a 56% decrease in upload time on a texture
upload microbenchmark. This was measured on an Ice Lake with an iris
driver that tries to use the compressed format fallback path.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19827>

17 months agomesa/st: Add st_texture_image_resource_level
Nanley Chery [Mon, 24 Oct 2022 23:44:03 +0000 (16:44 -0700)]
mesa/st: Add st_texture_image_resource_level

Returns the level of the gl_texture_image with respect to the resource
it's allocated within. Example: returns 0 for non-finalized texture.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19827>

17 months agomesa/st: Add st_compute_transcode_astc_to_dxt5
Nanley Chery [Mon, 12 Dec 2022 13:12:46 +0000 (05:12 -0800)]
mesa/st: Add st_compute_transcode_astc_to_dxt5

Add a function to upload ASTC data, transcoding it to BC3/DXT5 in the
process.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19827>

17 months agomesa/st: Add and use create_bc1_endpoint_ssbo
Nanley Chery [Tue, 25 Oct 2022 17:08:21 +0000 (10:08 -0700)]
mesa/st: Add and use create_bc1_endpoint_ssbo

Create and cache the SSBO used by the BC1 compute shader program.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19827>

17 months agomesa/st: Add get_compute_program
Nanley Chery [Fri, 22 Jul 2022 00:02:40 +0000 (17:02 -0700)]
mesa/st: Add get_compute_program

Add a function to create and cache the compute programs that will be
used to transcode ASTC to DXT5.

Note that the error paths in st_create_context_priv may actually lead to
segfaults if hit. I've been able to work around them by 1) moving them
further down and 2) returning early from st_glFlush if st->pipe is NULL.
I don't know if that's the right solution however.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19827>

17 months agomesa: Create _mesa_CreateShaderProgramv_impl
Nanley Chery [Fri, 4 Nov 2022 16:45:10 +0000 (09:45 -0700)]
mesa: Create _mesa_CreateShaderProgramv_impl

Factor out the implementation of _mesa_CreateShaderProgramv so that we
can make programs that will encode DXT5.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19827>

17 months agoglsl: Modify the #includes in the DXT5 shaders
Nanley Chery [Wed, 5 Oct 2022 05:10:39 +0000 (22:10 -0700)]
glsl: Modify the #includes in the DXT5 shaders

1. Drop the commented out includes. Shader caching is disabled if those
   are found.

2. Replace the active includes with "%s". Later on, we'll construct the
   final strings with vasprintf. One downside to doing this is that the
   glsl file extensions are no longer true. These files are now
   templates.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19827>

17 months agoglsl: Add compute shaders to encode DXT5/BC3
Nanley Chery [Thu, 28 Jul 2022 00:01:05 +0000 (17:01 -0700)]
glsl: Add compute shaders to encode DXT5/BC3

These compute shaders are from the MIT-licensed GPU compressor, Betsy.
I have included copyright headers, inlined the __sharedOnlyBarrier macro
definition from the "UavCrossPlatform_piece_all.glsl" header when
applicable, and made the following changes to support GLES:

   * Conditionally disable the const keyword in the BC3 shaders
   * Make the params uniform in the BC4 shader uint2
   * Avoid implicit data type conversions in the BC3 shaders
   * Use constructors for array initialization in the BC1 shader
   * Add precision qualifiers to the BC3 shaders
   * Output to an rgba16ui image for the BC1 and BC4 shaders
   * Set the version of the BC3 shaders to 310 es

Ref: https://github.com/darksylinc/betsy/tree/cc723dcae9
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19827>

17 months agodocs: Document the implicit barriers around blits
Nanley Chery [Thu, 24 Nov 2022 00:20:43 +0000 (16:20 -0800)]
docs: Document the implicit barriers around blits

We're going to use resource_copy_region to copy from a resource that has
been written to with imageStore. Make it clear that this is safe.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19827>

17 months agocrocus: disable Y tiling for render targets properly.
Dave Airlie [Thu, 9 Feb 2023 02:59:53 +0000 (12:59 +1000)]
crocus: disable Y tiling for render targets properly.

The old code would disallow linear targets as well which would confuse
things with reimporting dma-bufs.

Fixes: 32728dc66e36 ("crocus: introduce main resource configuration helper.")
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21209>

17 months agoiris: disable preemption for 3DPRIMITIVE during streamout
Tapani Pälli [Wed, 23 Nov 2022 07:22:36 +0000 (09:22 +0200)]
iris: disable preemption for 3DPRIMITIVE during streamout

This is required by Wa_16013994831.

Cc: mesa-stable
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19947>

17 months agointel/fs: fix mesh indirect movs
Lionel Landwerlin [Wed, 8 Feb 2023 12:11:07 +0000 (14:11 +0200)]
intel/fs: fix mesh indirect movs

The size in src[2] is in byte and needs to cover any possible data
accessed in src[0] by the indirection. That way the register
allocation is aware of what cannot be spilled for the instruction to
execute on valid data.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 70ace2bbcd ("intel/compiler: Implement Task Output and Mesh Input")
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21188>

17 months agozink: set PIPE_CAP_SURFACE_REINTERPRET_BLOCKS
Mike Blumenkrantz [Thu, 9 Feb 2023 14:22:14 +0000 (09:22 -0500)]
zink: set PIPE_CAP_SURFACE_REINTERPRET_BLOCKS

this fixes perf for CompressedTexSubImage and makes DOOM2016 run at full speed

ref #8223

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21218>

17 months agozink: use GPL to handle (simple) separate shader objects
Mike Blumenkrantz [Tue, 7 Feb 2023 18:32:21 +0000 (13:32 -0500)]
zink: use GPL to handle (simple) separate shader objects

apps/games using separate shader objects end up passing the separable
shaders to the link_shader hook individually, which is still not ideal for
zink's usage since the more optimal path is to have all the shaders and create
a RAST+FS GPL stage that can run all the inter-stage io handlers

it IS technically possible to handle this for simple VS+FS pipelines using
GPL, however, but it's kinda gross. such shaders now use descriptor buffer
to create their own pipelines/layouts/descriptors async, and then a "separable"
variant of the gfx program can be created by fast-linking these together

the "separable" gfx program can't handle shader variants, but it can do basic
pipeline caching for PSO state changes, which makes it flexible enough to sorta
kinda maybe handle the most basic cases of separate shader objects

descriptor buffer is used because having to create and manage a separate architecture
for sets/pools/templates is too nightmarish even for me

this is, at best, a partial solution, but it's the best the vulkan api can
currently do

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21197>

17 months agozink: enable combining intermediate gpl libs from combine function
Mike Blumenkrantz [Tue, 7 Feb 2023 18:29:18 +0000 (13:29 -0500)]
zink: enable combining intermediate gpl libs from combine function

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21197>

17 months agozink: move gpl input/output funcs to zink_pipeline.c
Mike Blumenkrantz [Mon, 6 Feb 2023 19:27:11 +0000 (14:27 -0500)]
zink: move gpl input/output funcs to zink_pipeline.c

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21197>

17 months agozink: allow multiple gpl libraries in zink_create_gfx_pipeline_combined()
Mike Blumenkrantz [Mon, 6 Feb 2023 19:15:34 +0000 (14:15 -0500)]
zink: allow multiple gpl libraries in zink_create_gfx_pipeline_combined()

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21197>