platform/upstream/gstreamer.git
2 years agoci: stop automatically running tests post-merge
Tim-Philipp Müller [Tue, 29 Mar 2022 17:57:21 +0000 (18:57 +0100)]
ci: stop automatically running tests post-merge

We did that in order to find flaky tests so we could add
them to our ignore lists, but that's all done now and I
doubt anyone still looks at the results, so this is just
wasting runner cycles at this point.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2063>

2 years agova: Fix printf format modifier for drm modifiers
Nicolas Dufresne [Fri, 1 Apr 2022 19:59:58 +0000 (15:59 -0400)]
va: Fix printf format modifier for drm modifiers

DRM modifiers are 64bit, the printf modifier is platform dependant. Use
the G_GINT64_MODIFIER macro to make this printf portable.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2102>

2 years agoaggregator: Improve debugging of arriving buffers
Jan Schmidt [Fri, 1 Apr 2022 13:16:29 +0000 (00:16 +1100)]
aggregator: Improve debugging of arriving buffers

Log some details about the buffers that are arriving and
being enqueued on each sink pad.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2096>

2 years agogstreamer: Remove GST_DATAFLOW debug category
Jan Schmidt [Fri, 1 Apr 2022 13:46:21 +0000 (00:46 +1100)]
gstreamer: Remove GST_DATAFLOW debug category

Nothing has logged anything to this category since event and
buffer dataflow was de-unified in 2005.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2097>

2 years agoUse gmodule-no-export-2.0
Xavier Claessens [Wed, 30 Mar 2022 15:06:02 +0000 (11:06 -0400)]
Use gmodule-no-export-2.0

We don't need `-Wl,--export-dynamic`, that's used only for executables
that needs to export an API to be used by plugins they load.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2031>

2 years agoRemove glib and gobject dependencies everywhere
Xavier Claessens [Fri, 25 Mar 2022 19:00:20 +0000 (15:00 -0400)]
Remove glib and gobject dependencies everywhere

They are part of gst_dep already and we have to make sure to always have
gst_dep. The order in dependencies matters, because it is also the order
in which Meson will set -I args. We want gstreamer's config.h to take
precedence over glib's private config.h when it's a subproject.

While at it, remove useless fallback args for gmodule/gio dependencies,
only gstreamer core needs it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2031>

2 years agoFix cross build with mingw32
Xavier Claessens [Thu, 24 Mar 2022 18:15:00 +0000 (14:15 -0400)]
Fix cross build with mingw32

At least on Ubuntu 20.04 the x86_64-w64-mingw32-gcc toolchain defaults
to WinXP. We require at least Vista for FILE_STANDARD_INFO.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2022>

2 years agoges-smart-video-mixer: use the proper pad to get the positioner meta
Xabier Rodriguez Calvar [Thu, 31 Mar 2022 10:49:48 +0000 (12:49 +0200)]
ges-smart-video-mixer: use the proper pad to get the positioner meta

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2094>

2 years agoglcolorconvert: should copy metadatas from the incoming buffer
Xabier Rodriguez Calvar [Thu, 31 Mar 2022 10:47:06 +0000 (12:47 +0200)]
glcolorconvert: should copy metadatas from the incoming buffer

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2094>

2 years agoUpdate android cross file
Xavier Claessens [Wed, 30 Mar 2022 17:07:10 +0000 (13:07 -0400)]
Update android cross file

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/617>

2 years agoAndroid: Implement JNI_OnLoad()
Xavier Claessens [Sat, 5 Sep 2020 00:52:47 +0000 (20:52 -0400)]
Android: Implement JNI_OnLoad()

When building for Android, chances are that gstreamer is going to be
loaded from Java using System.loadLibrary(). In that case we can
initialize GStreamer (including static plugins), redirect log functions,
etc.

This code is copied from cerbero because it can be used with
gstreamer-full-1.0 too. Cerbero needs to be adapted to drop that code
and generate gst_init_static_plugins() function.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/617>

2 years agoplaybin/playbin3: Allow setting a NULL URI
Sebastian Dröge [Fri, 1 Apr 2022 07:25:23 +0000 (10:25 +0300)]
playbin/playbin3: Allow setting a NULL URI

The URI is already initialized to NULL at the beginning and GstPlayer
was assuming that it is possible to set to NULL at a later time too.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1124

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2090>

2 years agonavigation: Rename parse_state to parse_modifier_state
Thibault Saunier [Thu, 31 Mar 2022 21:41:41 +0000 (23:41 +0200)]
navigation: Rename parse_state to parse_modifier_state

`parse_state` sounds a bit weird and `parse_modifier_state` is clearer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2087>

2 years agobase:gl: add x11 deps to gstglx11_dep
Stéphane Cerveau [Tue, 29 Mar 2022 15:51:13 +0000 (17:51 +0200)]
base:gl: add x11 deps to gstglx11_dep

On MacOS with homebrew the xlib-xcb.h is in
own cellar /opt/homebrew/Cellar/libx11/1.7.3.1/include
Need to add the windowing dependencies to gl tests

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2061>

2 years agoqsvencoder: Add support for VA memory
Seungha Yang [Fri, 25 Mar 2022 13:04:05 +0000 (22:04 +0900)]
qsvencoder: Add support for VA memory

Use VA allocator and buffer pool implementation for zero-copy
encoding with upstream VA elements

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2030>

2 years agoqsv: Use pipeline's VA context
Seungha Yang [Fri, 25 Mar 2022 12:03:02 +0000 (21:03 +0900)]
qsv: Use pipeline's VA context

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2030>

2 years agoUpdate openjp2 and libxml2 from wrapdb
Xavier Claessens [Thu, 31 Mar 2022 18:19:46 +0000 (14:19 -0400)]
Update openjp2 and libxml2 from wrapdb

This fix their static link for Windows.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2084>

2 years agolibs: va: add VA allocator parameter for derived images usage.
Víctor Manuel Jáquez Leal [Tue, 29 Mar 2022 12:52:33 +0000 (14:52 +0200)]
libs: va: add VA allocator parameter for derived images usage.

Added GstVaFeature enum type, and new parameter for VA allocator's
set_format() and get_format(). Also added a new parameter in VA pool
gst_va_pool_new_with_config() and
gst_buffer_pool_config_set_va_allocation_params().

This new parameter will define if derived images will by used for
buffer mapping.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2057>

2 years agowebrtcstats: Unify 'packets-lost' data type to int64
Sangchul Lee [Mon, 28 Mar 2022 12:25:50 +0000 (21:25 +0900)]
webrtcstats: Unify 'packets-lost' data type to int64

Previously, 'packets-lost' member of RTCReceivedRtpStreamStats had
a value of G_TYPE_INT from rtpsource or a value of G_TYPE_UINT64
from rtpjitterbuffer.
Because of the negative value of estimated amount of packets lost
in rtpsource as well as the description in
https://www.w3.org/TR/webrtc-stats/#dom-rtcreceivedrtpstreamstats
it is fixed to set this value with G_TYPE_INT64.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2049>

2 years agooverlay: Fix qt support detection
Xavier Claessens [Mon, 30 Mar 2020 19:16:29 +0000 (15:16 -0400)]
overlay: Fix qt support detection

On Ubuntu moc-qt5 command is called moc. This requires Meson 0.54.0 for
the new has_tools() method.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2075>

2 years agova: encoder: Remove unused allocation config.
Víctor Manuel Jáquez Leal [Wed, 30 Mar 2022 10:12:34 +0000 (12:12 +0200)]
va: encoder: Remove unused allocation config.

Since it's also done inside of gst_va_pool_new_with_config().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2072>

2 years agovadisplay: Add description readonly property
Seungha Yang [Tue, 29 Mar 2022 17:49:40 +0000 (02:49 +0900)]
vadisplay: Add description readonly property

Expose description of vendor for user information, similar to
the description property of d3d11device.
Also, set description and DRM device path on GstContext structure
so that user can read them and it will be printed on terminal
when gst-launch-1.0 is used

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2064>

2 years agogst-play: Improve Win32 keyboard input handling
Seungha Yang [Tue, 29 Mar 2022 13:16:14 +0000 (22:16 +0900)]
gst-play: Improve Win32 keyboard input handling

The console HANDLE will be keep signalled state unless application
reads console input buffer immediately. So we should read and flush
console input buffer from the thread where the event is signalled,
instead of GMain context thread.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2058>

2 years agotools: Add support for building gstreamer tools against gst-full
Thibault Saunier [Sat, 11 Sep 2021 15:17:56 +0000 (12:17 -0300)]
tools: Add support for building gstreamer tools against gst-full

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1581>

2 years agoplaysink: improve GL context sharing
Enrique Ocaña González [Mon, 28 Mar 2022 16:43:27 +0000 (18:43 +0200)]
playsink: improve GL context sharing

Configure playsink tried element with the bus of the main pipeline.
That tried element can be a gl video sink, which would benefit from being
able to propagate context messages to the main pipeline and have other
internal pipeline elements configured with it. Having different elements
configured with the same GL context allows them to share buffers with
video/x-raw(memory:GLMemory) caps and achieving zero-copy.

Thanks to Alicia Boya García <aboya@igalia.com> for her work co-debugging
the issue and contributing to find a solution.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2056>

2 years agodocs/design: Updates for upstream selection
Edward Hervey [Fri, 11 Mar 2022 10:34:25 +0000 (11:34 +0100)]
docs/design: Updates for upstream selection

Update existing documentation for various behaviours.

Add new information on how selection "upstream" of decodebin3 happens.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1905>

2 years agourisourcebin: When streams-aware, remove pads immediately
Edward Hervey [Wed, 9 Jun 2021 09:25:36 +0000 (11:25 +0200)]
urisourcebin: When streams-aware, remove pads immediately

For the same reason we add them immediately

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1905>

2 years agourisourcebin: Don't wait for pads content when streams-aware
Edward Hervey [Tue, 8 Jun 2021 12:31:10 +0000 (14:31 +0200)]
urisourcebin: Don't wait for pads content when streams-aware

If the adaptive demux is streams-aware it can add/remove pads at any point in
time without the need for no-more-pads or data blocking

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1905>

2 years agourisourcebin: Don't do buffering if source already does
Edward Hervey [Sat, 29 May 2021 05:31:15 +0000 (07:31 +0200)]
urisourcebin: Don't do buffering if source already does

Sources that can internally handle buffering shouldn't have yet-another
buffering element after it. This can be simply detected by checking if it can
answer a TIME BUFFERING query just after creation.

If that is the case, we can expose the element source pads directly

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1905>

2 years agodecodebin3: Handle upstream selection
Edward Hervey [Fri, 28 May 2021 05:49:10 +0000 (07:49 +0200)]
decodebin3: Handle upstream selection

Detect if upstream handles stream-selection, and if so bypass all stream
selection handling (streams are forwarded as-is).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1905>

2 years agoquery: Add a new stream selection query
Edward Hervey [Wed, 30 Mar 2022 08:01:33 +0000 (10:01 +0200)]
query: Add a new stream selection query

This new API allows querying whether elements can handle stream selection
themselves or not.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1905>

2 years agoci: Don't tie up a full job slot for cerbero trigger
Daniel Stone [Wed, 30 Mar 2022 09:52:53 +0000 (10:52 +0100)]
ci: Don't tie up a full job slot for cerbero trigger

We don't have a huge amount of capacity on shared runners, so better if
we don't use that limited capacity on a job which sits there doing
~nothing.

There is a new runner class called 'placeholder-job' which accepts a
huge number of parallel jobs, separately to normal jobs, on the
assumption that they will consume ~no resources; start using that.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2071>

2 years agova: Don't expose internal classes.
Víctor Manuel Jáquez Leal [Wed, 30 Mar 2022 05:03:59 +0000 (07:03 +0200)]
va: Don't expose internal classes.

VA allocators and pools classes don't need to be exposed as external
symbols.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2070>

2 years agogstplay: don't print error log in warning_cb
Haihua Hu [Wed, 30 Mar 2022 04:01:20 +0000 (12:01 +0800)]
gstplay: don't print error log in warning_cb

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2069>

2 years agovapostproc: Build classification dynamically.
Víctor Manuel Jáquez Leal [Tue, 29 Mar 2022 18:14:40 +0000 (20:14 +0200)]
vapostproc: Build classification dynamically.

By default, the classification is
"Converter/Filter/Colorspace/Scaler/Video/Hardware", but if VA
post-processor driver supports either color balance, skin tone
enhancement, sharpening or noise reduction, "Effect" is added.

Thus, if vapostproc ranking is raised, it can be chosen by
autovideosink.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2066>

2 years agowebrtc: produce stats for all relevant streams
Matthew Waters [Mon, 21 Feb 2022 03:02:52 +0000 (14:02 +1100)]
webrtc: produce stats for all relevant streams

Instead of only using the last ssrc that was pushed into a sink pad.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc: avoid different versions of gnu-indent always wanting to change !!
Matthew Waters [Fri, 11 Feb 2022 05:50:42 +0000 (16:50 +1100)]
webrtc: avoid different versions of gnu-indent always wanting to change !!

Add some sneaky parenthesis to avoid always having to use git commit -n
or revert out hunk of the change.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc: implement initial simulcast fec/rtx usage
Matthew Waters [Fri, 26 Nov 2021 11:04:14 +0000 (22:04 +1100)]
webrtc: implement initial simulcast fec/rtx usage

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc/datachannel: fix use-after-free in sctp state notification
Matthew Waters [Fri, 26 Nov 2021 11:11:06 +0000 (22:11 +1100)]
webrtc/datachannel: fix use-after-free in sctp state notification

g_signal_disconnect*() doesn't stop any existing callbacks from running
which means that if the notify::state callback is in progress in one
thread and the data channel object is finalize()ed in another thread,
then there could be a use-after-free trying lock the data channel
object.

We can't reasonably use a GWeakRef as we don't have a 'parent' object to
free the GWeakRef after the data channel is finalized.  This is also
complicated by the fact that the application can hold a reference to the
data channel object that would live beyond the lifetime of webrtcbin
itself.

We solve this by implementing a ghetto weak-ref solution internally with
a list of outstanding data channels.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: fix a use-after-free in test_data_channel_close
Matthew Waters [Fri, 26 Nov 2021 11:06:39 +0000 (22:06 +1100)]
tests/webrtc: fix a use-after-free in test_data_channel_close

g_object_weak_ref() is not thread-safe and the data channel object's
refs/unrefs can happen on multiple threads.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: fix a race in the tests related to state tracking
Matthew Waters [Fri, 26 Nov 2021 10:51:57 +0000 (21:51 +1100)]
tests/webrtc: fix a race in the tests related to state tracking

If things progress fast enough, some state changes may not be seen be
the waiting code.

Fix by:
1. keeping a list of all the state changes
2. waiting checks each entry and if the relevant state is found, all
   states up to and including then are removed.

This ensures that any waits will see all the state sets.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: factor out src pad property checking to a separate function
Matthew Waters [Thu, 25 Nov 2021 15:00:12 +0000 (02:00 +1100)]
tests/webrtc: factor out src pad property checking to a separate function

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: initial support for sending and receiving simulcast streams
Matthew Waters [Tue, 16 Nov 2021 08:27:11 +0000 (19:27 +1100)]
webrtcbin: initial support for sending and receiving simulcast streams

Input (sink pads) is the already-ssrc-muxed stream with the relevant rtp
sdes header extensions already applied:
  - mid
  - stream-id
  - repaired-stream-id

Output (src pads) have the pads separated into individual ssrc's as
that's what rtpbin gives us.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: test for enabled bundled fec/rtx
Matthew Waters [Tue, 16 Nov 2021 07:11:49 +0000 (18:11 +1100)]
tests/webrtc: test for enabled bundled fec/rtx

Doesn't actually check that any fec/rtx happens, just that the pipeline
is vaguely sane and doesn't error.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: support multiple received streams for a single mline
Matthew Waters [Tue, 16 Nov 2021 06:39:18 +0000 (17:39 +1100)]
webrtcbin: support multiple received streams for a single mline

Each rtpbin exposed recv_src pad is now exposed as webrtcbin src_%u pad
now with no meaining applied to the value of %u.  Previously this used
to mean the mline in the SDP.  If this is is still required, then the
transceiver can be retrieved from the pad and the "mlineindex" property
from the transciever.  The "mid" is also retrievable from the
transceiver.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc: explicitly error out in a couple of renegotiation cases
Matthew Waters [Tue, 16 Nov 2021 06:28:04 +0000 (17:28 +1100)]
webrtc: explicitly error out in a couple of renegotiation cases

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc/transportstream: add debug category
Matthew Waters [Tue, 16 Nov 2021 06:21:31 +0000 (17:21 +1100)]
webrtc/transportstream: add debug category

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: also check valid mline for srcpad codec-preferences negotiation
Matthew Waters [Wed, 3 Nov 2021 10:18:53 +0000 (21:18 +1100)]
tests/webrtc: also check valid mline for srcpad codec-preferences negotiation

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: don't name src pads based on the mline specifically anymore
Matthew Waters [Wed, 3 Nov 2021 09:46:23 +0000 (20:46 +1100)]
webrtcbin: don't name src pads based on the mline specifically anymore

Naming based on the mline doesn't really work with e.g. simulcast
scenarios.

It is entirely possible to retrieve the transceiver and then the mline
from that if that is so required.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc/tests: print the correct media idx on error
Matthew Waters [Fri, 29 Oct 2021 07:40:04 +0000 (18:40 +1100)]
webrtc/tests: print the correct media idx on error

Instead of the attribute index

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc/tests: give slightly better names to the dot file dumps
Matthew Waters [Fri, 29 Oct 2021 07:38:37 +0000 (18:38 +1100)]
webrtc/tests: give slightly better names to the dot file dumps

Don't use printf-specifiers with g_strconcat().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: improve some debugging output
Matthew Waters [Wed, 21 Jul 2021 07:48:34 +0000 (17:48 +1000)]
webrtcbin: improve some debugging output

- Put human readable names into debug strings.
- Demote some frequent rtpbin signal logging
- Don't use GST_PTR_FORMAT in g_set_error()

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: silence spurious warning when creating answer transceiver
Matthew Waters [Wed, 21 Jul 2021 07:39:11 +0000 (17:39 +1000)]
webrtcbin: silence spurious warning when creating answer transceiver

When creating a transceiver when creating an answer, the media kind of the
transceiver was never set correctly initially.  This would lead to a
GST_WARNING being produced about changin a transceiver's media kind.

Fix by retrieving the GstSDPMedia kind from the offer instead as the answer
GstSDPMedia has not been set as the answer caps have not been chosen yet.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: always use a unique SSRC for each stream
Matthew Waters [Wed, 21 Jul 2021 04:29:35 +0000 (14:29 +1000)]
tests/webrtc: always use a unique SSRC for each stream

Will become more relevant with mid/rid->ssrc mappings

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: add a specific find_transceiver_by_mid function
Matthew Waters [Wed, 21 Jul 2021 04:14:30 +0000 (14:14 +1000)]
webrtcbin: add a specific find_transceiver_by_mid function

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: explicitly use a variable for the rtp session idx
Matthew Waters [Tue, 20 Jul 2021 10:17:13 +0000 (20:17 +1000)]
webrtcbin: explicitly use a variable for the rtp session idx

Slightly clearer in meaning.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: support using an a=mid value from the sink/transceiver caps
Matthew Waters [Thu, 1 Jul 2021 05:54:34 +0000 (15:54 +1000)]
webrtcbin: support using an a=mid value from the sink/transceiver caps

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agova: Set <gst/va/gstva.h> as library single point entry header.
Víctor Manuel Jáquez Leal [Fri, 25 Mar 2022 14:56:01 +0000 (15:56 +0100)]
va: Set <gst/va/gstva.h> as library single point entry header.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2048>

2 years agova: Move allocators and pool objects into gstva library.
He Junyan [Wed, 23 Feb 2022 07:40:19 +0000 (15:40 +0800)]
va: Move allocators and pool objects into gstva library.

In order to other plugins use gstva objects, such as allocators and buffer
pools, this merge request move them from the va plugin to the gstva library.

This objects are not exposed in <gst/va/gstva.h> since they are not expected
to be used by users, only by plugin implementators.

Because of the surface copy design, which is used to implement allocator's
mem_copy() virtual function, depends on the vafilter, which is kept inside
the plugin, memory copy through VAPosproc is disabled and removed temporarly.

Also added some missing parameter validation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2048>

2 years agova: Move the video format functions into gstlibva.
He Junyan [Wed, 23 Feb 2022 07:25:08 +0000 (15:25 +0800)]
va: Move the video format functions into gstlibva.

Untabifying header file.

The logging category was moved from the plugin generic category to
the display category. It can argue that video formats hacks are
display dependant.

Added validations for input parameters.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2048>

2 years agomeson: Add some messages when selecting libsoup
Nirbheek Chauhan [Fri, 25 Mar 2022 19:32:02 +0000 (01:02 +0530)]
meson: Add some messages when selecting libsoup

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2032>

2 years agosoup: Fix usage of symbols / defines that are gone in libsoup3
Nirbheek Chauhan [Fri, 25 Mar 2022 19:29:12 +0000 (00:59 +0530)]
soup: Fix usage of symbols / defines that are gone in libsoup3

I am not sure about the SOUP_MESSAGE_OVERWRITE_CHUNKS change, but it
was definitely already broken when using libsoup-3.0 in a shared
build. souphttpsrc probably needs to be ported from SoupMessage to
SoupServerMessage when using libsoup-3.0.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1111

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2032>

2 years agosoup: Fix pre-processor macros in souploader for libsoup-3.0
Nirbheek Chauhan [Fri, 25 Mar 2022 19:26:04 +0000 (00:56 +0530)]
soup: Fix pre-processor macros in souploader for libsoup-3.0

Some of the preprocessor conditionals in the loader were very broken
with libsoup-3.0 + --default-library=static

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1111

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2032>

2 years agopbutils: Fix wmv screen detection
Edward Hervey [Mon, 28 Mar 2022 10:13:12 +0000 (12:13 +0200)]
pbutils: Fix wmv screen detection

strncmp vs !strncmp :)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2050>

2 years agoges: remove memory leak with description
Stéphane Cerveau [Mon, 28 Mar 2022 11:47:52 +0000 (13:47 +0200)]
ges: remove memory leak with description

free the capsdesc

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2047>

2 years agonle: clear seek event properly
Stéphane Cerveau [Mon, 28 Mar 2022 11:20:40 +0000 (13:20 +0200)]
nle: clear seek event properly

Use gst_clear_event instead of g_clear_object
avoiding a failing gobject unref

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2047>

2 years agoqsvencoder: Add support for dynamic bitrate update
Seungha Yang [Sun, 27 Mar 2022 14:27:54 +0000 (23:27 +0900)]
qsvencoder: Add support for dynamic bitrate update

... and add more encoding options.

QSV API supports dynamic bitrate change without IDR insertion.
That's more efficient way of runtime encoding option update
than starting from new sequence with IDR per bitrate option change.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2039>

2 years agoqsvh265enc: Add missing gop-size property
Seungha Yang [Fri, 25 Mar 2022 14:15:33 +0000 (23:15 +0900)]
qsvh265enc: Add missing gop-size property

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2039>

2 years agoqsv: Fix mfxFrameAllocator::Lock for encoder
Seungha Yang [Fri, 25 Mar 2022 12:13:22 +0000 (21:13 +0900)]
qsv: Fix mfxFrameAllocator::Lock for encoder

Only read map is possible for encoder input system memory

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2039>

2 years agopython: Add a suppression file for a leak in PyGObject
Thibault Saunier [Tue, 29 Mar 2022 16:43:56 +0000 (18:43 +0200)]
python: Add a suppression file for a leak in PyGObject

And ensure that the CI runs GES valgrind test when we change the
overrides as many GES tests are implemented in python

Proper fix is at: https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/204

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2060>

2 years agoavviddec: Remove vc1/wmv3 override
Edward Hervey [Tue, 29 Mar 2022 07:36:06 +0000 (09:36 +0200)]
avviddec: Remove vc1/wmv3 override

FFMPEG 5+ doesn't allow overriding the codec anymore (causes a segfault if you
attempt to do that). But the best part is ... that with the current caps
implementation in pad template and gst_ffmpeg_caps_to_codecid() we would never
replace it by anything different than the existing codec id.

Fixes #1054

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2052>

2 years agodocs: Fix doc generation example
Edward Hervey [Tue, 29 Mar 2022 07:24:55 +0000 (09:24 +0200)]
docs: Fix doc generation example

They need to be generated from the devenv else it just hangs for no reason.

See #1108

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2051>

2 years agopython: Add support for the GstURIHandlerInterface
Thibault Saunier [Mon, 6 Dec 2021 22:27:24 +0000 (19:27 -0300)]
python: Add support for the GstURIHandlerInterface

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1423>

2 years agovalidate/media-info: silence unsed variable warning
Matthew Waters [Mon, 28 Mar 2022 10:15:15 +0000 (21:15 +1100)]
validate/media-info: silence unsed variable warning

Fixes:

../validate/gst/validate/gst-validate-media-info.c:714:28: error: variable 'total_sink_count' set but not used [-Werror,-Wunused-but-set-variable]
  guint id, ncounters = 0, total_sink_count = 0;
                           ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agortsp-stream: remove unused variable:
Matthew Waters [Mon, 28 Mar 2022 10:03:16 +0000 (21:03 +1100)]
rtsp-stream: remove unused variable:

Fixes:

../gst/rtsp-server/rtsp-stream.c:2670:9: error: variable 'n_messages' set but not used [-Werror,-Wunused-but-set-variable]
  guint n_messages = 0;
        ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoapplemeida/texturecache: remove unused variable
Matthew Waters [Mon, 28 Mar 2022 09:51:35 +0000 (20:51 +1100)]
applemeida/texturecache: remove unused variable

Fixes:

../sys/applemedia/videotexturecache.m:71:20: error: variable 'features' set but not used [-Werror,-Wunused-but-set-variable]
  GstCapsFeatures *features;
                   ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoapplemedia/corevideobuffer: remove unused variable
Matthew Waters [Mon, 28 Mar 2022 09:50:27 +0000 (20:50 +1100)]
applemedia/corevideobuffer: remove unused variable

Fixes:

../sys/applemedia/corevideobuffer.c:209:19: error: variable 'video_meta' set but not used [-Werror,-Wunused-but-set-variable]
    GstVideoMeta *video_meta;
                  ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoapplemedia/iosgl: remove unused variable
Matthew Waters [Mon, 28 Mar 2022 09:49:01 +0000 (20:49 +1100)]
applemedia/iosgl: remove unused variable

Fixes:

../sys/applemedia/iosurfaceglmemory.c:219:41: error: variable 'texfmt' set but not used [-Werror,-Wunused-but-set-variable]
    GLuint tex_id, tex_target, texifmt, texfmt;
                                        ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agovtdec: remove unused variable
Matthew Waters [Mon, 28 Mar 2022 09:37:54 +0000 (20:37 +1100)]
vtdec: remove unused variable

Fixes:

../sys/applemedia/vtdec.c:611:35: error: variable 'output_flags' set but not used [-Werror,-Wunused-but-set-variable]
  VTDecodeFrameFlags input_flags, output_flags;
                                  ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoavsamplevideosink: remove unused variable
Matthew Waters [Mon, 28 Mar 2022 09:24:59 +0000 (20:24 +1100)]
avsamplevideosink: remove unused variable

Fixes

../sys/applemedia/avsamplevideosink.m:80:20: error: variable 'gstelement_class' set but not used [-Werror,-Wunused-but-set-variable]
  GstElementClass *gstelement_class;
                   ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoavfassetsrc: fix unused-but-set warning
Matthew Waters [Mon, 28 Mar 2022 09:11:29 +0000 (20:11 +1100)]
avfassetsrc: fix unused-but-set warning

../sys/applemedia/avfassetsrc.m:1014:12: error: variable 'caps' set but not used [-Werror,-Wunused-but-set-variable]
  GstCaps *caps;
           ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agospeed: fix unused-but-set warning
Matthew Waters [Mon, 28 Mar 2022 08:42:04 +0000 (19:42 +1100)]
speed: fix unused-but-set warning

../gst/speed/gstspeed.c:523:39: error: variable 'base' set but not used [-Werror,-Wunused-but-set-variable]
      gint64 start_value, stop_value, base;
                                      ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoresindvd: silence unused-but-set warning
Matthew Waters [Mon, 28 Mar 2022 07:38:23 +0000 (18:38 +1100)]
resindvd: silence unused-but-set warning

../ext/resindvd/gstpesfilter.c:117:11: error: variable 'STD_buffer_size_bound' set but not used [-Werror,-Wunused-but-set-variable]
  guint16 STD_buffer_size_bound;
          ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agompegts: don't shadow res variable
Matthew Waters [Mon, 28 Mar 2022 07:23:20 +0000 (18:23 +1100)]
mpegts: don't shadow res variable

Fixes unused-but-set warning:

../gst/mpegtsmux/gstbasetsmux.c:2115:43: error: variable 'res' set but not used [-Werror,-Wunused-but-set-variable]
      gboolean all_headers, done = FALSE, res = FALSE;
                                          ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agompeg: fix unused-but-set warning
Matthew Waters [Mon, 28 Mar 2022 07:12:43 +0000 (18:12 +1100)]
mpeg: fix unused-but-set warning

../gst-libs/gst/mpegts/gst-dvb-section.c:206:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
  guint i = 0, allocated_events = 12;
        ^
../gst-libs/gst/mpegts/gst-dvb-section.c:365:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
  guint i = 0, allocated_streams = 12;
        ^
../gst-libs/gst/mpegts/gst-dvb-section.c:543:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
  guint i = 0, allocated_streams = 12;
        ^
../gst-libs/gst/mpegts/gst-dvb-section.c:885:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
  guint i = 0, allocated_services = 8;
        ^
../gst-libs/gst/mpegts/gst-dvb-section.c:1316:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
  guint i = 0, allocated_services = 8;
        ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoosxcoreaudio: fix unused-but-set warning
Matthew Waters [Mon, 28 Mar 2022 07:12:03 +0000 (18:12 +1100)]
osxcoreaudio: fix unused-but-set warning

../sys/osxaudio/gstosxcoreaudio.c:480:18: error: variable 'interleaved' set but not used [-Werror,-Wunused-but-set-variable]
  gboolean sign, interleaved;
                 ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agovideo-format: Move NV12_8L128 into the correct position in GST_VIDEO_FORMATS_ALL
Sebastian Dröge [Mon, 28 Mar 2022 07:10:45 +0000 (10:10 +0300)]
video-format: Move NV12_8L128 into the correct position in GST_VIDEO_FORMATS_ALL

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2045>

2 years agompegdemux: silence unused-but-set werror
Matthew Waters [Mon, 28 Mar 2022 04:56:22 +0000 (15:56 +1100)]
mpegdemux: silence unused-but-set werror

../gst/mpegdemux/gstpesfilter.c:117:11: error: variable 'STD_buffer_size_bound' set but not used [-Werror,-Wunused-but-set-variable]
  guint16 STD_buffer_size_bound;
          ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2044>

2 years agoFix GstAmcSurfaceTexture segfault
Andrew Pritchard [Fri, 25 Mar 2022 03:25:02 +0000 (14:25 +1100)]
Fix GstAmcSurfaceTexture segfault
Check that `self` and `self->callback` are defined. `self` can be set to
`NULL` in `remove_listener`, and `self->callback` can be set to `NULL`
inside `gst_amc_surface_texture_jni_set_on_frame_available_callback`.
This can cause a segfault since the Java object can outlive the C
object, and call the callback after `remove_listener` is called.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2024>

2 years agoexamples/player/android: add missing dummy.cpp
Matthew Waters [Mon, 28 Mar 2022 03:36:24 +0000 (14:36 +1100)]
examples/player/android: add missing dummy.cpp

allows libc++_shared.so to be placed in the application

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2043>

2 years agodeinterlace: silence unused-but-set werror from imported code
Matthew Waters [Mon, 28 Mar 2022 02:35:17 +0000 (13:35 +1100)]
deinterlace: silence unused-but-set werror from imported code

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2042>

2 years agoexamples/player/android: update for android changes
Matthew Waters [Mon, 28 Mar 2022 02:28:56 +0000 (13:28 +1100)]
examples/player/android: update for android changes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2041>

2 years agoosxvideosink: fix unused-but-set-variable warning
Matthew Waters [Sun, 27 Mar 2022 22:50:38 +0000 (09:50 +1100)]
osxvideosink: fix unused-but-set-variable warning

../sys/osxvideo/osxvideosink.m:859:11: error: variable 'data' set but not used [-Werror,-Wunused-but-set-variable]
  guint8 *data, *readp, *writep;
          ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2040>

2 years agorawvideoparse: set format from caps in gst_raw_video_parse_set_config_from_caps
Corentin Damman [Wed, 16 Mar 2022 10:31:56 +0000 (10:31 +0000)]
rawvideoparse: set format from caps in gst_raw_video_parse_set_config_from_caps

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1970>

2 years agoglmixerbin: slightly better pad/element creation
Matthew Waters [Sun, 27 Mar 2022 05:35:14 +0000 (16:35 +1100)]
glmixerbin: slightly better pad/element creation

Use the return value from gst_element_link_pads() and gst_bin_add()

Fixes:

../ext/gl/gstglmixerbin.c:305:12: error: variable 'res' set but not used [-Werror,-Wunused-but-set-variable]
  gboolean res = TRUE;
           ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2038>

2 years agoccconverter: ensure correct ordering of cea608 across output buffers
Matthew Waters [Wed, 23 Mar 2022 06:31:37 +0000 (17:31 +1100)]
ccconverter: ensure correct ordering of cea608 across output buffers

e.g. if a 60fps output is configured, we can only produce a single field
of cea608 that must alternate between field 1 and field 2.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2019>

2 years agoccconverter: ignore padding cea608 data even if marked as 'valid'
Matthew Waters [Wed, 23 Mar 2022 04:13:10 +0000 (15:13 +1100)]
ccconverter: ignore padding cea608 data even if marked as 'valid'

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2019>

2 years agov4l2codecs: Detect missing M2M_HOLD_CAPTURE_BUF
Nicolas Dufresne [Wed, 23 Mar 2022 14:36:28 +0000 (10:36 -0400)]
v4l2codecs: Detect missing M2M_HOLD_CAPTURE_BUF

Produce an error if we try to use the feature of holding capture buffer
but it is not supported by the driver. Ingoring this can lead to stalls
as the driver will run-out of capture buffer to decode into. This
affects slice decoders but also split-field interlaced decoding.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2009>

2 years agov4l2codecs: h264: Set other field poc if available
Nicolas Dufresne [Wed, 23 Mar 2022 13:11:35 +0000 (09:11 -0400)]
v4l2codecs: h264: Set other field poc if available

Whenever the other field POC is available, pass it back to the
driver. This should not be strictly required, but it makes things
easier to debug and more forgiven.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2009>

2 years agov4l2codecs: Trace request by it FD
Nicolas Dufresne [Tue, 21 Dec 2021 15:59:37 +0000 (10:59 -0500)]
v4l2codecs: Trace request by it FD

This helps when crossing the debug logs with the kernel logs.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2009>