Duncan P. N. Exon Smith [Thu, 15 Oct 2020 22:17:17 +0000 (18:17 -0400)]
SourceManager: Factor out helpers for common SLocEntry lookup pattern, NFC
Add helpers `getSLocEntryOrNull`, which handles the `Invalid` logic
around `getSLocEntry`, and `getSLocEntryForFile`, which also checks for
`SLocEntry::isFile`, and use them to reduce repeated code.
Differential Revision: https://reviews.llvm.org/D89503
Shilei Tian [Fri, 23 Oct 2020 01:21:41 +0000 (21:21 -0400)]
[OpenMP] Fixed a potential integer overflow
`size_t` has different width on 32- and 64-bit architecture, but the
computation to floor to power of two assumed it is 64-bit, which can cause an
integer overflow. In this patch, architecture detection is added so that the
operation for 64-bit `size_t`. Thank Luke for reporting the issue.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D89878
Han Shen [Fri, 23 Oct 2020 00:26:01 +0000 (17:26 -0700)]
Revert "[MBP] Add whole chain to BlockFilterSet instead of individual BB"
This reverts commit
adfb5415010fbbc009a4a6298cfda7a6ed4fa6d4.
This is reverted because it caused an chrome error: https://crbug.com/1140168
Richard Smith [Fri, 23 Oct 2020 00:02:28 +0000 (17:02 -0700)]
Fix constant evaluation of zero-initialization of a union whose first
FieldDecl is an unamed bitfield.
Unnamed bitfields aren't non-static data member, so such a bitfield
isn't actually the first non-static data member.
Nick Desaulniers [Thu, 22 Oct 2020 23:29:17 +0000 (16:29 -0700)]
BitCodeFormat: update doc on new byref and mustprogress attrs; NFC
Forked from review of:
https://reviews.llvm.org/D87956
Louis Dionne [Thu, 22 Oct 2020 23:11:33 +0000 (19:11 -0400)]
[libc++abi] Fix the standalone build after the __config_site change
In
5d796645, we stopped looking at the LIBCXXABI_LIBCXX_INCLUDES variable,
which broke users of the Standalone build. This patch reinstates that
variable, however it must point to the *installed* path of the libc++
headers, not the libc++ headers in the source tree (which has always
been the case, but wasn't enforced before).
If LIBCXXABI_LIBCXX_INCLUDES points to the libc++ headers in the source
tree, the `__config_site` header will fail to be found.
Wei Mi [Thu, 15 Oct 2020 22:17:28 +0000 (15:17 -0700)]
[NFC][SampleFDO] Move some common stuff from SampleProfileReaderExtBinary/WriterExtBinary
to their parent classes.
SampleProfileReaderExtBinary/SampleProfileWriterExtBinary specify the typical
section layout currently used by SampleFDO. Currently a lot of section
reader/writer stay in the two classes. However, as we expect to have more
types of SampleFDO profiles, we hope those new types of profiles can share
the common sections while configuring their own sections easily with minimal
change. That is why I move some common stuff from
SampleProfileReaderExtBinary/SampleProfileWriterExtBinary to
SampleProfileReaderExtBinaryBase/SampleProfileWriterExtBinaryBase so new
profiles class inheriting from the base class can reuse them.
Differential Revision: https://reviews.llvm.org/D89524
David Blaikie [Thu, 22 Oct 2020 22:43:39 +0000 (15:43 -0700)]
DebugInfo: Use llc rather than %llc_dwarf when also hardcoding a target triple
Jessica Paquette [Tue, 20 Oct 2020 20:17:39 +0000 (13:17 -0700)]
[AArch64][GlobalISel] Move imm adjustment for G_ICMP to post-legalizer lowering
Move the code which adjusts the immediate/predicate on a G_ICMP to
AArch64PostLegalizerLowering.
This
- Reduces the number of places we need to test for optimized compares in the
selector. We know that the compare should have been simplified by the time it
hits the selector, so we can avoid testing this in selects, brconds, etc.
- Allows us to potentially fold more compares (previously, this optimization
was only done after calling `tryFoldCompare`, this may allow us to hit some more
TST cases)
- Simplifies the selection code in `emitIntegerCompare` significantly; we can
just use an emitSUBS function.
- Allows us to avoid checking that the predicate has been updated after
`emitIntegerCompare`.
Also add a utility header file for things that may be useful in the selector
and various combiners. No need for an implementation file at this point, since
it's just one constexpr function for now. I've run into a couple cases where
having one of these would be handy, so might as well add it here. There are
a couple functions in the selector that can probably be factored out into
here.
Differential Revision: https://reviews.llvm.org/D89823
Fangrui Song [Thu, 22 Oct 2020 22:26:52 +0000 (15:26 -0700)]
[ELF] --warn-backrefs: save the referenced InputFile *
For a diagnostic `A refers to B` where B refers to a bitcode file, if the
symbol gets optimized out, the user may see `A refers to <internal>`; if the
symbol is retained, the user may see `A refers to lto.tmp`.
Save the reference InputFile * in the DenseMap so that the original filename is
available in reportBackrefs().
Nico Weber [Thu, 22 Oct 2020 22:16:09 +0000 (18:16 -0400)]
[gn build] (semi-manually) port
147b9497e79
Jessica Paquette [Mon, 19 Oct 2020 17:17:15 +0000 (10:17 -0700)]
[AArch64][GlobalISel] Split post-legalizer combiner to allow for lowering at -O0
There are a lot of combines in AArch64PostLegalizerCombiner which exist to
facilitate instruction matching in the selector. (E.g. matching for G_ZIP and
other shuffle vector pseudos)
It still makes sense to select these instructions at -O0.
Matching earlier in a combiner can reduce complexity in the selector
significantly. For example, a good portion of our selection code for compares
would be a lot easier to represent in a combine.
This patch moves matching combines into a "AArch64PostLegalizerLowering"
combiner which runs at all optimization levels.
Also, while we're here, improve the documentation for the
AArch64PostLegalizerCombiner, and fix up the filepath in its file comment.
And also add a 'r' which somehow got dropped from a bunch of function names.
https://reviews.llvm.org/D89820
Yitzhak Mandelbaum [Thu, 22 Oct 2020 14:03:59 +0000 (14:03 +0000)]
[libTooling] Add function to Transformer to create a no-op edit.
This functionality is commonly needed in clang tidy checks (based on
transformer) that only print warnings, without suggesting any edits. The no-op
edit allows the user to associate a diagnostic message with a source location.
Differential Revision: https://reviews.llvm.org/D89961
Jan Korous [Thu, 22 Oct 2020 21:18:13 +0000 (14:18 -0700)]
[SourceManager] Avoid copying SLocEntry in computeMacroArgsCache
Follow-up to
e7870223d8b5
Differential Revision: https://reviews.llvm.org/D86230
LemonBoy [Thu, 22 Oct 2020 21:13:07 +0000 (14:13 -0700)]
[clang][Frontend] Add missing error handling
Some early errors during the ASTUnit creation were not transferred to the `FailedParseDiagnostic` so when the code in `LoadFromCommandLine` swaps its content with the content of `StoredDiagnostics` they cannot be retrieved by the user in any way.
Reviewed By: andrewrk, dblaikie
Differential Revision: https://reviews.llvm.org/D78658
Louis Dionne [Thu, 22 Oct 2020 21:03:33 +0000 (17:03 -0400)]
[libc++] Allow running the tests in the experimental runtimes-only build
Alexander Shaposhnikov [Thu, 22 Oct 2020 20:25:13 +0000 (13:25 -0700)]
[llvm-objcopy][MachO] Fix the calculation of the output size
Virtual sections do not contribute to the final output size.
This diff fixes the corresponding calculations in the method MachOWriter::totalSize.
Test plan: make check-all
Differential revision: https://reviews.llvm.org/D89661
Kostya Kortchinsky [Thu, 22 Oct 2020 20:40:12 +0000 (13:40 -0700)]
[GWP-ASan] Move random-related code in the allocator (redo)
This is a redo of D89908, which triggered some `-Werror=conversion`
errors with GCC due to assignments to the 31-bit variable.
This CL adds to the original one a 31-bit mask variable that is used
at every assignment to silence the warning.
Differential Revision: https://reviews.llvm.org/D89984
Nikita Popov [Thu, 22 Oct 2020 20:40:06 +0000 (22:40 +0200)]
[DomTree] Make assert more precise
Per asbirlea's comment, assert that only instructions, constants
and arguments are passed to this API. Simplify returning true
would not be correct for special Value subclasses like MemoryAccess.
Nikita Popov [Thu, 22 Oct 2020 19:50:18 +0000 (21:50 +0200)]
[BasicAA] Only add visited phi blocks temporarily
Visited phi blocks only need to be added for the duration of the
recursive alias queries, they should not leak into following code.
Once again, while this also improves analysis precision, this is
mainly intended to clarify the applicability scope of VisitedPhiBBs.
Xiangling Liao [Wed, 21 Oct 2020 20:50:36 +0000 (16:50 -0400)]
[AIX] Emit error for -G option on AIX
1. Emit error for -G driver option on AIX
2. Adjust cmake file to use -Wl,-G instead of -G
On AIX, legacy XL compiler uses -G to produce a shared object enabled
for use with the run-time linker, which has different meanings from what
it is used for in Clang. And in Clang, other targets do not have -G map
to another functionality in their legacy compiler. So this error is more
important when we are on AIX.
Differential Revision: https://reviews.llvm.org/D89897
Nikita Popov [Thu, 22 Oct 2020 19:44:09 +0000 (21:44 +0200)]
[BasicAA] Don't track visited blocks for phi-phi alias query
We only need the VisitedPhiBBs to disambiguate comparisons of
values from two different loop iterations. If we're comparing
two phis from the same basic block in lock-step, the compared
values will always be on the same iteration.
While this also increases precision, this is mainly intended
to clarify the scope of VisitedPhiBBs.
Venkataramanan Kumar [Thu, 22 Oct 2020 20:00:34 +0000 (16:00 -0400)]
Initial support for vectorization using Libmvec (GLIBC vector math library)
Differential Revision: https://reviews.llvm.org/D88154
Nikita Popov [Thu, 22 Oct 2020 19:56:37 +0000 (21:56 +0200)]
Revert "[GWP-ASan] Move random-related code in the allocator"
This reverts commit
9903b0586cfb76ef2401c342501e61e1bd3daa0f.
Causes build failures (on GCC 10.2) with the following error:
In file included from /home/nikic/llvm-project/compiler-rt/lib/scudo/standalone/combined.h:29,
from /home/nikic/llvm-project/compiler-rt/lib/scudo/standalone/allocator_config.h:12,
from /home/nikic/llvm-project/compiler-rt/lib/scudo/standalone/wrappers_cpp.cpp:14:
/home/nikic/llvm-project/compiler-rt/lib/scudo/standalone/../../gwp_asan/guarded_pool_allocator.h: In member function ‘bool gwp_asan::GuardedPoolAllocator::shouldSample()’:
/home/nikic/llvm-project/compiler-rt/lib/scudo/standalone/../../gwp_asan/guarded_pool_allocator.h:82:69: error: conversion from ‘uint32_t’ {aka ‘unsigned int’} to ‘unsigned int:31’ may change value [-Werror=conversion]
82 | (getRandomUnsigned32() % (AdjustedSampleRatePlusOne - 1)) + 1;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Nikita Popov [Wed, 21 Oct 2020 07:32:17 +0000 (09:32 +0200)]
[BasicAA] Add additional phi tests (NFC)
Kirill Bobyrev [Thu, 22 Oct 2020 19:47:48 +0000 (21:47 +0200)]
[clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC
Reviewed By: kadircet
Differential Revision: https://reviews.llvm.org/D89852
Jan Korous [Wed, 19 Aug 2020 05:34:37 +0000 (22:34 -0700)]
[SourceManager] Skip module maps when searching files for macro arguments
Differential Revision: https://reviews.llvm.org/D86230
Kirill Bobyrev [Thu, 22 Oct 2020 19:15:20 +0000 (21:15 +0200)]
[clangd] Give the server information about client's remote index protocol version
And also introduce Protobuf package versioning, it will help to deal
with breaking changes. Inroducing package version itself is a breaking
change, clients and servers need to be updated.
Reviewed By: sammccall
Differential Revision: https://reviews.llvm.org/D89862
Vedant Kumar [Thu, 22 Oct 2020 19:24:15 +0000 (12:24 -0700)]
[test] HotColdSplit: cover use of opaque pointer type
Add a test to cover the case where an extracted block contains a
lifetime marker for a pointer with an opaque type.
Vedant Kumar [Thu, 22 Oct 2020 18:11:12 +0000 (11:11 -0700)]
Revert "[CodeExtractor] Don't create bitcasts when inserting lifetime markers (NFCI)"
This reverts commit
26ee8aff2b85ee28a2b2d0b1860d878b512fbdef.
It's necessary to insert bitcast the pointer operand of a lifetime
marker if it has an opaque pointer type.
rdar://
70560161
Lei Zhang [Thu, 22 Oct 2020 19:20:42 +0000 (15:20 -0400)]
Revert "Revert "[mlir] Convert from Async dialect to LLVM coroutines""
This reverts commit
4986d5eaff359081a867def1c6a2e1147dbb2ad6 with
proper patches to CMakeLists.txt:
- Add MLIRAsync as a dependency to MLIRAsyncToLLVM
- Add Coroutines as a dependency to MLIRExecutionEngine
Mehdi Amini [Thu, 22 Oct 2020 19:11:56 +0000 (19:11 +0000)]
Revert "[mlir] Convert from Async dialect to LLVM coroutines"
This reverts commit
a8b0ae3bddee311cbc97801089a95702f32773f8
and commit
f8fcff5a9d7ee948add3f28382d4ced5710edaaf.
The build with SHARED_LIBRARY=ON is broken.
Arthur Eubanks [Thu, 22 Oct 2020 05:55:34 +0000 (22:55 -0700)]
Port -instnamer to NPM
Some clang tests use this.
Reviewed By: akhuang
Differential Revision: https://reviews.llvm.org/D89931
David Blaikie [Thu, 22 Oct 2020 18:47:35 +0000 (11:47 -0700)]
DWARFv5: Disable DW_OP_convert for configurations that don't yet support it
Testing reveals that lldb and gdb have some problems with supporting
DW_OP_convert - gdb with Split DWARF tries to resolve the CU-relative
DIE offset relative to the skeleton DIE. lldb tries to treat the offset
as absolute, which judging by the llvm-dsymutil support for
DW_OP_convert, I guess works OK in MachO? (though probably llvm-dsymutil
is producing invalid DWARF by resolving the relative reference to an
absolute one?).
Specifically this disables DW_OP_convert usage in DWARFv5 if:
* Tuning for GDB and using Split DWARF
* Tuning for LLDB and not targeting MachO
Kostya Kortchinsky [Wed, 21 Oct 2020 20:04:09 +0000 (13:04 -0700)]
[GWP-ASan] Move random-related code in the allocator
We need to have all thread specific data packed into a single `uintptr_t`
for the upcoming Fuchsia support. We can move the `RandomState` into the
`ThreadLocalPackedVariables`, reducing the size of `NextSampleCounter`
to 31 bits (or we could reduce `RandomState` to 31 bits).
We move `getRandomUnsigned32` into the platform agnostic part of the
class, and `initPRNG` in the platform specific part.
`ScopedBoolean` is replaced by actual assignments since non-const
references to bitfields are prohibited.
`random.{h,cpp}` are removed.
Differential Revision: https://reviews.llvm.org/D89908
Louis Dionne [Thu, 22 Oct 2020 18:43:41 +0000 (14:43 -0400)]
[libc++] Drop old workaround for iostreams instantiations missing from the dylib
On old Apple platforms (pre 10.9), we couldn't rely on the iostreams
explicit instantiations being part of the dylib. However, we don't
support back-deploying to such old deployment targets anymore, so the
workaround can be dropped.
Layton Kifer [Thu, 22 Oct 2020 18:42:09 +0000 (20:42 +0200)]
[InstCombine][NFC] Use ConstantExpr::getBinOpIdentity
Delete duplicate implementation getSelectFoldableConstant and
replace with ConstantExpr::getBinOpIdentity.
Differential Revision: https://reviews.llvm.org/D89839
Jay Foad [Fri, 16 Oct 2020 12:54:19 +0000 (13:54 +0100)]
[PatternMatch] Add new FP matchers. NFC.
This adds matchers m_NonNaN, m_NonInf, m_Finite and m_NonZeroFP as well
as generic support for binding the matched value to an APFloat.
I tried to follow the existing convention of using an FP suffix for
predicates like zero and non-zero, which could be confused with the
integer versions, but not for predicates which are clearly already
FP-specific.
Differential Revision: https://reviews.llvm.org/D89038
Nikita Popov [Sat, 17 Oct 2020 13:54:52 +0000 (15:54 +0200)]
[MemCpyOpt] Move GEP during call slot optimization
When performing a call slot optimization to a GEP destination, it
will currently usually fail, because the GEP is directly before the
memcpy and as such does not dominate the call. We should move it
above the call if that satisfies the domination requirement.
I think that a constant-index GEP is the only useful thing to move
here, as otherwise isDereferenceablePointer couldn't look through
it anyway. As such I'm not trying to generalize this further.
Differential Revision: https://reviews.llvm.org/D89623
Ettore Tiotto [Thu, 22 Oct 2020 17:59:32 +0000 (13:59 -0400)]
[NFC][PartialInliner]: Clean up code
Make member function const where possible, use LLVM_DEBUG to print debug traces
rather than a custom option, pass by reference to avoid null checking, ...
Reviewed By: fhann
Differential Revision: https://reviews.llvm.org/D89895
Tom Stellard [Thu, 22 Oct 2020 18:33:58 +0000 (11:33 -0700)]
HowToReleaseLLVM: Clean up document and remove references to SVN
Reviewed By: hans
Differential Revision: https://reviews.llvm.org/D80395
Sanjay Patel [Thu, 22 Oct 2020 17:18:38 +0000 (13:18 -0400)]
[InstSimplify] add tests for ctpop constant range; NFC
Jonathan Crowther [Thu, 22 Oct 2020 18:13:26 +0000 (14:13 -0400)]
[SystemZ][z/OS] Set short-enums as the default for z/OS
This patch sets short-enums to be the default for z/OS.
Reviewed By: abhina.sreeskantharajan
Differential Revision: https://reviews.llvm.org/D89801
Duncan P. N. Exon Smith [Thu, 15 Oct 2020 02:34:19 +0000 (22:34 -0400)]
clang/Basic: Remove ContentCache::getRawBuffer, NFC
Replace `ContentCache::getRawBuffer` with `getBufferDataIfLoaded` and
`getBufferIfLoaded`, excising another accessor for the underlying
`MemoryBuffer*` in favour of `StringRef` and `MemoryBufferRef`.
Differential Revision: https://reviews.llvm.org/D89445
Paul C. Anagnostopoulos [Thu, 22 Oct 2020 14:20:10 +0000 (10:20 -0400)]
[TableGen] Update documents to make them more complete
Differential Revision: https://reviews.llvm.org/D89962
Vedant Kumar [Tue, 20 Oct 2020 18:59:26 +0000 (11:59 -0700)]
[InstCombine] Remove dbg.values describing contents of dead allocas
When InstCombine removes an alloca, it erases the dbg.{addr,declare}
instructions which refer to the alloca. It would be better to instead
remove all debug intrinsics which describe the contents of the dead
alloca, namely all dbg.value(<dead alloca>, ..., DW_OP_deref)'s.
This effectively undoes work performed in an InstCombine run earlier in
the pipeline by LowerDbgDeclare, which inserts DW_OP_deref dbg.values
before CallInst users of an alloca. The motivating example looks like:
```
define void @foo(i32 %0) {
%a = alloca i32 ; This alloca is erased.
store i32 %0, i32* %a
dbg.value(i32 %0, "arg0") ; This dbg.value survives.
dbg.value(i32* %a, "arg0", DW_OP_deref)
call void @trivially_inlinable_no_op(i32* %a)
ret void
}
```
If the DW_OP_deref dbg.value is not erased, it becomes dbg.value(undef)
after inlining, making "arg0" unavailable. But we already have dbg.value
descriptions of the alloca's value (from LowerDbgDeclare), so the
DW_OP_deref dbg.value cannot serve its purpose of describing an
initialization of the alloca by some callee. It invalidates other useful
dbg.values, causing large gaps in location coverage, so we should delete
it (even though doing so may cause stale dbg.values to appear, if
there's a dead store to `%a` in @trivially_inlinable_no_op).
OTOH, it wouldn't be correct to delete all dbg.value descriptions of an
alloca. Note that it's possible to describe a variable that takes on
different pointer values, e.g.:
```
void use(int *);
void t(int a, int b) {
int *local = &a; // dbg.value(i32* %a.addr, "local")
local = &b; // dbg.value(i32* undef, "local")
use(&a); // (note: %b.addr is optimized out)
local = &a; // dbg.value(i32* %a.addr, "local")
}
```
In this example, the alloca for "b" is erased, but we need to describe
the value of "local" as <unavailable> before the call to "use". This
prevents "local" from appearing to be equal to "&a" at the callsite.
rdar://
66592859
Differential Revision: https://reviews.llvm.org/D85555
Matt Arsenault [Thu, 22 Oct 2020 16:10:36 +0000 (12:10 -0400)]
AMDGPU: Cleanup MIR test
Remove registers section and compact block/register numbers
Arthur Eubanks [Thu, 22 Oct 2020 16:49:42 +0000 (09:49 -0700)]
Revert "[Docs] Clarify that FunctionPasses can't add/remove declarations"
This reverts commit
710676cf3a3c6f6ddf2f18e24cac017d20dac1ff.
Fangrui Song [Thu, 22 Oct 2020 16:48:04 +0000 (09:48 -0700)]
[ELF] Set SHF_INFO_LINK for .rel[a].plt and .rel[a].dyn
The ELF spec says
> If the sh_flags field for this section header includes the attribute SHF_INFO_LINK, then this member represents a section header table index.
Set SHF_INFO_LINK so that binary manipulation tools know that sh_info is
a section header table index instead of (the number of local symbols in the case of SHT_SYMTAB/SHT_DYNSYM).
We have already added SHF_INFO_LINK for --emit-relocs retained SHT_REL[A].
For example, we can teach llvm-objcopy to preserve the section index of the sh_info referenced section if
SHF_INFO_LINK is set. (GNU objcopy recognizes .rel[a].plt and updates
sh_info even if SHF_INFO_LINK is not set).
Reviewed By: grimar, psmith
Differential Revision: https://reviews.llvm.org/D89828
Raphael Isemann [Thu, 22 Oct 2020 16:42:19 +0000 (18:42 +0200)]
Revert "[lldb] Explicitly use the configuration architecture when building test executables"
This reverts commit
41185226f6d80663b4a1064c6f47581ee567d78d.
Causes TestQuoting to fail on Windows.
Nikita Popov [Sat, 17 Oct 2020 18:54:53 +0000 (20:54 +0200)]
[DomTree] Accept Value as Def (NFC)
Non-instruction defs like arguments, constants or global values
always dominate all instructions/uses inside the function. This
case currently needs to be treated separately by the caller, see
https://reviews.llvm.org/D89623#inline-832818 for an example.
This patch makes the dominator tree APIs accept a Value instead of
an Instruction and always returns true for the non-Instruction case.
A complication here is that BasicBlocks are also Values. For that
reason we can't support the dominates(Value *, BasicBlock *)
variant, as it would conflict with dominates(BasicBlock *, BasicBlock *),
which has different semantics. For the other two APIs we assert
that the passed value is not a BasicBlock.
Differential Revision: https://reviews.llvm.org/D89632
Florian Hahn [Thu, 22 Oct 2020 08:39:05 +0000 (09:39 +0100)]
[SLP] Add tests with selects that can be turned into min/max.
AArch64 does not have a flexible vector select instruction. In some
cases, the selects can be turned into min/max however, for which there
are dedicated vector instructions on AArch64.
This patch adds some tests for such cases.
Tim Corringham [Tue, 28 Jul 2020 18:01:03 +0000 (19:01 +0100)]
[AMDGPU] Add amdgpu specific loop threshold metadata
Add new loop metadata amdgpu.loop.unroll.threshold to allow the initial AMDGPU
specific unroll threshold value to be specified on a loop by loop basis.
The intention is to be able to to allow more nuanced hints, e.g. specifying a
low threshold value to indicate that a loop may be unrolled if cheap enough
rather than using the all or nothing llvm.loop.unroll.disable metadata.
Differential Revision: https://reviews.llvm.org/D84779
Arthur Eubanks [Sun, 18 Oct 2020 20:35:58 +0000 (13:35 -0700)]
[gn build] Add missing clangd dependencies
Fixes
$ ninja obj/build/rel/gen/clang-tools-extra/clangd/CompletionModel.CompletionModel.obj
Some tablegen include files from clang/include/clang/AST and
clang/include/clang/Sema need to be generated before CompletionModel is
compiled.
Reviewed By: thakis
Differential Revision: https://reviews.llvm.org/D89657
Arthur Eubanks [Wed, 21 Oct 2020 15:55:50 +0000 (08:55 -0700)]
[Docs] Clarify that FunctionPasses can't add/remove declarations
In preparation for potential future concurrency, a FunctionPass
shouldn't modify anything at the module level that other FunctionPasses
can also modify.
Reviewed By: asbirlea
Differential Revision: https://reviews.llvm.org/D89890
Med Ismail Bennani [Wed, 21 Oct 2020 01:54:48 +0000 (03:54 +0200)]
[lldb/DWARF] Add support for DW_OP_implicit_value
This patch completes https://reviews.llvm.org/D83560. Now that the
compiler can emit `DW_OP_implicit_value` into DWARF expressions, lldb
needed to learn reading these opcodes for variable inspection and
expression evaluation.
This implicit location descriptor specifies an immediate value with two
operands: the length (ULEB128) followed by a block representing the value
in the target memory representation.
rdar://
67406091
Differential revision: https://reviews.llvm.org/D89842
Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Marco Antognini [Mon, 12 Oct 2020 14:17:03 +0000 (15:17 +0100)]
[OpenCL] Remove unused extensions
Many non-language extensions are defined but also unused. This patch
removes them with their tests as they do not require compiler support.
The cl_khr_select_fprounding_mode extension is also removed because it
has been deprecated since OpenCL 1.1 and Clang doesn't have any specific
support for it.
The cl_khr_context_abort extension is only referred to in "The OpenCL
Specification", version 1.2 and 2.0, in Table 4.3, but no specification
is provided in "The OpenCL Extension Specification" for these versions.
Because it is both unused in Clang and lacks specification, this
extension is removed.
The following extensions are platform extensions that bring new OpenCL
APIs but do not impact the kernel language nor require compiler support.
They are therefore removed.
- cl_khr_gl_sharing, introduced in OpenCL 1.0
- cl_khr_icd, introduced in OpenCL 1.2
- cl_khr_gl_event, introduced in OpenCL 1.1
Note: this extension adds a new API to create cl_event but it also
specifies that these can only be used by clEnqueueAcquireGLObjects.
Hence, they cannot be used on the device side and the extension does
not impact the kernel language.
- cl_khr_d3d10_sharing, introduced in OpenCL 1.1
- cl_khr_d3d11_sharing, introduced in OpenCL 1.2
- cl_khr_dx9_media_sharing, introduced in OpenCL 1.2
- cl_khr_image2d_from_buffer, introduced in OpenCL 1.2
- cl_khr_initialize_memory, introduced in OpenCL 1.2
- cl_khr_gl_depth_images, introduced in OpenCL 1.2
Note: this extension is related to cl_khr_depth_images but only the
latter adds new features to the kernel language.
- cl_khr_spir, introduced in OpenCL 1.2
- cl_khr_egl_event, introduced in OpenCL 1.2
Note: this extension adds a new API to create cl_event but it also
specifies that these can only be used by clEnqueueAcquire* API
functions. Hence, they cannot be used on the device side and the
extension does not impact the kernel language.
- cl_khr_egl_image, introduced in OpenCL 1.2
- cl_khr_terminate_context, introduced in OpenCL 1.2
The minimum required OpenCL version used in OpenCLExtensions.def for
these extensions is not always correct. Removing these address that
issue.
Reviewed By: Anastasia
Differential Revision: https://reviews.llvm.org/D89372
Aaron En Ye Shi [Thu, 22 Oct 2020 15:07:47 +0000 (15:07 +0000)]
[HIP] Fix HIP rounding math intrinsics
The __ocml_*_rte_f32 and __ocml_*_rte_f64 functions are not
available if OCML_BASIC_ROUNDED_OPERATIONS is not defined.
Reviewed By: b-sumner, yaxunl
Fixes: SWDEV-257235
Differential Revision: https://reviews.llvm.org/D89966
Mircea Trofin [Wed, 21 Oct 2020 20:59:45 +0000 (13:59 -0700)]
[NFC][MC] Use MCRegister for ReachingDefAnalysis APIs
Also updated the users of the APIs; and a drive-by small change to
RDFRegister.cpp
Differential Revision: https://reviews.llvm.org/D89912
Arthur Eubanks [Thu, 22 Oct 2020 05:08:58 +0000 (22:08 -0700)]
[LoopRotate][NPM] Disable header duplication under -Oz
It was already disabled under -Oz in
buildFunctionSimplificationPipeline(), but not in
buildModuleOptimizationPipeline()/addPGOInstrPasses().
Reviewed By: fhahn
Differential Revision: https://reviews.llvm.org/D89927
Jonas Devlieghere [Thu, 22 Oct 2020 15:32:05 +0000 (08:32 -0700)]
[lldb] Fix a regression introduced by D75730
In a new Range class was introduced to simplify and the Disassembler API
and reduce duplication. It unintentionally broke the
SBFrame::Disassemble functionality because it unconditionally converts
the number of instructions to a Range{Limit::Instructions,
num_instructions}. This is subtly different from the previous behavior,
where now we're passing a Range and assume it's valid in the callee, the
original code would propagate num_instructions and the callee would
compare the value and decided between disassembling instructions or
bytes.
Unfortunately the existing tests was not particularly strict:
disassembly = frame.Disassemble()
self.assertNotEqual(len(disassembly), 0, "Disassembly was empty.")
This would pass because without this patch we'd disassemble zero
instructions, resulting in an error:
(lldb) script print(lldb.frame.Disassemble())
error: error reading data from section __text
Differential revision: https://reviews.llvm.org/D89925
Eugene Zhulenev [Thu, 22 Oct 2020 15:17:53 +0000 (08:17 -0700)]
[mlir] Do not start threads in AsyncRuntime
pthreads is not enabled for all builds by default
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D89967
Teresa Johnson [Tue, 29 Sep 2020 22:31:11 +0000 (15:31 -0700)]
[MemProf] Allow the binary to specify the profile output filename
This will allow the output directory to be specified by a build time
option, similar to the directory specified for regular PGO profiles via
-fprofile-generate=. The memory profiling instrumentation pass will
set up the variable. This is the same mechanism used by the PGO
instrumentation and runtime.
Depends on D87120 and D89629.
Differential Revision: https://reviews.llvm.org/D89086
Christian Sigg [Thu, 22 Oct 2020 05:43:34 +0000 (07:43 +0200)]
[mlir][gpu] NFC: switch occurrences of gpu.launch_func to custom format.
Reviewed By: herhut
Differential Revision: https://reviews.llvm.org/D89929
Piotr Sobczak [Thu, 22 Oct 2020 14:28:33 +0000 (16:28 +0200)]
[AMDGPU] Fix expansion of i16 MULH
This commit marks i16 MULH as expand in AMDGPU backend,
which is necessary after the refactoring in D80485.
Differential Revision: https://reviews.llvm.org/D89965
Florian Hahn [Thu, 22 Oct 2020 15:02:55 +0000 (16:02 +0100)]
[AArch64] Add min/max cost-model tests for v2i32.
Evgeny Leviant [Thu, 22 Oct 2020 15:03:01 +0000 (18:03 +0300)]
[ARM][SchedModels] Convert IsLdstsoScaledPred to MCSchedPredicate
Differential revision: https://reviews.llvm.org/D89939
Simon Pilgrim [Thu, 22 Oct 2020 14:46:09 +0000 (15:46 +0100)]
[X86] X86AsmParser - make methods const where possible. NFCI.
Reported by cppcheck
Simon Pilgrim [Thu, 22 Oct 2020 13:53:30 +0000 (14:53 +0100)]
[X86] Return const& in IntelExprStateMachine::getIdentifierInfo(). NFCI.
Avoid unnecessary copy in X86AsmParser::ParseIntelOperand
Jeremy Morse [Thu, 22 Oct 2020 14:47:09 +0000 (15:47 +0100)]
[DebugInstrRef] Pass DBG_INSTR_REFs through register allocation
Both FastRegAlloc and LiveDebugVariables/greedy need to cope with
DBG_INSTR_REFs. None of them actually need to take any action, other than
passing DBG_INSTR_REFs through: variable location information doesn't refer
to any registers at this stage.
LiveDebugVariables stashes the instruction information in a tuple, then
re-creates it later. This is only necessary as the register allocator
doesn't expect to see any debug instructions while it's working. No
equivalence classes or interval splitting is required at all!
No changes are needed for the fast register allocator, as it just ignores
debug instructions. The test added checks that both of them preserve
DBG_INSTR_REFs.
This also expands ScheduleDAGInstrs.cpp to treat DBG_INSTR_REFs the same as
DBG_VALUEs when rescheduling instructions around. The current movement of
DBG_VALUEs around is less than ideal, but it's not a regression to make
DBG_INSTR_REFs subject to the same movement.
Differential Revision: https://reviews.llvm.org/D85757
Florian Hahn [Thu, 22 Oct 2020 14:47:38 +0000 (15:47 +0100)]
[AArch64] Add min/max cost-model tests for v4i16.
Raphael Isemann [Thu, 22 Oct 2020 13:31:34 +0000 (15:31 +0200)]
[lldb] Fix TestTargetAPI.py on Apple simulators
This test checks that the output of `SBTarget.GetDescription()` contains the
substrings `'a.out', 'Target', 'Module', 'Breakpoint'` in that order. This test
is currently failing on Apple simulators as apparently 'Module' can't be found
in the output after 'Target".
The reason for that is that the actual output of `SBTarget.GetDescription()` looks like this:
```
Target
Module /build/path/lldb-test-build.noindex/python_api/target/TestTargetAPI.test_get_description_dwarf/a.out
0x7ff2b6d3f990: ObjectFileMachO64, file = /build/path/lldb-test-build.noindex/python_api/target/TestTargetAPI.test_get_description
[...]
0x7ff307150000: BreakpointList with 0 Breakpoints:
<LLDB module output repeats for each loaded module>
```
Clearly the string order should be `'Target', 'Module', 'a.out', 'Breakpoint'`.
However, LLDB is also a bunch of system shared libraries (libxpc.dylib,
libobjc.A.dylib, etc.) when *not* running against a simulator, we end up
unintentionally finding the `'Target', 'Module', 'Breakpoint'` substrings in the
trailing descriptions of the system modules. When running against a simulator we
however don't load shared system libraries.
This patch just moves the substrings in the correct order to make this test pass
without having any shared library modules in the description output.
Reviewed By: JDevlieghere
Differential Revision: https://reviews.llvm.org/D89698
Matt Arsenault [Thu, 15 Oct 2020 22:53:56 +0000 (18:53 -0400)]
AMDGPU: Fix not always reserving VGPRs used for SGPR spilling
The VGPRs used for SGPR spills need to be reserved, even if we aren't
speculatively reserving one.
This was broken by
117e5609e98b43f925c678b72f816ad3a1c3eee7.
Matt Arsenault [Thu, 15 Oct 2020 13:56:11 +0000 (09:56 -0400)]
AMDGPU: Implement getNoPreservedMask
We don't support funclets for exception handling and I hit this when
manually reducing MIR.
Matt Arsenault [Thu, 15 Oct 2020 14:44:50 +0000 (10:44 -0400)]
ScheduleDAGInstrs: Skip debug instructions at end of scheduling region
If the end instruction of the scheduling region was a DBG_VALUE, the
uses of the debug instruction were tracked as if they were real
uses. This would then hit the deadDefHasNoUse assertion in
addVRegDefDeps if the only use was the debug instruction.
Jeremy Morse [Thu, 22 Oct 2020 13:50:45 +0000 (14:50 +0100)]
Limit debug instr-referencing tests to X86
The instruction referencing work currently only works on X86, and all the
tests for it will be X86 based for the time being. Configure the whole
directory to be X86-only, seeing how I keep on landing tests that don't
have the correct REQUIRES lines.
Jon Chesterfield [Thu, 22 Oct 2020 14:02:44 +0000 (15:02 +0100)]
[OpenMP] Emit calls to int64_t functions for amdgcn
[OpenMP] Emit calls to int64_t functions for amdgcn
Two functions, syncwarp and active_thread_mask, return lanemask_t. Currently
this is assumed to be int32, which is true for nvptx. Patch makes the type
target architecture dependent.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D89746
Paul C. Anagnostopoulos [Mon, 19 Oct 2020 13:20:54 +0000 (09:20 -0400)]
[TableGen] Continue improving the comments for the data structures.
Differential Revision: https://reviews.llvm.org/D89901
Eugene Zhulenev [Thu, 22 Oct 2020 12:59:05 +0000 (05:59 -0700)]
[mlir] Convert from Async dialect to LLVM coroutines
Lower from Async dialect to LLVM by converting async regions attached to `async.execute` operations into LLVM coroutines (https://llvm.org/docs/Coroutines.html):
1. Outline all async regions to functions
2. Add LLVM coro intrinsics to mark coroutine begin/end
3. Use MLIR conversion framework to convert all remaining async types and ops to LLVM + Async runtime function calls
All `async.await` operations inside async regions converted to coroutine suspension points. Await operation outside of a coroutine converted to the blocking wait operations.
Implement simple runtime to support concurrent execution of coroutines.
Reviewed By: herhut
Differential Revision: https://reviews.llvm.org/D89292
Raphael Isemann [Thu, 22 Oct 2020 13:10:22 +0000 (15:10 +0200)]
[lldb] Explicitly use the configuration architecture when building test executables
The Darwin builder currently assumes in `getArchCFlags` that the passed `arch`
value is an actual string it can string.join with vendor/os/version/env strings:
```
triple = '-'.join([arch, vendor, os, version, env])
```
However this is not true for most tests as we just pass down the `arch=None`
default value from `TestBase.build`. This causes that if we actually end up in
this function we just error out when concatenating `None` with the other actual
strings of vendor/os/version/env. What we should do instead is check that if
there is no test-specific architecture that we fall back to the configuration's
architecture value.
It seems we already worked around this in `builder.getArchSpec` by explicitly
falling back to the architecture specified in the configuration.
This patch just moves this fallback logic to the top `build` function so that it
affects all functions called from `TestBase.build`.
Reviewed By: JDevlieghere
Differential Revision: https://reviews.llvm.org/D89056
Paul C. Anagnostopoulos [Wed, 21 Oct 2020 15:58:06 +0000 (11:58 -0400)]
[Clang] [TableGen] Clean up !if(!eq(bool, 1) and related booleans
Differential Revision: https://reviews.llvm.org/D89893
Simon Pilgrim [Thu, 22 Oct 2020 13:27:19 +0000 (14:27 +0100)]
[CodeGen] Split MVT::changeTypeToInteger() functionality from EVT::changeTypeToInteger().
Add the MVT equivalent handling for EVT changeTypeToInteger/changeVectorElementType/changeVectorElementTypeToInteger.
All the SimpleVT code already exists inside the EVT equivalents, but by splitting this out we can use these directly inside MVT types without converting to/from EVT.
Evgeny Leviant [Thu, 22 Oct 2020 13:21:40 +0000 (16:21 +0300)]
[llvm-mca] Add few ldm* instructions to cortex-a57 test case
Alexander Belyaev [Thu, 22 Oct 2020 12:48:52 +0000 (14:48 +0200)]
[mlir] Add MemRefReinterpretCastOp definition to Standard.
Reuse most code for printing/parsing/verification from SubViewOp.
https://llvm.discourse.group/t/rfc-standard-memref-cast-ops/1454/15
Differential Revision: https://https://reviews.llvm.org/D89720
Raphael Isemann [Thu, 22 Oct 2020 11:50:22 +0000 (13:50 +0200)]
[lldb][NFC] Make GetShellSafeArgument return std::string and unittest it.
Florian Hahn [Thu, 22 Oct 2020 10:47:43 +0000 (11:47 +0100)]
[AArch64] Add cost model tests for min/max intrinsics.
Jeremy Morse [Thu, 22 Oct 2020 12:18:55 +0000 (13:18 +0100)]
Test I added requires X86 to be built.
This the second time I've stepped on this landmine, I'll look at setting
a lit local config. All the tests in this dir are going to be X86 for now.
Jeremy Morse [Thu, 22 Oct 2020 11:48:57 +0000 (12:48 +0100)]
[DebugInstrRef] Substitute debug value numbers to handle optimizations
This patch touches two optimizations, TwoAddressInstruction and X86's
FixupLEAs pass, both of which optimize by re-creating instructions. For
LEAs, various bits of arithmetic are better represented as LEAs on X86,
while TwoAddressInstruction sometimes converts instrs into three address
instructions if it's profitable.
For debug instruction referencing, both of these require substitutions to
be created -- the old instruction number must be pointed to the new
instruction number, as illustrated in the added test. If this isn't done,
any variable locations based on the optimized instruction are
conservatively dropped.
Differential Revision: https://reviews.llvm.org/D85756
David Zarzycki [Thu, 22 Oct 2020 11:50:00 +0000 (07:50 -0400)]
[x86 testing] NFC: Create exhaustive vector popcnt ULT/UGT tests
There are bunch of optimization opportunities right now in the vector
popcnt code gen when doing simple less-than/greater-than comparisons, so
let's examine them all to ensure that things don't regress as different
scenarios are fixed. We can always delete some later once some fixes are
made.
Please note: the new files were auto-generated. If people want, I can
commit the short C code that printed out the various combinations.
Alexander Kornienko [Thu, 22 Oct 2020 11:30:30 +0000 (13:30 +0200)]
[clang-tidy] Add links to check docs in comments
Alexander Belyaev [Wed, 21 Oct 2020 19:05:06 +0000 (21:05 +0200)]
[mlir] Add MemRefReshapeOp definition to Standard.
https://llvm.discourse.group/t/rfc-standard-memref-cast-ops/1454/15
Differential Revision: https://reviews.llvm.org/D89784
Max Kazantsev [Thu, 22 Oct 2020 10:29:15 +0000 (17:29 +0700)]
[SCEV][NFC] Simplify internals of BackedgeTakenInfo
Luís Marques [Thu, 22 Oct 2020 10:34:03 +0000 (11:34 +0100)]
[RISCV][NFC] Add more tests for 32-bit constant materialization
The existing tests were mostly for 64-bit constants.
Differential Revision: https://reviews.llvm.org/D83210
LLVM GN Syncbot [Thu, 22 Oct 2020 09:39:53 +0000 (09:39 +0000)]
[gn build] Port
be39a6fe6fc
Max Kazantsev [Thu, 22 Oct 2020 09:25:16 +0000 (16:25 +0700)]
[SCEV][NFC] Rename MaxAndComplete -> ConstantMaxAndComplete
This better reflects what this variable is about.
Tianqing Wang [Thu, 22 Oct 2020 08:46:07 +0000 (16:46 +0800)]
[X86] Add User Interrupts(UINTR) instructions
For more details about these instructions, please refer to the latest
ISE document:
https://software.intel.com/en-us/download/intel-architecture-instruction-set-extensions-programming-reference.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D89301
Evgeny Leviant [Thu, 22 Oct 2020 09:08:08 +0000 (12:08 +0300)]
[llvm-mca] Improve test case
Mikhail Goncharov [Fri, 9 Oct 2020 10:23:48 +0000 (12:23 +0200)]
[libc++] Update continous integration scripts
Now libc++ pipeline will be triggered from the "premerge-checks" and the
combined result are going to be returned to Harbormaster.
Reviewed-by: ldionne
Differential Revision: https://reviews.llvm.org/D89113
Max Kazantsev [Thu, 22 Oct 2020 08:12:54 +0000 (15:12 +0700)]
[SCEV][NFC] Rename getMax -> getConstantMax
This better reflects what this logic actually does.
Max Kazantsev [Thu, 22 Oct 2020 07:57:36 +0000 (14:57 +0700)]
Revert "[DWARFLinker] Capitalize type names (NFC)"
This reverts commit
3fce5ea7ce663410d3fb533528158bdab3a3604e.
`make check` broken.