Simon McVittie [Wed, 25 May 2011 15:51:23 +0000 (16:51 +0100)]
Merge branch 'dbus-1.4'
Simon McVittie [Wed, 25 May 2011 15:50:09 +0000 (16:50 +0100)]
NEWS
Simon McVittie [Tue, 18 Jan 2011 16:34:12 +0000 (16:34 +0000)]
handle_server_data_anonymous_mech: remove unnecessary debug output
Doing a malloc and a hex-encoding pass just to produce a _dbus_verbose
message (i.e. a message that, in practice, nobody will see) seems like
overkill, and this block had incorrect error handling (not checking the
result of _dbus_string_init) which upsets static analysis tools.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29881
Bug-NB: NB#180486
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
Simon McVittie [Tue, 18 Jan 2011 16:29:53 +0000 (16:29 +0000)]
dbus-launch: pass_info: always free strings on OOM
This doesn't really do anything, because we're about to exit anyway, but
it placates static analysis tools.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29881
Bug-NB: NB#180486
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
Simon McVittie [Wed, 26 Jan 2011 18:40:49 +0000 (18:40 +0000)]
dbus-send: remove minor dead code
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33128
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
Simon McVittie [Wed, 26 Jan 2011 18:38:01 +0000 (18:38 +0000)]
dbus_connection_dispatch: remove dead code
There's no way pending can be non-NULL here; if it was, we'd have jumped
straight past this block (getting filters from the connection), because
replies to pending calls don't go through filters.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33128
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
Ralf Habacker [Sun, 22 May 2011 18:33:47 +0000 (20:33 +0200)]
Spelling fix.
Ralf Habacker [Sun, 22 May 2011 14:53:48 +0000 (16:53 +0200)]
Ralf Habacker [Sun, 22 May 2011 11:02:34 +0000 (13:02 +0200)]
To avoid double dbus version definitions take values from configure.ac.
Simon McVittie [Tue, 22 Feb 2011 13:42:46 +0000 (13:42 +0000)]
DBusNonceFile: don't always fail when use_subdir=TRUE, i.e. on Unix
In shell-like pseudocode, the desired result is:
if $use_subdir
dir = $tmpdir/dbus_nonce-$random
path = $dir/nonce
mkdir $dir
write file at $path
else
dir = $user_owned_place
path = $dir/dbus_nonce-$random
write file at $path
However, /nonce was accidentally appended to $dir instead of $path,
resulting in an attempt to mkdir /tmp/dbus_nonce-XXXX/nonce when
dbus_nonce-XXXX hadn't been created yet.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34569
Tested-by: David Zeuthen <davidz@redhat.com>
Reviewed-by: David Zeuthen <davidz@redhat.com>
Simon McVittie [Wed, 25 May 2011 15:02:43 +0000 (16:02 +0100)]
Relax review criteria for the review cabal themselves, as discussed on-list
Colin agreed in principle and nobody actually objected, so here we go...
Simon McVittie [Wed, 25 May 2011 15:01:57 +0000 (16:01 +0100)]
Add davidz to the review cabal
Acked-by: Will Thompson <will.thompson@collabora.co.uk>
Acked-by: Colin Walters <walters@verbum.org>
Simon McVittie [Wed, 25 May 2011 14:25:45 +0000 (15:25 +0100)]
fix verb-subject agreement in ObjectManager spec
David Zeuthen [Tue, 8 Mar 2011 15:41:26 +0000 (10:41 -0500)]
Add org.freedesktop.DBus.ObjectManager interface
The org.freedesktop.DBus.ObjectManager provides a standardized and
efficient way of keeping one or more tree of objects synchronized
between one server and several clients.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34869
Signed-off-by: David Zeuthen <davidz@redhat.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Sun, 22 May 2011 21:01:13 +0000 (23:01 +0200)]
Added cmake 'help-options' target to print out all available configure options
Ralf Habacker [Sun, 22 May 2011 20:53:37 +0000 (22:53 +0200)]
Cleaned public cmake option naming.
Ralf Habacker [Sun, 22 May 2011 18:33:47 +0000 (20:33 +0200)]
Spelling fix.
Ralf Habacker [Sun, 22 May 2011 14:53:48 +0000 (16:53 +0200)]
Ralf Habacker [Sun, 22 May 2011 11:02:34 +0000 (13:02 +0200)]
To avoid double dbus version definitions take values from configure.ac.
Simon McVittie [Tue, 3 May 2011 09:27:52 +0000 (10:27 +0100)]
Merge branch 'dbus-1.4'
Simon McVittie [Thu, 3 Mar 2011 17:02:23 +0000 (17:02 +0000)]
dbus_connection_can_send_type: clarify that invalid codes are allowed here
This is sufficiently unusual that it seems worth saying explicitly
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35182
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Simon McVittie [Fri, 29 Apr 2011 14:45:20 +0000 (15:45 +0100)]
Merge branch 'dbus-1.4'
Simon McVittie [Fri, 29 Apr 2011 14:44:35 +0000 (15:44 +0100)]
NEWS
Will Thompson [Fri, 12 Feb 2010 19:19:05 +0000 (19:19 +0000)]
minotaur: bail if asked to monitor >1 bus
A coworker was just tripped up by `dbus-monitor --session --system` only
monitoring the system bus. This patch would have saved him reproducing a
tricky bug several times!
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=26548
Reviewed-by: Colin Walters <walters@verbum.org>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Wed, 27 Apr 2011 17:05:19 +0000 (18:05 +0100)]
NEWS for 1.5
Simon McVittie [Tue, 26 Apr 2011 15:06:58 +0000 (16:06 +0100)]
Clarify that 'r' and 'e' cannot appear in signatures
Reviewed-by: Colin Walters <walters@verbum.org>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34529
Simon McVittie [Tue, 26 Apr 2011 16:14:23 +0000 (17:14 +0100)]
Reserve 'm', '*', '?', '@', '&' and '^' for their uses in GVariant
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34529
Reviewed-by: Colin Walters <walters@verbum.org>
Simon McVittie [Wed, 27 Apr 2011 16:59:35 +0000 (17:59 +0100)]
Merge branch 'dbus-1.4'
Simon McVittie [Wed, 27 Apr 2011 16:59:28 +0000 (17:59 +0100)]
NEWS for 1.4
Lennart Poettering [Fri, 11 Mar 2011 01:58:39 +0000 (02:58 +0100)]
machine-id: fall back to reading /etc/machine-id if D-Bus machine ID is not available
Newer systemd-based systems support a global machine ID with the same
metrics as the D-Bus machine ID, but more powerful semantics (for
example on ro media) in /etc/machine-id.
If the D-Bus machine ID cannot be read, fall back to the systemd machine
ID.
This is a first step towards allowing D-Bus to be started up during
early boot where /var is not available.
[plus a whitespace fix -smcv]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Colin Walters <walters@verbum.org>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35228
Simon McVittie [Mon, 21 Mar 2011 10:16:28 +0000 (10:16 +0000)]
_dbus_check_fdleaks_enter, _dbus_check_fdleaks_leave: whitespace
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35173
Reviewed-by: Colin Walters <walters@verbum.org>
Simon McVittie [Mon, 14 Mar 2011 16:53:23 +0000 (16:53 +0000)]
Don't report file descriptors as "leaked" if they were already open
This is necessary to run the regression tests under valgrind (if
telling it to output to a dedicated fd), gdb, fakeroot etc.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35173
Reviewed-by: Colin Walters <walters@verbum.org>
Simon McVittie [Tue, 26 Apr 2011 18:20:18 +0000 (19:20 +0100)]
Merge branch 'dbus-1.4'
Conflicts:
NEWS
Simon McVittie [Tue, 26 Apr 2011 18:19:24 +0000 (19:19 +0100)]
NEWS
Simon McVittie [Tue, 26 Apr 2011 18:18:35 +0000 (19:18 +0100)]
Merge remote-tracking branch 'origin/dbus-1.4' into dbus-1.4
Simon McVittie [Tue, 26 Apr 2011 18:17:29 +0000 (19:17 +0100)]
NEWS
Simon McVittie [Thu, 2 Dec 2010 13:21:04 +0000 (13:21 +0000)]
dbus-1.pc.in: move -lpthread, -lrt, Winsock to Libs.private
"Private libraries are libraries which are not exposed through your
library, but are needed in the case of static linking" -- pkg-config(1)
Reviewed-by: Colin Walters <walters@verbum.org>
Simon McVittie [Tue, 26 Apr 2011 18:15:18 +0000 (19:15 +0100)]
Merge branch 'dbus-1.4'
Simon McVittie [Tue, 26 Apr 2011 18:15:09 +0000 (19:15 +0100)]
NEWS
Colin Walters [Sat, 26 Mar 2011 19:52:50 +0000 (15:52 -0400)]
activation: Use _dbus_system_log for activation information
Log when we are activating something (and whether it's via systemd)
as well as when we fail to activate, and when one succeeds.
https://bugs.freedesktop.org/show_bug.cgi?id=35705
Simon McVittie [Tue, 4 Jan 2011 19:12:46 +0000 (19:12 +0000)]
Add dbus-1-uninstalled.pc.in
See: http://smcv.pseudorandom.co.uk/2008/09/pc-uninstalled/
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32827
Reviewed-by: Colin Walters <walters@verbum.org>
Simon McVittie [Tue, 26 Apr 2011 18:05:53 +0000 (19:05 +0100)]
Merge branch 'dbus-1.4'
Conflicts:
NEWS
Simon McVittie [Mon, 21 Feb 2011 17:13:12 +0000 (17:13 +0000)]
Add support for --disable-gc-sections for broken toolchains
Also use AC_LINK_IFELSE rather than reinventing it as a shell function.
This was the last user of ld_supports_flag, so, delete it.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33466
Reviewed-by: Colin Walters <walters@verbum.org>
Simon McVittie [Mon, 21 Feb 2011 16:33:29 +0000 (16:33 +0000)]
Drop outdated list of options from README, mention configure --help instead
Simon McVittie [Mon, 21 Feb 2011 16:34:13 +0000 (16:34 +0000)]
Release notes for the -fPIE change
Simon McVittie [Mon, 21 Feb 2011 16:23:24 +0000 (16:23 +0000)]
Don't force use of -fPIE for the dbus-daemon if apparently supported
It's a minor security benefit, but not automatically beneficial (it
enables ASLR, but breaks prelinking, some buggy toolchains, and some gdb
versions). Distributions who know their infrastructure works well can
enable it just as easily via
./configure CFLAGS="-fPIE" LDFLAGS="-pie"
without extra support from us, and that's a generic solution applicable to
many packages.
Similarly, don't force libdbus and libdbus-internal to be PIC: libtool
knows better than we do whether that's necessary/beneficial on a
particular platform.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=16621
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27215
Bug-NB: NB#171940
Reviewed-by: Colin Walters <walters@verbum.org>
Simon McVittie [Tue, 22 Mar 2011 12:11:27 +0000 (12:11 +0000)]
Install dbus-daemon and dbus-daemon-launch-helper in the conventional way
Also remove some pointless indirection (extra_tests etc.), don't install
the unused directory $(libexecdir)/dbus-1 (we actually install the
launch helper directly into $(libexecdir)), and allow dbus_daemondir to be
set on Windows rather than forcing dbus-daemon to be installed to
$(bindir) there.
dbus_daemon_execdir has to contain "exec" so that the dbus-daemon will be
installed by "make install-exec" and not "make install-data".
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=14512
Reviewed-by: Colin Walters <walters@verbum.org>
Will Thompson [Thu, 14 Apr 2011 17:18:25 +0000 (18:18 +0100)]
dbus_bus_add_match: improve error documentation.
It's simply not true that the only possible error is a lack of resources
in the bus.
Simon McVittie [Tue, 12 Apr 2011 10:27:09 +0000 (11:27 +0100)]
Merge branch 'dbus-1.4'
Simon McVittie [Mon, 11 Apr 2011 11:04:19 +0000 (12:04 +0100)]
When uploading docs, use rsync -p to set permissions
It turns out that rsync --chmod means "pretend the source files had
already had this chmod operation applied to them", and not "chmod the
destination files" like you'd expect.
As a result, the -p (--perms) option is also needed, so that rsync will
"preserve" the modified permissions. Otherwise, the docs will not be
group-writeable as intended, and only the person who made the previous
upload will be able to upload them next time.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=36130
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Simon McVittie [Mon, 11 Apr 2011 18:04:30 +0000 (19:04 +0100)]
Development version: 1.5.1, dbus-specification 0.17
Simon McVittie [Mon, 11 Apr 2011 12:34:28 +0000 (13:34 +0100)]
Prepare 1.5.0
- D-Bus Specification 0.16
- libtool 9:0:6
Simon McVittie [Fri, 8 Apr 2011 14:23:17 +0000 (15:23 +0100)]
Merge branch 'dbus-1.4'
Conflicts:
NEWS
Simon McVittie [Fri, 8 Apr 2011 14:22:31 +0000 (15:22 +0100)]
development version
Simon McVittie [Fri, 8 Apr 2011 13:30:23 +0000 (14:30 +0100)]
Prepare version 1.4.8
Colin Walters [Mon, 28 Mar 2011 17:21:35 +0000 (13:21 -0400)]
activation: Strip out code to compare by Exec=
In commit:
075945f6 (John (J5) Palmieri 2005-07-14 20:44:15 +0000
some code was added to compare services by Exec key. The changelog is
not pariticularly informative as to why this was added. But while
debugging other code, we noticed this.
Comparing by Exec key is not in the specification, and triggered a
problem where while converting services to use systemd for activation,
a change was made to use Exec=/bin/false and simply rely on systemd
to activate.
While I think it was broken for the service files to be changed
to Exec=/bin/false, we shouldn't be doing something here that's
not in the spec either.
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35750
Simon McVittie [Thu, 7 Apr 2011 17:27:52 +0000 (18:27 +0100)]
oops, fix XML mis-nesting
Sven Herzberg [Thu, 7 Apr 2011 17:25:34 +0000 (18:25 +0100)]
list which parts of the Desktop Entry spec apply to service files
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19159
Simon McVittie [Thu, 7 Apr 2011 16:16:01 +0000 (17:16 +0100)]
Merge branch 'arg0namespace-24317'
Reviewed-by: David Zeuthen <davidz@redhat.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=24317
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=31818
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34870
Simon McVittie [Thu, 7 Apr 2011 16:15:41 +0000 (17:15 +0100)]
Merge branch 'dbus-1.4'
Simon McVittie [Thu, 7 Apr 2011 15:31:06 +0000 (16:31 +0100)]
Mention dbus-specification.xml's separate versioning in HACKING
Simon McVittie [Thu, 7 Apr 2011 15:30:41 +0000 (16:30 +0100)]
Check parsing (or otherwise) of path_namespace in match rules
Simon McVittie [Thu, 7 Apr 2011 12:13:56 +0000 (13:13 +0100)]
Remove support for trailing "." on arg0namespace
Simon McVittie [Thu, 7 Apr 2011 15:12:22 +0000 (16:12 +0100)]
Rename path_prefix to path_namespace and disallow trailing '/'
Also disallow having both path and path_namespace in the same match rule
(it wouldn't make sense, path is more specific than path_namespace).
As per IRC discussion with davidz and wjt.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34870
Simon McVittie [Thu, 7 Apr 2011 14:27:01 +0000 (15:27 +0100)]
Document when arg0namespace was added, for completeness
Simon McVittie [Thu, 7 Apr 2011 14:26:49 +0000 (15:26 +0100)]
Document when argNpath was added, for completeness
Simon McVittie [Thu, 7 Apr 2011 13:46:04 +0000 (14:46 +0100)]
specification: fix versioning
We've added things since 0.15, so this isn't still 0.15.
Simon McVittie [Thu, 7 Apr 2011 13:45:19 +0000 (14:45 +0100)]
path_prefix: anchor matches at path-component boundaries, and give examples
It seems wrong that path_prefix="/foo" matches /foobar, and it isn't
difficult or expensive to check.
David Zeuthen [Tue, 8 Mar 2011 15:32:34 +0000 (10:32 -0500)]
Add path_prefix match rule
Add a new path_prefix match rule that can be used for efficient
implementations of the org.freedesktop.DBus.ObjectManager interface
(see bug 34869).
https://bugs.freedesktop.org/show_bug.cgi?id=34870
Signed-off-by: David Zeuthen <davidz@redhat.com>
Simon McVittie [Thu, 7 Apr 2011 12:12:02 +0000 (13:12 +0100)]
re-word description of arg0namespace
It's unclear at first reading whether "may contain only one element"
means "elements >= 1, as an exception to the usual rule that
elements >= 2" (which is what was intended), or "elements == 1".
"Like a bus name or interface name" is a little ambiguous because they
have different syntactic restrictions: specifically allow any valid bus
name, which also allows all interface names.
Simon McVittie [Thu, 7 Apr 2011 11:41:52 +0000 (12:41 +0100)]
signals.h: rename argument in declaration to match implementation
Simon McVittie [Thu, 7 Apr 2011 11:40:30 +0000 (12:40 +0100)]
Merge remote-tracking branch 'wjt/arg0namespace' into arg0namespace-24317
Simon McVittie [Mon, 14 Mar 2011 11:45:04 +0000 (11:45 +0000)]
Break up the monster conditional in config-parser so gcov can cope
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=10887
Reviewed-by: Colin Walters <walters@verbum.org>
Simon McVittie [Mon, 14 Mar 2011 12:02:19 +0000 (12:02 +0000)]
Update NEWS for master
Simon McVittie [Mon, 14 Mar 2011 11:58:36 +0000 (11:58 +0000)]
Merge branch 'dbus-1.4'
Simon McVittie [Mon, 14 Mar 2011 11:58:28 +0000 (11:58 +0000)]
Update NEWS
Simon McVittie [Mon, 14 Mar 2011 11:53:24 +0000 (11:53 +0000)]
Merge branch 'dbus-1.4', rejecting all changes
This commit changes nothing, but means that merge tracking won't try to
apply the reversion of
d1d395774435..
09c9d6406b75f to master in future.
Simon McVittie [Mon, 14 Mar 2011 11:53:09 +0000 (11:53 +0000)]
Revert merge of master (dbus-1.5) into dbus-1.4
This reverts commits
d1d395774435..
09c9d6406b75f, keeping Lennart's
addition of UnknownInterface etc.
Lennart Poettering [Thu, 10 Mar 2011 03:10:31 +0000 (04:10 +0100)]
connection: hook UnknownObject and UnknownInterface up where appropriate
This makes use of UnknownInterface and UnknownObject where appropriate
in the D-Bus core.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34527
Reviewed-By: Simon McVittie <simon.mcvittie@collabora.co.uk>
Lennart Poettering [Thu, 10 Mar 2011 03:06:32 +0000 (04:06 +0100)]
protocol: introduce four new errors
UnknownInterface, UnknownObject, UnknownProperty and PropertyReadOnly,
as discussed on the ML.
The first two are already used by various bindings, such as the Qt and
Java binding, but have never been made official.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34527
Reviewed-by: David Zeuthen <davidz@redhat.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Thu, 3 Mar 2011 17:35:14 +0000 (17:35 +0000)]
Make dbus_type_is_valid into public API
This is just as useful for bindings as dbus_signature_validate, and I
think it's a good design principle to say that anything checked in a
_dbus_return_if_fail should be something the caller could check
for themselves.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=20496
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Simon McVittie [Thu, 10 Mar 2011 19:07:15 +0000 (19:07 +0000)]
Merge branch 'dbus-1.4'
Simon McVittie [Thu, 10 Mar 2011 13:06:09 +0000 (13:06 +0000)]
add doxygen.stamp to .gitignore
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35182
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Simon McVittie [Thu, 3 Mar 2011 16:55:55 +0000 (16:55 +0000)]
_dbus_marshal_write_fixed_multi: remove obsolete FIXME comment
As far as I can tell, we've never accepted out-of-range booleans and
canonicalized them, ever since this was first committed in 2004. If sent,
they'd be considered to be invalid by recipients, so they're unambiguously
an error.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35182
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Simon McVittie [Thu, 3 Mar 2011 16:30:43 +0000 (16:30 +0000)]
dbus_message_iter_append_basic: remove misleading documentation
This function specifically doesn't support Unix fds and is documented as
such.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35182
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Simon McVittie [Thu, 10 Mar 2011 18:42:12 +0000 (18:42 +0000)]
Implement uninstallation and cleanup for Doxygen docs, fixing distcheck
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Simon McVittie [Thu, 10 Mar 2011 18:59:26 +0000 (18:59 +0000)]
Merge branch 'validate-when-sending-16338' into dbus-1.4
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Simon McVittie [Thu, 3 Mar 2011 16:51:56 +0000 (16:51 +0000)]
dbus_type_is_basic etc.: it is an error to pass in bad typecodes
Previously, the comments said "this function will crash", but that's not
strictly true (checks can be disabled or made non-fatal). Their behaviour
is undefined if you do that, though.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=20496
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Simon McVittie [Tue, 8 Mar 2011 13:32:06 +0000 (13:32 +0000)]
Require specific user action to compile without 64-bit support
The D-Bus type system isn't implementable without 64-bit support, although
for historical reasons we have some sort of semi-working support for
platforms with no 64-bit integers. Let's find out whether any
practically relevant platform still lacks these types...
(GLib appears to have required 64-bit integer types since 2001.)
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35114
Reviewed-by: Lennart Poettering <lennart@poettering.net>
Simon McVittie [Thu, 10 Mar 2011 12:15:56 +0000 (12:15 +0000)]
Merge branch 'dbus-1.4'
Lennart Poettering [Thu, 10 Mar 2011 02:56:23 +0000 (03:56 +0100)]
autogen: add -I m4 to aclocal path
This fixes
2b5959882a403cddba754b37b58bdc49bff01f90 which forgot to add
m4/ to the command line of aclocal but moved scripts there.
Simon McVittie [Tue, 8 Mar 2011 12:35:46 +0000 (12:35 +0000)]
Merge branch 'dbus-1.4'
Simon McVittie [Tue, 8 Mar 2011 12:35:39 +0000 (12:35 +0000)]
Update NEWS
Simon McVittie [Mon, 7 Mar 2011 14:51:46 +0000 (14:51 +0000)]
Merge branch 'dbus-1.4'
Simon McVittie [Mon, 7 Mar 2011 13:55:10 +0000 (13:55 +0000)]
Fix some more stray occurrences of ELEMENT_TYPE
Andre Heinecke [Mon, 7 Mar 2011 10:43:23 +0000 (11:43 +0100)]
Do not use the name ELEMENT_TYPE
On Windows Systems ELEMENT_TYPE is already defined
in Winioctl.h this header is included indirectly
in dbus-sysdeps.h. By avoiding the use of the Name
ELEMENT_TYPE it is ensured that config-parser-common.h
can be included together with dbus-sysdeps.h
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Thu, 3 Mar 2011 16:30:00 +0000 (16:30 +0000)]
dbus_message_iter_append_fixed_array: add a check for valid booleans
The reasoning is the same as for dbus_message_iter_append_basic.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=16338
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
Simon McVittie [Thu, 3 Mar 2011 16:29:17 +0000 (16:29 +0000)]
dbus_message_iter_append_basic: validate booleans too
Sending, for instance, ((dbus_bool_t) 666) is a programming error and
should be diagnosed as such.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=16338
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
Simon McVittie [Wed, 16 Feb 2011 17:44:48 +0000 (17:44 +0000)]
dbus_message_iter_append_basic: check string-like arguments for validity
Strings: UTF-8 with no embedded NULs, by adding a new internal function,
_dbus_check_is_valid_utf8
Object paths, signatures: the obvious syntactic checks
This moves some of the burden of validation to the sender.
When sending <http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-demo.txt>
10240 times with up to 1024 parallel calls pending, on a single-core ARM
Linux device, I found that user CPU time in dbus-spam increased by up to 80%
as a result of the validation. However, when sending messages to dbus-daemon,
overall throughput only reduced by 15%, and when sending messages to an echo
service, overall throughput actually improved by around 14% (presumably
because making the sender CPU-bound influenced kernel scheduling).
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=16338
Bug-NB: NB#223152
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
Simon McVittie [Fri, 25 Feb 2011 15:49:55 +0000 (15:49 +0000)]
Merge branch 'dbus-1.4'
Conflicts:
NEWS