Seungbae Shin [Fri, 1 Oct 2021 12:09:58 +0000 (21:09 +0900)]
core, sink-input: dump sink-input info when it exceeds the maximum connection
+ fix minor warning
[Version] 13.0-36
[Issue Type] Debugging
Change-Id: Ia33d4fc0507630576b1305acff64633853a99de3
Seungbae Shin [Mon, 28 Dec 2020 07:44:25 +0000 (16:44 +0900)]
protocol-native, client: dump current connections on every new incoming connection
[Version] 13.0-35
[Issue Type] Debugging
Change-Id: I4078d1f7c8da1d4afbe4f472298aaf7f184c62e6
Seungbae Shin [Mon, 6 Sep 2021 11:15:18 +0000 (20:15 +0900)]
Allow permission if the process that setting stream volume is identical to stream creater
[Version] 13.0-34
[Issue Type] Bug fix
Change-Id: I739c602d6e63a4228cc4eaef9a16a27dd2078171
Georg Chini [Mon, 4 Jan 2021 20:08:05 +0000 (21:08 +0100)]
loopback: Fix sink latency calculation if source is alsa source with fixed latency
When an alsa source with fixed latency is used, the actual latency of the source
will only be one fragment size. This is not taken into account when the required
sink latency is calculated.
This patch fixes the issue.
[jungsup4.lee: backport mainline commit 0efae0]
[Version] 13.0-33
[Issue Type] Bug fix
Change-Id: If8b7aa3735c1a2456fa50f55b267180fa2efd1a1
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/451>
Seungbae Shin [Tue, 17 Aug 2021 09:10:46 +0000 (18:10 +0900)]
mutex-posix: fix svace defects (SIGN_EXTENSION)
[Version] 13.0-32
[Issue Type] Svace
Change-Id: Ibb61bbf8d069f869a695b40fa3c7db29be44c68f
Georg Chini [Mon, 19 Apr 2021 06:19:50 +0000 (08:19 +0200)]
loopback: Fix crash bug
The loopback message may be called after the sink input is already destroyed which causes
a crash. Also memory is leaked because the message object is not correctly freed.
This patch fixes the problems by adding a "dead" flag to the message structure and freeing
the message object on exit.
[jcsing.lee: backport mainline commit
468e3669a for fixing crash]
[Version] 13.0-31
[Issue Type] Bug fix
Change-Id: Id5ce55554fadda9cffeca698685897a88f45c2cb
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/541>
Seungbae Shin [Tue, 1 Jun 2021 07:51:30 +0000 (16:51 +0900)]
Change HAL configuration path
Followings configurations are moved to HAL directory
/usr/share/pulseaudio/ to /hal/share/pulseaudio/
/etc/pulse/ to /hal/etc/pulse/
[Version] 13.0-30
[Issue Type] New HAL
Change-Id: I2aa68e3c18176058c68110689adff7d07648fd99
Jaechul Lee [Thu, 22 Apr 2021 01:00:11 +0000 (10:00 +0900)]
Allow AecManager interface
[Version] 13.0-29
[Issue Type] None
Change-Id: I75d0f714247e9dd1cad97cf0141de2640dd12798
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Wed, 10 Mar 2021 02:54:02 +0000 (11:54 +0900)]
module-loopback: check validity of source-output/sink-input properly
When the bt a2dp-source linked to the combined sink is disconnected,
a crash occurs due to an attempt to access the opposite pair that has already been released.
[Version] 13.0-28
[Issue Type] Bug fix
Change-Id: I57d05f8d8b9ffff354857b2b7cfeb4b8cbd6877b
Jaechul Lee [Thu, 21 Jan 2021 01:42:48 +0000 (10:42 +0900)]
core-util: Add retry logic when pa_close returns Broken pipe error
[Version] 13.0-27
[Issue Type]
DF210105-01173
Change-Id: I721343b86fe3607ff3b71b63b088da4dca8fe792
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Tue, 8 Dec 2020 02:20:14 +0000 (11:20 +0900)]
null-source: Fix max_latency_msec argument is not changed
This module uses 2 seconds for default max latency. If max_latency_msec
is set, max_latency value will be changed.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/431>
[jcsing.lee: backport mainline commit
a17d00c3d for null-source latency]
[Version] 13.0-26
[Issue Type] Bug fix
Change-Id: I71d3d0795c51b3edc265f852199b74ab9afae10c
Jaechul Lee [Mon, 16 Nov 2020 01:14:56 +0000 (10:14 +0900)]
null-source: Add max_latency_msec argument
It takes much time when starting to capture because max latency is set
to 2 seconds as a initial value. null-source latency need to be set a
lower value than initial value to improve latency.
[jcsing.lee: backport mainline commit
bd8ef73b9 for null-source latency]
[Version] 13.0-25
[Issue Type] Bug fix
Change-Id: If0cf86477160005697c837382bbab4696442f5ef
zhaochengyi [Sat, 18 Jul 2020 08:47:40 +0000 (16:47 +0800)]
pulsecore: Add exception judgment to fix the crash when playing music
When playing music for a period of time, the Shared Memory is
frequently accessed, and occasionally read/write errors occur,
which causes the program to crash
[Current thread is 1 (Thread 0xffff86823010 (LWP 2841))]
(gdb) bt
0 0x0000ffff8702a714 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
1 0x0000ffff870188e8 in __GI_abort () at abort.c:79
2 0x0000ffff873b5728 in do_read (p=p@entry=0x3673a170, re=re@entry=0x3673a338) at pulsecore/pstream.c:856
3 0x0000ffff873b7fd8 in do_pstream_read_write (p=0x3673a170) at pulsecore/pstream.c:248
4 0x0000ffff873b8368 in srb_callback (srb=<optimized out>, userdata=0x3673a170) at pulsecore/pstream.c:287
5 0x0000ffff873b8bec in srbchannel_rwloop (sr=0x36766ae0) at pulsecore/srbchannel.c:190
6 0x0000ffff87339c70 in dispatch_pollfds (m=0x36670db0) at pulse/mainloop.c:655
7 0x0000ffff87339c70 in pa_mainloop_dispatch (m=m@entry=0x36670db0) at pulse/mainloop.c:898
8 0x0000ffff8733a01c in pa_mainloop_iterate (m=0x36670db0, block=<optimized out>, retval=0xffffd9683030) at pulse/mainloop.c:929
9 0x0000ffff8733a0d8 in pa_mainloop_run (m=m@entry=0x36670db0, retval=retval@entry=0xffffd9683030) at pulse/mainloop.c:945
10 0x0000000000406894 in main (argc=<optimized out>, argv=<optimized out>) at daemon/main.c:1144
[jcsing.lee: backport mainline commit
b5a6365f1]
Signed-off-by: zhaochengyi <zhaochengyi@uniontech.com>
[Version] 13.0-24
[Issue Type] Bug fix
Change-Id: I7dae834ca8dc0038aa583d02f688fdfb22edca0a
Jaechul Lee [Fri, 6 Nov 2020 01:52:33 +0000 (10:52 +0900)]
null-sink: Change block size to 50 msec when norewinds is set
playing sound through null sink takes almost 2 seconds at first time
playback when norewinds is set. Because block_usec is set 2 seconds at
initializing time. The value will be changed 50 msec after calling
update_request_latency callback.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/406>
[jcsing.lee: backport mainline commit
1e7adb4fd for null-sink latency]
Change-Id: I2f47c14ae8497421a0ab8f27e9043674191e95c4
Seungbae Shin [Fri, 13 Nov 2020 09:47:24 +0000 (18:47 +0900)]
daemon: Use /run instead of /var/run for PIDFile in systemd service
[Version] 13.0-22
[Issue Type] update
Change-Id: Ife3d89f0e28b40786bfdcc98c1f57e4653bf1d75
Seungbae Shin [Mon, 28 Sep 2020 07:05:25 +0000 (16:05 +0900)]
Remove unnecessary pa-info script from packaging
[Version] 13.0-21
[Issue Type] Packaging
Change-Id: Icc59bf09de7569a30c3b4897dd8de6f59b1037f3
Seungbae Shin [Tue, 15 Sep 2020 07:25:22 +0000 (16:25 +0900)]
fixup! Fix build warnings
[Version] 13.0-20
[Issue Type] Build
Change-Id: Id4440e520e8d5a00c2a5e8d8fa621a62aa05d3b2
Arun Raghavan [Thu, 23 Jul 2020 23:42:47 +0000 (19:42 -0400)]
stream-restore,device-restore: Avoid unaligned access
Newer GCC warns us that the channel_map and volume in legacy entries are
accessed via pointers, and these might be unaligned as the legacy entry
is a packed structure. For this reason, we read out those values into
local variables before accessing them as pointers.
The warnings are:
[146/433] Compiling C object src/modules/module-device-restore.so.p/module-device-restore.c.o
../src/modules/module-device-restore.c: In function ‘legacy_entry_read’:
../src/modules/module-device-restore.c:554:51: warning: taking address of packed member of ‘struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
554 | if (le->volume_valid && !pa_channel_map_valid(&le->channel_map)) {
| ^~~~~~~~~~~~~~~~
../src/modules/module-device-restore.c:559:48: warning: taking address of packed member of ‘struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
559 | if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
| ^~~~~~~~~~~
../src/modules/module-device-restore.c:559:104: warning: taking address of packed member of ‘struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
559 | if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
| ^~~~~~~~~~~
../src/modules/module-device-restore.c:559:117: warning: taking address of packed member of ‘struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
559 | if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
| ^~~~~~~~~~~~~~~~
[211/433] Compiling C object src/modules/module-stream-restore.so.p/module-stream-restore.c.o
../src/modules/module-stream-restore.c: In function ‘legacy_entry_read’:
../src/modules/module-stream-restore.c:1076:51: warning: taking address of packed member of ‘struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
1076 | if (le->volume_valid && !pa_channel_map_valid(&le->channel_map)) {
| ^~~~~~~~~~~~~~~~
../src/modules/module-stream-restore.c:1081:48: warning: taking address of packed member of ‘struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
1081 | if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
| ^~~~~~~~~~~
../src/modules/module-stream-restore.c:1081:104: warning: taking address of packed member of ‘struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
1081 | if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
| ^~~~~~~~~~~
../src/modules/module-stream-restore.c:1081:117: warning: taking address of packed member of ‘struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
1081 | if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
|
[jcsing.lee: cherry-pick from mainstream commit merge_requests/333]
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Change-Id: I37a2ac9e0a352457a1fd882862f9186715d1a253
Arun Raghavan [Thu, 23 Jul 2020 23:36:11 +0000 (19:36 -0400)]
glib-mainloop: Drop deprecated g_get_current_time() usage
This uses the year 2038-safe g_get_real_time() as recommended instead.
Bumps GLib dependency to 2.28 as a result.
[jcsing.lee: cherry-pick from mainstream commit merge_requests/333]
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Change-Id: I94d46f248783c5edc617f9ff157bbf23dd2391f8
Arun Raghavan [Thu, 23 Jul 2020 23:36:06 +0000 (19:36 -0400)]
proplist-util: Drop deprecated G_CONST_RETURN macro
The preference in glib is now to just use the const qualifier directly.
[jcsing.lee: cherry-pick from mainstream commit merge_requests/333]
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Change-Id: I255533b36d818a20f193b80864c338ece0e24dd0
Seungbae Shin [Wed, 2 Sep 2020 07:12:11 +0000 (16:12 +0900)]
Fix build warnings
[Version] 13.0-19
[Issue Type] Build
Change-Id: I35eeecabad0dbb2b3eaf52bcd0fe394055edf96f
Wootak Jung [Wed, 8 Jul 2020 05:23:33 +0000 (14:23 +0900)]
bluetooth: Apply upstream 13.0
Change-Id: I285cfd8ba851cfdb729ba1a9bcd9377fbdd2247b
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
Seungbae Shin [Thu, 27 Aug 2020 11:08:15 +0000 (20:08 +0900)]
bluez5-discover: Fix Coverity defect of Resource leak(RESOURCE_LEAK)
[Version] 13.0-18
[Issue Type] Vulnerability
Change-Id: I1c4890be02b3443e11a33298ca61bcb4ac1182ba
Seungbae Shin [Tue, 25 Aug 2020 12:06:32 +0000 (21:06 +0900)]
Apply deny policy on remote-audio methods for default context in dbus conf
[Version] 13.0-17
[Issue Type] Update
Change-Id: I9404c1aba633fd252869bbcdeb3993bac622b659
Seungbae Shin [Wed, 19 Aug 2020 05:28:18 +0000 (14:28 +0900)]
stream: skip cynara checks for remote connection
[Version] 13.0-16
[Issue Type] Update
Change-Id: I20caf16d5745bcb0e51c8e9b1ae4353c9a71f653
Seungbae Shin [Tue, 18 Aug 2020 09:56:15 +0000 (18:56 +0900)]
tunnel-sink(source)-new: modification for remote-audio
- receive stream event to update access permission of the sink(source)
- set remote name from target device name vconf
- set default remote access permission as denied
- set device api property with 'tunnel'
[Version] 13.0-15
[Issue Type] Update
Change-Id: Iae64a8805b6befa088b0c5ffce678894114a8bba
Seungbae Shin [Tue, 18 Aug 2020 07:09:39 +0000 (16:09 +0900)]
pulsecore: add remote utility functions with proplist definitions
- pa_proplist_has_remote_name
- pa_proplist_set_remote_access_permission
- pa_proplist_remote_is_allowed
- pa_sink_update_proplist_remote_access_permission
- pa_source_update_proplist_remote_access_permission
[Version] 13.0-14
[Issue Type] Add
Change-Id: I61615c128f91b2eaeda77bce44fab67dfed3e1c0
Sangchul Lee [Thu, 13 Aug 2020 04:06:32 +0000 (13:06 +0900)]
bluez5-device: Update the port latency offset according to the delay change
This patch applies the delay to the sink of the device. It will affect
the current latency of the sink.
[Version] 13.0-13
[Issue Type] New feature
Change-Id: I33dcc030876236d66bd074a5789f79febe0626ea
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 12 Aug 2020 10:56:32 +0000 (19:56 +0900)]
bluez5-util: Add pa_bluetooth_transport_set_delay() and related HOOK
This delay originates from the AVDTP 1.3 Delay Reporting feature.
This function sets the delay(us) to the bluetooth transport and notifies
the change via PA_BLUETOOTH_HOOK_TRANSPORT_DELAY_CHANGED hook.
[Version] 13.0-12
[Issue Type] New feature
Change-Id: I7d639e5f52d4b65c9a012d5716a4d544757d00e6
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jaechul Lee [Mon, 3 Aug 2020 03:11:13 +0000 (12:11 +0900)]
play-memblockq: Adds debug log when pop_cb_fails to peek data.
pulseaudio crashed when sink-input(feedback sound) moved to the combine
sink in multiview scenario.
[Version] 13.0-11
[Issue Type] TV issue
Change-Id: I38df7d6de7d931e5da829c42b62f078ed0ca9b77
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Wed, 29 Jul 2020 08:57:19 +0000 (17:57 +0900)]
thread-posix: retry thread joining if failed
print some logs related to threaded-mainloop
[Version] 13.0-10
[Issue Type] Debugging
Change-Id: Iaf415b422b8857ad5b84ee398da6d1535e468232
Seungbae Shin [Fri, 24 Jul 2020 10:41:49 +0000 (19:41 +0900)]
module-loopback: rollback calculation of requested buffer latency due to bluetooth sync issue
[Version] 13.0-9
[Issue Type] audio sync
Change-Id: Ic4e7c4cba0fa31f41c33c1c3fc4870de28665f8e
Wootak Jung [Tue, 30 Jun 2020 06:22:47 +0000 (15:22 +0900)]
bluez5-util: Add DelayReporting flag on endpoint registration
Change-Id: I1234032fd03a70913bdc5d81a9a9a770580fcc8f
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
Jaechul Lee [Fri, 22 May 2020 04:39:10 +0000 (13:39 +0900)]
sound-file-stream: Fix pulseaudio crash when invalid samples are pushed
memblockq only allows to push aligned data but a invalid file that has
not aligned samples was played though wav-player.
pulseaudio was crashed in pa_memblockq_push function.
pa_assert(uchunk->length % bq->base == 0);
[Version] 13.0-8
[Issue Type] Bugs (TFDF-10411)
Change-Id: I9f117bb3402ef94b46e4b77e7d188f1722f23114
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Fri, 15 May 2020 04:46:10 +0000 (13:46 +0900)]
alsa-sink: Adds handling EAGAIN in try_recover
snd_pcm_avail returns a negative value sometimes. It depends on H/W. So,
trying to recover function was added and print out the state of the
buffer.
[Version] 13.0.7
[Issue Type] TSIX-3385
Change-Id: Ia5f97261d6216e2a64e40d0432e03c5c816ba022
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
jaechul lee [Mon, 11 May 2020 04:51:40 +0000 (04:51 +0000)]
Merge "Allow tone-player interface" into tizen
jaechul lee [Mon, 11 May 2020 04:20:46 +0000 (04:20 +0000)]
Merge "pactl: Adds set-pcm-dump command" into tizen
Jaechul Lee [Wed, 22 Apr 2020 03:46:16 +0000 (12:46 +0900)]
Allow tone-player interface
[Version] 13.0-6
[Issue Type] None
Change-Id: I6fbf3a2a78cf5ac3773c39fa5670d6ed49372a1b
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 27 Apr 2020 03:47:51 +0000 (12:47 +0900)]
Fix build warning
[Version] 13.0.4
[Issue Type] Bug
Change-Id: Ib64feeaf9debec9abec70a1358983d9d7946cf90
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 23 Apr 2020 08:08:00 +0000 (17:08 +0900)]
pactl: Adds set-pcm-dump command
This commit is from
d2f6895a1. Unused functions such as
pcm_dump_option and defines regarding gstreamer have been removed.
[Version] 13.0-5
[Issue Type] None
Change-Id: I9d1be1ab5e38e4f7b21b6d99687bf66d8f50f896
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Daniil Kovalev [Sat, 2 Nov 2019 18:43:51 +0000 (21:43 +0300)]
Fix memory leak in context_free
In commit
f727cd9a `int error` member in `struct pa_context` was changed
to `pa_context_error *error`. The memory that is allocated with
`pa_xnew0` in src/pulse/context.c:142 is never freed, and it causes
a leak of 4 bytes. The leak can be easily detected with leak-sanitizer.
[jcsing.lee: backport mainline commit
5fdde3fa8 for fixing memory leak]
Change-Id: I08bd62a2b390a7e9025186b6eb00c0c0dfc87bb2
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
sanghyeok.oh [Tue, 7 Apr 2020 07:17:38 +0000 (16:17 +0900)]
Allow signal to pulseaudio
Signal from callmgrd to pulseaudio has denied.
Feb 17 13:38:47 localhost dbus[333]: [system] Rejected send message, 2 matched rules; type="signal", sender=":1.40" (uid=601 pid=549 comm="/usr/bin/callmgrd ") interface="org.tizen.AudioClient1" member="ClientSubscribed" error name="(unset)" requested_reply="0" destination="org.freedesktop.DBus" privilege="(n/a)" (uid=122 pid=453 comm="/usr/bin/pulseaudio ") rule(<deny send_destination="org.pulseaudio.Server" />)
Feb 17 13:39:46 localhost dbus[333]: [system] Rejected send message, 2 matched rules; type="signal", sender=":1.79" (uid=5001 pid=1360 comm="/usr/apps/org.tizen.multi-assistant-service/bin/or") interface="org.tizen.AudioClient1" member="ClientSubscribed" error name="(unset)" requested_reply="0" destination="org.freedesktop.DBus" privilege="(n/a)" (uid=122 pid=453 comm="/usr/bin/pulseaudio ") rule(<deny send_destination="org.pulseaudio.Server" />)
Change-Id: I0ea45a53f64212044ab772e09bc3a59456470708
Jaechul Lee [Thu, 26 Mar 2020 07:54:58 +0000 (16:54 +0900)]
pulsecore: Adds pa_play_file_repeat function
[Version] 13.0-4
[Issue Type] None
Change-Id: I704a7aa9e8fd871f47af3988b8c2997ed293692f
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Mon, 9 Mar 2020 03:33:22 +0000 (12:33 +0900)]
card-restore: Fix memory leak
[Version] 13.0-3
[Issue Type] Coverity defect
Change-Id: If6a5f8a7acedc0b6be5acf9ce270f8757ab6529c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 9 Mar 2020 03:11:05 +0000 (12:11 +0900)]
null-sink: Fix memory leak in pa__init()
[Version] 13.0-2
[Issue Type] Coverity
Change-Id: I4e831abe1000b8428a1256bc72c81d7136e02726
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 7 Feb 2020 02:57:20 +0000 (11:57 +0900)]
Merge branch 'upstream/13.0' into tizen
[Version] 13.0-1
[Issue Type] Upgrade
Change-Id: I252236dc28ad2be6fa4cb7f44fd942aeb83f5396
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jeongmo Yang [Wed, 29 Jan 2020 01:58:46 +0000 (10:58 +0900)]
mix: Update logic to set ramp finished flag
- The ramp finished flag could not be set as TRUE although "left" is reached to 0.
[Version] 11.1-81
[Profile] Common
[Issue Type] Update
Change-Id: I8ac34723379b42e41d12b9f685395bb0c7af6bba
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Seungbae Shin [Fri, 1 Nov 2019 01:44:40 +0000 (10:44 +0900)]
sink-input: fix to add ducking silence block with correct sample spec
[Version] 11.1-80
[Issue Type] Bug fix
Change-Id: I2dc445abdd121178d4890089b0a63520dba6f271
Tanu Kaskinen [Fri, 13 Sep 2019 13:18:43 +0000 (16:18 +0300)]
build-sys: Add missing files to release tarballs
Tanu Kaskinen [Fri, 13 Sep 2019 12:48:51 +0000 (15:48 +0300)]
update NEWS
Danny O'Brien [Mon, 2 Sep 2019 07:06:49 +0000 (00:06 -0700)]
man: Add description of pactl special names.
Arun Raghavan [Mon, 2 Sep 2019 04:29:29 +0000 (09:59 +0530)]
build-sys: Fix documentation of version info
The comment has been incorrect for a while now. Thanks to Jan Steffens
for pointing this out.
Moo [Sun, 1 Sep 2019 13:16:20 +0000 (13:16 +0000)]
l10n: Update lt.po
Arun Raghavan [Sun, 1 Sep 2019 07:35:10 +0000 (13:05 +0530)]
build-sys: Bump version info for libpulse
Minor implementation change since last release (we now load X11
properties only for SSH connections).
Rafael Fontenelle [Fri, 30 Aug 2019 13:12:24 +0000 (13:12 +0000)]
po: Update Brazilian Portuguese translation
Nicolas Fella [Fri, 30 Aug 2019 11:07:52 +0000 (11:07 +0000)]
daemon: Drop KDE-specific loading of module-device-manager
Newer versions of Plasma no longer use this module, and the consensus
seems to be that module-switch-on-connect works better for most cases.
Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/509
Carlos Garnacho [Sat, 22 Jun 2019 12:33:59 +0000 (14:33 +0200)]
client-conf: Avoid loading X11 properties unless SSH_CONNECTION is set
Reading properties from the X11 root window is meant to provide 1:1 results
with reading the configuration directly in the local case. This configuration
is essentially different only in remote cases.
Add an extra check for the SSH_CONNECTION envvar, so we don't even need
opening a X11 display connection for IPC in the most usual case.
Russell Treleaven [Mon, 19 Aug 2019 10:54:06 +0000 (10:54 +0000)]
gitlab: white space change to Bug.md
Add a second whitespace at the end of the line to force a newline in the
output.
David Emett [Sat, 27 Jul 2019 21:24:42 +0000 (22:24 +0100)]
dbus: fix ActiveProfile setting
Just like with handle_set_active_port, we need to look up the profile
corresponding to the provided path rather than doing a name comparison.
Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/709
Pali Rohár [Tue, 27 Aug 2019 03:11:27 +0000 (08:41 +0530)]
bluetooth: Only perform write-related calculations when we have a sink
This avoids a potential divide-by-zero when we try to decide how much to
write to the sink in the source thread when there is no sink.
Fixes https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/717
Arun Raghavan [Thu, 22 Aug 2019 13:23:13 +0000 (18:53 +0530)]
build-sys: meson: Process subdirectories before generating configuration
Subdirectories add to the top-level cdata (specifically, the SIMD
detection happens in the pulsecore meson.build), so we were missing
HAVE_MMX/SSE2/NEON defines without this fix.
Arun Raghavan [Thu, 22 Aug 2019 12:28:20 +0000 (17:58 +0530)]
build-sys: meson: Fixes for some ARM compiler checks
Yuri Chornoivan [Mon, 19 Aug 2019 08:35:06 +0000 (08:35 +0000)]
po: update Ukrainian translation
Russell Treleaven [Sun, 18 Aug 2019 20:48:23 +0000 (20:48 +0000)]
Update Bug.md to encourage users to attach pa-info output to bug reports
Arun Raghavan [Sat, 17 Aug 2019 10:42:37 +0000 (16:12 +0530)]
build-sys: meson: Give ourselves a little more timeout headroom
We're seeing CI failures due to once-test sometimes taking long. Let's
give ourselves a little more space per test (2 min -> 5 min) to avoid
this.
RODRIGUEZ Christophe [Sat, 17 Aug 2019 10:43:20 +0000 (10:43 +0000)]
raop: Fix infinite loop in raop-sink with UDP mode
There are potentially unresolved issues around the EAGAIN logic, but
this should prevent an infinite loop and log flood in the mean time.
Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/695
Arun Raghavan [Thu, 15 Aug 2019 10:19:30 +0000 (15:49 +0530)]
build-sys: meson: Add a bunch of missing checks
Arun Raghavan [Thu, 15 Aug 2019 10:00:41 +0000 (15:30 +0530)]
build-sys: meson: Add mkfifo checks for module-pipe-*
Arun Raghavan [Thu, 15 Aug 2019 10:00:26 +0000 (15:30 +0530)]
build-sys: meson: Add some missing declaration checks
Arun Raghavan [Thu, 15 Aug 2019 10:00:00 +0000 (15:30 +0530)]
build-sys: meson: Add a check for fast 64-bit operations
Arun Raghavan [Thu, 15 Aug 2019 07:38:14 +0000 (13:08 +0530)]
build-sys: meson: Add ARMv6 instruction check
Arun Raghavan [Thu, 15 Aug 2019 07:37:54 +0000 (13:07 +0530)]
build-sys: meson: Add atomic ops related checks
Lucas Stach [Tue, 13 Aug 2019 15:27:37 +0000 (17:27 +0200)]
meson: add stdint.h to checked headers
Without this check we won't ever define HAVE_STDINT_H, which isn't used
in pulse directly, but is needed by e.g. the speex headers to work
correctly.
Lucas Stach [Tue, 13 Aug 2019 15:08:13 +0000 (17:08 +0200)]
meson: allow to build bluez support without libbluetooth
pulseaudio does not link against libbluetooth, as it's only talking to the
bluez daemon over dbus. So the build dependency on libbluetooth is overly
restrictive, as some embedded systems choose to ship without libbluetooth
but still have bluez daemon support.
This syncs the meson to the autotools configuration behavior by changing
the bluez option to a default on boolean.
Lucas Stach [Tue, 13 Aug 2019 14:01:01 +0000 (16:01 +0200)]
meson: fix build files list when building with NEON
Sync the meson NEON build files list with the autotools build
sources list. Fixes "ERROR: File svolume_neon.c does not exist."
Jan Alexander Steffens (heftig) [Tue, 13 Aug 2019 19:47:23 +0000 (21:47 +0200)]
build-sys: meson: Fix 2 cases of joining paths w/o join_paths
Fixes https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/712
Tanu Kaskinen [Tue, 13 Aug 2019 13:49:31 +0000 (16:49 +0300)]
bootstrap.sh: don't set sysconfdir and localstatedir configure options
I don't know why these options were being passed to configure
(--sysconfdir has been there from the very beginning, --localstatedir
got added when the system mode was added). Overwriting system files by
default is not good, so let's not set these options.
Jan Alexander Steffens (heftig) [Thu, 8 Aug 2019 18:23:12 +0000 (20:23 +0200)]
build-sys: meson: Add some missing checks
- Header and function checks from configure.ac
(some libc, some libpthread, dladdr from libdl)
- Find iconv and check constness
Russell Treleaven [Thu, 8 Aug 2019 16:30:05 +0000 (12:30 -0400)]
add script to collect information for bug reports
Milo Casagrande [Wed, 7 Aug 2019 07:53:37 +0000 (09:53 +0200)]
l10n: Update Italian translation
* Fixed typo.
* Fixed use of double quotes.
Signed-off-by: Milo Casagrande <milo@milo.name>
Arun Raghavan [Tue, 6 Aug 2019 16:25:44 +0000 (21:55 +0530)]
build-sys: autotools: Add meson build files to EXTRA_DIST
As we currently still generate our tarballs using autotools, let's make
sure the meson build system is distributed with the tarball.
Arun Raghavan [Mon, 5 Aug 2019 08:49:27 +0000 (14:19 +0530)]
build-sys: Move svolume-*.c to libpulsecore
The various software volume implementations were being built as part of
libpulsecommon for some reason. These should only ever be used in the
daemon, so they should be in libpulsecore.
Arun Raghavan [Mon, 5 Aug 2019 08:39:44 +0000 (14:09 +0530)]
build-sys: meson: Fix minor typo in orc build
Arun Raghavan [Mon, 5 Aug 2019 05:09:49 +0000 (10:39 +0530)]
build-sys: meson: Add symbol versioning as in autotools
Adds the -version-script linker argument that we use with autotools to
version symbols in our public API.
Arun Raghavan [Mon, 5 Aug 2019 05:00:50 +0000 (10:30 +0530)]
build-sys: meson: Fix some defines for default.pa generation
Removes a warning from HAVE_GCONF not being set, and fixes generation of
a large section that depends on OS_IS_WIN32 being explicitly set to 0.
We can't set OS_IS_WIN32 to 0 by default since a bunch of code uses it
via an ifdef rather than by value.
Arun Raghavan [Fri, 2 Aug 2019 21:11:55 +0000 (02:41 +0530)]
build-sys: meson: Correctly set up RPATH
This was being done automatically by autotools, now we need to manually
specify this for each executable/library with a dependency in a
non-standard directory.
Arun Raghavan [Fri, 2 Aug 2019 20:22:09 +0000 (01:52 +0530)]
build-sys: meson: Add -Wl,no-delete to relevant libraries
This mirrors the autotools option for all server-side dynamic libraries.
Sangchul Lee [Wed, 31 Jul 2019 02:48:32 +0000 (11:48 +0900)]
stream-interaction: Fix crash when moving a ducked sink-input
The operation of a ducked stream in sink_input_move_start_cb()
should differ from sink_input_unlink_cb().
[Version] 11.1-79
[Issue Type] Bug fix
Change-Id: I698f3ca232b7151aaae021572a559d54bc3209bf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 30 Jul 2019 01:22:28 +0000 (10:22 +0900)]
role-ducking, role-cork, stream-interaction: Fetch and apply upstream codes
- stream-interaction: Support for triggering ducking/cork by source-output
: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/
0f4f109a3c1035ef3d8321ff836f83b3b6157326
- stream-interaction: Use PA_IDXSET_FOREACH macro to iterate idxset
: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/
5540f728e52e9c369079e3ac83b8bc55e3519079
- role-ducking, role-cork: Add use_source_trigger argument
: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/
65cc86f609525a89b740de6b366e35277763e32c
[Version] 11.1-78
[Issue Type] Upstream patch
Change-Id: I9b707e873a6fd1c50ee8fb47f82f09b8a092cd7f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jordi Mas [Sun, 28 Jul 2019 10:17:39 +0000 (10:17 +0000)]
Fixes to Catalan translation
Jan Alexander Steffens (heftig) [Wed, 10 Jul 2019 23:32:57 +0000 (01:32 +0200)]
meson: Fix installation of headers
To match Autotools:
- internal.h should not be installed
- Install simple.h and version.h
Jan Alexander Steffens (heftig) [Wed, 10 Jul 2019 23:25:38 +0000 (01:25 +0200)]
meson: Fix library versioning to match Autotools
For ease of maintaining both build systems, use the same version info
sequences as configure.ac. This should be simplified after Autotools has
been dropped.
Jan Alexander Steffens (heftig) [Wed, 10 Jul 2019 22:52:50 +0000 (00:52 +0200)]
meson: Fix build of padsp
- Rename "pulsedspdir" to the same "padsplibdir" that Autotools uses.
- Add a new option "pulsedsp-location" that is only used for padsp.in,
just like Autotools' --with-pulsedsp-location.
- Use 'set' instead of 'set_quoted' to avoid PULSEDSP_LOCATION getting
quoted twice.
Pali Rohár [Sun, 21 Jul 2019 15:07:02 +0000 (17:07 +0200)]
bluetooth: Fix usage of RTP structures in SBC codec
Rename struct rtp_payload to rtp_sbc_payload as it is specific for SBC
codec payload.
Add proper checks for endianity in rtp.h header and use uint8_t type
where appropriated.
Field frame_count is only 4 bit number, so add checks to prevent overflow.
And because is_fragmented field is not parsed by decoder there is no
support for decoding fragmented SBC frames. So throw an error in this case.
Pali Rohár [Sun, 21 Jul 2019 15:07:01 +0000 (17:07 +0200)]
bluetooth: Change A2DP codec API of reset() method to indicate failure
SBC codec reset() method may fail, so propagate this failure to caller.
Pali Rohár [Sun, 21 Jul 2019 15:07:00 +0000 (17:07 +0200)]
bluetooth: Fix usage of MTU, buffer sizes and return values of encode/decode methods
Add explanation why minimal bitpool value is used in SBC codec as initial
bitpool value for A2DP source.
Set buffer size for reading/writing from/to A2DP socket to exact link MTU
value. This would ensure that A2DP codec does not produce larger packet as
maximal possible size which can be sent.
Because A2DP socket is of SOCK_SEQPACKET type, it is guaranteed that
we do not read two packets via one read/recvmsg call.
Properly check for all return values of encode/encode methods of A2DP codec
functions. They may fail at different levels. Also encode or decode API
method may return zero length buffer (e.g. because of algorithmic delay of
codec), so do not fail in this case.
Seungbae Shin [Fri, 14 Jun 2019 03:36:52 +0000 (12:36 +0900)]
Migrate OpenSSL 1.0.2 to OpenSSL 1.1.1
https://bugs.tizen.org/browse/TC-2600
[Version] 11.1-77
[Issue type] Migration
Change-Id: I01479d0d92cb72e5a2441097d07b6f59cb024788
Arun Raghavan [Tue, 19 Feb 2019 03:57:02 +0000 (09:27 +0530)]
source: Fix a bad condition that made source events not be emitted
This broke during a refactor of sink/source state-change.
https://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=
db788229c66369a7b1283173183662b7f5e6c742
[Version] 11.1-76
[Profile] Common
[Issue Type] Upstream patch
Change-Id: I670281dcb94aa7d2bcc24b05cd44b99fa7ffc376
Georg Chini [Sun, 21 Jul 2019 13:07:18 +0000 (15:07 +0200)]
Commit
fd9e3452 removed -ffast-math from the compile flags. Under some
conditions this may lead to massive slowdown of floating point operations
when underflows or denormals are encountered. In particular, this problem
was observed with the soxr resampler after applying
https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/120
Therefore this patch adds -ffast-math to the link flags of the pulseaudio
daemon. Linking with -ffast-math adds a procedure set_fast_math() to the
startup code of the daemon. On x86, the procedure sets bit 6 and 15 of the
mxcsr register. When these bits are set, denormals and results of
underflowing operations are truncated to 0.
Piotr Drąg [Sat, 20 Jul 2019 12:13:29 +0000 (14:13 +0200)]
i18n: update Polish translation