Daniel Stenberg [Thu, 14 Jun 2007 14:42:21 +0000 (14:42 +0000)]
Shmulik Regev fixed a flaw in the multi interface that occurred when doing
HTTP CONNECT over a proxy
Daniel Stenberg [Thu, 14 Jun 2007 14:15:21 +0000 (14:15 +0000)]
s/HAVE_POLL/HAVE_SYS_POLL_H
James Housley [Thu, 14 Jun 2007 13:22:00 +0000 (13:22 +0000)]
Remove duplicate code that was left in as part of 1.35. This code
only affected sftp_sendquote() for the "chgrp/chmod/chown" commands.
This also fixed failure of test 614 on a system that previously failed.
Daniel Stenberg [Thu, 14 Jun 2007 11:21:48 +0000 (11:21 +0000)]
Make our own definitions of the POLL* defiens and the pollfd struct only get
done if the sys/poll.h file is missing, as we have seen machines with poll()
present but without the header file and machines that don't get HAVE_POLL
defined but that do have the sys/poll.h header file...
James Housley [Thu, 14 Jun 2007 10:36:53 +0000 (10:36 +0000)]
BUG FIX: When reading a directory listing that contains symlinks
with the latest libssh2, the listing would be truncated at the symlink.
Fix by looping on LIBSSH2_ERROR_EAGAIN, like the rest of the calls.
Daniel Stenberg [Wed, 13 Jun 2007 20:17:35 +0000 (20:17 +0000)]
Tom Regner provided a patch and worked together with James Housley, so now
CURLOPT_FTP_CREATE_MISSING_DIRS works for SFTP connections as well as FTP
ones.
Daniel Stenberg [Wed, 13 Jun 2007 20:08:19 +0000 (20:08 +0000)]
Rich Rauenzahn filed bug report #1733119
(http://curl.haxx.se/bug/view.cgi?id=1733119) and we collaborated on the fix.
The problem is that for 64bit HPUX builds, several socket-related functions
would still assume int (32 bit) arguments and not socklen_t (64 bit) ones.
James Housley [Wed, 13 Jun 2007 17:13:44 +0000 (17:13 +0000)]
Restore functionality mistakenly removed in the previous commit
James Housley [Wed, 13 Jun 2007 15:02:34 +0000 (15:02 +0000)]
Update documentation to reflect SFTP's ability to create directories on
upload. Some text provieded by Tom Regner
Gisle Vanem [Wed, 13 Jun 2007 14:01:48 +0000 (14:01 +0000)]
libssh2_session_free() returns void. Fix "#endif".
James Housley [Wed, 13 Jun 2007 12:15:23 +0000 (12:15 +0000)]
Commit Tom Regner's code for SFTP create missing directories. This patch
uses the --ftp-create-dirs flag to control if cURL will try and create
directories that are specified in an upload path, but don't exist.
James Housley [Wed, 13 Jun 2007 11:27:41 +0000 (11:27 +0000)]
Add a define to protect the state machine from older versions of libssh2,
ie 0.14, that don't know about newer constants used in the state machine.
Daniel Stenberg [Tue, 12 Jun 2007 21:39:21 +0000 (21:39 +0000)]
With lots of help from Rich Rauenza(?) in bug #1733119, we introduce a fairly
complicated work-around for 64bit HPUX compiles. We do the fix using inline
static functions to make them follow the header file properly and thus get
used fine in the test suite too etc.
James Housley [Tue, 12 Jun 2007 21:32:45 +0000 (21:32 +0000)]
* Updates for the latest version of libssh2, specifically
libssh2_sftp_shutdown() and libssh2_session_free() can now return
LIBSSH2_ERROR_EAGAIN.
* Fix the _send() and _recv() return values so non-blocking works
James Housley [Tue, 12 Jun 2007 16:15:20 +0000 (16:15 +0000)]
While connect and transfer works fine in non-blocking mode for the test
suite, transfer fails in the real world. So after connect set to blocking
as full non-blocking is migrated out.
Daniel Stenberg [Tue, 12 Jun 2007 13:51:57 +0000 (13:51 +0000)]
mention James current work on ssh
James Housley [Tue, 12 Jun 2007 13:47:32 +0000 (13:47 +0000)]
Prevent the state machine from getting stuck in SSH_AUTH_HOST_INIT
James Housley [Tue, 12 Jun 2007 12:31:10 +0000 (12:31 +0000)]
Convert Curl_ssh_connect() to run in a state machine for
LIBSSH2_APINO >=
200706012030. More to come...
Daniel Stenberg [Tue, 12 Jun 2007 08:15:02 +0000 (08:15 +0000)]
remove unused field in the state struct
Dan Fandrich [Mon, 11 Jun 2007 17:53:10 +0000 (17:53 +0000)]
Wait longer for servers to start up since the ssh server needs to generate
keys the first time (which can take a while on a slow or loaded host).
Enforce a longer startup wait time for the ssh client SOCKS server, too.
Check for an error code from startnew() when starting any server.
Dan Fandrich [Mon, 11 Jun 2007 17:49:25 +0000 (17:49 +0000)]
We do not use RSA keys in the test suite.
Daniel Stenberg [Mon, 11 Jun 2007 13:35:33 +0000 (13:35 +0000)]
restore the correct timeout time that my previous commit broke
Daniel Stenberg [Mon, 11 Jun 2007 13:32:49 +0000 (13:32 +0000)]
Properly wait for the c-ares resolve to complete, hopefully the cure for
bug #1733955
Daniel Stenberg [Mon, 11 Jun 2007 07:27:02 +0000 (07:27 +0000)]
Daniel Black's clarfication about the NTLM support
Gisle Vanem [Mon, 11 Jun 2007 04:33:21 +0000 (04:33 +0000)]
constify 'hostname' in init_thread_sync_data(). Simply clear
the whole 'tsd' structure on exit in destroy_thread_sync_data().
Gisle Vanem [Mon, 11 Jun 2007 04:07:51 +0000 (04:07 +0000)]
Squelsh some warnings for libssh older than 0.1.5.
Dan Fandrich [Fri, 8 Jun 2007 18:56:05 +0000 (18:56 +0000)]
Fixed the test harness so that it actually kills the ssh being used as
the SOCKS server.
Dan Fandrich [Fri, 8 Jun 2007 17:32:24 +0000 (17:32 +0000)]
Improved compatibility with perl 5.0 on the 'open' calls.
Dan Fandrich [Fri, 8 Jun 2007 17:21:40 +0000 (17:21 +0000)]
Incorporated Daniel Black's test706 and test707 SOCKS test cases.
Dan Fandrich [Fri, 8 Jun 2007 17:03:50 +0000 (17:03 +0000)]
Improved compatibility with perl 5.0 on the 'open' calls.
James Housley [Fri, 8 Jun 2007 16:19:21 +0000 (16:19 +0000)]
Curl_scp_done() needs to call libssh2_channel_free() to prevent a
memory leak, and it is the right thing to do.
James Housley [Fri, 8 Jun 2007 16:02:57 +0000 (16:02 +0000)]
Fix to work with the latest CVS version of libssh2
* As of (LIBSSH2_APINO >=
200706012030) there are not *nb() functions
* As of (LIBSSH2_APINO >=
200706012030) most libssh2_*() functions
can return LIBSSH2_ERROR_EAGAIN to indicate that the call would block.
To make the code work as previously, blocking, all the code has been
updated so that when (LIBSSH2_APINO >=
200706012030) it loops simulating
blocking. This allows the existing code to function and not hold up
the upcoming release.
Daniel Stenberg [Fri, 8 Jun 2007 09:01:33 +0000 (09:01 +0000)]
start working on 1.4.1
Daniel Stenberg [Fri, 8 Jun 2007 08:46:28 +0000 (08:46 +0000)]
1.4.0 preps
Dan Fandrich [Thu, 7 Jun 2007 22:42:26 +0000 (22:42 +0000)]
Changed the opens to work on older versions of perl.
Redirect ssh output to ssh.log
Dan Fandrich [Thu, 7 Jun 2007 22:24:53 +0000 (22:24 +0000)]
Fixed a compiler warning on uClibc.
Daniel Stenberg [Thu, 7 Jun 2007 21:56:03 +0000 (21:56 +0000)]
bug #1720605, There seems to be a problem when connecting to the Microsoft telnet server
Daniel Stenberg [Thu, 7 Jun 2007 21:47:29 +0000 (21:47 +0000)]
Daniel S (6 June 2007)
- -s/--silent can now be used to toggle off the silence again if used a second
time.
Daniel S (5 June 2007)
- Added Daniel Black's work that adds the first few SOCKS test cases. I also
fixed two minor SOCKS problems to make the test cases run fine.
Dan Fandrich [Thu, 7 Jun 2007 21:42:33 +0000 (21:42 +0000)]
Renamed the sshd log file to sshd.log.
Added more options to the ssh config file to improve the consistency of
the test environment.
Force a rewrite of the ssh config files on every invocation.
Changed the opens to work on older versions of perl.
Dan Fandrich [Thu, 7 Jun 2007 20:14:00 +0000 (20:14 +0000)]
Cleaned up SOCKS tests. Use a magic port number instead of killserver
to do nonlistening server tests, like other tests.
Dan Fandrich [Thu, 7 Jun 2007 19:49:09 +0000 (19:49 +0000)]
Fixed some problems in starting SSH for use in SOCKS.
Daniel Stenberg [Wed, 6 Jun 2007 20:08:40 +0000 (20:08 +0000)]
make -s/--silent properly toggle as it is documented
Daniel Stenberg [Tue, 5 Jun 2007 13:53:10 +0000 (13:53 +0000)]
the revert
Daniel Stenberg [Tue, 5 Jun 2007 13:52:34 +0000 (13:52 +0000)]
added 703: a socks5 version of 702
Daniel Stenberg [Tue, 5 Jun 2007 13:50:59 +0000 (13:50 +0000)]
Daniel Black's test suite fixes and initial test cases for SOCKS4/5 using
openssh
Daniel Stenberg [Tue, 5 Jun 2007 13:42:23 +0000 (13:42 +0000)]
if we read zero bytes from the proxy, the connection is broken and we need
to bail out
Daniel Stenberg [Tue, 5 Jun 2007 13:41:50 +0000 (13:41 +0000)]
mark connect failures as non-connected when ConnectPlease() fails, like when
a connection through a socks proxy doesn't work
Daniel Stenberg [Mon, 4 Jun 2007 21:33:02 +0000 (21:33 +0000)]
Revered Ashish Sharma's multiple entries patch, as it caused memory madness
Daniel Stenberg [Mon, 4 Jun 2007 21:26:30 +0000 (21:26 +0000)]
minor edit since getting an ID seems pointless when failure happens
Daniel Stenberg [Mon, 4 Jun 2007 21:04:14 +0000 (21:04 +0000)]
fix the bad bad bad mess this caused on name resolves returning more than
one name... Reported by James Bursa
Daniel Stenberg [Sat, 2 Jun 2007 20:09:23 +0000 (20:09 +0000)]
Brad Spencer found and fixed three flaws in the code, found with the new
gcc 4.2.0 warning: -Waddress
Daniel Stenberg [Sat, 2 Jun 2007 19:48:29 +0000 (19:48 +0000)]
Brad House fixed VS2005 compiler warnings due to time_t being 64bit.
He also made recent Microsoft compilers use _strdup() instead of strdup().
Daniel Stenberg [Sat, 2 Jun 2007 19:42:25 +0000 (19:42 +0000)]
Ashish Sharma provided a patch for supporting multiple entries in the
/etc/hosts file. Patch edited for coding style and functionality by me
(Daniel).
Daniel Stenberg [Sat, 2 Jun 2007 19:32:30 +0000 (19:32 +0000)]
ares_destroy_options() and ares_save_options() man pages by Brad House
Daniel Stenberg [Fri, 1 Jun 2007 21:24:34 +0000 (21:24 +0000)]
ouch, two conditionals were turned backwards!
Daniel Stenberg [Fri, 1 Jun 2007 21:01:57 +0000 (21:01 +0000)]
do the update timer stuff even when CURLM_CALL_MULTI_PERFORM is returned
Daniel Stenberg [Thu, 31 May 2007 11:34:32 +0000 (11:34 +0000)]
When transferring 500 downloads in parallel with a c-ares enabled build only
to find that it crashed miserably, and this was due to some select()isms left
in the code. This was due to API restrictions in c-ares 1.3.x, but with the
upcoming c-ares 1.4.0 this is no longer the case so now libcurl runs much
better with c-ares and the multi interface with > 1024 file descriptors in
use.
Daniel Stenberg [Thu, 31 May 2007 08:59:44 +0000 (08:59 +0000)]
Feng Tu made (lib)curl support "upload" resuming work for file:// URLs.
Daniel Stenberg [Wed, 30 May 2007 21:45:56 +0000 (21:45 +0000)]
make next version 1.4.0
Daniel Stenberg [Wed, 30 May 2007 21:37:17 +0000 (21:37 +0000)]
first take at detecting a random device and seeding the random key using data
from it in randomize_key()
Daniel Stenberg [Wed, 30 May 2007 21:11:10 +0000 (21:11 +0000)]
Shmulik Regev brought cryptographically secure transaction IDs
Daniel Stenberg [Wed, 30 May 2007 20:49:14 +0000 (20:49 +0000)]
Brad House added ares_save_options() and ares_destroy_options() that can be
used to keep options for later re-usal when ares_init_options() is used.
Daniel Stenberg [Wed, 30 May 2007 20:04:44 +0000 (20:04 +0000)]
Added CURLMOPT_MAXCONNECTS which is a curl_multi_setopt() option for setting
the maximum size of the connection cache maximum size of the multi handle.
Yang Tse [Wed, 30 May 2007 17:15:05 +0000 (17:15 +0000)]
In case of test failure, try not to show log files of other tests
Daniel Stenberg [Wed, 30 May 2007 12:58:47 +0000 (12:58 +0000)]
added ares_process_fd() to allow applications to ask for processing on
specific sockets and thus avoiding select() and associated functions/macros.
This function will be used by upcoming libcurl releases for this very
reason. It also made me export the ares_socket_t type in the public ares.h
header file, since ares_process_fd() uses that type for two of the arguments.
Daniel Stenberg [Wed, 30 May 2007 09:24:06 +0000 (09:24 +0000)]
remove really annoying debug output that makes life miserable when you do
hundreds of parallel transfers...
Daniel Stenberg [Sat, 26 May 2007 22:09:08 +0000 (22:09 +0000)]
When working with a problem Stefan Becker had, I found an off-by-one buffer
overwrite in Curl_select(). While fixing it, I also improved its performance
somewhat by changing calloc to malloc and breaking out of a loop earlier
(when possible).
Daniel Stenberg [Sat, 26 May 2007 22:02:29 +0000 (22:02 +0000)]
Primarily this fixes an off-by-one buffer overwrite (rare but still existing).
I also switched from calloc() to malloc() as a minor performance boost since
the rest of the code fills in the structs fine anyway - and they must for the
case when we use the stack-based auto variable array instead of the allocated
one.
I made the loop filling in poll_fds[] break when poll_nfds is reached as a
minor speed improvement.
Daniel Stenberg [Sat, 26 May 2007 20:50:00 +0000 (20:50 +0000)]
Clarify a bit about the fact that easy handles remain in the multi stack when
transfers are done and need to be removed and closed or re-added.
Daniel Stenberg [Sat, 26 May 2007 20:47:33 +0000 (20:47 +0000)]
make it a WARNING since this hits people hard in their faces
Daniel Stenberg [Fri, 25 May 2007 21:56:27 +0000 (21:56 +0000)]
Rob Crittenden fixed bug #1705802
(http://curl.haxx.se/bug/view.cgi?id=1705802), which was filed by Daniel
Black identifying several FTP-SSL test cases fail when we build libcurl with
NSS for TLS/SSL. Listed as #42 in KNOWN_BUGS.
Daniel Stenberg [Fri, 25 May 2007 21:20:39 +0000 (21:20 +0000)]
updated
Daniel Stenberg [Fri, 25 May 2007 21:11:28 +0000 (21:11 +0000)]
Ravi Pratap fixed a flaw in the init_by_resolv_conf() function for windows
that could cause it to return a bad return code.
Daniel Stenberg [Thu, 24 May 2007 21:11:18 +0000 (21:11 +0000)]
Song Ma filed bug report #1724016
(http://curl.haxx.se/bug/view.cgi?id=1724016) noticing that downloading
glob-ranges for TFTP was broken in CVS.
Daniel Stenberg [Thu, 24 May 2007 21:11:00 +0000 (21:11 +0000)]
stay within 80 cols
Daniel Stenberg [Thu, 24 May 2007 20:58:25 +0000 (20:58 +0000)]
'mytx' in bug report #1723194 (curl.haxx.se/bug/view.cgi?id=1723194)
pointed out that the warnf() function in the curl tool didn't properly deal
with the cases when excessively long words were used in the string to chop
up.
Daniel Stenberg [Wed, 23 May 2007 12:59:12 +0000 (12:59 +0000)]
TFTP transfers are also blocking
Daniel Stenberg [Wed, 23 May 2007 12:51:52 +0000 (12:51 +0000)]
fix the formatting of the trailing list
Daniel Stenberg [Tue, 22 May 2007 20:46:51 +0000 (20:46 +0000)]
Andre Guibert de Bruet fixed a memory leak when PKCS #12 parsing failed
Daniel Stenberg [Tue, 22 May 2007 19:51:44 +0000 (19:51 +0000)]
Andre Guibert de Bruet fixed a memory leak in the function that verifies the
peer's name in the SSL certificate when built for OpenSSL. The leak happens
for libcurls with CURL_DOES_CONVERSIONS enabled that fail to convert the CN
name from UTF8.
Daniel Stenberg [Sun, 20 May 2007 22:11:47 +0000 (22:11 +0000)]
WaitForSingleObject() uses a millisecond timeout and CURL_TIMEOUT_RESOLVE is
counted in seconds...
Daniel Stenberg [Fri, 18 May 2007 10:40:43 +0000 (10:40 +0000)]
better fix for the dl/ul counters
Daniel Stenberg [Fri, 18 May 2007 10:32:48 +0000 (10:32 +0000)]
Feng Tu reported that curl -w did wrong on TFTP transfers in
bug report #1715394 (http://curl.haxx.se/bug/view.cgi?id=1715394), and the
transfer-related info "variables" were indeed overwritten with zeroes wrongly
and have now been adjusted. The upload size still isn't accurate.
Daniel Stenberg [Fri, 18 May 2007 10:12:57 +0000 (10:12 +0000)]
bail out with error codes on failures
Daniel Stenberg [Thu, 17 May 2007 21:41:02 +0000 (21:41 +0000)]
they spell five with a v...
Daniel Stenberg [Thu, 17 May 2007 21:40:08 +0000 (21:40 +0000)]
Feng Tu pointed out a division by zero error in the TFTP connect timeout
code for timeouts less than fice seconds, and also provided a fix for it.
Dan Fandrich [Thu, 17 May 2007 06:04:44 +0000 (06:04 +0000)]
Added support for compiling under Minix 3.1.3 using ACK.
Dan Fandrich [Wed, 16 May 2007 17:45:53 +0000 (17:45 +0000)]
Match file times occurring in the morning.
Dan Fandrich [Tue, 15 May 2007 00:36:56 +0000 (00:36 +0000)]
Added call to setvbuf (disabled by default for speed) to flush the
memdebug log file after every line and avoid losing the last few log
entries if curl crashes.
Dan Fandrich [Tue, 15 May 2007 00:28:50 +0000 (00:28 +0000)]
Added support for quote commands before a transfer using SFTP and test
case 614.
Allow SFTP quote commands chmod, chown, chgrp to set a value of 0.
Dan Fandrich [Mon, 14 May 2007 22:03:42 +0000 (22:03 +0000)]
Added SFTP directory listing test case 613.
Dan Fandrich [Thu, 10 May 2007 20:03:20 +0000 (20:03 +0000)]
Added FTPS upload tests 408 and 409.
Dan Fandrich [Wed, 9 May 2007 18:24:27 +0000 (18:24 +0000)]
Kristian Gunstone fixed a problem where overwriting an uploaded file with
sftp didn't truncate it first, which would corrupt the file if the new
file was shorter than the old.
Dan Fandrich [Wed, 9 May 2007 18:05:14 +0000 (18:05 +0000)]
Added the list of SFTP post-quote commands, and fixed a few typos.
Dan Fandrich [Tue, 8 May 2007 22:14:30 +0000 (22:14 +0000)]
Added FTPS test cases 406 and 407
Daniel Stenberg [Tue, 8 May 2007 11:34:31 +0000 (11:34 +0000)]
CURLE_FTP_COULDNT_STOR_FILE is now known as CURLE_UPLOAD_FAILED. This is
because I just made SCP uploads return this value if the file size of
the upload file isn't given with CURLOPT_INFILESIZE*. Docs updated to
reflect this news, and a define for the old name was added to the public
header file.
Daniel Stenberg [Mon, 7 May 2007 07:07:55 +0000 (07:07 +0000)]
James Bursa fixed a bug in the multi handle code that made the connection
cache grow a bit too much, beyond the normal 4 * easy_handles.
Daniel Stenberg [Sun, 6 May 2007 08:14:42 +0000 (08:14 +0000)]
extended the description for the curl_multi_socket_action() change
Daniel Stenberg [Thu, 3 May 2007 20:50:07 +0000 (20:50 +0000)]
42. Daniel Black filed bug report #1705802 where he accurately mentions that
several FTP-SSL test cases fail when we build libcurl with NSS for TLS/SSL:
http://curl.haxx.se/bug/view.cgi?id=1705802
Dan Fandrich [Thu, 3 May 2007 19:12:45 +0000 (19:12 +0000)]
Fixed a few typos.