platform/upstream/libSkiaSharp.git
11 years agoAllow unit tests to include or exclude test sets.
caryclark@google.com [Thu, 2 May 2013 13:14:40 +0000 (13:14 +0000)]
Allow unit tests to include or exclude test sets.

This modifies the command line to take test
matches of the form:

   --match [or -m] [~][^]match[$] [~][^]match[$] ...

   ~ causes a matching test to always be skipped

   ^ requires the start of the test to match

   $ requires the end of the test to match

   ^ and $ requires an exact match

If a test does not match any list entry,
it is skipped unless some list entry starts with ~
Review URL: https://codereview.chromium.org/14650009

git-svn-id: http://skia.googlecode.com/svn/trunk@8955 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDisable AA for ovals and roundrects if MSAA is enabled.
commit-bot@chromium.org [Thu, 2 May 2013 13:11:22 +0000 (13:11 +0000)]
Disable AA for ovals and roundrects if MSAA is enabled.

Also remove GrPaint from a number of methods -- we only
use it to get the AA state.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/14109033

git-svn-id: http://skia.googlecode.com/svn/trunk@8954 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd msaa configs to bench_pictures.
jvanverth@google.com [Thu, 2 May 2013 12:39:37 +0000 (12:39 +0000)]
Add msaa configs to bench_pictures.

Enables msaa4 and msaa16 configs in bench_pictures and render_pictures (and
anything else that may use PictureRenderer).

Review URL: https://codereview.chromium.org/14544007/

git-svn-id: http://skia.googlecode.com/svn/trunk@8952 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate DEPS and GYP to use the copy of Android in platform_tools.
djsollen@google.com [Thu, 2 May 2013 12:27:21 +0000 (12:27 +0000)]
Update DEPS and GYP to use the copy of Android in platform_tools.

R=borenet@google.com

Review URL: https://codereview.chromium.org/13898019

git-svn-id: http://skia.googlecode.com/svn/trunk@8951 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix submit_try for new builder names
borenet@google.com [Thu, 2 May 2013 12:14:35 +0000 (12:14 +0000)]
Fix submit_try for new builder names

(SkipBuildbotRuns)
Unreviewed.

Review URL: https://codereview.chromium.org/14611009

git-svn-id: http://skia.googlecode.com/svn/trunk@8950 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 2 May 2013 07:01:25 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@8948 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHamfistedly removed core dependence on images
robertphillips@google.com [Thu, 2 May 2013 00:12:03 +0000 (00:12 +0000)]
Hamfistedly removed core dependence on images

https://codereview.chromium.org/14805002/

git-svn-id: http://skia.googlecode.com/svn/trunk@8947 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix for SurfaceTest on non-gpu platforms
junov@chromium.org [Wed, 1 May 2013 22:49:59 +0000 (22:49 +0000)]
Build fix for SurfaceTest on non-gpu platforms

Unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@8946 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding public API method on SkImage for extracting the GPU texture handle.
junov@chromium.org [Wed, 1 May 2013 22:38:16 +0000 (22:38 +0000)]
Adding public API method on SkImage for extracting the GPU texture handle.

TEST=Surface unit test

Review URL: https://codereview.chromium.org/14646007

git-svn-id: http://skia.googlecode.com/svn/trunk@8945 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test commit queue. (SkipBuildbotRuns)
commit-bot@chromium.org [Wed, 1 May 2013 21:50:53 +0000 (21:50 +0000)]
Whitespace change to test commit queue. (SkipBuildbotRuns)

R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/14772006

git-svn-id: http://skia.googlecode.com/svn/trunk@8944 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix attempt number 2.
scroggo@google.com [Wed, 1 May 2013 21:40:58 +0000 (21:40 +0000)]
Build fix attempt number 2.

Review URL: https://codereview.chromium.org/14646025

git-svn-id: http://skia.googlecode.com/svn/trunk@8943 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix the build.
scroggo@google.com [Wed, 1 May 2013 21:27:16 +0000 (21:27 +0000)]
Fix the build.

Remove an unused function warning.

Review URL: https://codereview.chromium.org/14785008

git-svn-id: http://skia.googlecode.com/svn/trunk@8942 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoForce linking with image decoders for images project.
scroggo@google.com [Wed, 1 May 2013 21:17:27 +0000 (21:17 +0000)]
Force linking with image decoders for images project.

Previously, each tool that wanted to use image decoders
but did not specifically reference them had to create a
dummy function that references them in order to ensure
they are not stripped by the linker.

Instead of making each tool reference each image decoder,
do it once in SkImageDecoder.cpp. Now each tool will have
image decoders linked in, assuming it includes the images
project.

This fixes a bug where SKPs with encoded data could not
be read by bench_ or render_pictures.

R=djsollen@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/14678003

git-svn-id: http://skia.googlecode.com/svn/trunk@8941 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkOpSegment.cpp gcc 4.7 build failure.
fmalita@google.com [Wed, 1 May 2013 20:35:51 +0000 (20:35 +0000)]
SkOpSegment.cpp gcc 4.7 build failure.

SkOpSegment.cpp:2240:5: error: ordered comparison of pointer with integer zero

Caught by gcc 4.7 -Werror=extra.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/14770005

git-svn-id: http://skia.googlecode.com/svn/trunk@8940 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for GL_EXT_multisampled_render_to_texture.
bsalomon@google.com [Wed, 1 May 2013 20:10:01 +0000 (20:10 +0000)]
Add support for GL_EXT_multisampled_render_to_texture.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14091008

git-svn-id: http://skia.googlecode.com/svn/trunk@8939 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHousekeeper should not fail when skia-autogen is reset.
rmistry@google.com [Wed, 1 May 2013 14:47:03 +0000 (14:47 +0000)]
Housekeeper should not fail when skia-autogen is reset.

Created to fix https://code.google.com/p/skia/issues/detail?id=1269 : UpdateDoxygen and UploadDoxygen steps fail when skia-autogen repository is reset.

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/14772003

git-svn-id: http://skia.googlecode.com/svn/trunk@8935 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd FontMgr to DirectWrite.
bungeman@google.com [Wed, 1 May 2013 14:21:20 +0000 (14:21 +0000)]
Add FontMgr to DirectWrite.
https://codereview.chromium.org/14314008/

git-svn-id: http://skia.googlecode.com/svn/trunk@8934 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
borenet@google.com [Tue, 30 Apr 2013 19:45:48 +0000 (19:45 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@8931 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoResubmit r8929 with the duplicated change in trunk/platform_tools/android
borenet@google.com [Tue, 30 Apr 2013 16:37:30 +0000 (16:37 +0000)]
Resubmit r8929 with the duplicated change in trunk/platform_tools/android

Unreviewed.
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/14652007

git-svn-id: http://skia.googlecode.com/svn/trunk@8930 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds after builder name change
borenet@google.com [Tue, 30 Apr 2013 12:43:07 +0000 (12:43 +0000)]
Whitespace change to trigger rebuilds after builder name change

git-svn-id: http://skia.googlecode.com/svn/trunk@8925 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds after builder name change
borenet@google.com [Tue, 30 Apr 2013 12:10:45 +0000 (12:10 +0000)]
Whitespace change to trigger rebuilds after builder name change

git-svn-id: http://skia.googlecode.com/svn/trunk@8922 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix builder name references
borenet@google.com [Tue, 30 Apr 2013 12:02:32 +0000 (12:02 +0000)]
Fix builder name references

... as a result of https://codereview.chromium.org/14517004/
(SkipBuildbotRuns)

R=bensong@google.com, rmistry@google.com, senorblanco@chromium.org

Review URL: https://codereview.chromium.org/14544003

git-svn-id: http://skia.googlecode.com/svn/trunk@8921 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 30 Apr 2013 07:01:03 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8919 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow supporting 1 older PICTURE_VERSION.
scroggo@google.com [Tue, 30 Apr 2013 02:37:56 +0000 (02:37 +0000)]
Allow supporting 1 older PICTURE_VERSION.

Allows https://codereview.chromium.org/14230022/ to be submitted
without breaking bench_pictures and render_pictures.

After DEPS roll and SKP capture, this will be reverted.

Review URL: https://codereview.chromium.org/14158015

git-svn-id: http://skia.googlecode.com/svn/trunk@8918 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixes for piping bitmaps with encoded data.
scroggo@google.com [Tue, 30 Apr 2013 02:32:41 +0000 (02:32 +0000)]
Fixes for piping bitmaps with encoded data.

Similar goals as https://codereview.chromium.org/14437012.

Builds on patch set 1 from that issue
(https://codereview.chromium.org/14437012/#ps1).

Instead of the changes in patch set 2 from that issue, this
changes SkOrderedWriteBuffer::writeBitmap to store whether an
SkBitmapHeap was used when to store the index of the SkBitmap.
SkOrderedReadBuffer::readBitmap now uses that information to
distinguish between using the heap and unflattening.

In addition, writeBitmap now records the width/height first in
all cases. If now SkBitmapHeapReader is attached, but an
SkBitmapHeap was used to record the bitmap, reading will fail
and provide the same red SkBitmap as in the case where the
SkBitmap was encoded but could not be decoded.

Updates the PICTURE_VERSION as well.

The key differences in this CL to look at are in:
SkOrderedWriteBuffer,
SkOrderedReadBuffer,
and SkPicture.

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/14230022

git-svn-id: http://skia.googlecode.com/svn/trunk@8917 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd routines to compute error between conic and quad
mike@reedtribe.org [Tue, 30 Apr 2013 02:14:58 +0000 (02:14 +0000)]
add routines to compute error between conic and quad

git-svn-id: http://skia.googlecode.com/svn/trunk@8916 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMinor optimization
robertphillips@google.com [Mon, 29 Apr 2013 18:07:35 +0000 (18:07 +0000)]
Minor optimization

https://codereview.chromium.org/14495006/

git-svn-id: http://skia.googlecode.com/svn/trunk@8912 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd 90 degree test case to rects GM
robertphillips@google.com [Mon, 29 Apr 2013 17:44:45 +0000 (17:44 +0000)]
add 90 degree test case to rects GM

https://codereview.chromium.org/13844017/

git-svn-id: http://skia.googlecode.com/svn/trunk@8911 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoStop using mix() to implement hard-light in shader.
commit-bot@chromium.org [Mon, 29 Apr 2013 17:40:33 +0000 (17:40 +0000)]
Stop using mix() to implement hard-light in shader.

R=jvanverth@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/14541004

git-svn-id: http://skia.googlecode.com/svn/trunk@8910 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove inout params from saturation helper func in XferEffect.
commit-bot@chromium.org [Mon, 29 Apr 2013 17:36:14 +0000 (17:36 +0000)]
Remove inout params from saturation helper func in XferEffect.

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/14535004

git-svn-id: http://skia.googlecode.com/svn/trunk@8909 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove guard against checking for copytexsubimage2d ptr in GrGLInterface::validate()
commit-bot@chromium.org [Mon, 29 Apr 2013 16:58:53 +0000 (16:58 +0000)]
Remove guard against checking for copytexsubimage2d ptr in GrGLInterface::validate()

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/13863021

git-svn-id: http://skia.googlecode.com/svn/trunk@8907 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPlumbed in discard_framebuffer extension
robertphillips@google.com [Mon, 29 Apr 2013 16:50:17 +0000 (16:50 +0000)]
Plumbed in discard_framebuffer extension

https://codereview.chromium.org/14461006/

git-svn-id: http://skia.googlecode.com/svn/trunk@8906 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreenable __builtin_clz for GNUC (and clang), recognizing that it is undefined for...
reed@google.com [Mon, 29 Apr 2013 15:34:35 +0000 (15:34 +0000)]
reenable __builtin_clz for GNUC (and clang), recognizing that it is undefined for a zero argument,
so we check for that explicitly.

git-svn-id: http://skia.googlecode.com/svn/trunk@8905 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd wacky random shift so I can generate some zeros (without the optimizer knowing)
reed@google.com [Mon, 29 Apr 2013 15:27:42 +0000 (15:27 +0000)]
add wacky random shift so I can generate some zeros (without the optimizer knowing)
so I can test passing a 0 to SkCLZ()

git-svn-id: http://skia.googlecode.com/svn/trunk@8904 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove redundant setting of alpha in hard-light GPU shader.
commit-bot@chromium.org [Mon, 29 Apr 2013 15:25:03 +0000 (15:25 +0000)]
Remove redundant setting of alpha in hard-light GPU shader.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/14418005

git-svn-id: http://skia.googlecode.com/svn/trunk@8903 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotemp work-around for mysterious failure of shadertext2 when using __builtin_clz
reed@google.com [Mon, 29 Apr 2013 15:10:44 +0000 (15:10 +0000)]
temp work-around for mysterious failure of shadertext2 when using __builtin_clz

git-svn-id: http://skia.googlecode.com/svn/trunk@8900 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreland 8897 (was not a build-breaker) and fix MathTest (was a build-breaker)
reed@google.com [Mon, 29 Apr 2013 14:43:50 +0000 (14:43 +0000)]
reland 8897 (was not a build-breaker) and fix MathTest (was a build-breaker)

git-svn-id: http://skia.googlecode.com/svn/trunk@8899 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 8897 -- broke clang build
reed@google.com [Mon, 29 Apr 2013 14:31:29 +0000 (14:31 +0000)]
revert 8897 -- broke clang build

git-svn-id: http://skia.googlecode.com/svn/trunk@8898 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse intrinsics on more platforms for SkCLZ
reed@google.com [Mon, 29 Apr 2013 14:18:44 +0000 (14:18 +0000)]
use intrinsics on more platforms for SkCLZ

Review URL: https://codereview.chromium.org/14418004

git-svn-id: http://skia.googlecode.com/svn/trunk@8897 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd unittest for SkCLZ
reed@google.com [Mon, 29 Apr 2013 14:18:23 +0000 (14:18 +0000)]
add unittest for SkCLZ

git-svn-id: http://skia.googlecode.com/svn/trunk@8896 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoup the inner-loop for clz bench, to get more stable results
reed@google.com [Mon, 29 Apr 2013 14:11:23 +0000 (14:11 +0000)]
up the inner-loop for clz bench, to get more stable results

git-svn-id: http://skia.googlecode.com/svn/trunk@8895 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd bench for SkCLZ
reed@google.com [Mon, 29 Apr 2013 13:55:11 +0000 (13:55 +0000)]
add bench for SkCLZ

git-svn-id: http://skia.googlecode.com/svn/trunk@8894 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_BENCH macro
reed@google.com [Mon, 29 Apr 2013 13:48:34 +0000 (13:48 +0000)]
use DEF_BENCH macro

git-svn-id: http://skia.googlecode.com/svn/trunk@8893 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCopy the top level Android directory into trunk.
djsollen@google.com [Mon, 29 Apr 2013 12:09:31 +0000 (12:09 +0000)]
Copy the top level Android directory into trunk.

This CL is the first step in a series needed to move the
android directory into trunk. After the copy we will update
GYP and DEPS to point to the new location and only then
remove the original directory.

git-svn-id: http://skia.googlecode.com/svn/trunk@8891 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sun, 28 Apr 2013 07:01:05 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8889 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded Google homepage to list of SKPs. Whitespace change to trigger rebuilds.
rmistry@google.com [Sat, 27 Apr 2013 18:26:56 +0000 (18:26 +0000)]
Added Google homepage to list of SKPs. Whitespace change to trigger rebuilds.

Review URL: https://codereview.chromium.org/14417010

git-svn-id: http://skia.googlecode.com/svn/trunk@8888 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd computation for error in conic-as-quad
mike@reedtribe.org [Sat, 27 Apr 2013 18:23:16 +0000 (18:23 +0000)]
add computation for error in conic-as-quad

git-svn-id: http://skia.googlecode.com/svn/trunk@8887 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 27 Apr 2013 07:02:53 +0000 (07:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8886 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd comment for computing max-diff between conic and its bounding quad
reed@google.com [Fri, 26 Apr 2013 21:43:29 +0000 (21:43 +0000)]
add comment for computing max-diff between conic and its bounding quad

git-svn-id: http://skia.googlecode.com/svn/trunk@8885 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops -- disable fail test for now
caryclark@google.com [Fri, 26 Apr 2013 20:41:24 +0000 (20:41 +0000)]
path ops -- disable fail test for now

fail test fails on 32 bit platforms

git-svn-id: http://skia.googlecode.com/svn/trunk@8884 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops -- handle non-finite numbers
caryclark@google.com [Fri, 26 Apr 2013 19:51:16 +0000 (19:51 +0000)]
path ops -- handle non-finite numbers

Op() and Simplify() do nothing if the input
is non-finite. Add code and tests.
Review URL: https://codereview.chromium.org/14407006

git-svn-id: http://skia.googlecode.com/svn/trunk@8882 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM self-tests: always run all tests (don't stop at first failure)
epoger@google.com [Fri, 26 Apr 2013 17:45:06 +0000 (17:45 +0000)]
GM self-tests: always run all tests (don't stop at first failure)
and make rebaseline.sh rebaseline all tests in one go.
(RunBuilders:Skia_PerCommit_House_Keeping)

Review URL: https://codereview.chromium.org/13979017

git-svn-id: http://skia.googlecode.com/svn/trunk@8881 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger Housekeepers.
rmistry@google.com [Fri, 26 Apr 2013 16:29:53 +0000 (16:29 +0000)]
Whitespace change to trigger Housekeepers.
(RunBuilders:Skia_PerCommit_House_Keeping)

git-svn-id: http://skia.googlecode.com/svn/trunk@8880 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger Housekeepers.
rmistry@google.com [Fri, 26 Apr 2013 16:21:21 +0000 (16:21 +0000)]
Whitespace change to trigger Housekeepers.
(RunBuilders:Skia_PerCommit_House_Keeping)

git-svn-id: http://skia.googlecode.com/svn/trunk@8879 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM: specify that currently used checksums are CityHashes of SkBitmaps
epoger@google.com [Fri, 26 Apr 2013 15:06:44 +0000 (15:06 +0000)]
GM: specify that currently used checksums are CityHashes of SkBitmaps
(distinct from other hash algorithms we may switch to, or hashes of
files such as PDFs that cannot be read into an SkBitmap)

Review URL: https://codereview.chromium.org/14284018

git-svn-id: http://skia.googlecode.com/svn/trunk@8877 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 26 Apr 2013 07:00:58 +0000 (07:00 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8873 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorename SkRationalQuad to SkConic
mike@reedtribe.org [Fri, 26 Apr 2013 00:58:29 +0000 (00:58 +0000)]
rename SkRationalQuad to SkConic

git-svn-id: http://skia.googlecode.com/svn/trunk@8872 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove useless SkRect::sort
robertphillips@google.com [Thu, 25 Apr 2013 22:25:29 +0000 (22:25 +0000)]
Remove useless SkRect::sort

https://codereview.chromium.org/14203008/

git-svn-id: http://skia.googlecode.com/svn/trunk@8871 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNexus 7 performance trigger rebaselines
robertphillips@google.com [Thu, 25 Apr 2013 22:23:43 +0000 (22:23 +0000)]
Nexus 7 performance trigger rebaselines

(SkipBuildbotRuns)

-This line, and those below, will be ignored--

M    bench/bench_expectations.txt

git-svn-id: http://skia.googlecode.com/svn/trunk@8870 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoimpl onCreateFrom... for fontmgr on windows
reed@google.com [Thu, 25 Apr 2013 20:40:02 +0000 (20:40 +0000)]
impl onCreateFrom... for fontmgr on windows

git-svn-id: http://skia.googlecode.com/svn/trunk@8869 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAvoid side effects related to skia error callbacks in the testing infrastructure
humper@google.com [Thu, 25 Apr 2013 18:33:49 +0000 (18:33 +0000)]
Avoid side effects related to skia error callbacks in the testing infrastructure

BUG=

Review URL: https://codereview.chromium.org/14447018

git-svn-id: http://skia.googlecode.com/svn/trunk@8867 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse SkError for a bitmap that could not be decoded.
scroggo@google.com [Thu, 25 Apr 2013 18:29:32 +0000 (18:29 +0000)]
Use SkError for a bitmap that could not be decoded.

When recreating an SkPicture from an SkStream, use the
new error reporting system to report that an SkBitmap
could not be decoded.

Add a test that the parse error is thrown.

Review URL: https://codereview.chromium.org/13892009

git-svn-id: http://skia.googlecode.com/svn/trunk@8866 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTemporarily disable HardLight effect in unit tests.
jvanverth@google.com [Thu, 25 Apr 2013 18:26:36 +0000 (18:26 +0000)]
Temporarily disable HardLight effect in unit tests.

git-svn-id: http://skia.googlecode.com/svn/trunk@8865 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdates to skimage tool to use it for testing.
scroggo@google.com [Thu, 25 Apr 2013 17:33:51 +0000 (17:33 +0000)]
Updates to skimage tool to use it for testing.

skimage_main.cpp:
More changes in the interest of testing our decoders.

force_all_opaque before writing PNG files.

Test reencoding the image to its original type (if possible), and
then test redecoding it (to make sure the encoding was successful).
Add an option to turn off this behavior.

Merge decodeFileAndWrite with decodeFile.

SkImageDecoder:
Add kUnknown_Type to SkImageEncoder::Types.

Add a static function to get the Format of an SkStream.

In getFormatName(), remove an incorrect assert.

When calling the flavor of DecodeStream that returns the Format,
check the stream if the decoder returns kUnknown_Format.

BUG=https://code.google.com/p/skia/issues/detail?id=1241

Review URL: https://codereview.chromium.org/14363003

git-svn-id: http://skia.googlecode.com/svn/trunk@8862 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReduce calls to SkMatrix::reset from GrDrawState
robertphillips@google.com [Thu, 25 Apr 2013 17:23:46 +0000 (17:23 +0000)]
Reduce calls to SkMatrix::reset from GrDrawState

https://codereview.chromium.org/14474011/

git-svn-id: http://skia.googlecode.com/svn/trunk@8861 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWork around overzealous assertion in SkMaskFilter.
tomhudson@google.com [Thu, 25 Apr 2013 16:56:40 +0000 (16:56 +0000)]
Work around overzealous assertion in SkMaskFilter.

When drawing nine-patch filters, we assert that the source contains the
destination. However, at least on the new analytic rect blur path, we can get
0-width destinations, and a 0-width rectangle is considered empty and therefore
*not contained in any other rectangle*, even if the bounds are valid and
numerically properly contained.

This patch makes sure we don't try to draw any of the four corners if they
are of 0 width or height. (The assert doesn't exist on the other codepaths.)

git-svn-id: http://skia.googlecode.com/svn/trunk@8860 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GPU support for roundrects
commit-bot@chromium.org [Thu, 25 Apr 2013 15:27:00 +0000 (15:27 +0000)]
Add GPU support for roundrects

This uses the OvalRenderer to render roundrects as "stretched ovals." It adds an
additional shader that handles the straight edges of ellipsoid roundrects better,
and uses the circle shader for roundrects where the two radii are the same. Only
axis-aligned, simple roundrects are supported. Handles fill, stroke and hairline.

R=bsalomon@google.com, robertphillips@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/13852049

git-svn-id: http://skia.googlecode.com/svn/trunk@8859 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodisable checking the style name from fontmgr (not impl on some backends,
reed@google.com [Thu, 25 Apr 2013 14:59:32 +0000 (14:59 +0000)]
disable checking the style name from fontmgr (not impl on some backends,
and likely will be remvoed in future api)

git-svn-id: http://skia.googlecode.com/svn/trunk@8858 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding missing SK_API identifier to class so that it's accessible in debug blink.
sugoi@google.com [Thu, 25 Apr 2013 14:54:15 +0000 (14:54 +0000)]
Adding missing SK_API identifier to class so that it's accessible in debug blink.

Review URL: https://codereview.chromium.org/14190016

git-svn-id: http://skia.googlecode.com/svn/trunk@8857 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix build : add src\pathops to pathops_unittest
caryclark@google.com [Thu, 25 Apr 2013 14:28:14 +0000 (14:28 +0000)]
fix build : add src\pathops to pathops_unittest

git-svn-id: http://skia.googlecode.com/svn/trunk@8856 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops : make it real
caryclark@google.com [Thu, 25 Apr 2013 13:34:40 +0000 (13:34 +0000)]
path ops : make it real

Add an option to SkCanvas to turn on path
ops when combining clips.

Allow Op() to use one of the input paths
as an output path.

Fix a bug in Op() when the minuend is empty
and the subtrahend is not (for difference).

Change the build to allow core to depend on pathops.
Review URL: https://codereview.chromium.org/14474002

git-svn-id: http://skia.googlecode.com/svn/trunk@8855 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded "SkRRect::contains(const SkRect&) const"
robertphillips@google.com [Thu, 25 Apr 2013 12:23:00 +0000 (12:23 +0000)]
Added "SkRRect::contains(const SkRect&) const"

https://codereview.chromium.org/14200044/

git-svn-id: http://skia.googlecode.com/svn/trunk@8854 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdjust some Nexus 7 performance triggers
robertphillips@google.com [Thu, 25 Apr 2013 12:21:18 +0000 (12:21 +0000)]
Adjust some Nexus 7 performance triggers

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@8853 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops : fix empty-diff bug, op-in-place
caryclark@google.com [Thu, 25 Apr 2013 11:51:54 +0000 (11:51 +0000)]
path ops : fix empty-diff bug, op-in-place

add some debugging around reverse diff, inverse
Review URL: https://codereview.chromium.org/13851015

git-svn-id: http://skia.googlecode.com/svn/trunk@8852 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 25 Apr 2013 07:01:04 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8851 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSome fixes for saturation computation XferEffect.
commit-bot@chromium.org [Thu, 25 Apr 2013 00:40:41 +0000 (00:40 +0000)]
Some fixes for saturation computation XferEffect.

R=jvanverth@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/14034018

git-svn-id: http://skia.googlecode.com/svn/trunk@8850 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for compiler error:
robertphillips@google.com [Wed, 24 Apr 2013 22:14:01 +0000 (22:14 +0000)]
Fix for compiler error:

src\core\skdata.cpp(126) : fatal error C1017: invalid integer constant expression

git-svn-id: http://skia.googlecode.com/svn/trunk@8849 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove MMap to SkData.
commit-bot@chromium.org [Wed, 24 Apr 2013 20:03:00 +0000 (20:03 +0000)]
Move MMap to SkData.

R=reed@google.com

Author: bungeman@google.com

Review URL: https://chromiumcodereview.appspot.com/14336003

git-svn-id: http://skia.googlecode.com/svn/trunk@8848 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix the build.
scroggo@google.com [Wed, 24 Apr 2013 19:37:52 +0000 (19:37 +0000)]
Fix the build.

Allow NULL for defaultValue in SkCommandLineFlags.

unreviewed.

Review URL: https://codereview.chromium.org/14472017

git-svn-id: http://skia.googlecode.com/svn/trunk@8847 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding new bench tests for lighting and blur
sugoi@google.com [Wed, 24 Apr 2013 19:36:44 +0000 (19:36 +0000)]
Adding new bench tests for lighting and blur

Review URL: https://codereview.chromium.org/14474004

git-svn-id: http://skia.googlecode.com/svn/trunk@8846 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTreat default command line argument properly.
scroggo@google.com [Wed, 24 Apr 2013 19:25:26 +0000 (19:25 +0000)]
Treat default command line argument properly.

In SkCommandLineFlags, if the client sets a default value
of multiple arguments (e.g. "arg0 arg1 ..."), set
the actual defaults to all of those arguments separately
(i.e. an array with [0] == "arg0", [1] == "arg1", ...),
rather than as one string (i.e. [0] == "arg0 arg1 ...").

Remove the hack that worked around this bug.

Also move the increasingly complicated implementation of
SkFlagInfo::CreateStringFlag into the cpp file.

BUG=https://code.google.com/p/skia/issues/detail?id=1237

Review URL: https://codereview.chromium.org/14366034

git-svn-id: http://skia.googlecode.com/svn/trunk@8845 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofirst impl of fontmgr for gdi
reed@google.com [Wed, 24 Apr 2013 19:14:56 +0000 (19:14 +0000)]
first impl of fontmgr for gdi

git-svn-id: http://skia.googlecode.com/svn/trunk@8844 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshow fontstyle values for each style
reed@google.com [Wed, 24 Apr 2013 19:14:39 +0000 (19:14 +0000)]
show fontstyle values for each style

git-svn-id: http://skia.googlecode.com/svn/trunk@8843 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd option to specify defaults configs to --config flag in gm. This makes it easier...
bsalomon@google.com [Wed, 24 Apr 2013 18:07:11 +0000 (18:07 +0000)]
Add option to specify defaults configs to --config flag in gm. This makes it easier to run gm defaults configs with a delta. Also make ~ exclude a config.

Review URL: https://codereview.chromium.org/13842014

git-svn-id: http://skia.googlecode.com/svn/trunk@8842 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExit ~GrContext early if GrContext::init() failed.
bsalomon@google.com [Wed, 24 Apr 2013 17:59:32 +0000 (17:59 +0000)]
Exit ~GrContext early if GrContext::init() failed.

Review URL: https://codereview.chromium.org/14049028

git-svn-id: http://skia.googlecode.com/svn/trunk@8841 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test Commit Queue (SkipBuildbotRuns)
commit-bot@chromium.org [Wed, 24 Apr 2013 17:52:36 +0000 (17:52 +0000)]
Whitespace change to test Commit Queue (SkipBuildbotRuns)

R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/14474009

git-svn-id: http://skia.googlecode.com/svn/trunk@8840 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing numerical rounding edge case in SkTileGrid
junov@chromium.org [Wed, 24 Apr 2013 15:39:11 +0000 (15:39 +0000)]
Fixing numerical rounding edge case in SkTileGrid

BUG=https://code.google.com/p/chromium/issues/detail?id=234688
TEST=TileGrid skia unit test

Review URL: https://codereview.chromium.org/13860011

git-svn-id: http://skia.googlecode.com/svn/trunk@8839 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a bug in SkTextBox.
scroggo@google.com [Wed, 24 Apr 2013 14:10:57 +0000 (14:10 +0000)]
Fix a bug in SkTextBox.

When checking to see if the line of text is beyond the bottom of
the textbox, compare with the bottom, rather than the height (bottom
- top). Prior to this change, text in the bottom of a textbox could
be clipped out.

BUG=https://code.google.com/p/skia/issues/detail?id=1250

Review URL: https://codereview.chromium.org/13856017

git-svn-id: http://skia.googlecode.com/svn/trunk@8838 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix compile warning on mac that breaks a bot, and remove jpeg creation bitmap since...
edisonn@google.com [Wed, 24 Apr 2013 13:21:49 +0000 (13:21 +0000)]
Fix compile warning on mac that breaks a bot, and remove jpeg creation bitmap since we mock the compression.

git-svn-id: http://skia.googlecode.com/svn/trunk@8836 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEncode images with DCTDecode (JPEG) in PDFs if it makes sense. Fallback to FlateDecod...
edisonn@google.com [Wed, 24 Apr 2013 13:01:01 +0000 (13:01 +0000)]
Encode images with DCTDecode (JPEG) in PDFs if it makes sense. Fallback to FlateDecode (zip) if it makes sense. Otherewise include uncompressed stream.
This change will reduce the size of PDFs to 50% (in the case of the existing SKPs, we reduce the total size of PDFs from 105MB to 50MB)
Review URL: https://codereview.appspot.com/7068055

git-svn-id: http://skia.googlecode.com/svn/trunk@8835 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 24 Apr 2013 07:01:07 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8833 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd stroked rrect benches.
jvanverth@google.com [Tue, 23 Apr 2013 19:14:03 +0000 (19:14 +0000)]
Add stroked rrect benches.

Review URL: https://codereview.chromium.org/14238017/

git-svn-id: http://skia.googlecode.com/svn/trunk@8832 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoARGB image encoder for checksums.
bungeman@google.com [Tue, 23 Apr 2013 18:06:23 +0000 (18:06 +0000)]
ARGB image encoder for checksums.
https://codereview.chromium.org/14267031/

git-svn-id: http://skia.googlecode.com/svn/trunk@8831 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoits ok if there is no family name in the pattern for fontconfig, for fc will interpret
reed@google.com [Tue, 23 Apr 2013 16:35:09 +0000 (16:35 +0000)]
its ok if there is no family name in the pattern for fontconfig, for fc will interpret
an empty string as looking for the default (which is our intent).

git-svn-id: http://skia.googlecode.com/svn/trunk@8830 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix an SkCommandLineFlags bug.
scroggo@google.com [Tue, 23 Apr 2013 15:38:09 +0000 (15:38 +0000)]
Fix an SkCommandLineFlags bug.

Previously I was storing an SkTDArray of const char*,
which fails if the strings go out of scope.

Instead, store an SkTArray of SkString, and copy the
strings, so we do not depend on the strings sticking
around. Using an SkTArray because it is smart enough
to call the destructors, so the copies can be destroyed
on program exit.

BUG=https://code.google.com/p/skia/issues/detail?id=1237

Review URL: https://codereview.chromium.org/14414008

git-svn-id: http://skia.googlecode.com/svn/trunk@8829 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove static effects from the effect memory pool.
bsalomon@google.com [Tue, 23 Apr 2013 15:37:27 +0000 (15:37 +0000)]
Remove static effects from the effect memory pool.
Review URL: https://codereview.chromium.org/14081016

git-svn-id: http://skia.googlecode.com/svn/trunk@8828 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd block comment for using SkChecksum
reed@google.com [Tue, 23 Apr 2013 15:35:24 +0000 (15:35 +0000)]
add block comment for using SkChecksum

git-svn-id: http://skia.googlecode.com/svn/trunk@8827 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix
sugoi@google.com [Tue, 23 Apr 2013 14:37:38 +0000 (14:37 +0000)]
Build fix

git-svn-id: http://skia.googlecode.com/svn/trunk@8826 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded a few bench for some image filters
sugoi@google.com [Tue, 23 Apr 2013 14:20:45 +0000 (14:20 +0000)]
Added a few bench for some image filters

Review URL: https://codereview.chromium.org/14234019

git-svn-id: http://skia.googlecode.com/svn/trunk@8824 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops : enable optimizations
caryclark@google.com [Tue, 23 Apr 2013 12:04:05 +0000 (12:04 +0000)]
path ops : enable optimizations

this addresses a few FIXME issues
- speed up implicit quad computation
- use ulps instead of epsilon
- assert on bad line results more often

git-svn-id: http://skia.googlecode.com/svn/trunk@8823 2bbb7eff-a529-9590-31e7-b0007b416f81