Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 07:30:54 +0000 (16:30 +0900)]
evas cache image - remove double unlock of image task locks.
this is indeed a bug and fixes coverity CID 1367492
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 07:20:17 +0000 (16:20 +0900)]
eina share - fix spinlock release if magic check fails on share data
this fixes a potential double spinlock unrelease if magic check fails
on share data. this fixes CID 1367493
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 06:35:19 +0000 (15:35 +0900)]
evas image obj - remove logically dead code
coverity is right - it's logically dead code. fix CID 1367774
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 02:54:45 +0000 (11:54 +0900)]
evas image load - remove unreachable code
it's just printing a warning anyway and coverity CID 1368210 is right
as it says it's unreachable. fix.
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 02:45:09 +0000 (11:45 +0900)]
evas image load - handle null module handle in case
this fixes CID 1368338
Stefan Schmidt [Wed, 8 Feb 2017 11:05:12 +0000 (12:05 +0100)]
build: do not use a absolute system path for service files during distcheck
Our systemd service files are installed into an absolute system path by default
which simply does not work when doing a distcheck. Set the path differently for
the distcheck options.
Amitesh Singh [Wed, 8 Feb 2017 04:23:21 +0000 (09:53 +0530)]
elm code: check return value of elm_layout_theme_set
fixes CID 1366922
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 02:33:42 +0000 (11:33 +0900)]
ecore_con proxy helper - fix null return handling for thread q wait
this fixes CID 1368376
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 02:26:26 +0000 (11:26 +0900)]
Revert "evas_async_events: integrated Ecore_Pipe in evas_async_events"
This reverts commit
ea0492e0c6912af704b14e51ea80715e2486ef2d.
this drops software engine rendering to like 5-10fps! or at least
visually about that... not tested enough at all!
Cedric BAIL [Wed, 8 Feb 2017 00:32:44 +0000 (16:32 -0800)]
ecore: add test to make sure that the timer reset during callback work as expected.
Cedric BAIL [Wed, 8 Feb 2017 00:32:22 +0000 (16:32 -0800)]
ecore: reset during timer callback execution doesn't make sense.
@fix
T3222
Carsten Haitzler (Rasterman) [Tue, 7 Feb 2017 13:55:36 +0000 (22:55 +0900)]
evas destructor - take lock arount post render list while freeing
this should fix CID 1369019 though really shouldnt be an issue...
Carsten Haitzler (Rasterman) [Tue, 7 Feb 2017 13:41:07 +0000 (22:41 +0900)]
eina freeq - fix possible seg with NULL freeq and pattern fill logic
this fixes handling of a NULL freeq handle - found by coverity.
fixes CID 1369021
Carsten Haitzler (Rasterman) [Tue, 7 Feb 2017 13:07:53 +0000 (22:07 +0900)]
evas cserve client - fix theoretical size less than 0 issue
theoretically size might be zero but it won't be... but make coverity
happy so it doesn't come back to triage
fix CID 1361430
Carsten Haitzler (Rasterman) [Tue, 7 Feb 2017 12:21:36 +0000 (21:21 +0900)]
evas textblock filter data set - avoid crash on freeing data binding
if balue is NULL the data binding is removed and freed, but we don't
return at that point but instead fall back to using/replacing the
databinding.
this fixes CID 1369022
Carsten Haitzler (Rasterman) [Sun, 5 Feb 2017 04:23:05 +0000 (13:23 +0900)]
ecore thread - up default 3 of thread workers to 4x cpu cures
this ups it from number of cpu cores to 4 times that (so if threads to
blocking i/o the spare cycles can be used up).
Jee-Yong Um [Tue, 7 Feb 2017 23:08:19 +0000 (15:08 -0800)]
edje: fix cached edje modification issue
Summary:
_edje_part_***_set/get (for mouse_events, repeat_events, ignore_flags, mask_flags)
overwrite cached edje value. These behaviors affect all edje object added after
these changes, and result in not intended.
@fix
Reviewers: jpeg, cedric
Subscribers: akanad, woohyun
Differential Revision: https://phab.enlightenment.org/D4362
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jiwon Kim [Tue, 7 Feb 2017 23:06:01 +0000 (15:06 -0800)]
eet: read sould be failed if cipher_key exist but file not ciphered
Summary:
Currentely, if eet_read_cipher()'s cipher_key param is exist but file
not ciphered, function always read and return successful result.
But, this behavior can not check data integrity.
e.g.
1. App create config file using eet with encryption key.
2. Attacker replace config to malicious config (not encryted).
3. App can not notice if eet_read_cipher() read that successfully.
@fix
Test Plan:
$eet -e test.cfg my_config test.src 1
$eet -d test.cfg my_config decode_res.txt my_encrytion_key
(Currentely decode success, but should be failed)
Reviewers: woohyun, raster
Subscribers: id213sin, akanad, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4563
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jiwon Kim [Tue, 7 Feb 2017 23:04:57 +0000 (15:04 -0800)]
elementary: set mirrored mode in a group_add()
Summary:
When a scroller just added and theme not changed,
scrollable interface's 'mirrored' property is always default.
elm_config_mirrored_set(EINA_TRUE) -> elm_scroller_add(),
: No mirrored mode
elm_scroller_add() -> elm_config_mirrored_set(EINA_TRUE),
: Mirrored mode
@fix
Test Plan:
1-1. elementary_test scroller
1-2. Turn on UI-Mirroring
2-1. elementary_test
2-2. Turn on UI-Mirroring
2-3. Click 'scroller' button
(Check scroller test's 'prev page' and 'next page' buttons)
Reviewers: cedric, woohyun, akanad
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4564
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Wonki Kim [Tue, 7 Feb 2017 23:03:45 +0000 (15:03 -0800)]
elm_scroller: keep contents layout rel even if rtl is set
Summary:
Once rtl mode is set, elm_layout reverses its x-axis.
however, scroller uses elm_layout to contain both original content and
proxy image of it when loop mode is set.
In this situation, elm_layout should not reverse its x-axis when It is
used for container of proxy to support loop mode of scroller.
This commit will not apply rtl mode to contents layout (mirrored set)
Test Plan:
* Check that there is a proxy image over right edge of original content.
1. Run elementary_test
2. Open scroller
3. Switch UI_mirrored mode on
4. Test (Control with keyboard / mouse wheel control looks bad on rtl mod)
a. go to the right edge with keyboard
b. get over the edge
Reviewers: woohyun, z-wony, jpeg, cedric
Differential Revision: https://phab.enlightenment.org/D4568
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Minkyu Kang [Tue, 7 Feb 2017 23:00:35 +0000 (15:00 -0800)]
elm_genlist: do not check scroll if show_item is NULL
Summary:
If show_item is NULL then does not need to check scroll.
But, sometimes show_item is NULL but check_scroll is true.
It was wrong and can makes a crash.
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Reviewers: cedric, Hermet, SanghyeonLee, raster
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4569
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Ivan Furs [Tue, 7 Feb 2017 22:50:32 +0000 (14:50 -0800)]
eina_file: add eina_file_unlink
Test Plan: split D4423 - unlink
Reviewers: raster, vtorri, an.kroitor, jpeg, reutskiy.v.v, NikaWhite, cedric
Reviewed By: cedric
Subscribers: artem.popov, cedric, vtorri, jpeg
Tags: #windows, #efl
Differential Revision: https://phab.enlightenment.org/D4485
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Derek Foreman [Tue, 7 Feb 2017 22:53:09 +0000 (16:53 -0600)]
elput: Fix async input shutdown during init
By only checking if the thread was cancelled *after* sending feedback
to the main thread we ended up claiming all the devices libinput
asked for in a way that never allowed them to be released
(how the hell can a cancelled thread send feedback?)
Jee-Yong Um [Tue, 7 Feb 2017 21:42:45 +0000 (13:42 -0800)]
elm.entry: add configuration for the default value of select_allow
Summary:
Small devices (like smart watch) can disallow entry selection by default.
This patch enables to control this behavior with elementary configuration.
Reviewers: cedric, jpeg
Subscribers: id213sin, woohyun
Differential Revision: https://phab.enlightenment.org/D4615
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Tue, 7 Feb 2017 21:41:34 +0000 (13:41 -0800)]
emile: don't use APIs deprecated in openssl-1.1
Summary:
When openssl-1.1.0 is built with `--api=1.1 disable-deprecated`, use of
deprecated APIs leads to build failures.
X-Gentoo-Bug: 606628
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=606628
Subscribers: cedric, jpeg
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D4616
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Tue, 7 Feb 2017 21:41:20 +0000 (13:41 -0800)]
edje_load: fix mirroring bug with GROUP, BOX, or TABLE part
Summary:
Mirrored stated should be applied to new edje_object
which is created for GROUP, BOX, or TABLE part.
@fix
Reviewers: woohyun, raster, cedric, jpeg, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D4618
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Ivan Furs [Tue, 7 Feb 2017 21:40:48 +0000 (13:40 -0800)]
evas_async_events: integrated Ecore_Pipe in evas_async_events
Summary:
Integrated Ecore_Pipe in evas_async_events
Reviewers: #eflete, raster, jpeg, vtorri, artem.popov, cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4622
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Tue, 7 Feb 2017 22:17:17 +0000 (14:17 -0800)]
evas: we now need to initialize ecore as it is a dependency.
se.osadchy [Tue, 7 Feb 2017 21:37:11 +0000 (13:37 -0800)]
elm gesture layer: add check for negative input tap start timeout.
Summary:
Add set 0 as start timeout if negative input value.
@fix
Reviewers: cedric, Hermet, raster
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4625
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
YeongJong Lee [Tue, 7 Feb 2017 21:36:40 +0000 (13:36 -0800)]
efl_ui_image: fix wrong define
Reviewers: jypark, jpeg, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D4626
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
YeongJong Lee [Tue, 7 Feb 2017 21:36:16 +0000 (13:36 -0800)]
efl_ui_flip: fix wrong define
Reviewers: jpeg, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D4627
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Minchul Lee [Tue, 7 Feb 2017 21:34:55 +0000 (13:34 -0800)]
gitignore: add eclipse project filename.
Summary: Import a project on Eclipse. These files are created automatically.
Reviewers: raster, cedric, jpeg, Hermet
Differential Revision: https://phab.enlightenment.org/D4637
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Sungtaek Hong [Tue, 7 Feb 2017 21:31:03 +0000 (13:31 -0800)]
elm_panel: set scrollable panel unfocusable when closed.
Summary:
- When scrollable panel is closed by elm_panel_hidden_set(),
elm_panel_toggle() APIs, it shows animation with
scroller bringin effect.
- During this animation, panel is still focusable, and may
stop closing when content gets focused.
- scrollable panel is now set unfocusable when closed by
APIs above, and set focusable when opened after bringin
animation.
Test Plan:
1) Set panel scrollable and opened.
2) Set another object focused and deleted it
when panel is closing.
3) Observe panel is closed.
Reviewers: cedric, jpeg, woohyun
Subscribers: conr2d, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4641
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Sungtaek Hong [Tue, 7 Feb 2017 21:29:57 +0000 (13:29 -0800)]
elm_index: skip level check when only 0 level is active
Summary:
- In mouse move callback, index tries to calculate
current level.
- This is not needed when level 1 is not active.
and blocks index item change.
Test Plan:
1) Run elementary test -> any vertical index.
2) Click on index item and drag to outside of index.
3) Observe index item is now changed as mouse movement.
Reviewers: cedric, Hermet, jpeg, eunue
Reviewed By: cedric
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4643
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Myoungwoon Roy, Kim [Tue, 7 Feb 2017 21:28:47 +0000 (13:28 -0800)]
doxygen: fix typo, cacologique expressions in API reference doxygen.
Summary: Fix typos, cacologique expressions in Ecore API reference doxygen.
Test Plan: doxygen
Reviewers: stefan, cedric, raster, Jaehyun_Cho
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4646
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Mykola Solyanko [Tue, 7 Feb 2017 21:25:44 +0000 (13:25 -0800)]
eldbus: add test suite for eldbus (eldbus_message*)
Summary:
add tests for next API
eldbus_message_iter_get()
eldbus_message_iter_signature_get()
eldbus_message_iter_arguments_get()
eldbus_message_iter_get_and_next()
eldbus_message_error_get()
eldbus_message_method_call_new()
eldbus_message_interface_get()
eldbus_message_member_get()
eldbus_message_path_get()
eldbus_message_sender_get()
eldbus_message_destination_get()
eldbus_message_arguments_get()
eldbus_message_error_get()
eldbus_message_signal_new()
eldbus_message_ref()
eldbus_message_unref()
eldbus_message_to_eina_value()
eldbus_message_iter_basic_get()
eldbus_message_error_get()
eldbus_message_iter_next()
eldbus_message_arguments_vappend()
Reviewers: cedric, raster, myoungwoon, NikaWhite
Subscribers: jpeg, artem.popov
Differential Revision: https://phab.enlightenment.org/D4649
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chris Michael [Tue, 7 Feb 2017 17:00:15 +0000 (12:00 -0500)]
elput: Delete output_name stringshare on error case
This actually should have been part of the previous patch which moved
setting output_name to evdev, but it got missed so add it now. This
ensures we cleanup the output_name stringshare on error.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 7 Feb 2017 16:34:57 +0000 (11:34 -0500)]
elput: Remove dead FIXME note
As device calibration has already been handled via external facing
API, this FIXME note is no longer needed.
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 7 Feb 2017 16:33:25 +0000 (11:33 -0500)]
elput: Set device output name when device is created
Small patch to set the output name of an Elput_Device when the device
gets created. Note, this was already being done inside elput_input,
but this patch moves it to when the device gets created.
NB: Really no functional changes here, just moving a function call.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 7 Feb 2017 15:50:09 +0000 (10:50 -0500)]
elementary: Fix return of elm_win_wl_window_get
This patch fixes an issue where the wrong wayland window would be
returned from elm_win_wl_window_get. When we lookup a window in
Enlightenment, this function would end up returning the parent window
(if existed) when what we want there is the actual window. This patch
puts the function more in line with the X11 equivalent.
Fixes T5142
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Marcel Hollerbach [Fri, 3 Feb 2017 18:23:47 +0000 (19:23 +0100)]
cmake: add ecore_x
Marcel Hollerbach [Fri, 3 Feb 2017 18:22:37 +0000 (19:22 +0100)]
ecore_x: we dont need this version file anymore
it indicated a while back which backend was used, we only have xlib
left.
Amitesh Singh [Tue, 7 Feb 2017 05:13:48 +0000 (10:43 +0530)]
access: fix crash while cleanup
The item is already deleted at this point and its garbage here
which results into crash ultimately.
Also I don't see a point in setting access_obj to NULL here
@fix
Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>
Andy Williams [Mon, 6 Feb 2017 23:39:15 +0000 (23:39 +0000)]
elm_code: syntax fix for preprocessor over multiple lines
Andy Williams [Mon, 6 Feb 2017 23:38:23 +0000 (23:38 +0000)]
elm_code: syntax fix for comments with an escaped blackslash
Cedric BAIL [Mon, 6 Feb 2017 23:35:48 +0000 (15:35 -0800)]
ecore: make sure we always manipulate a valid timer.
Felipe Magno de Almeida [Mon, 20 Jun 2016 21:50:38 +0000 (18:50 -0300)]
efl: add composite model for boolean properties
Add Efl.Model.Composite.Boolean, a model for wrapping another Efl.Model and
adding boolean properties to its children.
Children of the given composite model will have the boolean properties
specified in Efl.Model.Composite.Boolean with the specified default value.
A call to Efl.Model.Property_set can change the property value for a child.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Larry Jr [Tue, 31 Jan 2017 20:17:58 +0000 (18:17 -0200)]
efl: add efl_model and efl_ui_view classes
Efl.Model.Container and Efl.Model.Item to efl/interfaces are used
to create Efl.Model objects with predefined property values.
This is useful to any situation where we want an Efl.Model with
explicit defined property values.
Efl.Ui.View and Efl.Ui.Factory are used to connect Efl.Models with
Widgets, Elm.Layout and Efl.Ui.Image has changed to use news interfaces
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Mon, 6 Feb 2017 22:29:56 +0000 (14:29 -0800)]
ecore: handle initialization of timer correctly.
Cedric BAIL [Mon, 6 Feb 2017 18:46:00 +0000 (10:46 -0800)]
evas: more hardening of evas access map.x
Cedric BAIL [Mon, 6 Feb 2017 18:45:12 +0000 (10:45 -0800)]
evas: harden check on map presence.
Jerome Pinot [Sun, 5 Feb 2017 12:56:18 +0000 (21:56 +0900)]
edje_example: fix compile instruction
Marcel Hollerbach [Sat, 4 Feb 2017 22:41:55 +0000 (23:41 +0100)]
elm_notify: null out allow events when its deleted
otherwise later dismisscalls to that object will lead to spammy error
messages in the console
Chidambar Zinnoury [Sat, 4 Feb 2017 18:12:03 +0000 (19:12 +0100)]
ecore thread: Fix waiting.
Waiting would sometimes return as if the thread finished correctly while it is still running.
This is because we’re waiting for the waiter data to be null… but this is always the case if the user-passed data is null!
@fix
Amitesh Singh [Sat, 4 Feb 2017 07:48:55 +0000 (13:18 +0530)]
edje: unset timer pointer after delete.
Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>
Carsten Haitzler (Rasterman) [Sat, 4 Feb 2017 02:31:55 +0000 (11:31 +0900)]
evas render - drop eo overhead by using ptrs we already have
several calls, specifically evas_object_change_reset,
evas_object_cur_prev, and evas_object_clip_changes_clean that are
called directly or indirectly as part of evas render on at least every
active object if not more, were doing full eo obj lookups when their
calling functions already all had the eo protected data looked up.
tha's silly and just adds overhead we don't need. my test dropped
_eo_obj_pointer_get overhead in perf profiles from 4.48% to 2.65%. see:
4.48% libeo.so.1.18.99 [.] _eo_obj_pointer_get
4.23% libevas.so.1.18.99 [.] evas_render_updates_internal
2.61% libevas.so.1.18.99 [.] evas_render_updates_internal_loop
1.68% libeo.so.1.18.99 [.] efl_data_scope_get
1.57% libc-2.24.so [.] _int_malloc
1.42% libevas.so.1.18.99 [.] evas_object_smart_changed_get
1.09% libevas.so.1.18.99 [.] evas_object_clip_recalc.part.37
1.08% libpthread-2.24.so [.] pthread_getspecific
1.05% libevas.so.1.18.99 [.] efl_canvas_object_class_get
1.01% libevas.so.1.18.99 [.] evas_object_cur_prev
0.99% libeo.so.1.18.99 [.] _efl_object_event_callback_legacy_call
0.87% libevas.so.1.18.99 [.] _evas_render_phase1_object_ctx_render_cache_append
0.82% libpthread-2.24.so [.] pthread_mutex_lock
0.81% libevas.so.1.18.99 [.] _evas_render_phase1_object_process
0.79% libc-2.24.so [.] _int_free
vs now the improved:
4.82% libevas.so.1.18.99 [.] evas_render_updates_internal
3.44% libevas.so.1.18.99 [.] evas_render_updates_internal_loop
2.65% libeo.so.1.18.99 [.] _eo_obj_pointer_get
2.22% libc-2.24.so [.] _int_malloc
1.46% libevas.so.1.18.99 [.] evas_object_smart_changed_get
1.04% libeo.so.1.18.99 [.] _efl_object_event_callback_legacy_call
1.03% libevas.so.1.18.99 [.] _evas_render_phase1_object_ctx_render_cache_append
0.97% libeina.so.1.18.99 [.] eina_chained_mempool_malloc
0.93% libevas.so.1.18.99 [.] evas_object_clip_recalc.part.37
0.92% libpthread-2.24.so [.] pthread_mutex_lock
0.91% libevas.so.1.18.99 [.] _evas_render_phase1_object_process
0.84% libc-2.24.so [.] _int_free
0.84% libevas.so.1.18.99 [.] evas_object_cur_prev
0.83% libeina.so.1.18.99 [.] eina_chained_mempool_free
0.80% libeo.so.1.18.99 [.] efl_data_scope_get
of course other things "increase their percentage" as oe overhead now
dropped, and things seem to move around a bit, but it does make sense
to do this with no downsides i can see as we already are accessing the
protected data ptr in the parent func.
Derek Foreman [Fri, 3 Feb 2017 21:54:48 +0000 (15:54 -0600)]
ecore_evas: use ecore_timer_loop_add for idle timeout update
This shouldn't need "exact" time, so use a loop time based timer
to potentially save a syscall on archs that don't have a vdso.
@optimize
Cedric BAIL [Fri, 3 Feb 2017 19:12:28 +0000 (11:12 -0800)]
ecore: poller could actually be related to the main loop timing.
Reduce call to ecore_time_get which is a syscall to gettimeofday.
Mike Blumenkrantz [Fri, 3 Feb 2017 20:14:01 +0000 (15:14 -0500)]
elput: add event for relative motion
@feature
Andy Williams [Fri, 3 Feb 2017 17:17:05 +0000 (17:17 +0000)]
elm_code: fix bugs in the highlighting of full line comments
@fix
Andy Williams [Fri, 3 Feb 2017 17:16:12 +0000 (17:16 +0000)]
elm_code: Add syntax highlighting for python
Andy Williams [Fri, 3 Feb 2017 17:13:27 +0000 (17:13 +0000)]
elm_code: update syntax symbols for C
Also don't hard code preprocessing parse
Gustavo Sverzut Barbieri [Fri, 3 Feb 2017 14:17:05 +0000 (12:17 -0200)]
cmake: sync EFL_EO_API_SUPPORT definition with autotools.
in autotools we always define that symbol in config.h (thus now done
in common.cmake), while the Efl_Config.h that is generated never have
it, what's left is to enable/disable the legacy and beta APIs.
This fixes building eldbus_suite with cmake.
Gustavo Sverzut Barbieri [Fri, 3 Feb 2017 13:49:38 +0000 (11:49 -0200)]
ifdef RUN_IN_TREE logic.
This logic is only needed for autotools, cmake will replicate the
installation file structure and thus eina_prefix works out of box.
Marcel Hollerbach [Fri, 3 Feb 2017 10:14:45 +0000 (11:14 +0100)]
cmake: add ecore_input
Marcel Hollerbach [Fri, 3 Feb 2017 09:39:23 +0000 (10:39 +0100)]
cmake: add eeze
there is currently a bug in the testsuite which needs to change,
otherwise modules cannot be loaded. The code acutally runs when its
installed and EFL_RUN_IN_TREE is not set.
Marcel Hollerbach [Thu, 2 Feb 2017 23:04:19 +0000 (00:04 +0100)]
eeze: move binaries into subdirectories
in order to move to cmake we are moving every binary into its own
subdirectory.
Carsten Haitzler (Rasterman) [Fri, 3 Feb 2017 05:57:49 +0000 (14:57 +0900)]
ecore_con/efl_net - dedicated threads for network i/o not from the pool
so ecore_con/efl_net were using the standard ecore_thread thread pool
for doing things like dns lookups (that can take multiple minutes
until timeouts) and actual http transactions. similarly they can block
thread workers for long periods or indefinitely thus basically
blocking the whole eocre_thread pool and stopping others from sharing
it. the best solution we have right now is to bypass the thread pool
queue and have dedicated threads for these actions. what we should
have is a dedicated thread pool with each thread taking on N
connections (via select etc.) and the ability to create and destroy
thread pools for specific tasks so you can separate the work out from
other work. but that is basically a redesign of our thread pool infra
so let's do the quick solution here until that day comes.
this partially addresses D4640
a dedicated thread per image load though is going to be a lot nastier...
Carsten Haitzler (Rasterman) [Fri, 3 Feb 2017 05:39:57 +0000 (14:39 +0900)]
edje - fix crash on loading ancient edje files
ancient edje files dont put hash strings in the file dictionary but
instead inline and thus the strings cannot be direct added... silly
ancient files.
this is a horrible ugly workaround this but there isn't really
anything better than trying to detect such files (which dont seem to
have an older version in them i can find?) so detect by pointer
address and mapping the file.
this fixes T5138
@fix
Cedric BAIL [Fri, 3 Feb 2017 00:52:38 +0000 (16:52 -0800)]
ecore: implement new requirement in the test suite.
Cedric BAIL [Fri, 3 Feb 2017 00:52:10 +0000 (16:52 -0800)]
ecore: avoid calling ecore_time_get everytime we create a timer.
This is particularly useful for ecore_timer_loop_add which are not
supposed to trigger any syscall. It does add a new requirement
on the EFL_LOOP_TIME_CLASS to always have an interval defined during
construction.
Stephen 'Okra' Houston [Thu, 2 Feb 2017 21:02:15 +0000 (15:02 -0600)]
Cpumonitor theme - Set an aspect preference other than both so we can properlyl size the gadget.
Gustavo Sverzut Barbieri [Thu, 2 Feb 2017 19:04:44 +0000 (17:04 -0200)]
cmake: add ecore_file.
Gustavo Sverzut Barbieri [Thu, 2 Feb 2017 16:43:40 +0000 (14:43 -0200)]
cmake: add ecore_ipc.
Andy Williams [Thu, 2 Feb 2017 18:47:39 +0000 (18:47 +0000)]
elm_code: Fix empty selection checks
Cedric BAIL [Thu, 2 Feb 2017 18:29:59 +0000 (10:29 -0800)]
evas: simplify waiting logic for image decoding as we do not need lock and cond with Ecore_Thread infra.
Cedric BAIL [Thu, 2 Feb 2017 18:29:39 +0000 (10:29 -0800)]
evas: make sure we always wait in the correct thread.
YeongJong Lee [Thu, 2 Feb 2017 18:07:02 +0000 (18:07 +0000)]
elm_code: add support for redo
Summary:
now, elm_code support redo.
shortcut is <Ctrl> + <y>
Test Plan:
1. elementary_test - Code Editor
2. Check that undo and redo are work correctly.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4642
Carsten Haitzler (Rasterman) [Thu, 2 Feb 2017 01:13:24 +0000 (10:13 +0900)]
evlog - fix "remove setting stack var to 0" that broke evlogs
this fixes
b38c610c7e60cbdcb45fd6d27450e39e3a9c9dd1 - recent commit by
me. bad me! spank!
Carsten Haitzler (Rasterman) [Wed, 1 Feb 2017 23:50:11 +0000 (08:50 +0900)]
evas grid smart - fix divide by 0
if object happens to be 0x0 then we can get a divide by 0... fix!
@fix
Derek Foreman [Wed, 1 Feb 2017 22:21:34 +0000 (16:21 -0600)]
ecore_wl2: Make www events opt-in
Now we must set EFL_WAYLAND_ENABLE_WWW to turn on www. (Note:
this does NOT re-enable any visual effect, it merely controls
the event infrastructure that can be used to let a client
know when its window is mapped or moving)
This wasn't really disabled properly earlier, so disable it now
for a slight performance win when dragging windows (and a major
reduction in log chatter when debugging wayland)
Bruno Dilly [Wed, 1 Feb 2017 19:14:39 +0000 (17:14 -0200)]
edje: change seat signals
Use seat names as prefix, not as suffix, following
a top-down approach and avoiding issues
with applications that may be receiving
doubled signals (legacy + suffixed).
So instead of "mouse,in,seat1" signal will be
"seat,seat1,mouse,in".
Bruno Dilly [Thu, 26 Jan 2017 20:26:23 +0000 (18:26 -0200)]
edje: fix CID 1368019 - Null pointer dereferences
It only should check if it's allowed to focus a part
if a part was passed (if rp is null such check should
be skipped).
Gustavo Sverzut Barbieri [Wed, 1 Feb 2017 18:23:11 +0000 (16:23 -0200)]
efl_net_dialer_http: check for finished handles after unpause.
After we call curl_multi_socket_action() we must call
_efl_net_dialer_http_curlm_check() in order to call
curl_multi_info_read() and be notified of handles that were
finished. Otherwise the handle is gone and we'll be waiting for an
action that will never happen.
Fixes T5079
Derek Foreman [Wed, 1 Feb 2017 17:29:40 +0000 (11:29 -0600)]
build: Fix screw up with wayland header auto generation
Gustavo Sverzut Barbieri [Wed, 1 Feb 2017 14:25:43 +0000 (12:25 -0200)]
cmake: handle 'FindXXX.cmake' standard with 'find-XXX' libraries.
One can use virtual 'find-XXX' entries in LIBRARIES or
PUBLIC_LIBRARIES to use XXX_LIBRARIES and XXX_INCLUDE_DIR.
Gustavo Sverzut Barbieri [Wed, 1 Feb 2017 14:25:08 +0000 (12:25 -0200)]
cmake: handle support libraries in .pc
support libraries (src/static_libs), such as rg_etc, must not be
handled as a regular target, after all these are usually not shared
library and if they are, they have no .pc associated, then we use "-l"
as for system libraries, but using the installation path.
Stefan Schmidt [Wed, 1 Feb 2017 13:22:11 +0000 (14:22 +0100)]
cmake: remove dependency on libjpeg in eet as it is handled in common
Vyacheslav Reutskiy [Wed, 1 Feb 2017 13:08:13 +0000 (15:08 +0200)]
Revert "edje_edit: fix segmentation fault(Array index is out of bound)"
This patch need to revert because it just a temporary solution for load
'inherit_only' groups. Problem with these groups is solved in patch
c3733a213ba2de3acc2496a381e8e3f591f2c10a
This reverts commit
88f5ac22c1dcd2ddaf4fda4f170fb5c0ad9b3afd.
Vyacheslav Reutskiy [Wed, 1 Feb 2017 13:02:46 +0000 (15:02 +0200)]
edje_cc: remove 'inherit_only' groups from result edj file
The 'inherit_only' groups are helpers and no sense to save it to edj
file.
@fix
Marcel Hollerbach [Wed, 1 Feb 2017 11:19:24 +0000 (12:19 +0100)]
cmake: emile is depending on efl
there is some .eot.h file included from the efl interfaces, so we need a
dependency here
Marcel Hollerbach [Wed, 1 Feb 2017 11:18:33 +0000 (12:18 +0100)]
cmake: use the jpeg module of cmake to find the library
finding libjpeg can be a bit more complex, there are systems that are
not delivering a .pc for it. So we should just use the cmake module to
find it.
Stefan Schmidt [Wed, 1 Feb 2017 10:42:03 +0000 (11:42 +0100)]
cmake: fix efl version number
We are in the merge window for 1.19 so our number is actually 1.18.99
Stefan Schmidt [Wed, 1 Feb 2017 10:40:25 +0000 (11:40 +0100)]
cmake: downgrade minimum cmake version to 3.4
There seems really no reason to have such a new version as 3.7 as minimum
here. MAybe even go down to 3.1 as suggested on the mailing list.
YeongJong Lee [Wed, 1 Feb 2017 09:08:14 +0000 (09:08 +0000)]
elm_code: add copy/paste/cut undo
Summary: The patch for supporting copy,paste and cut undo
Test Plan:
1. elementary_test - Code Editor
2. Check that undo work correctly when copy,paste and cut
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4636
Daniel Zaoui [Fri, 27 Jan 2017 10:08:55 +0000 (12:08 +0200)]
DnD/Container: fix drag during animation
If the user icons are set but animation time is set to 0, the icons are
not deleted, resulting in ghosts images in the application.
Additionally, behavior was badly handled when animation time or timeout
before drag were set to 0.
@fix
Shinwoo Kim [Wed, 1 Feb 2017 07:33:52 +0000 (16:33 +0900)]
ecore_input: support Xbox One joystick
Add joystick mapper for Microsoft X-Box One pad (Covert Forces)
Carsten Haitzler (Rasterman) [Wed, 1 Feb 2017 07:08:04 +0000 (16:08 +0900)]
evas gl common - reduce data structure sizes got gl common context
this reduced pipes to 32 as default max pipes is 32 and we never
actually go up beyond 32 unless oyu use env vars to expand... and no
one will... and actual testing shows us top out at about 30 pipes
usage in anything i can find/test. this packs more bool flags together
as bits instead of itns or chars to save memory.
@optimize
Mykola Solyanko [Wed, 1 Feb 2017 04:10:18 +0000 (13:10 +0900)]
Eldbus: add test suite for eldbus (eldbus_object*)
Summary:
add tests for next API:
eldbus_object_bus_name_get
eldbus_object_connection_get
eldbus_object_method_call_new
eldbus_object_path_get
eldbus_object_ref
eldbus_object_send
eldbus_object_get
eldbus_object_introspect
eldbus_object_peer_ping
eldbus_object_peer_machine_id_get
eldbus_object_get
Reviewers: cedric, NikaWhite, myoungwoon, raster
Subscribers: m.solyanko, jpeg, artem.popov
Differential Revision: https://phab.enlightenment.org/D4635
YeongJong Lee [Tue, 31 Jan 2017 19:04:33 +0000 (19:04 +0000)]
elm_code: fix that selected code can't undo
Summary: Change some undo logic and remove unused function
Test Plan:
1. elementary_test - Code Editor
2. Select lines.
3. Remove selected lines.
4. undo removed lines(<Ctrl> + <z>)
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4631