platform/upstream/freerdp.git
5 years agoImproved timer implementation and error messages.
Armin Novak [Thu, 7 Feb 2019 16:26:26 +0000 (17:26 +0100)]
Improved timer implementation and error messages.

5 years agoImproved error logging for wait functions.
Armin Novak [Thu, 7 Feb 2019 16:13:21 +0000 (17:13 +0100)]
Improved error logging for wait functions.

5 years agoImproved implementation of LoadLibrary functions.
Armin Novak [Thu, 7 Feb 2019 16:08:18 +0000 (17:08 +0100)]
Improved implementation of LoadLibrary functions.

5 years agoImproved mutex and event functions
Armin Novak [Thu, 7 Feb 2019 15:43:55 +0000 (16:43 +0100)]
Improved mutex and event functions

* Added name for debugging to handle.
* Implemented *Ex functions

5 years agoFixed unicode key down and up messages.
Armin Novak [Thu, 7 Feb 2019 14:58:55 +0000 (15:58 +0100)]
Fixed unicode key down and up messages.

5 years agoFixed dead store warnings
Armin Novak [Thu, 7 Feb 2019 14:37:14 +0000 (15:37 +0100)]
Fixed dead store warnings

5 years agoFixed dead store warnings
Armin Novak [Thu, 7 Feb 2019 14:36:56 +0000 (15:36 +0100)]
Fixed dead store warnings

5 years agoFixed dead store warnings
Armin Novak [Thu, 7 Feb 2019 14:35:50 +0000 (15:35 +0100)]
Fixed dead store warnings

5 years agoFixed dead store warnings
Armin Novak [Thu, 7 Feb 2019 14:35:33 +0000 (15:35 +0100)]
Fixed dead store warnings

5 years agoFixed sign-compare warnings.
Armin Novak [Thu, 7 Feb 2019 14:09:47 +0000 (15:09 +0100)]
Fixed sign-compare warnings.

5 years agoFixed unused store warnings.
Armin Novak [Thu, 7 Feb 2019 14:09:36 +0000 (15:09 +0100)]
Fixed unused store warnings.

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:40:36 +0000 (14:40 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:39:15 +0000 (14:39 +0100)]
Fixed sign-compare warnings

5 years agoFixed unchecked return warning.
Armin Novak [Thu, 7 Feb 2019 13:38:55 +0000 (14:38 +0100)]
Fixed unchecked return warning.

5 years agoFixed unused variable warnings.
Armin Novak [Thu, 7 Feb 2019 13:38:37 +0000 (14:38 +0100)]
Fixed unused variable warnings.

5 years agoFixed sign-compare warnings, removed internal functions from API
Armin Novak [Thu, 7 Feb 2019 13:38:16 +0000 (14:38 +0100)]
Fixed sign-compare warnings, removed internal functions from API

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:37:23 +0000 (14:37 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:37:02 +0000 (14:37 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:36:50 +0000 (14:36 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:36:41 +0000 (14:36 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:36:33 +0000 (14:36 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:36:17 +0000 (14:36 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:36:06 +0000 (14:36 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:35:58 +0000 (14:35 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:35:40 +0000 (14:35 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:35:21 +0000 (14:35 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:35:10 +0000 (14:35 +0100)]
Fixed sign-compare warnings

5 years agoFixed _config_size return
Armin Novak [Thu, 7 Feb 2019 13:34:49 +0000 (14:34 +0100)]
Fixed _config_size return

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:34:37 +0000 (14:34 +0100)]
Fixed sign-compare warnings

5 years agoFixed const free warning.
Armin Novak [Thu, 7 Feb 2019 13:34:03 +0000 (14:34 +0100)]
Fixed const free warning.

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:33:59 +0000 (14:33 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:33:39 +0000 (14:33 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:33:30 +0000 (14:33 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:33:18 +0000 (14:33 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:33:08 +0000 (14:33 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:32:55 +0000 (14:32 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:32:38 +0000 (14:32 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:31:17 +0000 (14:31 +0100)]
Fixed sign-compare warnings

5 years agoCast SEC_* return values to HRESULT (Same as WIN32 API)
Armin Novak [Thu, 7 Feb 2019 13:25:23 +0000 (14:25 +0100)]
Cast SEC_* return values to HRESULT (Same as WIN32 API)

5 years agoCase SCARD_* return values to HRESULT (Same as WIN32 API)
Armin Novak [Thu, 7 Feb 2019 13:24:54 +0000 (14:24 +0100)]
Case SCARD_* return values to HRESULT (Same as WIN32 API)

5 years agoCast E_* errors to HRESULT (same as defined in WIN32 API)
Armin Novak [Thu, 7 Feb 2019 13:23:50 +0000 (14:23 +0100)]
Cast E_* errors to HRESULT (same as defined in WIN32 API)

5 years agoAddin function pointers now expect const strings
Armin Novak [Thu, 7 Feb 2019 13:23:14 +0000 (14:23 +0100)]
Addin function pointers now expect const strings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:22:28 +0000 (14:22 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:21:04 +0000 (14:21 +0100)]
Fixed sign-compare warnings

5 years agoFixed unused variable warnings.
Armin Novak [Thu, 7 Feb 2019 13:20:53 +0000 (14:20 +0100)]
Fixed unused variable warnings.

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:20:24 +0000 (14:20 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:19:59 +0000 (14:19 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:19:40 +0000 (14:19 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:19:23 +0000 (14:19 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:18:53 +0000 (14:18 +0100)]
Fixed sign-compare warnings

5 years agoFixed missing return value check.
Armin Novak [Thu, 7 Feb 2019 13:18:28 +0000 (14:18 +0100)]
Fixed missing return value check.

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:18:02 +0000 (14:18 +0100)]
Fixed sign-compare warnings

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:17:35 +0000 (14:17 +0100)]
Fixed sign-compare warnings

5 years agoFixed free checks to eliminate bad free warnings.
Armin Novak [Thu, 7 Feb 2019 13:16:21 +0000 (14:16 +0100)]
Fixed free checks to eliminate bad free warnings.

5 years agoFixed sign-compare warnings
Armin Novak [Thu, 7 Feb 2019 13:15:35 +0000 (14:15 +0100)]
Fixed sign-compare warnings

5 years agoFixed NSC SSE argument checks.
Armin Novak [Thu, 7 Feb 2019 11:02:28 +0000 (12:02 +0100)]
Fixed NSC SSE argument checks.

5 years agoMerge pull request #5285 from akallabeth/urbdrc_preparations
David Fort [Thu, 4 Apr 2019 16:21:47 +0000 (18:21 +0200)]
Merge pull request #5285 from akallabeth/urbdrc_preparations

Channel, log debug and semaphore related fixes

5 years agoMerge pull request #5309 from smaeul/patch/ntlm
David Fort [Thu, 4 Apr 2019 16:19:56 +0000 (18:19 +0200)]
Merge pull request #5309 from smaeul/patch/ntlm

Fix NTLM AvPair lists

5 years agoMerge pull request #5318 from akallabeth/filetime_fix
David Fort [Thu, 4 Apr 2019 16:06:22 +0000 (18:06 +0200)]
Merge pull request #5318 from akallabeth/filetime_fix

Fix #5317: Change file attributes before modifying file time.

5 years agoMerge pull request #5251 from akallabeth/wayland_cursor_handling_fix
David Fort [Thu, 4 Apr 2019 16:05:28 +0000 (18:05 +0200)]
Merge pull request #5251 from akallabeth/wayland_cursor_handling_fix

Moved wayland cursor handling to seat.

5 years agoMerge pull request #5273 from akallabeth/mac_compile_warning_fix
David Fort [Thu, 4 Apr 2019 16:03:50 +0000 (18:03 +0200)]
Merge pull request #5273 from akallabeth/mac_compile_warning_fix

Fixed mac compilation warnings.

5 years agoMerge pull request #5319 from akallabeth/clip_file_fix
David Fort [Thu, 4 Apr 2019 16:02:41 +0000 (18:02 +0200)]
Merge pull request #5319 from akallabeth/clip_file_fix

Fixed \0 terimination of clipboard file list

5 years agoFixed \0 terimination of clipboard file list
Armin Novak [Wed, 3 Apr 2019 08:17:51 +0000 (10:17 +0200)]
Fixed \0 terimination of clipboard file list

5 years agoFix #5317: Change file attributes before modifying file time.
Armin Novak [Fri, 29 Mar 2019 14:45:38 +0000 (15:45 +0100)]
Fix #5317: Change file attributes before modifying file time.

5 years agoMerge pull request #5249 from akallabeth/mac_timer_crash_fix
David Fort [Thu, 28 Mar 2019 18:05:48 +0000 (19:05 +0100)]
Merge pull request #5249 from akallabeth/mac_timer_crash_fix

Mac timer crash fix

5 years agoMerge pull request #5281 from akallabeth/assistance_ssl_init_fix
David Fort [Thu, 28 Mar 2019 18:04:25 +0000 (19:04 +0100)]
Merge pull request #5281 from akallabeth/assistance_ssl_init_fix

Fixed #5276: Enable SSL before parsing assistance file.

5 years agoMerge pull request #5295 from akallabeth/stream_macro_fix
David Fort [Thu, 28 Mar 2019 18:02:19 +0000 (19:02 +0100)]
Merge pull request #5295 from akallabeth/stream_macro_fix

Fixed Stream_* macros, bracing arguments.

5 years agoMerge pull request #5313 from m4ntis/fix-end-paint-log-level
David Fort [Wed, 20 Mar 2019 20:28:37 +0000 (21:28 +0100)]
Merge pull request #5313 from m4ntis/fix-end-paint-log-level

Fix update_end_paint wrong log level

5 years agoupdate.c: Fix update_end_paint wrong log level
kubistika [Wed, 20 Mar 2019 20:01:08 +0000 (22:01 +0200)]
update.c: Fix update_end_paint wrong log level

5 years agoMerge pull request #5307 from akallabeth/flatpak_dep_fix
Bernhard Miklautz [Tue, 19 Mar 2019 11:38:00 +0000 (12:38 +0100)]
Merge pull request #5307 from akallabeth/flatpak_dep_fix

Updated flatpak udev build script

5 years agoMerge pull request #5311 from m4ntis/bugfix/gfx-w2s2-decode
David Fort [Tue, 19 Mar 2019 08:38:40 +0000 (09:38 +0100)]
Merge pull request #5311 from m4ntis/bugfix/gfx-w2s2-decode

Fix Wire to Surface 2 pixel format decode on client

5 years agoclient/rdpgfx_main.c: Fix wire to surface 2 pixel format decode
Mati Shabtay [Mon, 18 Mar 2019 14:05:07 +0000 (16:05 +0200)]
client/rdpgfx_main.c: Fix wire to surface 2 pixel format decode

5 years agoClose file handle correctly. (#5310)
cerg2010cerg2010 [Mon, 18 Mar 2019 13:57:00 +0000 (16:57 +0300)]
Close file handle correctly. (#5310)

5 years agoFix NTLM AvPair lists
Samuel Holland [Mon, 18 Mar 2019 01:20:10 +0000 (20:20 -0500)]
Fix NTLM AvPair lists

There were two main issues here: First, the `ntlm_av_pair_add` and
`ntlm_av_pair_add_copy` were not adding a new `MsvAvEOL` to the end of
the list to replace the one they overwrote. This caused the second call
to one of those functions to fail (since it couldn't find the
terminator), which was the source of the test failure. It also caused
`ntlm_av_pair_list_length` and `ntlm_print_av_pair_list` to read out of
bounds until they happened to find the right word.

Second, several bounds checks were wrong or missing. For example,
`ntlm_av_pair_add` does not ensure that the value fits inside the list.
And `ntlm_av_pair_get_len` and `ntlm_av_pair_get_value_pointer` can
return error codes or NULL, but those error returns were ignored, and
the values used anyway (such as in `ntlm_av_pair_add_copy`).

This fixes the list handling code to have the invariant that all
functions returning `NTLM_AV_PAIR*` only return non-`NULL` if the entire
returned `AvPair` is within bounds. This removes the need for the length
parameter in functions that only operate on a single `AvPair`. This
check is performed by the new `ntlm_av_pair_check` helper, which is
added in some new places and used to simplify the code in others.

Other issues fixed along the way include:
 - `ntlm_av_pair_list_length` did not cast to `PBYTE`, so it was
   returning the number of `NTLM_AV_PAIR`-sized chunks (which was
   possibly not even an integer) instead of the number of bytes
 - I removed an impossible check for `offset <= 0` in
   `ntlm_av_pair_get_next_pointer`
 - The assertion that `Value != NULL` and the call to `CopyMemory` are
   only necessary if `AvLen` is nonzero
 - `ntlm_av_pair_get_next_pointer` (renamed to `ntlm_av_pair_next`)
   could be declared `static`

With this commit, TestNTLM now passes on powerpc64.

```
$ ./Testing/TestSspi TestNTLM
NTLM_NEGOTIATE (length = 40):
NTLM_CHALLENGE (length = 168):
NTLM_AUTHENTICATE (length = 352):
$ echo $?
0
```

Fixes #5250

5 years agoFixed flatpak pcsd build
Armin Novak [Fri, 15 Mar 2019 07:52:07 +0000 (08:52 +0100)]
Fixed flatpak pcsd build

5 years agoUpdated flatpak udev build script
Armin Novak [Fri, 15 Mar 2019 07:47:20 +0000 (08:47 +0100)]
Updated flatpak udev build script

5 years agoserver/rdpgfx_main.c: Fixed caps advertise PDU recv (#5304)
Mati Shabtay [Fri, 15 Mar 2019 07:37:35 +0000 (09:37 +0200)]
server/rdpgfx_main.c: Fixed caps advertise PDU recv (#5304)

5 years agoMerge pull request #5297 from akallabeth/nla_server_functions
Martin Fleisz [Fri, 8 Mar 2019 09:44:09 +0000 (10:44 +0100)]
Merge pull request #5297 from akallabeth/nla_server_functions

Exposing NLA functions to impersonate and revert context.

5 years agoExposing NLA functions to impersonate and revert context.
Armin Novak [Fri, 8 Mar 2019 09:10:43 +0000 (10:10 +0100)]
Exposing NLA functions to impersonate and revert context.

5 years agoFixed Stream_* macros, bracing arguments.
Armin Novak [Thu, 7 Mar 2019 08:21:04 +0000 (09:21 +0100)]
Fixed Stream_* macros, bracing arguments.

5 years agoMerge pull request #5294 from akallabeth/gfx_temporary_disable_new
David Fort [Mon, 4 Mar 2019 08:28:15 +0000 (09:28 +0100)]
Merge pull request #5294 from akallabeth/gfx_temporary_disable_new

Temporarily disable GFX version >= 10.3

5 years agoclient/Windows/wf_event.c: add missing "break" (#5293)
Ilya Shipitsin [Mon, 4 Mar 2019 08:17:10 +0000 (13:17 +0500)]
client/Windows/wf_event.c: add missing "break" (#5293)

found by cppcheck

[client/Windows/wf_event.c:464] -> [client/Windows/wf_event.c:468]: (warning) Variable 'xNewPos' is reassigned a value before the old one has been used. 'break;' missing?

5 years agoTemporarily disable GFX version >= 10.3
Armin Novak [Mon, 4 Mar 2019 08:07:27 +0000 (09:07 +0100)]
Temporarily disable GFX version >= 10.3

5 years agoMerge pull request #5252 from akallabeth/big_endian_fix
Martin Fleisz [Fri, 1 Mar 2019 09:06:56 +0000 (10:06 +0100)]
Merge pull request #5252 from akallabeth/big_endian_fix

Fixed endianess issue with GETPIXEL16 and GETPIXEL32

5 years agoMerge pull request #5289 from akallabeth/gfx_crash_fix
Martin Fleisz [Thu, 28 Feb 2019 12:58:10 +0000 (13:58 +0100)]
Merge pull request #5289 from akallabeth/gfx_crash_fix

Disabled RDPGFX_CAPVERSION_106 for good.

5 years agoDisabled RDPGFX_CAPVERSION_106 for good.
Armin Novak [Thu, 28 Feb 2019 12:43:11 +0000 (13:43 +0100)]
Disabled RDPGFX_CAPVERSION_106 for good.

5 years agoMerge pull request #5027 from akallabeth/wlog_off_fix
MartinHaimberger [Thu, 28 Feb 2019 09:55:12 +0000 (10:55 +0100)]
Merge pull request #5027 from akallabeth/wlog_off_fix

Fix #5024: Update inherited log level for all child loggers when setting a new one.

5 years agoFixed winpr_HexLogDump line length calculation.
Armin Novak [Thu, 28 Feb 2019 08:54:05 +0000 (09:54 +0100)]
Fixed winpr_HexLogDump line length calculation.

5 years agoMerge pull request #5288 from akallabeth/rdp_spec_updates
Martin Fleisz [Thu, 28 Feb 2019 08:35:15 +0000 (09:35 +0100)]
Merge pull request #5288 from akallabeth/rdp_spec_updates

Rdp spec updates

5 years agoBetter bounds checks for winpr_HexLogDump
Armin Novak [Thu, 28 Feb 2019 07:50:44 +0000 (08:50 +0100)]
Better bounds checks for winpr_HexLogDump

5 years agoFixed EGFX capability parsing, respect length fields.
Armin Novak [Wed, 27 Feb 2019 16:15:43 +0000 (17:15 +0100)]
Fixed EGFX capability parsing, respect length fields.
Disable RDPGFX_CAPVERSION_106 as we currently do not support scaled
outputs.

5 years agoUpdated EGFX support to 10.6
Armin Novak [Wed, 27 Feb 2019 15:36:15 +0000 (16:36 +0100)]
Updated EGFX support to 10.6

5 years agoFixed version magic mismatch with [MS-RDPBCGR]
Armin Novak [Wed, 27 Feb 2019 15:30:55 +0000 (16:30 +0100)]
Fixed version magic mismatch with [MS-RDPBCGR]

5 years agoFixed ReleaseSemaphore, respect lReleaseCount
Armin Novak [Tue, 26 Feb 2019 14:33:51 +0000 (15:33 +0100)]
Fixed ReleaseSemaphore, respect lReleaseCount

Signal the semapore lReleaseCount times.

5 years agoInitialize ppKeys to NULL in HashTable_GetKeys
Armin Novak [Tue, 26 Feb 2019 14:32:22 +0000 (15:32 +0100)]
Initialize ppKeys to NULL in HashTable_GetKeys

Ensure ppKeys=NULL in case of a function failure or empty table.

5 years agoAdded a logger dump function operating on a preallocated logger.
Armin Novak [Tue, 26 Feb 2019 14:31:47 +0000 (15:31 +0100)]
Added a logger dump function operating on a preallocated logger.

5 years agoForce close channel, use defines instead of magic numbers
Armin Novak [Tue, 26 Feb 2019 14:29:30 +0000 (15:29 +0100)]
Force close channel, use defines instead of magic numbers

* When senging a close request for a dynamic channel close the channel
  immediately. A response from the server is not guaranteed.
* Use the *_PDU defines instead of magic numbers when creating
  dynamic channel messages.

5 years agopotential fix for ENTER (modifiers) stuck after CTRL-ALT-ENTER (toggle fullscreen...
DraganNSDK [Mon, 25 Feb 2019 11:44:51 +0000 (06:44 -0500)]
potential fix for ENTER (modifiers) stuck after CTRL-ALT-ENTER (toggle fullscreen), clearing the buffer in xk_keyboard_update_modifier_keys. (#5280)

* xk_keyboard_update_modifier_keys fixed to clear the buffer.

* removed the xf_keyboard_clear(xfc) fix comments

5 years agoFixed #5276: Enable SSL before parsing assistance file.
Armin Novak [Mon, 25 Feb 2019 09:37:30 +0000 (10:37 +0100)]
Fixed #5276: Enable SSL before parsing assistance file.

The assistance file requires primitives from the ssl wrapper.
Enable these before parsing the file.
Additionally split the FIPS mode enablement from the one time
initializer to avoid ignoring that flag.

5 years agoFixed TS_INFO_PACKET (#5275)
Jiajun Wang [Fri, 22 Feb 2019 16:31:42 +0000 (00:31 +0800)]
Fixed TS_INFO_PACKET (#5275)

Those fields exclude the length of the mandatory null terminator:
* cbDomain
* cbUserName
* cbPassword
* cbAlternateShell
* cbWorkingDir