platform/upstream/libSkiaSharp.git
10 years agoaccount for inverse-paths when we prealloc storage in the rgn-builder
reed@google.com [Tue, 15 Oct 2013 15:44:35 +0000 (15:44 +0000)]
account for inverse-paths when we prealloc storage in the rgn-builder

test inversepath->rgn

BUG=
R=caryclark@google.com

Review URL: https://codereview.chromium.org/27222005

git-svn-id: http://skia.googlecode.com/svn/trunk@11776 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomeant to DISABLE this test
reed@google.com [Tue, 15 Oct 2013 15:40:32 +0000 (15:40 +0000)]
meant to DISABLE this test

git-svn-id: http://skia.googlecode.com/svn/trunk@11775 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd test for https://code.google.com/p/skia/issues/detail?id=1706
reed@google.com [Tue, 15 Oct 2013 15:35:29 +0000 (15:35 +0000)]
add test for https://code.google.com/p/skia/issues/detail?id=1706

BUG=

Review URL: https://codereview.chromium.org/27344002

git-svn-id: http://skia.googlecode.com/svn/trunk@11774 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRectShaderImageFilter: add a new factory method which takes a CropRect.
senorblanco@chromium.org [Tue, 15 Oct 2013 15:25:18 +0000 (15:25 +0000)]
SkRectShaderImageFilter: add a new factory method which takes a CropRect.
This will become the preferred API, and the old Create method will be deprecated.

R=reed@google.com, reed
BUG=

Review URL: https://codereview.chromium.org/26220004

git-svn-id: http://skia.googlecode.com/svn/trunk@11773 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove clipstack/region bounds assertion
commit-bot@chromium.org [Tue, 15 Oct 2013 15:14:43 +0000 (15:14 +0000)]
remove clipstack/region bounds assertion

BUG=skia_1720
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/26237010

git-svn-id: http://skia.googlecode.com/svn/trunk@11772 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix build break in assert
bsalomon@google.com [Tue, 15 Oct 2013 14:35:06 +0000 (14:35 +0000)]
Fix build break in assert

git-svn-id: http://skia.googlecode.com/svn/trunk@11771 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoseparate state for msaa renderability
commit-bot@chromium.org [Tue, 15 Oct 2013 14:18:16 +0000 (14:18 +0000)]
separate state for msaa renderability

R=robertphillips@google.com, brian@thesalomons.net

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/26695005

git-svn-id: http://skia.googlecode.com/svn/trunk@11770 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 15 Oct 2013 07:02:27 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11769 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSuppresses failing test due to change of bench_graph_svg. Will fix later.
bensong@google.com [Tue, 15 Oct 2013 00:35:18 +0000 (00:35 +0000)]
Suppresses failing test due to change of bench_graph_svg. Will fix later.
Review URL: https://codereview.chromium.org/26894004

git-svn-id: http://skia.googlecode.com/svn/trunk@11766 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChanges bench to output with git hash filename; cleans up bench_graph_svg to only...
bensong@google.com [Tue, 15 Oct 2013 00:08:14 +0000 (00:08 +0000)]
Changes bench to output with git hash filename; cleans up bench_graph_svg to only handle bench alerts; renames it to check_bench_regressions.
Review URL: https://codereview.chromium.org/26592010

git-svn-id: http://skia.googlecode.com/svn/trunk@11765 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoStart cleaning up 64bit Win warnings
robertphillips@google.com [Mon, 14 Oct 2013 21:53:24 +0000 (21:53 +0000)]
Start cleaning up 64bit Win warnings

https://codereview.chromium.org/27192003/

git-svn-id: http://skia.googlecode.com/svn/trunk@11764 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRuntime configuration setting for suppressing JPEG decoder errors.
halcanary@google.com [Mon, 14 Oct 2013 20:08:48 +0000 (20:08 +0000)]
Runtime configuration setting for suppressing JPEG decoder errors.

Add new runtime config variable, images.jpeg.suppressDecoderErrors
which defaults to false in Debug and true otherwise.  When Jpeg errors
are suppressed and an error happens, SkJPEGImageDecoder::onDecode()
will return silently false (Consequently, so will SkImageDecoder's
DecodeFile() and DecodeMemory() functions).

Also, the test_image_decoder program now respects runtime
configuration settings.

BUG=skia:1680
R=scroggo@google.com

Review URL: https://codereview.chromium.org/27230002

git-svn-id: http://skia.googlecode.com/svn/trunk@11763 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agochange SkAnnotation to not inherit from SkFlattenable (does not need dynamic factories)
reed@google.com [Mon, 14 Oct 2013 20:02:44 +0000 (20:02 +0000)]
change SkAnnotation to not inherit from SkFlattenable (does not need dynamic factories)

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/26606004

git-svn-id: http://skia.googlecode.com/svn/trunk@11762 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoswizzle color table if necessary
commit-bot@chromium.org [Mon, 14 Oct 2013 18:29:23 +0000 (18:29 +0000)]
swizzle color table if necessary

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/27224003

git-svn-id: http://skia.googlecode.com/svn/trunk@11761 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdding SkLumaColorFilter baselines.
fmalita@google.com [Mon, 14 Oct 2013 17:13:35 +0000 (17:13 +0000)]
Adding SkLumaColorFilter baselines.

Review URL: https://codereview.chromium.org/27213003

git-svn-id: http://skia.googlecode.com/svn/trunk@11760 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SkDataSet, and just store a key/value in SkAnnotation
reed@google.com [Mon, 14 Oct 2013 16:49:15 +0000 (16:49 +0000)]
remove SkDataSet, and just store a key/value in SkAnnotation

BUG=
R=mtklein@google.com

Review URL: https://codereview.chromium.org/27208002

git-svn-id: http://skia.googlecode.com/svn/trunk@11759 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove need for readFlattenableT from SkLightingImageFilter.
commit-bot@chromium.org [Mon, 14 Oct 2013 16:28:56 +0000 (16:28 +0000)]
Remove need for readFlattenableT from SkLightingImageFilter.

This will need new picture version.

BUG=
R=reed@android.com, sugoi@google.com, senorblanco@chromium.org, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/26594008

git-svn-id: http://skia.googlecode.com/svn/trunk@11758 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agohandle configuration variables longer than 30 characters long
humper@google.com [Mon, 14 Oct 2013 16:27:30 +0000 (16:27 +0000)]
handle configuration variables longer than 30 characters long

BUG=
R=bsalomon@google.com, halcanary@google.com, reed@google.com

Review URL: https://codereview.chromium.org/26206003

git-svn-id: http://skia.googlecode.com/svn/trunk@11757 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove renderable config list to GrDrawTargetCaps
commit-bot@chromium.org [Mon, 14 Oct 2013 15:33:45 +0000 (15:33 +0000)]
Move renderable config list to GrDrawTargetCaps

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/26342006

git-svn-id: http://skia.googlecode.com/svn/trunk@11756 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agosave/restore the canvas around every bench draw call
commit-bot@chromium.org [Mon, 14 Oct 2013 15:28:01 +0000 (15:28 +0000)]
save/restore the canvas around every bench draw call

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=11728

R=djsollen@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/26848013

git-svn-id: http://skia.googlecode.com/svn/trunk@11755 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkData need not be a Flattenable, since it does not need subclass/factories
reed@google.com [Mon, 14 Oct 2013 14:33:11 +0000 (14:33 +0000)]
SkData need not be a Flattenable, since it does not need subclass/factories

BUG=
R=mtklein@google.com

Review URL: https://codereview.chromium.org/26928002

git-svn-id: http://skia.googlecode.com/svn/trunk@11754 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate Housekeeper-PerCommit after adding a new type of gm result.
edisonn@google.com [Mon, 14 Oct 2013 14:31:14 +0000 (14:31 +0000)]
Update Housekeeper-PerCommit after adding a new type of gm result.

R=epoger@google.com

Review URL: https://codereview.chromium.org/27191002

git-svn-id: http://skia.googlecode.com/svn/trunk@11753 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSpin off incidental changes from DM CL (22839016).
commit-bot@chromium.org [Mon, 14 Oct 2013 14:15:28 +0000 (14:15 +0000)]
Spin off incidental changes from DM CL (22839016).

BUG=
R=epoger@google.com, bsalomon@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/27023004

git-svn-id: http://skia.googlecode.com/svn/trunk@11752 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd SkPDFDeviceFlatenner which extends SkPDFDevice to add support to flatten the...
commit-bot@chromium.org [Mon, 14 Oct 2013 13:42:12 +0000 (13:42 +0000)]
Add SkPDFDeviceFlatenner which extends SkPDFDevice to add support to flatten the path and the text when we have perspective.
prepare to deprecate SkPDFDevice constructor, and route gm and render_pdfs to use SkDocument::Create pdf interface instead. - controlled by a flag
add comments where we are supposed to flatten other features (paint, shaders, ... )

R=reed@google.com, bungeman@google.com, scroggo@google.com, vandebo@chromium.org, bsalomon@google.com

Author: edisonn@google.com

Review URL: https://codereview.chromium.org/24811002

git-svn-id: http://skia.googlecode.com/svn/trunk@11751 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove SkLumaXfermode.
commit-bot@chromium.org [Mon, 14 Oct 2013 13:11:11 +0000 (13:11 +0000)]
Remove SkLumaXfermode.

Possibly the shortest-lived Skia feature, SkLumaXfermode is now replaced
by a color filter implementation (SkLumaColorFilter). All known existing
clients (Blink) have been converted.

R=reed@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/26916002

git-svn-id: http://skia.googlecode.com/svn/trunk@11750 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSimplify code for configuring suppression of ImageDecoder warnings
halcanary@google.com [Mon, 14 Oct 2013 12:49:15 +0000 (12:49 +0000)]
Simplify code for configuring suppression of ImageDecoder warnings

For images.png.suppressDecoderWarnings and
images.jpeg.suppressDecoderWarnings, the default behavior is now:

Debug - DON'T suppress
Developer Release - suppress
Release - suppress

This behavior can be changed in Debug and in Developer through
the SkRTConf mechanism.

BUG=skia:1680
R=caryclark@google.com

Review URL: https://codereview.chromium.org/26863003

git-svn-id: http://skia.googlecode.com/svn/trunk@11749 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSampleApp - reduce unnecessary verbosity [with --picture $path]
halcanary@google.com [Mon, 14 Oct 2013 12:47:37 +0000 (12:47 +0000)]
SampleApp - reduce unnecessary verbosity [with --picture $path]

Before this change, `SampleApp --picture $path` prints out usage (as
well as --pictureDir) as if there was a syntax error in the command
line arguments.

BUG=skia:1677
R=reed@google.com

Review URL: https://codereview.chromium.org/24503003

git-svn-id: http://skia.googlecode.com/svn/trunk@11748 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove unnamed namespace usage from tests.
commit-bot@chromium.org [Sat, 12 Oct 2013 17:25:17 +0000 (17:25 +0000)]
Remove unnamed namespace usage from tests.

Skia code prefers static over unnamed namespace.

BUG=None
TEST=None
R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/26962002

git-svn-id: http://skia.googlecode.com/svn/trunk@11747 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 12 Oct 2013 07:02:05 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11746 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd stdio include to SkFonrConfigParser_android.
bungeman@google.com [Fri, 11 Oct 2013 20:13:41 +0000 (20:13 +0000)]
Add stdio include to SkFonrConfigParser_android.

git-svn-id: http://skia.googlecode.com/svn/trunk@11745 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoTry to work around VS2010 intsafe/stdint multiple define issues.
bungeman@google.com [Fri, 11 Oct 2013 20:04:08 +0000 (20:04 +0000)]
Try to work around VS2010 intsafe/stdint multiple define issues.

git-svn-id: http://skia.googlecode.com/svn/trunk@11744 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd stdio include to SkDebug_android.
bungeman@google.com [Fri, 11 Oct 2013 19:47:36 +0000 (19:47 +0000)]
Add stdio include to SkDebug_android.

git-svn-id: http://skia.googlecode.com/svn/trunk@11743 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd stdio include for Android specific code in SkRegion.
bungeman@google.com [Fri, 11 Oct 2013 19:23:56 +0000 (19:23 +0000)]
Add stdio include for Android specific code in SkRegion.

git-svn-id: http://skia.googlecode.com/svn/trunk@11741 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd stdio include to skdiff_image.
bungeman@google.com [Fri, 11 Oct 2013 19:19:10 +0000 (19:19 +0000)]
Add stdio include to skdiff_image.

git-svn-id: http://skia.googlecode.com/svn/trunk@11740 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCorrect 32bit pointer assumption in assert in SkMatrix.
bungeman@google.com [Fri, 11 Oct 2013 19:11:10 +0000 (19:11 +0000)]
Correct 32bit pointer assumption in assert in SkMatrix.

git-svn-id: http://skia.googlecode.com/svn/trunk@11739 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoClean up SkTypes.h.
bungeman@google.com [Fri, 11 Oct 2013 18:50:45 +0000 (18:50 +0000)]
Clean up SkTypes.h.

This change removes sk_stdint.h since it is only needed for vs2008 and earlier.
This change removes SK_MMAP_SUPPORT define since it is no longer used.
This change removes the stdio.h include from SkTypes.h since on many systems
this is a very large header, few Skia files actually use it, it is
available everywhere standard, and SkDebugf should be used instead.

After this change there is no need for external users to put Skia's
include/config into their own list of includes, saving the headache
of having two header files of the same name and sometimes getting the
wrong one depending on include order.

R=bsalomon@google.com, djsollen@google.com

Review URL: https://codereview.chromium.org/27044002

git-svn-id: http://skia.googlecode.com/svn/trunk@11738 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: allow client to pull all results, or just failures
epoger@google.com [Fri, 11 Oct 2013 18:45:33 +0000 (18:45 +0000)]
rebaseline_server: allow client to pull all results, or just failures
(SkipBuildbotRuns)

This will be handy for constrained networks or devices, where we don't want
to bother downloading info about all the successful tests.

R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/26891003

git-svn-id: http://skia.googlecode.com/svn/trunk@11737 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd valgrind suppressions for driver bugs
robertphillips@google.com [Fri, 11 Oct 2013 18:28:18 +0000 (18:28 +0000)]
Add valgrind suppressions for driver bugs

https://codereview.chromium.org/27019005/

git-svn-id: http://skia.googlecode.com/svn/trunk@11736 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agopdfviewer: more code comments + concat the pdf matrix with the existing matrix in...
edisonn@google.com [Fri, 11 Oct 2013 18:26:45 +0000 (18:26 +0000)]
pdfviewer: more code comments + concat the pdf matrix with the existing matrix in canvas, instead of reseting it.

Review URL: https://codereview.chromium.org/27057003

git-svn-id: http://skia.googlecode.com/svn/trunk@11735 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGIF decode: optional error messages and fault tolerance.
halcanary@google.com [Fri, 11 Oct 2013 18:21:56 +0000 (18:21 +0000)]
GIF decode: optional error messages and fault tolerance.

Add new runtime configuration variable,
images.gif.suppressDecoderWarnings, which suppresses warning and
errors from the GIF library.  It defaults to "true", which is current
behavior.

(This setting can be changed by setting the environment variable
skia_images_gif_suppressDecoderWarnings="false".)

Some conditions which were errors before are now warnings:

-   If the image width or height is greater than the GIF screen width or
    height (respectively) we expand the screen to hold the image.

-   If the offset of the image inside the screen would place the
    image outside of the screen, we shift the image to fix this.

-   If the image lacks a color table, we create a default color table.

-   If the image is truncated, then the rest of the image is filled with
    the fill color.

In all four cases, if images.gif.suppressDecoderWarnings is set to
false, then a warning message is printed via SkDebugf.

In the event of another kind of error, SkGIFImageDecoder::onDecode()
will still return false.  But with this change, if
images.gif.suppressDecoderWarnings is set to false, a description of
the error is printed via SkDebugf.

Also, added a new unit test GifTest, which tests the deconing of both
good GIf files and corrupted files that should now work with this
change.  This unit test is disabled on Win32, iOS, and Mac.

BUG=skia:1689
R=scroggo@google.com

Review URL: https://codereview.chromium.org/26743002

git-svn-id: http://skia.googlecode.com/svn/trunk@11734 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRectShaderImageFilter: add a workaround for the zero-sized rects currently passed...
senorblanco@chromium.org [Fri, 11 Oct 2013 17:57:47 +0000 (17:57 +0000)]
SkRectShaderImageFilter: add a workaround for the zero-sized rects currently passed by Blink.

BUG=306488
R=robertphillips@google.com, robertphillips

Review URL: https://codereview.chromium.org/26799004

git-svn-id: http://skia.googlecode.com/svn/trunk@11733 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse #if insteadof #ifdef DYNAMIC_ANNOTATIONS_ENABLED. It's always defined, just...
senorblanco@chromium.org [Fri, 11 Oct 2013 16:45:50 +0000 (16:45 +0000)]
Use #if insteadof #ifdef DYNAMIC_ANNOTATIONS_ENABLED.  It's always defined, just to 0 or 1.

BUG=
R=mtklein

Review URL: https://codereview.chromium.org/26358010

git-svn-id: http://skia.googlecode.com/svn/trunk@11731 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agopdfviewer: (more code cleanup): class documentation and comments
edisonn@google.com [Fri, 11 Oct 2013 16:17:44 +0000 (16:17 +0000)]
pdfviewer: (more code cleanup): class documentation and comments

Review URL: https://codereview.chromium.org/27043002

git-svn-id: http://skia.googlecode.com/svn/trunk@11730 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agosave/restore the canvas around every bench draw call
commit-bot@chromium.org [Fri, 11 Oct 2013 15:20:29 +0000 (15:20 +0000)]
save/restore the canvas around every bench draw call

BUG=
R=djsollen@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/26848013

git-svn-id: http://skia.googlecode.com/svn/trunk@11728 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove the old skimage expectations.
scroggo@google.com [Fri, 11 Oct 2013 15:12:46 +0000 (15:12 +0000)]
Remove the old skimage expectations.

As of https://code.google.com/p/skia/source/detail?r=11712 ,
the bots are now reading the expectations from a new place,
so these are no longer needed.

Unreviewed.

BUG=skia:1466

Review URL: https://codereview.chromium.org/26909004

git-svn-id: http://skia.googlecode.com/svn/trunk@11727 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFormat-only changes to skimage expectations files.
scroggo@google.com [Fri, 11 Oct 2013 14:51:31 +0000 (14:51 +0000)]
Format-only changes to skimage expectations files.

When running rebaseline.py, the format of the file changes from
what is currently checked in, but the actual data remains the
same. Update the format so future changes will be easier to see
visually (not mixed in with format changes).

Unreviewed.

Review URL: https://codereview.chromium.org/26888010

git-svn-id: http://skia.googlecode.com/svn/trunk@11726 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix leak in BlurTest
robertphillips@google.com [Fri, 11 Oct 2013 14:38:46 +0000 (14:38 +0000)]
Fix leak in BlurTest

https://codereview.chromium.org/26941002/

git-svn-id: http://skia.googlecode.com/svn/trunk@11725 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix double ref issue in SkPDFFont ctor
robertphillips@google.com [Fri, 11 Oct 2013 14:27:16 +0000 (14:27 +0000)]
Fix double ref issue in SkPDFFont ctor

https://codereview.chromium.org/26799003/

git-svn-id: http://skia.googlecode.com/svn/trunk@11724 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 11 Oct 2013 07:01:39 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11723 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix uninitialized memory read in BitmapCopy test with A1 config
robertphillips@google.com [Thu, 10 Oct 2013 22:01:02 +0000 (22:01 +0000)]
Fix uninitialized memory read in BitmapCopy test with A1 config

https://codereview.chromium.org/26890002/

git-svn-id: http://skia.googlecode.com/svn/trunk@11722 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSK_ONCE for SkMatrix::I()
commit-bot@chromium.org [Thu, 10 Oct 2013 21:58:31 +0000 (21:58 +0000)]
SK_ONCE for SkMatrix::I()

Going to start doing these in progressively larger and larger bulk,
but I figured the first few changes probably merit caution.

BUG=
R=reed@google.com, bungeman@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/26905002

git-svn-id: http://skia.googlecode.com/svn/trunk@11721 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement crop rect support for SkRectShaderImageFilter: remove fRect and use the...
senorblanco@chromium.org [Thu, 10 Oct 2013 21:36:48 +0000 (21:36 +0000)]
Implement crop rect support for SkRectShaderImageFilter: remove fRect and use the cropRect from SkImageFilter in its place.

R=reed@google.com

Review URL: https://codereview.chromium.org/26009004

git-svn-id: http://skia.googlecode.com/svn/trunk@11720 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoTemporarily disable FilterBitmapBenches while I fix it.
mtklein@google.com [Thu, 10 Oct 2013 21:27:17 +0000 (21:27 +0000)]
Temporarily disable FilterBitmapBenches while I fix it.

BUG=

Review URL: https://codereview.chromium.org/26254003

git-svn-id: http://skia.googlecode.com/svn/trunk@11718 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd ability to rebaseline skimage to rebaseline.py
scroggo@google.com [Thu, 10 Oct 2013 21:09:24 +0000 (21:09 +0000)]
Add ability to rebaseline skimage to rebaseline.py

Skip pattern matching for skimage, since the skimage results do not
match the pattern.

Automatically fill in expectations_root and actuals_base_url when
--skimage is specified.

Requires a change to move the expectations files to the right place.
Depends on https://codereview.chromium.org/26734006

(SkipBuildBotRuns)

BUG=skia:1466
R=epoger@google.com

Review URL: https://codereview.chromium.org/26666004

git-svn-id: http://skia.googlecode.com/svn/trunk@11717 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomode code cleanup (100c / l, comments)
edisonn@google.com [Thu, 10 Oct 2013 20:58:22 +0000 (20:58 +0000)]
mode code cleanup (100c / l, comments)

Review URL: https://codereview.chromium.org/26912005

git-svn-id: http://skia.googlecode.com/svn/trunk@11716 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix a minor regex bug.
scroggo@google.com [Thu, 10 Oct 2013 20:41:43 +0000 (20:41 +0000)]
Fix a minor regex bug.

Match against '.', rather than any character (how '.' is treated
in a regular expression).

Previous to this, xfermodes_8888*png matched the expression.

R=epoger@google.com

Review URL: https://codereview.chromium.org/26709003

git-svn-id: http://skia.googlecode.com/svn/trunk@11714 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAlign SkLumaColorFilter with the spec.
commit-bot@chromium.org [Thu, 10 Oct 2013 20:13:51 +0000 (20:13 +0000)]
Align SkLumaColorFilter with the spec.

The spec requires the resulting RGB channels for LuminanceToAlpha to be
0 (and not just scaled by the luminance value</facepalm>):

  | R' |     |      0        0        0  0  0 |   | R |
  | G' |     |      0        0        0  0  0 |   | G |
  | B' |  =  |      0        0        0  0  0 | * | B |
  | A' |     | 0.2125   0.7154   0.0721  0  0 |   | A |
  | 1  |     |      0        0        0  0  1 |   | 1 |

(http://www.w3.org/TR/2011/REC-SVG11-20110816/filters.html#feColorMatrixElement)

This doesn't affect luminance masking (which depends only on the
resulting alpha channel), but other color filter users may care
about all color components.

R=bsalomon@google.com, reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/26467003

git-svn-id: http://skia.googlecode.com/svn/trunk@11713 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkThreadPool: tweak two little things that have been annoying me
commit-bot@chromium.org [Thu, 10 Oct 2013 18:49:04 +0000 (18:49 +0000)]
SkThreadPool: tweak two little things that have been annoying me
 1) it's pretty annoying that SkThreadPool doesn't include SkRunnable for us;
 2) add wait() so we don't have to keep using SkAutoTDelete/free() to wait for completion.

BUG=
R=scroggo@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/26470005

git-svn-id: http://skia.googlecode.com/svn/trunk@11711 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix warnings when running a no gpu build
djsollen@google.com [Thu, 10 Oct 2013 18:48:27 +0000 (18:48 +0000)]
fix warnings when running a no gpu build

R=mtklein@google.com

Review URL: https://codereview.chromium.org/26908002

git-svn-id: http://skia.googlecode.com/svn/trunk@11710 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix mac10.6 build
djsollen@google.com [Thu, 10 Oct 2013 17:50:52 +0000 (17:50 +0000)]
fix mac10.6 build

Review URL: https://codereview.chromium.org/26882003

git-svn-id: http://skia.googlecode.com/svn/trunk@11708 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline nexus7 perf improvement
djsollen@google.com [Thu, 10 Oct 2013 17:42:20 +0000 (17:42 +0000)]
rebaseline nexus7 perf improvement

Review URL: https://codereview.chromium.org/26884002

git-svn-id: http://skia.googlecode.com/svn/trunk@11707 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix android_gdb_exe script
djsollen@google.com [Thu, 10 Oct 2013 17:41:32 +0000 (17:41 +0000)]
fix android_gdb_exe script

R=mtklein@google.com

Review URL: https://codereview.chromium.org/26871003

git-svn-id: http://skia.googlecode.com/svn/trunk@11706 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomake explicit the requirement that all colorfilters are reentrant-safe
reed@google.com [Thu, 10 Oct 2013 17:35:58 +0000 (17:35 +0000)]
make explicit the requirement that all colorfilters are reentrant-safe

BUG=
R=mtklein@google.com

Review URL: https://codereview.chromium.org/26876002

git-svn-id: http://skia.googlecode.com/svn/trunk@11705 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoInsert swapbuffers into GPU benchmarks.
djsollen@google.com [Thu, 10 Oct 2013 17:33:39 +0000 (17:33 +0000)]
Insert swapbuffers into GPU benchmarks.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/26489003

git-svn-id: http://skia.googlecode.com/svn/trunk@11704 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogm: if test has no expectations, record its result as no-expectations regardless...
epoger@google.com [Thu, 10 Oct 2013 17:24:20 +0000 (17:24 +0000)]
gm: if test has no expectations, record its result as no-expectations regardless of ignoreFailure

After https://code.google.com/p/skia/source/detail?r=11640 ('Ignore any
pdf-poppler GM failures'), there are a bunch of pdf-poppler tests showing up
as failure-ignored at http://c128.i.corp.google.com/production-gm-diffs/latest/view.html

Make them go away.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/26650005

git-svn-id: http://skia.googlecode.com/svn/trunk@11703 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd -fPIC fro tsan (isn't alrady set in non-library).
bungeman@google.com [Thu, 10 Oct 2013 17:24:17 +0000 (17:24 +0000)]
Add -fPIC fro tsan (isn't alrady set in non-library).

git-svn-id: http://skia.googlecode.com/svn/trunk@11702 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoEnable -fPIE, and -pie in tsan build. We're already -fPIC.
bungeman@google.com [Thu, 10 Oct 2013 17:09:49 +0000 (17:09 +0000)]
Enable -fPIE, and -pie in tsan build. We're already -fPIC.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/26142003

git-svn-id: http://skia.googlecode.com/svn/trunk@11701 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd leak to valgrind.supp
robertphillips@google.com [Thu, 10 Oct 2013 17:04:14 +0000 (17:04 +0000)]
Add leak to valgrind.supp

https://codereview.chromium.org/26869002/

git-svn-id: http://skia.googlecode.com/svn/trunk@11700 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline Nexus 7 GM results after upgrading devices to 4.3
djsollen@google.com [Thu, 10 Oct 2013 16:15:45 +0000 (16:15 +0000)]
Rebaseline Nexus 7 GM results after upgrading devices to 4.3

The fonts have changed as a result of the upgrade so all GMs with
text are reporting as mismatches.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/26866002

git-svn-id: http://skia.googlecode.com/svn/trunk@11699 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew expectations files for skimage.
scroggo@google.com [Thu, 10 Oct 2013 16:04:16 +0000 (16:04 +0000)]
New expectations files for skimage.

Copies them from expectations/skimage/buildername.json to
expectations/skimage/buildername/expected-results.json.

Required for https://codereview.chromium.org/26734006/ and
ultimately BUG=skia:1466

A follow up change will delete the old expectations files once
https://codereview.chromium.org/26734006/ has landed.

(SkipBuildbotRuns) - Since the new expectations files aren't even
read yet (they won't be until https://codereview.chromium.org/26734006/
is checked in), this need not be tested by the buildbots (yet).

Unreviewed.

BUG=skia:1466

Review URL: https://codereview.chromium.org/26865002

git-svn-id: http://skia.googlecode.com/svn/trunk@11698 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAlways clear dest in SkBitmap::copyTo's draw path
robertphillips@google.com [Thu, 10 Oct 2013 15:48:16 +0000 (15:48 +0000)]
Always clear dest in SkBitmap::copyTo's draw path

https://codereview.chromium.org/26268003/

git-svn-id: http://skia.googlecode.com/svn/trunk@11697 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline bench expectations
commit-bot@chromium.org [Thu, 10 Oct 2013 15:23:00 +0000 (15:23 +0000)]
rebaseline bench expectations

R=borenet@google.com, bsalomon@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/26841002

git-svn-id: http://skia.googlecode.com/svn/trunk@11696 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Revert "change SkColorTable to be immutable""
reed@google.com [Thu, 10 Oct 2013 14:44:56 +0000 (14:44 +0000)]
Revert "Revert "change SkColorTable to be immutable""

This reverts commit b8162cb840f4cb6002ef68d5ac775c6a122c52a9.

Fixed was call-sites in benches that used the (now gone) setIsOpaque api.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/26572006

git-svn-id: http://skia.googlecode.com/svn/trunk@11695 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebase SGX images after GrGLSLExpr change
bsalomon@google.com [Thu, 10 Oct 2013 14:42:45 +0000 (14:42 +0000)]
Rebase SGX images after GrGLSLExpr change

Review URL: https://codereview.chromium.org/26223005

git-svn-id: http://skia.googlecode.com/svn/trunk@11694 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse the modified path, not the original path for the platform prefix.
bungeman@google.com [Thu, 10 Oct 2013 14:16:23 +0000 (14:16 +0000)]
Use the modified path, not the original path for the platform prefix.

Fixes regression introduced in r11642.

git-svn-id: http://skia.googlecode.com/svn/trunk@11693 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChange SkImageFilter's cropRect from SkIRect to a CropRect struct, containing an...
senorblanco@chromium.org [Thu, 10 Oct 2013 13:51:19 +0000 (13:51 +0000)]
Change SkImageFilter's cropRect from SkIRect to a CropRect struct, containing an SkRect and flags indicating which parameters are set.

NOTE: this will require SK_CROP_RECT_IS_INT=1 to be set in Chrome until Blink has been updated to use SkImageFilter::CropRect. Include https://codereview.chromium.org/26528002/ with the Skia roll.

Note also that SK_CROP_RECT_IS_INT is a temporary measure until all call sites in Blink have been updated to use SkRect.

R=reed@google.com

Review URL: https://codereview.chromium.org/26371002

git-svn-id: http://skia.googlecode.com/svn/trunk@11692 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 10 Oct 2013 07:01:40 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11691 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoExpress (GLSL expression, possibly known value) pairs as a class
commit-bot@chromium.org [Thu, 10 Oct 2013 06:30:18 +0000 (06:30 +0000)]
Express (GLSL expression, possibly known value) pairs as a class

Express (GLSL expression, possibly known value) pairs as a class
instead of two variables Introduces GrGLSLExpr<N> to encapsulate
the expression and possibly constant-folded value of the expression.

This simplifies passing of the expressions to functions.

Changes the shaders with following patterns:
        { // Stage 0: Linear Gradient
        vec4 colorTemp = mix(uGradientStartColor_Stage0, uGradientEndColor_Stage0, clamp(vMatrixCoord_Stage0.x, 0.0, 1
        colorTemp.rgb *= colorTemp.a;
-       output_Stage0 = vec4((vColor) * (colorTemp));
+       output_Stage0 = (vColor * colorTemp);
+       }

Previously the vector cast was always added if constant folding was
effective, regardless of the term dimensions. Now the vector upcast is
not inserted in places where it is not needed, ie. when the binary
operator term is of the target dimension.

Also, some parentheses can be omitted. It is assumed that
GrGLSLExpr<N>("string") constructors construct a simple expression or
parenthesized expression.

Otherwise the shader code remains identical.

R=jvanverth@google.com, bsalomon@google.com, robertphillips@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/25048002

git-svn-id: http://skia.googlecode.com/svn/trunk@11690 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobasically a typo
commit-bot@chromium.org [Thu, 10 Oct 2013 02:53:30 +0000 (02:53 +0000)]
basically a typo

R=caryclark@google.com, bsalomon@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/23619063

git-svn-id: http://skia.googlecode.com/svn/trunk@11689 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkDocument api changes (abort, close return success, set DCT encoder...).
commit-bot@chromium.org [Wed, 9 Oct 2013 21:09:00 +0000 (21:09 +0000)]
SkDocument api changes (abort, close return success, set DCT encoder...).

R=reed@google.com, reed

Author: edisonn@google.com

Review URL: https://codereview.chromium.org/26744002

git-svn-id: http://skia.googlecode.com/svn/trunk@11688 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agocode cleanup
edisonn@google.com [Wed, 9 Oct 2013 20:23:12 +0000 (20:23 +0000)]
code cleanup

Review URL: https://codereview.chromium.org/26613006

git-svn-id: http://skia.googlecode.com/svn/trunk@11687 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove _impl from names in SkOnce.h.
commit-bot@chromium.org [Wed, 9 Oct 2013 20:08:20 +0000 (20:08 +0000)]
Remove _impl from names in SkOnce.h.

This is entirely to make power users (me, Mike's per-object use case) feel less
bad about calling sk_once() directly with args not created by DEF_SK_ONCE.

BUG=
R=bungeman@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/26129010

git-svn-id: http://skia.googlecode.com/svn/trunk@11686 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGive the new font cache GM a name
jvanverth@google.com [Wed, 9 Oct 2013 18:53:35 +0000 (18:53 +0000)]
Give the new font cache GM a name

BUG=
R=borenet@google.com

Review URL: https://codereview.chromium.org/26675004

git-svn-id: http://skia.googlecode.com/svn/trunk@11685 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agolow hanging calloc fruit
commit-bot@chromium.org [Wed, 9 Oct 2013 18:39:59 +0000 (18:39 +0000)]
low hanging calloc fruit

BUG=
R=reed@google.com, robertphillips@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/24267014

git-svn-id: http://skia.googlecode.com/svn/trunk@11683 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd swapBuffer call to SkGLContextHelper.
djsollen@google.com [Wed, 9 Oct 2013 18:25:38 +0000 (18:25 +0000)]
Add swapBuffer call to SkGLContextHelper.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/26701002

git-svn-id: http://skia.googlecode.com/svn/trunk@11682 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd new GM to stress test the GPU font cache for cases similar to
commit-bot@chromium.org [Wed, 9 Oct 2013 18:12:23 +0000 (18:12 +0000)]
Add new GM to stress test the GPU font cache for cases similar to
Chromium issue 303803.

BUG=303803

Committed: http://code.google.com/p/skia/source/detail?r=11673

R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/26699002

git-svn-id: http://skia.googlecode.com/svn/trunk@11680 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: extend returned JSON dict to allow for result-editing in coming CL
epoger@google.com [Wed, 9 Oct 2013 18:05:58 +0000 (18:05 +0000)]
rebaseline_server: extend returned JSON dict to allow for result-editing in coming CL
(SkipBuildbotRuns)

R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/26659002

git-svn-id: http://skia.googlecode.com/svn/trunk@11679 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Add new GM to stress test the GPU font cache"
jvanverth@google.com [Wed, 9 Oct 2013 17:03:22 +0000 (17:03 +0000)]
Revert "Add new GM to stress test the GPU font cache"

git-svn-id: http://skia.googlecode.com/svn/trunk@11678 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "change SkColorTable to be immutable"
reed@google.com [Wed, 9 Oct 2013 16:49:45 +0000 (16:49 +0000)]
Revert "change SkColorTable to be immutable"

This reverts commit 1c0ff422868b3badf5ffe0790a5d051d1896e2f7.

BUG=

Review URL: https://codereview.chromium.org/26709002

git-svn-id: http://skia.googlecode.com/svn/trunk@11677 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agochange SkColorTable to be immutable
reed@google.com [Wed, 9 Oct 2013 16:34:47 +0000 (16:34 +0000)]
change SkColorTable to be immutable

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/25353002

git-svn-id: http://skia.googlecode.com/svn/trunk@11676 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix font cache GM on Windows
jvanverth@google.com [Wed, 9 Oct 2013 16:22:38 +0000 (16:22 +0000)]
Fix font cache GM on Windows

git-svn-id: http://skia.googlecode.com/svn/trunk@11675 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSketch of SK_ONCE
mtklein@google.com [Wed, 9 Oct 2013 16:12:23 +0000 (16:12 +0000)]
Sketch of SK_ONCE

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/26563002

git-svn-id: http://skia.googlecode.com/svn/trunk@11674 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd new GM to stress test the GPU font cache for cases similar to
commit-bot@chromium.org [Wed, 9 Oct 2013 16:00:42 +0000 (16:00 +0000)]
Add new GM to stress test the GPU font cache for cases similar to
Chromium issue 303803.

BUG=303803
R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/26699002

git-svn-id: http://skia.googlecode.com/svn/trunk@11673 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement stroking a path with nv_path_rendering
commit-bot@chromium.org [Wed, 9 Oct 2013 15:14:18 +0000 (15:14 +0000)]
Implement stroking a path with nv_path_rendering

Initialize the path stroke properties in the GrGLPath constructor.
Use StencilStrokePath and CoverStrokePath to stroke the path.

The order of the GL calls is:
1. StencilFill, if needed
2. StencilStroke, if needed
2a. CoverStroke, if stroke was applied
2b. CoverFill, if stroke was not applied

The reason for not pairing StencilFill + CoverFill, StencilStroke +
CoverStroke is that Skia API does not allow separate fill and stroke
color within one call. Covering the stroke bounding box should also
cover the fill bounding box.

Causes different rendering in gm/dashcubics due to different rendering
algorithm. (?) (TODO: this should be resolved somehow.)

R=bsalomon@google.com, markkilgard@gmail.com, cdalton@nvidia.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/23440049

git-svn-id: http://skia.googlecode.com/svn/trunk@11672 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove tracking code, as it polutes the code readability. Should be added back, in...
edisonn@google.com [Wed, 9 Oct 2013 15:13:19 +0000 (15:13 +0000)]
remove tracking code, as it polutes the code readability. Should be added back, in a less eficient way, by registering streams instead, so we don't have to pass arround the streams, and the code will be cleaner.

Review URL: https://codereview.chromium.org/26700002

git-svn-id: http://skia.googlecode.com/svn/trunk@11671 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoflush after every print in windows
commit-bot@chromium.org [Wed, 9 Oct 2013 15:09:42 +0000 (15:09 +0000)]
flush after every print in windows

R=djsollen@google.com, reed@google.com, epoger@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/26680004

git-svn-id: http://skia.googlecode.com/svn/trunk@11670 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoARM Skia NEON patches - 28 - Xfermode: SIMD modeprocs
commit-bot@chromium.org [Wed, 9 Oct 2013 14:39:46 +0000 (14:39 +0000)]
ARM Skia NEON patches - 28 - Xfermode: SIMD modeprocs

Xfermode: allow for SIMD modeprocs

    This patch introduces the ability to have SIMD Xfermode modeprocs.
    In the NEON implementation, SIMD modeprocs will process 8 pixels
    at a time.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=

Committed: http://code.google.com/p/skia/source/detail?r=11654

R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/23644006

git-svn-id: http://skia.googlecode.com/svn/trunk@11669 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement filling a path with nv_path_rendering cover
commit-bot@chromium.org [Wed, 9 Oct 2013 14:11:33 +0000 (14:11 +0000)]
Implement filling a path with nv_path_rendering cover

Implement filling a path with nv_path_rendering cover functionality.

The nv_path_rendering cover can be used if the fill is non-inverted
and the draw operation does not require use of vertex shaders.

Moves code for the inverted fill from GrStencilAndCoverPathRenderer
down to GrGpuGL.

R=bsalomon@google.com, markkilgard@gmail.com, cdalton@nvidia.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/22686002

git-svn-id: http://skia.googlecode.com/svn/trunk@11667 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove --pdf option as it can now be controlled by --config
commit-bot@chromium.org [Wed, 9 Oct 2013 14:10:27 +0000 (14:10 +0000)]
Remove --pdf option as it can now be controlled by --config

R=borenet@google.com, bsalomon@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/25859006

git-svn-id: http://skia.googlecode.com/svn/trunk@11666 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix valgrind uninitialized memory complaint
robertphillips@google.com [Wed, 9 Oct 2013 12:51:09 +0000 (12:51 +0000)]
Fix valgrind uninitialized memory complaint

https://codereview.chromium.org/26469003/

git-svn-id: http://skia.googlecode.com/svn/trunk@11664 2bbb7eff-a529-9590-31e7-b0007b416f81