Mark Nauwelaerts [Tue, 31 Jan 2012 11:02:45 +0000 (12:02 +0100)]
Safeguard against NULL in strcmp
[In both of these cases, the situation being guarded against is:
check_password() is called, but soup_message_headers_get_one() does not find
an "Authorization" header. -smcv]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Dan Winship <danw@gnome.org>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=669479
Bug-NB: NB#297634
Robert Swain [Tue, 31 Jan 2012 13:27:38 +0000 (14:27 +0100)]
form: Check file pointer before dereferencing
[It's not documented as being allowed to be NULL, but later in the
function there's a check, and GLib convention is generally that all
'out' parameters are allowed to be NULL whether it makes sense or not. -smcv]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Dan Winship <danw@gnome.org>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=669479
Bug-NB: NB#297634
Dan Winship [Mon, 6 Feb 2012 22:19:26 +0000 (17:19 -0500)]
2.37.5
Simon McVittie [Tue, 10 Jan 2012 13:51:31 +0000 (13:51 +0000)]
soup_uri_new: do not allow invalid URIs to be returned, except via soup_uri_new (NULL)
Also document the possible NULL return.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Bug-NB: NB#294977
Simon McVittie [Fri, 3 Feb 2012 14:13:32 +0000 (14:13 +0000)]
SoupURI: add SOUP_URI_IS_VALID() and use it for basic precondition checks
In this patch, field setters don't have precondition checks for the
validity of the URI object itself, only a non-NULL check, to avoid
breaking existing code if it calls soup_uri_new (NULL) and then sets
fields in an unexpected order:
uri = soup_uri_new (NULL); /* uri is invalid */
soup_uri_set_host (uri, "www.google.com");
soup_uri_set_query (uri, "q=badgers");
soup_uri_set_scheme (uri, "http"); /* still invalid... */
soup_uri_set_path (uri, "/search"); /* finally valid */
Also annotate nullable setter parameters as (allow-none), to justify
why they don't have a precondition check.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Bug-NB: NB#294977
Simon McVittie [Fri, 3 Feb 2012 17:47:54 +0000 (17:47 +0000)]
soup_uri_copy_host: always set the path to something non-NULL
Not doing so is considered to be invalid.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Bug-NB: NB#294977
Simon McVittie [Fri, 3 Feb 2012 17:47:16 +0000 (17:47 +0000)]
SoupProxyResolver: construct a valid SoupURI
path = NULL is not considered valid.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Bug-NB: NB#294977
Paweł Forysiuk [Fri, 3 Feb 2012 15:50:44 +0000 (16:50 +0100)]
Try to make file:// uris work in win32 too
Simon McVittie [Fri, 3 Feb 2012 14:20:43 +0000 (14:20 +0000)]
uri-parsing test: add a case that was exercised by a protocol fuzzer
This was suspected to cause a crash via a NULL path; while it seems it
doesn't actually have that problem, it still seems worth testing.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Bug-NB: NB#294977
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Fri, 3 Feb 2012 14:19:28 +0000 (14:19 +0000)]
uri-parsing test: verify that URIs are split correctly
Testing the round-trip (split + reassemble) is necessary, but not
sufficient: a large proportion of SoupURI's API is in terms of the
separate parts, and this was never explicitly tested before.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Fri, 3 Feb 2012 13:51:53 +0000 (13:51 +0000)]
soup_uri_new: annotate uri_string as nullable
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Dan Winship <danw@gnome.org>
Simon McVittie [Tue, 10 Jan 2012 17:03:39 +0000 (17:03 +0000)]
SoupServer: reject non-HTTP URIs and URIs with no host
This prevents a critical warning and other misbehaviour in the
simple-httpd test, when using requests like "GET http: HTTP/1.0".
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Bug-NB: NB#294977
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Dan Winship <danw@gnome.org>
Simon McVittie [Tue, 10 Jan 2012 15:56:08 +0000 (15:56 +0000)]
Header parsing test: verify that a full URI can appear after the "GET"
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Dan Winship <danw@gnome.org>
Simon McVittie [Tue, 10 Jan 2012 13:51:47 +0000 (13:51 +0000)]
soup_uri_uses_default_port: correct documentation
We now know the default for ftp, too.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Dan Winship <danw@gnome.org>
Simon McVittie [Tue, 10 Jan 2012 13:20:38 +0000 (13:20 +0000)]
SoupURI: give "foo:" a non-NULL path member
SoupURI documents uri->path as being required, and got_headers in
SoupServer assumes that it's non-NULL, but in fact parsing a URI
consisting solely of a scheme ("foo:") would leave path = NULL.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=667637
Bug-NB: NB#294977
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Dan Winship <danw@gnome.org>
Dan Winship [Mon, 30 Jan 2012 23:55:40 +0000 (18:55 -0500)]
requester-test: add some more tests
Make sure that content-sniffing and redirections work
Dan Winship [Fri, 27 Jan 2012 18:25:24 +0000 (13:25 -0500)]
chunk-test: add a check that wrote-body-data gives the right data
(This was already working, but not tested, on master, but it was
broken on a work branch.)
Dan Winship [Mon, 23 Jan 2012 17:34:12 +0000 (12:34 -0500)]
SoupHTTPInputStream: don't burn through GCancellable fds
SoupSession limits the number of outgoing TCP connections, but
SoupRequestHTTP/SoupHTTPInputStream were still using a file descriptor
for the GCancellable of each request that got queued, even before it
was sent. This meant that if the app queued 1000ish requests all at
once (eg, while rendering an HTML page with *lots* of images), we
would run out of file descriptors.
Fix this by just using the GCancellable::cancelled signal rather than
g_cancellable_get_fd().
https://bugzilla.gnome.org/show_bug.cgi?id=668508
Raphael Kubo da Costa [Tue, 17 Jan 2012 14:30:48 +0000 (12:30 -0200)]
SoupSession: Do not actually send a request if it was cancelled before.
soup_session_cancel_message() may have been called in a REQUEST_STARTED
callback, so it is safer to make sure that
soup_connection_send_request() is called only if that is not the case.
https://bugzilla.gnome.org/show_bug.cgi?id=668098
Dan Winship [Tue, 17 Jan 2012 19:34:41 +0000 (14:34 -0500)]
post-release version bump
Dan Winship [Tue, 17 Jan 2012 19:02:46 +0000 (14:02 -0500)]
soup-message-io: make soup_message_io_unpause() obey use-thread-context
Dan Winship [Mon, 16 Jan 2012 23:50:01 +0000 (18:50 -0500)]
2.37.4
Dan Winship [Mon, 16 Jan 2012 23:09:22 +0000 (18:09 -0500)]
Belatedly add regression test for CVE-2011-2524
https://bugzilla.gnome.org/show_bug.cgi?id=667635
Xan Lopez [Sun, 1 Jan 2012 18:12:28 +0000 (19:12 +0100)]
soup-request-http: plug leak
The content type of the request is never freed.
https://bugzilla.gnome.org/show_bug.cgi?id=667099
Dan Winship [Thu, 22 Dec 2011 20:53:36 +0000 (15:53 -0500)]
configure.ac: bump glib requirement to 2.31.7 for GSocketClientEvent
Dan Winship [Thu, 8 Dec 2011 16:34:20 +0000 (11:34 -0500)]
SoupMessage: add network-event signal
Proxy the new GSocketClient::event signal and emit it on SoupMessage,
when relevant, to allow (a) debugging, (b) status messages, (c) request
timing, (d) fiddling with sockets
Dan Winship [Wed, 7 Dec 2011 22:03:19 +0000 (17:03 -0500)]
SoupConnection: belatedly fix up unix-only code
The last-minute-check-if-the-socket-has-been-closed-by-the-server code
was written long ago to use soup_socket_get_fd() and g_poll(), and so
was unix-only, but now that SoupSocket is GSocket-based, we can use
g_socket_condition_check() instead.
Dan Winship [Wed, 7 Dec 2011 21:53:26 +0000 (16:53 -0500)]
Force some SoupMessages to use a fresh SoupConnection
Add a new SOUP_MESSAGE_NEW_CONNECTION flag, and insist on getting a
brand new SoupConnection for any message that has that flag set, or
that uses a non-idempotent method.
Add a test to misc-test for this.
https://bugzilla.gnome.org/show_bug.cgi?id=578990
Dan Winship [Wed, 21 Dec 2011 16:50:41 +0000 (11:50 -0500)]
soup-headers: misc improvements
Return an error if the headers start with '\0', ignore header lines
with zero-length header names, and convert excess CRs to spaces. All
of these could possibly occur in received headers, and were previously
hitting g_return_if_fails().
Add a bunch of test cases to header-tests to test these cases (and
some others that we already handled correctly but weren't testing).
Fix the documentation of @str on soup_headers_parse* to reflect
reality.
Based on a patch from Simon McVittie.
https://bugzilla.gnome.org/show_bug.cgi?id=666316
Dan Winship [Tue, 20 Dec 2011 01:39:40 +0000 (20:39 -0500)]
2.37.3
Dan Winship [Fri, 16 Dec 2011 14:08:13 +0000 (09:08 -0500)]
Clarify the meaning of #SoupSession:ssl-strict
and fix the Since tags on #SoupSession:ssl-use-system-ca-file
and #SoupSession:tlsdb
https://bugzilla.gnome.org/show_bug.cgi?id=666280
Dan Winship [Sun, 4 Dec 2011 13:56:01 +0000 (14:56 +0100)]
SoupContentDecoder: add another hack to the broken server hack
We were fixing up responses that mistakenly claimed "gzip"
Content-Encoding for gzipped files, but not responses that mistakenly
claimed "x-gzip" encoding.
Craig Keogh [Sat, 3 Dec 2011 10:33:59 +0000 (11:33 +0100)]
Honor aclocal flags
https://bugzilla.gnome.org/show_bug.cgi?id=641470
Dan Winship [Fri, 2 Dec 2011 09:21:44 +0000 (10:21 +0100)]
bump version to 2.37.2.1 for the request API changes
Dan Winship [Sat, 22 Oct 2011 21:59:07 +0000 (17:59 -0400)]
SoupRequestHTTP: don't complete send() until after sniffing
If the session has a SoupContentSniffer (and it's not disabled for
this message), wait until content-sniffed is emitted before completing
send()/send_async(). Remove the faked content-sniffed emissions from
the cache codepaths, since they should no longer be needed.
https://bugzilla.gnome.org/show_bug.cgi?id=663451
Dan Winship [Sun, 23 Oct 2011 17:51:13 +0000 (13:51 -0400)]
SoupHTTPInputStream: change handling of error responses
Old behavior:
- If the (initial) response status code is 3xx/401/407, and the
message is successfully restarted, then just throw away the
initial response.
- If the (final) response status code is 2xx, then stream the body.
- Otherwise, return a GError from soup_http_input_stream_send*(),
and don't stream the body.
This worked OK for gvfs, which never cared about the bodies of 4xx
responses, but was problematic for WebKitGTK, which ended up needing
three separate (but interwoven) codepaths to handle all the cases.
(And still ended up handling 407 wrong.)
New behavior:
- If the (initial) response status code is 3xx/401/407, and the
message is successfully restarted, then just throw away the
initial response.
- The body of the (final) response is always streamed to the caller.
- A GError is only returned on transport errors, not on 4xx/5xx
responses
(This is an API break, but SoupHTTPInputStream is not API-stable.)
https://bugzilla.gnome.org/show_bug.cgi?id=663451
Dan Winship [Wed, 30 Nov 2011 12:34:43 +0000 (13:34 +0100)]
soup-session: fix some http-aliases/https-aliases problems
and add a test to misc-test
Dan Winship [Wed, 30 Nov 2011 17:30:26 +0000 (18:30 +0100)]
misc-test: fix a bug
misc-test would crash if it ran long enough (due to either stopping in
gdb or just adding enough new tests to the end) because of a bug in the
max_conns_test cleanup code.
Dan Winship [Wed, 30 Nov 2011 20:59:55 +0000 (21:59 +0100)]
Require glib 2.31 and update to new thread APIs
Dan Winship [Wed, 30 Nov 2011 11:31:21 +0000 (12:31 +0100)]
SoupMessage: fix setting of SOUP_MESSAGE_CERTIFICATE_TRUSTED flag
It was accidentally getting cleared at the wrong time (although the
tls-certificate and tls-errors properties were still correct).
Also add a test for this case.
https://bugzilla.gnome.org/show_bug.cgi?id=665182
Dan Winship [Mon, 21 Nov 2011 23:38:30 +0000 (18:38 -0500)]
2.37.2
Dan Winship [Mon, 21 Nov 2011 23:38:25 +0000 (18:38 -0500)]
Fix distcheck
Sergio Villar Senin [Fri, 21 Oct 2011 10:30:08 +0000 (12:30 +0200)]
coding-test.c: refactored and added deflate support.
Refactored the original code. A couple of utility functions perform now all
the checks.
Content compressed with deflate algorithm (with or without zlib headers) is
also supported and checked.
Sergio Villar Senin [Fri, 21 Oct 2011 15:57:46 +0000 (17:57 +0200)]
Adding zlib and raw encoded versions of mbox file for the coding-test
Sergio Villar Senin [Thu, 13 Oct 2011 16:37:24 +0000 (18:37 +0200)]
SoupContentDecoder: add support for deflate Content-Encoding
Claim that we support both gzip and deflate content encodings. Added support
to handle data compressed with deflate with and without zlib headers.
https://bugzilla.gnome.org/show_bug.cgi?id=661682
Dan Winship [Thu, 20 Oct 2011 21:27:34 +0000 (17:27 -0400)]
SoupAuthManagerNTLM: allow non-ASCII usernames/passwords
Switch to using the Unicode-encoded form of NTLM, so that non-ASCII
usernames/passwords will work.
Also, add a "-n" option to tests/get to make it use NTLM, and make
SoupAuthManagerNTLM allow passwords-in-URLs.
Based on a patch from Joachim Breitner, sponsored by ITOMIG GmbH and
the City of Böblingen.
https://bugzilla.gnome.org/show_bug.cgi?id=576838
Dan Winship [Thu, 20 Oct 2011 21:27:34 +0000 (17:27 -0400)]
SoupAuthBasic: allow (some) non-ASCII usernames/passwords
Convert the (assumed-UTF-8) username and password into ISO-8859-1
before encoding. This is what a few other browsers do.
Based on a patch from Joachim Breitner, sponsored by ITOMIG GmbH and
the City of Böblingen.
https://bugzilla.gnome.org/show_bug.cgi?id=576838
Dan Winship [Wed, 5 Oct 2011 20:09:44 +0000 (16:09 -0400)]
auth-test: add a test for server-closes-connection-during-auth
Dan Winship [Wed, 5 Oct 2011 17:57:33 +0000 (13:57 -0400)]
auth-test: reorganize this a bit to be more like other test programs
Dan Winship [Sun, 13 Nov 2011 20:02:34 +0000 (15:02 -0500)]
Fix handling of connections that time out while IN_USE
To avoid looping, we only resend a request on
unexpected-connection-close if it was sent on a connection that has
previously been succesfully used. But we were only setting the
"successfully" used flag after a message *completed*, so if a message
just got restarted, and the connection got closed before the second
sending, then the connection was seen as having never been used, and
so the message wouldn't get re-sent.
Fix this by marking the connection as having been used if a message it
is sending gets restarted.
https://bugzilla.gnome.org/show_bug.cgi?id=660057
Dan Winship [Sat, 12 Nov 2011 14:31:10 +0000 (09:31 -0500)]
context-test: fix cleanup code to avoid a crash
Dan Winship [Sat, 12 Nov 2011 14:27:33 +0000 (09:27 -0500)]
soup-uri: %-encode non-ASCII characters when parsing URIs
https://bugzilla.gnome.org/show_bug.cgi?id=662806
Dan Winship [Mon, 3 Oct 2011 18:58:06 +0000 (14:58 -0400)]
Add SoupSession:use-thread-context
Add a SoupSession flag telling it to use
g_main_context_get_thread_default() on a per-message basis, rather
than using a single GMainContext for everything. In the simple case,
this is just more glib-like API. In the more complicated case, it
allows synchronously sending one or more messages on a
SoupSessionAsync without running the main GMainLoop.
https://bugs.webkit.org/show_bug.cgi?id=68238
Dan Winship [Thu, 13 Mar 2008 01:39:14 +0000 (21:39 -0400)]
SoupSession: add some API for handling redirections
Dan Winship [Sun, 26 Jul 2009 14:43:14 +0000 (10:43 -0400)]
SoupSession: Add http-aliases and https-aliases properties
Currently SoupSession treats all URI schemes except "https" as aliases
for "http", and some apps depend on this. (Eg, iTunes sometimes
returns redirects involving "daap" URIs, which Rhythmbox needs to
treat as "http".) Unfortunately, this also means that it mishandles
redirects to, eg, ftp.
The http-aliases and https-aliases properties allow an app to
explicitly indicate which URI schemes should be considered aliases for
http and https, with other schemes considered to be unknown and
unhandled.
Dan Winship [Mon, 31 Oct 2011 22:34:21 +0000 (18:34 -0400)]
SoupHTTPInputStream: fix a g_warning in error cases
Sergio Villar Senin [Thu, 27 Oct 2011 13:00:31 +0000 (15:00 +0200)]
soup-http-input-stream: unpause the SoupMessage before cancelling it.
If we try to close a SoupHttpInputStream before the SoupMessage is finished
and the SoupMessage is in paused state, it will remain paused forever.
Unpause the SoupMessage before actually cancelling it.
https://bugzilla.gnome.org/show_bug.cgi?id=662847
Sergio Villar Senin [Thu, 27 Oct 2011 15:22:39 +0000 (17:22 +0200)]
soup-directory-input-stream: return a titleless html
Do not set the title of the HTML document returned by
SoupDirectoryInputStream. Also added the file size and the last modified
date to the output.
https://bugzilla.gnome.org/show_bug.cgi?id=662266
Dan Winship [Wed, 26 Oct 2011 23:30:00 +0000 (19:30 -0400)]
remove unnecessary libgthread references
Dan Winship [Tue, 25 Oct 2011 13:18:24 +0000 (09:18 -0400)]
2.37.1
Dan Winship [Sun, 23 Oct 2011 13:17:59 +0000 (09:17 -0400)]
SoupRequestHTTP: reorganize the async code a bit
Use the same "helper" data structure for all three cases (load from
SoupHTTPInputStream, load from cache immediately, and load from cache
after validating).
Dan Winship [Sat, 22 Oct 2011 19:20:07 +0000 (15:20 -0400)]
SoupRequest*, SoupHTTPInputStream: misc cleanups
Dan Winship [Sat, 22 Oct 2011 19:17:57 +0000 (15:17 -0400)]
SoupHTTPInputStream: remove GSeekable support
This was needed in gvfs (where this code originally came from), but
not here.
Dan Winship [Sat, 22 Oct 2011 14:54:29 +0000 (10:54 -0400)]
SoupRequestHTTP: don't cast GFileInputStreams to SoupHTTPInputStream
The return value of soup_cache_send_request() is not a
SoupHTTPInputStream, so don't cast it to that, because it's confusing.
Dan Winship [Fri, 21 Oct 2011 19:18:14 +0000 (15:18 -0400)]
configure: turn some warnings into errors
Use -Werror=... to turn warnings into errors for warnings that occur
in completely well-defined situations (ie, won't change with gcc
versions or optimization levels) and that couldn't be triggered by
foreign #include files.
Dan Winship [Fri, 21 Oct 2011 15:26:15 +0000 (11:26 -0400)]
Remove -DG_DISABLE_DEPRECATED
This causes prototypes like g_mutex_new() to disappear, causing the
prototype to be assumed incorrectly, causing crashes.
For now I still want to be able to build against either glib-2-30 or
glib master, so just remove the -DG_DISABLE_DEPRECATED.
Dan Winship [Thu, 20 Oct 2011 21:56:12 +0000 (17:56 -0400)]
oops, I apparently didn't run "make check" after the tls changes...
Dan Winship [Thu, 20 Oct 2011 21:12:25 +0000 (17:12 -0400)]
tests: make "./tests/foo" work from the toplevel dir
Dan Winship [Thu, 20 Oct 2011 21:05:05 +0000 (17:05 -0400)]
Fix SoupMessage https status information to be set more reliably
In particular, make sure it gets set when a connection fails, so that
soup_message_get_https_status() on the message will tell you *why* it
failed.
Also, update tests/get to display the tls-certificate-errors
Dan Winship [Thu, 20 Oct 2011 21:00:35 +0000 (17:00 -0400)]
SoupSession: fix some SSL problems
Setting SSL_CA_FILE to NULL should not cause warnings. Also, fix SSL
strictness: it should only be TRUE when we have a tlsdb.
Sergio Villar Senin [Fri, 16 Sep 2011 14:55:10 +0000 (16:55 +0200)]
soup-http-input-stream: use a list of SoupBuffers instead a custom buffer
We store now a list of SoupBuffers pending to be read. That would save us
several realloc() and memcpy() if the client does not read from the stream
quickly enough.
https://bugzilla.gnome.org/show_bug.cgi?id=659255
Dan Winship [Fri, 30 Sep 2011 00:41:38 +0000 (20:41 -0400)]
Add SoupServer:tls-certificate to go with SoupSession:tlsdb
Dan Winship [Mon, 26 Sep 2011 23:23:50 +0000 (19:23 -0400)]
libsoup.supp: belatedly commit some fixes
Dan Winship [Tue, 13 Sep 2011 00:33:39 +0000 (20:33 -0400)]
Use GTlsDatabase, add new SoupSession properties for it
Now that we have GTlsFileDatabase, we can use that to validate
certificates when the caller sets SoupSession:ssl-ca-file, rather than
doing it the slow hacky way we had been.
Also, add two new properties, SoupSession:tlsdb, to set an arbitrary
GTlsDatabase on the session, and SoupSession:use-system-ca-file, to
tell it to use the default GTlsDatabase.
Dan Winship [Thu, 29 Sep 2011 14:05:59 +0000 (10:05 -0400)]
redirect-test: add a test for accidental connection sharing
https://bugzilla.gnome.org/show_bug.cgi?id=651146
Sergio Villar Senin [Mon, 26 Sep 2011 17:09:31 +0000 (19:09 +0200)]
SoupSession: set the connection to IDLE on unqueuing SoupMessages
Connection should be set to IDLE state only after being 100% sure that is
not going to be reused by the current owner.
Also, fix a bug in SoupSessionSync revealed by this change.
https://bugzilla.gnome.org/show_bug.cgi?id=651146
Dan Winship [Sun, 7 Aug 2011 22:50:14 +0000 (18:50 -0400)]
SoupSession: make pause/unpause work in any state
https://bugzilla.gnome.org/show_bug.cgi?id=651146
Dan Winship [Thu, 29 Sep 2011 13:50:21 +0000 (09:50 -0400)]
Update for GStaticMutex deprecation in glib master
Instead of using GStaticMutex directly, use the G_LOCK macros, which
use GStaticMutex on older glibs and GMutex on newer glibs.
Dan Winship [Mon, 26 Sep 2011 22:18:24 +0000 (18:18 -0400)]
post-branch version bump to 2.37.0
Dan Winship [Mon, 26 Sep 2011 22:06:10 +0000 (18:06 -0400)]
2.36.0
Dan Winship [Thu, 22 Sep 2011 18:17:47 +0000 (14:17 -0400)]
Lots of gtk-doc fixes (no code changes)
Dan Winship [Mon, 19 Sep 2011 22:03:56 +0000 (18:03 -0400)]
2.35.92
Dan Winship [Mon, 19 Sep 2011 22:03:33 +0000 (18:03 -0400)]
tests/ssl-test: belatedly commit this
Sergio Villar Senin [Fri, 26 Aug 2011 17:03:30 +0000 (19:03 +0200)]
SoupSession: forget about SoupHosts if not used
Free SoupHosts with 0 connections after some time. Host IP addresses will
this way be re-resolved, protecting clients against server IP changes.
https://bugzilla.gnome.org/show_bug.cgi?id=646959
Dan Winship [Mon, 19 Sep 2011 19:36:09 +0000 (15:36 -0400)]
tests/ssl-test: add a test of https-related functionality
Dan Winship [Mon, 19 Sep 2011 19:34:13 +0000 (15:34 -0400)]
tests: update the test ssl key
Update the test ssl key to specify "CN=127.0.0.1", so we don't get
G_TLS_CERTIFICATE_BAD_IDENTITY from it
Dan Winship [Mon, 19 Sep 2011 19:06:20 +0000 (15:06 -0400)]
soup-socket: fix tls-errors property
We were mistakenly leaving G_TLS_CERTIFICATE_UNKNOWN_CA set after
validating the certificate against the ssl_creds's CA list.
Dan Winship [Mon, 19 Sep 2011 18:56:20 +0000 (14:56 -0400)]
soup-message-io: fix setting of SoupMessage TLS properties
Now that the TLS handshake occurs during connection, the socket
properties are set before we get to soup-message-io (and never
change), so copy them to the message right away rather than waiting
for a property notification.
https://bugzilla.gnome.org/show_bug.cgi?id=611496
Dan Winship [Sat, 17 Sep 2011 16:21:36 +0000 (12:21 -0400)]
tests: fix a few leaks, update valgrind suppressions file
Sergio Villar Senin [Fri, 16 Sep 2011 15:08:08 +0000 (17:08 +0200)]
soup-http-input-stream: read data from leftover buffers in finished messages
soup_http_input_stream_read(_async) allow clients to read pending data in
leftover buffers even if the SoupMessage used by the stream is finished.
https://bugzilla.gnome.org/show_bug.cgi?id=659256
Gustavo Noronha Silva [Tue, 13 Sep 2011 16:44:43 +0000 (13:44 -0300)]
Fix documentation to use the appropriate term for flags
Although checking for the existence of flags yields a boolean value,
flags can't be true, they are either set or not set.
Dan Winship [Tue, 30 Aug 2011 16:56:12 +0000 (12:56 -0400)]
2.35.90
Erik van Pienbroek [Fri, 12 Aug 2011 13:58:51 +0000 (15:58 +0200)]
Don't use the reserved keyword 'interface'
On Win32 environments, the keyword 'interface' is a reserved keyword. Up
until now a hack was applied in soup-portability.h to '#undef interface'
so that various pieces of libsoup could use that keyword. However, due
to a recent change in the mingw-w64 toolchain this #undef causes more
breakage while #include'ing other Win32 headers.
As the keyword 'interface' is a reserved keyword on Win32, applications
or libraries shouldn't be messing around with that. This patch changes
various parts of libsoup where the keyword 'interface' is used as name
for variables. These variables have been renamed to 'iface'. Due to this
rename, the #undef hack can be dropped and libsoup can be compiled
cleanly against the latest mingw-w64 toolchain
https://bugzilla.gnome.org/show_bug.cgi?id=656402
Dan Winship [Thu, 11 Aug 2011 01:50:54 +0000 (21:50 -0400)]
Add SOUP_MESSAGE_CAN_REBUILD, for regeneratable streamed request bodies
Long ago, soup_message_body_set_accumulate() was made into a no-op on
request bodies, because otherwise there would be no body available to
send if the request was restarted. Add a SOUP_MESSAGE_CAN_REBUILD
flag, that indicates that the caller takes responsibility for handling
this, and properly discard chunks if that is set.
Also update chunk-test to test this, and (finally!) remove the FIXME
there, since we are now testing the !accumulate codepath again
properly.
https://bugzilla.gnome.org/show_bug.cgi?id=656650
Dan Winship [Tue, 16 Aug 2011 01:05:11 +0000 (21:05 -0400)]
2.35.5
Dan Winship [Tue, 16 Aug 2011 01:17:54 +0000 (21:17 -0400)]
Fix distcheck
arno [Tue, 3 May 2011 05:46:07 +0000 (07:46 +0200)]
SoupContentSniffer: don't use gio anymore
This brings the content sniffing algorithm closer to the HTML5
specification.
https://bugzilla.gnome.org/show_bug.cgi?id=648846
Dan Winship [Mon, 8 Aug 2011 21:48:13 +0000 (17:48 -0400)]
Call soup_message_clean_response() when restarting a message
When a message got restarted, we were leaving the previous response
state in the message, which is bad for various reasons.
In particular, this caused a problem with non-keepalive redirections
of https URLs through proxies (!), because after the second CONNECT
succeeded, it would see that the message already had a status_code
set, and so it thought the message had been cancelled or something
while it was processing the CONNECT. proxy-test now has a regression
test for this case.
Based on patches and analysis from DongJae Kim and Thierry Reding.
https://bugzilla.gnome.org/show_bug.cgi?id=631368
Dan Winship [Sun, 7 Aug 2011 17:02:51 +0000 (13:02 -0400)]
Default to TLS for https connections, and fall back to SSLv3 on failure
Rather than always using SSLv3, try proper TLS+extensions first, and
fall back to SSLv3-without-extensions if that gives an error that
looks like it might mean "broken SSLv3-only server". Use
SoupSessionHost to record the fallback status for a host.
https://bugzilla.gnome.org/show_bug.cgi?id=581342
Dan Winship [Sun, 7 Aug 2011 16:10:45 +0000 (12:10 -0400)]
SoupConnection: do TLS handshake at connection time
Previously, when connecting to an https site, the TLS handshake didn't
happen until we started writing the request. Change it so that it now
happens as part of SoupConnection connecting.