Xavier Claessens [Sun, 2 Feb 2014 14:53:29 +0000 (09:53 -0500)]
Bug 719583 - Get a ESourceRegistry singleton
Chao-Hsiung Liao [Sun, 2 Feb 2014 12:07:00 +0000 (20:07 +0800)]
Updated Traditional Chinese translation(Hong Kong and Taiwan)
Milan Crha [Fri, 31 Jan 2014 12:20:00 +0000 (13:20 +0100)]
maildir_store_get_folder_sync: Fix a use-after-free issue
Matthew Barnes [Thu, 30 Jan 2014 17:33:11 +0000 (12:33 -0500)]
Add CamelNullOutputStream.
GOutputStream subclass to eventually replace CamelStreamNull.
Matthew Barnes [Thu, 30 Jan 2014 14:35:48 +0000 (09:35 -0500)]
IMAPX: Remove unused CAMEL_IMAPX_COMMAND_STREAM option.
99% sure this is unused. Or at least can't find any cases of "%S" in
CamelIMAPXCommand format strings.
Milan Crha [Wed, 29 Jan 2014 18:54:44 +0000 (19:54 +0100)]
Bug #721286 - IMAPx: read messages become unread when reopening Evolution ][
Found one more issue when testing the same change for gnome-3-10:
d) do not use CamelOperation in the parser thread, because it can be
cancelled at an application end with camel_operation_cancel_all() call,
which is done too early, before any pending jobs are properly finished
(it can be IDLE job, or save of folder changes back to the server)
Milan Crha [Wed, 29 Jan 2014 11:50:57 +0000 (12:50 +0100)]
Bug #721286 - IMAPx: read messages become unread when reopening Evolution
Couple things changed here:
a) the camel_folder_summary_get_changed() could return list of changed
messages only if they were loaded in memory, which is not correct - I
think it's part of the issue why it failed
b) it could happen that imapx_server_sync_changes() was called to save some
changes, but then didn't change anything; in such cases, messages marked
as locally changed were never unmarked, which led to false tests; I added
a function to unmark the messages as locally changed (this can cause slow
close of evolution for the first time, due to unsetting of the flag, but
later ends are fine)
c) state of the message flags on the server is the master state, except of
the state where locally stored info is marked as locally changed. This
allows to show proper state of messages on the server (it is influenced
by a) and b) too, so it might take up to two evolution starts to get
the same view in evolution as is the state on the server).
Milan Crha [Tue, 28 Jan 2014 14:25:54 +0000 (15:25 +0100)]
camel_flag_list_copy: Avoid false 'changed' notifications
The function, as written, returned that the destination list
changed even in cases where both flag lists were empty. This
made for example IMAPx report that each message in a folder
hanged, even there did not change any.
Milan Crha [Mon, 27 Jan 2014 12:50:37 +0000 (13:50 +0100)]
imapx_write_flags: Fix a typo which flag to skip
The code was surely trying to avoid writing CAMEL_IMAPX_MESSAGE_RECENT
flag back to the server, but the actual behaviour was that each flag
had been ignored, if the CAMEL_IMAPX_MESSAGE_RECENT was set.
This could have an effect of copied read message being marked as unread
in the destination IMAPx folder.
Milan Crha [Fri, 24 Jan 2014 16:39:45 +0000 (17:39 +0100)]
[Esource] Do not set properties on load which did not change
When calling g_object_set(), g_object_set_property() and similar
set functions, the GObject itself notifies about the property change,
even if the value didn't change at all. This was exhibited by false
notifications when (re)loading ESource on a change on all its saved
properties, which, in particular, was causing bug #722399.
Wylmer Wang [Fri, 24 Jan 2014 13:18:33 +0000 (21:18 +0800)]
Update Chinese simplified translation
Milan Crha [Thu, 23 Jan 2014 12:41:37 +0000 (13:41 +0100)]
Bug #720943 - vFolder does not refresh automatically
Nilamdyuti Goswami [Wed, 22 Jan 2014 16:18:46 +0000 (21:48 +0530)]
Assamese translation updated
Matthew Barnes [Wed, 22 Jan 2014 13:56:08 +0000 (08:56 -0500)]
Bug 722275 - IMAPX: Parser trips on mailbox containing '+'
Mailbox names containing a '+' character were tripping up the parser due
to it being treated as one of a special set of characters to distinguish
identifiers from IMAP syntax. But I don't think '+' is necessary in the
set of characters. For continuations, at least, it should always follow
a newline character, with is also a special character.
Matthew Barnes [Tue, 21 Jan 2014 16:53:47 +0000 (11:53 -0500)]
IMAPX: Remove some unused character macros.
Milan Crha [Tue, 21 Jan 2014 11:45:56 +0000 (12:45 +0100)]
Bug #702709 - Do network background operations only if the CamelSession is online
This may prevent any network background operations, when associated
CamelSession is offline, like when the machine gets suspended or is
just resumed.
Milan Crha [Tue, 21 Jan 2014 07:21:18 +0000 (08:21 +0100)]
[CamelGPGContext] Prefer gpg2 over gpg
If there is a newer version installed, then use it, rather than
the old.
Milan Crha [Mon, 20 Jan 2014 19:12:40 +0000 (20:12 +0100)]
Server-side memory leaks in calendar factory
This change addresses:
- typo for GDestroyNotify (was being used ref, instead of unref)
- leaking data_cal object when opening a calendar
- DataCalView dispose didn't remove view from the backend
These led to memory leaks on both view and backend objects.
Milan Crha [Mon, 20 Jan 2014 18:12:33 +0000 (19:12 +0100)]
[CalDAV] Force password ask on soup authenticate failure
Some servers may allow OPTIONS request on authenticated account with
a wrong password, but fail on REPORT and other queries, which makes
the calendar open routine not recognize the wrong password case.
Fabiano Fidêncio [Fri, 17 Jan 2014 16:51:14 +0000 (17:51 +0100)]
Bug #722415 - Memo does not support Start Date property
Matthew Barnes [Sun, 19 Jan 2014 15:11:46 +0000 (10:11 -0500)]
Add camel_imapx_server_shutdown().
Lets CamelIMAPXStore explicitly tell its server to shut down command
processing. Better than doing this implicitly from dispose(), since
both the idle and parser threads now hold a reference to the server,
and we no longer join with the idle thread.
Matthew Barnes [Fri, 17 Jan 2014 20:14:23 +0000 (15:14 -0500)]
CamelStore: Remove noop_sync() method.
No longer used.
Removed functions:
camel_store_noop_sync()
camel_store_noop()
camel_store_noop_finish()
Matthew Barnes [Fri, 17 Jan 2014 20:12:45 +0000 (15:12 -0500)]
Remove imapx_store_noop_sync().
No longer needed; see the previous commit.
Matthew Barnes [Fri, 17 Jan 2014 20:07:04 +0000 (15:07 -0500)]
CamelIMAPXServer: Ping the server after a period of inactivity.
If an IDLE command is in progress, stop and restart the command.
Otherwise issue a NOOP command. This just lets the IMAP server
know we're still here to (hopefully) avoid being logged off.
This obviates the need for CamelStore's noop() method, which can
now be removed since it was only needed for IMAP.
Matthew Barnes [Fri, 17 Jan 2014 20:06:40 +0000 (15:06 -0500)]
CamelIMAPXServer: A little code reorganization.
Matthew Barnes [Fri, 17 Jan 2014 16:02:02 +0000 (11:02 -0500)]
CamelIMAPXServer: Work around refcounting issue in IDLE thread.
Use the ol' weak-reference-as-callback-closure trick to avoid IDLE
command callbacks holding the last CamelIMAPXServer reference.
Milan Crha [Fri, 17 Jan 2014 15:56:38 +0000 (16:56 +0100)]
Add missing include to git.mk in examples/Makefile.am
Milan Crha [Thu, 16 Jan 2014 20:34:10 +0000 (21:34 +0100)]
Bug #720676 - [IMAPX] Do more searching server-side
The SEARCH command doesn't support all the things evolution can
search for, but it can cover the most common cases, which speeds
searching significantly (especially when the folder content is not
required locally).
Matthew Barnes [Thu, 16 Jan 2014 13:33:16 +0000 (08:33 -0500)]
CamelIMAPXServer: Use a main loop in the parser thread.
The "while" loop previously used in the parser thread just blocked the
thread until incoming data became available. Using a GMainLoop allows
us to add other event sources, like periodic timeouts to help keep the
connection alive without relying on Evolution.
I'm also hoping this will help eliminate the separate thread for IDLE,
since it now uses a GMainLoop as well. But I don't quite have my head
around all the implications yet.
Matthew Barnes [Thu, 16 Jan 2014 13:31:19 +0000 (08:31 -0500)]
CamelIMAPXServer: Remove unused casting macro.
Chao-Hsiung Liao [Thu, 16 Jan 2014 11:36:10 +0000 (19:36 +0800)]
Updated Traditional Chinese translation(Hong Kong and Taiwan)
Milan Crha [Wed, 15 Jan 2014 13:46:37 +0000 (14:46 +0100)]
Bug #687640 - Crash in caldav's initialize_backend()
Two threads could call initialize_backend() simultaneously,
overwriting data one to the other, which caused the crash.
Matthew Barnes [Tue, 14 Jan 2014 17:00:09 +0000 (12:00 -0500)]
CamelIMAPXServer: Give IDLE state enum a proper type definition.
Matthew Barnes [Tue, 14 Jan 2014 16:10:37 +0000 (11:10 -0500)]
CamelIMAPXServer: Use a main loop in the IDLE thread.
Instead of mucking with infinite "while" loops and condition variables,
run a GMainLoop in the IDLE thread and attach a GSource from the parser
thread when an IDLE command should be issued.
Matthew Barnes [Tue, 14 Jan 2014 16:45:14 +0000 (11:45 -0500)]
CamelIMAPXServer: Remove IDLE_LOCK/UNLOCK() macros.
Just call g_mutex_lock/unlock() directly.
Matthew Barnes [Tue, 14 Jan 2014 16:34:50 +0000 (11:34 -0500)]
CamelIMAPXServer: Move IDLE structs to private section.
Milan Crha [Mon, 13 Jan 2014 11:59:38 +0000 (12:59 +0100)]
Bug #721581 - Unable to write to ldap addressbook
Matthew Barnes [Mon, 13 Jan 2014 01:39:59 +0000 (20:39 -0500)]
Post-release version bump.
Matthew Barnes [Mon, 13 Jan 2014 01:17:42 +0000 (20:17 -0500)]
NEWS update for 3.11.4 release.
Matthew Barnes [Mon, 13 Jan 2014 00:51:19 +0000 (19:51 -0500)]
Bug 720657 - IMAPX: No new messages are received
Regression caused by removal of "mobile mode". I misinterpreted some
complex expression embedded in a loop condition, which is why I don't
like complex expressions in loop conditions - difficult to for others
grok, which means high potential for mistakes.
hanniedu [Sat, 11 Jan 2014 15:32:54 +0000 (16:32 +0100)]
Updated dutch translation Master (3.12)
Lubomir Rintel [Thu, 9 Jan 2014 17:19:53 +0000 (12:19 -0500)]
IMAPX: Handle BODY[HEADER] in FETCH response.
A broken IMAP server (whatever they use at Masaryk University) was
seen having this conversation:
C: A001 UID FETCH 1:* (RFC822.SIZE RFC822.HEADER FLAGS)
S: * 1 FETCH (RFC822.SIZE 4220 BODY[HEADER] {523} ...)
...
This confuses Camel into thinking it was a request for a full message
and it in turn fails to update the folder summary and issues a warning
about not being able to locate an appropriate FETCH job.
This works around the issue by treating BODY[HEADER] as equivalent to
RFC822.HEADER in untagged FETCH responses.
Lubomir Rintel [Thu, 9 Jan 2014 16:20:13 +0000 (11:20 -0500)]
CamelIMAPXNamespace: Allow NIL separator character.
RFC 2342 allows it:
Namespace_Response = "*" SP "NAMESPACE" SP Namespace SP Namespace
SP Namespace
Namespace = nil / "(" 1*( "(" string SP (<"> QUOTED_CHAR <"> /
nil) *(Namespace_Response_Extension) ")" ) ")"
^^^
Ryan Lortie [Wed, 8 Jan 2014 17:01:57 +0000 (12:01 -0500)]
configure.ac: trivial typo fix in last commit
-ldb vs. -ldl
Ryan Lortie [Tue, 7 Jan 2014 21:36:12 +0000 (16:36 -0500)]
tests: #include <sys/wait.h> for WIFEXITED
https://bugzilla.gnome.org/show_bug.cgi?id=721737
Ryan Lortie [Tue, 7 Jan 2014 21:31:53 +0000 (16:31 -0500)]
Remove #include <malloc.h> from a file
This ancient header has long been deprecated in favour of <stdlib.h> but
this file uses GLib memory functions anyway, so neither is required.
https://bugzilla.gnome.org/show_bug.cgi?id=721737
Ryan Lortie [Tue, 7 Jan 2014 21:10:13 +0000 (16:10 -0500)]
Bug 721733 - Tweak Berkeley DB detection logic
Make two changes to the logic that we use to find the Berkeley DB:
- in the default case where --with-libdb is not given, do not attempt
to add the default ${prefix}/include and ${prefix}/lib to the CFLAGS
and LIBS. Only do this if --with-libdb is explicitly given.
- in the case where --with-libdb is not given, and DB_CFLAGS or DB_LIBS
is already set, use those values instead of our own guesses
This allows the build to proceed on FreeBSD, where the headers are in an
unusual location and the library has an unusual name.
https://bugzilla.gnome.org/show_bug.cgi?id=721733
Matthew Barnes [Mon, 6 Jan 2014 16:52:07 +0000 (11:52 -0500)]
Bug 721527 - License text contains obsolete FSF postal address
Matthew Barnes [Tue, 7 Jan 2014 14:45:40 +0000 (09:45 -0500)]
Remove camel/README.COPYRIGHT.
The instructions are out-of-date, and advise contacting Novell Inc.
Matthew Barnes [Mon, 6 Jan 2014 12:53:22 +0000 (07:53 -0500)]
Bump SOURCES_DBUS_SERVICE_NAME version.
To cover both the new "ServerError" D-Bus signal and the new built-in
"system-proxy" data source.
Andika Triwidada [Sat, 4 Jan 2014 03:15:01 +0000 (10:15 +0700)]
Updated Indonesian translation
Marek Černocký [Fri, 3 Jan 2014 06:36:36 +0000 (07:36 +0100)]
Updated Czech translation
Rafael Ferreira [Fri, 3 Jan 2014 01:40:31 +0000 (23:40 -0200)]
Updated Brazilian Portuguese translation
Fran Diéguez [Mon, 30 Dec 2013 00:10:53 +0000 (01:10 +0100)]
Updated Galician translations
Gabor Kelemen [Sat, 28 Dec 2013 20:13:55 +0000 (21:13 +0100)]
Updated Hungarian translation
Dimitris Spingos [Thu, 26 Dec 2013 16:36:55 +0000 (18:36 +0200)]
Updated Greek translation
William Jon McCann [Wed, 18 Dec 2013 10:24:00 +0000 (05:24 -0500)]
Update project homepage URL
Matthew Barnes [Mon, 16 Dec 2013 18:12:08 +0000 (13:12 -0500)]
Post-release version bump.
Matthew Barnes [Mon, 16 Dec 2013 17:01:37 +0000 (12:01 -0500)]
NEWS update for 3.11.3 release.
Matthew Barnes [Tue, 10 Dec 2013 21:00:13 +0000 (16:00 -0500)]
CamelIMAPXServer: Fix handling of LSUB responses.
If we receive an LSUB response on a mailbox name but no corresponding
LIST response, ignore it. IMAP allows subscriptions to mailbox names
regardless of whether the mailbox actually exists. Not useful to us.
Matthew Barnes [Tue, 10 Dec 2013 19:41:14 +0000 (14:41 -0500)]
CamelStore: Fix typo preventing valid folder renames.
Matthew Barnes [Tue, 10 Dec 2013 19:30:32 +0000 (14:30 -0500)]
IMAPX: Remove unused member from GetMessageData struct.
Matthew Barnes [Sun, 8 Dec 2013 16:19:08 +0000 (11:19 -0500)]
Coding style and whitespace cleanups.
Matthew Barnes [Sun, 8 Dec 2013 16:42:17 +0000 (11:42 -0500)]
Update API documentation.
Colin Walters [Fri, 22 Nov 2013 20:02:21 +0000 (15:02 -0500)]
Bug 715035 - cache-reaper: Demote g_message() -> g_debug()
No need to tell the system administrator about these.
Matthew Barnes [Fri, 6 Dec 2013 17:25:41 +0000 (12:25 -0500)]
CamelMimeFilter: Function signature cleanup.
Matthew Barnes [Fri, 6 Dec 2013 17:05:50 +0000 (12:05 -0500)]
CamelGpgContext: Fix broken debugging statements.
Camel likes to use this debugging idiom:
#define d(x)
and then wraps debugging statements like so:
d (printf (...));
One is supposed to enable debugging by changing the macro to:
#define d(x) x
This idiom makes debugging statements hard to grep for, but moreover
they don't get compiled regularly and so they tend to bit rot.
As was the case in CamelGpgContext, where the debugging statements
didn't build because they were still written for Camel's old home-
grown object system.
Matthew Barnes [Fri, 6 Dec 2013 16:52:11 +0000 (11:52 -0500)]
CamelStreamFilter: Fix broken debugging statements.
Camel likes to use this debugging idiom:
#define d(x)
and then wraps debugging statements like so:
d (printf (...));
One is supposed to enable debugging by changing the macro to:
#define d(x) x
This idiom makes debugging statements hard to grep for, but moreover
they don't get compiled regularly and so they tend to bit rot.
As was the case in CamelStreamFilter, where the debugging statements
didn't build because they were calling CamelStream functions as they
existed YEARS ago.
Piotr Drąg [Fri, 6 Dec 2013 15:58:53 +0000 (16:58 +0100)]
Updated POTFILES.skip
Tristan Van Berkom [Fri, 6 Dec 2013 06:08:15 +0000 (15:08 +0900)]
Migrated tests/cursor-example to examples/cursor
Examples can be added to the examples subdirectory which does
not belong in 'tests'. Note that the new documentation contains
an examples section, the file eds-cursor-example.sgml is manually
written and includes source code inline, along with some commentary
on the source code example.
Tristan Van Berkom [Fri, 6 Dec 2013 06:03:56 +0000 (15:03 +0900)]
Restructuring documentation build.
This commit unifies the various EDS related reference manuals into
a single 'eds' reference manual. This comprises libedataserver, libebackend,
libebook, libebook-contacts, libedata-book, libecal, libedata-cal into
a single reference manual. The camel and private reference manuals are
left alone.
Tristan Van Berkom [Fri, 6 Dec 2013 06:07:44 +0000 (15:07 +0900)]
ETestServerFixture: Fixing gtk-doc comments.
Tristan Van Berkom [Fri, 6 Dec 2013 06:00:11 +0000 (15:00 +0900)]
Libedataserver: Fixing gtk-doc comments and adding gtk-doc section headers
Tristan Van Berkom [Fri, 6 Dec 2013 05:59:54 +0000 (14:59 +0900)]
Libebackend: Fixing gtk-doc comments and adding gtk-doc section headers
Tristan Van Berkom [Fri, 6 Dec 2013 05:59:14 +0000 (14:59 +0900)]
Calendar: Fixing gtk-doc comments and adding gtk-doc section headers
Tristan Van Berkom [Fri, 6 Dec 2013 05:58:38 +0000 (14:58 +0900)]
Addressbook: Fixing gtk-doc comments and adding gtk-doc section headers
Matthew Barnes [Thu, 5 Dec 2013 15:03:05 +0000 (10:03 -0500)]
CamelFolderSummary: Add a FIXME comment.
Resolving corner cases so I can get rid of camel_folder_lock/unlock().
Matthew Barnes [Thu, 5 Dec 2013 14:26:44 +0000 (09:26 -0500)]
CamelTransport: Stop using the internal 'send_lock'.
Use camel_service_queue_task() instead of locking an internal mutex.
This ensures methods are run in the order they were called, and also
makes cancellation of a waiting method immediate instead of blocking
until it acquires the mutex it's competing for.
This requires flip-flopping the synchronous and asynchronous functions,
so that the synchronous function calls its asynchronous counterpart with
help from CamelAsyncClosure.
Matthew Barnes [Sun, 1 Dec 2013 15:41:45 +0000 (10:41 -0500)]
CamelStore: Stop using the internal 'folder_lock'.
Use camel_service_queue_task() instead of locking an internal mutex.
This ensures methods are run in the order they were called, and also
makes cancellation of a waiting method immediate instead of blocking
until it acquires the mutex it's competing for.
This requires flip-flopping some synchronous and asynchronous functions,
so that the synchronous function calls its asynchronous counterpart with
help from CamelAsyncClosure.
Removed functions:
camel_store_lock()
camel_store_unlock()
Matthew Barnes [Sun, 1 Dec 2013 15:38:43 +0000 (10:38 -0500)]
Add CAMEL_CHECK_LOCAL_GERROR.
Same as CAMEL_CHECK_GERROR, but for direct GError pointers.
Example:
success = class->foo (object, some_data, &local_error);
CAMEL_CHECK_LOCAL_GERROR (object, foo, success, local_error);
return success;
Matthew Barnes [Sat, 30 Nov 2013 17:08:25 +0000 (12:08 -0500)]
Add camel_service_queue_task().
Adds a GTask to a queue of waiting tasks with the same source object.
Queued tasks execute one at a time from a separate thread in the order
they were added.
This is primarily intended for use by CamelStore, CamelTransport and
CamelFolder to achieve ordered invocation of synchronous class methods.
This will finally fix Camel's long-standing (mis)use of mutexes as a
dispatch mechanism, which doesn't preserve order and isn't cancellable.
Matthew Barnes [Wed, 4 Dec 2013 22:37:11 +0000 (17:37 -0500)]
Bug 710361 - GError corruption in imapx_command_fetch_message_done()
camel_imapx_job_take_error() was being called twice on the same GError.
The 2nd call freed the GError set in the 1st call, which corrupted the
memory. Put a safeguard in camel_imapx_job_take_error() to catch this
in the future.
Matthew Barnes [Wed, 4 Dec 2013 17:14:52 +0000 (12:14 -0500)]
Bug 719720 - Refcount error in imapx_command_select_done()
We were finalizing the CamelIMAPXCommand too early, and then trying
to use it further down in the logic. This of course led to crashes.
Failed command structures were also leaking. Fixed that too.
Matthew Barnes [Wed, 4 Dec 2013 14:52:00 +0000 (09:52 -0500)]
Remove --enable-strict configure option.
GLib/GTK+ uses different deprecation macros nowadays.
The MIN_REQUIRED macros do a better job of catching deprecated symbol
usage up to the minimum build requirement, and the MAX_ALLOWED macros
catch symbol usage that violates our minimum build requirement.
These newer deprecation macros are always enabled, so we don't need a
special configure flag for them.
Matthew Barnes [Wed, 4 Dec 2013 14:39:43 +0000 (09:39 -0500)]
Deprecate ECancellable[Rec]Mutex.
Lionel Landwerlin [Wed, 4 Dec 2013 14:24:12 +0000 (09:24 -0500)]
Bug 719774 - Missing linker flag in evolution-addressbook-factory
Colin Walters [Wed, 4 Dec 2013 14:10:25 +0000 (09:10 -0500)]
Bug 719307 - trust-prompt: Squash a compiler warning
gcc tells us this could be uninitialized, which will only happen if we
fail to base64 decode.
Tristan Van Berkom [Wed, 4 Dec 2013 08:01:37 +0000 (17:01 +0900)]
Moved all libecal/client tests to have a namespace
Avoid naming conflicts when installing tests into ${pkglibexecdir}/installed-tests
Tristan Van Berkom [Wed, 4 Dec 2013 08:00:37 +0000 (17:00 +0900)]
Moved all libebook/client tests to have a namespace
Avoid naming conflicts when installing tests into ${pkglibexecdir}/installed-tests
Philip Withnall [Fri, 29 Nov 2013 08:58:40 +0000 (08:58 +0000)]
tests: Fix potential g_object_unref(NULL) calls in libebook tests
Found by scan-build.
https://bugzilla.gnome.org/719533
Philip Withnall [Fri, 29 Nov 2013 08:56:57 +0000 (08:56 +0000)]
libedata-cal: Fix a potential g_strstrip(NULL) call
If the calendar contained any attendees _not_ prefixed with ‘mailto:’,
the text variable would be NULL, and would cause an assertion failure in
g_strstrip().
Found by scan-build.
https://bugzilla.gnome.org/719533
Philip Withnall [Fri, 29 Nov 2013 08:51:11 +0000 (08:51 +0000)]
libecal: Refactor system timezone key file parsing code
Previously, the code could call g_strstrip(NULL) if a line started with
a quotation mark but didn’t end with one, e.g.:
MyKey="some-unbalanced-value
The code now ignores unbalanced quotation marks, returning the odd one
in the value rather than crashing (or stripping it).
Found by scan-build.
https://bugzilla.gnome.org/719533
Philip Withnall [Tue, 3 Dec 2013 20:26:57 +0000 (15:26 -0500)]
EBookBackendCache: Remove an unnecessary NULL check.
A newly-created EContact is never NULL, so the check is redundant.
It was confusing the static analyser.
https://bugzilla.gnome.org/719533
Philip Withnall [Tue, 3 Dec 2013 19:55:29 +0000 (14:55 -0500)]
CamelPOP3Folder: Fix a potential g_object_unref(NULL) call
If all the branch conditions in this function evaluate to FALSE, the
stream is never set, and hence g_object_unref(NULL) is called on exiting
the function.
Found by scan-build.
https://bugzilla.gnome.org/719533
Matthew Barnes [Mon, 2 Dec 2013 13:32:16 +0000 (08:32 -0500)]
CamelTransport: Port to GTask.
Matthew Barnes [Mon, 2 Dec 2013 13:45:32 +0000 (08:45 -0500)]
CamelSubscribable: Port to GTask.
Matthew Barnes [Sun, 1 Dec 2013 17:05:05 +0000 (12:05 -0500)]
CamelStore: Port to GTask.
Matthew Barnes [Mon, 2 Dec 2013 20:40:41 +0000 (15:40 -0500)]
CamelSession: Port to GTask.
Matthew Barnes [Tue, 3 Dec 2013 16:05:24 +0000 (11:05 -0500)]
CamelService: Port to GTask.
Matthew Barnes [Mon, 2 Dec 2013 19:56:38 +0000 (14:56 -0500)]
CamelSasl: Port to GTask.