platform/upstream/gstreamer.git
2 years agohlsdemux: after update playlist, setup streams if current variant changes 38/273438/3 submit/tizen/20220406.053411
Gilbok Lee [Wed, 6 Apr 2022 00:15:03 +0000 (09:15 +0900)]
hlsdemux: after update playlist, setup streams if current variant changes

- If the playlist update fails, the main playlist is downloaded newly
  At this time, a new playlist is created and the previous playlist isn't updated.

[Version] 1.20.0-12
[Issue Type] Bug fix

Change-Id: If7313c529b411d9f6c86019e3e24c6f4f475dda7

2 years agowebrtcstats: Unify 'packets-lost' data type to int64 86/273286/2
Sangchul Lee [Mon, 28 Mar 2022 12:25:50 +0000 (21:25 +0900)]
webrtcstats: Unify 'packets-lost' data type to int64

Previously, 'packets-lost' member of RTCReceivedRtpStreamStats had
a value of G_TYPE_INT from rtpsource or a value of G_TYPE_UINT64
from rtpjitterbuffer.
Because of the negative value of estimated amount of packets lost
in rtpsource as well as the description in
https://www.w3.org/TR/webrtc-stats/#dom-rtcreceivedrtpstreamstats
it is fixed to set this value with G_TYPE_INT64.

Change-Id: Ife744ab6d039fda1647c893089d1cacbc04a508a
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2049>

2 years agowebrtc/datachannel: fix use-after-free in sctp state notification 85/273285/2
Matthew Waters [Fri, 26 Nov 2021 11:11:06 +0000 (22:11 +1100)]
webrtc/datachannel: fix use-after-free in sctp state notification

g_signal_disconnect*() doesn't stop any existing callbacks from running
which means that if the notify::state callback is in progress in one
thread and the data channel object is finalize()ed in another thread,
then there could be a use-after-free trying lock the data channel
object.

We can't reasonably use a GWeakRef as we don't have a 'parent' object to
free the GWeakRef after the data channel is finalized.  This is also
complicated by the fact that the application can hold a reference to the
data channel object that would live beyond the lifetime of webrtcbin
itself.

We solve this by implementing a ghetto weak-ref solution internally with
a list of outstanding data channels.

Change-Id: Id901ca1cbd3edf1a9b9337a65b414d91c803cc3c
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: Update documentation of 'get-stats' action signal 73/273073/1
Sangchul Lee [Mon, 21 Mar 2022 15:30:28 +0000 (00:30 +0900)]
webrtcbin: Update documentation of 'get-stats' action signal

Some stats fields are updated according to the current implementation.

Change-Id: Id45e1984fa07c056dc26f01276ec38b84bc61cca
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2005>

2 years agowebrtcbin: Check data channel transport for notifying 'ice-gathering-state' 72/273072/1
Sangchul Lee [Thu, 10 Mar 2022 10:22:52 +0000 (19:22 +0900)]
webrtcbin: Check data channel transport for notifying 'ice-gathering-state'

Previously, it did not care about data channel's. It is fixed by adding
some conditions.

Change-Id: Ie388e25f40a43dcbd39ec2c477022f8984f04e98
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1957>

2 years agogood:v4l2videodec: Fix DRC issue 30/272930/1 submit/tizen/20220329.001259
Jeongmo Yang [Mon, 28 Mar 2022 06:15:55 +0000 (15:15 +0900)]
good:v4l2videodec: Fix DRC issue

[Version] 1.20.0-11
[Issue Type] Bug fix

Change-Id: I75a392a7c3ae5ac6bd366924d73a670270f268d2
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agov4l2videodec : enable resolution change 28/272928/1
Ming Qian [Tue, 19 Oct 2021 08:10:06 +0000 (16:10 +0800)]
v4l2videodec : enable resolution change

The dynamic resolution changes when
the sequence starts when the decoder detects a coded frame with one or
more of the following parameters different from those previously
established (and reflected by corresponding queries):
1.coded resolution (OUTPUT width and height),
2.visible resolution (selection rectangles),
3.the minimum number of buffers needed for decoding,
4.bit-depth of the bitstream has been changed.

Although gstreamer parser has parsed the stream resolution.
but there are some case that we need to handle resolution change event.
1. bit-depth is different from the negotiated format.
2. the capture buffer count can meet the demand
3. there are some hardware limitations that the decoded resolution may
be larger than the display size. For example, the stream size is
1920x1080, but some vpu may decode it to 1920x1088.

Change-Id: I99c7e973c197490b462b5d3100b413007fc19c39
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1381>

2 years agov4l2videodec : refactor the setup process of capture 27/272927/1
Ming Qian [Tue, 26 Oct 2021 02:03:42 +0000 (10:03 +0800)]
v4l2videodec : refactor the setup process of capture

v4l2videodec do some refactoring so that it can support
dynamic resolution change event.

1.wrap the setup process of capture as a function,
as decoder need setup the capture again when
dynamic resolution change event is received.

2.move the function "remove_padding"

Change-Id: I31fc55b5247e80f4ee7692cf925ca4f06fac2d3b
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1381>

2 years agoFix build error in tv profile 44/272444/3 accepted/tizen/unified/20220323.062839 submit/tizen/20220318.052318
Gilbok Lee [Thu, 17 Mar 2022 00:35:28 +0000 (09:35 +0900)]
Fix build error in tv profile

- Add the necessary cflags in pkgconfig
- Add missed build define

[Version] 1.20.0-10
[Issue Type] Bug fix

Change-Id: Id86be2511a21c711e55ca2636d12625871b24d4a

2 years agowebrtcbin: Check data channel transport for notifying 'ice-gathering-state' 64/272164/10 accepted/tizen/unified/20220318.020352 submit/tizen/20220317.011210
Sangchul Lee [Thu, 10 Mar 2022 08:17:53 +0000 (17:17 +0900)]
webrtcbin: Check data channel transport for notifying 'ice-gathering-state'

Previously, it did not care about data channel's. It is fixed by adding
some conditions.

[Version] 1.20.0-9
[Issue Type] Bug fix

Change-Id: If1fd8047c1a944ccbe65c13b1cda7c0e34a7bec7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agogood:v4l2: Add new feature to disable colorimetry 96/272296/3
Jeongmo Yang [Mon, 14 Mar 2022 07:25:42 +0000 (16:25 +0900)]
good:v4l2: Add new feature to disable colorimetry

- V4L2 driver on RPI4 does not support some colorimetry,
  it causes video playing failure with some contents.

[Version] 1.20.0-8
[Issue Type] New feature

Change-Id: I87026e658b44784cbcc427551275aa03f03012c1
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agospec: apply tv profile requirement 10/272210/4
Eunhye Choi [Fri, 11 Mar 2022 07:26:45 +0000 (16:26 +0900)]
spec: apply tv profile requirement

Change-Id: Ia8b7a5869182bce4cbdd24c6fa96702bf5da556d

2 years agogood:v4l2: Add new property for TBM dump 80/272180/5
Jeongmo Yang [Thu, 10 Mar 2022 12:45:51 +0000 (21:45 +0900)]
good:v4l2: Add new property for TBM dump

[Version] 1.20.0-6
[Issue Type] New feature

Change-Id: Ia1233939ad58a9797840760cf2c35d4fa728f97c
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agofix up! good:v4l2bufferpool: Fix crash when v4l2h264dec is stopped 21/271521/2 accepted/tizen/unified/20220223.132507 submit/tizen/20220222.233730
Jeongmo Yang [Tue, 22 Feb 2022 09:49:55 +0000 (18:49 +0900)]
fix up! good:v4l2bufferpool: Fix crash when v4l2h264dec is stopped

- Add new parameter to check whether it's locked or not.

[Version] 1.20.0-5
[Issue Type] Bug fix

Change-Id: I5fabc83d3100b7ae3b46f48743a212311895f5b4
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agomeson: apply latest build script 27/271427/2 submit/tizen/20220222.093450
Eunhye Choi [Mon, 21 Feb 2022 06:18:12 +0000 (15:18 +0900)]
meson: apply latest build script

- revert 5b8d85d2d7268312a7e6ba40d08d53a0ffd7f209
- meson version have to be over 0.59.x

Change-Id: I9466034180183e7b1ee99e44ab6cca27f78e0815

2 years agofixup! gst-plugins-bad: Rename some definitions for TIZEN 33/271433/1 accepted/tizen/unified/20220222.132931 submit/tizen/20220221.101104
Sangchul Lee [Mon, 21 Feb 2022 07:28:40 +0000 (16:28 +0900)]
fixup! gst-plugins-bad: Rename some definitions for TIZEN

[Version] 1.20.0-3
[Issue Type] Typo

Change-Id: I9a336c1f21322c503e4702f443013ac7ef1a77e3

2 years agortpvp8depay: Fix crash when sending new custom event 31/271431/2
Sangchul Lee [Mon, 21 Feb 2022 06:50:50 +0000 (15:50 +0900)]
rtpvp8depay: Fix crash when sending new custom event

This patch fixes a seg.fault with warnings as below.

GLib-GObject-WARNING **: 13:56:46.770: ../gobject/gtype.c:4330: type id '0' is invalid
GLib-GObject-WARNING **: 13:56:46.772: can't peek value table for type '<invalid>' which is not currently referenced

[Version] 1.20.0-2
[Issue Type] Crash

Change-Id: If33c7c63e6ef14f9f5bcfaea8d0e650311ff1f16
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agoMerge "meson: Apply ASLR on Executable" into tizen
eunhae choi [Mon, 21 Feb 2022 03:45:34 +0000 (03:45 +0000)]
Merge "meson: Apply ASLR on Executable" into tizen

2 years agogood:v4l2bufferpool: Fix crash when v4l2h264dec is stopped 98/271398/1 accepted/tizen/unified/20220220.211441 submit/tizen/20220219.173827
Jeongmo Yang [Sat, 19 Feb 2022 14:52:58 +0000 (23:52 +0900)]
good:v4l2bufferpool: Fix crash when v4l2h264dec is stopped

- When gst_v4l2_buffer_pool_streamoff() is called, mutex for pool is locked
  and wait for buffer if there is a buffer which is not queued(=released) yet.
  But the mutex is also used when buffer is going to queue,
  so it cause deadlock and crash finally.
- This issue is occurred since below patch.
  commit id: ca61a76987e566555a2f7bc0f4c1bcf3a8ad6dcd
  v4l2: Fix threading issues in orphaning mechanism

[Version] 1.20.0-1
[Issue Type] Deadlock and crash

Change-Id: I980dc29156a40102206038e58f762ae7f2314e11
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agomeson: Apply ASLR on Executable 82/271382/1
Eunhye Choi [Fri, 18 Feb 2022 11:17:18 +0000 (20:17 +0900)]
meson: Apply ASLR on Executable

Change-Id: I87f1c357ac0f925e2b9cf2794b14f8d7673dd9e2

2 years agospec: fix emul build error 56/271156/2 accepted/tizen/unified/20220217.153506 submit/tizen/20220216.051033
Eunhye Choi [Wed, 16 Feb 2022 06:25:16 +0000 (15:25 +0900)]
spec: fix emul build error

- exclude omx build in case of ix86, x86_64

Change-Id: I3bbc650746a12b0dcd2459107af52f4c8b9790f3

2 years agogood:qtmux: Enable TIZEN_FEATURE_GST_MUX_ENHANCEMENT and fix build error 50/271150/1
Jeongmo Yang [Tue, 15 Feb 2022 12:46:35 +0000 (21:46 +0900)]
good:qtmux: Enable TIZEN_FEATURE_GST_MUX_ENHANCEMENT and fix build error

Change-Id: I88f573164982d78487b9975966eadb2fb40424a2
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
(cherry picked from commit b250b4bd1668640981b26df9cfd5d03a8ff16c32)

2 years agoMerge branch 'tizen_gst_1.20.0' into tizen 00/271100/1
Gilbok Lee [Tue, 15 Feb 2022 08:45:42 +0000 (17:45 +0900)]
Merge branch 'tizen_gst_1.20.0' into tizen

Change-Id: I0593f0ccef22bc03857264fc421ad17fca21778c

2 years agobuild: downgrade of meson 91/271091/3
Eunhye Choi [Tue, 15 Feb 2022 07:56:34 +0000 (16:56 +0900)]
build: downgrade of meson

- downgrade of meson temporarily for SR verification.
- this will be reverted as soon as meson 0.60.3 is applied
  at tizen_base.

Change-Id: I458e1907c36011c45efc6cf9a49292eac281fabd

2 years agogood:v4l2videodecoder: Fix video decoding failure 86/271086/2
Jeongmo Yang [Tue, 15 Feb 2022 07:15:24 +0000 (16:15 +0900)]
good:v4l2videodecoder: Fix video decoding failure

1. not-negotiation
 : Skip adding color space for output.
2. buffer drop
 : Set missed timestamp.

Change-Id: I54058c9e917a3e6b6dbf5efbc03461782aee68e4
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agospec: remove release macro 33/271033/1
Eunhye Choi [Mon, 14 Feb 2022 11:04:18 +0000 (20:04 +0900)]
spec: remove release macro

- spec :
  remove release macro which is not supported on Quick Build system
- core :
  disable deprecated declaration temporarily to avoid build error
  of related modules

Change-Id: Ib527e9aaf98d3c4c0d933eca30b77e4f70af6416

2 years agoUse gst_branch define in spec 42/270942/3
Gilbok Lee [Fri, 11 Feb 2022 08:59:10 +0000 (17:59 +0900)]
Use gst_branch define in spec

- Use _lib_gstreamer_dir define in spec

Change-Id: I34ece90b32f3ccd07e210b13b95b7cfa23596e79

2 years agogstreamer: enable check 34/270934/1
Gilbok Lee [Fri, 11 Feb 2022 08:13:43 +0000 (17:13 +0900)]
gstreamer: enable check

Change-Id: Ia0f9d56d52c2bd73ef950b55db8d851c81f7d58f

2 years agoFix incorrect define 97/270897/2
Gilbok Lee [Fri, 11 Feb 2022 01:55:22 +0000 (10:55 +0900)]
Fix incorrect define

Change-Id: I3ea1d50c627203ff94cf0aead09ee3b1e300f21e

2 years agoMerge "nice: Add gstreamer plugins from libnice (0.1.17)" into tizen_gst_1.20.0
Sangchul Lee [Thu, 10 Feb 2022 10:20:56 +0000 (10:20 +0000)]
Merge "nice: Add gstreamer plugins from libnice (0.1.17)" into tizen_gst_1.20.0

2 years agoMerge "spec: Fix to have valid release version when building each plugin" into tizen_...
Gilbok Lee [Thu, 10 Feb 2022 08:26:03 +0000 (08:26 +0000)]
Merge "spec: Fix to have valid release version when building each plugin" into tizen_gst_1.20.0

2 years agovideo-format: TV profile format(STV0 and STV1) location rearrangement 60/270860/1
Hyunil [Thu, 10 Feb 2022 07:38:18 +0000 (16:38 +0900)]
video-format: TV profile format(STV0 and STV1) location rearrangement

Change-Id: Ie0fc546358688dd119025271f09990b68018b6c6
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
2 years agonice: Add gstreamer plugins from libnice (0.1.17) 47/270847/3
Sangchul Lee [Thu, 10 Feb 2022 05:29:21 +0000 (14:29 +0900)]
nice: Add gstreamer plugins from libnice (0.1.17)

Change-Id: I30b4590d3e767ccff11a385ebfa5597935bc0db8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agospec: Fix to have valid release version when building each plugin 17/270817/1
Sangchul Lee [Wed, 9 Feb 2022 09:36:59 +0000 (18:36 +0900)]
spec: Fix to have valid release version when building each plugin

Change-Id: I1f428505d85428385e7cef721c0499306cb0a804
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agospec: add release def for each plugin 49/270649/2
Eunhye Choi [Mon, 7 Feb 2022 16:54:30 +0000 (01:54 +0900)]
spec: add release def for each plugin

- add release define for each plugin
- use tar.gz to reduce archive time during build

Change-Id: I1d9cb584f73c79c3486c4ebbdf8a28f3374e3ae9

2 years agoMerge branch 'tizen_gst_1.19.3' into tizen_gst_1.20.0 96/270596/4
Gilbok Lee [Mon, 7 Feb 2022 01:09:35 +0000 (10:09 +0900)]
Merge branch 'tizen_gst_1.19.3' into tizen_gst_1.20.0

Change-Id: I4a331bbd883e5f078684fd02948d8d6e9b78eed0

2 years agogst-plugins-base: Add camera control interface 33/270533/1
Gilbok Lee [Fri, 4 Feb 2022 08:07:41 +0000 (17:07 +0900)]
gst-plugins-base: Add camera control interface

Change-Id: Iad5a2993728df0d79fbdfc8a50ca4630e1d4044e

2 years agogst-plugins-base : Add missing definition for pkg-config 31/270531/1
Gilbok Lee [Fri, 4 Feb 2022 07:34:03 +0000 (16:34 +0900)]
gst-plugins-base : Add missing definition for pkg-config

Change-Id: Ia99e541c280e81e400b39b17d5cc0dd46d90e8dc

2 years agoChange auto features to 'disabled' 30/270530/3
Gilbok Lee [Fri, 4 Feb 2022 07:11:07 +0000 (16:11 +0900)]
Change auto features to 'disabled'

Change-Id: Ifff14cae99c0718f2e615253c10ba3e5b0712fbb

2 years agoRelease 1.20.0 1.20.0
Tim-Philipp Müller [Thu, 3 Feb 2022 19:53:25 +0000 (19:53 +0000)]
Release 1.20.0

2 years agoUpdate ChangeLogs for 1.20.0
Tim-Philipp Müller [Thu, 3 Feb 2022 19:53:18 +0000 (19:53 +0000)]
Update ChangeLogs for 1.20.0

2 years agovideo: fix up GstVideoOrientationMethod type registration
Tim-Philipp Müller [Thu, 3 Feb 2022 18:18:03 +0000 (18:18 +0000)]
video: fix up GstVideoOrientationMethod type registration

... in order to make older g-i happy (~1.60) which doesn't like
freeform descriptions in the value_name field. Which in turn
then makes hotdoc happy instead of erroring out when we bump
the symbol index version.

We usually only (ab)use the name field for description strings
for private plugin enums, not for public API visible to bindings.

This lets glib-mkenum generate the _get_type() function for the
enum again, which in turn will generate the expected value names
to match the enums.

We might be able to add this back later once we can upgrade the
g-i version requirement (and the documentation job image).

This reverts most of commit b0aab48cdcf0a454d14aeb4d907209d8ee3f1add

2 years agortsp-server: includes GObject-introspection 03/270503/4
Hyunsoo Park [Thu, 3 Feb 2022 14:27:16 +0000 (23:27 +0900)]
rtsp-server: includes GObject-introspection

Change-Id: Ia3a93b0edb37f8b04ecbc4fba58f74642c47f3cd
Signed-off-by: Hyunsoo Park <hance.park@samsung.com>
2 years agortsp-server: remove files of no use 75/270475/3
Hyunsoo Park [Thu, 3 Feb 2022 07:05:45 +0000 (16:05 +0900)]
rtsp-server: remove files of no use

'*-ext' files are inherited for tizen extension.
And these have been used internally, but no longer used.

Change-Id: Icb49a56b4f26ee008d84a43b1ae8cc0839d7a5fb
Signed-off-by: Hyunsoo Park <hance.park@samsung.com>
2 years agoregistry/macos: retrieve plugins relative to location of libgstreamer.dylib
Matthew Waters [Wed, 2 Feb 2022 07:06:49 +0000 (18:06 +1100)]
registry/macos: retrieve plugins relative to location of libgstreamer.dylib

Provides a relocatable directory structure for running GStreamer
applications as used in GStreamer.framework.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1627>

2 years agogst-plugins-base: Add missing definition for gstreamer-video-1.0 pkg-config 50/270450/1
Sangchul Lee [Thu, 3 Feb 2022 02:19:11 +0000 (11:19 +0900)]
gst-plugins-base: Add missing definition for gstreamer-video-1.0 pkg-config

It is fixed to use tizen functions in videooverlay.h.

Change-Id: I132d9d04be952aa815e4c4d8702611def87374ac
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agodashsink: doc cleanup
Stéphane Cerveau [Wed, 2 Feb 2022 08:58:15 +0000 (09:58 +0100)]
dashsink: doc cleanup

Remove max-files mention in the command line test
Fix some typos
Use mpegtsdemux instead of tsdemux in the pipeline description

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1624>

2 years agoIncl resample in CustomData, tutorial 3
Alistair Martin [Tue, 1 Feb 2022 14:51:23 +0000 (14:51 +0000)]
Incl resample in CustomData, tutorial 3

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1619>

2 years agotagdemux: Fix crash when presented with malformed files
Jeremy Cline [Sun, 21 Nov 2021 22:52:48 +0000 (17:52 -0500)]
tagdemux: Fix crash when presented with malformed files

There's a race condition in gsttagdemux.c between typefinding and the
end-of-stream event. If TYPE_FIND_MAX_SIZE is exceeded,
demux->priv->collect is set to NULL and an error is returned. However,
the end-of-stream event causes one last attempt at typefinding to occur.

This leads to gst_tag_demux_trim_buffer() being called with the NULL
demux->priv->collect buffer which it attempts to dereference, resulting
in a segfault.

The malicious MP3 can be created by:

printf "\x49\x44\x33\x04\x00\x00\x00\x00\x00\x00%s", \
    "$(dd if=/dev/urandom bs=1K count=200)" > malicious.mp3

This creates a valid ID3 header which gets us as far as typefinding. The
crash can then be reproduced with the following pipeline:

gst-launch-1.0 -e filesrc location=malicious.mp3 ! queue ! decodebin ! audioconvert ! vorbisenc ! oggmux ! filesink location=malicious.ogg

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/967

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1620>

2 years agonvdecoder: Fix for display resolution setup
Seungha Yang [Mon, 31 Jan 2022 15:18:44 +0000 (00:18 +0900)]
nvdecoder: Fix for display resolution setup

Display resolution should be cropped rect, not coded resolution.
Otherwise decoded output from NVDEC might be wrong.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1617>

2 years agoapplemedia: Disable 64RGBALE support on older macOS
Nirbheek Chauhan [Mon, 31 Jan 2022 21:30:41 +0000 (03:00 +0530)]
applemedia: Disable 64RGBALE support on older macOS

The kCVPixelFormatType_64RGBALE enum is only available on macOS Big
Sur (11.3) and newer. We also cannot use that while configuring the
encoder or decoder on older macOS.

Define the symbol unconditionally, but only use it when we're running
on Big Sur with __builtin_available().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1613>

2 years agoapplemedia: Remove some unnecessary variables
Nirbheek Chauhan [Mon, 31 Jan 2022 21:34:32 +0000 (03:04 +0530)]
applemedia: Remove some unnecessary variables

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1613>

2 years agodocs: gst-libav: update cache and symbol index for FFmpeg 4.4
Mathieu Duponchelle [Fri, 28 Jan 2022 18:58:55 +0000 (19:58 +0100)]
docs: gst-libav: update cache and symbol index for FFmpeg 4.4

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1597>

2 years agodocs: Add objc and objcpp files to hotdoc gst_c_sources
Nirbheek Chauhan [Mon, 31 Jan 2022 23:37:04 +0000 (05:07 +0530)]
docs: Add objc and objcpp files to hotdoc gst_c_sources

Hotdoc should be able to extract and parse comments out of these. Just
need to be careful to only add the glob in directories that actually
contain *.m (objc) and *.mm (objcpp) files.

Also fix some doc comments and remove redundant ones.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1614>

2 years agovaapi: Disable Wayland if no libdrm
Víctor Manuel Jáquez Leal [Sun, 30 Jan 2022 08:38:48 +0000 (09:38 +0100)]
vaapi: Disable Wayland if no libdrm

Platform wise, is not possible, as far as I known, to have Wayland
without kernel's DRM. Though, it's possible to configure
gstreamer-vaapi without DRM but Wayland support, with the enhanced
handling of dmabuf in vaapisink for Wayland, vaapisink will always
fail. Given both issues, configuration with no DRM but Wayland, makes
things more complex, and a simpler approach is to refuse that
configuration.

This patch disables Wayland support if there isn't DRM support. Also,
it disables the display test for Wayland, relying only on DRM and
X11.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1606>

2 years agovaapi: libs: video-format: Check if formats map is not NULL.
Víctor Manuel Jáquez Leal [Sun, 30 Jan 2022 06:10:09 +0000 (07:10 +0100)]
vaapi: libs: video-format: Check if formats map is not NULL.

Formats map is instantiated at the end of the display
instantiation. The problem is the Wayland display which looks for a
format in a callback, before the map is populated.

If user compiles gstreamer-vaapi with DRM support, the map is
populated with a DRM display at GStreamer plugin registration. But if
not, or a VA driver is not available, the plugin will try with a
Wayland driver, which cause the NULL de-reference.

Nevertheless, in the case of no DRM support, and if the Wayland
display doesn't get a reply from the format conversion is not a
problem.

So the solution is the trivial one, check if the format map is already
populated before de-reference it.

Fixes: #977
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1606>

2 years agogstreamer-full: warn if version-script not available
Stéphane Cerveau [Tue, 19 Oct 2021 10:32:32 +0000 (12:32 +0200)]
gstreamer-full: warn if version-script not available

Instead of error out, warn user that the platform does not support
the version script.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1191>

2 years agowpe: Support wpe-webkit-1.1
Jan Alexander Steffens (heftig) [Fri, 14 Jan 2022 10:26:42 +0000 (11:26 +0100)]
wpe: Support wpe-webkit-1.1

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1522>

2 years agowpe: Install WebExtension in pkglibdir
Philippe Normand [Sat, 29 Jan 2022 10:24:36 +0000 (10:24 +0000)]
wpe: Install WebExtension in pkglibdir

The uninstalled WebExtension takes precedence over the installed one, so that
audio support works in local developer builds as well.

Fixes #975

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1602>

2 years agodocs: Rename "OS X" to "macOS" in some documentation
Nirbheek Chauhan [Sun, 30 Jan 2022 13:36:29 +0000 (19:06 +0530)]
docs: Rename "OS X" to "macOS" in some documentation

No one uses the term "Mac OS X" anymore, it's "macOS". "OS X" is even
worse, because people will usually start the search with "mac".

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1607>

2 years agoosxaudio: Document GstOsxAudioElement interface
Nirbheek Chauhan [Sat, 29 Jan 2022 22:26:14 +0000 (03:56 +0530)]
osxaudio: Document GstOsxAudioElement interface

This is listed as a public interface implemented by osxaudio, so we
need to mark it as a plugin API so that it's listed in the
documentation correctly.

This is an ancient symbol, so add it to the symbol index too.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1601>

2 years agoapplemedia: Document vtenc / vtdec elements
Nirbheek Chauhan [Fri, 28 Jan 2022 17:45:28 +0000 (23:15 +0530)]
applemedia: Document vtenc / vtdec elements

Also preserve-alpha property should only be exposed on the
vtenc_prores element since h264 does not support transparency.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-docs/-/issues/94

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1601>

2 years agodocs: Update symbol index with old macOS plugin symbols
Nirbheek Chauhan [Fri, 28 Jan 2022 17:07:38 +0000 (22:37 +0530)]
docs: Update symbol index with old macOS plugin symbols

These symbols from macOS plugins osxaudio, osxvideo, and applemedia
have been present for a very long time but were never documented.

This allows us to document these, and also add Since: markers for new
features (symbols) there were added in 1.20

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1601>

2 years agosoup: Don't store a strong reference to the logging object
Sebastian Dröge [Sat, 29 Jan 2022 10:56:22 +0000 (12:56 +0200)]
soup: Don't store a strong reference to the logging object

Otherwise this causes a reference cycle between the session, the logger
and the logging object (i.e. the sink element or session wrapper).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1603>

2 years agosouphttpsrc: Always abort the session once its last user is gone
Sebastian Dröge [Sat, 29 Jan 2022 10:55:30 +0000 (12:55 +0200)]
souphttpsrc: Always abort the session once its last user is gone

And wait until there are no pending GSources on the main context anymore
afterwards.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1603>

2 years agosouphttpsrc: Post context message after setting up the context from the source's...
Sebastian Dröge [Sat, 29 Jan 2022 10:54:23 +0000 (12:54 +0200)]
souphttpsrc: Post context message after setting up the context from the source's thread

This simplifies the code and especially the locking a bit, and makes
sure we only export the session after it is fully set up.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1603>

2 years agov4l2codecs: h264: Improve ABI check
Nicolas Dufresne [Fri, 28 Jan 2022 19:39:35 +0000 (14:39 -0500)]
v4l2codecs: h264: Improve ABI check

This moves the ABI check to the registration, so we don't expose
decoders with the wrong ABI or that are just broken somehow. It
also makes few enhancement:

- Handle missing, but required controls
- Prints the controls macro name instead of id

This should fix RK3399 support with a currently release minor
regression in the Hantro driver that cause errors.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1599>

2 years agowebrtc: Expose RTCError enum
Philippe Normand [Fri, 28 Jan 2022 17:11:41 +0000 (17:11 +0000)]
webrtc: Expose RTCError enum

The error codes not complying with the spec are now notified with the
GST_WEBRTC_ERROR_INTERNAL_FAILURE code.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1485>

2 years agod3d11decoder: Fix typo in doc
Seungha Yang [Fri, 28 Jan 2022 19:46:24 +0000 (04:46 +0900)]
d3d11decoder: Fix typo in doc

s/elemenet/element/g

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1598>

2 years agoRelease 1.19.90
Tim-Philipp Müller [Fri, 28 Jan 2022 14:28:35 +0000 (14:28 +0000)]
Release 1.19.90

2 years agoUpdate ChangeLogs for 1.19.90
Tim-Philipp Müller [Fri, 28 Jan 2022 14:28:28 +0000 (14:28 +0000)]
Update ChangeLogs for 1.19.90

2 years agosouphttpsink: Protect against spurious wakeups during startup
Sebastian Dröge [Fri, 28 Jan 2022 13:47:44 +0000 (15:47 +0200)]
souphttpsink: Protect against spurious wakeups during startup

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1594>

2 years agosouphttpsrc: Don't use the source element after setup from the session thread
Sebastian Dröge [Fri, 28 Jan 2022 13:33:04 +0000 (15:33 +0200)]
souphttpsrc: Don't use the source element after setup from the session thread

The source element might be gone already if the session is shared with
other source elements.

As a consequence, do all logging via the session object instead of using
the source element.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1594>

2 years agosouphttpsrc: Don't abort all pending operations on the session if shutting down a...
Sebastian Dröge [Fri, 28 Jan 2022 13:31:55 +0000 (15:31 +0200)]
souphttpsrc: Don't abort all pending operations on the session if shutting down a source with a shared session

Only do it for a non-shared session. Other sources would otherwise get
their requests cancelled unexpectedly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1594>

2 years agosouphttpsrc: Don't set boolean to FALSE right after checking that it is FALSE
Sebastian Dröge [Fri, 28 Jan 2022 13:31:25 +0000 (15:31 +0200)]
souphttpsrc: Don't set boolean to FALSE right after checking that it is FALSE

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1594>

2 years agosouphttpsrc: soup_session_new_with_options() can't fail with NULL
Sebastian Dröge [Fri, 28 Jan 2022 13:30:56 +0000 (15:30 +0200)]
souphttpsrc: soup_session_new_with_options() can't fail with NULL

So don't check for it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1594>

2 years agotests: Mark adaptivedemux tests as sometimes timing out
Sebastian Dröge [Fri, 28 Jan 2022 10:18:18 +0000 (12:18 +0200)]
tests: Mark adaptivedemux tests as sometimes timing out

... in addition to all the other issues that were ignored for them
already.

At least the reverse playback test regularly times out, waiting for a
download to finish that has already finished successfully.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1593>

2 years agoautodetect: fix debug init category
Stéphane Cerveau [Thu, 27 Jan 2022 15:28:48 +0000 (16:28 +0100)]
autodetect: fix debug init category

Since the split of elements, the debug category
was default for autodetect.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1590>

2 years agosoup: move libsoup session into its own thread
Daniel Kolesa [Fri, 21 Jan 2022 15:09:30 +0000 (16:09 +0100)]
soup: move libsoup session into its own thread

Starting with libsoup3, there is no attempt to handle thread safety
inside the library, and it was never considered fully safe before
either. Therefore, move all session handling into its own thread.

The libsoup thread has its own context and main loop. When some
request is made or a response needs to be read, an idle source
is created to issue that; the gstreamer thread issuing that waits
for that to be complete. There is a per-src condition variable to
deal with that.

Since the thread/loop needs to be longer-lived than the soup
session itself, a wrapper object is provided to contain them. The
soup session only has a single reference, owned by the wrapper
object.

It is no longer possible to force an external session, since this
does not seem to be used anywhere within gstreamer and would be
tricky to implement; this is because one would not have to provide
just a session, but also the complete thread arrangement made in
the same way as the system currently does internally, in order to
be safe.

Messages are still built gstreamer-side. It is safe to do so until
the message is sent on the session. Headers are also processed on
the gstreamer side, which should likewise be safe.

All requests as well as reads on the libsoup thread are issued
asynchronously. That allows libsoup to schedule things with as
little blocking as possible, and means that concurrent access
to the session is possible, when sharing the session.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/947

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1555>

2 years agogst-plugins-good: Rename some definitions for TIZEN 15/270315/2
Sangchul Lee [Fri, 28 Jan 2022 03:57:22 +0000 (12:57 +0900)]
gst-plugins-good: Rename some definitions for TIZEN

__TIZEN__ is renamed and deprecated.

Change-Id: I2d1f09006403dd1a458241672bb1a2d809ac6753
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agogst-plugins-bad: Rename some definitions for TIZEN 12/270312/2
Sangchul Lee [Fri, 28 Jan 2022 02:28:01 +0000 (11:28 +0900)]
gst-plugins-bad: Rename some definitions for TIZEN

__TIZEN__ is renamed and deprecated.

Change-Id: Idcf8fd98c409eb52a61e4f8e7fbc16c92268b09a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agovapostproc: Make cb max values symmetrical to their min values.
Víctor Manuel Jáquez Leal [Thu, 27 Jan 2022 10:22:54 +0000 (11:22 +0100)]
vapostproc: Make cb max values symmetrical to their min values.

Intel drivers expose some colorbalance's maximum values much more
bigger than their minimum values, given their middle values (default
value). This means, in practice, that the real middle point between
the maximum and minimum values implies a major change in the color
balance, which is not expected by the GStreamer color balance logic.

This patch makes the given maximum value symmetrical to the minimum
value, given the middle one (default value).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1580>

2 years agoci: Add a Windows native cross-arm64 job with a new image
Nirbheek Chauhan [Thu, 27 Jan 2022 05:55:53 +0000 (11:25 +0530)]
ci: Add a Windows native cross-arm64 job with a new image

Needed an update to the windows Dockerfile to:

1. Install the 'UniversalBuildTools' workload for Cerbero
2. Install ARM and ARM64 workloads for cross-uwp-universal in Cerbero
3. Install VS 2019 since we need that for ARM64 NEON support in Opus

We can't test UWP in gstreamer.git because glib needs custom patches
for that. It will be tested in Cerbero.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1570>

2 years agoci: Remove windows-sdk-8.1 from docker image
Nirbheek Chauhan [Thu, 27 Jan 2022 09:21:45 +0000 (14:51 +0530)]
ci: Remove windows-sdk-8.1 from docker image

We don't need this, we use the Windows 10 SDK provided by Visual
Studio Build Tools.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1570>

2 years agosubprojects/pcre: Add the wrap so it's cached in the image
Nirbheek Chauhan [Thu, 27 Jan 2022 09:20:54 +0000 (14:50 +0530)]
subprojects/pcre: Add the wrap so it's cached in the image

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1570>

2 years agogst-devtools: Add a cairo option for the cairo dep
Nirbheek Chauhan [Thu, 27 Jan 2022 05:55:00 +0000 (11:25 +0530)]
gst-devtools: Add a cairo option for the cairo dep

So that it can be explicitly disabled to avoid pulling in pixman which
doesn't build on Windows ARM64 yet.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1570>

2 years agosubprojects/lame: Update to latest wrap
Nirbheek Chauhan [Thu, 27 Jan 2022 05:54:01 +0000 (11:24 +0530)]
subprojects/lame: Update to latest wrap

Fixes an issue with xmmintrin on non-x86 machines:

https://github.com/mesonbuild/wrapdb/pull/295

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1570>

2 years agosubprojects/libpng: Update to latest wrap file
Nirbheek Chauhan [Thu, 27 Jan 2022 05:57:36 +0000 (11:27 +0530)]
subprojects/libpng: Update to latest wrap file

It was getting pulled in automatically via cairo, but the version
there is too old for us. We need the latest to fix Windows ARM64 NEON
support:

> ERROR: No specified compiler can handle file subprojects\libpng-1.6.37\arm/filter_neon.S

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1570>

2 years agov4l2codecs: Fix debug assertion in register functions
Nicolas Dufresne [Thu, 27 Jan 2022 16:49:53 +0000 (11:49 -0500)]
v4l2codecs: Fix debug assertion in register functions

As now, we warn if the decoder have no support src pixel format, but that
warning is called before the type (hence the debug category) is initialized.
Fix this by moving the debug category init out of the type initialization,
into the register funcitons.

This will fix an assertion that occures in the register function and allow
relevant log to be seen by the users.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1588>

2 years agowebrtcbin: Chain up to parent constructed method
Jakub Adam [Thu, 27 Jan 2022 16:56:29 +0000 (17:56 +0100)]
webrtcbin: Chain up to parent constructed method

Failing to do so makes GstWebRTCBin invisible to the leaks tracer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1587>

2 years agoaggregator: don't forward reconfigure events
Mathieu Duponchelle [Wed, 22 Dec 2021 23:24:03 +0000 (00:24 +0100)]
aggregator: don't forward reconfigure events

Those will cause us to renegotiate at the next aggregate cycle,
and while at that point we may decide to reconfigure upstream
branches (in practice we don't as this is inherently racy,
and that's the reason why mixer subclasses perform conversion
internally), we certainly don't want to just forward the event
willy-nilly to all our sinkpads.

An actual issue this is fixing is when caps downstream of a
compositor are changed at every samples-selected signal emission,
for the purpose of interpolating the output geometry, and the
compositor has a non-zero latency, the reconfigure events were
forwarded to basesrc, which triggered an allocation query, which
in turn caused aggregator to have to drain (thus not being able
to queue <latency> frames), leading to disastrous effects
(choppy output as compositor couldn't consume frames fast enough,
the higher the latency the choppier the output)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1464>

2 years agortphdrext: Return non-floating references from `gst_rtp_header_extension_create_from_...
Sebastian Dröge [Thu, 27 Jan 2022 12:22:26 +0000 (14:22 +0200)]
rtphdrext: Return non-floating references from `gst_rtp_header_extension_create_from_uri()`

The header extension objects are never getting a parent object and using
floating references only complicates usage, especially via dynamic API
like signals.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1582>

2 years agortphdrext: Use `set_metadata()` instead of `set_static_metadata()`
Sebastian Dröge [Thu, 27 Jan 2022 12:26:26 +0000 (14:26 +0200)]
rtphdrext: Use `set_metadata()` instead of `set_static_metadata()`

The latter needs a static string.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1583>

2 years agogst-plugins-bad/good: Add missing __TIZEN__ define to meson.build 83/270283/1
Sangchul Lee [Thu, 27 Jan 2022 10:57:18 +0000 (19:57 +0900)]
gst-plugins-bad/good: Add missing __TIZEN__ define to meson.build

Change-Id: Ic1d07e62b53972641d8a2bafe37f6e83c67e5a44
Signed-off-by: Sangchul Lee <sangchul1011@gmail.com>
2 years agoVideoInfo, AudioInfo: fix usage with python bindings
Mathieu Duponchelle [Tue, 25 Jan 2022 23:02:49 +0000 (00:02 +0100)]
VideoInfo, AudioInfo: fix usage with python bindings

* Expose an actual constructor from caps

* Error out in overrides for code that was using the "manual
  allocation" pattern which only worked by chance. Direct
  the script writer to the new_from_caps constructor instead.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/-/issues/47

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1571>

2 years agodocs: Updates to contributing guide
Brad Hards [Thu, 27 Jan 2022 04:54:28 +0000 (10:24 +0530)]
docs: Updates to contributing guide

Mostly some modifications for handling security issues.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1370>

2 years agodocs: Explain how to open a merge request with screenshots
Nirbheek Chauhan [Fri, 19 Nov 2021 07:15:13 +0000 (12:45 +0530)]
docs: Explain how to open a merge request with screenshots

The merge request workflow can be confusing to people unfamiliar with
it, so add screenshots.

Also add a new section on how to revise merge requests, since a lot of
people tend to open new merge requests to make any changes.

Eliminate the separate "How to Prepare a Merge Request for Submission"
section -- merge it with the main section.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1367>

2 years agogst-plugins-bad: update translations
Tim-Philipp Müller [Thu, 27 Jan 2022 01:40:17 +0000 (01:40 +0000)]
gst-plugins-bad: update translations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1579>

2 years agogst-plugins-ugly: update translations
Tim-Philipp Müller [Thu, 27 Jan 2022 01:39:28 +0000 (01:39 +0000)]
gst-plugins-ugly: update translations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1579>

2 years agogst-plugins-good: update translations
Tim-Philipp Müller [Thu, 27 Jan 2022 01:38:39 +0000 (01:38 +0000)]
gst-plugins-good: update translations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1579>