platform/kernel/linux-exynos.git
10 years agoMerge tag 'iio-for-3.13b' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23...
Greg Kroah-Hartman [Sun, 29 Sep 2013 20:12:23 +0000 (13:12 -0700)]
Merge tag 'iio-for-3.13b' of git://git./linux/kernel/git/jic23/iio into staging-next

Jonathan writes:

Second set of new functionality for IIO in the 3.13 cycle - with bug fixes for first set.

This is a small, mainly to get a couple of compile bug related fixes into
the tree ASAP.

New device support:
1) Add ad5446 dac support to the ad5641 driver.

New functionality and cleanups:
1) Optional power supply regulators for the st pressure sensors drivers using
   the new optional regulator interface.
2) Bit of tidying up of naming in the sysfs trigger.

Bug fixes from the previous series:
1) Missing select IIO_BUFFER for ti_am335x_adc
2) Drop a bonus bracket in iio-trig-bfin-timmer

10 years agoiio:trigger: fix sysfs name on list mutex
Denis CIOCCA [Mon, 23 Sep 2013 10:49:00 +0000 (11:49 +0100)]
iio:trigger: fix sysfs name on list mutex

Signed-off-by: Denis Ciocca <denis.ciocca@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
10 years agostaging:iio:iio-trig-bfin-timer: Fix compile error
Lars-Peter Clausen [Fri, 27 Sep 2013 13:50:00 +0000 (14:50 +0100)]
staging:iio:iio-trig-bfin-timer: Fix compile error

This patch fixes the following compile errors for the iio-trig-bfin-timer
driver:
drivers/staging/iio/trigger/iio-trig-bfin-timer.c: In function ‘iio_bfin_tmr_frequency_store’:
drivers/staging/iio/trigger/iio-trig-bfin-timer.c:121: error: invalid storage class for function ‘iio_bfin_tmr_frequency_show’
drivers/staging/iio/trigger/iio-trig-bfin-timer.c:118: warning: ISO C90 forbids mixed declarations and code
drivers/staging/iio/trigger/iio-trig-bfin-timer.c:135: error: initializer element is not constant
...

The issue was introduced in commit e5e26dd5 ("staging: iio: replace
strict_strto*() with kstrto*()") by leaving an excess opening bracket.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
10 years agoiio:ti_am335x_adc ensure that IIO_KFIFO_BUF is not selected witout IIO_BUFFER
Jonathan Cameron [Wed, 25 Sep 2013 20:37:00 +0000 (21:37 +0100)]
iio:ti_am335x_adc ensure that IIO_KFIFO_BUF is not selected witout IIO_BUFFER

This avoids build problems such iio_push_to_buffers* not being defined.

Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
10 years agostaging: comedi: 8253.h: tidy up the i8253_cascade_ns_to_timer*() users
H Hartley Sweeten [Thu, 26 Sep 2013 18:40:15 +0000 (11:40 -0700)]
staging: comedi: 8253.h: tidy up the i8253_cascade_ns_to_timer*() users

Introduce a couple defines for the common 8254 oscillator base values
used in the comedi drivers and remove the custom defines and open
coded values.

Change the i8253_cascade_ns_to_timer_2div() calls in the drivers to
the more generic i8253_cascade_ns_to_timer(). They are identical due
to the #define in the 8253.h header.

Remove the extra mask by TRIG_ROUND_MASK of the 'round_mode' parameter
to i8253_cascade_ns_to_timer(). That function already handles the mask.

Tidy up all the calls to i8253_cascade_ns_to_timer().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: rxtx.c remove dead code rts_cts void
Malcolm Priestley [Thu, 26 Sep 2013 18:00:41 +0000 (19:00 +0100)]
staging: vt6656: rxtx.c remove dead code rts_cts void

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: rxtx.c Move rts_cts pointer assignment to s_vGenerateTxParameter
Malcolm Priestley [Thu, 26 Sep 2013 17:57:34 +0000 (18:57 +0100)]
staging: vt6656: rxtx.c Move rts_cts pointer assignment to s_vGenerateTxParameter

Move rts/cts pointers to relevant vnt_tx_data_head position.

Remove old rts_cts pointers in calling functions.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: rxtx.c s_vGenerateTxParameter Create vnt_mic_hdr structure
Malcolm Priestley [Thu, 26 Sep 2013 17:52:10 +0000 (18:52 +0100)]
staging: vt6656: rxtx.c s_vGenerateTxParameter Create vnt_mic_hdr structure

Create double pointer to pass back vnt_mic_hdr address position
of relevant structure if need_mic is more than 0. Otherwise it
is NULL.

This replaces the pMICHDR void pointer with struct vnt_mic_hdr
and assignments in the calling functions.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: rxtx.c create structure to join vnt_tx_data_head with vnt_tx_head.
Malcolm Priestley [Thu, 26 Sep 2013 17:49:44 +0000 (18:49 +0100)]
staging: vt6656: rxtx.c create structure to join vnt_tx_data_head with vnt_tx_head.

Create struct vnt_tx_mic_hdr for with union vnt_tx_data_head
for mic mode.

Create union vnt_tx for mic and non mic mode.

Attach vnt_rrv_time_* to relevant tx_head.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: rxtx.c Create union of struct vnt_rrv_time* stuctures
Malcolm Priestley [Thu, 26 Sep 2013 17:47:25 +0000 (18:47 +0100)]
staging: vt6656: rxtx.c Create union of struct vnt_rrv_time* stuctures

Attach union vnt_tx_head to structure vnt_tx_buffer replacing pointer
pvRrvTime.

In s_vGenerateTxParameter the relevant struct vnt_rrv_time_*
structure is attached to the vnt_tx_head.

The NULL check is now pFifoHead.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: rename interrupt (async cmd) support functions
H Hartley Sweeten [Thu, 26 Sep 2013 17:26:42 +0000 (10:26 -0700)]
staging: comedi: pcl726: rename interrupt (async cmd) support functions

Rename these functions so they have namespace associated with the driver.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: dt2801: fix using uninitialized variable warnings
H Hartley Sweeten [Thu, 26 Sep 2013 17:29:20 +0000 (10:29 -0700)]
staging: comedi: dt2801: fix using uninitialized variable warnings

As pointed out by Fengguang Wu, the calls to dt2801_readdata() return the
data read thru a pointer (the address of a local variable) passed as a
parameter. If this local variable is not initialized it produces a warning
during the build of the form:

drivers/staging/comedi/drivers/dt2801.c: In function 'dt2801_ai_insn_read':
drivers/staging/comedi/drivers/dt2801.c:273:14: warning: 'hb' is used
      uninitialized in this function [-Wuninitialized]

Fix these warning by making sure the local variables are initialized.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: Kconfig: COMEDI_NI_ATMIO should select COMEDI_FC
H Hartley Sweeten [Thu, 26 Sep 2013 17:28:28 +0000 (10:28 -0700)]
staging: comedi: Kconfig: COMEDI_NI_ATMIO should select COMEDI_FC

As pointed out by the kbuild test robot, the ni_atmio driver includes
ni_mio_common.c which uses the helper functions in the comedi_fc module.

Select the COMEDI_FC module when COMEDI_NI_ATMIO is enabled to fix the
following build error:

ERROR: "cfc_write_array_to_buffer" [drivers/staging/comedi/drivers/ni_atmio.ko] undefined!

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl711: put acquired data in buffer for AI command
Ian Abbott [Thu, 26 Sep 2013 09:16:39 +0000 (10:16 +0100)]
staging: comedi: pcl711: put acquired data in buffer for AI command

The asynchronous command support for the AI subdevice is still missing
one crucial element, it doesn't actually put the acquired data in the
buffer so it can be read()!  Call `comedi_buf_put()` from the interrupt
handler to perform this function.  A return value of 0 from
`comedi_buf_put()` means there was no room in the buffer so set the
`COMEDI_CB_OVERFLOW` and `COMEDI_CB_ERROR` event flags in that case.
Otherwise, set the `COMEDI_CB_BLOCK` and `COMEDI_CB_EOS` event flags to
mark the end of a "scan" (the scan length is currently fixed at one
sample in this driver).

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl711: handle cmd->stop_src and stop_arg
Ian Abbott [Thu, 26 Sep 2013 09:16:38 +0000 (10:16 +0100)]
staging: comedi: pcl711: handle cmd->stop_src and stop_arg

The interrupt handler used to support asynchronous commands on the AI
subdevice currently marks the command as finished (setting the "end of
acquisition" event flag and returning to software-triggered acquisition
mode) once it has decremented `devpriv->ntrig` to 0.  However, nothing
sets `devpriv->ntrig`, as noted in the "FIXME" comment.

If the `stop_src` setting of the asynchronous command is `TRIG_COUNT`,
then the `stop_arg` setting indicates the number of scans to be
performed in the overall acquisition.  (Otherwise, `stop_src` will be
`TRIG_NONE`, meaning the acquisition should run indefinitely until
cancelled.)  When starting the acquisition in `pcl711_ai_cmd()`, set
`devpriv->ntrig` to the number of scans to be performed (`stop_arg`) if
`stop_src` is `TRIG_COUNT`.  In the interrupt handler, don't decrement
`devpriv->ntrig` or handle end of acquision unless `stop_src` is
`TRIG_COUNT`.

Also check for an empty acquisition in `pcl711_ai_cmd()`, i.e. one where
`stop_src` is `TRIG_COUNT` and `stop_arg` is zero and just mark end of
acquisition without actually setting up the interrupts in this case.

Also change the type of the `ntrig` member of the private data structure
to `unsigned int` as it should be (same type as `stop_arg`).

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl711: add AI cancel handler
Ian Abbott [Thu, 26 Sep 2013 09:16:37 +0000 (10:16 +0100)]
staging: comedi: pcl711: add AI cancel handler

Comedi subdevices that support asynchronous commands should have a
'cancel' handler to stop an in-progress command.  Add such a handler to
the pcl711 driver module.  I think merely setting the acquisition mode
to "software-triggered" would be sufficient, but also clear the
interrupt status for good luck.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: rename 'boardtypes'
H Hartley Sweeten [Wed, 25 Sep 2013 22:42:36 +0000 (15:42 -0700)]
staging: comedi: pcl726: rename 'boardtypes'

'boardtypes' is pretty generic, rename this static const variable.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: update MODULE_DESCRIPTION
H Hartley Sweeten [Wed, 25 Sep 2013 22:42:16 +0000 (15:42 -0700)]
staging: comedi: pcl726: update MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something useful instead of the
generic "Comedi low-level driver".

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: tidy up multi-line comments
H Hartley Sweeten [Wed, 25 Sep 2013 22:41:58 +0000 (15:41 -0700)]
staging: comedi: pcl726: tidy up multi-line comments

Tidy up the multi-line comments to follow the CodingStyle.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: add support for the external interrupt signal
H Hartley Sweeten [Wed, 25 Sep 2013 22:41:40 +0000 (15:41 -0700)]
staging: comedi: pcl726: add support for the external interrupt signal

The ACL-6126 board supports an external interrupt signal on pin 17 of
its I/O connector (CN3). Add a new subdevice to this driver to support
asynchronous commands with this input.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: final tidy up of boardinfo
H Hartley Sweeten [Wed, 25 Sep 2013 22:41:18 +0000 (15:41 -0700)]
staging: comedi: pcl726: final tidy up of boardinfo

For aesthetics, rearrange the boardinfo struct definition a bit to give
it a bit of logical order.

Also, rename the 'n_aochan' member to it has better visual association
with the other analog output members.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: remove the *_SIZE defines
H Hartley Sweeten [Wed, 25 Sep 2013 22:40:57 +0000 (15:40 -0700)]
staging: comedi: pcl726: remove the *_SIZE defines

The *_SIZE defines are only used to initialize the 'io_range' members in
the boardinfo. Remove the defines and just open code the values.

For aesthetics, change the type of the 'io_range' and rename it to better
match the 'len' parameter to comedi_request_region().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: remove unnecessary comments in boardinfo definition
H Hartley Sweeten [Wed, 25 Sep 2013 22:40:29 +0000 (15:40 -0700)]
staging: comedi: pcl726: remove unnecessary comments in boardinfo definition

The variable names provided enough information.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: rename boardinfo 'IRQbits'
H Hartley Sweeten [Wed, 25 Sep 2013 22:40:08 +0000 (15:40 -0700)]
staging: comedi: pcl726: rename boardinfo 'IRQbits'

Rename this CamelCase variable in the boardinfo.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: tidy up the comedi_lrange code
H Hartley Sweeten [Wed, 25 Sep 2013 22:39:48 +0000 (15:39 -0700)]
staging: comedi: pcl726: tidy up the comedi_lrange code

For aesthetics, declare the comedi_lrange tables with one entry per line.

Since the range data in the boardinfo is only for the analog outputs,
rename the variables to make this clearer.

Use ARRAY_SIZE to initialize the 'ao_num_ranges' member instead of open
coding the value.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: remove digital i/o register offsets from boardinfo
H Hartley Sweeten [Wed, 25 Sep 2013 22:38:55 +0000 (15:38 -0700)]
staging: comedi: pcl726: remove digital i/o register offsets from boardinfo

The PCL-727 board uses different register offsets for the digital input and
output ports. Instead of having all the register offsets in the boardinfo,
replace them with a simple bit-field flag, 'is_pcl727'. Use that flag in the
(*insn_bits) functions to determine what registers need to be used.

To save a bit of space, change the 'have_dio' flag in the boardinfo to a
bit-field.

For aesthetics, rename and tidy up the register map defines.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: tidy up pcl726_attach()
H Hartley Sweeten [Wed, 25 Sep 2013 22:37:43 +0000 (15:37 -0700)]
staging: comedi: pcl726: tidy up pcl726_attach()

For aesthetics, add some whitespace to the subdevice initialization.

Only allocate, and initialize, the digital input and output subdevices
if the boardinfo indicates that they exist on the board.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: fix the analog output range_table_list initialization
H Hartley Sweeten [Wed, 25 Sep 2013 22:37:18 +0000 (15:37 -0700)]
staging: comedi: pcl726: fix the analog output range_table_list initialization

The analog output channels use jumpers on the board to individually set
the range used. This driver uses the configuration options passed to the
(*attach) function to setup the analog output subdevice range_table_list
for each channel.

The configuration options should be 'it->options[2 + i]' for each channel 'i'
not '...[2 + 1]' for each channel. Fix the error and move the code so that
the range_table_list is setup before the subdevice is initialized.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: enable the interrupt support code
H Hartley Sweeten [Wed, 25 Sep 2013 22:36:57 +0000 (15:36 -0700)]
staging: comedi: pcl726: enable the interrupt support code

Tidy up and enable the interrupt support code for the external trigger
source interrupt on the ACL-6126 board.

The interrupt handler is currently just a stub function. Once the async
command support is added this function will be completed.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: remove all '= 0' boardinfo
H Hartley Sweeten [Wed, 25 Sep 2013 22:36:36 +0000 (15:36 -0700)]
staging: comedi: pcl726: remove all '= 0' boardinfo

Remove all the '= 0' entries in the boardinfo. They will default to 0.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: tidy up pcl726_ao_insn_read()
H Hartley Sweeten [Wed, 25 Sep 2013 22:36:13 +0000 (15:36 -0700)]
staging: comedi: pcl726: tidy up pcl726_ao_insn_read()

Tidy up this function to follow the normal form for analog output
read back functions.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: tidy up pcl726_ao_insn()
H Hartley Sweeten [Wed, 25 Sep 2013 22:35:50 +0000 (15:35 -0700)]
staging: comedi: pcl726: tidy up pcl726_ao_insn()

For aesthetics, rename the function to help with greps.

The offset binary value from the core should be saved for read back.
Move the saving of the value in the private data so it occurs before
the value is possibly munged for bipolar outputs.

Use the comedi_offset_munge() helper to munge the offset binary value
to two's complement for bipolar outputs.

According to the November 2011 users manual, the write order must be
MSB them LSB. Update the comment.

Modify the register map defines to handle the channel offset calculation.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: remove 'bipolar' from the private data
H Hartley Sweeten [Wed, 25 Sep 2013 22:35:26 +0000 (15:35 -0700)]
staging: comedi: pcl726: remove 'bipolar' from the private data

These flags are set in the private data during the attach to indicate
if the range for each channel is bipolar or unipolar. Use the helper
function conedi_chan_range_is_bipolar() to determine this by checking
the range_table_list directly.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: core: introduce comedi_chan_range_is_{bi,uni}polar()
H Hartley Sweeten [Wed, 25 Sep 2013 22:35:06 +0000 (15:35 -0700)]
staging: comedi: core: introduce comedi_chan_range_is_{bi,uni}polar()

Introduce two helper functions to check if a subdevice range_table_list
for a given channel/range is bipolar or unipolar.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: pcl726: convert boardinfo declaration to C99 format
H Hartley Sweeten [Wed, 25 Sep 2013 22:34:47 +0000 (15:34 -0700)]
staging: comedi: pcl726: convert boardinfo declaration to C99 format

Convert the boardinfo declaration to C99 format to make it less error
prone and easier to maintain.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: dgnc: Remove casting the return value which is a void pointer
Jingoo Han [Wed, 25 Sep 2013 23:35:49 +0000 (08:35 +0900)]
staging: dgnc: Remove casting the return value which is a void pointer

Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.

CC: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Fix typo in rtl8188eu/core
Masanari Iida [Thu, 26 Sep 2013 15:11:44 +0000 (00:11 +0900)]
staging: rtl8188eu: Fix typo in rtl8188eu/core

Correct spelling typo in rtl8188eu/core

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
# On branch rtl8188eu-typo2
# Changes to be committed:
# modified:   drivers/staging/rtl8188eu/core/rtw_ap.c
# modified:   drivers/staging/rtl8188eu/core/rtw_br_ext.c
# modified:   drivers/staging/rtl8188eu/core/rtw_cmd.c
# modified:   drivers/staging/rtl8188eu/core/rtw_efuse.c
# modified:   drivers/staging/rtl8188eu/core/rtw_ieee80211.c
# modified:   drivers/staging/rtl8188eu/core/rtw_mlme.c
# modified:   drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
# modified:   drivers/staging/rtl8188eu/core/rtw_security.c
#
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Fix typo in rtl8188eu/include
Masanari Iida [Thu, 26 Sep 2013 15:11:43 +0000 (00:11 +0900)]
staging: rtl8188eu: Fix typo in rtl8188eu/include

Correct spelling typo in rtl8188eu/include

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Fix typo in rtl8188eu/os_dep
Masanari Iida [Thu, 26 Sep 2013 15:11:46 +0000 (00:11 +0900)]
staging: rtl8188eu: Fix typo in rtl8188eu/os_dep

Correct spelling typo in rtl8188eu/os_dep

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Fix typo in rtl8188eu/hal
Masanari Iida [Thu, 26 Sep 2013 15:11:45 +0000 (00:11 +0900)]
staging: rtl8188eu: Fix typo in rtl8188eu/hal

Correct spelling typo in rtl8188eu/hal

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: imx-drm: imx-ldb: Staticize of_get_data_mapping()
Fabio Estevam [Mon, 2 Sep 2013 01:11:55 +0000 (22:11 -0300)]
staging: imx-drm: imx-ldb: Staticize of_get_data_mapping()

Staticize of_get_data_mapping() in order to fix the following sparse warning:

drivers/staging/imx-drm/imx-ldb.c:424:11: warning: symbol 'of_get_data_mapping' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: usbip: Fix man-pages for usbip userspace utilities
Tobias Polzer [Mon, 9 Sep 2013 14:13:15 +0000 (16:13 +0200)]
staging: usbip: Fix man-pages for usbip userspace utilities

The usbip userspace utilities contained some half-documented (only in
--help, not in man) options. They were added to the man-pages of usbip
and usbipd.
Also a typo in the usbip headline was fixed.

Signed-off-by: Tobias Polzer <tobias.polzer@fau.de>
Signed-off-by: Dominik Paulus <dominik.paulus@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rt8192u: remove #ifdef RTL8192U in r8192U.h
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:36 +0000 (23:42 +0300)]
staging: rt8192u: remove #ifdef RTL8192U in r8192U.h

This patch removes #ifdef RTL8192U header guard and the code that falls
outside it, since RTL8192U is defined.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove code inside #ifdef RTL8190P in r8190_rtl8256.h
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:35 +0000 (23:42 +0300)]
staging: rtl8192u: remove code inside #ifdef RTL8190P in r8190_rtl8256.h

This patch removes the unused code inside #ifdef RTL8190P header guard,
since RTL8190P is not defined.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove #ifndef RTL8192U and the code inside it
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:34 +0000 (23:42 +0300)]
staging: rtl8192u: remove #ifndef RTL8192U and the code inside it

This patch removes the unused code inside #ifndef RTL8192U header guard
and the guard itself, since RTL8192U is defined.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove #ifndef RTL8190P guard from r8192U_dm.c
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:33 +0000 (23:42 +0300)]
staging: rtl8192u: remove #ifndef RTL8190P guard from r8192U_dm.c

This patch removes #ifndef RTL8190P header guard since RTL8190P is not
defined anywhere in rtl8192u code.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove code inside #ifdef RTL8190P in r8192U_dm.c
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:32 +0000 (23:42 +0300)]
staging: rtl8192u: remove code inside #ifdef RTL8190P in r8192U_dm.c

This patch removes the unused code that resides inside #ifdef RTL8190P
header guard since RTL8190P is not defined.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove code inside #ifdef RTL8190P in r819xU_firmware.c
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:31 +0000 (23:42 +0300)]
staging: rtl8192u: remove code inside #ifdef RTL8190P in r819xU_firmware.c

This patch removes the unused code that resides inside #ifdef RTL8190P since
RTL8190P is not defined.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove code inside #ifdef RTL8190P/RTL8192E in r819xU_phy.c
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:30 +0000 (23:42 +0300)]
staging: rtl8192u: remove code inside #ifdef RTL8190P/RTL8192E in r819xU_phy.c

This patch removes the unused code inside #ifdef RTL8190P and #ifdef RTL8192E
guards since RTL8190P and RTL8192E are not defined.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove unused dm_gpio_change_rf_callback()
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:29 +0000 (23:42 +0300)]
staging: rtl8192u: remove unused dm_gpio_change_rf_callback()

This patch removes dm_gpio_change_rf_callback() because it is not called
anywhere and it resides inside an #ifdef RTL8192E guard while RTL8192E
is not defined.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove #ifdef RTL8192U guard in r8192U_dm.c
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:28 +0000 (23:42 +0300)]
staging: rtl8192u: remove #ifdef RTL8192U guard in r8192U_dm.c

This patch removes #ifdef RTL8192U header guards from r8192U_dm.c, since
RTL8192U is defined in the included r8192U.h header.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove dm_check_rfctrl_gpio()
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:27 +0000 (23:42 +0300)]
staging: rtl8192u: remove dm_check_rfctrl_gpio()

This patch removes dm_check_rfctrl_gpio() because it does nothing when
RTL8192U is defined.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: check dev_alloc_skb() return value in fw_download_code()
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:26 +0000 (23:42 +0300)]
staging: rtl8192u: check dev_alloc_skb() return value in fw_download_code()

This patch adds a check whether skb allocation, in fw_download_code(), was
successful.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove unused code in fw_download_code()
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:25 +0000 (23:42 +0300)]
staging: rtl8192u: remove unused code in fw_download_code()

This patch removes the code that resides outside #ifdef RTL8192U,
since RTL8192U is defined in r8192U.h and removes, also, the header
guard itself.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove cmpk_message_handle_tx()
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:24 +0000 (23:42 +0300)]
staging: rtl8192u: remove cmpk_message_handle_tx()

The function cmpk_message_handle_tx() is called only in r8192U_dm.c in two
places. The first call resides outside an #ifdef RTL8192U guard, and since
RTL8192U is defined this call can be removed. At the other site this function
is called, there is no check on its return value. Since cmpk_message_handle_tx()
does not do anything else other than returning true, it can be safely removed.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192u: remove unused code from cmpk_message_handle_tx()
Xenia Ragiadakou [Sat, 21 Sep 2013 20:42:23 +0000 (23:42 +0300)]
staging: rtl8192u: remove unused code from cmpk_message_handle_tx()

The file r819xU_cmdpkt.c includes header r8192U.h which defines RTL8192U.
This patch removes from cmpk_message_handle_tx() the part of the code that
is never used because it resides outside the header guard #ifdef RTL8192U.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: dwc2: core: coding style - indentation should use tabs
Luis Ortega Perez de Villar [Wed, 25 Sep 2013 11:10:50 +0000 (13:10 +0200)]
Staging: dwc2: core: coding style - indentation should use tabs

Fixed coding style issue where lines are indented with spaces
instead of tabs.

Signed-off-by: Luis Ortega Perez de Villar <luiorpe1@upv.es>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: dwc2: add TODO file
Paul Zimmerman [Tue, 24 Sep 2013 00:15:40 +0000 (17:15 -0700)]
staging: dwc2: add TODO file

Add TODO file for DWC2 driver

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: dwc2: add microframe scheduler from downstream Pi kernel
Dom Cobley [Mon, 23 Sep 2013 21:23:34 +0000 (14:23 -0700)]
staging: dwc2: add microframe scheduler from downstream Pi kernel

The transfer scheduler in the dwc2 driver is pretty basic, not to
mention buggy. It works fairly well with just a couple of devices
plugged in, but if you add, say, multiple devices with periodic
endpoints, the scheduler breaks down and can't even enumerate all
the devices.

To improve this, import the "microframe scheduler" patch from the
driver in the downstream Raspberry Pi kernel, which is based on
the Synopsys vendor driver. The original patch came from Denx
(http://git.denx.de/?p=linux-denx.git) and was commited to the
raspberrypi.org git tree by "popcornmix" (Dom Cobley).

I have added a driver parameter for this, enabled by default, in
case anyone has problems with it and needs to disable it. I don't
think we should add a DT binding for that, though, since I plan
to remove the option once any bugs are fixed.

[raspberrypi.org patch from Dom Cobley]
Signed-off-by: Dom Cobley <popcornmix@gmail.com>
[adapted to dwc2 driver by Paul Zimmerman]
Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: dwc2: validate urb->actual_length for OUT endpoints
Paul Zimmerman [Mon, 23 Sep 2013 21:23:33 +0000 (14:23 -0700)]
staging: dwc2: validate urb->actual_length for OUT endpoints

In dwc2_assign_and_init_hc(), validate urb->actual_length for OUT
endpoints before using the value. This fix is from the Synopsys
vendor driver.

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: remove needless check before usb_free_urb()
Wei Yongjun [Mon, 23 Sep 2013 13:55:45 +0000 (21:55 +0800)]
staging: r8188eu: remove needless check before usb_free_urb()

usb_free_urb(NULL) is safe and this check is not required.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: crystalhd: Fix assignment of 0/1 to bool variables
Peter Senna Tschudin [Sun, 22 Sep 2013 18:44:13 +0000 (20:44 +0200)]
Staging: crystalhd: Fix assignment of 0/1 to bool variables

Convert 0 to false and 1 to true when assigning values to bool
variables. Inspired by commit 3db1cd5c05f35fb43eb134df6f321de4e63141f2.

The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):

@@
bool b;
@@
(
-b = 0
+b = false
|
-b = 1
+b = true
)

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging / quickstart: remove reduplicate if(acpi_disabled) check
Hanjun Guo [Sun, 22 Sep 2013 11:05:47 +0000 (19:05 +0800)]
Staging / quickstart: remove reduplicate if(acpi_disabled) check

In acpi_bus_register_driver(), there is an if (acpi_disabled) check,
so the if(acpi_disabled) before it is reduplicate, remove it.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192e: Remove redundant pci_set_drvdata
Sachin Kamat [Fri, 20 Sep 2013 10:11:36 +0000 (15:41 +0530)]
staging: rtl8192e: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: sm7xxfb: Remove redundant pci_set_drvdata
Sachin Kamat [Fri, 20 Sep 2013 10:11:37 +0000 (15:41 +0530)]
staging: sm7xxfb: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: xgifb: Remove redundant pci_set_drvdata
Sachin Kamat [Fri, 20 Sep 2013 10:11:39 +0000 (15:41 +0530)]
staging: xgifb: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6655: Remove redundant pci_set_drvdata
Sachin Kamat [Fri, 20 Sep 2013 10:11:38 +0000 (15:41 +0530)]
staging: vt6655: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8187se: Remove redundant pci_set_drvdata
Sachin Kamat [Fri, 20 Sep 2013 10:11:35 +0000 (15:41 +0530)]
staging: rtl8187se: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: winbond: reg: white space deleted
Iker Pedrosa [Mon, 16 Sep 2013 13:43:27 +0000 (15:43 +0200)]
Staging: winbond: reg: white space deleted

White space deleted before semicolons.

Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: winbond: reg: erased trailing whitespace
Iker Pedrosa [Mon, 16 Sep 2013 13:43:26 +0000 (15:43 +0200)]
Staging: winbond: reg: erased trailing whitespace

Erased all the errors given by checkpatch stating trailing whitespace.

Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: winbond: phy_calibration: second of the patches that fixes lines over 80...
Iker Pedrosa [Mon, 16 Sep 2013 13:43:25 +0000 (15:43 +0200)]
Staging: winbond: phy_calibration: second of the patches that fixes lines over 80 characters

Second of the patches that fixes the lines over 80 characters in phy_calibration.c

Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: winbond: phy_calibration: first of the patches that fixes lines over 80...
Iker Pedrosa [Mon, 16 Sep 2013 13:43:24 +0000 (15:43 +0200)]
Staging: winbond: phy_calibration: first of the patches that fixes lines over 80 characters

First of the patches that fixes the lines over 80 characters in phy_calibration.c

Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: winbond: mto: deleted extern functions
Iker Pedrosa [Mon, 16 Sep 2013 13:43:23 +0000 (15:43 +0200)]
Staging: winbond: mto: deleted extern functions

Deleted declaration of external functions that weren't used on this driver.

Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: winbond: mto: avoided use of extern functions
Iker Pedrosa [Mon, 16 Sep 2013 13:43:22 +0000 (15:43 +0200)]
Staging: winbond: mto: avoided use of extern functions

Prototype of two functions added to the header to avoid the use of extern.

Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: winbond: mto: removed function declaration
Iker Pedrosa [Mon, 16 Sep 2013 13:43:21 +0000 (15:43 +0200)]
Staging: winbond: mto: removed function declaration

The following function declarations have been removed because they aren't implemented.

Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: usbip: Fix IPv6 support in usbipd
Dominik Paulus [Fri, 13 Sep 2013 09:55:51 +0000 (11:55 +0200)]
staging: usbip: Fix IPv6 support in usbipd

getaddrinfo() leaves the order of the returned addrinfo structs
unspecified. On systems with bindv6only disabled (this is the default),
PF_INET6 sockets bind to IPv4, too. Thus, IPv6 support in usbipd was
broken when getaddrinfo returned first IPv4 and then IPv6 addrinfos, as
the IPv6 bind failed with EADDRINUSE.

This patch uses seperate sockets for IPv4 and IPv6 and sets IPV6_V6ONLY
on all IPv6 sockets. Two command line arguments, -4 and -6 were added to
manually select the socket family.

Signed-off-by: Tobias Polzer <tobias.polzer@fau.de>
Signed-off-by: Dominik Paulus <dominik.paulus@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: usbip: Fix build on Debian ppc
Tobias Polzer [Thu, 19 Sep 2013 08:39:38 +0000 (10:39 +0200)]
staging: usbip: Fix build on Debian ppc

One missing include was added.

Signed-off-by: Dominik Paulus <dominik.paulus@fau.de>
Signed-off-by: Tobias Polzer <tobias.polzer@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: usbip: Fix build with --with-tcp-wrappers
Dominik Paulus [Thu, 19 Sep 2013 12:47:41 +0000 (14:47 +0200)]
staging: usbip: Fix build with --with-tcp-wrappers

With --with-tcp-wrappers=no specified, the build system reset LIBS to
the empty string and thus fails to link against libsysfs.

Signed-off-by: Dominik Paulus <dominik.paulus@fau.de>
Signed-off-by: Tobias Polzer <tobias.polzer@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: usbip: stub_dev: Fixed checkpatch warnings
Elad Wexler [Thu, 5 Sep 2013 09:07:10 +0000 (12:07 +0300)]
Staging: usbip: stub_dev: Fixed checkpatch warnings

Coding style issues

Signed-off-by: Elad Wexler <eladwexler77@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: usbip: vhci_hcd: remove check for dma
navin patidar [Tue, 10 Sep 2013 05:06:46 +0000 (10:36 +0530)]
staging: usbip: vhci_hcd: remove check for dma

vhci_hcd is a virtual usb host controller, so no need to
check for dma.

Signed-off-by: navin patidar <navinp@cdac.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: usbip: vhci_hcd: correctly handle return value
navin patidar [Tue, 10 Sep 2013 05:13:39 +0000 (10:43 +0530)]
staging: usbip: vhci_hcd: correctly handle return value

ret == 0 means success, anything else is failure.

Signed-off-by: navin patidar <navinp@cdac.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: usbip: stub_main: correctly handle return value
navin patidar [Tue, 10 Sep 2013 05:14:07 +0000 (10:44 +0530)]
staging: usbip: stub_main: correctly handle return value

ret == 0 means success, anything else is failure.

Signed-off-by: navin patidar <navinp@cdac.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: olpc_dcon: remove unnecessary work pending test
Xie XiuQi [Thu, 19 Sep 2013 22:04:57 +0000 (15:04 -0700)]
staging: olpc_dcon: remove unnecessary work pending test

Remove unnecessary work pending test before calling schedule_work().
It has been tested in queue_work_on() already. No functional changed.

Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
Cc: Jens Frederich <jfrederich@gmail.com>
Cc: Daniel Drake <dsd@laptop.org>
Cc: Jon Nettleton <jon.nettleton@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8187se: Change variable type to bool
Peter Senna Tschudin [Sat, 21 Sep 2013 22:27:47 +0000 (00:27 +0200)]
staging: rtl8187se: Change variable type to bool

The variable ownbit_flag is only assigned the values true and false.
Change its type to bool.

The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):

@exists@
type T;
identifier b;
@@
- T
+ bool
  b = ...;
  ... when any
  b = \(true\|false\)

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: Change variable type to bool
Peter Senna Tschudin [Sat, 21 Sep 2013 22:27:48 +0000 (00:27 +0200)]
staging: vt6656: Change variable type to bool

The variables bMultiBand and bKeyTableFull are only assigned the
values true and false. Change its type to bool.

The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):

@exists@
type T;
identifier b;
@@
- T
+ bool
  b = ...;
  ... when any
  b = \(true\|false\)

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: winbond: Change variable type to bool
Peter Senna Tschudin [Sat, 21 Sep 2013 22:27:49 +0000 (00:27 +0200)]
staging: winbond: Change variable type to bool

The variable Trigger is only assigned the values true and false.
Change its type to bool.

The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):

@exists@
type T;
identifier b;
@@
- T
+ bool
  b = ...;
  ... when any
  b = \(true\|false\)

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: PHSModule.c: Matching the function definition with function declaration
Shalin Mehta [Tue, 17 Sep 2013 07:42:17 +0000 (00:42 -0700)]
Staging: bcm: PHSModule.c: Matching the function definition with function declaration

The function implementations of the PHSModule didn't match with the declaration. The functions are static
in the declaration but in the implemntation they are non-static

Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: rxtx.c s_vGenerateTxParameter replace pTxBufHead void pointer.
Malcolm Priestley [Tue, 17 Sep 2013 18:58:11 +0000 (19:58 +0100)]
staging: vt6656: rxtx.c s_vGenerateTxParameter replace pTxBufHead void pointer.

with struct vnt_tx_buffer and attach vnt_tx_fifo_head to pTX_Buffer structure.

The the calling pbyTxBufferAddr points to the same address as
vnt_tx_buffer->fifo_head and is still in use.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: desc.h remove typedef struct tagSTxBufHead to rxtx.h
Malcolm Priestley [Tue, 17 Sep 2013 18:54:35 +0000 (19:54 +0100)]
staging: vt6656: desc.h remove typedef struct tagSTxBufHead to rxtx.h

In code it is referred to as fifo to renamed to
typedef struct tagSTxBufHead -> struct vnt_tx_fifo_head

This is only needed by rxtc.c so moved to rxtx.h

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8192e: Fix typo in rtl8192e/dot11d.h
Masanari Iida [Mon, 16 Sep 2013 00:58:07 +0000 (09:58 +0900)]
staging: rtl8192e: Fix typo in rtl8192e/dot11d.h

Correct spelling typo in comment

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6655: vt6656: Fix typo in comments
Masanari Iida [Sun, 15 Sep 2013 11:31:37 +0000 (20:31 +0900)]
staging: vt6655: vt6656: Fix typo in comments

Correct spelling typo in staging/vt6655 and staging/vt6656

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: octeon: Fix typo in staging/octeon
Masanari Iida [Mon, 16 Sep 2013 02:44:08 +0000 (11:44 +0900)]
staging: octeon: Fix typo in staging/octeon

Correct spelling typo in staging/octeon

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agodrivers: staging: netlogic.h: removed WARNING: extern prototypes should be avoided...
Avinash kumar [Fri, 20 Sep 2013 06:32:54 +0000 (12:02 +0530)]
drivers: staging: netlogic.h: removed WARNING: extern prototypes should be avoided in .h files

removed checpatch warning : WARNING: extern prototypes should be avoided in .h files

Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: lustre: fix switch case statement indenting
Jon Bernard [Tue, 17 Sep 2013 19:44:58 +0000 (15:44 -0400)]
Staging: lustre: fix switch case statement indenting

This is a patch to lvfs_linux.c that fixes incorrect switch case statement
indenting found by checkpatch.pl.

Signed-off-by: Jon Bernard <jbernard@tuxion.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: lustre: remove assignment in if conditions
Jon Bernard [Tue, 17 Sep 2013 01:27:55 +0000 (21:27 -0400)]
Staging: lustre: remove assignment in if conditions

This is a patch to lvfs_linux.c that removes the use of variable assignment
within an if condition found by checkpatch.pl.

Signed-off-by: Jon Bernard <jbernard@tuxion.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: lustre: Fix typo in lustre/llite
Masanari Iida [Sun, 15 Sep 2013 05:38:18 +0000 (14:38 +0900)]
staging: lustre: Fix typo in lustre/llite

Correct spelling typo in lustre/llite
Correct double words "to to"

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: lustre: Fix typo in lustre/libcfs
Masanari Iida [Sun, 15 Sep 2013 06:11:07 +0000 (15:11 +0900)]
staging: lustre: Fix typo in lustre/libcfs

Correct spelling typos in comment and debug message,
within  luster/libcfs

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: dgap: tty.c: removes smatch warnings "redundant null check"
Lidza Louina [Mon, 23 Sep 2013 22:47:15 +0000 (18:47 -0400)]
staging: dgap: tty.c: removes smatch warnings "redundant null check"

This patch removes these smatch warnings:
redundant null check on dgap_TmpWriteBuf calling kfree()
redundant null check on brd->SerialDriver->ttys calling kfree()
redundant null check on brd->PrintDriver->ttys calling kfree()

The code checked to see if these variables are null
before freeing. This check isn't needed.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: dgap: tty.c: removes smatch warning "ignoring unreachable code"
Lidza Louina [Mon, 23 Sep 2013 22:47:14 +0000 (18:47 -0400)]
staging: dgap: tty.c: removes smatch warning "ignoring unreachable code"

This patch removes this smatch warning:
info: ignoring unreachable code.

There were instances where there was extra code after
the default action in switch statements. These default
actions ended with a break so the code wasn't being run
at anytime. This patch removes that extra code.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: dgap: driver.c: removes smatch warning "redundant null check"
Lidza Louina [Mon, 23 Sep 2013 22:47:12 +0000 (18:47 -0400)]
staging: dgap: driver.c: removes smatch warning "redundant null check"

This patch removes these smatch warnings from dgap_driver.c:

redundant null check on dgap_config_buf calling kfree()
redundant null check on brd->flipbuf calling kfree()
redundant null check on brd->flipflagbuf calling kfree()

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>