Brian Sullivan [Thu, 23 Mar 2017 18:30:05 +0000 (11:30 -0700)]
Merge pull request dotnet/coreclr#10397 from briansull/ibc-dump
Improve the dumping of BasicBlock weights and edge counts in the JIT
Commit migrated from https://github.com/dotnet/coreclr/commit/
abe18069c56aec42b5d8bfa83c322994f232c7ee
Bruce Forstall [Thu, 23 Mar 2017 17:57:49 +0000 (10:57 -0700)]
Merge pull request dotnet/coreclr#10402 from BruceForstall/FixMulCseBug
Fix CSE bug with GT_MUL and GTF_MUL_64RSLT
Commit migrated from https://github.com/dotnet/coreclr/commit/
b6c36706c174e0cbd280dca5ec0a829171aaafe0
Steve MacLean [Thu, 23 Mar 2017 17:38:50 +0000 (13:38 -0400)]
[Unix] runtest.sh crossgen should exit on failure (dotnet/coreclr#9907)
* Fix crossgen segfault
* Check crossgen in runtests.sh
* Do not use test -v
CI showed bash 4.2 feature test -v is not present on
OSX CI systems. Fall back to more standard bash test
Commit migrated from https://github.com/dotnet/coreclr/commit/
087a2eeb4c1384113fe68da1257b98fa99bd0484
Atsushi Kanamori [Thu, 23 Mar 2017 14:02:28 +0000 (07:02 -0700)]
Move IReflect.cs to shared partition. (dotnet/coreclr#10415)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8f485224cd9a5899e5f8e991f2db87cef5566b1b
Ilya [Thu, 23 Mar 2017 13:58:18 +0000 (16:58 +0300)]
I used PVS-Studio static analyzer to check this project. I would like to suggest a variant of the way to fix the error, detected with the help of V534 diagnostic. Description of the diagnostic: https://viva64.com/en/examples/v534/ (dotnet/coreclr#10414)
Incorrect variable 'i' from the outer loop is used in condition of the inner loop.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5bcd08108f522524741805d97989e5f227a6bd6b
Stephen Toub [Thu, 23 Mar 2017 13:41:12 +0000 (09:41 -0400)]
Merge pull request dotnet/coreclr#10412 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-25123-03, beta-25122-02, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f0bafd7833fc46378971398db518de4f6aa4f8cb
ragmani [Thu, 23 Mar 2017 09:09:09 +0000 (18:09 +0900)]
[x86/Linux] fix broken stack in DelayLoad_Helper when converting to AT&T syntax assembly. (dotnet/coreclr#10383)
* fix broken stack in DelayLoad_Helper when converting to AT&T syntax assembly.
"push \frameFlags" was changed to "pushw $0x0" by converting to AT&T syntax assembly.
Signed-off-by: ragmani <ragmani0216@gmail.com>
* [x86/Linux] modify pushing frameFlags stack from Intel syntax to AT&T syntax.
Signed-off-by: ragmani <ragmani0216@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
9784b493f3c85dd0967e8c2d936416e625f9cd0f
dotnet-bot [Thu, 23 Mar 2017 08:57:36 +0000 (08:57 +0000)]
Update CoreClr, CoreFx to beta-25123-03, beta-25122-02, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
400ae726d96e408016e4459a4a002e44d2165cc0
Rahul Kumar [Thu, 23 Mar 2017 08:13:54 +0000 (01:13 -0700)]
Merge pull request dotnet/coreclr#10064 from rahku/cgroup
memory limit in containers on linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
b511095cb37ce2e363ab55740960e7f610a9220d
rahul [Thu, 9 Mar 2017 02:55:24 +0000 (18:55 -0800)]
memory limit in containers on linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
b2b4ea22fcf71ef61ff84aa9669da2419c7541a5
Gaurav Khanna [Thu, 23 Mar 2017 06:25:57 +0000 (23:25 -0700)]
Various fixes for generating portable RID packages (dotnet/coreclr#10409)
Commit migrated from https://github.com/dotnet/coreclr/commit/
90f74b3963073c3671da1b4b95a6c205b7fa0411
Luis G [Thu, 23 Mar 2017 05:51:45 +0000 (02:51 -0300)]
Add handling of multiple CMake installations in probe-win (dotnet/coreclr#9980)
* Add handling of multiple CMake installations in probe-win
Check if multiple CMake versions are installed, and use by default the first path available
Fixes dotnet/coreclr#8221
* Fix typo in value accessor
* Restore previous null check in probe_win
* Remove redundant assignment
Commit migrated from https://github.com/dotnet/coreclr/commit/
6c73fd9440a68f064f4767347a4401155ee88899
Tanner Gooding [Thu, 23 Mar 2017 05:44:40 +0000 (22:44 -0700)]
Removing the special handling in classlibnative for atan2(±∞, ±∞) and pow(-1.0, ±∞). (dotnet/coreclr#10295)
* Removing the special handling in classlibnative for atan2(±∞, ±∞) and pow(-1.0, ±∞).
* Fixing up the logic for HAVE_COMPATIBLE_POW in the PAL layer.
Commit migrated from https://github.com/dotnet/coreclr/commit/
72c57d9d9fd2d4cd8c96f124d132d316c8ef6013
Jan Kotas [Thu, 23 Mar 2017 05:43:36 +0000 (22:43 -0700)]
Fix fallout from switching corelib to use resx (dotnet/coreclr#10407)
Fixes #https://github.com/dotnet/corefx/issues/17413
Commit migrated from https://github.com/dotnet/coreclr/commit/
ab0fbce6b629d081c1102d353abab0d8febd4487
Gaurav Khanna [Thu, 23 Mar 2017 04:35:24 +0000 (21:35 -0700)]
Unify command line arg for portable RID build (dotnet/coreclr#10408)
Commit migrated from https://github.com/dotnet/coreclr/commit/
14792ccacd1209380ba642431fe22f703b9f4060
Jon Hanna [Thu, 23 Mar 2017 04:25:58 +0000 (04:25 +0000)]
Named Multiply and Divide methods on TimeSpan (dotnet/coreclr#10366)
dotnet/corefxdotnet/coreclr#16476
Commit migrated from https://github.com/dotnet/coreclr/commit/
741ce0d615bdae442cb3ee184a5a36b30d1a152a
Swaroop Sridhar [Wed, 22 Mar 2017 22:22:46 +0000 (15:22 -0700)]
Add reflect.xml for a abstract* tests
For the abstract* tests in question:
The tests check for TypeLoad exception from a derived class that doesn't implement an abstract method in base class.
However, the Linker removed the abstract method from base, so there is no exception.
Therefore, add reflect.xml to override the linker's behavior and enable testing for TypeLoadException.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f36d5b00cadd97983a917f130fd7da875e6f2c83
Swaroop Sridhar [Wed, 22 Mar 2017 22:22:04 +0000 (15:22 -0700)]
Exclude some tests from Linker testing.
Exclude some tests while testing via ILLINK.
The reasons are mentioned in issues.targets.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ba4f04e851174f96b3049eb5277d111669c59ac
Swaroop Sridhar [Mon, 20 Mar 2017 18:20:12 +0000 (11:20 -0700)]
Linker Testing: Use a central target for copying reflection roots.
Copy the test.refect.xml file (if one exists) as part of the
AfterBuild job -- so that individual tests need not identify
the CopyReflectionRoots explicitly as a default target.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d532bfced676ac0e3051d2468ad01f793ab2fb84
Drew Scoggins [Thu, 23 Mar 2017 00:21:13 +0000 (17:21 -0700)]
Merge pull request dotnet/coreclr#9947 from DrewScoggins/xunitApi
Update CoreCLR to use xunit perf api
Commit migrated from https://github.com/dotnet/coreclr/commit/
69ad56379c0612489ec9467f7216501bd448b881
Sean Gillespie [Wed, 22 Mar 2017 23:39:14 +0000 (16:39 -0700)]
Opt-out of GC Stress for FEATURE_STANDALONE_GC (dotnet/coreclr#10391)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ecdf277ce50f29cccb494157cdbbfda86517feac
Bruce Forstall [Wed, 22 Mar 2017 23:36:53 +0000 (16:36 -0700)]
Jump stubs (dotnet/coreclr#10398)
Add document on CLR Jump Stubs
Commit migrated from https://github.com/dotnet/coreclr/commit/
56d550d4f8aec2dd40b72a182205d0a2463a1bc9
Bruce Forstall [Wed, 22 Mar 2017 23:21:04 +0000 (16:21 -0700)]
Fix CSE bug with GT_MUL and GTF_MUL_64RSLT
Unconditionally set op1 and op2 as GTF_DONT_CSE.
Previously, this was only done if the cast was not
a GT_NOP. It is possible for it already to come in
as GT_NOP, thus leading to the possibility to CSE
the operand, and leading to this assert firing:
```
assert(tree->gtIsValid64RsltMul());
```
Commit migrated from https://github.com/dotnet/coreclr/commit/
f401bfc49f96c12d90ec63bd4d4ef74d0cd998e6
Atsushi Kanamori [Wed, 22 Mar 2017 22:28:14 +0000 (15:28 -0700)]
Move Type.IsSerializable and Type.DefaultBinder to shared file. (dotnet/coreclr#10395)
This will pave the way for the mirrorbot to fix
https://github.com/dotnet/corert/issues/3061.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f10955c88f0f82bb3eae7966390979f49dcb47ae
Jonghyun Park [Wed, 22 Mar 2017 22:25:19 +0000 (07:25 +0900)]
[x86/Linux] 16-byte aligned TheUMEntryPrestub (dotnet/coreclr#10376)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9e79eb43b9ce606a10a8815e4858b377fa94c979
Brian Sullivan [Wed, 22 Mar 2017 18:23:19 +0000 (11:23 -0700)]
Improve the dumping of BasicBlock weights and edge counts in the JIT
Weights are now printed to fit into a 6 character field in one of three forms:
standard (ddd or ddd.dd), large (ddddd.) or very large (dddddk)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3dd1518ca4e71e290e914becfa9ebcfd9a27042a
Gaurav Khanna [Wed, 22 Mar 2017 20:54:41 +0000 (13:54 -0700)]
Switch tests to use OSX.10.12 RID (dotnet/coreclr#10394)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ecf644fd125a7fd4699c346d44dff4edb9b578e1
Gaurav Khanna [Wed, 22 Mar 2017 20:30:49 +0000 (13:30 -0700)]
Enable Portable Windows RID (dotnet/coreclr#10365)
* Enable Portable RID support for Windows and OSX.
Commit migrated from https://github.com/dotnet/coreclr/commit/
da1d8cd17a8ec2a78e8139d03be358d26acb503c
Drew Scoggins [Tue, 21 Mar 2017 21:01:03 +0000 (14:01 -0700)]
Add updated timeout
Commit migrated from https://github.com/dotnet/coreclr/commit/
5d362a30a372849f5cf7ac3a283dab40c146e19b
Drew Scoggins [Fri, 3 Mar 2017 22:51:37 +0000 (14:51 -0800)]
Update CoreCLR to use xunit perf api
This updates the CoreCLR performance runs to use the new xunit
performance api. This will unblock several people who were wanting to
move tests forward from netstandard1.4 which is were we have been locked
because of using the old desktop runner.
Commit migrated from https://github.com/dotnet/coreclr/commit/
02749bf56c408d62e2687a8f208b8b2e674df7eb
Atsushi Kanamori [Wed, 22 Mar 2017 17:51:46 +0000 (10:51 -0700)]
Reconcile the "easy" System\Reflection .cs files with their CoreRT versions. (dotnet/coreclr#10387)
Files to be moved the shared partition (after CoreRT side is in)
AmbiguousMatchException.cs
AssemblyAttributes.cs
AssemblyContentType.cs
AssemblyNameFlags.cs
Binder.cs
BindingFlags.cs
CallingConventions.cs
CustomAttributeFormatException.cs
DefaultMemberAttribute.cs
EventAttributes.cs
ExceptionHandlingClauseOptions.cs
FieldAttributes.cs
GenericParameterAttributes.cs
ICustomAttributeProvider.cs
ImageFileMachine.cs
InterfaceMapping.cs
IntrospectionExtensions.cs
InvalidFilterCriteriaException.cs
IReflectableType.cs
ManifestResourceInfo.cs
MemberFilter.cs
MemberTypes.cs
MethodAttributes.cs
MethodImplAttributes.cs
Missing.cs
ModuleResolveEventHandler.cs
ParameterAttributes.cs
ParameterModifier.cs
PortableExecutableKinds.cs
ProcessorArchitecture.cs
PropertyAttributes.cs
ReflectionContext.cs
ReflectionTypeLoadException.cs
ResourceAttributes.cs
ResourceLocation.cs
StrongNameKeyPair.cs
TargetException.cs
TargetInvocationException.cs
TargetParameterCountException.cs
TypeAttributes.cs
TypeFilter.cs
Commit migrated from https://github.com/dotnet/coreclr/commit/
2e970d8c53b4750c46ea00ea4c044af57e6b53df
Hyeongseok Oh [Wed, 22 Mar 2017 17:32:11 +0000 (02:32 +0900)]
Change default CI job for ARM and clean-up (dotnet/coreclr#10370)
- Change ARM CI job triggered by PR: ubuntu16.04 debug, ubuntu release, tizen debug/release
- Clean-up: remove emulator build/test
- Change ubuntu16.04 x64 default job name and trigger phrase: conflict triggerring with arm
Commit migrated from https://github.com/dotnet/coreclr/commit/
b94328c2428ce27aa4b813faf6c4a2ebd25822f1
Sean Gillespie [Wed, 22 Mar 2017 17:25:08 +0000 (10:25 -0700)]
Fix an issue where GCStress allocated objects using the Gen 0 alloc context (dotnet/coreclr#10322)
* Fix an issue where GCStress allocated objects using the Gen 0 alloc context
* Remove a GCStress MaybeTrigger on LOH allocations that attempted to use the gen 0 alloc context
Commit migrated from https://github.com/dotnet/coreclr/commit/
992d37064fa76ea7633734607381545e228806a5
Andy Ayers [Wed, 22 Mar 2017 17:23:56 +0000 (10:23 -0700)]
Merge pull request dotnet/coreclr#10371 from AndyAyersMS/FixDevirt
Fix several devirtualization issues
Commit migrated from https://github.com/dotnet/coreclr/commit/
c2ba64de40e5e28c56b9734521c5f6ead20bdea9
Gaurav Khanna [Wed, 22 Mar 2017 15:55:53 +0000 (08:55 -0700)]
Move OSX packages to use 10.12 as the RID (dotnet/coreclr#10354)
Commit migrated from https://github.com/dotnet/coreclr/commit/
66384321b7fb53a57163e3d895407800a37ca44e
Jan Kotas [Wed, 22 Mar 2017 15:03:09 +0000 (08:03 -0700)]
Merge pull request dotnet/coreclr#10374 from dotnet/mirror-merge-9057970
Mirror changes from dotnet/corert
Commit migrated from https://github.com/dotnet/coreclr/commit/
0976a5d3383e0aaed8895b09af9b12db4392df91
Atsushi Kanamori [Wed, 22 Mar 2017 11:37:12 +0000 (04:37 -0700)]
Move DefaultBinder.cs to the shared partition. (dotnet/coreclr#10355)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d10eede76ecf94ec63b51d94dadf1e1c5b339c71
Jeremy Kuhne [Tue, 21 Mar 2017 23:07:53 +0000 (16:07 -0700)]
FileStream redirection got changed. Add ThreadPoolBoundHandle redirect.
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=398142&_a=edit
[tfs-changeset: 1651640]
Commit migrated from https://github.com/dotnet/coreclr/commit/
37eeb4ca174c25396949dcbada8698a7827c0d7e
Stephen Toub [Wed, 22 Mar 2017 06:09:22 +0000 (02:09 -0400)]
Fix leak in Task.WaitAny(..., int) (dotnet/coreclr#10331)
WaitAny is effectively built on top of WhenAny, creating a continuation from the supplied tasks and then blocking on that continuation. When a timeout is provided, it blocks with that timeout. But if it doesn't complete within the timeout, it ends up leaking the continuations it created into the constituent tasks. The fix is simply to force the returned continuation to complete, such that its continuation logic does all of the appropriate cleanup.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d6e9a08a70dab11ddc845fb0ccf36aa436e9ebec
dotnet bot [Wed, 22 Mar 2017 05:04:42 +0000 (22:04 -0700)]
Update CoreClr, CoreFx to beta-25121-02, beta-25122-01, respectively (dotnet/coreclr#10310)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8390d5464b2f0f0ce360fc8b92869bfe8ad5d172
Alex Perovich [Wed, 22 Mar 2017 05:02:47 +0000 (00:02 -0500)]
Switch coreclr corelib to use resx (dotnet/coreclr#10372)
* Revert "Revert "Switch coreclr corelib to use resx (dotnet/coreclr#10268)""
* Add resources.target override
This fixes the GenerateResource task running on the arm emulator runs.
* Fix run.sh to have a working Tools-Override
Commit migrated from https://github.com/dotnet/coreclr/commit/
cdff8b0babe5d82737058ccdae8b14d8ae90160d
Sean Gillespie [Wed, 22 Mar 2017 05:00:12 +0000 (22:00 -0700)]
[Local GC] Forbid inclusion of gcscan.h from VM and DAC directories (dotnet/coreclr#10332)
* Forbid inclusion of gcscan.h from VM and DAC directories
* Address code review feedback - hoist IsGCHeapInitialized check to an assert, since the heap should definitely be initialized if we are validating objects that ostensibly came from it
Commit migrated from https://github.com/dotnet/coreclr/commit/
d5906ff3e0d0f864c1432f1f39d586ca3d79fbb6
Andy Ayers [Tue, 21 Mar 2017 20:17:28 +0000 (13:17 -0700)]
Fix several devirtualization issues
When doing interface devirtualization, if the object type is canonical,
ensure that the owner type is too. The jit may present a mixed set
when inlining a shared method into a non-shared method. Ideally the
jit would also be able to present exact object types in such cases but
currently it cannot guarantee this. Closes dotnet/coreclr#10311.
Adjust contracts to address some contract violations seen in desktop
testing. Make the helper non-static and fold in some of the info that
was passed from the caller to bring the desktop and CoreCLR implementations
closer.
Disallow interface devirt if the method is final but the class is not
exact or final, since derived classes can still override final methods
when implementing interfaces.
Don't try and devirtualize interface calls from com objects.
Add some related test cases.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d02fbd29384dc10217c35af0aea3ee862c07ac63
Jan Kotas [Wed, 22 Mar 2017 00:45:57 +0000 (17:45 -0700)]
Merge pull request dotnet/coreclr#10363 from jkotas/revert
Revert "Switch coreclr corelib to use resx (dotnet/coreclr#10268)"
Commit migrated from https://github.com/dotnet/coreclr/commit/
f4b58a22dfe6336e90d587ef3457af2070a09afc
Jan Kotas [Tue, 21 Mar 2017 23:24:52 +0000 (16:24 -0700)]
Revert "Switch coreclr corelib to use resx (dotnet/coreclr#10268)"
This reverts commit dotnet/coreclr@
12ef04c22b07f1e4ec5a63009298e4537a2c8e1a.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6d32a5152ef43752c72ff8dbbe9fbc635a55df13
Bruce Forstall [Tue, 21 Mar 2017 22:27:07 +0000 (15:27 -0700)]
Fix Linux/x86 call alignment calculation and insertion (dotnet/coreclr#10266)
* Fix Linux/x86 call alignment calculation and insertion
The existing system of calculating per-call alignment adjustments
did not consider the possibility of nested calls. On x86, some
arguments for a call might be pushed on the stack before a
nested call's arguments start being pushed. Thus, a call can't
consider only its own arguments when determining the stack level.
Instead, use the existing genStackLevel variable, updated
dynamically during code generation, to determine the baseline
stack alignment when a call first needs to push something on
the stack, or if it has no stack arguments, whether it needs to
align the stack before a call.
One wrinkle here is that the fgAddCodeRef() function for adding
throw blocks for array bounds checks, and other similar helpers,
need to know the stack level on entry, and this stack level is
computed during argument morphing. There is a tough phase ordering
problem here. So, we bail out and force an EBP frame if there are
any such throw helpers in the function. When using an EBP frame,
the helper block doesn't need to know the stack level -- it is
only needed for ESP frames, needed for unwinding. Note that this
bail out already existed if the same helper needed multiple different
stack levels on entry. We could do slightly better without too much
work by not bailing out for top-level calls with no stack arguments.
* Track max alignment added for nested calls during codegen
This information is needed by Linux/x86 for an assert about
maximum emitter stack depth.
* Make max stack align tracking available in release as well
The assert these are used in is a noway_assert.
* Formatting
Commit migrated from https://github.com/dotnet/coreclr/commit/
68012bf209f37ab5b5b11a02b203f2949d1ef8dc
Hanjoung Lee [Tue, 21 Mar 2017 22:00:56 +0000 (07:00 +0900)]
[x86/Linux] Invoke gcResetForBB() in genFuncletProlog (dotnet/coreclr#10186)
Commit migrated from https://github.com/dotnet/coreclr/commit/
75a87c0d929c6b87b0fdd03da1fb2489125c2eaa
Andy Ayers [Tue, 21 Mar 2017 20:08:01 +0000 (13:08 -0700)]
Merge pull request dotnet/coreclr#10343 from parjong/fix/self_override
Fix bogus assert in resolveVirtualMethodHelper and update related ilproj
Commit migrated from https://github.com/dotnet/coreclr/commit/
8b7e09d96bc33a0d0159cf15331b6b669ae6d33a
Bruce Forstall [Tue, 21 Mar 2017 20:01:52 +0000 (13:01 -0700)]
Add /silent option to crossgen (dotnet/coreclr#10350)
This sets the NGenOptions.fSilent flag, which prevents displaying
the final output message.
This is useful for JIT asm diff generation.
Commit migrated from https://github.com/dotnet/coreclr/commit/
40e64db3861284708676f3e46302e32a54e846ec
Alex Perovich [Tue, 21 Mar 2017 19:55:39 +0000 (14:55 -0500)]
Switch coreclr corelib to use resx (dotnet/coreclr#10268)
* Switch to resx
* Use roslyn rewriter to switch from GetResourceString to SR
* More GetResourceString changes
* Add missing resource
* Remove Environment.GetResourceString and replace final usages with SR
* Remove comment
* Fix spacing
* Replace final instances of Environment.GetResourceString
* Add another missing resource
* Add back Environment.GetResourceStringLocal because the runtime needs it
Commit migrated from https://github.com/dotnet/coreclr/commit/
12ef04c22b07f1e4ec5a63009298e4537a2c8e1a
Viktor Hofer [Tue, 21 Mar 2017 19:36:25 +0000 (20:36 +0100)]
System.IO.Path.IsPathRooted does not check if valid drive letter on Windows (dotnet/coreclr#10323)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e21d073e5e2b1d258cfef9111656d46884b242e7
Aditya Mandaleeka [Tue, 21 Mar 2017 19:01:53 +0000 (12:01 -0700)]
Merge pull request dotnet/coreclr#10254 from sdmaclea/PR-FIX-SCRIPT-ERROR
Fix script ERRORLEVEL typo
Commit migrated from https://github.com/dotnet/coreclr/commit/
fc992064a8746119a5f153279838d0cd791fced7
Koundinya Veluri [Tue, 21 Mar 2017 18:47:32 +0000 (11:47 -0700)]
Temporarily disable frequently failing Sleep PAL tests (dotnet/coreclr#10313)
See dotnet/coreclr#8321
Commit migrated from https://github.com/dotnet/coreclr/commit/
b635982b6c8dfcf5cb5d2116a155b2ae7b913b2d
Ian Hays [Tue, 21 Mar 2017 17:37:51 +0000 (10:37 -0700)]
Merge pull request dotnet/coreclr#10321 from WinCPP/issue-7060
Issue dotnet/coreclr#7060 - Make StreamReader.ReadBuffer non-virtual
Commit migrated from https://github.com/dotnet/coreclr/commit/
5654462feabdcbe93752774a707acea70a331c4a
Joseph Tremoulet [Tue, 21 Mar 2017 15:06:24 +0000 (11:06 -0400)]
Merge pull request dotnet/coreclr#10327 from mikedn/assertion-info
Refactor GenTree assertion information storage
Commit migrated from https://github.com/dotnet/coreclr/commit/
2308976b5db89e692e802ad28605ffe08826e2f6
Jonghyun Park [Tue, 21 Mar 2017 09:31:04 +0000 (18:31 +0900)]
[x86/Linux] Log UpdateRegDisplay calls (dotnet/coreclr#10335)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce38ca26fed02c9380946f3056d3159e6a539eac
Jonghyun Park [Tue, 21 Mar 2017 06:10:30 +0000 (15:10 +0900)]
Fix bogus assert in resolveVirtualMethodHelper and update related ilproj
Commit migrated from https://github.com/dotnet/coreclr/commit/
325332e383e698f0f1262a7f1b15586380e406dd
Jonghyun Park [Tue, 21 Mar 2017 04:36:27 +0000 (13:36 +0900)]
[x86/Linux] Use 4-byte align for double in struct (dotnet/coreclr#10340)
Commit migrated from https://github.com/dotnet/coreclr/commit/
be9896c8c27f1ef6ac6df46031bb69d56195712e
Jonghyun Park [Tue, 21 Mar 2017 04:26:19 +0000 (13:26 +0900)]
[x86/Linux] Correct update on ResumableFrame (dotnet/coreclr#10339)
Commit migrated from https://github.com/dotnet/coreclr/commit/
beeaf0926c7eccf0a5f86b95ad5b3ed186438dc1
Jan Kotas [Tue, 21 Mar 2017 04:13:04 +0000 (21:13 -0700)]
Merge pull request dotnet/coreclr#10341 from dotnet/mirror-merge-9056283
Mirror changes from dotnet/corert
Commit migrated from https://github.com/dotnet/coreclr/commit/
7996b0dbddb85cf4347c11d5026fd12347f5b6a8
Jan Kotas [Tue, 21 Mar 2017 02:30:56 +0000 (19:30 -0700)]
Delete moved file
Commit migrated from https://github.com/dotnet/coreclr/commit/
36c28a55dfce52331b1df0def2b67f0eb6044354
Atsushi Kanamori [Mon, 20 Mar 2017 21:01:10 +0000 (14:01 -0700)]
NS2.0 - Complete System.Security namespace.
- Add GetObjectData() implementation to System.SecurityExcepton
- Clean up a bit and move to shared partition.
Commit migrated from https://github.com/dotnet/coreclr/commit/
74e00c8c34a490a7dfd00a7a6fb2fb9ffc77f7db
Jonghyun Park [Tue, 21 Mar 2017 00:14:02 +0000 (09:14 +0900)]
'root' as a special case in UTIL_IsExecuteBitsSet (dotnet/coreclr#10246)
Commit migrated from https://github.com/dotnet/coreclr/commit/
cd9b5e782f6e9b1f392e028c819ed538546311eb
Tarek Mahmoud Sayed [Mon, 20 Mar 2017 23:19:48 +0000 (16:19 -0700)]
Fix MAC build (dotnet/coreclr#10328)
This is temporary fix to unblock the CI and coreclr building for MAC. this change should be reverted after having the proper fix for how we load ICU on MAC
Commit migrated from https://github.com/dotnet/coreclr/commit/
8fb9a5e2f77dbd88a6d6a564ff91f5f1d87e4b65
Jan Kotas [Mon, 20 Mar 2017 23:17:55 +0000 (16:17 -0700)]
Merge pull request dotnet/coreclr#10325 from dotnet/mirror-merge-9055987
Mirror changes from dotnet/corert
Commit migrated from https://github.com/dotnet/coreclr/commit/
900113351c78d676d0d853df24bdc51a1f1171df
Aditya Mandaleeka [Mon, 20 Mar 2017 23:01:13 +0000 (16:01 -0700)]
Merge pull request dotnet/coreclr#10330 from omajid/fix-markdown-atx-headers
Fix markdown headings
Commit migrated from https://github.com/dotnet/coreclr/commit/
027180d8ef4a8a0e50f4cba3ad985af38882f5ef
Omair Majid [Mon, 20 Mar 2017 22:12:33 +0000 (18:12 -0400)]
Fix markdown headings
GitHub recently changed how atx headings (beginning with `#`) are
rendered. A space is now required between `#` and the following text
for the heading to be recognized.
Update headings in the docs to match the expected format.
See https://github.github.com/gfm/#atx-headings
Commit migrated from https://github.com/dotnet/coreclr/commit/
765f28934dc3c47e0f3658a818bcc04d3c71c9ef
Jan Kotas [Mon, 20 Mar 2017 21:28:18 +0000 (14:28 -0700)]
Delete moved files
Commit migrated from https://github.com/dotnet/coreclr/commit/
378a18beb2bf841a2d069b700d413dd10fdd7eb6
Mike Danes [Sat, 11 Mar 2017 09:04:04 +0000 (11:04 +0200)]
Refactor GenTree assertion information storage
Stealing a bit from gtAssertionNum is ugly and error prone (e.g. bool HasAssertion() { return gtAssertionNum != 0; } is incorrect if the edge bit is set).
Commit migrated from https://github.com/dotnet/coreclr/commit/
d6b17aa51b29f756a7aa4061d171636d6da3d030
Fix another per code review
Commit migrated from https://github.com/dotnet/coreclr/commit/
c4adbaa01ccb897008c4ef73f29a90f89d2c0291
Joseph Tremoulet [Mon, 20 Mar 2017 21:13:14 +0000 (17:13 -0400)]
Merge pull request dotnet/coreclr#10319 from JosephTremoulet/NullField
Permit null object in `GenTreeUseEdgeIterator`
Commit migrated from https://github.com/dotnet/coreclr/commit/
281da0a152ff5dc65b4bebcc95d19ec8e4a4508e
Atsushi Kanamori [Mon, 20 Mar 2017 17:42:17 +0000 (10:42 -0700)]
Move Type.cs and Module.cs to Shared Partition.
Types.cs is split into the main file, Type.Helpers.cs and Type.Enum.cs.
All three will be shared.
- GenericTypeArguments - reconcile with CoreClr
(the code is identical provided that the underlying
Type provider implemented IsConstructedGenericType
correctly. But we can't assume that for third party types.)
- IsInterface and IsSerializable has some CoreClr
specific logic for RuntimeTypes - moving this out
to the unshared space for now.
- IsContextFulImpl()/IsMarshalByRefImpl() - corrected
implemention to match CoreClr.
- IsIntegerType - no CommonRuntimeTypes in CoreClr
so going back to typeof() checks - the runtime implemented
types override all this enum code anyway on both runtimes.
- GetRootElementType() - upgraded visibility to "internal"
as a concession to CoreClr.
- CoreCLR's IsVisible has a fast path - we'll keep that.
- Moved IsRuntimeImplemented() out of Internal.Reflection.Core.NonPortable
namespace so calls to it can be more easily shared.
- Module.MethodHandle was not implemented correctly for
non-runtime modules (it's supposed to return default(ModuleHandle)).
This makes it behave correctly and reconciles Module.cs
with the CoreCLR version.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b94d95ec4ed7a03ae9d9d6aaa31536211b46c8cb
Jan Kotas [Mon, 20 Mar 2017 21:03:14 +0000 (14:03 -0700)]
Merge pull request dotnet/coreclr#10317 from dotnet/mirror-merge-9055826
Mirror changes from dotnet/corert
Commit migrated from https://github.com/dotnet/coreclr/commit/
750085eaa497dbcd15c8888f66cd7a3920d7a949
WinCPP [Mon, 20 Mar 2017 19:58:55 +0000 (01:28 +0530)]
Issue dotnet/coreclr#7060 - Make StreamReader.ReadBuffer non-virtual
Commit migrated from https://github.com/dotnet/coreclr/commit/
121d11e2d086219d92b3791ebc1b3f2727aae038
Joseph Tremoulet [Mon, 20 Mar 2017 19:39:46 +0000 (15:39 -0400)]
Permit null object in `GenTreeUseEdgeIterator`
We use `GT_FIELD` for static field loads, which have no instance pointer.
Update the iterator constructor to recognize this as a valid state rather
than fail an assertion.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ffe7ea09fc7cb027cf832520090974de09947881
Bruce Forstall [Mon, 20 Mar 2017 19:09:36 +0000 (12:09 -0700)]
Merge pull request dotnet/coreclr#10315 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
0097b99d215927ee9be083f7acdc4129679624d2
Jan Kotas [Sun, 19 Mar 2017 02:41:39 +0000 (19:41 -0700)]
Fix FileStream for ProjectN
[tfs-changeset: 1651325]
Commit migrated from https://github.com/dotnet/coreclr/commit/
40fee095de80676ffb6e60bd2e9d38d85bfa40b3
Bruce Forstall [Mon, 20 Mar 2017 18:45:47 +0000 (11:45 -0700)]
Remove message about falling to default for MethodContext::repGetEEInfo()
[tfs-changeset: 1651465]
Commit migrated from https://github.com/dotnet/coreclr/commit/
4e4105d1bad1c15bc10dce037055ea5f749d8196
Brian Sullivan [Mon, 20 Mar 2017 17:34:10 +0000 (10:34 -0700)]
Merge pull request dotnet/coreclr#10301 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
8ada92875cba27ab5336dfad88f2ae9ffc101dad
Gaurav Khanna [Mon, 20 Mar 2017 17:32:34 +0000 (10:32 -0700)]
Initial document on AssemblyLoadContext Design (dotnet/coreclr#10271)
* Initial document on AssemblyLoadContext Design
Commit migrated from https://github.com/dotnet/coreclr/commit/
149a455cb6c46d793cc5be33d34142c118564086
Brian Sullivan [Mon, 20 Mar 2017 17:24:17 +0000 (10:24 -0700)]
Merge pull request dotnet/coreclr#10262 from briansull/refactor2
Updates for the handling of Profile data in the JIT
Commit migrated from https://github.com/dotnet/coreclr/commit/
f07554b48c4be3b3eef0b6a2b7f1d42eb4b053e4
Atsushi Kanamori [Mon, 20 Mar 2017 17:03:26 +0000 (10:03 -0700)]
Make GetModuleHandle() sharable. (dotnet/coreclr#10309)
Commit migrated from https://github.com/dotnet/coreclr/commit/
05e35b9e4edb317ec0fcfbe622ae3d7621ef5ae4
Gaurav Khanna [Mon, 20 Mar 2017 15:55:56 +0000 (08:55 -0700)]
Merge pull request dotnet/coreclr#9445 from hqueue/arm/ci
[ARM/CI] ARM CI script for arm and armel
Commit migrated from https://github.com/dotnet/coreclr/commit/
803961628736e38cc095b3e54d8ab30160b52a4a
Atsushi Kanamori [Mon, 20 Mar 2017 15:18:45 +0000 (08:18 -0700)]
Reconciles Type.cs with CoreRT version for move to shared partition. (dotnet/coreclr#10306)
* Clone files and add resource strings.
* Subset each partial class.
* String=>string and Environment.GetResourceString => SR.cs
Doing this upfront with reduce the upcoming diffs - hopefully.
* Add IsRuntimeImplemented() emulator.
* One method was put in the wrong file. Correcting.
* Converted Type.Enum.cs to CoreRT style member by member.
* Converted Type.Helpers.cs to CoreRT style member by member.
* Internalize __Filter.cs into Type.Helpers.cs
* Pretransform to reduce diffs.
Removed contracts and comments,
"abstract public" -> "public abstract"
* Converted Type.cs to CoreRT style member by member.
* Eh.. rather not share IsInterface and IsSerializable than have that #if CORECLR.
* Transplant the CoreRt files (now just a reordering.)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7c77fffac0ea7399a2f7dbf217b5ea804c0c1ad0
Steve MacLean [Mon, 20 Mar 2017 15:17:05 +0000 (11:17 -0400)]
[Arm64/Unix] Set PROCFS_* available in tryrun (dotnet/coreclr#10255)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a54f3dfe63eaf3a813541fc3387f683d84099d93
Bruce Forstall [Mon, 20 Mar 2017 02:46:08 +0000 (19:46 -0700)]
Desktop side of the change to remove COR_JIT_EE_VERSION
1. Bring over the JIT-EE interface file changes,
2. Stop building ctpjit.dll, and delete its build rules,
3. Stop building skipjit.dll.
[tfs-changeset: 1651372]
Commit migrated from https://github.com/dotnet/coreclr/commit/
4ddfdefc0fe2c7f48ff3f2ead52e43ddaa831058
Tarek Mahmoud Sayed [Sun, 19 Mar 2017 23:19:56 +0000 (16:19 -0700)]
Invariant globalization (dotnet/coreclr#10264)
* Invariant Globalization Work
* Convert the testing Exceptions to asserts
* Remove un-needed comment
* Fix typos
* Fix unrelated typo
* Address the PR feedback
* More feedback addressing
* More feedback addressing
* Fix Linux break
* More feedback addressing
* cleanup
Commit migrated from https://github.com/dotnet/coreclr/commit/
d905f67f12c6b2eed918894e0642ec972a1d9fec
Stephen Toub [Sun, 19 Mar 2017 12:06:20 +0000 (08:06 -0400)]
Merge pull request dotnet/coreclr#10291 from dotnet-bot/master-UpdateDependencies
Update CoreClr to beta-25119-02 (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
389b9abd4b109c68addca3bd215ab7626f84bb3d
dotnet-bot [Sun, 19 Mar 2017 08:08:34 +0000 (08:08 +0000)]
Update CoreClr to beta-25119-02
Commit migrated from https://github.com/dotnet/coreclr/commit/
401b40b5d5cf654dc1b68c7fb9e9a52458af89a4
Bruce Forstall [Sun, 19 Mar 2017 06:35:05 +0000 (23:35 -0700)]
Fix code to build with older VC++ compiler (dotnet/coreclr#10281)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8b99922f32596822b14d3d62e8c54fca5b19f257
John Bottenberg [Sun, 19 Mar 2017 04:33:58 +0000 (21:33 -0700)]
Remove potential overflow in SafeBSTRHandle (dotnet/coreclr#10182)
Commit migrated from https://github.com/dotnet/coreclr/commit/
671701167d2dc8f0297f08c67482b565684d8c79
Jonghyun Park [Sun, 19 Mar 2017 04:32:57 +0000 (13:32 +0900)]
Fix a typo in exceptoinhandling.cpp (dotnet/coreclr#10237)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ee5350ca1c1a848e0f9f82473dbdaf7f1edc1a4c
Maoni Stephens [Sun, 19 Mar 2017 04:30:55 +0000 (21:30 -0700)]
I hoisted the accounting for LOH into allocate_large_objects to avoid missing counting in certain stages during bgc when we go through bgc_loh_alloc_clr instead of adjust_limit_clr (dotnet/coreclr#10284)
Commit migrated from https://github.com/dotnet/coreclr/commit/
fc3220f19a8ee8266e0782bf8878790453f790e6
Atsushi Kanamori [Sat, 18 Mar 2017 22:15:43 +0000 (15:15 -0700)]
Fix for Module.GetMethod(string) (dotnet/coreclr#10283)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f22e55bf30580c4e518aaf1c94c31e79297370c6
Stephen Toub [Sat, 18 Mar 2017 21:40:09 +0000 (17:40 -0400)]
Merge pull request dotnet/coreclr#10280 from dotnet-bot/master-UpdateDependencies
Update CoreClr to beta-25118-03 (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8d3683664fafdbad91a5d3e84e7984c2b32fee13
Jan Kotas [Sat, 18 Mar 2017 20:57:24 +0000 (13:57 -0700)]
Merge pull request dotnet/coreclr#10272 from dotnet/mirror-merge-9051754
Mirror changes from dotnet/corert
Commit migrated from https://github.com/dotnet/coreclr/commit/
b50562f5bc75461f88d4b996b7bcc2aefbab43bd
Joseph Tremoulet [Sat, 18 Mar 2017 18:06:54 +0000 (14:06 -0400)]
Merge pull request dotnet/coreclr#10216 from JosephTremoulet/SpanBench
Update SpanBench test
Commit migrated from https://github.com/dotnet/coreclr/commit/
455d57cb8e660e92f5b8f6e4b218c8c4e2cac693
dotnet-bot [Sat, 18 Mar 2017 16:37:23 +0000 (16:37 +0000)]
Update CoreClr to beta-25118-03
Commit migrated from https://github.com/dotnet/coreclr/commit/
e35bd4757a03faba02dd082f8c88e9f60dd9716e
Joseph Tremoulet [Thu, 16 Mar 2017 00:43:01 +0000 (20:43 -0400)]
Update SpanBench test
- Re-enable the tests that were disabled in
e859c309.
- Re-work how tests are invoked from the command line to require less
boilerplate
- Now each test has a single [Benchmark] entrypoint
- That entrypoint invokes its test's single inner-loop by wrapping it
in a lambda that it passes to a new helper Invoke method (shared
across all tests) which handles the xunit vs. command-line
differences..
- Main finds the entrypoints by using reflection to search for the
[Benchmark] attributes, so the explicit list of stringified test
names is no longer needed and the command line will run the same
set of tests that xunit-perf does.
- The new SpanAPI tests now get invoked when this tests is run from the
command line as well.
- Add [NoInlining] to the SpanAPI tests' kernels.
- Add some heap writes and conditional writes to prevent deadcode
optimization from eliminating tests' kernels (assuming we don't do
interprocedural constant propagation or deadcode, or store sinking and
final value calculation, or PRE...).
- Split the Index SpanAPI tests into one version that uses a
loop-invariant index and thus should get hoisted out of the loop, and
another version that uses variant indices.
Commit migrated from https://github.com/dotnet/coreclr/commit/
65226a257f173edc03de3b4b43d001f801d0b379
Pat Gavlin [Sat, 18 Mar 2017 15:41:40 +0000 (08:41 -0700)]
Merge pull request dotnet/coreclr#10054 from pgavlin/GenTreeUseEdgeIterator
Improve GenTreeUseEdgeIterator.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1f3865737c52ca75329e1597a575e07faa33188