Alexander Galazin [Fri, 24 May 2019 08:50:49 +0000 (10:50 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Iaf1958f4db9588eba3ea77b4a1e7d41b4fc20c13
Alexander Galazin [Fri, 24 May 2019 07:48:11 +0000 (09:48 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Ided1b0de70eddb65bb70983ed341435dc3a99621
Jeff Bolz [Fri, 7 Dec 2018 01:38:40 +0000 (19:38 -0600)]
Waiver for device-scope core memory model tests.
https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/1356
Components: Vulkan
Affects: dEQP-VK.memory_model.*core11*.device.*
Change-Id: Ibf5d1ca0232471246ac16a9491d9ae54d87c74a8
Alexander Galazin [Wed, 22 May 2019 10:21:27 +0000 (12:21 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Ibdcd0cae47c3eca35db283b67a62e21de81e5cf3
Ilkka Saarelainen [Wed, 15 May 2019 12:01:14 +0000 (15:01 +0300)]
Add GeometryPointSize feature check
Some tests were using gl_PointSize without checking if the
shaderTessellationAndGeometryPointSize feature is supported and enabled.
This CL adds the feature checks to those tests. If the feature is not
supported/enabled, an alternative geometry shader code without
gl_PointSize will be used.
Affects:
dEQP-VK.glsl.*geometry
dEQP-VK.ycbcr.*geometry*
dEQP-VK.query_pool.*
dEQP-VK.transform_feedback.simple.streams_pointsize*
Components: Vulkan
VK-GL-CTS issue: 1763
Change-Id: If58bb5129144bae8d51dca84a3d0c89b46be1343
(cherry picked from commit
d4b80f34b70ae497b6bb0573859209ae28197a35)
Ilkka Saarelainen [Wed, 15 May 2019 12:01:14 +0000 (15:01 +0300)]
Add GeometryPointSize feature check
Some tests were using gl_PointSize without checking if the
shaderTessellationAndGeometryPointSize feature is supported and enabled.
This CL adds the feature checks to those tests. If the feature is not
supported/enabled, an alternative geometry shader code without
gl_PointSize will be used.
Affects:
dEQP-VK.glsl.*geometry
dEQP-VK.ycbcr.*geometry*
dEQP-VK.query_pool.*
dEQP-VK.transform_feedback.simple.streams_pointsize*
Components: Vulkan
VK-GL-CTS issue: 1763
Change-Id: If58bb5129144bae8d51dca84a3d0c89b46be1343
(cherry picked from commit
d4b80f34b70ae497b6bb0573859209ae28197a35)
Alexander Galazin [Wed, 22 May 2019 06:46:41 +0000 (08:46 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Iaaff1bd558b7938a73c553c312f8271a8e288cd3
Toni Merilehti [Wed, 15 May 2019 14:49:42 +0000 (17:49 +0300)]
Add feature checks to shader builtin tests
Some shader builtin tests use SampleId and SamplePosition BuiltIns
in shaders, which both require the SampleRateShading OpCapability
and the sampleRateShading Vulkan feature. This CL adds the missing
feature checks when required by the shaders.
Affects:
dEQP-VK.pipeline.multisample_shader_builtin.sample_id.*
dEQP-VK.pipeline.multisample_shader_builtin.sample_position.*
Components: Vulkan
VK-GL-CTS issue: 1744
Change-Id: I4557b5cd79191f7ca1202562416d12d3b1d8ce60
(cherry picked from commit
3f2ce1e5bcf568fe0a65a4ed638e0589b8694482)
Chris Forbes [Fri, 17 May 2019 15:48:42 +0000 (08:48 -0700)]
Check for imageCubeArray feature in image tests
Components: Vulkan
Affects: dEQP-VK.image.*cube_array*
VK-GL-CTS Issue: #1781
Change-Id: Idbf3e96481336820520a46293ca3eaf74b21654d
Chris Forbes [Thu, 16 May 2019 00:18:47 +0000 (17:18 -0700)]
Check for required features in memory model tests
All of these tests expect to be able to write to storage buffers; check
for the vertexPipelineStoresAndAtomics or fragmentStoresAndAtomics
features as appropriate.
VK-GL-CTS Issue: 1777
Components: Vulkan
Affects: dEQP-VK.memory_model.*
Change-Id: I51adeda82ba7af22368c239a6abfc481479700f1
Bas Nieuwenhuizen [Thu, 2 May 2019 21:13:14 +0000 (23:13 +0200)]
Fix image sizes for formats that need a multiple of 2.
All these have in their format definition something like
"Images in this format must be defined with a width that is a multiple
of two."
in their format definition.
This patch makes sure we actually use even sizes for images with these
formats.
It is not ideal that I have to hardcode these lists but I don't know a
better source to get them from.
Affects:
dEQP-VK.api.invariance.random
Components: Vulkan
VK-GL-CTS issue: 1766
Change-Id: Ie19583db56e7ae483136e1fb4651ae625efb9c02
Alexander Galazin [Mon, 20 May 2019 10:24:42 +0000 (12:24 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I7cb87c9d21e2ba725b199ee59663ece150333993
Alexander Galazin [Mon, 20 May 2019 09:40:23 +0000 (11:40 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I782d2f2d769d92e11f7e558cdefb56d187fe53e6
Alexander Galazin [Mon, 20 May 2019 08:58:43 +0000 (10:58 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I0fd601c9fc32f66eb7e45322801a930d4f33c4dc
Alexander Galazin [Mon, 20 May 2019 08:12:17 +0000 (10:12 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Ib38bd02e2ed4c74ee845e19eb25b8de05fb0e312
Ari Suonpaa [Tue, 30 Apr 2019 10:36:09 +0000 (13:36 +0300)]
Check for largePoints feature and add 1px test variant
Pipeline multisample tests were using point size of 3
without checking for largePoints feature. Now the feature
is checked and a 1 pixel variant is also added.
Affects:
dEQP-VK.pipeline.multisample.*.primitive_point
New tests:
dEQP-VK.pipeline.multisample.*.primitive_point_1px
Components: Vulkan
VK-GL-CTS issue: 1739
Change-Id: I0eef68b8194a1026a98b19579d1d3c1b7f9c9cc7
(cherry picked from commit
c382ec855438509b201c4aa5eff6b730534f2f3c)
Boris Zanin [Thu, 16 May 2019 15:23:19 +0000 (17:23 +0200)]
Remove incorrect unroll_dont_unroll test
According SPIR-V validator: Unroll and DontUnroll
loop controls must not both be specified.
Remove tests:
* dEQP-VK.spirv_assembly.instruction.compute.loop_control.unroll_dont_unroll
Affects:
* dEQP-VK.spirv_assembly.instruction.compute.loop_control.*
VK-GL-CTS issue: 1779
Change-Id: Ib799f96a290bb08df1175f1dc6f6d212314665af
Chris Forbes [Wed, 15 May 2019 17:38:01 +0000 (10:38 -0700)]
Don't set sampleShadingEnable in dEQP-VK.pipeline.framebuffer_attachment.*
These tests don't need per-sample shading, and didn't check for whether
it was supported by the device.
Components: Vulkan
Affects: dEQP-VK.pipeline.framebuffer_attachment.*ms
VK-GL-CTS Issue: 1776
Change-Id: Ic8477262410e1531c1acabe494c2cf64c199dd6b
Lingfeng Yang [Fri, 8 Feb 2019 15:36:00 +0000 (07:36 -0800)]
Fix stack underflow in incremental present test
This uses the current object's m_queueFamilyIndex instead of a queue
family index that is on the stack, avoiding using a stale stack address
when the test runs.
VK-GL-CTS issue: 1585
Affects:
dEQP-VK.wsi.*.incremental_present.*
Components: Vulkan
Change-Id: I80228651b799d3444676cdcbf5cc845bcb195fe9
(cherry picked from commit
a268922558ed0c353a7d8b6845f8d6279b72af29)
Alexander Galazin [Fri, 10 May 2019 10:06:12 +0000 (12:06 +0200)]
Update fetch_sources.py to Python 3
Components: Framework
Change-Id: I7f75a084e5128b1a19be7649a06a315e91a36688
(cherry picked from commit
9c4f100a056b084876e874a1b115192225b9a61a)
Graeme Leese [Mon, 14 Jan 2019 19:01:56 +0000 (19:01 +0000)]
Tests for VK_KHR_uniform_buffer_standard_layout
Enables the existing std430 UBO tests based on support for the
extension.
Components: Vulkan
Affects: dEQP-VK.ubo.*.std430.*
Change-Id: I224377696979eea0ac8ca0b3f190414909ddc0a8
(cherry picked from commit
00a15d59264d0853c5d9ef2a0178293f536a3d29)
Alexander Galazin [Fri, 10 May 2019 06:14:38 +0000 (08:14 +0200)]
Whitelist Vulkan CTS 1.1.4.1
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: Iad3e3c27e48585dc2143f8bf800a4ed56d9f2f01
Alexander Galazin [Thu, 9 May 2019 18:40:58 +0000 (20:40 +0200)]
Update gen_framework_c.py for python3
Components: Framework
Change-Id: If332d1f79f6f861fd49d16ee700967bdcf80b598
Alexander Galazin [Thu, 9 May 2019 18:02:47 +0000 (20:02 +0200)]
Update SPIR-V Tools
Components: Framework
Change-Id: I6f5971307e97ed55bd7c2164a94dd997784e0105
Alexander Galazin [Tue, 23 Apr 2019 19:09:43 +0000 (21:09 +0200)]
Require Python 3
Require Python 3 as some components used by the CTS already need it.
Update SPIR-V Tools: Fixes build issues on Windows and OpUnreachable validation.
Components: Framework, AOSP, Vulkan, OpenGL
Affects: dEQP-VK.*, builds
VK-GL-CTS issue: 1665
VK-GL-CTS issue: 1627
VK-GL-CTS issue: 1716
Change-Id: I719574b50aa16fdb0d06e85981a029ae8e0c4416
(cherry picked from commit
b1e5e376ccb021339741c927f99d9c2378ecc6cc)
Eric Werness [Tue, 20 Nov 2018 17:34:06 +0000 (09:34 -0800)]
Update generate scripts for python3
Components: Framework
Change-Id: Ia3db51e520ffbab7613f9948f23e6320b2815462
(cherry picked from commit
c7ebd5a8c32ae0b16789fc700d62502a5891aeae)
Eric Werness [Fri, 16 Nov 2018 21:50:40 +0000 (13:50 -0800)]
Support Python3 as well in gen_release_info.py
The CMake file version check can end up picking python3 in some cases -
making the Python code compatible with python3 seems easier than
adjusting the version check.
Components: Frameworks
Change-Id: Iab37090ab813dcb7839490225ca2a4bf2f721c12
(cherry picked from commit
f1bcdd5e9df1f83cc9dc4ef7235d3da16e9f7fab)
Alexander Galazin [Thu, 9 May 2019 09:46:54 +0000 (11:46 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Icae001e33d6a01954a6461d38bc8226abb48775e
Alexander Galazin [Thu, 9 May 2019 09:15:26 +0000 (11:15 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I015156c0e368515b0cecc70775a82a5537baa341
Slawomir Cygan [Mon, 29 Apr 2019 11:45:02 +0000 (13:45 +0200)]
Fix regression in subgroups tests after merging
393912cd
This extends the additional verification to catch uninitialized memory from
commit
393912cd to tests added in 1.1.3, so after
393912cd.
This fixes regression that occured on master after
393912cd was merged.
Components: Vulkan
VK-GL-CTS Issue: 1757
Change-Id: Icb7fe91ee2839626d8ebc90ae2788f85b0e835b7
Affects: dEQP-VK.subgroups.basic.framebuffer.*tess*
Matthew Netsch [Thu, 25 Apr 2019 18:41:15 +0000 (14:41 -0400)]
Fixes linear support check for pipeline tests
Removes old workaround for certain formats
Components: Vulkan
VK-GL-CTS Issue: 1755
Affects:
dEQP-VK.pipeline.sampler.*
Change-Id: Ia35303f11132f84560f06c13c7a94e3f9be888db
Chris Forbes [Fri, 3 May 2019 20:53:14 +0000 (13:53 -0700)]
Check for depthBiasClamp feature before using it
VK-GL-CTS Issue: 1764
Affects: dEQP-VK.dynamic_state.rs_state.depth_bias_clamp
Change-Id: Iccd05a1eac2285125847a392c4065d36c88cb426
Chris Forbes [Wed, 1 May 2019 14:43:48 +0000 (07:43 -0700)]
Check for imageCubeArray support before using VK_IMAGE_VIEW_TYPE_CUBE_ARRAY
VK-GL-CTS Issue: 1761
Components: Vulkan
Affects: dEQP-VK.binding_model.shader_access.*cube_array*
Change-Id: I918227d1518c3d7f6cefd7931531aafb34fcf9f8
Alexander Galazin [Sun, 28 Apr 2019 12:33:14 +0000 (14:33 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Ief71fa1e4d028988c1e5bc9c0d477787c8a1fcd6
Alexander Galazin [Sun, 28 Apr 2019 08:36:59 +0000 (10:36 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I71fc7f7b5ccaf55f0ad0ec40d4e0720bebbabb50
Graeme Leese [Tue, 9 Apr 2019 11:25:19 +0000 (12:25 +0100)]
Reduce expected precision of RGB10A2 filtering
The code in the YCbCr tests says that it was copied from the texture
explicit lod tests, but those tests give rgb10a2 a 'low' precision, not
'fp16'. Reduce the precision expected in the YCbCr tests.
Components: Vulkan
VK-GL-CTS Issue: 1731
Affects: dEQP-VK.ycbcr.*
dEQP-VK.protected_memory.interaction.ycbcr.*
Change-Id: Ib0ae233fc271ded2f9987fe448dcd351e509a0c4
(cherry picked from commit
5deebf4709ed3e2c3aaad3b8bb8703f236309b97)
Carl Ritson [Thu, 14 Mar 2019 16:25:30 +0000 (16:25 +0000)]
Fix memory initialisation in subgroups tests
Subgroup tests expand memory allocations to accommodate std140 layout
shaders; however, the extra memory is not initialised.
This changes initialisation to be based on the actually allocated
buffer size and adds additional verification to catch uninitialised
memory.
Affects:
dEQP-VK.subgroups.*
Components: Vulkan
VK-GL-CTS Issue: 1639
Change-Id: I0dfc0abb9bcbe63b5d1d5ad43e6fee99389fdfa2
Matthew Netsch [Wed, 24 Apr 2019 16:02:30 +0000 (12:02 -0400)]
Fixes pipeline tests to check for maxSamplerLodBias
Components: Vulkan
VK-GL-CTS Issue: 1750
Affects:
dEQP-VK.pipeline.sampler.*
Change-Id: I1ed594f0eb5cf8e249eda5eb31b114f1bfb93fd2
Alexander Galazin [Wed, 24 Apr 2019 05:59:25 +0000 (07:59 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I558e81a43c829769f170c4b26f3b290d88cf708e
Alexander Galazin [Tue, 23 Apr 2019 18:10:25 +0000 (20:10 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: If4d754edf8a5c942ebf51fcbb3a71d87bfbc7856
Alexander Galazin [Tue, 23 Apr 2019 17:13:22 +0000 (19:13 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I578c423d59f3c21357dd6f448f68cee5b46a98d0
Alexander Galazin [Tue, 23 Apr 2019 16:47:53 +0000 (18:47 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I4e639df46cf1f19a0bde8a061fa54d0bc1f7732d
Dan Sinclair [Mon, 15 Apr 2019 19:55:23 +0000 (15:55 -0400)]
Roll Amber.
This Cl rolls the Amber version to pickup the removal of
CopyBitsOfValueToBuffer which is triggering alignment errors on certain
platforms.
d26ee22 Unify buffer sizes. (#465)
dd5b5e6 Convert ProbeSSBO to use Format objects. (#464)
ee7662c Add doc/engines.md (#463)
d84f541 Convert BufferCommand to use Format. (#462)
e8302e1 Dawn engine: refactor (#455)
5299cf3 Move Format up into base Buffer class (#461)
847634a Use Format instead of DatumType where possible. (#460)
e968f5c AmberScript and README updates (#459)
d4e543b Add Buffer::GetFormat (#458)
ae06ff8 Simplify Format::GetBytesize; rename to SizeInBytes (#457)
b322b20 [vulkan] Allow setting vertex buffer with a data buffer (#450)
43248b2 [AmberScript] Add DERIVE_PIPELINE (#453)
5397303 Dawn engine: Adapt to latest Dawn API. (#454)
77b90e8 Update Dawn config file (#440)
6a39267 [vulkan] copy fb data onto device (#452)
7f72bbf [vulkan] Add a write framebuffer state; cleanup (#449)
a8acd2e Generate a Format from a DataBuffer. (#448)
da78976 [vulkan] TransferImage knows current layout and stage (#445)
1f834b8 [amberscript] Add REPEAT command (#443)
1806fc6 [amberscript] Fix BUFFER commands in examples (#447)
135cef4 Add EXPECT EQ_BUFFER command (#444)
c5afcf2 Add amber overview doc (#442)
3ba9e39 [vulkan] simplify image transition code. (#441)
VK-GL-CTS issue: 1735
Components: Framework
Affects: dEQP-VK.*
Change-Id: If13ab968d26aec30c7a5bf4ebde952e6947c00fa
(cherry picked from commit
532f56f72878c4b1ba4230debc90e0bafe51b4b5)
Boris Zanin [Thu, 11 Apr 2019 08:07:12 +0000 (10:07 +0200)]
Add float 16 calculation into FMA tests
Add one more calculation flavor into calculation
Float16 FMA tests.
Updates:
* dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic*.fma
* dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic*.fma*
Components: Vulkan
VK-GL-CTS issue: 1730
Change-Id: Ic3c378a75d23afcafb0f6ce7052351d70d4d30bc
(cherry picked from commit
67a010acd731667bcf067652d11ba494f0afff95)
Juan A. Suarez Romero [Mon, 15 Apr 2019 16:39:12 +0000 (16:39 +0000)]
Create YCbCr with PREDEFINED layout
This fixes validation errors due mismatch with the expected initial
layout.
Affects:
* dEQP-VK.ycbcr.conversion.*
Components: Vulkan
VK-GL-CTS issue: 1737
Change-Id: If30f5ebb73529850c6bbafcd8e42bed6143864c3
(cherry picked from commit
bcfe10d9aa5dbdb05296a5891e358b3581288845)
Chris Forbes [Mon, 15 Apr 2019 23:03:23 +0000 (16:03 -0700)]
Check for geometry shader support when testing adjacency topologies
Clipping tests would attempt to create pipelines using adjacency
topologies without checking for geometry shader support.
This seems to be a benign failure on most real implementations, but is a
VU violation.
Affects: dEQP-VK.clipping.clip_volume.*
VK-GL-CTS Issue: 1738
Change-Id: Iac6cfc6a669f2e533ce8ceaf4e7c2448b9fe4883
(cherry picked from commit
9c97d200e33e781ebb9f85df1195bcb84e013833)
ygole [Wed, 27 Mar 2019 11:38:37 +0000 (17:08 +0530)]
Add hasDisplay check after createWsiDisplay throws
Commit
b7efacd7b3 (Check if CTS has platform display for wsi-type) added
checks after createWsiDisplay failure to prevent reporting test failure
if native display for requested wsi-type isn't avaiable. This situation
can occur if vulkan driver supports multiple wsi extensions and only one
native display is available. Change did not fix all the places where
createWsiDisplay is called. The check is missing in file
vktImageMutableTests.cpp so fix it.
Affects: dEQP-VK.image.swapchain_mutable.*
Components: Vulkan, Framework
VK-GL-CTS issue: 1558
Change-Id: Iffc50a70ed48fb18c4d609c8d74b8e4615e4297d
(cherry picked from commit
984a7606ec93dfe90a17127357c7f0b0262bcd51)
Toni Merilehti [Thu, 11 Apr 2019 10:18:14 +0000 (13:18 +0300)]
Add feature checks to spirv assembly tests
Adds missing checks for vertexPipelineStoresAndAtomics and
fragmentStoresAndAtomics core device features to spirv assembly
tests when required by the shaders.
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.*
Components: Vulkan
VK-GL-CTS issue: 1725
Change-Id: I33af3faac948913f2f5ac7a4d385c323b00e5444
(cherry picked from commit
c71c2e3a5afa19c68c0ad9a03d18c06d2997b2c3)
Alexander Galazin [Fri, 22 Mar 2019 09:06:18 +0000 (10:06 +0100)]
Fix uninitialized variable reported by gcc 8.3
VK-GL-CTS issue: 1656
Components: Vulkan
Affects: dEQP-VK.sparse_resources.*
Change-Id: I298c795b05c0c204f04970da7a923f797c4478b8
(cherry picked from commit
1dadbfc46128054db7679bb662eba16b20a241c1)
Joan Orantos [Tue, 16 Apr 2019 13:42:20 +0000 (15:42 +0200)]
Fix element size for R16G16B16A16_UNORM.
The PlanarFormatDescription set for this format
was specifying 16 bytes instead of 8. This would
generate wrong input image on the test group
dEQP-VK.ycbcr.conversion.r16*
Components: Vulkan
Affects:
dEQP-VK.ycbcr.conversion.r16*
VK-GL-CTS issue: 1740
Change-Id: Ic364128febaa3b85b9ade767049e4f4f3f894357
Alexander Galazin [Tue, 16 Apr 2019 10:23:41 +0000 (12:23 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I9a6fa607958cf6864cec912aa0bfc6edf27224cf
Matthew Netsch [Fri, 5 Apr 2019 20:19:29 +0000 (16:19 -0400)]
Fixed buffer memory type for protected test
Components: Vulkan
VK-GL-CTS issue: 1727
Affects:
dEQP-VK.protected_memory.*
Change-Id: I07c5a57591f37aff558e3a634faa45ab33b2f776
Chris Forbes [Mon, 15 Apr 2019 23:03:23 +0000 (16:03 -0700)]
Check for geometry shader support when testing adjacency topologies
Clipping tests would attempt to create pipelines using adjacency
topologies without checking for geometry shader support.
This seems to be a benign failure on most real implementations, but is a
VU violation.
Affects: dEQP-VK.clipping.clip_volume.*
VK-GL-CTS Issue: 1738
Change-Id: Iac6cfc6a669f2e533ce8ceaf4e7c2448b9fe4883
Alexander Galazin [Thu, 11 Apr 2019 13:51:07 +0000 (15:51 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I39a8a2632e2dbc8f2cd7165b8ce614287de79e66
Alexander Galazin [Thu, 11 Apr 2019 12:46:34 +0000 (14:46 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I22ee52a20ef76af09b9e9ae5c4f7e8ee7073025c
Samuel Iglesias Gonsálvez [Fri, 5 Apr 2019 14:40:30 +0000 (16:40 +0200)]
Missing format checks for vertex attribute and color attachments in input_ouput tests
Input_output tests were not checking that the vertex attribute formats
were supported by the physical device. Added a similar check for the color
attachment.
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.*input_output*
Components: Vulkan
VK-GL-CTS issue: 1726
Change-Id: I2987deeafc8d3cc119730993fcb30fb191be062c
Alexander Galazin [Fri, 5 Apr 2019 11:00:13 +0000 (13:00 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Iea26f0e9f9c0d8b69d99fa4b0763269f420858df
Alexander Galazin [Fri, 5 Apr 2019 10:58:45 +0000 (12:58 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I1e1913b4571e7a001879b3a0a597eafc0f48d828
Nikita Bart [Wed, 27 Mar 2019 13:13:00 +0000 (14:13 +0100)]
Handle BUFFER_DYNAMIC and UPDATE_AFTER_BIND interaction
"descriptorset_random" tests were violating the spec's requirement that
bindings with VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT_EXT bit
cannot be used with BUFFER_DYNAMIC descriptor types in one set.
Testing of UPDATE_AFTER_BIND bindings is disabled
in order to conform to the requirement.
Fix validation of inline UBO with variable descriptor count
When used with variable descriptor count inline UBO's were read
and written out of allocated size, which is set in
VkDescriptorSetVariableDescriptorCountAllocateInfoEXT.descriptorCount
Components: Vulkan
Affects: dEQP-VK.binding_model.descriptorset_random.*
VK-GL-CTS issue: 1708
Change-Id: I9e97b701897961aedf8a746b72a1070ccd3b04e7
Alexander Galazin [Thu, 4 Apr 2019 18:52:34 +0000 (20:52 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Iae6020003b47aa1903dfc1f9917383de6a33fb57
Alexander Galazin [Thu, 4 Apr 2019 18:52:02 +0000 (14:52 -0400)]
Merge "Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3" into vulkan-cts-1.1.3
Alexander Galazin [Wed, 3 Apr 2019 16:23:33 +0000 (18:23 +0200)]
Blacklist 1.0.2.x versions
1.0.2.x is withdrawn. Recent drivers shouldn't advertise these versions.
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: I5e7417d0561381dd0365edef9f17609cc5f2a5aa
Alexander Galazin [Thu, 4 Apr 2019 18:22:37 +0000 (20:22 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I353dac50e06609d2783125bf22aee21f27c9939a
Anthony Pesch [Tue, 26 Mar 2019 16:24:17 +0000 (12:24 -0400)]
Fix buffer RAW hazards in MultiQueue synchronization tests
The MultiQueue tests emit barriers between command buffers for two reasons:
1. To express the data dependencies between different pipeline stages.
2. To transfer ownership of the resource between queue families.
The exclusive sharing mode tests need both of these barriers, while the
concurrent mode tests only need to describe the data dependency.
Previously, a barrier was only emitted for the exclusive tests, causing
the concurrent tests to not have a barrier expressing the data dependencies
between the pipeline stages. Now the data dependencies are described for
both the exlusive and concurrent tests, while the ownership transfer is
only performed for exclusive tests.
Affects: dEQP-VK.synchronization.op.multi_queue.*.write_*_read_*.buffer_*
Components: Vulkan
VK-GL-CTS issue: 1650
Change-Id: Ic3bc83a7dcab8686754aea5267afeb10090038d0
(cherry picked from commit
93dc8a343c7ea67a2c8ffb694b45ff44703fbe6f)
Boris Zanin [Wed, 3 Apr 2019 10:14:26 +0000 (12:14 +0200)]
Fix damage binary length field in shadercacheSave
Hash cache collision does not mean that binary
would be of same length.
Function shadercacheSave does not account it and
overwrites original binary length with cached
binary length.
Components: Framework
VK-GL-CTS issue: 1717
Change-Id: Iaabce787725c584b9735e959b572ca7667addde4
(cherry picked from commit
7871b6a8e263e1fddefbdbfbf1ca19e657f384ec)
Alexander Galazin [Thu, 4 Apr 2019 09:05:26 +0000 (11:05 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I0944cd90d64d01363cdbf8ce6b1007987bf7857c
Piers Daniell [Wed, 3 Apr 2019 20:20:09 +0000 (14:20 -0600)]
Don't disown Win32 handle after import
For Win32 fences and semaphores, the Vulkan implementation does not take
ownership of the handle after import. It is up to the application to
maintain ownership while the handle is in use and to call
CloseHandle() after.
Affects:
dEQP-VK.api.external.*.opaque_win32*
Components: Vulkan
VK-GL-CTS issue: 1720
Change-Id: I4e26ef53c9bf27c30efd71992fd02a574f81b3a0
Alexander Galazin [Wed, 3 Apr 2019 07:32:20 +0000 (09:32 +0200)]
Whitelist Vulkan CTS 1.1.4.0
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: I575178442d938a776ab32c1c5e965246324e8cec
Alexander Galazin [Wed, 3 Apr 2019 07:17:40 +0000 (09:17 +0200)]
Whitelist Vulkan CTS 1.1.3.2
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: Ia9ecc8dad3b2a37212d19f1878abb02095c22298
(cherry picked from commit
38db037997d48eca9ed86bdd134430ab03ff5ef6)
Alexander Galazin [Wed, 3 Apr 2019 07:17:40 +0000 (09:17 +0200)]
Whitelist Vulkan CTS 1.1.3.2
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: Ia9ecc8dad3b2a37212d19f1878abb02095c22298
Alexander Galazin [Tue, 2 Apr 2019 18:06:00 +0000 (20:06 +0200)]
Update SPIRV-Tools
Components: Framework
Affects: dEQP-VK.*
Change-Id: Ifcbd09e61a49fa0981091c176e6cf2b7bcaf98b7
Boris Zanin [Tue, 26 Mar 2019 10:34:38 +0000 (11:34 +0100)]
Avoid check vulkan core features in compute tests
Remove graphics features requirements from check
in compute shaders. This is particulary useful if
tests are targeted both in compute and graphics
pipelines, but in graphics also require certain
additional features.
Affects tests:
* dEQP-VK.spirv_assembly.instruction.compute.*
Components: vulkan
VK-GL-CTS issue: 1667
Change-Id: Ia9b039c404611a35b5ee878278dbe6fa175e40f9
Mika Väinölä [Fri, 29 Mar 2019 12:20:24 +0000 (14:20 +0200)]
Fix image layouts in SPIR-V image sampler tests
Use the same image layout in VkDescriptorImageInfo and
copyBufferToImage.
Affects:
dEQP-VK.spirv_assembly.instruction.compute.image_sampler.imagefetch.*
Components: Vulkan
VK-GL-CTS issue: 1542
Change-Id: I001b9d9ce7ee349c15c4c72d2b78557bbff40b86
Mika Väinölä [Fri, 29 Mar 2019 13:33:56 +0000 (15:33 +0200)]
Add *.qpa to .gitignore
Tell git to ignore test result log files. Remove unnecessary
TestResults.qpa from project root.
VK-GL-CTS issue: 1710
Change-Id: Ied98b5ba3bd839a5ceff8fe5ee1303e36406f531
Alexander Galazin [Fri, 29 Mar 2019 11:31:21 +0000 (12:31 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: Ia79528e30236521e7a3b0284b95709c31b523a11
Alexander Galazin [Fri, 29 Mar 2019 11:01:20 +0000 (12:01 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Iac3d5efdad7fe20709154ca4ed6d05fdea11f8a8
Alexander Galazin [Fri, 29 Mar 2019 10:15:10 +0000 (11:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: Ic01781a17482429ea152af7df5ff752a2226b568
Samuel Iglesias Gonsálvez [Wed, 20 Mar 2019 11:33:33 +0000 (12:33 +0100)]
Add tests for VK_EXT_host_query_reset
Added tests for Occlusion, Statistics and Timestamp queries.
New tests:
dEQP-VK.pipeline.timestamp.*host_query_reset*
dEQP-VK.query_pool.*host_query_reset*
Components: Vulkan
VK-GL-CTS issue: 1653
Change-Id: Ic828de11bd0782bed75833a252a1b07a066aa635
Igor Ostrowski [Tue, 12 Mar 2019 10:36:10 +0000 (11:36 +0100)]
Add handle compatibility check in win32 keyed mutex tests
Affects:
dEQP-VK.synchronization.win32_keyed_mutex.*
Components: Vulkan
VK-GL-CTS issue: 1669
Change-Id: I1ce4edae009d291100725fce9d87ae6ac826c4ae
Boris Zanin [Mon, 25 Mar 2019 17:06:01 +0000 (18:06 +0100)]
Move VkRunner tests to Amber
CTS will use Amber as the shader test engine.
Thus this commit does:
* move existing VkRunner tests to Amber
* remove VkRunner from the CTS source
Affects tests:
* dEQP-VK.graphicsfuzz.*
Components: vulkan
VK-GL-CTS issue: 1663
Change-Id: Ie3d17ec6f2eea79b777261f7c022fa7c5d0a965f
Mohd Faisal [Tue, 19 Mar 2019 14:45:56 +0000 (14:45 +0000)]
Fixed dEQP-VK.binding_model.descriptor_copy.* issues.
Added missing check for number of maxBoundDescriptorSets
allowed, and fixed not copy the same binding in same
descriptorSet.
Affects:
dEQP-VK.binding_model.descriptor_copy.*
Components: Vulkan
VK-GL-CTS issue: 1664
Change-Id: I69bdb45174c61da3afaa0b323f2598a56d7895c8
Alexander Galazin [Thu, 28 Mar 2019 12:55:31 +0000 (08:55 -0400)]
Revert "Simplify the combination passed to vkCreateImage"
This reverts commit
8b8dc08b3487d8abebedd12a264736e304264910.
Change-Id: I51bf04f47ce13673fd26244ba0507bd633f261b2
Courtney Goeltzenleuchter [Wed, 13 Mar 2019 00:05:29 +0000 (18:05 -0600)]
Check for getPlatformDisplay support before using
I was under the impression that NativeDisplay::CAPABILITY_GET_DISPLAY_PLATFORM
meant that we know the capability exists. But that apparently isn't
true.
Instead treat that as a flag to enable checking for the capability.
Don't really see the point of the capability bit if I have to check
anyway.
Affects: Android
KHR-GLES32.info.*
Pretty much any test running on EGL 1.4 device.
Components: Framework, AOSP
Change-Id: I49e36918bc231c08e1a473fe99e5086f54416850
Jari Komppa [Mon, 25 Feb 2019 13:07:45 +0000 (15:07 +0200)]
Optimize format flag fetch function
This fixes one old TODO in vktApiFeatureInfo by optimizing several array
traversals into a single one.
Affects:
dEQP-VK.api.info.format_properties.*
Components: Vulkan
VK-GL-CTS issue: 1624
Change-Id: I2b0e603e20e8adb27620754e0ca9a0b9d102d01f
Boris Zanin [Fri, 22 Mar 2019 14:24:36 +0000 (15:24 +0100)]
Limit transient images tests
Transient images (images that usage field contains the flag bit
VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) can be used only in
conjunction with following usages (according to specification):
* VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
* VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT
* VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
The tests falsely attempts to create images with layout:
* VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL
* VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL
Such layout requires images to be created with usages:
* VK_IMAGE_USAGE_TRANSFER_SRC_BIT
* VK_IMAGE_USAGE_TRANSFER_DST_BIT
that's prohibited for transient images.
If underlying image is transient, it is invalid for it to be a
TRANSFER_SRC or TRANSFER_DST. Do not allow tests for transient
images to use such layouts.
Affected tests:
* dEQP-VK.renderpass.*.attachment.*
* dEQP-VK.renderpass2.*.attachment.*
Components: vulkan
VK-GL-CTS issue: 1545
Change-Id: Ibd1635d15419adcb646fbc1daf030a2736b972b1
Toni Merilehti [Tue, 19 Mar 2019 14:38:16 +0000 (16:38 +0200)]
Reduce memory usage in point size clamping tests
Win32 builds running dEQP-VK.rasterization.primitive_size.points.*
caused resource errors when using 16384 x 16384 render targes due to
large memory allocations.
This optimization changes the rendering format from R8G8B8A8 to
a single-channel format R8_UNORM, reduces the sizes of the render
targets on the last two test cases to 10240 x 10240 and 9216 x 9216,
and removes one unnecessary result buffer copy to reduce memory
allocation.
Affects:
dEQP-VK.rasterization.primitive_size.points.*
Components: Vulkan
VK-GL-CTS issue: 1649
Change-Id: I5d9f435961f0cd56f8b520ac7e98cece1d4f73d7
Daniel Koch [Mon, 18 Mar 2019 15:49:33 +0000 (11:49 -0400)]
Update glslang
Component: Framework
VK-GL-CTS Issue: 1698
Change-Id: I63d45cfc317f99fbf7d16b43f489f93863a02f14
Hsin-Hsiao Lin [Tue, 26 Mar 2019 08:14:02 +0000 (09:14 +0100)]
Do not expect bit-exact results on float
For float outputs annotated with RelaxedPrecision or with NoPerspective,
check them against an epsilon range, 6E-8, which is 0x0001 in fp16.
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.*
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.*
Components: vulkan
VK-GL-CTS issue: 1670
Change-Id: I98454826a3f4afccd655b0228839970ba0213793
Daniel Koch [Tue, 26 Mar 2019 22:54:18 +0000 (18:54 -0400)]
Remove "using namespace glu" from header
since this is a bad coding practise and can cause
issues when other files include it.
Affects: - (compilation only)
Component: OpenGL
Change-Id: I6809dcc7f0f12a9fde1b329889727708628798e3
David Neto [Tue, 12 Feb 2019 20:00:03 +0000 (15:00 -0500)]
Add scalar uint with signed int compares as Amber cases
Logs an error and throws an exception if the script fails to parse.
Components: Vulkan
Affects:
dEQP-VK.spirv_assembly.instruction.compute.signed_int_compare.uint_sgreaterthan
dEQP-VK.spirv_assembly.instruction.compute.signed_int_compare.uint_sgreaterthanequal
dEQP-VK.spirv_assembly.instruction.compute.signed_int_compare.uint_slessthan
dEQP-VK.spirv_assembly.instruction.compute.signed_int_compare.uint_slessthanequal
VK-GL-CTS issue: 1147
Change-Id: Ic8ce35bff0e05360dc9e674cce313d441e2f4953
Ari Suonpaa [Thu, 7 Feb 2019 07:06:08 +0000 (09:06 +0200)]
Add scissor tests
This adds more coverage for scissoring. In particular
tests for multiple scissors and zero area scissor
were added. Attachment clears are also mixed with
draw commands to verify they are not scissored.
New tests:
dEQP-VK.draw.scissor.*
Components: Vulkan
VK-GL-CTS issue: 1580
Change-Id: I7a7ee221d23d836fbb8fc2d1556fb533b5b41ab6
Piotr Byszewski [Mon, 17 Dec 2018 11:53:50 +0000 (12:53 +0100)]
Additional coverage for color resolve
This change extracts base class out of existing MultisampleRender-
PassTestInstance and reuses it for the second set of tests.
New tests are ment to check cases where application consumes
all available on-chip memory (maxColorAttachments attachments).
Note that tests are executed for 4, 8 and 16 attachments since
framework does not allow to query maxColorAttachments before
test creation and this is needed to preper proper shaders.
Components: Vulkan
VK-GL-CTS issue: 1496
Affects:
dEQP-VK.renderpass.suballocation.multisample_resolve.*
dEQP-VK.renderpass2.suballocation.multisample_resolve.*
Change-Id: I14f39e7185a2930506dc8352fce8ac2896b317ae
Ari Suonpaa [Fri, 22 Mar 2019 07:18:53 +0000 (09:18 +0200)]
Disable pipeline_create_only when running Amber tests
Amber test framework didn't initialize pipeline_create_only
in Amber options. This resulted in Amber tests only checking
if pipeline was created successfully. All test commands
were left unexecuted and tests were passing even when
they were modified to fail.
Affects:
-
Components: Vulkan, Framework
VK-GL-CTS issue: 1659
Change-Id: I657d4e162d6bbc7bf6a5b41bd5bac7ddaf4dbf78
Toni Merilehti [Wed, 13 Mar 2019 11:36:05 +0000 (13:36 +0200)]
Check shaderFloat16 support in 16bit_storage.*64*
Require shaderFloat16 feature in
dEQP-VK.spirv_assembly.instruction.*.16bit_storage.*64* tests when
using VK_KHR_shader_float16_int8 device extension. Tests now throw
NotSupported if VK_KHR_shader_float16_int8 extension is enabled but
shaderFloat16 is not supported by the device.
Affects:
dEQP-VK.spirv_assembly.instruction.*.16bit_storage.*64*
Components: Vulkan
VK-GL-CTS issue: 1643
Change-Id: I79b271f131571805e6dacb87fa3620039021eedb
Alexander Galazin [Fri, 22 Mar 2019 20:13:10 +0000 (21:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: I62d7ebcc0c2cb2a2adc9c1d8f910c499b3504b7f
Alexander Galazin [Fri, 22 Mar 2019 20:11:55 +0000 (21:11 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I4f48c3e9ca8593777c5a4ef6cd32050f8c839043
Alexander Galazin [Fri, 22 Mar 2019 20:10:39 +0000 (21:10 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I328cee295acc9eb8c5204e5f3574879d9e21a609
Alexander Galazin [Fri, 22 Mar 2019 19:49:07 +0000 (20:49 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: If24571c09fd321c8417da919af0d2272a0ac2c57
Tony Zlatinski [Tue, 12 Feb 2019 16:50:28 +0000 (10:50 -0600)]
cmake: Add support for PNG_ARM_NEON_OPT NDK-r19
On Android, here is clang compiler change for
NDKs after ndk-r17c where the compiler intrinsics
for libpng are not part of the compiler for the
armeabi-v7a targets.
Add the supported png functions for these compiler
intrinsics, explicitly for 32-bit ARM builds.
Affects:
dEQP-VK.*
Components: Vulkan, Framework
VK-GL-CTS issue: 1638
Change-Id: Ib832f983294f5dd747720ed4a79a21e29a06f776
(cherry picked from commit
99a88af740c425bf250ce9cb2143aa6be3a778f2)
Alexander Galazin [Fri, 22 Mar 2019 09:06:18 +0000 (10:06 +0100)]
Fix uninitialized variable reported by gcc 8.3
VK-GL-CTS issue: 1656
Components: Vulkan
Affects: dEQP-VK.sparse_resources.*
Change-Id: I298c795b05c0c204f04970da7a923f797c4478b8