Yang Tse [Fri, 16 Sep 2011 19:55:13 +0000 (21:55 +0200)]
curl tool: add new files to Symbian's .mmp project file
Yang Tse [Fri, 16 Sep 2011 19:44:45 +0000 (21:44 +0200)]
curl tool: move 'Configurable' and free_config_fields() to tool_cfgable.[ch]
Reviewing fields being free'd in free_config_fields() still pending
Yang Tse [Fri, 16 Sep 2011 19:12:32 +0000 (21:12 +0200)]
src/setup.h: add conditional include of assert.h
Yang Tse [Fri, 16 Sep 2011 17:46:01 +0000 (19:46 +0200)]
curl tool: move so called 'multi_files' stuff into tool_mfiles.[ch]
Additionally some code reorganization and direct OOM handling fixes,
just another step towards fixing curl tool issues uncovered 2011-09-15
Yang Tse [Fri, 16 Sep 2011 13:31:29 +0000 (15:31 +0200)]
curl tool: move convert_* functions into tool_convert.[ch]
Additionally fix data type of result vars for iconv() calls
Yang Tse [Thu, 15 Sep 2011 22:57:54 +0000 (00:57 +0200)]
main.c: convert GetStr() into a macro to ease leak debugging
Yang Tse [Thu, 15 Sep 2011 22:36:21 +0000 (00:36 +0200)]
main.c: de-obfuscate a couple for-loop exit conditions
Yang Tse [Thu, 15 Sep 2011 18:03:30 +0000 (20:03 +0200)]
curl tool: fix a bunch of double free's uncovered 2011-09-15
Re-enabling MemoryTracking capability on 'src' subdirectory files and torture
tests have uncovered many issues which were going unnoticed in curl tool. So
here we go fixing some of them. Others still remain and should be addressed
ASAP, given that curl tool is used in our test harness also for test server
start verification purposes. There are even non-socket file descriptor leaks.
Yang Tse [Thu, 15 Sep 2011 15:35:23 +0000 (17:35 +0200)]
Make Curl_safefree() macro assign NULL to given pointer when free'd
Yang Tse [Thu, 15 Sep 2011 09:40:54 +0000 (11:40 +0200)]
curl MSVC project files: adjust resource compiler include path
Yang Tse [Wed, 14 Sep 2011 18:31:23 +0000 (20:31 +0200)]
src/Makefile.vc6: adjust resource compiler include path
Yang Tse [Wed, 14 Sep 2011 09:27:12 +0000 (11:27 +0200)]
curl tool: re-enable MemoryTracking capability on 'src' subdirectory files.
Use same preprocessor logic for curl tool MemoryTracking activation in source
files located in 'src' subdirectory as the one used for libcurl sources.
Yang Tse [Wed, 14 Sep 2011 08:36:29 +0000 (10:36 +0200)]
ftp.c: add a couple of failure messages
warp kawada [Thu, 8 Sep 2011 22:39:39 +0000 (15:39 -0700)]
Curl_add_custom_headers: support headers with no data
A custom HTTP header ending in a semicolon instead of a colon
will be treated as a header to be added without any data
portion.
Daniel Stenberg [Tue, 13 Sep 2011 20:47:34 +0000 (22:47 +0200)]
progressfunc: a simple CURLOPT_PROGRESSFUNCTION example
Daniel Stenberg [Tue, 13 Sep 2011 18:04:03 +0000 (20:04 +0200)]
7.22.1: start working
Daniel Stenberg [Tue, 13 Sep 2011 18:03:17 +0000 (20:03 +0200)]
THANKS: 16 new contributors from 7.22.0
Daniel Stenberg [Tue, 13 Sep 2011 16:53:00 +0000 (18:53 +0200)]
RELEASE-NOTES: ready for 7.22.0
Daniel Stenberg [Tue, 13 Sep 2011 16:46:09 +0000 (18:46 +0200)]
codestyle: minor whitespace fix
Jeff Pohlmeyer [Tue, 13 Sep 2011 16:44:41 +0000 (18:44 +0200)]
polarssl: build with PolarSSL-1.0.0
With this fix, it should work for PolarSSL-1.0.0 (and SVN-1091 trunk)
and retain compatibility with earlier versions. (Tested with 0.14.1)
PolarSSL still doesn't play nicely with curl's CA bundle (we discussed
this before) but I was at least able to retrieve the
https://www.gmail.com/ login page using a modified ca-certificates.crt
file with all 3 versions of PolarSSL.
Daniel Stenberg [Tue, 13 Sep 2011 11:05:31 +0000 (13:05 +0200)]
BUGS: spellfixed, slightly reformatted for web looks
Reported by: Jeff Pohlmeyer
Dan Fandrich [Mon, 12 Sep 2011 21:45:22 +0000 (14:45 -0700)]
Document NTLM winbind options (and caveats)
Daniel Stenberg [Mon, 12 Sep 2011 21:02:41 +0000 (23:02 +0200)]
BUGS: renumbered to look better in the web version
Daniel Stenberg [Mon, 12 Sep 2011 20:55:40 +0000 (22:55 +0200)]
BUGS: revamped bug report documentation
Yang Tse [Mon, 12 Sep 2011 14:01:07 +0000 (16:01 +0200)]
Mention that BSD-style lwIP TCP/IP stack support on Windows is experimental.
Yang Tse [Mon, 12 Sep 2011 13:16:07 +0000 (15:16 +0200)]
ftp.c: fix socket leak torture tests detected 2011-08-30
Also fix inappropriate error handling when sending ftp EPRT or PORT commands.
Daniel Stenberg [Sun, 11 Sep 2011 13:51:38 +0000 (15:51 +0200)]
TODO: remove 4 entries, add one new
Zero-copy and "Avoid having to remove/readd handles" are not really
features we think are worthwhile to add. Removed.
SRP features have been added already, removed.
11.9 IPv6 addresses with globbing added
Daniel Stenberg [Sun, 11 Sep 2011 13:42:11 +0000 (15:42 +0200)]
spell-checked comments
Daniel Stenberg [Sun, 11 Sep 2011 13:31:01 +0000 (15:31 +0200)]
TODO-RELEASE: postpone the remainders
There's three pending bug fixes but there's no time left so let's
try to get them fixed for next release...
Guenter Knauf [Sun, 11 Sep 2011 14:49:28 +0000 (16:49 +0200)]
Updated makefiles to latest libssh2.
Yang Tse [Sat, 10 Sep 2011 16:46:05 +0000 (18:46 +0200)]
urlglob.c: fix OOM handling
Yang Tse [Sat, 10 Sep 2011 03:05:27 +0000 (05:05 +0200)]
ftp.c: fix ftp active connects which got broken with commit
fdf157abdf
Yang Tse [Fri, 9 Sep 2011 23:23:21 +0000 (01:23 +0200)]
runtests.pl: replace TAB with spaces
Yang Tse [Fri, 9 Sep 2011 23:14:52 +0000 (01:14 +0200)]
test harness: revert needless commit
0a5bbb2ac1
https, ftps and ssh servers allowed start up time back to previous values
Yang Tse [Fri, 9 Sep 2011 22:52:13 +0000 (00:52 +0200)]
ssh.c: revert needless commit
7b7c45879e
Daniel Stenberg [Fri, 9 Sep 2011 13:38:30 +0000 (15:38 +0200)]
RELEASE-NOTES: synced with
303c90074d4c
Five more bugfixes, one more contributor
Daniel Stenberg [Fri, 9 Sep 2011 13:20:31 +0000 (15:20 +0200)]
tcpnodelay: rename variable
Renamed the variable from 'proto' to 'level' simply because it is not
protocol you set but level and that is the name of the argument used in
man pages and the POSIX documentation of the setsockopt function.
Guenter Knauf [Thu, 8 Sep 2011 09:17:16 +0000 (11:17 +0200)]
Avoid ftruncate() static define with MinGW64.
Yang Tse [Thu, 8 Sep 2011 09:08:00 +0000 (11:08 +0200)]
libssh2: use calloc as alloc function for libssh2 versions older than 1.3
This workarounds old libssh2 versions not properly initializing
some ssh session variables, which would trigger memory debuggers
warnings on memory being used without having been initialized.
Adriano Meirelles [Thu, 8 Sep 2011 06:38:59 +0000 (08:38 +0200)]
Curl_speedcheck: don't mistakenly clear Curl_expire()
The current version of speedcheck.c may disable timeout by setting zero
to Curl_expire. Which is fine using the curl_multi_perform, because it
recheck all timeout internals, but when using custom event poller (like
hiperfifo.c) it may keep stalle connection forever.
Yang Tse [Wed, 7 Sep 2011 23:22:47 +0000 (01:22 +0200)]
lib582.c: fix segfault triggered when torture testing test case 582
Daniel Stenberg [Wed, 7 Sep 2011 20:46:06 +0000 (22:46 +0200)]
ftp_state_use_port: minor code indent fix
Daniel Stenberg [Wed, 7 Sep 2011 20:45:43 +0000 (22:45 +0200)]
checksrc: detect "}else" uses as well
Daniel Stenberg [Wed, 7 Sep 2011 20:43:28 +0000 (22:43 +0200)]
getinmemory.c: use better argument names for write callback
Yang Tse [Tue, 6 Sep 2011 23:26:43 +0000 (01:26 +0200)]
ssh.c: fix memory leaks triggered upon OOM or other failures
Yang Tse [Tue, 6 Sep 2011 17:59:42 +0000 (19:59 +0200)]
test case 583: ensure that test failures don't go unnoticed - follow-up
Yang Tse [Tue, 6 Sep 2011 16:11:11 +0000 (18:11 +0200)]
test suite: libtest header inclusion cleanup - follow-up
Adjust tests/libtest/Makefile.inc and remove a couple of unused headers from
tests/libtest/lib583.c
Yang Tse [Tue, 6 Sep 2011 15:56:39 +0000 (17:56 +0200)]
test case 583: ensure that test failures don't go unnoticed
Yang Tse [Tue, 6 Sep 2011 15:47:54 +0000 (17:47 +0200)]
test suite: libtest header inclusion cleanup
Added missing memoryTracking to test cases 560 and 583. If this triggers
leak detection on these, it only means that previously it was going unnoticed.
Yang Tse [Mon, 5 Sep 2011 23:57:21 +0000 (01:57 +0200)]
fix bool variables checking and assignment
Yang Tse [Mon, 5 Sep 2011 21:45:04 +0000 (23:45 +0200)]
pingpong.c: avoid a memmove call in function Curl_pp_vsendf
Yang Tse [Mon, 5 Sep 2011 18:46:09 +0000 (20:46 +0200)]
fix bool variables checking and assignment
Yang Tse [Mon, 5 Sep 2011 10:39:50 +0000 (12:39 +0200)]
test suite: use test case specific netrc file names
Guenter Knauf [Sun, 4 Sep 2011 20:04:45 +0000 (22:04 +0200)]
Fixed final message output.
Daniel Stenberg [Sun, 4 Sep 2011 17:41:34 +0000 (19:41 +0200)]
TODO-RELEASE: deleteing five issues due to no response
No feedback and no updates, removing these issues
Yang Tse [Sun, 4 Sep 2011 15:09:22 +0000 (17:09 +0200)]
setup_once.h cleanup and sync
Guenter Knauf [Sun, 4 Sep 2011 15:05:49 +0000 (17:05 +0200)]
Fix to skip untrusted certs.
Guenter Knauf [Sun, 4 Sep 2011 08:03:08 +0000 (10:03 +0200)]
Added SPNEGO to MinGW makefiles.
Yang Tse [Sat, 3 Sep 2011 23:56:30 +0000 (01:56 +0200)]
NTLM WB: fix file descriptor leak upon OOM condition
Yang Tse [Sat, 3 Sep 2011 16:26:21 +0000 (18:26 +0200)]
revert changes not intended to be pushed with commit
6b75d2c2
Yang Tse [Sat, 3 Sep 2011 14:06:10 +0000 (16:06 +0200)]
fix a bunch of MSVC compiler warnings
Guenter Knauf [Sat, 3 Sep 2011 12:01:09 +0000 (14:01 +0200)]
Updated dependecies versions.
Guenter Knauf [Sat, 3 Sep 2011 11:55:16 +0000 (13:55 +0200)]
Some MinGW makefile tweaks for MinGW64.
Guenter Knauf [Sat, 3 Sep 2011 11:37:29 +0000 (13:37 +0200)]
Changed MinGW to use own winidn prototypes.
Dan Fandrich [Fri, 2 Sep 2011 20:15:58 +0000 (13:15 -0700)]
Fix NTLM winbind support to pass the torture tests
Calling sclose() both in the child and the parent fools the
socket leak detector into thinking it's been closed twice.
Calling close() in the child instead overcomes this problem. It's
not as portable as the sclose() macro, but this code is highly
POSIX-specific, anyway.
Yang Tse [Fri, 2 Sep 2011 17:40:53 +0000 (19:40 +0200)]
MemoryTracking: fix logging of free() calls done where Curl_safefree is called
Just internal stuff...
Curl_safefree is now a macro defined in memdebug.h instead of a function
prototyped in url.h and implemented in url.c, so inclusion of url.h is no
longer required in order to simply use Curl_safefree.
Provide definition of macro WHILE_FALSE in setup_once.h in order to allow
other macros such as DEBUGF and DEBUGASSERT, and code using it, to compile
without 'conditional expression is constant' warnings.
The WHILE_FALSE stuff fixes 150+ MSVC compiler warnings.
Yang Tse [Fri, 2 Sep 2011 15:41:39 +0000 (17:41 +0200)]
transfer.c: fix parentheses/braces placement for vi/emacs delimiter matching
Yang Tse [Thu, 1 Sep 2011 22:06:19 +0000 (00:06 +0200)]
transfer.c: fix loadhostpairs() OOM handling
Yang Tse [Thu, 1 Sep 2011 20:21:57 +0000 (22:21 +0200)]
test harness: https, ftps and ssh servers allowed start up time increased 33%
Yang Tse [Thu, 1 Sep 2011 15:09:46 +0000 (17:09 +0200)]
hostip.c: return immediately from Curl_resolv_timeout() upon expired timeout.
Ensure existing logic in Curl_resolv_timeout() is not subverted upon getting a
negative timeout from resolve_server(). The timeout in resolve_server() could
be checked to avoid calling Curl_resolv_timeout() with an expired timeout, but
fixing this in this way allows existing logic in resolve_server() to be kept
unchanged.
Yang Tse [Thu, 1 Sep 2011 13:38:30 +0000 (15:38 +0200)]
ftp.c: fix some leaks torture tests detected 2011-08-30 - follow-up
follow-up for commit
d20408e8
Yang Tse [Wed, 31 Aug 2011 17:59:26 +0000 (19:59 +0200)]
test harness: fix detection of test harness client knownhosts file
Regenerate curl's tests client knownhosts file also when, somehow,
this file is empty.
Yang Tse [Wed, 31 Aug 2011 16:16:14 +0000 (18:16 +0200)]
test harness: fix detection of test harness host and client key files
Regenerate curl's tests host and client key files also when, somehow,
any of these files are empty.
Yang Tse [Wed, 31 Aug 2011 16:15:29 +0000 (18:15 +0200)]
ssh.c: fix realloc() OOM handling
Yang Tse [Wed, 31 Aug 2011 16:14:38 +0000 (18:14 +0200)]
ftp.c: fix some leaks torture tests detected 2011-08-30 - follow-up
follow-up for commit
c06de200
Yang Tse [Wed, 31 Aug 2011 01:50:07 +0000 (03:50 +0200)]
fix some leaks torture tests detected 2011-08-30
Yang Tse [Tue, 30 Aug 2011 23:58:06 +0000 (01:58 +0200)]
fix some leaks torture tests detected 2011-08-30
Daniel Stenberg [Mon, 29 Aug 2011 13:37:06 +0000 (15:37 +0200)]
RELEASE-NOTES: synced with
3445fa2e3f
Kamil Dudka [Fri, 26 Aug 2011 09:10:58 +0000 (11:10 +0200)]
tests: break busy loops in tests 502, 555, and 573
Yang Tse [Mon, 29 Aug 2011 12:27:06 +0000 (14:27 +0200)]
pingpong.c: fix Curl_pp_vsendf() arbitrary restrictions on command length
This removes command length restrictions on calling functions.
Yang Tse [Sun, 28 Aug 2011 09:29:09 +0000 (11:29 +0200)]
NTLM: header inclusion cleanup follow-up
Yang Tse [Sun, 28 Aug 2011 05:15:46 +0000 (07:15 +0200)]
NTLM: header inclusion cleanup
Yang Tse [Sun, 28 Aug 2011 00:00:02 +0000 (02:00 +0200)]
NTLM: END of refactoring/splitting/moving
First:
File curl_ntlm.h renamed curl_ntlm_msgs.h
File curl_ntlm.c renamed curl_ntlm_msgs.c
Afterwards:
File http_ntlm.c renamed curl_ntlm.c
File http_ntlm.h renamed curl_ntlm.h
Yang Tse [Sat, 27 Aug 2011 23:19:08 +0000 (01:19 +0200)]
NTLM: move NTLM core specifics into curl_ntlm_core.[ch]
Yang Tse [Sat, 27 Aug 2011 17:16:10 +0000 (19:16 +0200)]
NTLM_WB: move NTLM_WB specifics into curl_ntlm_wb.[ch]
Yang Tse [Sat, 27 Aug 2011 04:31:18 +0000 (06:31 +0200)]
NTLM_WB: final congruency naming adjustments
Configure script option --enable-wb-ntlm-auth renamed to --enable-ntlm-wb
Configure script option --disable-wb-ntlm-auth renamed to --disable-ntlm-wb
Preprocessor symbol WINBIND_NTLM_AUTH_ENABLED renamed to NTLM_WB_ENABLED
Preprocessor symbol WINBIND_NTLM_AUTH_FILE renamed to NTLM_WB_FILE
Test harness env var CURL_NTLM_AUTH renamed to CURL_NTLM_WB_FILE
Static function wb_ntlm_close renamed to ntlm_wb_cleanup
Static function wb_ntlm_initiate renamed to ntlm_wb_init
Static function wb_ntlm_response renamed to ntlm_wb_response
Yang Tse [Fri, 26 Aug 2011 23:32:49 +0000 (01:32 +0200)]
NTLM single-sign on adjustments (XI)
Feature string literal NTLM_SSO renamed to NTLM_WB.
Preprocessor symbol USE_NTLM_SSO renamed to WINBIND_NTLM_AUTH_ENABLED.
curl's 'long' option 'ntlm-sso' renamed to 'ntlm-wb'.
Fix some comments to make clear that this is actually a NTLM delegation.
Daniel Stenberg [Fri, 26 Aug 2011 21:23:07 +0000 (23:23 +0200)]
--cookie-jar: activates the cookie engine
Daniel Stenberg [Thu, 25 Aug 2011 20:42:02 +0000 (22:42 +0200)]
Curl_read_plain: indent code
Yang Tse [Fri, 26 Aug 2011 16:57:50 +0000 (18:57 +0200)]
NTLM single-sign on adjustments (X)
Functions renamed:
Curl_output_ntlm_sso -> Curl_output_ntlm_wb
sso_ntlm_close -> wb_ntlm_close
sso_ntlm_response -> wb_ntlm_response
sso_ntlm_initiate -> wb_ntlm_initiate
Preprocessor symbols renamed:
CURLAUTH_NTLM_SSO -> CURLAUTH_NTLM_WB
CURL_VERSION_NTLM_SSO -> CURL_VERSION_NTLM_WB
Daniel Stenberg [Thu, 25 Aug 2011 14:04:55 +0000 (16:04 +0200)]
TODO: progress callback without doubles
Steve Holme [Thu, 25 Aug 2011 13:09:30 +0000 (15:09 +0200)]
http NTLM: refactoring followup
Output of Curl_ntlm_create_type1_message() and Curl_ntlm_create_type3_message()
functions is now already base64 encoded.
Kamil Dudka [Wed, 24 Aug 2011 21:50:59 +0000 (23:50 +0200)]
docs: the next release is going to be 7.22.0
Yang Tse [Wed, 24 Aug 2011 12:00:42 +0000 (14:00 +0200)]
include limits.h for INT_MAX
Yang Tse [Wed, 24 Aug 2011 11:58:37 +0000 (13:58 +0200)]
add missing semicolons
Daniel Stenberg [Wed, 24 Aug 2011 09:56:23 +0000 (11:56 +0200)]
add missing semicolons
Daniel Stenberg [Wed, 24 Aug 2011 09:55:49 +0000 (11:55 +0200)]
safefree use: fix compiler warning
include the prototype header
Steve Holme [Wed, 24 Aug 2011 06:55:25 +0000 (08:55 +0200)]
SMTP authentication: fix ordering of preferred authentication method
Fixed the order of the preferred SMTP authentication method to:
AUTH CRAM-MD5, AUTH LOGIN then AUTH PLAIN.
AUTH PLAIN should be the last as it slightly more insecure than AUTH LOGIN
as the username and password are sent together - there is no handshaking
between the client and server like there is with AUTH LOGIN.
Yang Tse [Wed, 24 Aug 2011 06:07:36 +0000 (08:07 +0200)]
base64: fix Curl_base64_encode and Curl_base64_decode interfaces
Previous interfaces for these libcurl internal functions did not allow to tell
apart a legitimate zero size result from an error condition. These functions
now return a CURLcode indicating function success or otherwise specific error.
Output size is returned using a pointer argument.
All usage of these two functions, and others closely related, has been adapted
to the new interfaces. Relative error and OOM handling adapted or added where
missing. Unit test 1302 also adapted.
Daniel Stenberg [Tue, 23 Aug 2011 14:31:10 +0000 (16:31 +0200)]
resolve.c: new example showing off CURLOPT_RESOLVE