Chidambar Zinnoury [Mon, 21 Apr 2014 19:54:15 +0000 (21:54 +0200)]
Bugfix: e fileman: Correct automagic window size computation.
When available width is less than minimum width, the height was computed according to the available width, but the window width was effectively the minimum width: its height was thus more than needed.
The function now takes the minimum dimensions so that correct height and width are computed.
Chidambar Zinnoury [Mon, 21 Apr 2014 19:53:05 +0000 (21:53 +0200)]
Bugfix: e fileman: Correct typo on height computation.
Chidambar Zinnoury [Mon, 21 Apr 2014 17:36:37 +0000 (19:36 +0200)]
Bugfix: e fileman: Fixe information popup placement.
– Use zone coordinates on desktop icons to have the popup placed where it should be with multiple screens.
– Use correct window content coordinates to account for the client frame.
Chidambar Zinnoury [Mon, 21 Apr 2014 14:32:02 +0000 (16:32 +0200)]
Bugfix: e filepreview widget: Use correct units for devices sizes.
This will also make them consistent with file sizes.
Chidambar Zinnoury [Mon, 21 Apr 2014 13:50:57 +0000 (15:50 +0200)]
e xkbswitch: Add check changed.
Chidambar Zinnoury [Mon, 21 Apr 2014 13:50:09 +0000 (15:50 +0200)]
e xkbswitch: Align indentation.
Chidambar Zinnoury [Mon, 21 Apr 2014 13:29:39 +0000 (15:29 +0200)]
Bugfix: e xkbswitch: Disable both up and down buttons when there is only one configuration.
Chidambar Zinnoury [Mon, 21 Apr 2014 11:26:13 +0000 (13:26 +0200)]
e music-control: Add MPD support.
Chidambar Zinnoury [Mon, 21 Apr 2014 11:25:26 +0000 (13:25 +0200)]
e syscon: Add check changed.
Chidambar Zinnoury [Mon, 21 Apr 2014 11:24:50 +0000 (13:24 +0200)]
e system: Show units.
Chidambar Zinnoury [Mon, 21 Apr 2014 11:23:33 +0000 (13:23 +0200)]
e syscon: For user-friendliness, show “System Controls” instead of “Syscon” on labels.
Chidambar Zinnoury [Mon, 21 Apr 2014 07:18:27 +0000 (09:18 +0200)]
Bugfix: e fileman: Client coordinates are not accounted against current zone position, so we should use them when computing maximum width and height.
This helps computing optimal dimensions when using multiple screens.
Chidambar Zinnoury [Mon, 21 Apr 2014 07:16:34 +0000 (09:16 +0200)]
e fileman: Use a macro for minimum dimensions instead of hardcoding them at several places.
Chidambar Zinnoury [Mon, 21 Apr 2014 07:15:11 +0000 (09:15 +0200)]
Bugfix: e fileman: Typo on maximum height condition.
Chidambar Zinnoury [Mon, 21 Apr 2014 07:11:40 +0000 (09:11 +0200)]
e: It’s now 2014!
Carsten Haitzler (Rasterman) [Sat, 19 Apr 2014 00:08:02 +0000 (09:08 +0900)]
re-order icon finding for border to use the most reliable source first
Gwanglim Lee [Fri, 18 Apr 2014 16:51:36 +0000 (12:51 -0400)]
null check ecstack
Summary: fix segmentation fault error
Test Plan:
run enlightenment (wl only server) -> run elementary_test -> run terminlogy
-> move cursor to elementary_test -> click on elementary_test
Reviewers: raster, devilhorns, zmike
CC: cedric
Differential Revision: https://phab.enlightenment.org/D770
Carsten Haitzler (Rasterman) [Fri, 18 Apr 2014 00:53:00 +0000 (09:53 +0900)]
fix resent eo changes to e that break updating labels and toggles
this fixes D1172
Carsten Haitzler (Rasterman) [Fri, 18 Apr 2014 00:39:16 +0000 (09:39 +0900)]
formatting
Wonguk Jeong [Fri, 18 Apr 2014 00:35:43 +0000 (09:35 +0900)]
comp_x_screensaver: screensaver off bug fix
Summary:
Can not turn off screensaver due to condition check bug.
@fixes
Test Plan: enlightenment -> do nothing -> screen saver on -> mouse/key input -> check whether screen saver is turned off or not
Reviewers: raster, cedric, zmike
Reviewed By: raster
CC: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D766
Carsten Haitzler (Rasterman) [Thu, 17 Apr 2014 04:55:39 +0000 (13:55 +0900)]
fix screensaver/blanking issue where a ss on/off events come in together
Gwanglim Lee [Mon, 14 Apr 2014 12:32:51 +0000 (08:32 -0400)]
Fixed a problem with e wl server that sent invalid key value to wl client. (server-side)
Summary:
This problem occurred due to xkb_keysym_t value of libxkbcommon by e wl server.
e wl server should pass keycode from evdev input device on to wl client.
In order that e wl server receives valid keycode Ecore_Event_Key should have
an extended data member. This patch should be applied with client side patch (efl).
Test Plan: run e wl server -> create wl client -> type keys
Reviewers: raster, devilhorns, zmike
Reviewed By: devilhorns
CC: cedric
Differential Revision: https://phab.enlightenment.org/D713
Mike Blumenkrantz [Fri, 11 Apr 2014 17:40:58 +0000 (13:40 -0400)]
improve eolian build dependency
Mike Blumenkrantz [Fri, 11 Apr 2014 14:32:18 +0000 (10:32 -0400)]
make eolian files also depend on eolian_gen
Mike Blumenkrantz [Fri, 11 Apr 2014 00:15:07 +0000 (20:15 -0400)]
and update makefile for eolian
Mike Blumenkrantz [Fri, 11 Apr 2014 00:00:50 +0000 (20:00 -0400)]
apparently this is how we're doing eolian bin finding
Mike Blumenkrantz [Thu, 10 Apr 2014 23:26:32 +0000 (19:26 -0400)]
mfw I forget git add
..........................__......
.................,-~*`¯lllllll`*~,....
...........,-~*`llllllllllllllllll¯`*-,..
......,-~*lllllllllllllllllllllllllllll*-,.
...,-*llllllllllllllllllllllllllllllllll.\.
.;*`lllllllllllllllllllllllllll,-~*~-,llll\....
..\lllllllllllllllllllllllllll/......\;;;;,-`~-,.
...\lllllllllllllllllllll,-*....`~-~-,...(.(¯`*,`,.
....\llllllllllll,-~*..............)_-\..*`*;..).
.....\,-*`¯,*`)............,-~*`~.............../...
......|/.../.../~,......-~*,-~*`;................/.\..
...../.../.../.../..,-,..*~,.`*~*................*...\..
....|.../.../.../.*`...\...........................)....)¯`~,...
....|./.../..../.......)......,.)`*~-,............/....|..)...`~-,.
..././.../...,*`-,.....`-,...*`....,---......\..../...../..|...¯```*~-,,
...(..........)`*~-,....`*`.,-~*.,-*......|.../..../.../...............\.
....*-,.......`*-,...`~,..``.,,,-*..........|.,*...,*...|..............\.
.......*,.........`-,...)-,..............,-*`...,-*....(`-,............\.
..........f`-,.........`-,/...*-,___,,-~*....,-*......|...`-,..........\.
Mike Blumenkrantz [Thu, 10 Apr 2014 23:06:04 +0000 (19:06 -0400)]
fix ibox eo errors
Mike Blumenkrantz [Thu, 10 Apr 2014 22:45:20 +0000 (18:45 -0400)]
preserve client stacking after compositor effects
fix T1065
Mike Blumenkrantz [Thu, 10 Apr 2014 21:37:24 +0000 (17:37 -0400)]
comp_object now uses eo, e_comp_object_signal* -> edje_object_signal*
also cw->clip is gone
Wonguk Jeong [Thu, 10 Apr 2014 02:09:36 +0000 (11:09 +0900)]
efm: fix bugs during renaming multiple files and copying file into same directory
Summary:
Since E_FM_OP_OVERWRITE_RESPONSE_NO was sent before file renaming, src had been changed as next file.
->send E_FM_OP_OVERWRITE_RESPONSE_NO after file renaming.
File became empty if I copy a file into same directory
--> first of all, prevent move, rename, symlink into same directory. in case of copy, attach " (copy)" postfix after file name automatically. (need to decide postfix policy)
fixes T739
Reviewers: zmike, raster
CC: seoz, cedric
Maniphest Tasks: T739
Differential Revision: https://phab.enlightenment.org/D707
Mike Blumenkrantz [Fri, 4 Apr 2014 19:38:10 +0000 (15:38 -0400)]
fuck you gettext
Mike Blumenkrantz [Fri, 4 Apr 2014 19:26:11 +0000 (15:26 -0400)]
fix null deref in e_shelf
CID 1039825
Mike Blumenkrantz [Fri, 4 Apr 2014 19:21:58 +0000 (15:21 -0400)]
use e_util_strcmp() in e_font stuff
CID 1039827, 1039826
Mike Blumenkrantz [Fri, 4 Apr 2014 19:14:08 +0000 (15:14 -0400)]
reduce strstr use in xkb parser
CID 1039849
Mike Blumenkrantz [Fri, 4 Apr 2014 19:01:53 +0000 (15:01 -0400)]
null check xkb layout list
CID 1039869
Mike Blumenkrantz [Fri, 4 Apr 2014 18:56:11 +0000 (14:56 -0400)]
remove mixer wizard check
alsa is no longer the only output method, so this was a bogus check anyway
CID 1039872
Mike Blumenkrantz [Fri, 4 Apr 2014 18:53:06 +0000 (14:53 -0400)]
remove winlist dead code
CID 1039873
Mike Blumenkrantz [Fri, 4 Apr 2014 18:51:21 +0000 (14:51 -0400)]
bugfix: unify temp module temperature_get_bus_files() functions
CID 1039874
Mike Blumenkrantz [Fri, 4 Apr 2014 18:42:24 +0000 (14:42 -0400)]
bugfix: check notification icon size correctly
CID 1039875
Mike Blumenkrantz [Fri, 4 Apr 2014 18:33:15 +0000 (14:33 -0400)]
remove fileman dead code
CID 1039878
Mike Blumenkrantz [Fri, 4 Apr 2014 18:32:01 +0000 (14:32 -0400)]
simplify/improve evry files dead code and maybe fix or add a bug
CID 1039879
Mike Blumenkrantz [Fri, 4 Apr 2014 18:15:13 +0000 (14:15 -0400)]
bugfix: correctly check evry trigger matches
CID 1039880
Mike Blumenkrantz [Fri, 4 Apr 2014 18:11:24 +0000 (14:11 -0400)]
remove transition config dead code
CID 1039881
Mike Blumenkrantz [Fri, 4 Apr 2014 18:10:09 +0000 (14:10 -0400)]
remove font config dead code
CID 1039882
Mike Blumenkrantz [Fri, 4 Apr 2014 18:06:59 +0000 (14:06 -0400)]
remove impossible/unnecessary randr rotation checks
CID 1039944
Mike Blumenkrantz [Fri, 4 Apr 2014 18:04:36 +0000 (14:04 -0400)]
remove unnecessary battery check
CID 1039945
Mike Blumenkrantz [Fri, 4 Apr 2014 18:02:02 +0000 (14:02 -0400)]
remove a bunch of unused e_util edje icon functions
CID 1039948, 1039946
removals: e_util_*edje_icon_list*
Mike Blumenkrantz [Fri, 4 Apr 2014 17:53:49 +0000 (13:53 -0400)]
bugfix: comp config dialog correctly detects effects disabled/fast states
CID 1039957, 1039956
Mike Blumenkrantz [Fri, 4 Apr 2014 17:50:08 +0000 (13:50 -0400)]
check more pulse mixer returns
CID 1039959, 1039960
Mike Blumenkrantz [Fri, 4 Apr 2014 17:40:47 +0000 (13:40 -0400)]
check import config dialog unlink() return value
CID 1039964
Mike Blumenkrantz [Fri, 4 Apr 2014 17:38:38 +0000 (13:38 -0400)]
check rename() return value
CID 1039966
Mike Blumenkrantz [Fri, 4 Apr 2014 17:36:11 +0000 (13:36 -0400)]
check pulse mixer fd dup return
CID 1040123
Mike Blumenkrantz [Fri, 4 Apr 2014 17:30:56 +0000 (13:30 -0400)]
remove unused ibar variable set
CID 1155291, 1058715
Mike Blumenkrantz [Fri, 4 Apr 2014 17:29:34 +0000 (13:29 -0400)]
fix tiling memory corruption
CID 1186206
Mike Blumenkrantz [Fri, 4 Apr 2014 17:26:25 +0000 (13:26 -0400)]
e_bindings_key_allowed() handles NULL param
CID 1191998
Mike Blumenkrantz [Fri, 4 Apr 2014 17:25:05 +0000 (13:25 -0400)]
null check xkb parser
CID 1193251
Mike Blumenkrantz [Fri, 4 Apr 2014 17:19:24 +0000 (13:19 -0400)]
check pixmap_size_get() return in e_pointer
CID 1195448
Seunghun Lee [Thu, 3 Apr 2014 10:23:57 +0000 (19:23 +0900)]
fix crash when access pager_config which is null.
Summary:
crash was happend when user do logout the enlightenment with pager16.
pager_config was freed in e_modapi_shutdown(),
but after that, there was accessing pager_config again in _gc_shutdown() by called gadman_shutdown().
Reviewers: zmike, raster, cedric, seoz
CC: cedric
Differential Revision: https://phab.enlightenment.org/D694
Mike Blumenkrantz [Wed, 2 Apr 2014 18:16:34 +0000 (14:16 -0400)]
unify comp object stacking
these were nearly identical, and sooner or later there was going to be an unfortunate c/p error
Mike Blumenkrantz [Wed, 2 Apr 2014 17:06:28 +0000 (13:06 -0400)]
comp docs part 1: comp objects
Mike Blumenkrantz [Wed, 2 Apr 2014 16:31:33 +0000 (12:31 -0400)]
fix frame size calc check to account for themes with 0 height
Mike Blumenkrantz [Wed, 2 Apr 2014 15:07:22 +0000 (11:07 -0400)]
fix client layer marker detection/usage in wayland
this is the correct fix for D687
Seunghun Lee [Wed, 2 Apr 2014 13:27:13 +0000 (09:27 -0400)]
remove unused comp object variable use and function call in show helper
Reviewers: zmike
Differential Revision: https://phab.enlightenment.org/D686
Gwanglim Lee [Wed, 2 Apr 2014 09:39:07 +0000 (10:39 +0100)]
wl pointer configure: fix typo
Summary: ews->geometry.y needs to be set.
Test Plan: N/A
Reviewers: raster, devilhorns, zmike
Reviewed By: devilhorns
CC: cedric
Differential Revision: https://phab.enlightenment.org/D688
Stefan Schmidt [Tue, 1 Apr 2014 13:52:50 +0000 (15:52 +0200)]
po: Remove files for disabled wallpaper2 module to fix make distcheck
The wallpaper2 module got disabled by not includng its makefile anymore
which confused gettext as it still had two files listed for it.
Tom Hacohen [Mon, 31 Mar 2014 14:16:19 +0000 (15:16 +0100)]
Fix client border changing issues
The code was zeroing the flag that tells e to change the border after
the callbacks about frame changes. This means that one couldn't change
the border from within those callbacks. This commit fixes this issue.
Carsten Haitzler (Rasterman) [Mon, 31 Mar 2014 10:04:20 +0000 (19:04 +0900)]
disable wp2 module
fixes T954
maxerba [Sun, 30 Mar 2014 17:48:22 +0000 (19:48 +0200)]
Italian translation for Tiling profile
Mike Blumenkrantz [Fri, 28 Mar 2014 16:17:35 +0000 (12:17 -0400)]
bugfix: efm current .desktop fetching now returns the right .desktop
fix T792
Mike Blumenkrantz [Fri, 28 Mar 2014 16:17:00 +0000 (12:17 -0400)]
bugfix: swallow efm background objects after applying theme
fix T792
Mike Blumenkrantz [Fri, 28 Mar 2014 13:43:05 +0000 (09:43 -0400)]
stringshare_replace in fwin: it exists for a reason, stop using macros ffs
Mike Blumenkrantz [Fri, 28 Mar 2014 13:32:51 +0000 (09:32 -0400)]
bugfix: ibar now scrolls correctly during drags
fix T794
Stefan Schmidt [Fri, 28 Mar 2014 09:51:29 +0000 (10:51 +0100)]
music-control: Do not leak the allocated metadata strings
Fix for
ca07e7d505274377635fda2a79d8ac8c61877ea6
Thanks are going to Davide Andreoli for spotting it.
Stefan Schmidt [Fri, 28 Mar 2014 09:14:37 +0000 (10:14 +0100)]
modules/ibar: Fix condition check for edje emits
This fixes a copy and paste error which sneaked into
daa98e867d5340fac9ee087e637be38f653b01fe
CID 1194780
Mike Blumenkrantz [Fri, 28 Mar 2014 01:27:51 +0000 (21:27 -0400)]
never use new clients for stacking
fix Tcedric
Mike Blumenkrantz [Thu, 27 Mar 2014 23:47:31 +0000 (19:47 -0400)]
greatly improve child dialog placement, FIXME--
fix T980
Mike Blumenkrantz [Thu, 27 Mar 2014 21:01:22 +0000 (17:01 -0400)]
Revert "move comp object tiler creation to helper function to catch retries"
This reverts commit
f4e4b2fc4f0e9a1741f11bc945fb72c4b137ff9c.
testing commit that wasn't supposed to go upstream
Mike Blumenkrantz [Thu, 27 Mar 2014 20:54:58 +0000 (16:54 -0400)]
fix access module build
if nobody noticed this was even broken for 3 months, why is it still in the tree?
Mike Blumenkrantz [Thu, 27 Mar 2014 20:42:23 +0000 (16:42 -0400)]
ensure minimum X parent window size of 1x1
fix T1098
Mike Blumenkrantz [Thu, 27 Mar 2014 20:19:16 +0000 (16:19 -0400)]
move comp object tiler creation to helper function to catch retries
Mike Blumenkrantz [Thu, 27 Mar 2014 20:05:21 +0000 (16:05 -0400)]
don't refocus hidden clients on desk flip
probably fix T1083
Mike Blumenkrantz [Thu, 27 Mar 2014 20:02:27 +0000 (16:02 -0400)]
null check _evry_items_sort_func() for users with broken systems
fix T1125
Mike Blumenkrantz [Thu, 27 Mar 2014 19:58:39 +0000 (15:58 -0400)]
check key events for both key and keyname bindings
fix T1119
Mike Blumenkrantz [Thu, 27 Mar 2014 19:50:48 +0000 (15:50 -0400)]
ignore mouse movements on client during keyboard actions
fix T1097
Mike Blumenkrantz [Thu, 27 Mar 2014 19:45:45 +0000 (15:45 -0400)]
ignore X layer window mouse events
fix T1130
Mike Blumenkrantz [Thu, 27 Mar 2014 19:38:37 +0000 (15:38 -0400)]
always unclip/uneffect clients when changing desks
probably fix T1126
Mike Blumenkrantz [Thu, 27 Mar 2014 19:31:18 +0000 (15:31 -0400)]
redo input rects after comp effect layer changes
fix T1070
Mike Blumenkrantz [Thu, 27 Mar 2014 14:45:49 +0000 (10:45 -0400)]
remove invalid shelf autohide window check which would always be wrong
Mike Blumenkrantz [Thu, 27 Mar 2014 14:45:27 +0000 (10:45 -0400)]
disable comp object animation hooks if animations are disabled
Mike Blumenkrantz [Thu, 27 Mar 2014 13:59:48 +0000 (09:59 -0400)]
fix lots of edje emits on non-edje objects
Mike Blumenkrantz [Thu, 27 Mar 2014 13:29:56 +0000 (09:29 -0400)]
+e_icon_edje_get()
Stefan Schmidt [Thu, 27 Mar 2014 15:06:06 +0000 (16:06 +0100)]
tiling: Free allocated memory on error path.
We don't use new_node in this code path. Free before returning.
CID 1186205
Stefan Schmidt [Thu, 27 Mar 2014 11:47:21 +0000 (12:47 +0100)]
bugfix: music_control: Use correct markup for metadata text.
We piped the plain metadata text to edje TEXTBLOCK which might interpret
some of the characters as markup. Better convert it to the correct markup
first. The actual bug case was a & in the metadata cut off the rest of
the text. Now we get the correct & before sending it of to edje.
Fixes T1061
Gwanglim Lee [Thu, 27 Mar 2014 07:37:39 +0000 (07:37 +0000)]
Added a '--disable-wl-x11' to avoid build break since wl-x11 module has a dependency to ECORE_X_EVENT_XKB_STATE_NOTIFY
Summary: Resolved a build break when building e with wayland only options
Test Plan: building e with wayland only options
Reviewers: raster, devilhorns
Reviewed By: devilhorns
CC: cedric
Differential Revision: https://phab.enlightenment.org/D670
Carsten Haitzler (Rasterman) [Wed, 26 Mar 2014 06:32:53 +0000 (15:32 +0900)]
don't delete client objects when _e_client_hook_call returns false.
_e_client_hook_call() returns false when object refcount hit 0... ie..
it's been deleted. it's simply invalid memory access to then del the
object thats already gone to 0 refcount and been deleted/freed.
Carsten Haitzler (Rasterman) [Tue, 25 Mar 2014 13:44:04 +0000 (22:44 +0900)]
tasks - fix tasks on other screens to properly show all window content
this fixes T1120
Mike Blumenkrantz [Mon, 24 Mar 2014 16:36:29 +0000 (12:36 -0400)]
bump efl req version
Mike Blumenkrantz [Mon, 24 Mar 2014 16:33:48 +0000 (12:33 -0400)]
use eo to shut up harmless eo menu errors
Mike Blumenkrantz [Mon, 24 Mar 2014 16:32:06 +0000 (12:32 -0400)]
add eo headers, aka Captain #define